[kudu-CR] KUDU-2844 (2/3): move RowBlock memory into a new RowBlockMemory struct

2020-08-12 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15801 ) Change subject: KUDU-2844 (2/3): move RowBlock memory into a new RowBlockMemory struct .. Patch Set 4: Code-Review+2 -- To view,

[kudu-CR] KUDU-2612 p8: replay participant ops on bootstrap

2020-08-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16304 ) Change subject: KUDU-2612 p8: replay participant ops on bootstrap .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2612 p7: add transaction participants to tablets

2020-08-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16277 ) Change subject: KUDU-2612 p7: add transaction participants to tablets .. Patch Set 6: (2 comments) LGTM, but it seems IWYU isn't

[kudu-CR] KUDU-2844 (2/3): move RowBlock memory into a new RowBlockMemory struct

2020-08-12 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15801 ) Change subject: KUDU-2844 (2/3): move RowBlock memory into a new RowBlockMemory struct .. Patch Set 4: Verified+1 Test failure is

[kudu-CR] KUDU-2844 (2/3): move RowBlock memory into a new RowBlockMemory struct

2020-08-12 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change. Change subject: KUDU-2844 (2/3): move RowBlock memory into a new RowBlockMemory struct .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit

[kudu-CR] KUDU-2844 (1/3): make BlockHandle ref-counted

2020-08-12 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15800 ) Change subject: KUDU-2844 (1/3): make BlockHandle ref-counted .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-3180: prioritize larger mem-stores in time-based flusing

2020-08-12 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16319 ) Change subject: KUDU-3180: prioritize larger mem-stores in time-based flusing .. Patch Set 2: Code-Review+2 It'd be nice if you could

[kudu-CR] KUDU-2844 (1/3): make BlockHandle ref-counted

2020-08-12 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15800 ) Change subject: KUDU-2844 (1/3): make BlockHandle ref-counted .. Patch Set 2: Code-Review+1 (1 comment)

[kudu-CR] KUDU-3181: put a bound on the queue of compilation manager

2020-08-12 Thread Li Zhiming (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16330 to look at the new patch set (#4). Change subject: KUDU-3181: put a bound on the queue of compilation manager

[kudu-CR] KUDU-2844 (1/3): make BlockHandle ref-counted

2020-08-12 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15800 ) Change subject: KUDU-2844 (1/3): make BlockHandle ref-counted .. Patch Set 2: Verified+1 Test failure is likely unrelated:

[kudu-CR] KUDU-2844 (1/3): make BlockHandle ref-counted

2020-08-12 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change. Change subject: KUDU-2844 (1/3): make BlockHandle ref-counted .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/15800 To unsubscribe,

[kudu-CR] KUDU-3181: put a bound on the queue of compilation manager

2020-08-12 Thread Li Zhiming (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16330 to look at the new patch set (#3). Change subject: KUDU-3181: put a bound on the queue of compilation manager

[kudu-CR] KUDU-3181: put a bound on the queue of compilation manager

2020-08-12 Thread Li Zhiming (Code Review)
Li Zhiming has posted comments on this change. ( http://gerrit.cloudera.org:8080/16330 ) Change subject: KUDU-3181: put a bound on the queue of compilation manager .. Patch Set 2: (2 comments)

[kudu-CR] KUDU-3180: prioritize larger mem-stores in time-based flusing

2020-08-12 Thread Yifan Zhang (Code Review)
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/16319 ) Change subject: KUDU-3180: prioritize larger mem-stores in time-based flusing .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-3180: prioritize larger mem-stores in time-based flusing

2020-08-12 Thread Yifan Zhang (Code Review)
Hello Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16319 to look at the new patch set (#2). Change subject: KUDU-3180: prioritize larger mem-stores in time-based flusing

[kudu-CR] KUDU-2612 p8: replay participant ops on bootstrap

2020-08-12 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16304 ) Change subject: KUDU-2612 p8: replay participant ops on bootstrap .. Patch Set 3: (1 comment)

[kudu-CR] KUDU-2612 p8: replay participant ops on bootstrap

2020-08-12 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16304 to look at the new patch set (#3). Change subject: KUDU-2612 p8: replay participant ops on bootstrap

[kudu-CR] KUDU-2612 p7: add transaction participants to tablets

2020-08-12 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16277 to look at the new patch set (#6). Change subject: KUDU-2612 p7: add transaction participants to tablets

[kudu-CR] KUDU-2612 p7: add transaction participants to tablets

2020-08-12 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16277 ) Change subject: KUDU-2612 p7: add transaction participants to tablets .. Patch Set 6: (8 comments)

[kudu-CR] WIP KUDU-1587 part 1: load meter for ThreadPool

2020-08-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/16332 ) Change subject: WIP KUDU-1587 part 1: load meter for ThreadPool .. Patch Set 1: just did a quick skim over the patch, would be good to

[kudu-CR] KUDU-2612 p7: add transaction participants to tablets

2020-08-12 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16277 to look at the new patch set (#5). Change subject: KUDU-2612 p7: add transaction participants to tablets

[kudu-CR] WIP KUDU-1587 part 1: load meter for ThreadPool

2020-08-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16332 Change subject: WIP KUDU-1587 part 1: load meter for ThreadPool .. WIP KUDU-1587 part 1: load meter for ThreadPool This patch

[kudu-CR] KUDU-2844 (3/3): avoid copying plain/dict strings to RowBlock Arena

2020-08-12 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Andrew Wong, Kudu Jenkins, Andrew Wong, Volodymyr Verovkin, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15802 to look at the new patch set (#4). Change subject: KUDU-2844 (3/3): avoid copying plain/dict strings to RowBlock Arena

[kudu-CR] KUDU-2844 (1/3): make BlockHandle ref-counted

2020-08-12 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, Andrew Wong, Kudu Jenkins, Andrew Wong, Volodymyr Verovkin, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15800 to look at the new patch set (#2). Change subject: KUDU-2844 (1/3): make BlockHandle ref-counted

[kudu-CR] KUDU-2844 (2/3): move RowBlock memory into a new RowBlockMemory struct

2020-08-12 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Andrew Wong, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15801 to look at the new patch set (#4). Change subject: KUDU-2844 (2/3): move RowBlock memory into a new RowBlockMemory struct

[kudu-CR] KUDU-2844 (3/3): avoid copying plain/dict strings to RowBlock Arena

2020-08-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15802 ) Change subject: KUDU-2844 (3/3): avoid copying plain/dict strings to RowBlock Arena .. Patch Set 3: (4 comments)

[kudu-CR] KUDU-3180: prioritize larger mem-stores in time-based flusing

2020-08-12 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16319 ) Change subject: KUDU-3180: prioritize larger mem-stores in time-based flusing .. Patch Set 1: Code-Review+1 (2 comments)

[kudu-CR] KUDU-2844 (1/3): make BlockHandle ref-counted

2020-08-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15800 ) Change subject: KUDU-2844 (1/3): make BlockHandle ref-counted .. Patch Set 1: (5 comments)

[kudu-CR] KUDU-2844 (2/3): move RowBlock memory into a new RowBlockMemory struct

2020-08-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15801 ) Change subject: KUDU-2844 (2/3): move RowBlock memory into a new RowBlockMemory struct .. Patch Set 3: (6 comments)

[kudu-CR] KUDU-3181: put a bound on the queue of compilation manager

2020-08-12 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16330 ) Change subject: KUDU-3181: put a bound on the queue of compilation manager .. Patch Set 2: (3 comments)

[kudu-CR] KUDU-3181: put a bound on the queue of compilation manager

2020-08-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16330 ) Change subject: KUDU-3181: put a bound on the queue of compilation manager .. Patch Set 2: (3 comments) Thank you for the patch!