Alexey Serbin has posted comments on this change.
Change subject: [docs] guide on assertions in the Java code
..
Patch Set 2: Verified+1
Unrelated flakes in:
RaftConsensusITest.TestReplicaBehaviorViaRPC
org.apache.kudu.spar
Alexey Serbin has posted comments on this change.
Change subject: KUDU-2087. Fix failure to map Kerberos principal to username
with FreeIPA
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7551
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7578
Change subject: [clock] fixed link error on OS X
..
[clock] fixed link error on OS X
kudu_common is needed to link the clock library, ot
Alexey Serbin has posted comments on this change.
Change subject: [clock] fixed link error on OS X
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7578/1/src/kudu/clock/CMakeLists.txt
File src/kudu/clock/CMakeL
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7578
to look at the new patch set (#2).
Change subject: [clock] fixed link error on OS X
..
[clock] fixed link error on
Alexey Serbin has posted comments on this change.
Change subject: [clock] fixed link error on OS X
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7578/1/src/kudu/clock/CMakeLists.txt
File src/kudu/clock/CMakeL
Alexey Serbin has submitted this change and it was merged.
Change subject: [clock] fixed link error on OS X
..
[clock] fixed link error on OS X
kudu_common is needed to link the clock library, otherwise the following
error is o
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4738
to look at the new patch set (#8).
Change subject: WIP: [iwyu] first pass
..
WIP: [iwyu] first pass
Updated C++ so
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7593
Change subject: WIP [thirdparty]: added include-what-you-use
..
WIP [thirdparty]: added include-what-you-use
Build the include-what-you-
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4738
to look at the new patch set (#9).
Change subject: WIP: [iwyu] first pass
..
WIP: [iwyu] first pass
Updated C++ so
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7594
Change subject: [tests] fix compilation warning on OS X
..
[tests] fix compilation warning on OS X
Fixed compilation warning on OS X due
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4738
to look at the new patch set (#10).
Change subject: WIP: [iwyu] first pass
..
WIP: [iwyu] first pass
Updated C++ s
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7593
to look at the new patch set (#2).
Change subject: WIP [thirdparty]: added include-what-you-use
..
WIP [thirdparty]
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7604
Change subject: [build-support] added IWYU filter script
..
[build-support] added IWYU filter script
Added a script to filter the output
Alexey Serbin has submitted this change and it was merged.
Change subject: [tests] fix compilation warning on OS X
..
[tests] fix compilation warning on OS X
Fixed compilation warning on OS X due to unused function:
CountBlocks
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7604
to look at the new patch set (#2).
Change subject: [build-support] added IWYU filter script
..
[build-support] adde
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7593
to look at the new patch set (#3).
Change subject: [thirdparty]: added include-what-you-use
..
[thirdparty]: added
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4738
to look at the new patch set (#11).
Change subject: WIP: [iwyu] first pass
..
WIP: [iwyu] first pass
Updated C++ s
Alexey Serbin has posted comments on this change.
Change subject: WIP: [iwyu] first pass
..
Patch Set 11: Verified+1
unrelated flake in raft_consensus-itest (TSAN build only)
--
To view, visit http://gerrit.cloudera.org:8080/
Alexey Serbin has posted comments on this change.
Change subject: WIP: [iwyu] first pass
..
Patch Set 11: -Verified
> (19 comments)
>
> Thanks for banging on this some more, will be great to have with
> the automated checki
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7628
Change subject: remove 'using std::...' and other from header files
..
remove 'using std::...' and other from header files
Adding 'using
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7628
to look at the new patch set (#2).
Change subject: remove 'using std::...' and other from header files
..
remove 'u
Alexey Serbin has posted comments on this change.
Change subject: remove 'using std::...' and other from header files
..
Patch Set 1:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/7628/1/src/kudu/clock/hybrid_clock.cc
File
Alexey Serbin has submitted this change and it was merged.
Change subject: remove 'using std::...' and other from header files
..
remove 'using std::...' and other from header files
Adding 'using ...' into header files is not a
Alexey Serbin has posted comments on this change.
Change subject: remove 'using std::...' and other from header files
..
Patch Set 2: Verified+1
Unrelated flake in
ClientBehavior/ClientFailoverParamITest.TestDeleteLeaderWhileS
Alexey Serbin has posted comments on this change.
Change subject: transaction: remove unused StatusTransactionCompletionCallback
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7632
To unsubscri
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7635
Change subject: [util] remove 'using pb_util::Secure[Short]DebugString'
..
[util] remove 'using pb_util::Secure[Short]DebugString'
Addre
Alexey Serbin has submitted this change and it was merged.
Change subject: [util] remove 'using pb_util::Secure[Short]DebugString'
..
[util] remove 'using pb_util::Secure[Short]DebugString'
Addressed TODO in pb_util.h: removed
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7649
Change subject: [gutil] remove the rest of 'using ...' from headers
..
[gutil] remove the rest of 'using ...' from headers
Removed the r
Alexey Serbin has uploaded a new patch set (#2).
Change subject: [gutil] remove the rest of 'using ...' from headers
..
[gutil] remove the rest of 'using ...' from headers
Removed the rest of 'using ...' directives from gutil he
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7650
Change subject: [cfile-test-base.h] remove cyclic dependency
..
[cfile-test-base.h] remove cyclic dependency
Removed '#include "kudu/cfi
Alexey Serbin has submitted this change and it was merged.
Change subject: [cfile-test-base.h] remove cyclic dependency
..
[cfile-test-base.h] remove cyclic dependency
Removed '#include "kudu/cfile/cfile-test-base.h"' from the
Hello Dan Burkert, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7649
to look at the new patch set (#3).
Change subject: [gutil] remove the rest of 'using ...' from headers
Hello Dan Burkert, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7649
to look at the new patch set (#4).
Change subject: [gutil] remove the rest of 'using ...' from headers
Alexey Serbin has posted comments on this change.
Change subject: [gutil] remove the rest of 'using ...' from headers
..
Patch Set 3:
(8 comments)
http://gerrit.cloudera.org:8080/#/c/7649/3/src/kudu/gutil/hash/hash.h
File src/
Alexey Serbin has posted comments on this change.
Change subject: [gutil] remove the rest of 'using ...' from headers
..
Patch Set 4:
Carrying over Dan's +2 from PS2.
--
To view, visit http://gerrit.cloudera.org:8080/7649
To
Alexey Serbin has posted comments on this change.
Change subject: [gutil] remove the rest of 'using ...' from headers
..
Patch Set 4: Code-Review+2
Carrying over Dan's +2 from PS2.
--
To view, visit http://gerrit.cloudera.org
Alexey Serbin has submitted this change and it was merged.
Change subject: [gutil] remove the rest of 'using ...' from headers
..
[gutil] remove the rest of 'using ...' from headers
Removed the rest of 'using ...' directives fr
Alexey Serbin has posted comments on this change.
Change subject: KUDU-871. Support tombstoned voting
..
Patch Set 6:
(7 comments)
Glanced through one of the tests. Will take a closer look today.
http://gerrit.cloudera.org:8
Alexey Serbin has posted comments on this change.
Change subject: KUDU-2091: Certificates with intermediate CA's do not work with
Kudu
..
Patch Set 1:
(9 comments)
http://gerrit.cloudera.org:8080/#/c/7662/1/src/kudu/rpc/rpc-t
Alexey Serbin has posted comments on this change.
Change subject: [build-support] added IWYU filter script
..
Patch Set 2:
(12 comments)
Thank you for the review! I'll post a new version as soon as I shorten the
muted list e
Alexey Serbin has posted comments on this change.
Change subject: [thirdparty]: added include-what-you-use
..
Patch Set 3:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/7593/3/thirdparty/download-thirdparty.sh
File thirdpar
Alexey Serbin has posted comments on this change.
Change subject: [thirdparty]: added include-what-you-use
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7593/3/thirdparty/patches/llvm-iwyu-nocurses.patch
File
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7593
to look at the new patch set (#4).
Change subject: [thirdparty]: added include-what-you-use
..
[thirdparty]: added
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7604
to look at the new patch set (#3).
Change subject: [build-support] added IWYU filter script
..
[build-support] adde
Alexey Serbin has uploaded a new patch set (#12).
Change subject: WIP: [iwyu] first pass
..
WIP: [iwyu] first pass
Updated C++ source files in accordance with include-what-you-use
recommendations:
* remove unused header files
Alexey Serbin has posted comments on this change.
Change subject: WIP: [iwyu] first pass
..
Patch Set 12:
(21 comments)
http://gerrit.cloudera.org:8080/#/c/4738/11/src/kudu/benchmarks/rle.cc
File src/kudu/benchmarks/rle.cc:
L
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7604
to look at the new patch set (#4).
Change subject: [build-support] added IWYU filter script
..
[build-support] adde
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4738
to look at the new patch set (#13).
Change subject: WIP: [iwyu] first pass
..
WIP: [iwyu] first pass
Updated C++ s
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7593
to look at the new patch set (#6).
Change subject: [thirdparty]: added include-what-you-use
..
[thirdparty]: added
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4738
to look at the new patch set (#14).
Change subject: WIP: [iwyu] first pass
..
WIP: [iwyu] first pass
Updated C++ s
Alexey Serbin has posted comments on this change.
Change subject: [thirdparty]: added include-what-you-use
..
Patch Set 6: Verified+1
Unrelated flake in
org.apache.kudu.client.TestScannerMultiTablet.org.apache.kudu.client.Test
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7604
to look at the new patch set (#6).
Change subject: [build-support] added IWYU filter script
..
[build-support] adde
Alexey Serbin has posted comments on this change.
Change subject: [build-support] added IWYU filter script
..
Patch Set 6:
(4 comments)
> (4 comments)
>
> For the imported mapping files:
> - Please add a file-level comment
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7604
to look at the new patch set (#7).
Change subject: [build-support] added IWYU filter script
..
[build-support] adde
Alexey Serbin has posted comments on this change.
Change subject: [build-support] added IWYU filter script
..
Patch Set 6:
(1 comment)
I moved the IWYU license into the header of corresponding boost mapping files.
http://gerr
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7604
to look at the new patch set (#8).
Change subject: [build-support] added IWYU filter script
..
[build-support] adde
Alexey Serbin has posted comments on this change.
Change subject: KUDU-2091: Certificates with intermediate CA's do not work with
Kudu
..
Patch Set 2:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/7662/1/src/kudu/rpc/rpc-t
Alexey Serbin has posted comments on this change.
Change subject: [build-support] added IWYU filter script
..
Patch Set 8:
> Thanks. Maybe Dan wants to take a look, since he's reviewing your
> other IWYU patches?
Yes, I would
Alexey Serbin has posted comments on this change.
Change subject: KUDU-2091: Certificates with intermediate CA's do not work with
Kudu
..
Patch Set 2:
(5 comments)
Overall looks good to me, just some nits in the commit messag
Alexey Serbin has submitted this change and it was merged.
Change subject: [build-support] added IWYU filter script
..
[build-support] added IWYU filter script
Added a script to filter the output from the include-what-you-use t
Alexey Serbin has submitted this change and it was merged.
Change subject: [thirdparty]: added include-what-you-use
..
[thirdparty]: added include-what-you-use
Build the include-what-you-use utility along with the LLVM toolchai
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4738
to look at the new patch set (#15).
Change subject: [iwyu] first pass
..
[iwyu] first pass
Updated C++ source file
Alexey Serbin has posted comments on this change.
Change subject: [iwyu] first pass
..
Patch Set 15:
> definitely woudl be nice to get rid of some of the more common
> pragmas... here's a count from grep | uniq -c | sort -nk1
Alexey Serbin has posted comments on this change.
Change subject: rpc: move ConnectionId to its own file
..
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7685/1//COMMIT_MSG
Commit Message:
PS1, Li
Alexey Serbin has posted comments on this change.
Change subject: gutil: remove use of deprecated headers
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7684/1/src/kudu/gutil/hash/hash.h
File src/kudu/gutil/ha
Alexey Serbin has posted comments on this change.
Change subject: rpc: some small cleanup in ConnectionId
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7686/1/src/kudu/rpc/proxy.cc
File src/kudu/rpc/proxy.cc:
Alexey Serbin has posted comments on this change.
Change subject: gutil: remove use of deprecated headers
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7684/1/src/kudu/gutil/hash/hash.h
File src/kudu/gutil/ha
Alexey Serbin has posted comments on this change.
Change subject: rpc: move ConnectionId to its own file
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7685
To unsubscribe, visit http://gerrit.
Alexey Serbin has posted comments on this change.
Change subject: rpc: some small cleanup in ConnectionId
..
Patch Set 2: Code-Review+2
It seems there were unrelated flaky tests in RELEASE and SAN configs, but
overall LGTM.
-
Alexey Serbin has posted comments on this change.
Change subject: gutil: remove use of deprecated headers
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7684
To unsubscribe, visit http://gerrit
Alexey Serbin has posted comments on this change.
Change subject: KUDU-1942. Kerberos fails to log in on hostnames with capital
letters
..
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7693/2//COMMIT_MSG
Commi
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4738
to look at the new patch set (#16).
Change subject: [iwyu] first pass
..
[iwyu] first pass
Updated C++ source file
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7696
Change subject: [iwyu] update on the internal and boost mappings
..
[iwyu] update on the internal and boost mappings
Updated the interna
Alexey Serbin has posted comments on this change.
Change subject: [iwyu] update on the internal and boost mappings
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7696/1/build-support/iwyu/mappings/boost-all.i
Alexey Serbin has posted comments on this change.
Change subject: [iwyu] update on the internal and boost mappings
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7696/1/thirdparty/patches/llvm-iwyu-include-pic
Alexey Serbin has posted comments on this change.
Change subject: KUDU-2032 (part 1): pass pre-resolution hostname into RPC
proxies
..
Patch Set 2:
(5 comments)
some nits
http://gerrit.cloudera.org:8080/#/c/7687/2/src/kudu/m
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4738
to look at the new patch set (#17).
Change subject: [iwyu] first pass
..
[iwyu] first pass
Updated C++ source file
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7702
Change subject: [gitignore] added *.autosave
..
[gitignore] added *.autosave
Change-Id: I99457244f007c757eb1a5a0aba235d8e33e4460e
---
M
Alexey Serbin has posted comments on this change.
Change subject: KUDU-2032 (part 2): propagate master hostnames into client
..
Patch Set 2:
(1 comment)
looks good to me, just a nit
http://gerrit.cloudera.org:8080/#/c/7692/2/
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4738
to look at the new patch set (#18).
Change subject: [iwyu] first pass
..
[iwyu] first pass
Updated C++ source file
Alexey Serbin has posted comments on this change.
Change subject: KUDU-1942. Kerberos fails to log in on hostnames with capital
letters
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7693
To u
Alexey Serbin has submitted this change and it was merged.
Change subject: KUDU-1942. Kerberos fails to log in on hostnames with capital
letters
..
KUDU-1942. Kerberos fails to log in on hostnames with capital letters
This ens
Alexey Serbin has posted comments on this change.
Change subject: KUDU-2032 (part 2): propagate master hostnames into client
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7692
To unsubscribe,
Alexey Serbin has submitted this change and it was merged.
Change subject: security: only lookup hostname if _HOST substitution is required
..
security: only lookup hostname if _HOST substitution is required
The Kerberos princi
Alexey Serbin has posted comments on this change.
Change subject: security: only lookup hostname if _HOST substitution is required
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7694
To unsubsc
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4738
to look at the new patch set (#19).
Change subject: [iwyu] first pass
..
[iwyu] first pass
Updated C++ source file
Alexey Serbin has posted comments on this change.
Change subject: [iwyu] first pass
..
Patch Set 18:
(41 comments)
Thank you for the thorough review!
http://gerrit.cloudera.org:8080/#/c/4738/18/src/kudu/client/client-internal
Alexey Serbin has posted comments on this change.
Change subject: [iwyu] first pass
..
Patch Set 18:
(3 comments)
> Other than the 1 nit in sp::shared_ptr, this looks good to me
Great -- thank you for reviewing this jumbo-pat
Alexey Serbin has posted comments on this change.
Change subject: [iwyu] first pass
..
Patch Set 19:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4738/19/src/kudu/client/shared_ptr.h
File src/kudu/client/shared_ptr.h:
Line
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7696
to look at the new patch set (#2).
Change subject: [iwyu] update on the internal and boost mappings
..
[iwyu] updat
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7750
Change subject: [build-support] IWYU build configuration for Jenkins
..
[build-support] IWYU build configuration for Jenkins
Added provi
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4738
to look at the new patch set (#20).
Change subject: [iwyu] first pass
..
[iwyu] first pass
Updated C++ source file
Alexey Serbin has uploaded a new patch set (#2).
Change subject: [build-support] IWYU build configuration for Jenkins
..
[build-support] IWYU build configuration for Jenkins
Added provisions to run the include-what-you-use tool
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7696
to look at the new patch set (#3).
Change subject: [iwyu] update on the internal and boost mappings
..
[iwyu] updat
Alexey Serbin has posted comments on this change.
Change subject: [iwyu] update on the internal and boost mappings
..
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/7696/1//COMMIT_MSG
Commit Message:
PS1, Line
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7696
to look at the new patch set (#4).
Change subject: [iwyu] update on the internal and boost mappings
..
[iwyu] updat
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4738
to look at the new patch set (#21).
Change subject: [iwyu] first pass
..
[iwyu] first pass
Updated C++ source file
Alexey Serbin has posted comments on this change.
Change subject: [iwyu] first pass
..
Patch Set 21: Verified+1
unrelated flake in MultiThreadedTabletTest/5.DeleteAndReinsert
--
To view, visit http://gerrit.cloudera.org:8080/
Alexey Serbin has posted comments on this change.
Change subject: KUDU-2032 (part 1): pass pre-resolution hostname into RPC
proxies
..
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7687
To unsub
301 - 400 of 15449 matches
Mail list logo
