[kudu-CR] KUDU-1811: C++ client: use larger batches when fetching scan tokens

2017-08-29 Thread Jun He (Code Review)
Jun He has posted comments on this change. Change subject: KUDU-1811: C++ client: use larger batches when fetching scan tokens .. Patch Set 7: (1 comment)

[kudu-CR] KUDU-1811: C++ client: use larger batches when fetching scan tokens

2017-08-29 Thread Jun He (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7748 to look at the new patch set (#8). Change subject: KUDU-1811: C++ client: use larger batches when fetching scan tokens

[kudu-CR] KUDU-1811: C++ client: use larger batches when fetching scan tokens

2017-08-29 Thread Jun He (Code Review)
Jun He has posted comments on this change. Change subject: KUDU-1811: C++ client: use larger batches when fetching scan tokens .. Patch Set 5: (1 comment) Thanks for the comments and PTAL.

[kudu-CR] KUDU-1811: C++ client: use larger batches when fetching scan tokens

2017-08-29 Thread Jun He (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7748 to look at the new patch set (#7). Change subject: KUDU-1811: C++ client: use larger batches when fetching scan tokens

[kudu-CR] KUDU-1811: C++ client: use larger batches when fetching scan tokens

2017-08-26 Thread Jun He (Code Review)
Jun He has posted comments on this change. Change subject: KUDU-1811: C++ client: use larger batches when fetching scan tokens .. Patch Set 5: (1 comment) BTW, will this be included in 1.5 release?

[kudu-CR] KUDU-1811: C++ client: use larger batches when fetching scan tokens

2017-08-22 Thread Jun He (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7748 to look at the new patch set (#6). Change subject: KUDU-1811: C++ client: use larger batches when fetching scan tokens

[kudu-CR] KUDU-1811: C++ client: use larger batches when fetching scan tokens

2017-08-22 Thread Jun He (Code Review)
Jun He has posted comments on this change. Change subject: KUDU-1811: C++ client: use larger batches when fetching scan tokens .. Patch Set 5: (4 comments) I think some scale tests are needed to check the impact of the

[kudu-CR] KUDU-1811: C++ client: use larger batches when fetching scan tokens

2017-08-20 Thread Jun He (Code Review)
Jun He has posted comments on this change. Change subject: KUDU-1811: C++ client: use larger batches when fetching scan tokens .. Patch Set 5: Reran Jenkins build multiple times due to

[kudu-CR] KUDU-1811: C++ client: use larger batches when fetching scan tokens

2017-08-20 Thread Jun He (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7748 to look at the new patch set (#5). Change subject: KUDU-1811: C++ client: use larger batches when fetching scan tokens

[kudu-CR] KUDU-1811: C++ client: use larger batches when fetching scan tokens

2017-08-20 Thread Jun He (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7748 to look at the new patch set (#4). Change subject: KUDU-1811: C++ client: use larger batches when fetching scan tokens

[kudu-CR] KUDU-1811: C++ client: use larger batches when fetching scan tokens

2017-08-20 Thread Jun He (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7748 to look at the new patch set (#3). Change subject: KUDU-1811: C++ client: use larger batches when fetching scan tokens

[kudu-CR] KUDU-1811: C++ client: use larger batches when fetching scan tokens

2017-08-20 Thread Jun He (Code Review)
Jun He has posted comments on this change. Change subject: KUDU-1811: C++ client: use larger batches when fetching scan tokens .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-1811: C++ client: use larger batches when fetching scan tokens

2017-08-20 Thread Jun He (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7748 to look at the new patch set (#2). Change subject: KUDU-1811: C++ client: use larger batches when fetching scan tokens

[kudu-CR] KUDU-1811: C++ client: use larger batches when fetching scan tokens

2017-08-20 Thread Jun He (Code Review)
Jun He has posted comments on this change. Change subject: KUDU-1811: C++ client: use larger batches when fetching scan tokens .. Patch Set 1: (3 comments)

[kudu-CR] KUDU-1811: C++ client: use larger batches when fetching scan tokens

2017-08-20 Thread Jun He (Code Review)
Jun He has uploaded a new change for review. http://gerrit.cloudera.org:8080/7748 Change subject: KUDU-1811: C++ client: use larger batches when fetching scan tokens .. KUDU-1811: C++ client: use larger batches when fetching

[kudu-CR] KUDU-2089: Failed java tests can orphan test-tmp files

2017-08-18 Thread Jun He (Code Review)
Jun He has uploaded a new change for review. http://gerrit.cloudera.org:8080/7719 Change subject: KUDU-2089: Failed java tests can orphan test-tmp files .. KUDU-2089: Failed java tests can orphan test-tmp files This changes

[kudu-CR] KUDU-1831. Java client does not check if the primary key columns are specified first

2017-01-26 Thread Jun He (Code Review)
Jun He has posted comments on this change. Change subject: KUDU-1831. Java client does not check if the primary key columns are specified first .. Patch Set 4: > (1 comment) > > I'm good with the change, just one javadoc

[kudu-CR] KUDU-1831. Java client does not check if the primary key columns are specified first

2017-01-26 Thread Jun He (Code Review)
Hello Jean-Daniel Cryans, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5723 to look at the new patch set (#4). Change subject: KUDU-1831. Java client does not check if the primary key columns are specified first

[kudu-CR] KUDU-1831. Java client does not check if the primary key columns are specified first

2017-01-23 Thread Jun He (Code Review)
Jun He has posted comments on this change. Change subject: KUDU-1831. Java client does not check if the primary key columns are specified first .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-1831. Java client does not check if the primary key columns are specified first

2017-01-23 Thread Jun He (Code Review)
Jun He has posted comments on this change. Change subject: KUDU-1831. Java client does not check if the primary key columns are specified first .. Patch Set 2: > (1 comment) > > Jun, what motivated you to make this change

[kudu-CR] KUDU-1831. Java client does not check if the primary key columns are specified first

2017-01-20 Thread Jun He (Code Review)
Jun He has posted comments on this change. Change subject: KUDU-1831. Java client does not check if the primary key columns are specified first .. Patch Set 2: Thanks for the discussion. Remove the new code from Schema

[kudu-CR] KUDU-1831. Java client does not check if the primary key columns are specified first

2017-01-19 Thread Jun He (Code Review)
Hello Jean-Daniel Cryans, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5723 to look at the new patch set (#2). Change subject: KUDU-1831. Java client does not check if the primary key columns are specified first

[kudu-CR] KUDU-1831. Java client does not check if the primary key columns are specified first

2017-01-19 Thread Jun He (Code Review)
Jun He has posted comments on this change. Change subject: KUDU-1831. Java client does not check if the primary key columns are specified first .. Patch Set 1: Based on

[kudu-CR] KUDU-1831. Java client does not check if the primary key columns are specified first

2017-01-19 Thread Jun He (Code Review)
Jun He has posted comments on this change. Change subject: KUDU-1831. Java client does not check if the primary key columns are specified first .. Patch Set 1: > It seems like in the context of a projection, we don't want to

[kudu-CR] KUDU-1831. Java client does not check if the primary key columns are specified first

2017-01-18 Thread Jun He (Code Review)
Jun He has posted comments on this change. Change subject: KUDU-1831. Java client does not check if the primary key columns are specified first .. Patch Set 1: > I'm pretty sure we don't want this limitation, see >

[kudu-CR] KUDU-1831. Java client does not check if the primary key columns are specified first

2017-01-15 Thread Jun He (Code Review)
Jun He has uploaded a new change for review. http://gerrit.cloudera.org:8080/5723 Change subject: KUDU-1831. Java client does not check if the primary key columns are specified first .. KUDU-1831. Java client does not check

[kudu-CR] KUDU-1771. Java client "connection refused" errors logged as "connection reset"

2017-01-12 Thread Jun He (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5680 to look at the new patch set (#2). Change subject: KUDU-1771. Java client "connection refused" errors logged as "connection reset"

[kudu-CR] KUDU-1771. Java client "connection refused" errors logged as "connection reset"

2017-01-12 Thread Jun He (Code Review)
Jun He has posted comments on this change. Change subject: KUDU-1771. Java client "connection refused" errors logged as "connection reset" .. Patch Set 1: (2 comments)

[kudu-CR] KUDU-1771. Java client "connection refused" errors logged as "connection reset"

2017-01-11 Thread Jun He (Code Review)
Jun He has uploaded a new change for review. http://gerrit.cloudera.org:8080/5680 Change subject: KUDU-1771. Java client "connection refused" errors logged as "connection reset" .. KUDU-1771. Java client "connection refused"

[kudu-CR] KUDU-1821. Noisy warning from catalog manager

2017-01-10 Thread Jun He (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5637 to look at the new patch set (#3). Change subject: KUDU-1821. Noisy warning from catalog manager .. KUDU-1821.

[kudu-CR] KUDU-1821. Noisy warning from catalog manager

2017-01-09 Thread Jun He (Code Review)
Jun He has posted comments on this change. Change subject: KUDU-1821. Noisy warning from catalog manager .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5637/2/src/kudu/master/catalog_manager.cc File

[kudu-CR] KUDU-1821. Noisy warning from catalog manager

2017-01-07 Thread Jun He (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5637 to look at the new patch set (#2). Change subject: KUDU-1821. Noisy warning from catalog manager .. KUDU-1821.

[kudu-CR] KUDU-1821. Noisy warning from catalog manager

2017-01-06 Thread Jun He (Code Review)
Jun He has uploaded a new change for review. http://gerrit.cloudera.org:8080/5637 Change subject: KUDU-1821. Noisy warning from catalog manager .. KUDU-1821. Noisy warning from catalog manager This commit changes the

[kudu-CR] KUDU-1822. Update docs to build the documentation in ubuntu

2017-01-05 Thread Jun He (Code Review)
Jun He has uploaded a new change for review. http://gerrit.cloudera.org:8080/5608 Change subject: KUDU-1822. Update docs to build the documentation in ubuntu .. KUDU-1822. Update docs to build the documentation in ubuntu

[kudu-CR] KUDU-734. Add test coverage for encodings and strings

2017-01-05 Thread Jun He (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5588 to look at the new patch set (#2). Change subject: KUDU-734. Add test coverage for encodings and strings ..

[kudu-CR] KUDU-734. Add test coverage for encodings and strings

2017-01-04 Thread Jun He (Code Review)
Jun He has posted comments on this change. Change subject: KUDU-734. Add test coverage for encodings and strings .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/5588/1//COMMIT_MSG Commit Message: Line 9:

[kudu-CR] KUDU-90. Add a header checksum to our RPC protocol

2017-01-04 Thread Jun He (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5578 to look at the new patch set (#4). Change subject: KUDU-90. Add a header checksum to our RPC protocol .. KUDU-90.

[kudu-CR] [KUDU-90] Add a header checksum to our RPC protocol Added 4-byte checksum into the RPC protocol. Checksum is inserted immediately after total size.

2017-01-04 Thread Jun He (Code Review)
Jun He has posted comments on this change. Change subject: [KUDU-90] Add a header checksum to our RPC protocol Added 4-byte checksum into the RPC protocol. Checksum is inserted immediately after total_size. .. Patch Set 3:

[kudu-CR] KUDU-1655. Update docs for ASF maven repository coordinates

2017-01-03 Thread Jun He (Code Review)
Jun He has posted comments on this change. Change subject: KUDU-1655. Update docs for ASF maven repository coordinates .. Patch Set 2: (3 comments) Addressed the review comments.

[kudu-CR] KUDU-1655. Update docs for ASF maven repository coordinates

2017-01-03 Thread Jun He (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5581 to look at the new patch set (#2). Change subject: KUDU-1655. Update docs for ASF maven repository coordinates ..

[kudu-CR] KUDU-734. Add test coverage for encodings and strings

2016-12-31 Thread Jun He (Code Review)
Jun He has uploaded a new change for review. http://gerrit.cloudera.org:8080/5588 Change subject: KUDU-734. Add test coverage for encodings and strings .. KUDU-734. Add test coverage for encodings and strings added a

[kudu-CR] KUDU-1817. Fix kudu-spark2 artifactId in pom.xml

2016-12-28 Thread Jun He (Code Review)
Jun He has uploaded a new change for review. http://gerrit.cloudera.org:8080/5586 Change subject: KUDU-1817. Fix kudu-spark2 artifactId in pom.xml .. KUDU-1817. Fix kudu-spark2 artifactId in pom.xml kudu-spark2 pom.xml is

[kudu-CR] KUDU-1655. Update docs for ASF maven repository coordinates - Update Maven Artifacts - Update Kudu Integration with Spark using --packages

2016-12-26 Thread Jun He (Code Review)
Jun He has uploaded a new change for review. http://gerrit.cloudera.org:8080/5581 Change subject: KUDU-1655. Update docs for ASF maven repository coordinates - Update Maven Artifacts - Update Kudu Integration with Spark using --packages

[kudu-CR] [KUDU-90] Add a header checksum to our RPC protocol Added 4-byte checksum into the RPC protocol. Checksum is inserted immediately after total size.

2016-12-26 Thread Jun He (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5578 to look at the new patch set (#3). Change subject: [KUDU-90] Add a header checksum to our RPC protocol Added 4-byte checksum into the RPC protocol. Checksum is inserted immediately

[kudu-CR] [KUDU-90] Add a header checksum to our RPC protocol Added 4-byte checksum into the RPC protocol. Checksum is inserted immediately after total size.

2016-12-24 Thread Jun He (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5578 to look at the new patch set (#2). Change subject: [KUDU-90] Add a header checksum to our RPC protocol Added 4-byte checksum into the RPC protocol. Checksum is inserted immediately

[kudu-CR] fix lint error

2016-12-24 Thread Jun He (Code Review)
Jun He has abandoned this change. Change subject: fix lint error .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/5579 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: abandon

[kudu-CR] fix lint error

2016-12-24 Thread Jun He (Code Review)
Jun He has restored this change. Change subject: fix lint error .. Restored -- To view, visit http://gerrit.cloudera.org:8080/5579 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: restore

[kudu-CR] fix lint error

2016-12-24 Thread Jun He (Code Review)
Jun He has abandoned this change. Change subject: fix lint error .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/5579 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: abandon

[kudu-CR] fix lint error

2016-12-24 Thread Jun He (Code Review)
Jun He has uploaded a new change for review. http://gerrit.cloudera.org:8080/5579 Change subject: fix lint error .. fix lint error Change-Id: I2d10f7b5aa370cd4affbd7cf0055139988374341 --- M src/kudu/rpc/serialization.cc 1

[kudu-CR] [KUDU-90] Add a header checksum to our RPC protocol Added 4-byte checksum into the RPC protocol. Checksum is inserted immediately after total size.

2016-12-24 Thread Jun He (Code Review)
Jun He has uploaded a new change for review. http://gerrit.cloudera.org:8080/5578 Change subject: [KUDU-90] Add a header checksum to our RPC protocol Added 4-byte checksum into the RPC protocol. Checksum is inserted immediately after total_size.