[kudu-CR] [log] Support logging audit logs to a separate file

2024-09-22 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21613 ) Change subject: [log] Support logging audit logs to a separate file .. Patch Set 8: (7 comments) http://gerrit.cloudera.org:8080/#/c/2

[kudu-CR] [ranger] enhance the robustness of key retrieval

2024-09-22 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21673 ) Change subject: [ranger] enhance the robustness of key retrieval .. Patch Set 7: Code-Review+1 (2 comments) http://gerrit.cloudera.org

[kudu-CR] [tablet] fix race in RowSetMetadata::id()

2024-09-18 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21779 ) Change subject: [tablet] fix race in RowSetMetadata::id() .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8

[kudu-CR] KUDU-3606 [tools] Check column IDs when --strict column id is enabled

2024-09-18 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21695 ) Change subject: KUDU-3606 [tools] Check column IDs when --strict_column_id is enabled .. Patch Set 7: Verified+1 The failed tests ts_r

[kudu-CR] KUDU-3606 [tools] Check column IDs when --strict column id is enabled

2024-09-18 Thread Yingchun Lai (Code Review)
Yingchun Lai has removed a vote on this change. Change subject: KUDU-3606 [tools] Check column IDs when --strict_column_id is enabled .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080

[kudu-CR] KUDU-3606 [tools] Check column IDs when --strict column id is enabled

2024-09-18 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21695 ) Change subject: KUDU-3606 [tools] Check column IDs when --strict_column_id is enabled .. Patch Set 7: (3 comments) http://gerrit.clou

[kudu-CR] KUDU-3606 [tools] Check column IDs when --strict column id is enabled

2024-09-18 Thread Yingchun Lai (Code Review)
Hello Mahesh Reddy, Alexey Serbin, Yifan Zhang, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21695 to look at the new patch set (#7). Change subject: KUDU-3606 [tools] Check column IDs when --strict_column_id is enabled

[kudu-CR] KUDU-3606 [tools] Check column IDs when --strict column id is enabled

2024-09-13 Thread Yingchun Lai (Code Review)
Hello Mahesh Reddy, Alexey Serbin, Yifan Zhang, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21695 to look at the new patch set (#6). Change subject: KUDU-3606 [tools] Check column IDs when --strict_column_id is enabled

[kudu-CR] KUDU-3606 [tools] Check column IDs when --strict column id is enabled

2024-09-13 Thread Yingchun Lai (Code Review)
Hello Mahesh Reddy, Alexey Serbin, Yifan Zhang, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21695 to look at the new patch set (#5). Change subject: KUDU-3606 [tools] Check column IDs when --strict_column_id is enabled

[kudu-CR] KUDU-3606 [tools] Check column IDs when --strict column id is enabled

2024-09-13 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21695 ) Change subject: KUDU-3606 [tools] Check column IDs when --strict_column_id is enabled .. Patch Set 4: (9 comments) http://gerrit.clou

[kudu-CR] KUDU-3606 [tools] Show column ids when using 'kudu table describe'

2024-09-13 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21717 ) Change subject: KUDU-3606 [tools] Show column ids when using 'kudu table describe' .. Patch Set 2: > Patch Set 2: > > Overall looks go

[kudu-CR] KUDU-3606 [tools] Show column ids when using 'kudu table describe'

2024-09-13 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21717 ) Change subject: KUDU-3606 [tools] Show column ids when using 'kudu table describe' .. Patch Set 2: Verified+1 -- To view, visit http:

[kudu-CR] KUDU-3606 [tools] Show column ids when using 'kudu table describe'

2024-09-13 Thread Yingchun Lai (Code Review)
Yingchun Lai has removed a vote on this change. Change subject: KUDU-3606 [tools] Show column ids when using 'kudu table describe' .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21

[kudu-CR] [tablet] fix race in RowSetMetadata::id()

2024-09-11 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21779 ) Change subject: [tablet] fix race in RowSetMetadata::id() .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/21779/3/src

[kudu-CR] [rpc] instantiate DiagnosticSocket only if sock diag available

2024-08-27 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21727 ) Change subject: [rpc] instantiate DiagnosticSocket only if sock_diag available .. Patch Set 1: Code-Review+2 -- To view, visit http://

[kudu-CR] [util] fine-grained versioning for diagnostic socket

2024-08-26 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21722 ) Change subject: [util] fine-grained versioning for diagnostic socket .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.clo

[kudu-CR] KUDU-3606 [tools] Show column ids when using 'kudu table describe'

2024-08-26 Thread Yingchun Lai (Code Review)
Hello Yifan Zhang, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21717 to look at the new patch set (#2). Change subject: KUDU-3606 [tools] Show column ids when using 'kudu table describe'

[kudu-CR] [util] fine-grained versioning for diagnostic socket

2024-08-25 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21722 ) Change subject: [util] fine-grained versioning for diagnostic socket .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/

[kudu-CR] KUDU-3606 [tools] Show column ids when using 'kudu table describe'

2024-08-23 Thread Yingchun Lai (Code Review)
Yingchun Lai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21717 Change subject: KUDU-3606 [tools] Show column ids when using 'kudu table describe' .. KUDU-3606 [tools] Show column ids when using 'kudu

[kudu-CR] KUDU-3606 [tools] Copy table with non-continuous column ids

2024-08-23 Thread Yingchun Lai (Code Review)
Hello Mahesh Reddy, Yifan Zhang, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21695 to look at the new patch set (#4). Change subject: KUDU-3606 [tools] Copy table with non-continuous column ids ..

[kudu-CR] [tools] Copy table with non-continuous column ids

2024-08-23 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21695 ) Change subject: [tools] Copy table with non-continuous column ids .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/216

[kudu-CR] Table copy supports creating a table with no range partition

2024-08-21 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21634 ) Change subject: Table copy supports creating a table with no range partition .. Patch Set 4: Code-Review+2 -- To view, visit http://ge

[kudu-CR] [tools] Copy table with non-continuous column ids

2024-08-21 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21695 ) Change subject: [tools] Copy table with non-continuous column ids .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloude

[kudu-CR] [tools] Copy table with non-continuous column ids

2024-08-21 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21695 ) Change subject: [tools] Copy table with non-continuous column ids .. Patch Set 3: The failed tests (org.apache.kudu.client.TestSecurity

[kudu-CR] [tools] Copy table with non-continuous column ids

2024-08-21 Thread Yingchun Lai (Code Review)
Yingchun Lai has removed a vote on this change. Change subject: [tools] Copy table with non-continuous column ids .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21695 To unsubscribe

[kudu-CR] [tools] Copy table with non-continuous column ids

2024-08-21 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21695 ) Change subject: [tools] Copy table with non-continuous column ids .. Patch Set 2: (8 comments) http://gerrit.cloudera.org:8080/#/c/216

[kudu-CR] [tools] Copy table with non-continuous column ids

2024-08-21 Thread Yingchun Lai (Code Review)
Hello Mahesh Reddy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21695 to look at the new patch set (#3). Change subject: [tools] Copy table with non-continuous column ids .

[kudu-CR] Table copy supports creating a table with no range partition

2024-08-21 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21634 ) Change subject: Table copy supports creating a table with no range partition .. Patch Set 3: Code-Review+1 (2 comments) http://gerrit.

[kudu-CR] [log] Support logging audit logs to a separate file

2024-08-21 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21613 ) Change subject: [log] Support logging audit logs to a separate file .. Patch Set 6: Code-Review+1 -- To view, visit http://gerrit.clou

[kudu-CR] [tool] standardize the output of rebalance report tool

2024-08-21 Thread Yingchun Lai (Code Review)
Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21672 ) Change subject: [tool] standardize the output of rebalance report tool .. [tool] standardize the output of rebalance report tool

[kudu-CR] [tools] Copy table with non-continuous column ids

2024-08-20 Thread Yingchun Lai (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21695 to look at the new patch set (#2). Change subject: [tools] Copy table with non-continuous column ids .. [tools] Cop

[kudu-CR] Copy table with non-continuous column ids

2024-08-20 Thread Yingchun Lai (Code Review)
Yingchun Lai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21695 Change subject: Copy table with non-continuous column ids .. Copy table with non-continuous column ids Change-Id: I77af7b92b45f3866cc8b6

[kudu-CR] [common] Remove unused field from key util::PushLowerBoundPrimaryKeyPredicates

2024-08-20 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21694 ) Change subject: [common] Remove unused field from key_util::PushLowerBoundPrimaryKeyPredicates .. Patch Set 1: Code-Review+2 Did you f

[kudu-CR] [fs] fix const-correctness of a few methods

2024-08-19 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21693 ) Change subject: [fs] fix const-correctness of a few methods .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org

[kudu-CR] KUDU-3462 [UT] Fix a flaky test in log block manager-test

2024-08-19 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21686 ) Change subject: KUDU-3462 [UT] Fix a flaky test in log_block_manager-test .. Patch Set 3: Verified+1 The fauled tests (txn_participant-

[kudu-CR] KUDU-3462 [UT] Fix a flaky test in log block manager-test

2024-08-19 Thread Yingchun Lai (Code Review)
Yingchun Lai has removed a vote on this change. Change subject: KUDU-3462 [UT] Fix a flaky test in log_block_manager-test .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21686 To uns

[kudu-CR] KUDU-3462 [UT] Fix a flaky test in log block manager-test

2024-08-18 Thread Yingchun Lai (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21686 to look at the new patch set (#3). Change subject: KUDU-3462 [UT] Fix a flaky test in log_block_manager-test

[kudu-CR] [UT] Improve a flaky test in log block manager-test

2024-08-17 Thread Yingchun Lai (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21686 to look at the new patch set (#2). Change subject: [UT] Improve a flaky test in log_block_manager-test .. [UT] Impr

[kudu-CR] [UT] Improve a flaky test in log block manager-test

2024-08-17 Thread Yingchun Lai (Code Review)
Yingchun Lai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21686 Change subject: [UT] Improve a flaky test in log_block_manager-test .. [UT] Improve a flaky test in log_block_manager-test Change-Id: I9

[kudu-CR] [ranger] enhance the robustness of key retrieval

2024-08-16 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21673 ) Change subject: [ranger] enhance the robustness of key retrieval .. Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/2167

[kudu-CR] [tool] standardize the output of rebalance report tool

2024-08-15 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21672 ) Change subject: [tool] standardize the output of rebalance report tool .. Patch Set 4: Verified+1 Failed tests are not related. -- To

[kudu-CR] [tool] standardize the output of rebalance report tool

2024-08-15 Thread Yingchun Lai (Code Review)
Yingchun Lai has removed a vote on this change. Change subject: [tool] standardize the output of rebalance report tool .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21672 To unsubs

[kudu-CR] [tool] standardize the output of rebalance report tool

2024-08-15 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21672 ) Change subject: [tool] standardize the output of rebalance report tool .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.c

[kudu-CR] [tool] Fix the copied table schema missing check bug

2024-08-15 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21676 ) Change subject: [tool] Fix the copied table schema missing check bug .. Patch Set 1: Verified+1 The failed tests are unrelated. -- To

[kudu-CR] [tool] Fix the copied table schema missing check bug

2024-08-15 Thread Yingchun Lai (Code Review)
Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21676 ) Change subject: [tool] Fix the copied table schema missing check bug .. [tool] Fix the copied table schema missing check bug Ch

[kudu-CR] [tool] Fix the copied table schema missing check bug

2024-08-15 Thread Yingchun Lai (Code Review)
Yingchun Lai has removed a vote on this change. Change subject: [tool] Fix the copied table schema missing check bug .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21676 To unsubscr

[kudu-CR] [tool] Fix the copied table schema missing check bug

2024-08-15 Thread Yingchun Lai (Code Review)
Yingchun Lai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21676 Change subject: [tool] Fix the copied table schema missing check bug .. [tool] Fix the copied table schema missing check bug Change-Id:

[kudu-CR] [tool] sandardize the output of rebalance report tool

2024-08-15 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21672 ) Change subject: [tool] sandardize the output of rebalance report tool .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/

[kudu-CR] [tool] sandardize the output of rebalance report tool

2024-08-15 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21672 ) Change subject: [tool] sandardize the output of rebalance report tool .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/

[kudu-CR] [tool] sandardize the output of rebalance report tool

2024-08-14 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21672 ) Change subject: [tool] sandardize the output of rebalance report tool .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/

[kudu-CR] [cfile] modernize CFileWriter

2024-08-14 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21670 ) Change subject: [cfile] modernize CFileWriter .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/21670 To

[kudu-CR] KUDU-3599 more robust way of updating tablet copy metrics

2024-08-11 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21658 ) Change subject: KUDU-3599 more robust way of updating tablet copy metrics .. Patch Set 1: Code-Review+2 -- To view, visit http://gerri

[kudu-CR] [util] modernize MemTracker

2024-08-10 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21654 ) Change subject: [util] modernize MemTracker .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/21654/1/src/kudu/util/mem_

[kudu-CR] [util] modernize MemTracker

2024-08-10 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21654 ) Change subject: [util] modernize MemTracker .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/21654 To u

[kudu-CR] Table copy supports creating a table with no range partition

2024-08-09 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21634 ) Change subject: Table copy supports creating a table with no range partition .. Patch Set 2: Code-Review+1 -- To view, visit http://ge

[kudu-CR] [util] modernize MemTracker

2024-08-09 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21654 ) Change subject: [util] modernize MemTracker .. Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/21654/1/src/

[kudu-CR] Table copy supports creating empty range partition

2024-08-08 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21637 ) Change subject: Table copy supports creating empty range partition .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloud

[kudu-CR] [log] Support logging audit logs to a separate file

2024-08-08 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21613 ) Change subject: [log] Support logging audit logs to a separate file .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/2

[kudu-CR] Table copy supports creating empty range partition

2024-08-07 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21637 ) Change subject: Table copy supports creating empty range partition .. Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.or

[kudu-CR] [Tool] CLI table copy creats a table with no range partition

2024-08-07 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21634 ) Change subject: [Tool] CLI table copy creats a table with no range partition .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8

[kudu-CR] [log] Support logging audit logs to a separate file

2024-08-06 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21613 ) Change subject: [log] Support logging audit logs to a separate file .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/2

[kudu-CR] WIP KUDU-3606 Supports copying tablet from different cluster

2024-08-06 Thread Yingchun Lai (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21648 to look at the new patch set (#3). Change subject: WIP KUDU-3606 Supports copying tablet from different cluster ..

[kudu-CR] WIP KUDU-3606 Supports copying tablet from different cluster

2024-08-06 Thread Yingchun Lai (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21648 to look at the new patch set (#2). Change subject: WIP KUDU-3606 Supports copying tablet from different cluster ..

[kudu-CR] WIP KUDU-3606 Supports copying tablet from different cluster

2024-08-06 Thread Yingchun Lai (Code Review)
Yingchun Lai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21648 Change subject: WIP KUDU-3606 Supports copying tablet from different cluster .. WIP KUDU-3606 Supports copying tablet from different clus

[kudu-CR] KUDU-3371 Parameterize some options of RocksDB

2024-07-31 Thread Yingchun Lai (Code Review)
Yingchun Lai has removed a vote on this change. Change subject: KUDU-3371 Parameterize some options of RocksDB .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21570 To unsubscribe, v

[kudu-CR] KUDU-3371 Parameterize some options of RocksDB

2024-07-31 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21570 ) Change subject: KUDU-3371 Parameterize some options of RocksDB .. Patch Set 4: Verified+1 Remove the un-related failed tests. -- To v

[kudu-CR] [fs] check block size match only for block managers

2024-07-31 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21627 ) Change subject: [fs] check block size match only for block managers .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.clou

[kudu-CR] [log] Support logging audit logs to a separate file

2024-07-31 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21613 ) Change subject: [log] Support logging audit logs to a separate file .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/2

[kudu-CR] KUDU-3591 Fix the flaky test FsManagerTestBase.TestAddRemoveDataDirsFuzz

2024-07-28 Thread Yingchun Lai (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21604 to look at the new patch set (#4). Change subject: KUDU-3591 Fix the flaky test FsManagerTestBase.TestAddRemoveDataDirsFuzz .

[kudu-CR] KUDU-3591 Fix the flaky test FsManagerTestBase.TestAddRemoveDataDirsFuzz

2024-07-28 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21604 ) Change subject: KUDU-3591 Fix the flaky test FsManagerTestBase.TestAddRemoveDataDirsFuzz .. Patch Set 3: (2 comments) http://gerrit.c

[kudu-CR] [log] fix the Ranger client log count limit not working

2024-07-26 Thread Yingchun Lai (Code Review)
Yingchun Lai has removed a vote on this change. Change subject: [log] fix the Ranger client log count limit not working .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21572 To unsub

[kudu-CR] [log] fix the Ranger client log count limit not working

2024-07-26 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21572 ) Change subject: [log] fix the Ranger client log count limit not working .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.clo

[kudu-CR] [log] fix the Ranger client log count limit not working

2024-07-26 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21572 ) Change subject: [log] fix the Ranger client log count limit not working .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.

[kudu-CR] [tests] more robust TabletServerDiskErrorITest::SetUp()

2024-07-25 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21614 ) Change subject: [tests] more robust TabletServerDiskErrorITest::SetUp() .. Patch Set 1: Code-Review+1 There is a new IWYU error need to

[kudu-CR] [tests] more robust TabletServerDiskErrorITest::SetUp()

2024-07-25 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21614 ) Change subject: [tests] more robust TabletServerDiskErrorITest::SetUp() .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.

[kudu-CR] KUDU-3591 Fix the flaky test FsManagerTestBase.TestAddRemoveDataDirsFuzz

2024-07-21 Thread Yingchun Lai (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21604 to look at the new patch set (#3). Change subject: KUDU-3591 Fix the flaky test FsManagerTestBase.TestAddRemoveDataDirsFuzz ...

[kudu-CR] KUDU-3591 Fix the flaky test FsManagerTestBase.TestAddRemoveDataDirsFuzz

2024-07-21 Thread Yingchun Lai (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21604 to look at the new patch set (#2). Change subject: KUDU-3591 Fix the flaky test FsManagerTestBase.TestAddRemoveDataDirsFuzz ...

[kudu-CR] [util] a small clean up on the Throttler class

2024-07-20 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21603 ) Change subject: [util] a small clean up on the Throttler class .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.

[kudu-CR] just a test

2024-07-20 Thread Yingchun Lai (Code Review)
Yingchun Lai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21604 Change subject: just a test .. just a test Change-Id: I56a03d64c8ababd63fe31fa1e7fce1efac3875e8 --- M src/kudu/fs/fs_manager-test.cc 1 f

[kudu-CR] KUDU-3371 Parameterize some options of RocksDB

2024-07-16 Thread Yingchun Lai (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21570 to look at the new patch set (#3). Change subject: KUDU-3371 Parameterize some options of RocksDB

[kudu-CR] KUDU-3371 Add NO ROCKSDB build option

2024-07-14 Thread Yingchun Lai (Code Review)
Hello Zoltan Chovan, Alexey Serbin, Yuqi Du, Zoltan Martonka, Yifan Zhang, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21560 to look at the new patch set (#5). Change subject: KUDU-3371 Add NO_ROCKSDB build option .

[kudu-CR] KUDU-3371 Parameterize some options of RocksDB

2024-07-13 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21570 ) Change subject: KUDU-3371 Parameterize some options of RocksDB .. Patch Set 2: (26 comments) http://gerrit.cloudera.org:8080/#/c/21570

[kudu-CR] KUDU-3371 Parameterize some options of RocksDB

2024-07-13 Thread Yingchun Lai (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21570 to look at the new patch set (#2). Change subject: KUDU-3371 Parameterize some options of RocksDB

[kudu-CR] KUDU-3371 Add NO ROCKSDB build option

2024-07-13 Thread Yingchun Lai (Code Review)
Hello Zoltan Chovan, Alexey Serbin, Yuqi Du, Zoltan Martonka, Yifan Zhang, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21560 to look at the new patch set (#4). Change subject: KUDU-3371 Add NO_ROCKSDB build option .

[kudu-CR] KUDU-3371 Add NO ROCKSDB build option

2024-07-13 Thread Yingchun Lai (Code Review)
Hello Zoltan Chovan, Alexey Serbin, Yuqi Du, Zoltan Martonka, Yifan Zhang, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21560 to look at the new patch set (#3). Change subject: KUDU-3371 Add NO_ROCKSDB build option .

[kudu-CR] Update CMake to 3.22.6

2024-07-11 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21569 ) Change subject: Update CMake to 3.22.6 .. Patch Set 2: > In case you use the provided cmake from thirdparty for thirdparty build, but

[kudu-CR] Update CMake to 3.22.6

2024-07-10 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21569 ) Change subject: Update CMake to 3.22.6 .. Patch Set 1: Code-Review+1 Is the cmake_minimum_required in ./CMakeLists.txt needed to be upd

[kudu-CR] KUDU-3371 Parameterize some options of RocksDB

2024-07-10 Thread Yingchun Lai (Code Review)
Yingchun Lai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21570 Change subject: KUDU-3371 Parameterize some options of RocksDB .. KUDU-3371 Parameterize some options of RocksDB There are many options

[kudu-CR] KUDU-3371 Add NO ROCKSDB build option

2024-07-07 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21560 ) Change subject: KUDU-3371 Add NO_ROCKSDB build option .. Patch Set 2: > Patch Set 2: Code-Review+1 > > Thank you for the change. > Coul

[kudu-CR] [cfile] allocate CFileWriter field on the stack when possible

2024-07-06 Thread Yingchun Lai (Code Review)
Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21543 ) Change subject: [cfile] allocate CFileWriter field on the stack when possible .. [cfile] allocate CFileWriter field on the stack

[kudu-CR] KUDU-3371 Add NO ROCKSDB build option

2024-07-05 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21560 ) Change subject: KUDU-3371 Add NO_ROCKSDB build option .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/215

[kudu-CR] KUDU-3371 Add NO ROCKSDB build option

2024-07-05 Thread Yingchun Lai (Code Review)
Yingchun Lai has removed a vote on this change. Change subject: KUDU-3371 Add NO_ROCKSDB build option .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21560 To unsubscribe, visit http

[kudu-CR] KUDU-3371 Add NO ROCKSDB build option

2024-07-02 Thread Yingchun Lai (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21560 to look at the new patch set (#2). Change subject: KUDU-3371 Add NO_ROCKSDB build option .. KUDU-3371 Add NO_ROCKSD

[kudu-CR] [cfile] allocate CFileWriter field on the stack when possible

2024-07-01 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21543 ) Change subject: [cfile] allocate CFileWriter field on the stack when possible .. Patch Set 2: Code-Review+2 -- To view, visit http://g

[kudu-CR] KUDU-3371 Add NO ROCKSDB build option

2024-07-01 Thread Yingchun Lai (Code Review)
Yingchun Lai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21560 Change subject: KUDU-3371 Add NO_ROCKSDB build option .. KUDU-3371 Add NO_ROCKSDB build option This patch adds a build option 'NO_ROCKSD

[kudu-CR] [metrics] Add metrics for tablet replication time

2024-06-26 Thread Yingchun Lai (Code Review)
Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21507 ) Change subject: [metrics] Add metrics for tablet replication time .. [metrics] Add metrics for tablet replication time Add tabl

[kudu-CR] [metrics] Add metrics for tablet replication time

2024-06-26 Thread Yingchun Lai (Code Review)
Yingchun Lai has removed a vote on this change. Change subject: [metrics] Add metrics for tablet replication time .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21507 To unsubscribe

[kudu-CR] [metrics] Add metrics for tablet replication time

2024-06-26 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21507 ) Change subject: [metrics] Add metrics for tablet replication time .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.

[kudu-CR] [metrics] Add metrics for tablet replica election

2024-06-26 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21490 ) Change subject: [metrics] Add metrics for tablet replica election .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.

[kudu-CR] [metrics] Add metrics for tablet replication time

2024-06-25 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21507 ) Change subject: [metrics] Add metrics for tablet replication time .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloude

  1   2   3   4   5   6   7   8   9   10   >