[kudu-CR] WIP: [iwyu] first pass

2017-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: WIP: [iwyu] first pass .. Patch Set 14: definitely woudl be nice to get rid of some of the more common pragmas... here's a count from grep | uniq -c | sort -nk1

[kudu-CR] WIP: [iwyu] first pass

2017-08-14 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4738 to look at the new patch set (#14). Change subject: WIP: [iwyu] first pass .. WIP: [iwyu] first pass Updated C++

[kudu-CR] WIP: [iwyu] first pass

2017-08-14 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4738 to look at the new patch set (#13). Change subject: WIP: [iwyu] first pass .. WIP: [iwyu] first pass Updated C++

[kudu-CR] WIP: [iwyu] first pass

2017-08-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: WIP: [iwyu] first pass .. Patch Set 12: (21 comments) http://gerrit.cloudera.org:8080/#/c/4738/11/src/kudu/benchmarks/rle.cc File src/kudu/benchmarks/rle.cc:

[kudu-CR] WIP: [iwyu] first pass

2017-08-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new patch set (#12). Change subject: WIP: [iwyu] first pass .. WIP: [iwyu] first pass Updated C++ source files in accordance with include-what-you-use recommendations: * remove unused header files

[kudu-CR] WIP: [iwyu] first pass

2017-08-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: WIP: [iwyu] first pass .. Patch Set 11: (2 comments) http://gerrit.cloudera.org:8080/#/c/4738/11/src/kudu/benchmarks/tpch/rpc_line_item_dao-test.cc File

[kudu-CR] WIP: [iwyu] first pass

2017-08-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: WIP: [iwyu] first pass .. Patch Set 11: -Verified > (19 comments) > > Thanks for banging on this some more, will be great to have with > the automated

[kudu-CR] WIP: [iwyu] first pass

2017-08-08 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: WIP: [iwyu] first pass .. Patch Set 11: (19 comments) Thanks for banging on this some more, will be great to have with the automated checking. I only got

[kudu-CR] WIP: [iwyu] first pass

2017-08-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: WIP: [iwyu] first pass .. Patch Set 11: Verified+1 unrelated flake in raft_consensus-itest (TSAN build only) -- To view, visit

[kudu-CR] WIP: [iwyu] first pass

2017-08-07 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4738 to look at the new patch set (#11). Change subject: WIP: [iwyu] first pass .. WIP: [iwyu] first pass Updated C++

[kudu-CR] WIP: [iwyu] first pass

2017-08-07 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4738 to look at the new patch set (#10). Change subject: WIP: [iwyu] first pass .. WIP: [iwyu] first pass Updated C++

[kudu-CR] WIP: [iwyu] first pass

2017-08-03 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4738 to look at the new patch set (#8). Change subject: WIP: [iwyu] first pass .. WIP: [iwyu] first pass Updated C++

[kudu-CR] WIP: [iwyu] first pass

2016-11-29 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4738 to look at the new patch set (#7). Change subject: WIP: [iwyu] first pass .. WIP: [iwyu] first pass Updated C++

[kudu-CR] WIP: [iwyu] first pass

2016-11-28 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4738 to look at the new patch set (#6). Change subject: WIP: [iwyu] first pass .. WIP: [iwyu] first pass Updated C++

[kudu-CR] WIP: [iwyu] first pass

2016-11-28 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: WIP: [iwyu] first pass .. Patch Set 5: > > Also, the codegen test is broken due to some unexpected reason. > I > > need to figure what went wrong with that.

[kudu-CR] WIP: [iwyu] first pass

2016-11-28 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: WIP: [iwyu] first pass .. Patch Set 5: > Also, the codegen test is broken due to some unexpected reason. I > need to figure what went wrong with that. But if

[kudu-CR] WIP: [iwyu] first pass

2016-11-28 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: WIP: [iwyu] first pass .. Patch Set 5: (3 comments) > (3 comments) > > Just did a scan through, mostly looked at fs/ and tserver/ (for > fun). > > One

[kudu-CR] WIP: [iwyu] first pass

2016-11-28 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: WIP: [iwyu] first pass .. Patch Set 5: (3 comments) Just did a scan through, mostly looked at fs/ and tserver/ (for fun). One thing comes to mind: this will

[kudu-CR] WIP: [iwyu] first pass

2016-11-28 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: WIP: [iwyu] first pass .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/4738/5/src/kudu/cfile/cfile_reader.cc File

[kudu-CR] WIP: [iwyu] first pass

2016-11-28 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: WIP: [iwyu] first pass .. Patch Set 5: (4 comments) > (5 comments) > > Only got through about 20% of the files, but it looks like there > are some cases

[kudu-CR] WIP: [iwyu] first pass

2016-11-28 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: WIP: [iwyu] first pass .. Patch Set 5: (5 comments) Only got through about 20% of the files, but it looks like there are some cases where headers are getting

[kudu-CR] WIP: [iwyu] first pass

2016-11-27 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4738 to look at the new patch set (#5). Change subject: WIP: [iwyu] first pass .. WIP: [iwyu] first pass Updated C++