[kudu-CR] doxygen for C++ client API

2016-07-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: doxygen for C++ client API .. Patch Set 9: (1 comment) > One thing we should add to this (it can be a follow-up commit). > > It needs to be integrated into

[kudu-CR] async background flush provision for C++ client

2016-07-18 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: async background flush provision for C++ client .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3668/2/src/kudu/client/client.cc File

[kudu-CR] KUDU-1311 [master] support adding and dropping range partitions

2016-07-18 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1311 [master] support adding and dropping range partitions .. Patch Set 4: (37 comments)

[kudu-CR] KUDU-1311 [master] support adding and dropping range partitions

2016-07-18 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1311 [master] support adding and dropping range partitions .. Patch Set 6: Build Started http://104.196.14.100/job/kudu-gerrit/2531/ -- To view, visit

[kudu-CR] [c++-client]: cache non-covering ranges in meta cache

2016-07-18 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: [c++-client]: cache non-covering ranges in meta cache .. Patch Set 9: Build Started http://104.196.14.100/job/kudu-gerrit/2532/ -- To view, visit

[kudu-CR] async background flush provision for C++ client

2016-07-18 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: async background flush provision for C++ client .. Patch Set 2: (62 comments) overall I think this needs more tests. Since the flusher is a thread,

[kudu-CR] WIP [java-client] Re-enable multi-master tests

2016-07-18 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: WIP [java-client] Re-enable multi-master tests .. Patch Set 2: -Verified Build Started http://104.196.14.100/job/kudu-gerrit/2530/ -- To view, visit

[kudu-CR] KUDU-1516 ksck should check for more raft-related status issues (partial)

2016-07-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1516 ksck should check for more raft-related status issues (partial) .. Patch Set 1: BTW, I tried this on a cluster with a bad table: WARNING: Unable to

[kudu-CR] WIP [java-client] Re-enable multi-master tests

2016-07-18 Thread Jean-Daniel Cryans (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3654 to look at the new patch set (#2). Change subject: WIP [java-client] Re-enable multi-master tests .. WIP

[kudu-CR] WIP [java-client] Re-enable multi-master tests

2016-07-18 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: WIP [java-client] Re-enable multi-master tests .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/2529/ -- To view, visit

[kudu-CR] KUDU-1374: send full tablet report when new leader master is detected

2016-07-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1374: send full tablet report when new leader master is detected .. Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/3643/5//COMMIT_MSG Commit

[kudu-CR] KUDU-1358 (part 3): new multi-master stress test

2016-07-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1358 (part 3): new multi-master stress test .. Patch Set 9: (4 comments)

[kudu-CR] async background flush provision for C++ client

2016-07-18 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: async background flush provision for C++ client .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/2528/ -- To view, visit

[kudu-CR] KUDU-1358 (part 2): heartbeat to every master

2016-07-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1358 (part 2): heartbeat to every master .. Patch Set 9: (4 comments) http://gerrit.cloudera.org:8080/#/c/3610/9/src/kudu/tserver/heartbeater.cc File

[kudu-CR](gh-pages) Add dropdown menu for Community nav button

2016-07-18 Thread Mike Percy (Code Review)
Mike Percy has uploaded a new patch set (#3). Change subject: Add dropdown menu for Community nav button .. Add dropdown menu for Community nav button * The dropdown is disabled on small screens * Also remove justified nav CSS

[kudu-CR](gh-pages) Add dropdown menu for Community nav button

2016-07-18 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Add dropdown menu for Community nav button .. Patch Set 2: (2 comments) > One more parting thought: might be worth a > here advising people that they shouldn't

[kudu-CR] async background flush provision for C++ client

2016-07-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: async background flush provision for C++ client .. Patch Set 1: > What was the rationale behind using a dedicated thread to manage > background flushing? I

[kudu-CR](gh-pages) Clean up community web page and add commits@ mailing list

2016-07-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Clean up community web page and add commits@ mailing list .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3666 To unsubscribe,

[kudu-CR](gh-pages) Add dropdown menu for Community nav button

2016-07-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add dropdown menu for Community nav button .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/3665/2/_includes/top_common.html File

[kudu-CR] WIP: Add time/watermark based garbage collection to ResultTracker

2016-07-18 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: WIP: Add time/watermark based garbage collection to ResultTracker .. Patch Set 12: -Verified Build Started http://104.196.14.100/job/kudu-gerrit/2527/ -- To

[kudu-CR] master: do not delete unknown tablets

2016-07-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: master: do not delete unknown tablets .. Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/3645/5//COMMIT_MSG Commit Message: Line 7: master: do not

[kudu-CR] async background flush provision for C++ client

2016-07-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: async background flush provision for C++ client .. Patch Set 1: What was the rationale behind using a dedicated thread to manage background flushing? I think

[kudu-CR](gh-pages) Add weekly update for 7/18

2016-07-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add weekly update for 7/18 .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/3671 To unsubscribe, visit

[kudu-CR](gh-pages) Update the docs webpages to reflect the master branch

2016-07-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Update the docs webpages to reflect the master branch .. Patch Set 1: The reason they're out of date is that we typically wait for a release to publish the new

[kudu-CR](gh-pages) Update the docs webpages to reflect the master branch

2016-07-18 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Update the docs webpages to reflect the master branch .. Patch Set 1: (4 comments) We should fix some "wrong docs" before regenerating this and pushing it

[kudu-CR] WIP: Add time/watermark based garbage collection to ResultTracker

2016-07-18 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: WIP: Add time/watermark based garbage collection to ResultTracker .. Patch Set 12: Build Started http://104.196.14.100/job/kudu-gerrit/2525/ -- To view, visit

[kudu-CR] WIP: Add time/watermark based garbage collection to ResultTracker

2016-07-18 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3628 to look at the new patch set (#12). Change subject: WIP: Add time/watermark based garbage collection to ResultTracker

[kudu-CR](gh-pages) Update the docs webpages to reflect the master branch

2016-07-18 Thread Dinesh Bhat (Code Review)
Hello Jean-Daniel Cryans, Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3672 to review the following change. Change subject: Update the docs webpages to reflect the master branch

[kudu-CR] KUDU-1358 (part 1): master should accept heartbeat even if follower

2016-07-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1358 (part 1): master should accept heartbeat even if follower .. Patch Set 9: (1 comment) Any way to system test this, like calling ListTabletServers

[kudu-CR] doxygen for C++ client API

2016-07-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: doxygen for C++ client API .. Patch Set 9: (65 comments) http://gerrit.cloudera.org:8080/#/c/3619/9/src/kudu/client/client.h File src/kudu/client/client.h: High

[kudu-CR](gh-pages) Add weekly update for 7/18

2016-07-18 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Add weekly update for 7/18 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3671 To unsubscribe, visit

[kudu-CR] [java client] Redo how we manage exceptions

2016-07-18 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Redo how we manage exceptions .. Patch Set 8: > hm, what's the status on this. Still waiting on Dan? Yeah I told Dan that helping out Adar

[kudu-CR] Fix flaky disk reservation-itest

2016-07-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Fix flaky disk_reservation-itest .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3652 To unsubscribe, visit

[kudu-CR] Fix flaky disk reservation-itest

2016-07-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Fix flaky disk_reservation-itest .. Fix flaky disk_reservation-itest There are two fixes in this patch for two separate types of failures seen on Jenkins

[kudu-CR](gh-pages) Add weekly update for 7/18

2016-07-18 Thread Todd Lipcon (Code Review)
Hello Jean-Daniel Cryans, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3671 to review the following change. Change subject: Add weekly update for 7/18 .. Add weekly update for 7/18

[kudu-CR] master: add assert checks for leader lock

2016-07-18 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: master: add assert checks for leader_lock .. master: add assert checks for leader_lock A side effect of recursive checking in RWMutex is that we can now

[kudu-CR] rw mutex: prevent recursive use

2016-07-18 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: rw_mutex: prevent recursive use .. rw_mutex: prevent recursive use Todd provided an example[1] of deadlocked rwlocks due to a fairness policy. In the

[kudu-CR] doxygen for C++ client API

2016-07-18 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: doxygen for C++ client API .. Patch Set 9: One thing we should add to this (it can be a follow-up commit). It needs to be integrated into make_site.sh and the web

[kudu-CR] KUDU-1492: Show column encodings/compression on table page in master Test results are in JIRA: https://issues.apache.org/jira/browse/KUDU-1492

2016-07-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-1492: Show column encodings/compression on table page in master Test results are in JIRA: https://issues.apache.org/jira/browse/KUDU-1492 .. Patch Set 1:

[kudu-CR] Memory tracking for result tracker

2016-07-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Memory tracking for result tracker .. Patch Set 18: (1 comment) I don't have any more comments except on the tests.

[kudu-CR] async background flush provision for C++ client

2016-07-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/3668 Change subject: async background flush provision for C++ client .. async background flush provision for C++ client Implemented

[kudu-CR] KUDU-1492: Show column encodings/compression on table page in master Test results are in JIRA: https://issues.apache.org/jira/browse/KUDU-1492

2016-07-18 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1492: Show column encodings/compression on table page in master Test results are in JIRA: https://issues.apache.org/jira/browse/KUDU-1492 .. Patch Set 1: (2

[kudu-CR] WIP: Add time/watermark based garbage collection to ResultTracker

2016-07-18 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: WIP: Add time/watermark based garbage collection to ResultTracker .. Patch Set 11: Build Started http://104.196.14.100/job/kudu-gerrit/2523/ -- To view, visit

[kudu-CR] WIP: Add time/watermark based garbage collection to ResultTracker

2016-07-18 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3628 to look at the new patch set (#11). Change subject: WIP: Add time/watermark based garbage collection to ResultTracker

[kudu-CR] WIP: Add time/watermark based garbage collection to ResultTracker

2016-07-18 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: WIP: Add time/watermark based garbage collection to ResultTracker .. Patch Set 10: Build Started http://104.196.14.100/job/kudu-gerrit/2522/ -- To view, visit

[kudu-CR] WIP: Add time/watermark based garbage collection to ResultTracker

2016-07-18 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3628 to look at the new patch set (#10). Change subject: WIP: Add time/watermark based garbage collection to ResultTracker

[kudu-CR] Make block manager-test work on systems without hole-punching

2016-07-18 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: Make block_manager-test work on systems without hole-punching .. Patch Set 3: (1 comment)

[kudu-CR] Make block manager-test work on systems without hole-punching

2016-07-18 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3636 to look at the new patch set (#3). Change subject: Make block_manager-test work on systems without hole-punching ..

[kudu-CR] Make block manager-test work on systems without hole-punching

2016-07-18 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Make block_manager-test work on systems without hole-punching .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/2521/ -- To view, visit

[kudu-CR] KUDU-1492: Show column encodings/compression on table page in master Test results are in JIRA: https://issues.apache.org/jira/browse/KUDU-1492

2016-07-18 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1492: Show column encodings/compression on table page in master Test results are in JIRA: https://issues.apache.org/jira/browse/KUDU-1492 .. Patch Set 1:

[kudu-CR] KUDU-1492: Show column encodings/compression on table page in master Test results are in JIRA: https://issues.apache.org/jira/browse/KUDU-1492

2016-07-18 Thread Dinesh Bhat (Code Review)
Hello Jean-Daniel Cryans, Mike Percy, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3667 to review the following change. Change subject: KUDU-1492: Show column encodings/compression on table page in master Test results are in JIRA:

[kudu-CR](gh-pages) Add dropdown menu for Community nav button

2016-07-18 Thread Mike Percy (Code Review)
Mike Percy has uploaded a new patch set (#2). Change subject: Add dropdown menu for Community nav button .. Add dropdown menu for Community nav button * The dropdown is disabled on small screens * Also remove justified nav CSS

[kudu-CR](gh-pages) Clean up community web page and add commits@ mailing list

2016-07-18 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Clean up community web page and add commits@ mailing list .. Patch Set 1: Rendered HTML at: http://mpercy.github.io/kudu/ -- To view, visit

[kudu-CR](gh-pages) Add dropdown menu for Community nav button

2016-07-18 Thread Mike Percy (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3665 to review the following change. Change subject: Add dropdown menu for Community nav button .. Add dropdown menu for