[kudu-CR](branch-0.9.x) service_pool: only log queue overflows once per second

2016-05-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: service_pool: only log queue overflows once per second .. service_pool: only log queue overflows once per second These queue overflow messages are

[kudu-CR] KUDU-1467. Fix incorrect bootstrap replay issue with UPSERT

2016-05-24 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3208 to review the following change. Change subject: KUDU-1467. Fix incorrect bootstrap replay issue with UPSERT ..

[kudu-CR] Integrate the ResultTracker into the rpc subsystem and add a test

2016-05-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Integrate the ResultTracker into the rpc subsystem and add a test .. Patch Set 6: (1 comment) This is still missing a parallel test for the failure

[kudu-CR] Move the PbTracer in rpc_context.cc to pb_util

2016-05-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: Move the PbTracer in rpc_context.cc to pb_util .. Move the PbTracer in rpc_context.cc to pb_util We'll need to use this outside of RpcContext so

[kudu-CR] Add request id and sequence number to the rpc request header

2016-05-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: Add request id and sequence number to the rpc request header .. Add request id and sequence number to the rpc request header This adds a new

[kudu-CR] Add request id and sequence number to the rpc request header

2016-05-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add request id and sequence number to the rpc request header .. Patch Set 6: submitting this. I can take care of any further comments todd has post-commit

[kudu-CR] Add a ResultTracker class that will track server side results

2016-05-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add a ResultTracker class that will track server side results .. Patch Set 6: (4 comments)

[kudu-CR] Add a ResultTracker class that will track server side results

2016-05-24 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3190 to look at the new patch set (#7). Change subject: Add a ResultTracker class that will track server side results ..

[kudu-CR] [c++-client]: minimal changes to support tables with non-covering range partitions

2016-05-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [c++-client]: minimal changes to support tables with non-covering range partitions .. Patch Set 1: (3 comments)

[kudu-CR] Remove default table partitioning

2016-05-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Remove default table partitioning .. Patch Set 9: (2 comments)

[kudu-CR] Integrate the ResultTracker into the rpc subsystem and add a test

2016-05-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Integrate the ResultTracker into the rpc subsystem and add a test .. Patch Set 6: (9 comments) It's becoming increasingly clear to me that Todd needs to take a

[kudu-CR] Allow to set RequestId in the RPC RequestHeader

2016-05-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Allow to set RequestId in the RPC RequestHeader .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/3179/2/src/kudu/rpc/rpc_controller.h File

[kudu-CR] Add a RpcContext::RespondFailure() method

2016-05-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add a RpcContext::RespondFailure() method .. Patch Set 6: This patch is incredibly confusing stand alone. I think it's better served being part of the integration

[kudu-CR] Add a ResultTracker class that will track server side results

2016-05-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add a ResultTracker class that will track server side results .. Patch Set 3: (3 comments)

[kudu-CR] Add a ResultTracker class that will track server side results

2016-05-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add a ResultTracker class that will track server side results .. Patch Set 6: (4 comments)

[kudu-CR] Move the PbTracer in rpc_context.cc to pb_util

2016-05-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Move the PbTracer in rpc_context.cc to pb_util .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3194 To unsubscribe, visit

[kudu-CR] Add a request tracker to track client rpc sequence numbers

2016-05-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add a request tracker to track client rpc sequence numbers .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3078 To unsubscribe,

[kudu-CR] Add a ResultTracker class that will track server side results

2016-05-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add a ResultTracker class that will track server side results .. Patch Set 3: (25 comments) http://gerrit.cloudera.org:8080/#/c/3190/3//COMMIT_MSG Commit

[kudu-CR] KUDU-1267: Calling getString() on RowResult for wrong type gave weird exception

2016-05-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1267: Calling getString() on RowResult for wrong type gave weird exception .. Patch Set 1: (4 comments)

[kudu-CR] Reduce verbosity of Java logs

2016-05-24 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Reduce verbosity of Java logs .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3203/1/java/kudu-client/src/test/resources/log4j.properties

[kudu-CR] Add a RpcContext::RespondFailure() method

2016-05-24 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3191 to look at the new patch set (#6). Change subject: Add a RpcContext::RespondFailure() method .. Add a

[kudu-CR] Reduce verbosity of Java logs

2016-05-24 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Reduce verbosity of Java logs .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3203/1/java/kudu-client/src/test/resources/log4j.properties

[kudu-CR] Dependency on Hadoop test classes causes Javadoc warnings and build failure

2016-05-24 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3199 to look at the new patch set (#2). Change subject: Dependency on Hadoop test classes causes Javadoc warnings and build failure

[kudu-CR] Reduce verbosity of Java logs

2016-05-24 Thread Dan Burkert (Code Review)
Hello Jean-Daniel Cryans, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3203 to review the following change. Change subject: Reduce verbosity of Java logs .. Reduce verbosity of Java logs

[kudu-CR] Add a ResultTracker class that will track server side results

2016-05-24 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3190 to look at the new patch set (#4). Change subject: Add a ResultTracker class that will track server side results ..

[kudu-CR] Integrate the ResultTracker into the rpc subsystem and add a test

2016-05-24 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3192 to look at the new patch set (#5). Change subject: Integrate the ResultTracker into the rpc subsystem and add a test

[kudu-CR] Move the PbTracer in rpc_context.cc to pb_util

2016-05-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Move the PbTracer in rpc_context.cc to pb_util .. Patch Set 2: Verified+1 unrelated flake org.kududb.client.TestKuduTable.testGetLocations -- To view,

[kudu-CR] Add request id and sequence number to the rpc request header

2016-05-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add request id and sequence number to the rpc request header .. Patch Set 6: Keeping the +2 since this was just a rebase. -- To view, visit

[kudu-CR] KUDU-1267: Calling getString() on RowResult for wrong type gave weird exception

2016-05-24 Thread Ted Malaska (Code Review)
Ted Malaska has restored this change. Change subject: KUDU-1267: Calling getString() on RowResult for wrong type gave weird exception .. Restored I am restoring -- To view, visit http://gerrit.cloudera.org:8080/3102 To

[kudu-CR] KUDU-1267: Calling getString() on RowResult for wrong type gave weird exception

2016-05-24 Thread Ted Malaska (Code Review)
Ted Malaska has abandoned this change. Change subject: KUDU-1267: Calling getString() on RowResult for wrong type gave weird exception .. Abandoned Killing this one -- To view, visit http://gerrit.cloudera.org:8080/3143 To

[kudu-CR] Remove default table partitioning

2016-05-24 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Remove default table partitioning .. Patch Set 9: Looks like only the Python tests are still failing now. -- To view, visit http://gerrit.cloudera.org:8080/3131

[kudu-CR] Dependency on Hadoop test classes causes impertinent Javadoc warnings

2016-05-24 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded a new change for review. http://gerrit.cloudera.org:8080/3199 Change subject: Dependency on Hadoop test classes causes impertinent Javadoc warnings .. Dependency on Hadoop test classes causes

[kudu-CR](branch-0.9.x) service_pool: only log queue overflows once per second

2016-05-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/3197 Change subject: service_pool: only log queue overflows once per second .. service_pool: only log queue overflows once per second These

[kudu-CR] service_pool: only log queue overflows once per second

2016-05-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: service_pool: only log queue overflows once per second .. service_pool: only log queue overflows once per second These queue overflow messages are

[kudu-CR] java: use truncated randomized exponential backoff for retries

2016-05-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: java: use truncated randomized exponential backoff for retries .. java: use truncated randomized exponential backoff for retries This changes the Java

[kudu-CR] python: add support for specifying partitioning

2016-05-24 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Wes McKinney, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3196 to review the following change. Change subject: python: add support for specifying partitioning ..

[kudu-CR] Add unique id generation to the client

2016-05-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add unique id generation to the client .. Patch Set 11: (3 comments)

[kudu-CR](branch-0.9.x) rpcz: break out trace metrics into separate PB fields

2016-05-24 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: rpcz: break out trace metrics into separate PB fields .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3195 To unsubscribe,

[kudu-CR] Move the PbTracer in rpc_context.cc to pb_util

2016-05-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Move the PbTracer in rpc_context.cc to pb_util .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3194/1/src/kudu/util/pb_util.h File

[kudu-CR] KUDU-1386 NaN float and double values are not handled correctly

2016-05-24 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1386 NaN float and double values are not handled correctly .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/3142/2/src/kudu/common/types.h

[kudu-CR] java: use truncated randomized exponential backoff for retries

2016-05-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: java: use truncated randomized exponential backoff for retries .. Patch Set 1: Code-Review+2 (1 comment)

[kudu-CR] Integrate the ResultTracker into the rpc subsystem and add a test

2016-05-24 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3192 to look at the new patch set (#4). Change subject: Integrate the ResultTracker into the rpc subsystem and add a test

[kudu-CR] Add a request tracker to track client rpc sequence numbers

2016-05-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add a request tracker to track client rpc sequence numbers .. Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/3078/7/src/kudu/rpc/request_tracker.h

[kudu-CR] Add a RpcContext::RespondFailure() method

2016-05-24 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3191 to look at the new patch set (#4). Change subject: Add a RpcContext::RespondFailure() method .. Add a

[kudu-CR] Add unique id generation to the client

2016-05-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add unique id generation to the client .. Patch Set 11: (4 comments) http://gerrit.cloudera.org:8080/#/c/3077/11/src/kudu/client/client_builder-internal.cc File

[kudu-CR] Move the PbTracer in rpc_context.cc to pb_util

2016-05-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/3194 Change subject: Move the PbTracer in rpc_context.cc to pb_util .. Move the PbTracer in rpc_context.cc to pb_util We'll need to

[kudu-CR] Add a generic retriable rpc class

2016-05-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add a generic retriable rpc class .. Patch Set 12: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3064 To unsubscribe, visit

[kudu-CR] java: use truncated randomized exponential backoff for retries

2016-05-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: java: use truncated randomized exponential backoff for retries .. Patch Set 1: (1 comment)

[kudu-CR] Move the MetaCacheServerPicker into meta_cache.h/cc

2016-05-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Move the MetaCacheServerPicker into meta_cache.h/cc .. Patch Set 15: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3028 To unsubscribe, visit

[kudu-CR] Add request id and sequence number to the rpc request header

2016-05-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add request id and sequence number to the rpc request header .. Patch Set 5: Code-Review+2 Looks good to me, leaving open for Todd. -- To view, visit

[kudu-CR] Bump the master branch's version to 1.0.0-SNAPSHOT

2016-05-24 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: Bump the master branch's version to 1.0.0-SNAPSHOT .. Bump the master branch's version to 1.0.0-SNAPSHOT Change-Id:

[kudu-CR] java: use truncated randomized exponential backoff for retries

2016-05-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: java: use truncated randomized exponential backoff for retries .. Patch Set 1: (1 comment)

[kudu-CR] Change flush defaults to encourage parallel IO and larger flushes

2016-05-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Change flush defaults to encourage parallel IO and larger flushes .. Patch Set 2: (2 comments)

[kudu-CR] rpcz: break out trace metrics into separate PB fields

2016-05-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: rpcz: break out trace metrics into separate PB fields .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3092 To unsubscribe, visit

[kudu-CR] KUDU-1267: Calling getString() on RowResult for wrong type gave weird exception

2016-05-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1267: Calling getString() on RowResult for wrong type gave weird exception .. Patch Set 1: Let's assume that your Kudu repo is checked out to whatever local

[kudu-CR] KUDU-1307 [master] support tables with range partition bounds

2016-05-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1307 [master] support tables with range partition bounds .. Patch Set 10: (9 comments) http://gerrit.cloudera.org:8080/#/c/2806/10//COMMIT_MSG Commit

[kudu-CR] Fix typo in RPC design doc

2016-05-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Fix typo in RPC design doc .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3153 To unsubscribe, visit

[kudu-CR] KUDU-1267: Calling getString() on RowResult for wrong type gave weird exception

2016-05-24 Thread Ted Malaska (Code Review)
Ted Malaska has abandoned this change. Change subject: KUDU-1267: Calling getString() on RowResult for wrong type gave weird exception .. Abandoned I released a newer version -- To view, visit

[kudu-CR] Non-covering Range Partitions design doc

2016-05-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Non-covering Range Partitions design doc .. Patch Set 10: Code-Review+2 Seems fine to me. Not sure what other feedback you're looking to collect, or whether the

[kudu-CR] Fix typo in RPC design doc

2016-05-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Fix typo in RPC design doc .. Patch Set 1: Code-Review+2 Test failures are from the change this is based on. Rebase and you should be fine. -- To view, visit

[kudu-CR] KUDU-1267: Calling getString() on RowResult for wrong type gave weird exception

2016-05-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1267: Calling getString() on RowResult for wrong type gave weird exception .. Patch Set 1: Hey Ted, looks like you created another Gerrit change instead of

[kudu-CR] Integrate the ResultTracker into the rpc subsystem and add a test

2016-05-24 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3192 to look at the new patch set (#2). Change subject: Integrate the ResultTracker into the rpc subsystem and add a test

[kudu-CR] Add a ResultTracker class that will track server side results

2016-05-24 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3190 to look at the new patch set (#2). Change subject: Add a ResultTracker class that will track server side results ..

[kudu-CR] Add a RpcContext::RespondFailure() method

2016-05-24 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3191 to look at the new patch set (#2). Change subject: Add a RpcContext::RespondFailure() method .. Add a

[kudu-CR] Add a ResultTracker class that will track server side results

2016-05-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/3190 Change subject: Add a ResultTracker class that will track server side results .. Add a ResultTracker class that will track server

[kudu-CR] service_pool: only log queue overflows once per second

2016-05-24 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: service_pool: only log queue overflows once per second .. Patch Set 1: Code-Review+2 Looks good for branch-0.9.x too. -- To view, visit