Todd Lipcon has posted comments on this change.
Change subject: Remove a stray WARNING left in deltafile.cc
..
Patch Set 1: Code-Review+2
Going to self-+2 this one since it's trivial
--
To view, visit http://gerrit.cloudera.o
Todd Lipcon has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3211
Change subject: Remove a stray WARNING left in deltafile.cc
..
Remove a stray WARNING left in deltafile.cc
This was a debugging warning th
Todd Lipcon has posted comments on this change.
Change subject: KUDU-1444. Get resource metrics of a scan.
..
Patch Set 5:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/3013/5/src/kudu/client/client.h
File src/kudu/client/c
Todd Lipcon has submitted this change and it was merged.
Change subject: java: use truncated randomized exponential backoff for retries
..
java: use truncated randomized exponential backoff for retries
This changes the Java cli
Todd Lipcon has posted comments on this change.
Change subject: KUDU-745 / KUDU-1463 tablet's table id attribute is empty string
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3183
To unsubscri
Todd Lipcon has submitted this change and it was merged.
Change subject: KUDU-745 / KUDU-1463 tablet's table id attribute is empty string
..
KUDU-745 / KUDU-1463 tablet's table id attribute is empty string
This fixes the issue
Todd Lipcon has posted comments on this change.
Change subject: Change flush defaults to encourage parallel IO and larger
flushes
..
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/3186/2/src/kudu/cfile/cfile_wr
Hello Jean-Daniel Cryans,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3186
to look at the new patch set (#3).
Change subject: Change flush defaults to encourage parallel IO and larger
flushes
Todd Lipcon has submitted this change and it was merged.
Change subject: service_pool: only log queue overflows once per second
..
service_pool: only log queue overflows once per second
These queue overflow messages are extreme
Hello David Ribeiro Alves,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3208
to review the following change.
Change subject: KUDU-1467. Fix incorrect bootstrap replay issue with UPSERT
..
David Ribeiro Alves has posted comments on this change.
Change subject: Integrate the ResultTracker into the rpc subsystem and add a
test
..
Patch Set 6:
(1 comment)
This is still missing a parallel test for the failure case.
David Ribeiro Alves has posted comments on this change.
Change subject: Add a RpcContext::RespondFailure() method
..
Patch Set 6:
That's fair. I separated this mostly so that I can explain why I needed it in
the commit message
David Ribeiro Alves has submitted this change and it was merged.
Change subject: Move the PbTracer in rpc_context.cc to pb_util
..
Move the PbTracer in rpc_context.cc to pb_util
We'll need to use this outside of RpcContext so t
David Ribeiro Alves has submitted this change and it was merged.
Change subject: Add a request tracker to track client rpc sequence numbers
..
Add a request tracker to track client rpc sequence numbers
This adds a new component
David Ribeiro Alves has submitted this change and it was merged.
Change subject: Add request id and sequence number to the rpc request header
..
Add request id and sequence number to the rpc request header
This adds a new (opti
David Ribeiro Alves has posted comments on this change.
Change subject: Add request id and sequence number to the rpc request header
..
Patch Set 6:
submitting this. I can take care of any further comments todd has post-commit
David Ribeiro Alves has posted comments on this change.
Change subject: Add a ResultTracker class that will track server side results
..
Patch Set 6:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/3190/6/src/kudu/rpc/result_
David Ribeiro Alves has posted comments on this change.
Change subject: Add a ResultTracker class that will track server side results
..
Patch Set 3:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/3190/3/src/kudu/rpc/result_
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3190
to look at the new patch set (#7).
Change subject: Add a ResultTracker class that will track server side results
..
Adar Dembo has posted comments on this change.
Change subject: [c++-client]: minimal changes to support tables with
non-covering range partitions
..
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/3177/1/src/kud
Adar Dembo has posted comments on this change.
Change subject: Remove default table partitioning
..
Patch Set 9:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/3131/9/java/kudu-client/src/test/java/org/kududb/client/TestKudu
Adar Dembo has posted comments on this change.
Change subject: Integrate the ResultTracker into the rpc subsystem and add a
test
..
Patch Set 6:
(9 comments)
It's becoming increasingly clear to me that Todd needs to take a de
Adar Dembo has posted comments on this change.
Change subject: Allow to set RequestId in the RPC RequestHeader
..
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/3179/2/src/kudu/rpc/rpc_controller.h
File src/kudu
Adar Dembo has posted comments on this change.
Change subject: Add unique id generation to the client
..
Patch Set 11:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3077/11/src/kudu/integration-tests/client-stress-test.cc
Fi
Adar Dembo has posted comments on this change.
Change subject: Add unique id generation to the client
..
Patch Set 10:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3077/10//COMMIT_MSG
Commit Message:
Line 10: an uuid. The
Adar Dembo has posted comments on this change.
Change subject: Add a RpcContext::RespondFailure() method
..
Patch Set 6:
This patch is incredibly confusing stand alone. I think it's better served
being part of the integration
Adar Dembo has posted comments on this change.
Change subject: Add a ResultTracker class that will track server side results
..
Patch Set 3:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/3190/3/src/kudu/rpc/result_tracker.c
Adar Dembo has posted comments on this change.
Change subject: Add a ResultTracker class that will track server side results
..
Patch Set 6:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/3190/6/src/kudu/rpc/result_tracker.h
Adar Dembo has posted comments on this change.
Change subject: Move the PbTracer in rpc_context.cc to pb_util
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3194
To unsubscribe, visit http://ge
Adar Dembo has posted comments on this change.
Change subject: Add a request tracker to track client rpc sequence numbers
..
Patch Set 8: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3078
To unsubscribe, vis
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3190
to look at the new patch set (#6).
Change subject: Add a ResultTracker class that will track server side results
..
Adar Dembo has posted comments on this change.
Change subject: KUDU-1267: Calling getString() on RowResult for wrong type gave
weird exception
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3102/3/java/kudu-c
David Ribeiro Alves has posted comments on this change.
Change subject: Add a ResultTracker class that will track server side results
..
Patch Set 3:
(25 comments)
http://gerrit.cloudera.org:8080/#/c/3190/3//COMMIT_MSG
Commit
Will Berkeley has posted comments on this change.
Change subject: Dependency on Hadoop test classes causes Javadoc warnings and
build failure
..
Patch Set 2:
What unit test do you mean? Neither JarFinder or the function that c
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3102
to look at the new patch set (#3).
Change subject: KUDU-1267: Calling getString() on RowResult for wrong type gave
weird exception
Adar Dembo has posted comments on this change.
Change subject: KUDU-1267: Calling getString() on RowResult for wrong type gave
weird exception
..
Patch Set 1:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/3102/1/java/kudu-
Adar Dembo has posted comments on this change.
Change subject: KUDU-1267: Calling getString() on RowResult for wrong type gave
weird exception
..
Patch Set 2:
Thanks for making some changes. There were several suggestions you
Jean-Daniel Cryans has posted comments on this change.
Change subject: Reduce verbosity of Java logs
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3203/1/java/kudu-client/src/test/resources/log4j.properties
F
Adar Dembo has posted comments on this change.
Change subject: Reduce verbosity of Java logs
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/3203/1/java/kudu-client/src/test/java/org/kududb/client/MiniKuduClus
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3192
to look at the new patch set (#6).
Change subject: Integrate the ResultTracker into the rpc subsystem and add a
test
..
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3190
to look at the new patch set (#5).
Change subject: Add a ResultTracker class that will track server side results
..
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3191
to look at the new patch set (#6).
Change subject: Add a RpcContext::RespondFailure() method
..
Add a RpcContext::R
Jean-Daniel Cryans has posted comments on this change.
Change subject: Dependency on Hadoop test classes causes Javadoc warnings and
build failure
..
Patch Set 2:
Can you also pull its unit test?
--
To view, visit http://ger
Jean-Daniel Cryans has posted comments on this change.
Change subject: Reduce verbosity of Java logs
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3203/1/java/kudu-client/src/test/resources/log4j.properties
F
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3199
to look at the new patch set (#2).
Change subject: Dependency on Hadoop test classes causes Javadoc warnings and
build failure
Hello Jean-Daniel Cryans,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3203
to review the following change.
Change subject: Reduce verbosity of Java logs
..
Reduce verbosity of Java logs
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3190
to look at the new patch set (#4).
Change subject: Add a ResultTracker class that will track server side results
..
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3192
to look at the new patch set (#5).
Change subject: Integrate the ResultTracker into the rpc subsystem and add a
test
..
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3191
to look at the new patch set (#5).
Change subject: Add a RpcContext::RespondFailure() method
..
Add a RpcContext::R
David Ribeiro Alves has posted comments on this change.
Change subject: Move the PbTracer in rpc_context.cc to pb_util
..
Patch Set 2: Verified+1
unrelated flake org.kududb.client.TestKuduTable.testGetLocations
--
To view, vi
Wes McKinney has posted comments on this change.
Change subject: python: add support for specifying partitioning
..
Patch Set 1:
This seems reasonable to me. If you anticipate partitioning options growing in
complexity, then p
David Ribeiro Alves has posted comments on this change.
Change subject: Add request id and sequence number to the rpc request header
..
Patch Set 6:
Keeping the +2 since this was just a rebase.
--
To view, visit http://gerrit
David Ribeiro Alves has posted comments on this change.
Change subject: Add request id and sequence number to the rpc request header
..
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3079
To unsub
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3102
to look at the new patch set (#2).
Change subject: KUDU-1267: Calling getString() on RowResult for wrong type gave
weird exception
Ted Malaska has restored this change.
Change subject: KUDU-1267: Calling getString() on RowResult for wrong type gave
weird exception
..
Restored
I am restoring
--
To view, visit http://gerrit.cloudera.org:8080/3102
To unsub
Ted Malaska has abandoned this change.
Change subject: KUDU-1267: Calling getString() on RowResult for wrong type gave
weird exception
..
Abandoned
Killing this one
--
To view, visit http://gerrit.cloudera.org:8080/3143
To u
Dan Burkert has posted comments on this change.
Change subject: Remove default table partitioning
..
Patch Set 9:
Looks like only the Python tests are still failing now.
--
To view, visit http://gerrit.cloudera.org:8080/3131
Dan Burkert has submitted this change and it was merged.
Change subject: Fix typo in RPC design doc
..
Fix typo in RPC design doc
Change-Id: I43ed70a07b5b54bffb72997e23ec02e3d1ccaecc
Reviewed-on: http://gerrit.cloudera.org:8080
Dan Burkert has posted comments on this change.
Change subject: Fix typo in RPC design doc
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3153
To unsubscribe, visit http://gerrit.cloudera.org:8
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3194
to look at the new patch set (#2).
Change subject: Move the PbTracer in rpc_context.cc to pb_util
..
Move the PbTra
Jean-Daniel Cryans has posted comments on this change.
Change subject: java: use truncated randomized exponential backoff for retries
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3198
To unsu
Jean-Daniel Cryans has posted comments on this change.
Change subject: service_pool: only log queue overflows once per second
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3197
To unsubscribe,
Will Berkeley has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3199
Change subject: Dependency on Hadoop test classes causes impertinent Javadoc
warnings
..
Dependency on Hadoop test classes causes impert
Todd Lipcon has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3197
Change subject: service_pool: only log queue overflows once per second
..
service_pool: only log queue overflows once per second
These que
Todd Lipcon has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3198
Change subject: java: use truncated randomized exponential backoff for retries
..
java: use truncated randomized exponential backoff for re
Todd Lipcon has submitted this change and it was merged.
Change subject: service_pool: only log queue overflows once per second
..
service_pool: only log queue overflows once per second
These queue overflow messages are extreme
Todd Lipcon has submitted this change and it was merged.
Change subject: java: use truncated randomized exponential backoff for retries
..
java: use truncated randomized exponential backoff for retries
This changes the Java cli
Todd Lipcon has posted comments on this change.
Change subject: python: add support for specifying partitioning
..
Patch Set 1:
Wes -- would appreciate thoughts on whether this API is reasonably "pythonic"
or if there's a bett
Hello Dan Burkert, Wes McKinney,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3196
to review the following change.
Change subject: python: add support for specifying partitioning
..
pytho
David Ribeiro Alves has posted comments on this change.
Change subject: Add unique id generation to the client
..
Patch Set 11:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/3077/11/src/kudu/client/client_builder-internal.c
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3077
to look at the new patch set (#12).
Change subject: Add unique id generation to the client
..
Add unique id generat
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3179
to look at the new patch set (#2).
Change subject: Allow to set RequestId in the RPC RequestHeader
..
Allow to set
Hello Adar Dembo, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3153
to look at the new patch set (#3).
Change subject: Fix typo in RPC design doc
..
Fix typo in RPC design
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3131
to look at the new patch set (#9).
Change subject: Remove default table partitioning
..
Remove default table partit
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3078
to look at the new patch set (#8).
Change subject: Add a request tracker to track client rpc sequence numbers
..
Ad
Hello Adar Dembo, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3079
to look at the new patch set (#6).
Change subject: Add request id and sequence number to the rpc request header
David Ribeiro Alves has posted comments on this change.
Change subject: Add a request tracker to track client rpc sequence numbers
..
Patch Set 7:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/3078/7/src/kudu/rpc/request_tr
Jean-Daniel Cryans has posted comments on this change.
Change subject: rpcz: break out trace metrics into separate PB fields
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3195
To unsubscribe,
Jean-Daniel Cryans has submitted this change and it was merged.
Change subject: rpcz: break out trace metrics into separate PB fields
..
rpcz: break out trace metrics into separate PB fields
This removes the trace metrics from
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3131
to look at the new patch set (#8).
Change subject: Remove default table partitioning
..
Remove default table partit
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3131
to look at the new patch set (#7).
Change subject: Remove default table partitioning
..
Remove default table partit
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3131
to look at the new patch set (#6).
Change subject: Remove default table partitioning
..
Remove default table partit
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3131
to look at the new patch set (#5).
Change subject: Remove default table partitioning
..
Remove default table partit
Dan Burkert has submitted this change and it was merged.
Change subject: Bump maven-assembly-plugin version
..
Bump maven-assembly-plugin version
The previous version spewed useless log lines at INFO level. With this change,
a
Adar Dembo has posted comments on this change.
Change subject: Move the PbTracer in rpc_context.cc to pb_util
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3194/1/src/kudu/util/pb_util.h
File src/kudu/util/pb
Adar Dembo has posted comments on this change.
Change subject: Add a ResultTracker class that will track server side results
..
Patch Set 3:
(25 comments)
I did a light first pass.
Overall I think this needs more documentatio
Todd Lipcon has submitted this change and it was merged.
Change subject: rpcz: break out trace metrics into separate PB fields
..
rpcz: break out trace metrics into separate PB fields
This removes the trace metrics from the tex
Todd Lipcon has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3195
Change subject: rpcz: break out trace metrics into separate PB fields
..
rpcz: break out trace metrics into separate PB fields
This remove
Adar Dembo has posted comments on this change.
Change subject: Make BuildLog() return Status
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3134
To unsubscribe, visit http://gerrit.cloudera.org
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3142
to look at the new patch set (#3).
Change subject: KUDU-1386 NaN float and double values are not handled correctly
.
Will Berkeley has posted comments on this change.
Change subject: KUDU-1386 NaN float and double values are not handled correctly
..
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/3142/2/src/kudu/common/types.h
David Ribeiro Alves has posted comments on this change.
Change subject: Add unique id generation to the client
..
Patch Set 11:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3077/11/src/kudu/integration-tests/client-stress-t
Jean-Daniel Cryans has posted comments on this change.
Change subject: Bump maven-assembly-plugin version
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3193
To unsubscribe, visit http://gerrit
Todd Lipcon has posted comments on this change.
Change subject: KUDU-1386 NaN float and double values are not handled correctly
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3142/1/src/kudu/common/types.h
Fil
Hello Jean-Daniel Cryans,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3193
to look at the new patch set (#2).
Change subject: Bump maven-assembly-plugin version
..
Bump maven-assembly-
Adar Dembo has posted comments on this change.
Change subject: java: use truncated randomized exponential backoff for retries
..
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3184/1/java/kudu-clien
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3131
to look at the new patch set (#4).
Change subject: Remove default table partitioning
..
Remove default table partit
David Ribeiro Alves has submitted this change and it was merged.
Change subject: Add a generic retriable rpc class
..
Add a generic retriable rpc class
This patch adds a new, generic, class for retriable Rpcs: RetriableRpc.
Thi
David Ribeiro Alves has submitted this change and it was merged.
Change subject: Move the MetaCacheServerPicker into meta_cache.h/cc
..
Move the MetaCacheServerPicker into meta_cache.h/cc
This moves the MetaCacheServerPicker in
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3192
to look at the new patch set (#4).
Change subject: Integrate the ResultTracker into the rpc subsystem and add a
test
..
1 - 100 of 144 matches
Mail list logo