[kudu-CR] Remove a stray WARNING left in deltafile.cc

2016-05-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Remove a stray WARNING left in deltafile.cc .. Patch Set 1: Code-Review+2 Going to self-+2 this one since it's trivial -- To view, visit http://gerrit.cloudera.o

[kudu-CR] Remove a stray WARNING left in deltafile.cc

2016-05-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/3211 Change subject: Remove a stray WARNING left in deltafile.cc .. Remove a stray WARNING left in deltafile.cc This was a debugging warning th

[kudu-CR] KUDU-1444. Get resource metrics of a scan.

2016-05-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1444. Get resource metrics of a scan. .. Patch Set 5: (7 comments) http://gerrit.cloudera.org:8080/#/c/3013/5/src/kudu/client/client.h File src/kudu/client/c

[kudu-CR](branch-0.9.x) java: use truncated randomized exponential backoff for retries

2016-05-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: java: use truncated randomized exponential backoff for retries .. java: use truncated randomized exponential backoff for retries This changes the Java cli

[kudu-CR] KUDU-745 / KUDU-1463 tablet's table id attribute is empty string

2016-05-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-745 / KUDU-1463 tablet's table id attribute is empty string .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3183 To unsubscri

[kudu-CR] KUDU-745 / KUDU-1463 tablet's table id attribute is empty string

2016-05-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-745 / KUDU-1463 tablet's table id attribute is empty string .. KUDU-745 / KUDU-1463 tablet's table id attribute is empty string This fixes the issue

[kudu-CR] Change flush defaults to encourage parallel IO and larger flushes

2016-05-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Change flush defaults to encourage parallel IO and larger flushes .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/3186/2/src/kudu/cfile/cfile_wr

[kudu-CR] Change flush defaults to encourage parallel IO and larger flushes

2016-05-24 Thread Todd Lipcon (Code Review)
Hello Jean-Daniel Cryans, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3186 to look at the new patch set (#3). Change subject: Change flush defaults to encourage parallel IO and larger flushes

[kudu-CR](branch-0.9.x) service_pool: only log queue overflows once per second

2016-05-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: service_pool: only log queue overflows once per second .. service_pool: only log queue overflows once per second These queue overflow messages are extreme

[kudu-CR] KUDU-1467. Fix incorrect bootstrap replay issue with UPSERT

2016-05-24 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3208 to review the following change. Change subject: KUDU-1467. Fix incorrect bootstrap replay issue with UPSERT ..

[kudu-CR] Integrate the ResultTracker into the rpc subsystem and add a test

2016-05-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Integrate the ResultTracker into the rpc subsystem and add a test .. Patch Set 6: (1 comment) This is still missing a parallel test for the failure case.

[kudu-CR] Add a RpcContext::RespondFailure() method

2016-05-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add a RpcContext::RespondFailure() method .. Patch Set 6: That's fair. I separated this mostly so that I can explain why I needed it in the commit message

[kudu-CR] Move the PbTracer in rpc_context.cc to pb_util

2016-05-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: Move the PbTracer in rpc_context.cc to pb_util .. Move the PbTracer in rpc_context.cc to pb_util We'll need to use this outside of RpcContext so t

[kudu-CR] Add a request tracker to track client rpc sequence numbers

2016-05-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: Add a request tracker to track client rpc sequence numbers .. Add a request tracker to track client rpc sequence numbers This adds a new component

[kudu-CR] Add request id and sequence number to the rpc request header

2016-05-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: Add request id and sequence number to the rpc request header .. Add request id and sequence number to the rpc request header This adds a new (opti

[kudu-CR] Add request id and sequence number to the rpc request header

2016-05-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add request id and sequence number to the rpc request header .. Patch Set 6: submitting this. I can take care of any further comments todd has post-commit

[kudu-CR] Add a ResultTracker class that will track server side results

2016-05-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add a ResultTracker class that will track server side results .. Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/3190/6/src/kudu/rpc/result_

[kudu-CR] Add a ResultTracker class that will track server side results

2016-05-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add a ResultTracker class that will track server side results .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/3190/3/src/kudu/rpc/result_

[kudu-CR] Add a ResultTracker class that will track server side results

2016-05-24 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3190 to look at the new patch set (#7). Change subject: Add a ResultTracker class that will track server side results ..

[kudu-CR] [c++-client]: minimal changes to support tables with non-covering range partitions

2016-05-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [c++-client]: minimal changes to support tables with non-covering range partitions .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/3177/1/src/kud

[kudu-CR] Remove default table partitioning

2016-05-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Remove default table partitioning .. Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/3131/9/java/kudu-client/src/test/java/org/kududb/client/TestKudu

[kudu-CR] Integrate the ResultTracker into the rpc subsystem and add a test

2016-05-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Integrate the ResultTracker into the rpc subsystem and add a test .. Patch Set 6: (9 comments) It's becoming increasingly clear to me that Todd needs to take a de

[kudu-CR] Allow to set RequestId in the RPC RequestHeader

2016-05-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Allow to set RequestId in the RPC RequestHeader .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/3179/2/src/kudu/rpc/rpc_controller.h File src/kudu

[kudu-CR] Add unique id generation to the client

2016-05-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add unique id generation to the client .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/3077/11/src/kudu/integration-tests/client-stress-test.cc Fi

[kudu-CR] Add unique id generation to the client

2016-05-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add unique id generation to the client .. Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/3077/10//COMMIT_MSG Commit Message: Line 10: an uuid. The

[kudu-CR] Add a RpcContext::RespondFailure() method

2016-05-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add a RpcContext::RespondFailure() method .. Patch Set 6: This patch is incredibly confusing stand alone. I think it's better served being part of the integration

[kudu-CR] Add a ResultTracker class that will track server side results

2016-05-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add a ResultTracker class that will track server side results .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/3190/3/src/kudu/rpc/result_tracker.c

[kudu-CR] Add a ResultTracker class that will track server side results

2016-05-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add a ResultTracker class that will track server side results .. Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/3190/6/src/kudu/rpc/result_tracker.h

[kudu-CR] Move the PbTracer in rpc_context.cc to pb_util

2016-05-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Move the PbTracer in rpc_context.cc to pb_util .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3194 To unsubscribe, visit http://ge

[kudu-CR] Add a request tracker to track client rpc sequence numbers

2016-05-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add a request tracker to track client rpc sequence numbers .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3078 To unsubscribe, vis

[kudu-CR] Add a ResultTracker class that will track server side results

2016-05-24 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3190 to look at the new patch set (#6). Change subject: Add a ResultTracker class that will track server side results ..

[kudu-CR] KUDU-1267: Calling getString() on RowResult for wrong type gave weird exception

2016-05-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1267: Calling getString() on RowResult for wrong type gave weird exception .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/3102/3/java/kudu-c

[kudu-CR] Add a ResultTracker class that will track server side results

2016-05-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add a ResultTracker class that will track server side results .. Patch Set 3: (25 comments) http://gerrit.cloudera.org:8080/#/c/3190/3//COMMIT_MSG Commit

[kudu-CR] Dependency on Hadoop test classes causes Javadoc warnings and build failure

2016-05-24 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: Dependency on Hadoop test classes causes Javadoc warnings and build failure .. Patch Set 2: What unit test do you mean? Neither JarFinder or the function that c

[kudu-CR] KUDU-1267: Calling getString() on RowResult for wrong type gave weird exception

2016-05-24 Thread Ted Malaska (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3102 to look at the new patch set (#3). Change subject: KUDU-1267: Calling getString() on RowResult for wrong type gave weird exception

[kudu-CR] KUDU-1267: Calling getString() on RowResult for wrong type gave weird exception

2016-05-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1267: Calling getString() on RowResult for wrong type gave weird exception .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/3102/1/java/kudu-

[kudu-CR] KUDU-1267: Calling getString() on RowResult for wrong type gave weird exception

2016-05-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1267: Calling getString() on RowResult for wrong type gave weird exception .. Patch Set 2: Thanks for making some changes. There were several suggestions you

[kudu-CR] Reduce verbosity of Java logs

2016-05-24 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Reduce verbosity of Java logs .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3203/1/java/kudu-client/src/test/resources/log4j.properties F

[kudu-CR] Reduce verbosity of Java logs

2016-05-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Reduce verbosity of Java logs .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/3203/1/java/kudu-client/src/test/java/org/kududb/client/MiniKuduClus

[kudu-CR] Integrate the ResultTracker into the rpc subsystem and add a test

2016-05-24 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3192 to look at the new patch set (#6). Change subject: Integrate the ResultTracker into the rpc subsystem and add a test ..

[kudu-CR] Add a ResultTracker class that will track server side results

2016-05-24 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3190 to look at the new patch set (#5). Change subject: Add a ResultTracker class that will track server side results ..

[kudu-CR] Add a RpcContext::RespondFailure() method

2016-05-24 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3191 to look at the new patch set (#6). Change subject: Add a RpcContext::RespondFailure() method .. Add a RpcContext::R

[kudu-CR] Dependency on Hadoop test classes causes Javadoc warnings and build failure

2016-05-24 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Dependency on Hadoop test classes causes Javadoc warnings and build failure .. Patch Set 2: Can you also pull its unit test? -- To view, visit http://ger

[kudu-CR] Reduce verbosity of Java logs

2016-05-24 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Reduce verbosity of Java logs .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3203/1/java/kudu-client/src/test/resources/log4j.properties F

[kudu-CR] Dependency on Hadoop test classes causes Javadoc warnings and build failure

2016-05-24 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3199 to look at the new patch set (#2). Change subject: Dependency on Hadoop test classes causes Javadoc warnings and build failure

[kudu-CR] Reduce verbosity of Java logs

2016-05-24 Thread Dan Burkert (Code Review)
Hello Jean-Daniel Cryans, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3203 to review the following change. Change subject: Reduce verbosity of Java logs .. Reduce verbosity of Java logs

[kudu-CR] Add a ResultTracker class that will track server side results

2016-05-24 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3190 to look at the new patch set (#4). Change subject: Add a ResultTracker class that will track server side results ..

[kudu-CR] Integrate the ResultTracker into the rpc subsystem and add a test

2016-05-24 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3192 to look at the new patch set (#5). Change subject: Integrate the ResultTracker into the rpc subsystem and add a test ..

[kudu-CR] Add a RpcContext::RespondFailure() method

2016-05-24 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3191 to look at the new patch set (#5). Change subject: Add a RpcContext::RespondFailure() method .. Add a RpcContext::R

[kudu-CR] Move the PbTracer in rpc_context.cc to pb_util

2016-05-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Move the PbTracer in rpc_context.cc to pb_util .. Patch Set 2: Verified+1 unrelated flake org.kududb.client.TestKuduTable.testGetLocations -- To view, vi

[kudu-CR] python: add support for specifying partitioning

2016-05-24 Thread Wes McKinney (Code Review)
Wes McKinney has posted comments on this change. Change subject: python: add support for specifying partitioning .. Patch Set 1: This seems reasonable to me. If you anticipate partitioning options growing in complexity, then p

[kudu-CR] Add request id and sequence number to the rpc request header

2016-05-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add request id and sequence number to the rpc request header .. Patch Set 6: Keeping the +2 since this was just a rebase. -- To view, visit http://gerrit

[kudu-CR] Add request id and sequence number to the rpc request header

2016-05-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add request id and sequence number to the rpc request header .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3079 To unsub

[kudu-CR] KUDU-1267: Calling getString() on RowResult for wrong type gave weird exception

2016-05-24 Thread Ted Malaska (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3102 to look at the new patch set (#2). Change subject: KUDU-1267: Calling getString() on RowResult for wrong type gave weird exception

[kudu-CR] KUDU-1267: Calling getString() on RowResult for wrong type gave weird exception

2016-05-24 Thread Ted Malaska (Code Review)
Ted Malaska has restored this change. Change subject: KUDU-1267: Calling getString() on RowResult for wrong type gave weird exception .. Restored I am restoring -- To view, visit http://gerrit.cloudera.org:8080/3102 To unsub

[kudu-CR] KUDU-1267: Calling getString() on RowResult for wrong type gave weird exception

2016-05-24 Thread Ted Malaska (Code Review)
Ted Malaska has abandoned this change. Change subject: KUDU-1267: Calling getString() on RowResult for wrong type gave weird exception .. Abandoned Killing this one -- To view, visit http://gerrit.cloudera.org:8080/3143 To u

[kudu-CR] Remove default table partitioning

2016-05-24 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Remove default table partitioning .. Patch Set 9: Looks like only the Python tests are still failing now. -- To view, visit http://gerrit.cloudera.org:8080/3131

[kudu-CR] Fix typo in RPC design doc

2016-05-24 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: Fix typo in RPC design doc .. Fix typo in RPC design doc Change-Id: I43ed70a07b5b54bffb72997e23ec02e3d1ccaecc Reviewed-on: http://gerrit.cloudera.org:8080

[kudu-CR] Fix typo in RPC design doc

2016-05-24 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Fix typo in RPC design doc .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3153 To unsubscribe, visit http://gerrit.cloudera.org:8

[kudu-CR] Move the PbTracer in rpc_context.cc to pb_util

2016-05-24 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3194 to look at the new patch set (#2). Change subject: Move the PbTracer in rpc_context.cc to pb_util .. Move the PbTra

[kudu-CR](branch-0.9.x) java: use truncated randomized exponential backoff for retries

2016-05-24 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: java: use truncated randomized exponential backoff for retries .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3198 To unsu

[kudu-CR](branch-0.9.x) service_pool: only log queue overflows once per second

2016-05-24 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: service_pool: only log queue overflows once per second .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3197 To unsubscribe,

[kudu-CR] Dependency on Hadoop test classes causes impertinent Javadoc warnings

2016-05-24 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded a new change for review. http://gerrit.cloudera.org:8080/3199 Change subject: Dependency on Hadoop test classes causes impertinent Javadoc warnings .. Dependency on Hadoop test classes causes impert

[kudu-CR](branch-0.9.x) service_pool: only log queue overflows once per second

2016-05-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/3197 Change subject: service_pool: only log queue overflows once per second .. service_pool: only log queue overflows once per second These que

[kudu-CR](branch-0.9.x) java: use truncated randomized exponential backoff for retries

2016-05-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/3198 Change subject: java: use truncated randomized exponential backoff for retries .. java: use truncated randomized exponential backoff for re

[kudu-CR] service_pool: only log queue overflows once per second

2016-05-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: service_pool: only log queue overflows once per second .. service_pool: only log queue overflows once per second These queue overflow messages are extreme

[kudu-CR] java: use truncated randomized exponential backoff for retries

2016-05-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: java: use truncated randomized exponential backoff for retries .. java: use truncated randomized exponential backoff for retries This changes the Java cli

[kudu-CR] python: add support for specifying partitioning

2016-05-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: python: add support for specifying partitioning .. Patch Set 1: Wes -- would appreciate thoughts on whether this API is reasonably "pythonic" or if there's a bett

[kudu-CR] python: add support for specifying partitioning

2016-05-24 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Wes McKinney, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3196 to review the following change. Change subject: python: add support for specifying partitioning .. pytho

[kudu-CR] Add unique id generation to the client

2016-05-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add unique id generation to the client .. Patch Set 11: (3 comments) http://gerrit.cloudera.org:8080/#/c/3077/11/src/kudu/client/client_builder-internal.c

[kudu-CR] Add unique id generation to the client

2016-05-24 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3077 to look at the new patch set (#12). Change subject: Add unique id generation to the client .. Add unique id generat

[kudu-CR] Allow to set RequestId in the RPC RequestHeader

2016-05-24 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3179 to look at the new patch set (#2). Change subject: Allow to set RequestId in the RPC RequestHeader .. Allow to set

[kudu-CR] Fix typo in RPC design doc

2016-05-24 Thread Dan Burkert (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3153 to look at the new patch set (#3). Change subject: Fix typo in RPC design doc .. Fix typo in RPC design

[kudu-CR] Remove default table partitioning

2016-05-24 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3131 to look at the new patch set (#9). Change subject: Remove default table partitioning .. Remove default table partit

[kudu-CR] Add a request tracker to track client rpc sequence numbers

2016-05-24 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3078 to look at the new patch set (#8). Change subject: Add a request tracker to track client rpc sequence numbers .. Ad

[kudu-CR] Add request id and sequence number to the rpc request header

2016-05-24 Thread David Ribeiro Alves (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3079 to look at the new patch set (#6). Change subject: Add request id and sequence number to the rpc request header

[kudu-CR] Add a request tracker to track client rpc sequence numbers

2016-05-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add a request tracker to track client rpc sequence numbers .. Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/3078/7/src/kudu/rpc/request_tr

[kudu-CR](branch-0.9.x) rpcz: break out trace metrics into separate PB fields

2016-05-24 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: rpcz: break out trace metrics into separate PB fields .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3195 To unsubscribe,

[kudu-CR](branch-0.9.x) rpcz: break out trace metrics into separate PB fields

2016-05-24 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: rpcz: break out trace metrics into separate PB fields .. rpcz: break out trace metrics into separate PB fields This removes the trace metrics from

[kudu-CR] Remove default table partitioning

2016-05-24 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3131 to look at the new patch set (#8). Change subject: Remove default table partitioning .. Remove default table partit

[kudu-CR] Remove default table partitioning

2016-05-24 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3131 to look at the new patch set (#7). Change subject: Remove default table partitioning .. Remove default table partit

[kudu-CR] Remove default table partitioning

2016-05-24 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3131 to look at the new patch set (#6). Change subject: Remove default table partitioning .. Remove default table partit

[kudu-CR] Remove default table partitioning

2016-05-24 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3131 to look at the new patch set (#5). Change subject: Remove default table partitioning .. Remove default table partit

[kudu-CR] Bump maven-assembly-plugin version

2016-05-24 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: Bump maven-assembly-plugin version .. Bump maven-assembly-plugin version The previous version spewed useless log lines at INFO level. With this change, a

[kudu-CR] Move the PbTracer in rpc_context.cc to pb_util

2016-05-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Move the PbTracer in rpc_context.cc to pb_util .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3194/1/src/kudu/util/pb_util.h File src/kudu/util/pb

[kudu-CR] Add a ResultTracker class that will track server side results

2016-05-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add a ResultTracker class that will track server side results .. Patch Set 3: (25 comments) I did a light first pass. Overall I think this needs more documentatio

[kudu-CR] rpcz: break out trace metrics into separate PB fields

2016-05-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: rpcz: break out trace metrics into separate PB fields .. rpcz: break out trace metrics into separate PB fields This removes the trace metrics from the tex

[kudu-CR](branch-0.9.x) rpcz: break out trace metrics into separate PB fields

2016-05-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/3195 Change subject: rpcz: break out trace metrics into separate PB fields .. rpcz: break out trace metrics into separate PB fields This remove

[kudu-CR] Make BuildLog() return Status

2016-05-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Make BuildLog() return Status .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3134 To unsubscribe, visit http://gerrit.cloudera.org

[kudu-CR] KUDU-1386 NaN float and double values are not handled correctly

2016-05-24 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3142 to look at the new patch set (#3). Change subject: KUDU-1386 NaN float and double values are not handled correctly .

[kudu-CR] KUDU-1386 NaN float and double values are not handled correctly

2016-05-24 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1386 NaN float and double values are not handled correctly .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/3142/2/src/kudu/common/types.h

[kudu-CR] Add unique id generation to the client

2016-05-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add unique id generation to the client .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/3077/11/src/kudu/integration-tests/client-stress-t

[kudu-CR] Bump maven-assembly-plugin version

2016-05-24 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Bump maven-assembly-plugin version .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3193 To unsubscribe, visit http://gerrit

[kudu-CR] KUDU-1386 NaN float and double values are not handled correctly

2016-05-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1386 NaN float and double values are not handled correctly .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3142/1/src/kudu/common/types.h Fil

[kudu-CR] Bump maven-assembly-plugin version

2016-05-24 Thread Dan Burkert (Code Review)
Hello Jean-Daniel Cryans, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3193 to look at the new patch set (#2). Change subject: Bump maven-assembly-plugin version .. Bump maven-assembly-

[kudu-CR] java: use truncated randomized exponential backoff for retries

2016-05-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: java: use truncated randomized exponential backoff for retries .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/3184/1/java/kudu-clien

[kudu-CR] Remove default table partitioning

2016-05-24 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3131 to look at the new patch set (#4). Change subject: Remove default table partitioning .. Remove default table partit

[kudu-CR] Add a generic retriable rpc class

2016-05-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: Add a generic retriable rpc class .. Add a generic retriable rpc class This patch adds a new, generic, class for retriable Rpcs: RetriableRpc. Thi

[kudu-CR] Move the MetaCacheServerPicker into meta_cache.h/cc

2016-05-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: Move the MetaCacheServerPicker into meta_cache.h/cc .. Move the MetaCacheServerPicker into meta_cache.h/cc This moves the MetaCacheServerPicker in

[kudu-CR] Integrate the ResultTracker into the rpc subsystem and add a test

2016-05-24 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3192 to look at the new patch set (#4). Change subject: Integrate the ResultTracker into the rpc subsystem and add a test ..

  1   2   >