---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34687/#review86176
---
I haven't done a full review here but took interest in this because
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33295/#review86169
---
Ship it!
Add an @return and fix the nits, and I'm ready to commit
On June 1, 2015, 1:06 a.m., Adam B wrote:
3rdparty/libprocess/include/process/firewall.hpp, lines 54-55
https://reviews.apache.org/r/33295/diff/6/?file=964946#file964946line54
Please capitalize The beginning of each @param description.
Alexander Rojas wrote:
I do completely
On May 13, 2015, 4:28 p.m., Bernd Mathiske wrote:
src/examples/java/TestFramework.java, line 251
https://reviews.apache.org/r/33058/diff/2/?file=922676#file922676line251
line 80 chars
There are many lines in the java files with line 80 chars, or even 100
chars.
I don't think
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34565/#review86179
---
Ship it!
Ship It!
- Joris Van Remoortere
On May 21, 2015, 8:54
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34911/#review86187
---
Patch looks great!
Reviews applied: [34910, 34911]
All tests
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33271/
---
(Updated June 2, 2015, 9:34 a.m.)
Review request for mesos, Bernd Mathiske,
On May 28, 2015, 10:40 a.m., Adam B wrote:
3rdparty/libprocess/src/help.cpp, line 140
https://reviews.apache.org/r/34655/diff/1/?file=971486#file971486line140
Why does this '/help/' need to be removed?
Marco Massenzio wrote:
because it's wrong - it shouldn't be there.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33271/#review86186
---
docs/mesos-c++-style-guide.md
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34268/#review86172
---
Ship it!
Ship It!
- Till Toenshoff
On May 22, 2015, 7:15 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34195/#review86258
---
I'm seeing the following pattern:
```
if (flags.master.isNone()) {
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34662/#review86263
---
Ship it!
Modulo Jie's comments
- Niklas Nielsen
On June 1,
On June 2, 2015, 5:52 p.m., Ben Mahler wrote:
I'm seeing the following pattern:
```
if (flags.master.isNone()) {
cerr flags.usage(Missing required option --master) endl;
return EXIT_FAILURE;
}
```
Why not leverage EXIT here?
```
if (flags.master.isNone()) {
On June 2, 2015, 5:05 p.m., Jie Yu wrote:
src/tests/oversubscription_tests.cpp, lines 77-80
https://reviews.apache.org/r/34816/diff/7/?file=976044#file976044line77
Any reason change the comments and the test name here?
Sorry - mistake during fixing git merge conflicts
- Bartek
On June 2, 2015, 4:24 p.m., Niklas Nielsen wrote:
src/tests/mesos.hpp, line 797
https://reviews.apache.org/r/34816/diff/7/?file=976043#file976043line797
How will this work, when we can't access the mocked resource estimator
from the test body?
You were right - default
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34748/
---
(Updated June 2, 2015, 7:40 p.m.)
Review request for mesos, Ben Mahler, Jie
On June 2, 2015, 5:52 p.m., Ben Mahler wrote:
I'm seeing the following pattern:
```
if (flags.master.isNone()) {
cerr flags.usage(Missing required option --master) endl;
return EXIT_FAILURE;
}
```
Why not leverage EXIT here?
```
if (flags.master.isNone()) {
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34816/
---
(Updated June 2, 2015, 7:37 p.m.)
Review request for mesos, Jie Yu, Niklas
On June 1, 2015, 9:40 p.m., Ben Mahler wrote:
include/mesos/mesos.proto, lines 577-580
https://reviews.apache.org/r/34748/diff/3/?file=975577#file975577line577
We've lost the important information (what does it mean for these to be
unset?). Could you revert the comment changes
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34748/
---
(Updated June 2, 2015, 8:16 p.m.)
Review request for mesos, Ben Mahler, Jie
On June 2, 2015, 8:05 p.m., Vinod Kone wrote:
src/tests/mesos.hpp, lines 716-723
https://reviews.apache.org/r/34816/diff/8/?file=976766#file976766line716
You want to use both ON_CALL and EXPECT_CALL. See TestAllocator in
tests/mesos.hpp for the rationale.
+1
However, i can see
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34816/#review86283
---
Ship it!
src/tests/mesos.hpp
On June 1, 2015, 9:40 p.m., Ben Mahler wrote:
include/mesos/mesos.proto, lines 577-580
https://reviews.apache.org/r/34748/diff/3/?file=975577#file975577line577
We've lost the important information (what does it mean for these to be
unset?). Could you revert the comment changes
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34748/#review86276
---
Patch looks great!
Reviews applied: [34816, 34662, 34748]
All
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34662/
---
(Updated June 2, 2015, 8:58 p.m.)
Review request for mesos, Jie Yu, Niklas
On June 2, 2015, 9:08 p.m., Niklas Nielsen wrote:
src/tests/oversubscription_tests.cpp, line 91
https://reviews.apache.org/r/34816/diff/9/?file=976795#file976795line91
This is implicit and you can remove it :)
Here and below
oh, sure (:
- Bartek
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34816/#review86271
---
src/tests/mesos.hpp
On June 1, 2015, 6:32 p.m., Chi Zhang wrote:
include/mesos/mesos.proto, lines 543-545
https://reviews.apache.org/r/34894/diff/1/?file=975745#file975745line543
Maybe some comments for the three names? (kinda the reason you are not
using 'repeated' of TrafficControlStatistics in
On June 2, 2015, 5:07 p.m., Jie Yu wrote:
src/tests/module.hpp, lines 76-79
https://reviews.apache.org/r/34662/diff/14/?file=976049#file976049line76
Do we need this?
Nope, we deleted RE moduled test so in fact we don't - sorry.
- Bartek
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34863/#review86282
---
Bad patch!
Reviews applied: [34899, 34830, 34832, 34426]
Failed
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34816/
---
(Updated June 2, 2015, 8:36 p.m.)
Review request for mesos, Jie Yu, Niklas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34956/#review86313
---
Ship it!
Ship It!
- Paul Brett
On June 2, 2015, 10:04 p.m., Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34962/#review86315
---
Should we name the 'resource_estimator' directory
On June 2, 2015, 10:40 p.m., Paul Brett wrote:
src/linux/routing/queueing/discipline.hpp, line 39
https://reviews.apache.org/r/34956/diff/1/?file=976864#file976864line39
Should config be optional?
Jie Yu wrote:
We still need a Config struct for each type of qdisc so that the
On June 2, 2015, 11:24 p.m., Niklas Nielsen wrote:
Should we name the 'resource_estimator' directory 'resource_estimators'
like we name the directory isolators?
I am fine with either; just wanted to get a feel for what pattern we want
to go with (the containerizer directory is in
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34306/#review86327
---
Could we print the framework's capabilities when it registers with
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34962/
---
(Updated June 3, 2015, 12:11 a.m.)
Review request for mesos, Bartek Plotka,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34962/#review86340
---
Ship it!
Ship It!
- Vinod Kone
On June 3, 2015, 12:11 a.m., Jie
On June 2, 2015, 11:09 p.m., Paul Brett wrote:
src/linux/routing/queueing/internal.hpp, line 143
https://reviews.apache.org/r/34957/diff/1/?file=976870#file976870line143
Not your problem, but we really should either explain why we have to
increment the reference counter here but
On June 2, 2015, 11:24 p.m., Niklas Nielsen wrote:
Should we name the 'resource_estimator' directory 'resource_estimators'
like we name the directory isolators?
I am fine with either; just wanted to get a feel for what pattern we want
to go with (the containerizer directory is in
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34729/#review86335
---
src/slave/slave.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34956/#review86336
---
src/linux/routing/queueing/discipline.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34968/
---
Review request for mesos and Jie Yu.
Repository: mesos
Description
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34969/
---
Review request for mesos and Vinod Kone.
Repository: mesos
Description
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34962/
---
Review request for mesos, Bartek Plotka, Niklas Nielsen, and Vinod Kone.
On June 2, 2015, 11:09 p.m., Paul Brett wrote:
src/linux/routing/queueing/internal.hpp, line 143
https://reviews.apache.org/r/34957/diff/1/?file=976870#file976870line143
Not your problem, but we really should either explain why we have to
increment the reference counter here but
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34962/#review86323
---
Ship it!
Ship It!
- Bartek Plotka
On June 2, 2015, 11:15 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34962/#review86332
---
Patch looks great!
Reviews applied: [34962]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34968/#review86341
---
Ship it!
Ship It!
- Vinod Kone
On June 3, 2015, 1:07 a.m., Ben
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34816/#review86289
---
Ship it!
Ship It!
- Jie Yu
On June 2, 2015, 9:19 p.m., Bartek
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34748/#review86297
---
Ship it!
Ship It!
- Niklas Nielsen
On June 2, 2015, 3:06 p.m.,
On June 2, 2015, 10:40 p.m., Paul Brett wrote:
src/linux/routing/queueing/discipline.hpp, line 39
https://reviews.apache.org/r/34956/diff/1/?file=976864#file976864line39
Should config be optional?
We still need a Config struct for each type of qdisc so that the template
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34958/#review86308
---
Patch looks great!
Reviews applied: [34956, 34957, 34958]
All
On June 2, 2015, 9:10 a.m., Benjamin Hindman wrote:
src/common/http.cpp, lines 212-213
https://reviews.apache.org/r/34687/diff/4/?file=975084#file975084line212
Please see formatting for braces:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34956/
---
Review request for mesos, Chi Zhang, Ian Downes, Paul Brett, and Cong Wang.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34957/
---
Review request for mesos, Chi Zhang, Ian Downes, Paul Brett, and Cong Wang.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34958/#review86307
---
Ship it!
Ship It!
- Paul Brett
On June 2, 2015, 10:06 p.m., Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34816/
---
(Updated June 2, 2015, 9:19 p.m.)
Review request for mesos, Jie Yu, Niklas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34894/#review86287
---
Bad patch!
Reviews applied: [34899, 34830, 34832, 34426]
Failed
On June 2, 2015, 9:10 a.m., Benjamin Hindman wrote:
I haven't done a full review here but took interest in this because the
required 'ip' field of the MasterInfo protobuf (as well as other protobufs)
is deprecated because it doesn't support IPv6. We need to make 'ip' an
optional
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34748/#review86298
---
Ship it!
Ship It!
- Jie Yu
On June 2, 2015, 10:06 p.m., Bartek
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34687/#review86299
---
Patch looks great!
Reviews applied: [34687]
All tests passed.
-
On May 27, 2015, 4:24 p.m., Marco Massenzio wrote:
Doxyfile, line 833
https://reviews.apache.org/r/34724/diff/1/?file=972987#file972987line833
Apache Mesos Docs, maybe?
Great point! Will change that before committing.
- Niklas
On June 2, 2015, 11:09 p.m., Paul Brett wrote:
src/linux/routing/queueing/internal.hpp, line 143
https://reviews.apache.org/r/34957/diff/1/?file=976870#file976870line143
Not your problem, but we really should either explain why we have to
increment the reference counter here but
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34958/
---
Review request for mesos, Chi Zhang, Ian Downes, Paul Brett, and Cong Wang.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34748/
---
(Updated June 2, 2015, 10:06 p.m.)
Review request for mesos, Ben Mahler, Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34957/#review86305
---
Ship it!
Ship It!
- Paul Brett
On June 2, 2015, 10:05 p.m., Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34631/
---
(Updated June 2, 2015, 9:26 p.m.)
Review request for mesos, Bartek Plotka, Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34632/
---
(Updated June 2, 2015, 9:28 p.m.)
Review request for mesos, Bartek Plotka, Jie
On May 29, 2015, 12:23 p.m., Vinod Kone wrote:
src/tests/oversubscription_tests.cpp, line 117
https://reviews.apache.org/r/34633/diff/1/?file=970999#file970999line117
Why not implement the TODO?
s/AWAIT_READY(received)/AWAIT_ASSERT_EQ(expected, received)/ ?
We still
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34721/
---
(Updated June 2, 2015, 9:30 p.m.)
Review request for mesos, Bartek Plotka, Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34633/
---
(Updated June 2, 2015, 9:29 p.m.)
Review request for mesos, Bartek Plotka, Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34970/#review86346
---
Patch looks great!
Reviews applied: [34968, 34969, 34970]
All
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33824/#review86351
---
Hi Alex - I noticed the new 'code drop' but none of the comments
On 六月 1, 2015, 6:41 p.m., Ben Mahler wrote:
src/cli/mesos-ps, line 138
https://reviews.apache.org/r/34886/diff/1/?file=975641#file975641line138
s/+/ + /
@Ben, can we ship it now? :-)
- weitao
---
This is an automatically
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34976/
---
Review request for mesos and Dave Lester.
Repository: mesos
Description
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34970/#review86344
---
src/examples/oversubscribing_framework.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33934/#review86347
---
3rdparty/libprocess/src/process.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34970/#review86352
---
src/examples/oversubscribing_framework.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34980/
---
Review request for mesos, Jie Yu, Niklas Nielsen, Szymon Konefal, and Vinod
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34980/#review86362
---
Any idea why review requests failed to show diff of noop.hpp?
I
On June 3, 2015, 5:58 a.m., Bartek Plotka wrote:
Any idea why review requests failed to show diff of noop.hpp?
I guess it something with
https://reviews.apache.org/r/34962/diff/#file976910, since this patch
depends on that.
reviewboard*
- Bartek
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33272/#review86194
---
Ship it!
Ship It!
- Benjamin Hindman
On May 20, 2015, 10:36
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33275/#review86195
---
Ship it!
Ship It!
- Benjamin Hindman
On May 20, 2015, 10:36
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33823/
---
(Updated June 2, 2015, 2:12 p.m.)
Review request for mesos, Isabel Jimenez,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33295/
---
(Updated June 2, 2015, 11:57 a.m.)
Review request for mesos, Adam B, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33271/#review86189
---
Ship it!
docs/mesos-c++-style-guide.md
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34565/
---
(Updated June 2, 2015, 9:59 a.m.)
Review request for mesos and Joris Van
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33825/
---
(Updated June 2, 2015, 4:06 p.m.)
Review request for mesos, Isabel Jimenez,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33824/
---
(Updated June 2, 2015, 4:03 p.m.)
Review request for mesos, Isabel Jimenez,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34944/
---
Review request for mesos and Marco Massenzio.
Repository: mesos
Description
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34944/
---
(Updated June 2, 2015, 2:46 p.m.)
Review request for mesos and Marco
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34943/
---
Review request for mesos.
Repository: mesos
Description
---
See
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33274/#review86191
---
Ship it!
Ship It!
- Benjamin Hindman
On May 20, 2015, 10:36
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34886/#review86200
---
Patch looks great!
Reviews applied: [34886]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33358/
---
(Updated June 2, 2015, 12:24 p.m.)
Review request for mesos, Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33272/
---
(Updated June 2, 2015, 12:37 p.m.)
Review request for mesos, Bernd Mathiske,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33276/
---
(Updated June 2, 2015, 12:37 p.m.)
Review request for mesos, Bernd Mathiske,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33275/
---
(Updated June 2, 2015, 12:37 p.m.)
Review request for mesos, Bernd Mathiske,
On May 28, 2015, 11:53 p.m., Marco Massenzio wrote:
Folks - this thing has been out for almost four months now, we should
really get it moving.
@alexdr - can you please address Nik's comments (Nik - you got late to the
party :) but that's ok)
@till - I think Alex addressed
1 - 100 of 117 matches
Mail list logo
