---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34137/
---
(Updated June 22, 2015, 9:44 a.m.)
Review request for mesos, Chi Zhang, Paul
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34908/
---
(Updated June 22, 2015, 9:55 a.m.)
Review request for mesos and Timothy Chen.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34141/
---
(Updated June 22, 2015, 9:53 a.m.)
Review request for mesos, Chi Zhang, Paul
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34140/
---
(Updated June 22, 2015, 9:51 a.m.)
Review request for mesos, Chi Zhang, Paul
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35033/
---
(Updated June 22, 2015, 9:51 a.m.)
Review request for mesos, Jie Yu and Vinod
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32891/
---
(Updated June 22, 2015, 9:38 a.m.)
Review request for mesos, Chi Zhang, Jay
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34142/
---
(Updated June 22, 2015, 9:57 a.m.)
Review request for mesos, Chi Zhang, Paul
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35686/#review88812
---
Ship it!
Ship It!
- Jie Yu
On June 20, 2015, 4:42 a.m., Michael
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34135/
---
(Updated June 22, 2015, 9:41 a.m.)
Review request for mesos, Chi Zhang, Paul
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34139/
---
(Updated June 22, 2015, 9:54 a.m.)
Review request for mesos, Chi Zhang, Paul
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35695/#review88810
---
Ship it!
Ship It!
- Till Toenshoff
On June 20, 2015, 7:14 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31444/#review88814
---
src/tests/launch_tests.cpp (lines 118 - 120)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35697/#review88808
---
Ship it!
Thanks a bunch for these.
- Till Toenshoff
On June 20,
On June 22, 2015, 2:13 p.m., Alexander Rukletsov wrote:
Looks like a copy-paste bug. How have you found it? Was the test flaky?
I was using these tests as a reference for writing my new tests for
[r35702](https://reviews.apache.org/r/35702/) and noticed it.
- Michael
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35438/
---
(Updated June 22, 2015, 7:46 a.m.)
Review request for mesos, Adam B, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35562/#review88788
---
Ship it!
Ship It!
- Till Toenshoff
On June 17, 2015, 2:28 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35438/
---
(Updated June 22, 2015, 7:57 a.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35438/#review88789
---
Patch looks great!
Reviews applied: [35438]
All tests passed.
-
On June 18, 2015, 6:08 p.m., Niklas Nielsen wrote:
A few high level comments:
1) Let's use an enum instead of an unstructured int to encode the namespaces
2) Let's get a test wired up
3) Think about Mac compatibility while introducing the enum :)
- Added an enum that is protected by
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35585/
---
(Updated June 22, 2015, 1:56 p.m.)
Review request for mesos, Ian Downes, Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35697/#review88840
---
Ship it!
Thanks, will commit this for you.
Also we are
On June 22, 2015, 10:20 a.m., Alexander Rukletsov wrote:
Before making a thorough review, let's discuss one high level question.
Here is the problem how I understand it: we reserve for roles, but our code
works mostly with frameworks (allocator methods, Offer protobuf). To
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35701/#review88821
---
src/master/master.cpp (lines 972 - 975)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35696/#review88834
---
Ship it!
I'll get this committed for you, one other inconsistency
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35714/#review88839
---
Adding this seems good since it's agnostic to how it is used. But
On June 22, 2015, 9:37 p.m., Chi Zhang wrote:
src/slave/containerizer/isolators/network/port_mapping.cpp, lines 1886-1889
https://reviews.apache.org/r/35744/diff/1/?file=989925#file989925line1886
If we have 0 known orphans, 3 unknown orphans, we'd try to delete ICMP
and ARP 3
On June 22, 2015, 8:04 p.m., Ben Mahler wrote:
Adding this seems good since it's agnostic to how it is used. But for
reservations specifically, any reason not to use just BadRequest?
From what I can tell, this is generally used for conditional requests
(based on headers or some
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35744/
---
Review request for mesos, Chi Zhang, Paul Brett, and Vinod Kone.
Bugs:
On June 22, 2015, 6:26 p.m., Till Toenshoff wrote:
src/master/master.cpp, lines 972-975
https://reviews.apache.org/r/35701/diff/1/?file=989004#file989004line972
I understand this was updated due to some discussions on related RRs. I
would however love to see the definitive answer
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35743/#review88862
---
Patch looks great!
Reviews applied: [35743]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35744/#review88855
---
Ship it!
Ship It!
- Chi Zhang
On June 22, 2015, 9:58 p.m., Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35749/#review88875
---
Ship it!
let us definitely improve the info pointer management,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35701/#review7
---
Ship it!
Ship It!
- Till Toenshoff
On June 20, 2015, 8 p.m.,
On June 22, 2015, 6:26 p.m., Till Toenshoff wrote:
src/master/master.cpp, lines 972-975
https://reviews.apache.org/r/35701/diff/1/?file=989004#file989004line972
I understand this was updated due to some discussions on related RRs. I
would however love to see the definitive answer
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35738/#review88892
---
Patch looks great!
Reviews applied: [35738]
All tests passed.
-
On June 22, 2015, 6:26 p.m., Till Toenshoff wrote:
src/master/master.cpp, lines 972-975
https://reviews.apache.org/r/35701/diff/1/?file=989004#file989004line972
I understand this was updated due to some discussions on related RRs. I
would however love to see the definitive answer
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35749/
---
(Updated June 22, 2015, 11:29 p.m.)
Review request for mesos, Chi Zhang, Paul
On June 22, 2015, 8:12 p.m., Ben Mahler wrote:
Thanks, will commit this for you.
Also we are inconcistent on the Test suffix, e.g. MasterTest vs
CRAMMD5Authentication. See two options:
(1) We can use Test to signify that there is a fixture, if that's
helpful. So remove any
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35750/#review0
---
Ship it!
It's not very clean to reply on `___recover`'s
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35756/
---
Review request for mesos and Niklas Nielsen.
Bugs: MESOS-2226
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35743/#review88852
---
Ship it!
3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35738/#review88868
---
Ship it!
Ship It!
- Chi Zhang
On June 22, 2015, 7:26 p.m., Paul
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35749/
---
Review request for mesos, Chi Zhang, Paul Brett, and Vinod Kone.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35750/
---
Review request for mesos, Chi Zhang, Paul Brett, and Vinod Kone.
Bugs:
On June 22, 2015, 11:19 p.m., Chi Zhang wrote:
src/slave/containerizer/isolators/network/port_mapping.cpp, lines 1905-1909
https://reviews.apache.org/r/35749/diff/1/?file=989997#file989997line1905
Do we need another for loop here to clean up unknownOrphans like you
did above?
On June 22, 2015, 11:33 p.m., Chi Zhang wrote:
let us definitely improve the info pointer management, there is 7 'delete
info' in this file right now... :(
Yeah, I'll follow up with patches.
- Jie
---
This is an automatically
On June 21, 2015, 6:47 p.m., Vinod Kone wrote:
src/common/resources.cpp, lines 479-487
https://reviews.apache.org/r/35715/diff/1/?file=989223#file989223line479
These checks are done in master's validation.cpp
Michael Park wrote:
Ah sorry, I missed that.
This
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35738/
---
(Updated June 23, 2015, 12:42 a.m.)
Review request for mesos, Chi Zhang, Ian
On June 22, 2015, 9:37 p.m., Chi Zhang wrote:
src/slave/containerizer/isolators/network/port_mapping.cpp, lines 1886-1889
https://reviews.apache.org/r/35744/diff/1/?file=989925#file989925line1886
If we have 0 known orphans, 3 unknown orphans, we'd try to delete ICMP
and ARP 3
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35749/#review88871
---
src/slave/containerizer/isolators/network/port_mapping.cpp (lines
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35567/#review88780
---
Ship it!
src/slave/flags.cpp (line 28)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35717/
---
(Updated June 22, 2015, 11:37 a.m.)
Review request for mesos, Adam B and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29507/#review88761
---
Patch looks great!
Reviews applied: [29507]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35728/
---
(Updated June 22, 2015, 11:34 a.m.)
Review request for mesos and Adam B.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35728/
---
Review request for mesos and Adam B.
Repository: mesos
Description
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33564/#review88750
---
Follow up in order to remove stout/memory.hpp:
On June 1, 2015, 1:15 p.m., Niklas Nielsen wrote:
LGTM - Would it make sense to have sane min/max values for the
timeouts/counts?
I wonder it would make sense to have a test to exercise an upgrade path
(the timeout being different in the slaves, than in the master). Maybe I
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29507/
---
(Updated June 22, 2015, 3:03 a.m.)
Review request for mesos, Ben Mahler and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35702/#review88760
---
Before making a thorough review, let's discuss one high level
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35738/#review88844
---
Patch looks great!
Reviews applied: [35738]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35743/
---
Review request for mesos, Benjamin Hindman and Till Toenshoff.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35699/#review88836
---
Ship it!
Thanks for taking care of this!
- Ben Mahler
On June
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35033/#review88822
---
Patch looks great!
Reviews applied: [35033]
All tests passed.
-
On June 11, 2015, 7:34 p.m., Vinod Kone wrote:
3rdparty/libprocess/src/process.cpp, lines 820-836
https://reviews.apache.org/r/34128/diff/2/?file=963212#file963212line820
If two libprocess based unix processes (e.g., scheudler and master) are
within the *same* bridged container,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35695/#review88841
---
Ship it!
Thanks, will commit this for you.
Ditto the previous
On June 11, 2015, 7:34 p.m., Vinod Kone wrote:
3rdparty/libprocess/src/process.cpp, lines 820-836
https://reviews.apache.org/r/34128/diff/2/?file=963212#file963212line820
If two libprocess based unix processes (e.g., scheudler and master) are
within the *same* bridged container,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34908/#review88833
---
Patch looks great!
Reviews applied: [34908]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35738/
---
Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35586/#review88910
---
Patch looks great!
Reviews applied: [35585, 35586]
All tests
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35763/#review88915
---
Patch looks great!
Reviews applied: [35763]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35585/#review88919
---
Ship it!
include/mesos/slave/isolator.hpp (lines 78 - 104)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35762/
---
(Updated June 22, 2015, 10:41 p.m.)
Review request for mesos and Jie Yu.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35763/
---
Review request for mesos.
Bugs: MESOS-1856
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35762/
---
Review request for mesos and Jie Yu.
Repository: mesos
Description
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35765/#review88912
---
Ship it!
Ship It!
- Till Toenshoff
On June 23, 2015, 3:09 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35765/
---
Review request for mesos and Jie Yu.
Bugs: MESOS-2917
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35586/
---
(Updated June 22, 2015, 10:21 p.m.)
Review request for mesos, Ian Downes, Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35585/#review88902
---
Hum, I don't see any change from r2 to r3? Did you upload the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35762/#review88906
---
Ship it!
Ship It!
- Till Toenshoff
On June 23, 2015, 2:41 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35586/
---
(Updated June 22, 2015, 10:48 p.m.)
Review request for mesos, Ian Downes, Jie
On June 22, 2015, 10:23 p.m., Jie Yu wrote:
Hum, I don't see any change from r2 to r3? Did you upload the correct diff?
I accidentally committed the diffs into the dependent RR. Fixed now. Thanks! :)
- Kapil
---
This is an
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35585/
---
(Updated June 22, 2015, 10:48 p.m.)
Review request for mesos, Ian Downes, Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35762/
---
(Updated June 22, 2015, 11:05 p.m.)
Review request for mesos and Jie Yu.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35762/#review88918
---
Ship it!
Ship It!
- Jie Yu
On June 23, 2015, 3:05 a.m., Kapil
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35765/#review88921
---
Patch looks great!
Reviews applied: [35585, 35586, 35762, 35765]
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35585/
---
(Updated June 22, 2015, 10:20 p.m.)
Review request for mesos, Ian Downes, Jie
On June 23, 2015, 2:47 a.m., Till Toenshoff wrote:
Ship It!
As discussed, another RR updating docs/network-monitoring.md would be great to
keep things in sync.
- Till
---
This is an automatically generated e-mail. To reply, visit:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35765/#review88917
---
Ship it!
Ship It!
- Jie Yu
On June 23, 2015, 3:09 a.m., Kapil
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35756/#review88900
---
Patch looks great!
Reviews applied: [35756]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35586/
---
(Updated June 23, 2015, 12:59 a.m.)
Review request for mesos, Ian Downes, Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35585/
---
(Updated June 23, 2015, 1:03 a.m.)
Review request for mesos, Ian Downes, Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35763/#review88924
---
Ship it!
Thanks for this.
A couple of minor formatting nits.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35763/#review88925
---
Can you please add one of the committers as a reviewer?
- Marco
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35702/#review88781
---
src/master/http.cpp (lines 519 - 520)
On June 20, 2015, 7:35 p.m., Alexander Rukletsov wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/hashmap.hpp, line 52
https://reviews.apache.org/r/35694/diff/3/?file=988938#file988938line52
Let's avoid re-creating iterator:
```
for (auto iterator =
On June 20, 2015, 7:35 p.m., Alexander Rukletsov wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/hashmap.hpp, line 52
https://reviews.apache.org/r/35694/diff/3/?file=988938#file988938line52
Let's avoid re-creating iterator:
```
for (auto iterator =
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35694/#review88774
---
Ship it!
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35728/#review88771
---
Patch looks great!
Reviews applied: [35728]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35717/#review88779
---
Patch looks great!
Reviews applied: [35717]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35703/#review88784
---
Ship it!
Looks like a copy-paste bug. How have you found it? Was
1 - 100 of 101 matches
Mail list logo
