Re: Review Request 35799: Support mounting relative paths with docker.

On June 24, 2015, 3:13 a.m., Bernd Mathiske wrote: src/tests/docker_tests.cpp, line 374 https://reviews.apache.org/r/35799/diff/1/?file=990751#file990751line374 Use Flags::docker_sandbox_directory (or a constant that the flag also uses for its default value) instead. Not only

Re: Review Request 35721: Set the ownership of persistent volume to match the sandbox directory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35721/#review89723 --- Ship it! Looks great! Just a few formatting/wrapping nits, but I

Re: Review Request 35711: Disallow special characters in role name.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35711/#review89630 --- Looks great. I think you're covering all the places where roles are

Re: Review Request 35985: Consistent capitalization of NOTE in documentation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35985/#review89726 --- Ship it! Ship It! - Bernd Mathiske On June 28, 2015, 3:45 a.m.,

Re: Review Request 29507: Added Configurable Slave Ping Timeouts

On June 24, 2015, 6:41 p.m., Ben Mahler wrote: Actually, we should think about one more thing, how does this interact with the zookeeper session timeout? Adam B wrote: The hardcoded individual ping timeout (15secs) was previously longer than the default zk session timeout

Re: Review Request 35919: Firewall rule's apply method returns an HTTP response instead of an error message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35919/#review89728 --- Patch looks great! Reviews applied: [35919] All tests passed. -

Re: Review Request 35998: Added doxygen styled comments to Path::basename and Path::dirname.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35998/#review89735 --- Patch looks great! Reviews applied: [35998] All tests passed. -

Review Request 35998: Added doxygen styled comments to Path::basename and Path::dirname.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35998/ --- Review request for mesos, Bernd Mathiske and Joerg Schad. Repository: mesos

Re: Review Request 35919: Firewall rule's apply method returns an HTTP response instead of an error message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35919/ --- (Updated June 29, 2015, 12:21 p.m.) Review request for mesos, Adam B and Till

Re: Review Request 35961: Include protobuf classes in generated Javadoc.

On June 27, 2015, 6:59 p.m., Adam B wrote: src/java/generated/org/apache/mesos/MesosNativeLibrary.java.in, lines 27-36 https://reviews.apache.org/r/35961/diff/1/?file=993816#file993816line27 Did you verify that the curly-braces are properly handled here? I read on

Re: Review Request 35961: Include protobuf classes in generated Javadoc.

On June 27, 2015, 6:59 p.m., Adam B wrote: Thanks for doing this Connor! Just a couple of questions about javadoc parsing of html (I'm no expert, just googled a few things). Do we need to do a pass over our protos now to convert any `//` or `/*` block comments to `/**` comments? Worth

Re: Review Request 35961: Include protobuf classes in generated Javadoc.

On June 27, 2015, 6:59 p.m., Adam B wrote: src/java/mesos.pom.in, line 134 https://reviews.apache.org/r/35961/diff/1/?file=993817#file993817line134 Is `${project.basedir}/generated` any better/different than `@abs_top_builddir@/src/java/generated` Connor Doyle wrote:

Review Request 36003: WIP: MESOS-2942: Documentation for SSL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36003/ --- Review request for mesos, Adam B and Benjamin Hindman. Bugs: MESOS-2942

Re: Review Request 35711: Disallow special characters in role name.

On June 29, 2015, 11:17 a.m., Adam B wrote: src/common/validation.hpp, lines 27-34 https://reviews.apache.org/r/35711/diff/7/?file=993941#file993941line27 I'm not convinced this is the right namespace/scope for a freestanding validate() function. Maybe, like we have a Resource

Review Request 36009: Updated CHANGELOG about the acceptOffers API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36009/ --- Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone. Bugs:

Review Request 36005: Removed obsolete ec2 scripts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36005/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-2640

Re: Review Request 36003: WIP: MESOS-2942: Documentation for SSL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36003/#review89756 --- Patch looks great! Reviews applied: [29526, 29527, 29528, 29529,

Re: Review Request 35985: Consistent capitalization of NOTE in documentation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35985/#review89733 --- Ship it! Ship It! - Alexander Rojas On June 28, 2015, 12:45

Re: Review Request 36014: Fixed stack trace in isolator tests on Linux VM

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36014/#review89775 --- Ship it! Ship It! - Ian Downes On June 29, 2015, 11:58 a.m.,

Re: Review Request 35981: Added persistent volume user guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35981/#review89773 --- Ship it! LGTM overall! Thanks a lot, mpark!

Re: Review Request 33090: Removed unmaintained frameworks code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33090/ --- (Updated June 29, 2015, 11:11 a.m.) Review request for mesos and Vinod Kone.

Review Request 36010: Updated upgrades.md about Resource API changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36010/ --- Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone. Bugs:

Re: Review Request 36010: Updated upgrades.md about Resource API changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36010/#review89759 --- Ship it! Looking pretty good. Minor suggestions.

Re: Review Request 36003: MESOS-2942: Documentation for SSL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36003/ --- (Updated June 29, 2015, 6:49 p.m.) Review request for mesos, Adam B and

Review Request 36011: Updated CHANGELOG about the Resource API changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36011/ --- Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone. Bugs:

Re: Review Request 36008: Updated upgrades.md about the new 'acceptOffers' API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36008/#review89758 --- Ship it! Looks good to me, although I wouldn't mind a mention of

Re: Review Request 36008: Updated upgrades.md about the new 'acceptOffers' API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36008/ --- (Updated June 29, 2015, 6:30 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 36011: Updated CHANGELOG about the Resource API changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36011/#review89760 --- Ship it! Fix the ordering, then we can ShipIt! CHANGELOG (lines

Re: Review Request 36005: Removed obsolete ec2 scripts.

On June 29, 2015, 11:42 a.m., Mesos ReviewBot wrote: Bad patch! Reviews applied: [36005] Failed command: ./bootstrap Error: autoreconf: Entering directory `.' autoreconf: configure.ac: not using Gettext autoreconf: running: aclocal --warnings=all -I m4 autoreconf:

Re: Review Request 31207: Support for SSL and non-ssl traffic simultaneously.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31207/ --- (Updated June 29, 2015, 6:49 p.m.) Review request for mesos and Benjamin

Re: Review Request 36003: MESOS-2942: Documentation for SSL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36003/ --- (Updated June 29, 2015, 9:50 p.m.) Review request for mesos, Adam B and

Re: Review Request 36022: Remove http specific protocol from master browse in webui.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36022/#review89797 --- Ship it! Ship It! - Adam B On June 29, 2015, 2:03 p.m., Joris

Re: Review Request 36026: Fixed typo in slave flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36026/ --- (Updated June 29, 2015, 11:03 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 36026: Fixed typo in slave flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36026/#review89818 --- Ship it! Ship It! - Joris Van Remoortere On June 29, 2015,

Re: Review Request 36003: MESOS-2942: Documentation for SSL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36003/#review89788 --- Patch looks great! Reviews applied: [29526, 29527, 29528, 29529,

Review Request 36026: Fixed typo in slave flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36026/ --- Review request for mesos, Benjamin Hindman and Joris Van Remoortere.

Re: Review Request 36026: Fixed typo in slave flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36026/#review89819 --- Ship it! Ship It! - Kapil Arya On June 29, 2015, 7:03 p.m.,

Review Request 36018: Remove http specific protocol from master redirect.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36018/ --- Review request for mesos, Adam B and Benjamin Hindman. Repository: mesos

Re: Review Request 36021: Disabled flaky HookTest::VerifySlaveLaunchExecutorHook test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36021/#review89801 --- Ship it! Ship It! - Ben Mahler On June 29, 2015, 9:02 p.m.,

Re: Review Request 31207: Support for SSL and non-ssl traffic simultaneously.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31207/ --- (Updated June 29, 2015, 10:21 p.m.) Review request for mesos and Benjamin

Re: Review Request 36005: Removed obsolete ec2 scripts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36005/#review89806 --- Patch looks great! Reviews applied: [36005] All tests passed. -

Review Request 36022: Remove http specific protocol from master browse in webui.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36022/ --- Review request for mesos, Adam B and Benjamin Hindman. Repository: mesos

Review Request 36023: Improved the documentation of Containerizer::launch() to clarify the failure cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36023/ --- Review request for mesos and Ian Downes. Repository: mesos Description

Review Request 36021: Disabled flaky HookTest::VerifySlaveLaunchExecutorHook test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36021/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-2226

Re: Review Request 36014: Fixed stack trace in isolator tests on Linux VM

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36014/#review89795 --- Patch looks great! Reviews applied: [36014] All tests passed. -

Re: Review Request 36022: Remove http specific protocol from master browse in webui.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36022/#review89813 --- Patch looks great! Reviews applied: [29526, 29527, 29528, 29529,

Re: Review Request 36026: Fixed typo in slave flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36026/#review89817 --- src/slave/flags.cpp (line 284)

Re: Review Request 36026: Fixed typo in slave flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36026/#review89816 --- Valid typo. Improper fix. You could try again, or I could just push

Re: Review Request 31207: Support for SSL and non-ssl traffic simultaneously.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31207/ --- (Updated June 29, 2015, 6:36 a.m.) Review request for mesos and Benjamin

Re: Review Request 35728: Fix failing test: SlaveTest.ROOT_RunTaskWithCommandInfoWithUser.

On June 25, 2015, 7:30 p.m., Adam B wrote: Nice work! So, running the command as root first will guarantee that lt-mesos-executor exists before trying to run the task as the test-user `nobody`? We might be able to fix this in a cleaner way, but this looks good enough to me. Just fix

Re: Review Request 35927: Added TaskStatus::Reason to Termination Message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35927/ --- (Updated June 29, 2015, 7:22 a.m.) Review request for mesos and Alexander

Re: Review Request 35919: Firewall rule's apply method returns an HTTP response instead of an error message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35919/#review89715 --- Ship it! 3rdparty/libprocess/src/process.cpp (line 2017)

Re: Review Request 35927: Added TaskStatus::Reason to Termination Message.

On June 28, 2015, 8:57 a.m., Alexander Rukletsov wrote: include/mesos/containerizer/containerizer.proto, lines 87-89 https://reviews.apache.org/r/35927/diff/1/?file=993029#file993029line87 Why do we need a deprecation cycle for this? AFAIK, it's part of the containerizer API only

Re: Review Request 35927: Added TaskStatus::Reason to Termination Message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35927/#review89717 --- Patch looks great! Reviews applied: [35927] All tests passed. -

Re: Review Request 31207: Support for SSL and non-ssl traffic simultaneously.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31207/#review89710 --- Patch looks great! Reviews applied: [29526, 29527, 29528, 29529,

Re: Review Request 36023: Improved the documentation of Containerizer::launch() to clarify the failure cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36023/#review89825 --- Patch looks great! Reviews applied: [36023] All tests passed. -

Re: Review Request 32982: Added reservation user guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32982/#review89824 --- Looks great! I know this is already committed, but I had a few

Re: Review Request 36026: Fixed typo in slave flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36026/#review89820 --- Ship it! Ship It! - Adam B On June 29, 2015, 4:03 p.m., Brendan

Re: Review Request 35981: Added persistent volume user guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35981/#review89827 --- Nice work! Just a few cleanups and questions/clarifications.

Re: Review Request 36003: MESOS-2942: Documentation for SSL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36003/#review89833 --- Great job! Some minor suggestions/rewordings, but I'd say it's

Re: Review Request 35961: Include protobuf classes in generated Javadoc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35961/#review89839 --- Ship it! Ship It! - Adam B On June 29, 2015, 8:53 a.m., Connor

Re: Review Request 34646: Redirect to the leader master when current master is not a leader.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34646/#review89799 --- Looks great, thanks! I still wonder if we can remove some of the

Re: Review Request 35721: Set the ownership of persistent volume to match the sandbox directory.

On June 29, 2015, 6:41 p.m., Jie Yu wrote: Thanks guys! haosdent, can you follow up with a unit test for this change? Sure. Let me write it now. Thank you for your help again. - haosdent --- This is an automatically generated

Re: Review Request 35711: Disallow special characters in role name.

On June 29, 2015, 11:17 a.m., Adam B wrote: src/common/validation.hpp, lines 27-34 https://reviews.apache.org/r/35711/diff/7/?file=993941#file993941line27 I'm not convinced this is the right namespace/scope for a freestanding validate() function. Maybe, like we have a Resource

Re: Review Request 31444: Support chrooting in MesosContainerizer launch helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31444/#review89425 --- src/slave/containerizer/mesos/launch.cpp (lines 64 - 65)

Re: Review Request 35958: Updated SlaveTest.PingTimeoutNoPings test to use custom timeout values.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35958/#review89843 --- Ship it! Thank you! src/tests/slave_tests.cpp (lines 1467 -

Re: Review Request 32982: Added reservation user guide.

On June 28, 2015, 11:36 p.m., Benjamin Hindman wrote: I made a few minor tweaks here before committing. (1) Replaced the fenced code blocks with indented code blocks so that the doxygen generated markdown was readable. (2) Made all the 'Coming Soon' be styled consistently (I went

Re: Review Request 36003: MESOS-2942: Documentation for SSL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36003/ --- (Updated June 30, 2015, 5:47 a.m.) Review request for mesos, Adam B and

Re: Review Request 35981: Added persistent volume user guide.

On June 29, 2015, 7:09 p.m., Jie Yu wrote: docs/persistent-volume.md, lines 23-24 https://reviews.apache.org/r/35981/diff/1/?file=994064#file994064line23 We don't store 'principal' in DiskInfo yet. Maybe add a coming soon somewhere as well? I put it at the end actually. Do you

Re: Review Request 35981: Added persistent volume user guide.

On June 30, 2015, 12:14 a.m., Adam B wrote: docs/persistent-volume.md, line 169 https://reviews.apache.org/r/35981/diff/1/?file=994064#file994064line169 There is no `volumes` field. Just a `resources` field, where each resource in the list must contain a `disk.volume` to be

Re: Review Request 35919: Firewall rule's apply method returns an HTTP response instead of an error message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35919/#review89854 --- Ship it! Minor points, but otherwise shippable. I guess I'm still

Re: Review Request 36003: MESOS-2942: Documentation for SSL.

On June 30, 2015, 12:57 a.m., Adam B wrote: docs/mesos-ssl.md, lines 58-59 https://reviews.apache.org/r/36003/diff/3/?file=995165#file995165line58 Can you list RHEL/Ubuntu instructions as well? (For OpenSSL as well) I'm reluctant to add the instructions as I can't easily verify the

Re: Review Request 33090: Removed unmaintained frameworks code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33090/#review89781 --- Patch looks great! Reviews applied: [33090] All tests passed. -

Re: Review Request 35927: Added TaskStatus::Reason to Termination Message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35927/#review89779 --- Thanks Joerg! See my detailed comments. I suggest you take a look

Re: Review Request 34137: Add support for container image provisioners.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34137/#review89293 --- src/slave/containerizer/mesos/containerizer.hpp (lines 319 - 320)