Re: Review Request 38161: Replaced a hard-coded number for registration backoff with a proper constant.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38161/#review102636 --- Ship it! Ship It! - Bernd Mathiske On Oct. 14, 2015, 8:51

Re: Review Request 39018: Added JSON parsing for Resources.

> On Oct. 13, 2015, 3:35 a.m., Guangya Liu wrote: > > include/mesos/resources.hpp, lines 114-118 > > > > > > Can this be removed or merged to the under comments? > > Greg Mann wrote: > I put the comment here

Re: Review Request 39156: RegistryClient refactor: changed getManifest interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39156/ --- (Updated Oct. 14, 2015, 4:05 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 38952: Replaced `> >` with `>>` in fault tolerance tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38952/ --- (Updated Oct. 14, 2015, 3:51 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 38160: Documented how to expedite event firing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38160/ --- (Updated Oct. 14, 2015, 3:51 p.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 38161: Replaced a hard-coded number for registration backoff with a proper constant.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38161/ --- (Updated Oct. 14, 2015, 3:51 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 39018: Added JSON parsing for Resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39018/ --- (Updated Oct. 14, 2015, 3:50 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 38579: Refactored registry client

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38579/ --- (Updated Oct. 14, 2015, 4:06 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 39155: RegistryClient refactor: removed nested namespace references

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39155/ --- (Updated Oct. 14, 2015, 4:05 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 39014: RegistryClient refactor: renamed ManifestResponse

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39014/ --- (Updated Oct. 14, 2015, 4:06 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 39276: Fixed a bug in which under certains circumstances HTTP 1.1 Pipelining is not respected.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39276/ --- (Updated Oct. 14, 2015, 5:35 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 39018: Added JSON parsing for Resources.

> On Oct. 13, 2015, 5 p.m., Michael Park wrote: > > src/common/resources.cpp, line 1198 > > > > > > Why the move here? > > Greg Mann wrote: > I was moving all of the private methods into an

Re: Review Request 39068: RegistryClient refactor: Renamed fsLayerInfoList

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39068/ --- (Updated Oct. 14, 2015, 4:07 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 38570: Change documentation image links to absolute paths.

> On Oct. 6, 2015, 2:29 p.m., Ben Mahler wrote: > > docs/external-containerizer.md, line 92 > > > > > > How will this work when we add multiple versions of documents to the > > website? Now this hardcodes "latest"

Re: Review Request 39289: [WIP] Quota: Added authorization of quota requests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39289/ --- (Updated Oct. 14, 2015, 8:04 p.m.) Review request for mesos and Alexander

Re: Review Request 39288: [WIP] Quota: Added authentication of quota requests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39288/ --- (Updated Oct. 14, 2015, 8:03 p.m.) Review request for mesos and Alexander

Review Request 39323: Fixed syntax error in sed usage on OSX.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39323/ --- Review request for mesos and Joris Van Remoortere. Bugs: MESOS-3734

Re: Review Request 39312: Hierarchical Allocator: Replaced Polymorphic factory with functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39312/#review102680 --- Ship it! Thank you! Yes, this seems simpler to me :) - Ben

Review Request 39325: Fixed race between coordinator election and recovery in replicated log.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39325/ --- Review request for mesos, Jie Yu, Joris Van Remoortere, and Timothy Chen.

Review Request 39320: Speeded up the test by reducing the allocation timeout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39320/ --- Review request for mesos, Benjamin Bannier, Bernd Mathiske, and Till Toenshoff.

Re: Review Request 38978: Add post-rewrite hook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38978/ --- (Updated Oct. 14, 2015, 4:55 p.m.) Review request for mesos and Joris Van

Re: Review Request 38978: Add post-rewrite hook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38978/ --- (Updated Oct. 14, 2015, 5:10 p.m.) Review request for mesos and Joris Van

Re: Review Request 39320: Speeded up the test by reducing the allocation timeout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39320/#review102670 --- Bad patch! Reviews applied: [39320] Failed command:

Re: Review Request 39323: Fixed syntax error in sed usage on OSX.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39323/#review102677 --- Ship it! Ship It! - haosdent huang On Oct. 14, 2015, 6:14

Re: Review Request 39310: Enable /master/state-summary endpoint include active flag for framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39310/#review102678 --- Ship it! Ship It! - Ben Mahler On Oct. 14, 2015, 8:03 a.m.,

Re: Review Request 29550: Libprocess: Added "tests" target for make.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29550/ --- (Updated Oct. 14, 2015, 2:31 p.m.) Review request for mesos, Cody Maloney,

Re: Review Request 38952: Replaced `> >` with `>>` in fault tolerance tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38952/#review102643 --- Ship it! Ship It! - Bernd Mathiske On Oct. 14, 2015, 8:51

Re: Review Request 39320: Speeded up the test by reducing the allocation timeout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39320/#review102647 --- src/tests/fault_tolerance_tests.cpp (line 719)

Re: Review Request 38978: Add post-rewrite hook.

> On Oct. 14, 2015, 1:27 p.m., Joris Van Remoortere wrote: > > support/hooks/post-rewrite, line 14 > > > > > > How come you chose not to follow the whitespace check in the existing > > pre-commit hook? I seem

Re: Review Request 39323: Fixed syntax error in sed usage on OSX.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39323/ --- (Updated Oct. 14, 2015, 6:26 p.m.) Review request for mesos and Joris Van

Re: Review Request 39323: Fixed syntax error in sed usage on OSX.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39323/ --- (Updated Oct. 14, 2015, 6:25 p.m.) Review request for mesos and Joris Van

Re: Review Request 39276: Fixed a bug in which under certains circumstances HTTP 1.1 Pipelining is not respected.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39276/#review102645 --- Patch looks great! Reviews applied: [39276] All tests passed. -

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38883/#review102624 --- Again lots of nit-picking, feel free to ignore what you disagree

Re: Review Request 38570: Change documentation image links to absolute paths.

> On Oct. 6, 2015, 2:29 p.m., Ben Mahler wrote: > > docs/external-containerizer.md, line 92 > > > > > > How will this work when we add multiple versions of documents to the > > website? Now this hardcodes "latest"

Re: Review Request 39018: Added JSON parsing for Resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39018/#review102664 --- Patch looks great! Reviews applied: [39211, 39018] All tests

Re: Review Request 29551: Added "tests" target for make.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29551/ --- (Updated Oct. 14, 2015, 2:31 p.m.) Review request for mesos, Cody Maloney,

Re: Review Request 39018: Added JSON parsing for Resources.

> On 十月 13, 2015, 3:35 a.m., Guangya Liu wrote: > > include/mesos/resources.hpp, lines 114-118 > > > > > > Can this be removed or merged to the under comments? > > Greg Mann wrote: > I put the comment here so

Re: Review Request 39250: Puller refactor: moved untar to a common place

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39250/#review102579 --- Patch looks great! Reviews applied: [39013, 38443, 39184, 39155,

Re: Review Request 39018: Added JSON parsing for Resources.

> On 十月 13, 2015, 5:38 a.m., Guangya Liu wrote: > > src/common/resources.cpp, line 367 > > > > > > Why not check error here? > > Greg Mann wrote: > I'm sorry, I don't understand this comment. Are you referring

Re: Review Request 39018: Added JSON parsing for Resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39018/#review102584 --- include/mesos/resources.hpp (line 375)

Re: Review Request 39300: Fixed flaky ReservationEndpointsTest.AvailableResources test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39300/ --- (Updated Oct. 14, 2015, 7:38 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 38307: Libprocess: Removed namespace pollution.

> On Sept. 11, 2015, 6:57 p.m., Joseph Wu wrote: > > Ship it! > > > > I pointed out a bunch of would-be-nice-to-refactor lines. But I don't > > think it's critical to change them to ship this. Let's make these changes in a separate patch. - Joris

Review Request 39312: Hierarchical Allocator: Replaced Polymorphic factory with functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39312/ --- Review request for mesos, Ben Mahler and Michael Park. Bugs: MESOS-3554

Re: Review Request 39300: Fixed flaky ReservationEndpointsTest.AvailableResources test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39300/#review102588 --- Patch looks great! Reviews applied: [39300] All tests passed. -

Re: Review Request 39088: Made shell test locale-independent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39088/#review102589 --- Ship it! Ship It! - Till Toenshoff On Oct. 8, 2015, 1:27 p.m.,

Re: Review Request 38307: Libprocess: Removed namespace pollution.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38307/ --- (Updated Oct. 14, 2015, 8:39 a.m.) Review request for mesos, Artem

Re: Review Request 38627: Adds an overload of ModuleManager::create() allowing overriding parameters programatically

> On Oct. 12, 2015, 2:54 p.m., Marco Massenzio wrote: > > Would it be possible to add a few unit tests, also to show usage patterns? > > especially given the absence of any documentation, it's kinda difficult to > > figure out how is this "intended to work" and, without tests, whether it > >

Review Request 39310: Enable /master/state-summary endpoint include active flag for framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39310/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-3721

Re: Review Request 39325: Fixed race between coordinator election and recovery in replicated log.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39325/ --- (Updated Oct. 14, 2015, 8:29 p.m.) Review request for mesos, Jie Yu, Joris Van

Re: Review Request 38900: Update command executor to support rootfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38900/#review102682 --- Only one issue (regarding user). See my detailed comments below.

Re: Review Request 39325: Fixed race between coordinator election and recovery in replicated log.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39325/#review102693 --- src/tests/log_tests.cpp (line 730)

Re: Review Request 38978: Add post-rewrite hook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38978/#review102691 --- Patch looks great! Reviews applied: [38978] All tests passed. -

Re: Review Request 39323: Fixed syntax error in sed usage on OSX.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39323/#review102694 --- Patch looks great! Reviews applied: [39323] All tests passed. -

Review Request 39330: libprocess: Replaced usage of "volatile" with std::atomic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39330/ --- Review request for mesos and Joris Van Remoortere. Bugs: MESOS-3326

Re: Review Request 39324: Updated protobuf::parse to handle JSON "null" values.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39324/#review102707 --- Patch looks great! Reviews applied: [39324] All tests passed. -

Re: Review Request 39323: Fixed syntax error in sed usage on OSX.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39323/#review102709 --- Ship it! Ship It! - Gilbert Song On Oct. 14, 2015, 11:26 a.m.,

Re: Review Request 29551: Added "tests" target for make.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29551/#review102711 --- Patch looks great! Reviews applied: [29550, 29551] All tests

Review Request 39331: Support docker local store pull image simultaneously

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39331/ --- Review request for mesos, Anand Mazumdar, Jojy Varghese, and Timothy Chen.

Re: Review Request 38747: Adding digest utilities

> On Oct. 13, 2015, 12:54 a.m., Jiang Yan Xu wrote: > > 3rdparty/libprocess/include/process/digest.hpp, line 71 > > > > > > I imagine `fn` is expensive, after all, it's cryptography. :) > > > > Serially

Re: Review Request 39323: Fixed syntax error in sed usage on OSX.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39323/#review102705 --- Ship it! Ship It! - Isabel Jimenez On Oct. 14, 2015, 6:26

Re: Review Request 39258: Add filesystem isolator with command executor test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39258/#review102697 --- src/slave/containerizer/provisioner/provisioner.hpp (line 101)

Re: Review Request 39312: Hierarchical Allocator: Replaced Polymorphic factory with functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39312/#review102600 --- Patch looks great! Reviews applied: [39312] All tests passed. -

Re: Review Request 38734: Cleaned up function signatures to use Option.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38734/#review102724 --- Ship it! Ship It! - Vinod Kone On Sept. 24, 2015, 9:27 p.m.,

Re: Review Request 37955: Remove hashmap::existsValue since it is never called

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37955/#review102720 --- Ship it! Ship It! - Vinod Kone On Aug. 31, 2015, 3:42 p.m.,

Re: Review Request 39323: Fixed syntax error in sed usage on OSX.

> On Oct. 14, 2015, 11:24 p.m., James Peach wrote: > > Automake detects sed, so I think that you should do something like this: > > > > SED_I = $(SED) -i.orig > > > > foo: bar > > $(AM_V_GEN)$(SED_I) 's/mesos.mesos_pb2/mesos_pb2/' $@ I suppose there's value in using

Re: Review Request 39325: Fixed race between coordinator election and recovery in replicated log.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39325/#review102710 --- Haven't looked into details yet. Some high level questions below.

Re: Review Request 39325: Fixed race between coordinator election and recovery in replicated log.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39325/ --- (Updated Oct. 15, 2015, 1:21 a.m.) Review request for mesos, Jie Yu, Joris Van

Re: Review Request 39323: Fixed syntax error in sed usage on OSX.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39323/#review102718 --- Automake detects sed, so I think that you should do something like

Re: Review Request 39323: Fixed syntax error in sed usage on OSX.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39323/ --- (Updated Oct. 14, 2015, 11:41 p.m.) Review request for mesos and Joris Van

Re: Review Request 39323: Fixed syntax error in sed usage on OSX.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39323/#review102727 --- Ship it! Ship It! - James Peach On Oct. 14, 2015, 11:41 p.m.,

Re: Review Request 39323: Fixed syntax error in sed usage on OSX.

> On Oct. 14, 2015, 11:24 p.m., James Peach wrote: > > Automake detects sed, so I think that you should do something like this: > > > > SED_I = $(SED) -i.orig > > > > foo: bar > > $(AM_V_GEN)$(SED_I) 's/mesos.mesos_pb2/mesos_pb2/' $@ > > Neil Conway wrote: > I

Re: Review Request 39323: Fixed syntax error in sed usage on OSX.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39323/#review102726 --- Ship it! Ship It! - James Peach On Oct. 14, 2015, 11:41 p.m.,

Re: Review Request 39331: Support docker local store pull image simultaneously

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39331/#review102739 --- Patch looks great! Reviews applied: [39331] All tests passed. -

Re: Review Request 39096: CMake:[1/2] Moved `__WINDOWS__` flag definition to CompilationConfigure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39096/#review102608 --- Ship it! cleaned up the comment a little. - Joris Van Remoortere

Re: Review Request 39076: CMake: Added ability of Windows builds to include protobuf headers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39076/#review102603 --- Ship it!

Re: Review Request 39092: CMake:[2/3] prepared process library tests to run with `make check`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39092/#review102605 --- Ship it! - Joris Van Remoortere On Oct. 13, 2015, 6:25 p.m.,

Re: Review Request 39093: CMake:[3/3] Add `make check` target.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39093/#review102606 --- Ship it! - Joris Van Remoortere On Oct. 13, 2015, 6:25 p.m.,

Re: Review Request 39091: CMake:[1/3] Prepared stout tests to run with `make check`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39091/#review102604 --- Ship it! - Joris Van Remoortere On Oct. 13, 2015, 6:25 p.m.,

Re: Review Request 39076: CMake: Added ability of Windows builds to include protobuf headers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39076/ --- (Updated Oct. 14, 2015, 11:47 a.m.) Review request for mesos, Artem

Re: Review Request 39276: Fixed a bug in which under certains circumstances HTTP 1.1 Pipelining is not respected.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39276/#review102607 --- Going to look at the test now, but wanted to provide this feedback

Re: Review Request 39276: Fixed a bug in which under certains circumstances HTTP 1.1 Pipelining is not respected.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39276/#review102619 --- Patch looks great! Reviews applied: [39276] All tests passed. -

Re: Review Request 39276: Fixed a bug in which under certains circumstances HTTP 1.1 Pipelining is not respected.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39276/ --- (Updated Oct. 14, 2015, 2:04 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 39097: CMake:[2/2] remove `__WINDOWS__` flag definition from Stout config.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39097/#review102609 --- Ship it! - Joris Van Remoortere On Oct. 13, 2015, 6:26 p.m.,

Re: Review Request 39002: Fixed sed command for Python protos generation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39002/#review102614 --- Ship it! Ship It! - Joris Van Remoortere On Oct. 5, 2015, 5:48

Re: Review Request 38978: Add post-rewrite hook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38978/#review102629 --- Ship it! This looks good! Tried it out locally.

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36913/ --- (Updated Oct. 14, 2015, 1:28 p.m.) Review request for mesos, Alexander

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36913/#review102630 --- src/master/master.hpp (lines 863 - 878)

Re: Review Request 39310: Enable /master/state-summary endpoint include active flag for framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39310/#review102599 --- Patch looks great! Reviews applied: [39310] All tests passed. -

Re: Review Request 39018: Added JSON parsing for Resources.

> On Oct. 13, 2015, 5 p.m., Michael Park wrote: > > src/common/resources.cpp, line 361 > > > > > > I think it would be better to only support one way of doing things > > here. I would opt for the array format. Is

Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38705/#review101980 --- support/apply-reviews.py (line 7)

Re: Review Request 39018: Added JSON parsing for Resources.

> On Oct. 13, 2015, 3:35 a.m., Guangya Liu wrote: > > include/mesos/resources.hpp, lines 114-118 > > > > > > Can this be removed or merged to the under comments? > > Greg Mann wrote: > I put the comment here

Re: Review Request 29550: Libprocess: Added "tests" target for make.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29550/#review102626 --- I ran `make tests` from `3rdparty/libprocess` and ran in to:

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36913/ --- (Updated Oct. 14, 2015, 1:07 p.m.) Review request for mesos, Alexander

Re: Review Request 39018: Added JSON parsing for Resources.

> On 十月 13, 2015, 3:35 a.m., Guangya Liu wrote: > > include/mesos/resources.hpp, lines 114-118 > > > > > > Can this be removed or merged to the under comments? > > Greg Mann wrote: > I put the comment here so

Re: Review Request 39323: Fixed syntax error in sed usage on OSX.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39323/#review102744 --- Patch looks great! Reviews applied: [39323] All tests passed. -

Re: Review Request 39312: Hierarchical Allocator: Replaced Polymorphic factory with functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39312/#review102743 --- Ship it! Ship It! - Michael Park On Oct. 14, 2015, 9:15 a.m.,

Re: Review Request 39325: Fixed race between coordinator election and recovery in replicated log.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39325/#review102749 --- Patch looks great! Reviews applied: [39325] All tests passed. -

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36913/ --- (Updated Oct. 14, 2015, 2:07 p.m.) Review request for mesos, Alexander

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36913/ --- (Updated Oct. 14, 2015, 2:16 p.m.) Review request for mesos, Alexander

Re: Review Request 39018: Added JSON parsing for Resources.

> On Oct. 13, 2015, 5 p.m., Michael Park wrote: > > src/common/resources.cpp, line 361 > > > > > > I think it would be better to only support one way of doing things > > here. I would opt for the array format. Is

  1   2   >