Re: Review Request 42113: WIP: Handle unreserve logic for dynamic reservation (2/3).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42113/ --- (Updated 一月 13, 2016, 9:03 a.m.) Review request for mesos and Klaus Ma.

Re: Review Request 41876: Used std::list as opposed to List from stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41876/ --- (Updated Jan. 13, 2016, 11:02 a.m.) Review request for mesos, Ben Mahler and

Review Request 42246: Fixed support for non-HDFS URIs by Hadoop client.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42246/ --- Review request for mesos, haosdent huang, Jie Yu, and switched to 'mcypark'.

Re: Review Request 41243: Updated how we find the .git directory in bootstrap.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41243/#review114175 --- Ship it! Ship It! - Benjamin Bannier On Jan. 13, 2016, 11:34

Re: Review Request 41882: Constrained types used in Flags instantiation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41882/ --- (Updated Jan. 13, 2016, 11:43 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 42185: Added an example executor based on the new V1 API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42185/#review114160 --- src/examples/test_http_executor.cpp (line 130)

Re: Review Request 42053: Added flags to set size of completed task/framework history.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42053/ --- (Updated Jan. 13, 2016, 10:42 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 41876: Used std::list as opposed to List from stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41876/#review114169 --- Ship it! Ship It! - Alexander Rojas On Jan. 13, 2016, 11:02

Re: Review Request 41243: Updated how we find the .git directory in bootstrap.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41243/#review114168 --- bootstrap (line 15)

Re: Review Request 42053: Added flags to set size of completed task/framework history.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42053/ --- (Updated Jan. 13, 2016, 10:43 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 42165: Removed `hasPrincipal` parameter from unreserve validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42165/#review114167 --- Patch looks great! Reviews applied: [42164, 42165] Passed

Re: Review Request 42234: WIP: Added test case on re-using evicting executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42234/#review114170 --- Bad patch! Reviews applied: [40375, 41334, 41333, 40529, 41772,

Re: Review Request 41882: Constrained types used in Flags instantiation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41882/#review114177 --- Ship it! Ship It! - Alexander Rojas On Jan. 13, 2016, 11:43

Re: Review Request 42221: Removed references to wDRF from allocator.

> On Jan. 13, 2016, 1:52 a.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1185 > > > > > > s/framwork/frameworks Why do you want plural here? - Alexander

Re: Review Request 42221: Removed references to wDRF from allocator.

> On Jan. 13, 2016, 1:52 a.m., Guangya Liu wrote: > > Since the comments are mainly to developers, the `second stage` is not very > > clear to developers, but the `WDRF` seems more clear. If want to update, > > what about "fair share stage"? The fairness of the "second" stage is determined by

Re: Review Request 41243: Updated how we find the .git directory in bootstrap.

> On Jan. 13, 2016, 10:04 a.m., Till Toenshoff wrote: > > bootstrap, line 15 > > > > > > This would introduce Python as a hard dependency of the Mesos build > > environment. > > > > We should avoid this. >

Re: Review Request 41243: Updated how we find the .git directory in bootstrap.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41243/ --- (Updated Jan. 13, 2016, 10:34 a.m.) Review request for mesos, Benjamin

Re: Review Request 42246: Fixed support for non-HDFS URIs by Hadoop client.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42246/#review114173 --- Ship it! Ship It! - haosdent huang On Jan. 13, 2016, 10:07

Re: Review Request 42222: Added a comment on allocator recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4/#review114161 --- Patch looks great! Reviews applied: [42221, 4] Passed

Re: Review Request 42194: WIP: Handle unreserve logic for dynamic reservation (3/3).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42194/ --- (Updated 一月 13, 2016, 9:58 a.m.) Review request for mesos and Klaus Ma.

Re: Review Request 41243: Updated how we find the .git directory in bootstrap.

> On Jan. 13, 2016, 10:04 a.m., Till Toenshoff wrote: > > bootstrap, line 15 > > > > > > This would introduce Python as a hard dependency of the Mesos build > > environment. > > > > We should avoid this.

Re: Review Request 42212: Added unit test for framework/task history flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42212/ --- (Updated Jan. 13, 2016, 11:01 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 42194: WIP: Handle unreserve logic for dynamic reservation (3/3).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42194/#review114181 --- Bad patch! Reviews applied: [40375, 41334, 41333, 40529, 41772,

Re: Review Request 37168: MESOS-3063 (Add an example framework using dynamic reservation)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/#review114192 --- ping @mcypark :). - Klaus Ma On Dec. 13, 2015, 11:28 p.m.,

Re: Review Request 42248: Fixed markdown parsing in markdown-styleguide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42248/ --- (Updated Jan. 13, 2016, 12:42 p.m.) Review request for mesos, Joerg Schad and

Re: Review Request 41791: Updated allocation slack for dynamic reserve (1/3).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41791/ --- (Updated 一月 13, 2016, 12:58 p.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 39782: Add a comment for os::libraries::setPaths.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39782/#review114193 --- Ship it! Ship It! - Till Toenshoff On Jan. 12, 2016, 10:14

Re: Review Request 42194: Handle unreserve logic for dynamic reservation (3/3).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42194/ --- (Updated 一月 13, 2016, 1:10 p.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 41769: Made allocator traverse all roles for quota allocation.

> On Jan. 13, 2016, 11:41 a.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 1164-1166 > > > > > > This looks like a bug to me. I can't remember why we have `break` here > > in

Re: Review Request 41438: Added documentation on using network proxy for mesos fetcher

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41438/#review114194 --- docs/fetcher.md (line 226)

Re: Review Request 41438: Added documentation on using network proxy for mesos fetcher

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41438/#review114195 --- Ship it! (after the issues in my previous review are fixed)

Re: Review Request 42040: Added Quota Operator Documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42040/ --- (Updated Jan. 13, 2016, 1:53 p.m.) Review request for mesos, Alexander

Re: Review Request 42209: Updated getting started page to install Java on OSX.

> On Jan. 12, 2016, 10:04 p.m., Kevin Klues wrote: > > Can you veirfy that this doesn't break things for Yosemite? > > Vinod Kone wrote: > I don't have yosemite handy to test it :) but from looking online it > looks like cask and caskroom have existed for a while, pre-yosemite. > > Joseph

Re: Review Request 42209: Updated getting started page to install Java on OSX.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42209/#review114183 --- Ship it! Ship It! - Kevin Klues On Jan. 12, 2016, 9:38 p.m.,

Re: Review Request 41769: Made allocator traverse all roles for quota allocation.

> On 一月 13, 2016, 11:41 a.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 1164-1166 > > > > > > This looks like a bug to me. I can't remember why we have `break` here > > in

Re: Review Request 41243: Updated how we find the .git directory in bootstrap.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41243/#review114187 --- This recent change breaks the functionality - it hangs now. -

Re: Review Request 42246: Fixed support for non-HDFS URIs by Hadoop client.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42246/#review114189 --- Patch looks great! Reviews applied: [42246] Passed command:

Re: Review Request 42113: Handle unreserve logic for dynamic reservation (2/3).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42113/ --- (Updated 一月 13, 2016, 1:01 p.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 42194: Handle unreserve logic for dynamic reservation (3/3).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42194/ --- (Updated 一月 13, 2016, 1:05 p.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 42212: Added unit test for framework/task history flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42212/#review114198 --- Patch looks great! Reviews applied: [42053, 42212] Passed

Review Request 42250: CMake: Add sasl and dl link flags, add curl link library and add protobuf library directory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42250/ --- Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van

Re: Review Request 41108: CMake: Add sasl and dl link flags, add curl link library and add protobuf library directory.

> On Jan. 8, 2016, 4:43 p.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [41096, 41185, 41108] > > > > Failed command: ./support/apply-review.sh -n -r 41108 > > > > Error: > > 2016-01-08 16:43:43 URL:https://reviews.apache.org/r/41108/diff/raw/ > > [4052/4052] ->

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40632/ --- (Updated 一月 13, 2016, 12:39 p.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 41308: MESOS-1718: Unit Test for moving getExecutorInfo from slave to master

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41308/#review114191 --- @Joseph/Vinod, would you help to review those patches move

Re: Review Request 41847: Updated allocation slack when slave was updated.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41847/ --- (Updated 一月 13, 2016, 12:55 p.m.) Review request for mesos, Ben Mahler, Artem

Review Request 42196: Added cgroup instructions for CentOS 6.6.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42196/ --- Review request for mesos and Till Toenshoff. Bugs: MESOS-4035 and MESOS-4038

Re: Review Request 37531: Fix master CHECK failure if a framework uses duplicated task id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37531/ --- (Updated Jan. 13, 2016, 10:06 p.m.) Review request for mesos, Jie Yu and Vinod

Review Request 42197: Added a filter for tests using 'perf' hardware events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42197/ --- Review request for mesos and Till Toenshoff. Bugs: MESOS-3082

Re: Review Request 41769: Made allocator traverse all roles for quota allocation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41769/#review114184 --- src/master/allocator/mesos/hierarchical.cpp (lines 1164 - 1166)

Re: Review Request 41772: Added helper function to flatten resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41772/ --- (Updated 一月 13, 2016, 12:16 p.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 41882: Constrained types used in Flags instantiation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41882/#review114186 --- Ship it!

Re: Review Request 42248: Fixed markdown parsing in markdown-styleguide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42248/ --- (Updated Jan. 13, 2016, 12:47 p.m.) Review request for mesos, Joerg Schad and

Re: Review Request 42248: Fixed markdown parsing in markdown-styleguide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42248/ --- (Updated Jan. 13, 2016, 1:01 p.m.) Review request for mesos, Joerg Schad and

Re: Review Request 42130: Added tests for `ALLOCATION_SLACK` helper functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42130/ --- (Updated Jan. 13, 2016, 9:31 p.m.) Review request for mesos, Guangya Liu and

Re: Review Request 41438: Added documentation on using network proxy for mesos fetcher

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41438/#review114197 --- docs/fetcher.md (line 258)

Re: Review Request 42197: Added a filter for tests using 'perf' hardware events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42197/ --- (Updated Jan. 13, 2016, 2:32 p.m.) Review request for mesos and Till

Re: Review Request 41108: CMake: Add sasl and dl link flags, add curl link library and add protobuf library directory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41108/ --- (Updated Jan. 13, 2016, 6:09 p.m.) Review request for mesos, Artem

Re: Review Request 42143: Removed HTTPTest.Auth test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42143/ --- (Updated Jan. 13, 2016, 6:13 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 41819: Added ContainerConfig to all isolators.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41819/#review114234 --- Ship it!

Re: Review Request 37531: Fix master CHECK failure if a framework uses duplicated task id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37531/#review114243 --- Patch looks great! Reviews applied: [37531] Passed command:

Re: Review Request 42035: Windows: Removed the `--switch_user` flag in Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42035/#review114246 --- src/slave/flags.cpp (line 196)

Re: Review Request 41108: CMake: Add sasl and dl link flags, add curl link library and add protobuf library directory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41108/ --- (Updated Jan. 13, 2016, 6:31 p.m.) Review request for mesos, Artem

Re: Review Request 42235: Added protobuf for docker ImageReference and the parsing function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42235/#review114250 --- Ship it! Verified that the logic in `parseImageReference` is

Re: Review Request 42211: Added filters to disable NetClsIsolator tests in case cgroups is not present or the net_cls subsystem is disable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42211/#review114273 --- Bad patch! Reviews applied: [42047] Failed command:

Re: Review Request 42215: Added expectations for call to mocked executor shutdown.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42215/#review114285 --- Ship it! Ship It! - Timothy Chen On Jan. 13, 2016, 12:05 a.m.,

Review Request 42264: Fixed a GMock warning in RoleTest.ImplicitRoleStaticReservation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42264/ --- Review request for mesos, Joris Van Remoortere and Timothy Chen. Bugs:

Re: Review Request 40936: Windows: Unified POSIX and Windows implementation of shell.hpp

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40936/ --- (Updated Jan. 13, 2016, 7:14 p.m.) Review request for mesos, Alex Naparu, Alex

Re: Review Request 41870: [stout] Added ref-qualifiers to Option::get().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41870/#review114266 --- Ship it!

Re: Review Request 42186: Added tests for recovery for HTTP based executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42186/#review114268 --- Patch looks great! Reviews applied: [41275, 41277, 41280, 41281,

Re: Review Request 42262: Improved links at containerizer.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42262/ --- (Updated Jan. 13, 2016, 8:38 p.m.) Review request for mesos, Joerg Schad and

Re: Review Request 42262: Improved links at containerizer.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42262/#review114272 --- Ship it! Ship It! - Neil Conway On Jan. 13, 2016, 8:38 p.m.,

Re: Review Request 41806: Cleaned up assertions in test cases around JSON HTTP responses.

> On Jan. 12, 2016, 10:56 p.m., Adam B wrote: > > src/tests/executor_http_api_tests.cpp, line 394 > > > > > > Do you think there's any test overhead in doing another AWAIT for a > > `response` that has already been

Re: Review Request 40936: Windows: Unified POSIX and Windows implementation of shell.hpp

> On Jan. 6, 2016, 2:23 a.m., Alex Clemmer wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/shell.hpp, line > > 73 > > > > > > How semantically similar is this to the POSIX code? If it's very

Review Request 42265: Fixed more tests that didn't set a shutdown expect for MockExecutor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42265/ --- Review request for mesos, Joris Van Remoortere and Timothy Chen. Bugs:

Re: Review Request 42196: Added cgroup instructions for CentOS 6.6.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42196/#review114267 --- docs/getting-started.md (line 117)

Re: Review Request 42236: Added a utility function to create https URI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42236/#review114278 --- Ship it! Ship It! src/uri/schemes/http.hpp (line 54)

Re: Review Request 42237: Added docker image manifest parsing functions for strings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42237/#review114277 --- Ship it! Ship It! - Timothy Chen On Jan. 13, 2016, 6:23 a.m.,

Re: Review Request 42263: Added more structure for containerizer related subpages in home.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42263/ --- (Updated Jan. 13, 2016, 8:38 p.m.) Review request for mesos, Joerg Schad and

Re: Review Request 42216: Fixed gmock warnings in hook tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42216/#review114271 --- Ship it! Ship It! - Neil Conway On Jan. 12, 2016, 10:27 p.m.,

Re: Review Request 41820: Pulled out provisioner from linux filesystem isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41820/#review114279 --- Ship it! Ship It! - Timothy Chen On Jan. 11, 2016, 8:15 p.m.,

Re: Review Request 41820: Pulled out provisioner from linux filesystem isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41820/ --- (Updated Jan. 13, 2016, 1:19 p.m.) Review request for mesos, Artem

Re: Review Request 41820: Pulled out provisioner from linux filesystem isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41820/#review114255 --- Ship it! Thanks! THis is great!

Re: Review Request 42237: Added docker image manifest parsing functions for strings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42237/#review114260 --- Ship it! LGTM! - Gilbert Song On Jan. 12, 2016, 10:23 p.m.,

Re: Review Request 41870: Added ref-qualifiers to Option::get().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41870/ --- (Updated Jan. 13, 2016, 8:12 p.m.) Review request for mesos, Joris Van

Re: Review Request 41617: Added a new category called whitespace/mesos-comments to capture missing, leading, white-space in comments

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41617/ --- (Updated Jan. 13, 2016, 8:15 p.m.) Review request for mesos and Michael Park.

Re: Review Request 42216: Fixed gmock warnings in hook tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42216/#review114282 --- Can you include the names of the tests in the commit message? -

Re: Review Request 42215: Added expectations for call to mocked executor shutdown.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42215/#review114281 --- Ship it! Can you include the names of the tests in the commit

Re: Review Request 41243: Updated how we find the .git directory in bootstrap.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41243/ --- (Updated Jan. 13, 2016, 6:41 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 42236: Added a utility function to create https URI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42236/#review114257 --- Ship it! LGTM! Just consider whether or not we should put it as

Re: Review Request 42059: Updated ContainerLogger to use Subprocess::IO type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42059/#review114254 --- Ship it! src/slave/containerizer/mesos/containerizer.cpp (lines

Re: Review Request 41783: Logger Module: Implement the rotating container logger module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41783/#review113378 --- src/slave/container_loggers/rotate.hpp (line 36)

Re: Review Request 42254: Checked whether the remaining cluster resources is allocatable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42254/#review114262 --- Patch looks great! Reviews applied: [42221, 42254] Passed

Re: Review Request 41870: [stout] Added ref-qualifiers to Option::get().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41870/ --- (Updated Jan. 13, 2016, 8:11 p.m.) Review request for mesos, Joris Van

Re: Review Request 42263: Added more structure for containerizer related subpages in home.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42263/#review114274 --- Ship it! Ship It! - Jojy Varghese On Jan. 13, 2016, 8:38 p.m.,

Re: Review Request 41243: Updated how we find the .git directory in bootstrap.

> On Jan. 13, 2016, 12:26 p.m., Till Toenshoff wrote: > > This recent change breaks the functionality - it hangs now. Looks like 'git rev-parse --git-common-dir' sometimes returns the absolute path of the .git directory, and other times it returns a relative path. My relPath() function

Re: Review Request 41819: Added ContainerConfig to all isolators.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41819/ --- (Updated Jan. 13, 2016, 1:19 p.m.) Review request for mesos, Artem

Re: Review Request 41595: Updated `Master::Http::state` to use `jsonify` in mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41595/#review114416 --- I was wondering what the results of the benchmark would be with an

Re: Review Request 42172: Add documentation for logging and ContainerLogger.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42172/#review114415 --- Ship it! Ship It! - Benjamin Hindman On Jan. 12, 2016, 7:24

Re: Review Request 42273: Modified scheduler library to move the queue contents before `async`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42273/#review114426 --- Patch looks great! Reviews applied: [42273] Passed command:

Re: Review Request 42164: Allowed (un)reserve operations without a principal.

> On 一月 13, 2016, 5:22 a.m., Michael Park wrote: > > src/master/validation.cpp, line 703 > > > > > > First thing here is that the `principal` field in `ReservationInfo` is > > still marked `required`. What's our

  1   2   3   >