Re: Review Request 42618: Modified the `cgroup/net_cls` isolator to use the `NetClsHandleMgr`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42618/ --- (Updated Feb. 5, 2016, 10:24 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 42947: Implemented the `status` method in `CgroupNetClsIsolatorProcess`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42947/ --- (Updated Feb. 5, 2016, 10:32 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 42993: Support for multiple frameworks sharing the same resource.

> On Feb. 1, 2016, 3:51 a.m., Guangya Liu wrote: > > It is better add some unit tests in `hierarchical_allocator_tests.cpp` to > > cover the update in allocator for shareable resources. Added unit tests but included in https://reviews.apache.org/r/42996. - Anindya

Re: Review Request 43156: Added test: dynamic reservations with same role, different principals.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43156/#review118139 --- Ship it! Ship It! - Guangya Liu On 二月 5, 2016, 5:47 p.m.,

Re: Review Request 42735: Make bash scripts portable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42735/ --- (Updated Feb. 5, 2016, 4:51 p.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 42982: Defined a virtual `status` method for Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42982/ --- (Updated Feb. 5, 2016, 3:35 p.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 42982: Defined a virtual `status` method for Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42982/ --- (Updated Feb. 5, 2016, 3:35 p.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 42618: Modified the `cgroup/net_cls` isolator to use the `NetClsHandleMgr`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42618/ --- (Updated Feb. 5, 2016, 3:31 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 42618: Modified the `cgroup/net_cls` isolator to use the `NetClsHandleMgr`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42618/ --- (Updated Feb. 5, 2016, 3:27 p.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 42782: Added a unit-test to test net_cls major handles set from command line.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42782/ --- (Updated Feb. 5, 2016, 3:34 p.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 42947: Implemented the `status` method in `CgroupNetClsIsolatorProcess`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42947/ --- (Updated Feb. 5, 2016, 3:47 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 42782: Added a unit-test to test net_cls major handles set from command line.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42782/#review118031 --- Patch looks great! Reviews applied: [42982, 42983, 43096, 42618,

Re: Review Request 43107: Passed agent flag --cgroup_net_cls_primary_handle to net_cls isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43107/ --- (Updated Feb. 5, 2016, 3:34 p.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 42781: Added the --cgroups_net_cls_primary_handle flag to the slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42781/ --- (Updated Feb. 5, 2016, 3:32 p.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 43193: Fixed parsing docker image env vars.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43193/#review118034 --- Ship it! Ship It! - Jie Yu On Feb. 5, 2016, 10:14 a.m.,

Review Request 43156: Added test: dynamic reservations with same role, different principals.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43156/ --- Review request for mesos and Michael Park. Bugs: MESOS-4590

Re: Review Request 42735: Make bash scripts portable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42735/#review118039 --- Ship it! Ship It! - haosdent huang On Feb. 5, 2016, 4:51

Re: Review Request 43193: Fixed parsing docker image env vars.

> On Feb. 5, 2016, 5:18 p.m., Jie Yu wrote: > > Ship It! Jie Yu, Can you shepherd/commit it? - Shuai --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43193/#review118034

Re: Review Request 43168: Added working dir flag to command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43168/#review118040 --- Ship it! Ship It! - Jie Yu On Feb. 5, 2016, 1:24 a.m.,

Re: Review Request 43193: Fixed parsing docker image env vars.

> On Feb. 5, 2016, 5:18 p.m., Jie Yu wrote: > > Ship It! > > Shuai Lin wrote: > Jie Yu, Can you shepherd/commit it? oops, just saw it already commited, thanks! - Shuai --- This is an automatically generated e-mail. To reply,

Re: Review Request 43072: Use full screen width for Mesos UI using Bootstraps (v3.3.6) container-fluid

> On Feb. 2, 2016, 2:45 a.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [43072] > > > > Failed command: ./support/apply-review.sh -n -r 43072 > > > > Error: > > 2016-02-02 02:45:28 URL:https://reviews.apache.org/r/43072/diff/raw/ > > [226634/226634] -> "43072.patch" [1]

Re: Review Request 43240: Removed implicit, value changing conversion.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43240/#review118035 --- Fix it, then Ship it! src/log/tool/benchmark.cpp (line 209)

Re: Review Request 43240: Removed implicit, value changing conversion.

> On Feb. 5, 2016, 6:31 p.m., Jie Yu wrote: > > src/log/tool/benchmark.cpp, line 209 > > > > > > can you use 0xff here? Yes, I can and should. - Benjamin

Re: Review Request 43240: Removed implicit, value changing conversion.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43240/ --- (Updated Feb. 5, 2016, 6:41 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 43083: Supported working dir in docker runtime isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43083/ --- (Updated Feb. 5, 2016, 12:13 a.m.) Review request for mesos, Artem

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43032/#review117989 --- src/docker/docker.cpp (lines 538 - 540)

Re: Review Request 42947: Implemented the `status` method in `CgroupNetClsIsolatorProcess`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42947/ --- (Updated Feb. 5, 2016, 3:46 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 42751: Tweaked some resource test cases.

> On Feb. 5, 2016, 2:33 a.m., Guangya Liu wrote: > > src/tests/resources_tests.cpp, lines 327-328 > > > > > > Just a question, do we have some guidelines for when to use `ASSERT_EQ` > > and when to use `EXPECT_EQ`

Re: Review Request 42588: Added unit-test for `NetClsHandleManager`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42588/#review118069 --- Fix it, then Ship it!

Re: Review Request 42157: Changed ProvisionerAppcTest to use AppcStoreTest suite.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42157/#review118099 --- Ship it! Ship It! - Jie Yu On Jan. 22, 2016, 5:36 p.m.,

Re: Review Request 42995: Allow tasks to set persistent volume as readonly or readwrite resource.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42995/ --- (Updated Feb. 5, 2016, 10:57 p.m.) Review request for mesos and Adam B.

Re: Review Request 42992: Support sharing of resources through reference counting of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42992/ --- (Updated Feb. 5, 2016, 10:57 p.m.) Review request for mesos and Adam B.

Re: Review Request 42996: Add unit tests for sharing of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42996/ --- (Updated Feb. 5, 2016, 10:57 p.m.) Review request for mesos and Adam B.

Re: Review Request 42994: Added a persistent volume test framework for shared volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42994/ --- (Updated Feb. 5, 2016, 10:57 p.m.) Review request for mesos and Adam B.

Re: Review Request 42993: Support for multiple frameworks sharing the same resource.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42993/ --- (Updated Feb. 5, 2016, 10:57 p.m.) Review request for mesos and Adam B.

Re: Review Request 43220: Added script to generate docs from endpoint help strings.

> On Feb. 5, 2016, 5:17 a.m., Ben Mahler wrote: > > support/generate-endpoint-help.py, lines 225-227 > > > > > > Do you need the empty check? Also I think we've been doing `if > > new_name` in our python style.

Re: Review Request 42618: Modified the `cgroup/net_cls` isolator to use the `NetClsHandleMgr`.

> On Feb. 5, 2016, 12:31 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp, line 200 > > > > > > What's defaultPrimary? Who is the user? Can you just do the following: > > > >

Re: Review Request 43096: Added helper function in cgroup for supporting net_cls subsystem.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43096/ --- (Updated Feb. 5, 2016, 10:22 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 42947: Implemented the `status` method in `CgroupNetClsIsolatorProcess`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42947/ --- (Updated Feb. 5, 2016, 10:28 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 42782: Added a unit-test to test net_cls major handles set from command line.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42782/ --- (Updated Feb. 5, 2016, 10:27 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 43107: Passed agent flag --cgroup_net_cls_primary_handle to net_cls isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43107/ --- (Updated Feb. 5, 2016, 10:27 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 42156: Refactored up the common image creation in appc tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42156/#review118096 --- src/tests/containerizer/provisioner_appc_tests.cpp (line 55)

Re: Review Request 43144: Added env var to set upper bound on number of libprocess worker threads.

> On Feb. 5, 2016, 2:20 p.m., Qian Zhang wrote: > > 1. Besides changing the code, you may also need to update the following doc > > to describe the newly introduced env var "LIBPROCESS_MAX_WORKER_THREADS" > > https://github.com/apache/mesos/blob/master/docs/configuration.md#libprocess-options >

Re: Review Request 42997: Offer shareable resources to frameworks only if opted in.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42997/ --- (Updated Feb. 5, 2016, 10:57 p.m.) Review request for mesos and Adam B.

Re: Review Request 42998: Added docs for shareable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42998/ --- (Updated Feb. 5, 2016, 10:59 p.m.) Review request for mesos and Adam B.

Re: Review Request 43220: Added script to generate docs from endpoint help strings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43220/ --- (Updated Feb. 5, 2016, 11:17 p.m.) Review request for mesos, Ben Mahler, Greg

Re: Review Request 43144: Added env var to set upper bound on number of libprocess worker threads.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43144/ --- (Updated Feb. 5, 2016, 9:45 p.m.) Review request for mesos and Klaus Ma.

Re: Review Request 42781: Added the --cgroups_net_cls_primary_handle flag to the slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42781/#review118091 --- Ship it! Ship It! - Jie Yu On Feb. 5, 2016, 3:32 p.m.,

Re: Review Request 43239: Added Resources::size().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43239/#review118094 --- Ship it! Ship It! - Michael Park On Feb. 5, 2016, 2:18

Re: Review Request 42781: Added the --cgroups_net_cls_primary_handle flag to the slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42781/ --- (Updated Feb. 5, 2016, 10:26 p.m.) Review request for mesos and Jie Yu.

Review Request 43267: Returned "ServiceUnavailable" for slave's /state during recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43267/ --- Review request for mesos, Anand Mazumdar and Ben Mahler. Bugs: MESOS-4066

Re: Review Request 43261: Refactor process::initialize environment variable parsing into Flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43261/#review118104 --- Patch looks great! Reviews applied: [43260, 43261] Passed

Review Request 43272: Modify the containerizer, fetcher, and container logger's environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43272/ --- Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Till

Review Request 43271: Modify subprocess to deal with LIBPROCESS_PORT specially.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43271/ --- Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Till

Review Request 43261: Refactor process::initialize environment variable parsing into Flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43261/ --- Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Till

Re: Review Request 43156: Added test: dynamic reservations with same role, different principals.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43156/#review118085 --- Patch looks great! Reviews applied: [43156] Passed command:

Re: Review Request 42983: Implemented the `status` method in `MesosContainerizer`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42983/ --- (Updated Feb. 5, 2016, 8 p.m.) Review request for mesos and Jie Yu. Changes

Re: Review Request 43240: Removed implicit, value changing conversion.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43240/#review118067 --- Patch looks great! Reviews applied: [43240] Passed command:

Re: Review Request 43072: Use full screen width for Mesos UI using Bootstraps (v3.3.6) container-fluid

> On Feb. 2, 2016, 2:45 a.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [43072] > > > > Failed command: ./support/apply-review.sh -n -r 43072 > > > > Error: > > 2016-02-02 02:45:28 URL:https://reviews.apache.org/r/43072/diff/raw/ > > [226634/226634] -> "43072.patch" [1]

Review Request 43263: Updated site building instrucutions in site/README.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43263/ --- Review request for mesos. Repository: mesos Description --- Updated

Re: Review Request 43122: Updated doxygen target for site/Rakefile.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43122/ --- (Updated Feb. 5, 2016, 4:19 p.m.) Review request for mesos, Joseph Wu and Neil

Re: Review Request 43200: Updated role documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43200/#review117993 --- Patch looks great! Reviews applied: [43199, 43200] Passed

Re: Review Request 43105: Ensured the allocator does not double account resources.

> On 二月 4, 2016, 3:46 p.m., Guangya Liu wrote: > > This case may happen when master is recovering, framework recovery start > > before some agent. Can you please add a unit test to cover this code > > change? It could be register framework first, then addslave and check the > > result. > >

Re: Review Request 43083: Supported working dir in docker runtime isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43083/#review118003 --- Patch looks great! Reviews applied: [43019, 43020, 43021, 43022,

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

> On Feb. 5, 2016, 9:54 a.m., haosdent huang wrote: > > src/tests/containerizer/docker_tests.cpp, line 129 > > > > > > Why adjust await time here? I think 15 seconds should be enough to get > > version, start

Re: Review Request 43193: Fixed parsing docker image env vars.

> On Feb. 5, 2016, 8:47 a.m., Guangya Liu wrote: > > But the unit test does passed > > https://github.com/apache/mesos/blob/master/src/tests/containerizer/docker_tests.cpp#L578-L579 > > even without your fix, can you please clarify why the unit test passed for > > validating

Re: Review Request 43193: Fixed parsing docker image env vars.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43193/ --- (Updated Feb. 5, 2016, 10:14 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 43193: Fixed parsing docker image env vars.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43193/#review117992 --- But the unit test does passed

Re: Review Request 43193: Fixed parsing docker image env vars.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43193/ --- (Updated Feb. 5, 2016, 9:50 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 43193: Fixed parsing docker image env vars.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43193/#review117999 --- src/tests/containerizer/docker_tests.cpp (line 507)

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

> On Feb. 5, 2016, 9:54 a.m., haosdent huang wrote: > > src/tests/containerizer/docker_tests.cpp, line 129 > > > > > > Why adjust await time here? I think 15 seconds should be enough to get > > version, start

Re: Review Request 43193: Fixed parsing docker image env vars.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43193/#review118007 --- Patch looks great! Reviews applied: [43193] Passed command:

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43032/#review118009 --- Patch looks great! Reviews applied: [43032] Passed command:

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43032/#review117998 --- Fix it, then Ship it! Ship It! src/docker/docker.cpp (lines

Re: Review Request 43193: Fixed parsing docker image env vars.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43193/#review118004 --- Ship it! Thanks for the update - Guangya Liu On 二月 5, 2016,

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43032/ --- (Updated Feb. 5, 2016, 10:52 a.m.) Review request for mesos, Guangya Liu,

Re: Review Request 43144: Added env var to set upper bound on number of libprocess worker threads.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43144/#review118012 --- 1. Besides changing the code, you may also need to update the

Review Request 43269: MasterContender/MasterDetector loadable as modules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43269/ --- Review request for mesos. Bugs: MESOS-4610

Review Request 43276: Fix compilation on Ubuntu 15.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43276/ --- Review request for mesos, Artem Harutyunyan, Michael Park, and Neil Conway.

Re: Review Request 43258: Modified agent to get container status from containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43258/ --- (Updated Feb. 6, 2016, 1:26 a.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 43121: Updated Doxygen main page to use relative links.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43121/#review118119 --- Ship it! Ship It! - Ben Mahler On Feb. 3, 2016, 12:15 a.m.,

Re: Review Request 43220: Added script to generate docs from endpoint help strings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43220/#review118118 --- Looking great, just some minor thoughts around ways to make this

Re: Review Request 43258: Modified agent to get container status from containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43258/#review118125 --- src/slave/slave.cpp (lines 3228 - 3234)

Re: Review Request 42751: Tweaked some resource test cases.

> On 二月 5, 2016, 2:33 a.m., Guangya Liu wrote: > > src/tests/resources_tests.cpp, lines 327-328 > > > > > > Just a question, do we have some guidelines for when to use `ASSERT_EQ` > > and when to use `EXPECT_EQ` ?

Re: Review Request 43199: Updated authorization documentation.

> On Feb. 4, 2016, 7:43 p.m., Neil Conway wrote: > > docs/authorization.md, line 223 > > > > > > s/framework/principal/ , I'd think. Fixed this here, and elsewhere. - Greg

Re: Review Request 43200: Updated role documentation.

> On Feb. 5, 2016, 7:07 a.m., Guangya Liu wrote: > > docs/roles.md, line 21 > > > > > > Maybe `Configure Mesos to provide guaranteed resource allocations for > > use by a role.` is better? You can refer to `home.md`

Re: Review Request 43200: Updated role documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43200/#review118132 --- docs/roles.md (line 22)

Re: Review Request 42618: Modified the `cgroup/net_cls` isolator to use the `NetClsHandleMgr`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42618/#review118133 --- Ship it! Ship It! - Jie Yu On Feb. 5, 2016, 10:24 p.m.,

Re: Review Request 43276: Fix compilation on Ubuntu 15.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43276/#review118124 --- Ship it! Ship It! - Michael Park On Feb. 6, 2016, 12:34

Re: Review Request 43199: Updated authorization documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43199/ --- (Updated Feb. 6, 2016, 2:40 a.m.) Review request for mesos, Neil Conway and

Re: Review Request 43200: Updated role documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43200/ --- (Updated Feb. 6, 2016, 2:43 a.m.) Review request for mesos, Neil Conway and

Re: Review Request 43200: Updated role documentation.

> On 二月 5, 2016, 7:07 a.m., Guangya Liu wrote: > > docs/roles.md, line 21 > > > > > > Maybe `Configure Mesos to provide guaranteed resource allocations for > > use by a role.` is better? You can refer to `home.md`

Re: Review Request 43072: Use full screen width for Mesos UI using Bootstraps (v3.3.6) container-fluid

> On Feb. 2, 2016, 2:45 a.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [43072] > > > > Failed command: ./support/apply-review.sh -n -r 43072 > > > > Error: > > 2016-02-02 02:45:28 URL:https://reviews.apache.org/r/43072/diff/raw/ > > [226634/226634] -> "43072.patch" [1]

Re: Review Request 42157: Changed ProvisionerAppcTest to use AppcStoreTest suite.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42157/ --- (Updated Feb. 6, 2016, 1:35 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 42841: WIP: Introducing appc image fetcher.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42841/ --- (Updated Feb. 6, 2016, 1:36 a.m.) Review request for Jie Yu. Changes ---

Re: Review Request 43263: Updated site building instrucutions in site/README.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43263/#review118121 --- Thanks Kapil! site/README.md (lines 27 - 31)

Re: Review Request 43263: Updated site building instrucutions in site/README.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43263/#review118110 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 42156: Refactored up the common image creation in appc tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42156/ --- (Updated Feb. 6, 2016, 1:35 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 43122: Updated doxygen target for site/Rakefile.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43122/#review118120 --- Hm.. a bit tough to tell what this change is about, mind

Re: Review Request 43276: Fix compilation on Ubuntu 15.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43276/#review118117 --- Ship it! LGTM! Compiles and tests successfully under both

  1   2   >