Re: Review Request 43593: Add test for spliting revocable resources in separate offer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43593/#review119424 --- Patch looks great! Reviews applied: [43041, 43593] Passed

Re: Review Request 43552: Added a support/push-reviews.py script to push reviews upstream.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43552/#review119420 --- Patch looks great! Reviews applied: [43552] Passed command:

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

> On Feb. 12, 2016, 3:43 p.m., Timothy Chen wrote: > > src/tests/containerizer/docker_tests.cpp, line 139 > > > > > > You need to EXPECT_SOME on the find first, other wise it's basically an > > assert. Do you mean

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

> On Feb. 12, 2016, 3:43 p.m., Timothy Chen wrote: > > src/docker/docker.cpp, line 536 > > > > > > Seems like we're increasing trying to find docker versions in our code > > base. How about let's capture the docker

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43367/#review119413 --- src/tests/fetcher_cache_tests.cpp (line 194)

Re: Review Request 43636: Cleaned up various code in a test file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43636/#review119412 --- Patch looks great! Reviews applied: [43635, 43636] Passed

Re: Review Request 43634: Consistent markdown code style in persistent-volumes.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43634/#review119405 --- Patch looks great! Reviews applied: [43634] Passed command:

Re: Review Request 43593: Add test for spliting revocable resources in separate offer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43593/ --- (Updated Feb. 17, 2016, 3:01 a.m.) Review request for mesos, Guangya Liu,

Re: Review Request 43041: Update Master to send revocable resources in separate offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43041/ --- (Updated Feb. 17, 2016, 3 a.m.) Review request for mesos, Guangya Liu, Klaus

Re: Review Request 43635: Changed scalar resources to use fixed-point internally.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43635/#review119400 --- docs/attributes-resources.md (line 39)

Re: Review Request 43608: Speed up FetcherCache test cases by disable framework checkpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43608/ --- (Updated Feb. 17, 2016, 2:10 a.m.) Review request for mesos, Alexander

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43367/ --- (Updated Feb. 17, 2016, 2:11 a.m.) Review request for mesos, Alexander

Re: Review Request 43616: Documented that labels should not contain duplicate key-value pairs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43616/#review119399 --- include/mesos/mesos.proto (line 598)

Re: Review Request 43635: Changed scalar resources to use fixed-point internally.

> On Feb. 17, 2016, 8:30 a.m., Klaus Ma wrote: > > src/common/values.cpp, line 67 > > > > > > Let's add check on overflow; it will be helpful if scalar value was > > big. Scalar is a general type, there maybe used

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/#review119395 --- Patch looks great! Reviews applied: [43613, 43614, 43629, 43630,

Re: Review Request 43635: Changed scalar resources to use fixed-point internally.

> On Feb. 17, 2016, 12:30 a.m., Klaus Ma wrote: > > docs/attributes-resources.md, line 7 > > > > > > Any related to this patches? Not really, just a minor doc cleanup I made along the way. Happy to split into a

Review Request 43552: Added a support/push-reviews.py script to push reviews upstream.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43552/ --- Review request for mesos, Artem Harutyunyan, Kevin Klues, and Michael Park.

Re: Review Request 43635: Changed scalar resources to use fixed-point internally.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43635/#review119382 --- docs/attributes-resources.md (line 7)

Re: Review Request 43618: Added examples for documentation on master/slave state.json.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43618/#review119389 --- Ship it! Ship It! - Vinod Kone On Feb. 16, 2016, 9:59 p.m.,

Review Request 43638: Fixed minor style issues in command_utils.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43638/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 43565: Implemented `status` method in `ComposingContainerizer`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43565/#review119387 --- Ship it! Ship It! - Jie Yu On Feb. 14, 2016, 4:31 p.m.,

Re: Review Request 43015: Fixed persistent volumes with docker tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43015/#review119340 --- src/slave/containerizer/docker.cpp (lines 161 - 162)

Re: Review Request 43336: Introduced Appc image fetcher.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43336/ --- (Updated Feb. 16, 2016, 11:36 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 43583: Added documentation for multiple-disk support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43583/#review119380 --- Open issues were adressed by https://reviews.apache.org/r/43633.

Review Request 43636: Cleaned up various code in a test file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43636/ --- Review request for mesos and Joris Van Remoortere. Repository: mesos

Review Request 43635: Changed scalar resources to use fixed-point internally.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43635/ --- Review request for mesos and Joris Van Remoortere. Bugs: MESOS-4687

Re: Review Request 43634: Consistent markdown code style in persistent-volumes.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43634/#review119379 --- Ship it! Ship It! - Neil Conway On Feb. 16, 2016, 11:03

Re: Review Request 43616: Documented that labels should not contain duplicate key-value pairs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43616/#review119378 --- Bad patch! Reviews applied: [43616] Failed command:

Re: Review Request 43633: Improved Multiple Disk documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43633/#review119370 --- Ship it! Ship It! - Neil Conway On Feb. 16, 2016, 10:48

Re: Review Request 43633: Improved Multiple Disk documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43633/ --- (Updated Feb. 16, 2016, 10:48 p.m.) Review request for mesos, Joris Van

Review Request 43633: Improved Multiple Disk documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43633/ --- Review request for mesos, Joris Van Remoortere and Neil Conway. Bugs:

Re: Review Request 43490: Added testcase for TASK_KILLING state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43490/#review119369 --- Patch looks great! Reviews applied: [43487, 43488, 43489, 43490]

Review Request 43615: Update test suite to use the reworked MesosTest helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/ --- Review request for mesos, Bernd Mathiske and Artem Harutyunyan. Bugs:

Review Request 43629: Especially updated tests to use the updated MesosTest helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43629/ --- Review request for mesos, Bernd Mathiske and Artem Harutyunyan. Bugs:

Review Request 43613: Refactor cluster test helpers into self-contained objects.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43613/ --- Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Artem

Review Request 43619: Added generated docs from updates to state.json documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43619/ --- Review request for mesos, Michael Park and Vinod Kone. Bugs: MESOS-3568

Re: Review Request 43618: Added examples for documentation on master/slave state.json.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43618/ --- (Updated Feb. 16, 2016, 9:59 p.m.) Review request for mesos, Michael Park and

Re: Review Request 43583: Added documentation for multiple-disk support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43583/#review119364 --- Fix it, then Ship it! docs/multiple-disk.md (line 54)

Re: Review Request 43583: Added documentation for multiple-disk support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43583/#review119258 --- docs/multiple-disk.md (line 31)

Re: Review Request 43583: Added documentation for multiple-disk support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43583/#review119363 --- docs/multiple-disk.md (line 138)

Re: Review Request 43583: Added documentation for multiple-disk support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43583/ --- (Updated Feb. 16, 2016, 9:43 p.m.) Review request for mesos, Jie Yu and Neil

Re: Review Request 43583: Added documentation for multiple-disk support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43583/#review119357 --- Fix it, then Ship it! docs/multiple-disk.md (line 83)

Re: Review Request 43159: Removed the duplicate "active" field in json schema of `Framework`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43159/#review119351 --- Ship it! Ship It! - Joris Van Remoortere On Feb. 3, 2016,

Review Request 43618: Added examples for documentation on master/slave state.json.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43618/ --- Review request for mesos, Michael Park and Vinod Kone. Bugs: MESOS-3568

Review Request 43617: Synchronized v1/ and unversioned copies of `mesos.proto`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43617/ --- Review request for mesos and Joris Van Remoortere. Repository: mesos

Review Request 43616: Documented that labels should not contain duplicate key-value pairs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43616/ --- Review request for mesos and Michael Park. Repository: mesos Description

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

> On Feb. 12, 2016, 3:43 p.m., Timothy Chen wrote: > > src/docker/docker.cpp, line 543 > > > > > > Does label.value() return a Try? What kind of error do we expect from > > it? No, it does not return Try. But I

Re: Review Request 43490: Added testcase for TASK_KILLING state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43490/ --- (Updated Feb. 16, 2016, 6:23 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 43490: Added testcase for TASK_KILLING state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43490/ --- (Updated Feb. 16, 2016, 6:20 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 42696: Speed up FetcherCacheTest.Local* test by reduce loop.

> On Feb. 16, 2016, 11:02 a.m., Alexander Rukletsov wrote: > > Could you please explain in description why disabling checkpointing speeds > > up the test and why it is ok to disable it for these tests? > > haosdent huang wrote: > Sure! > > Bernd Mathiske wrote: > Not writing to disk

Re: Review Request 43608: Speed up FetcherCache test cases by disable framework checkpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43608/ --- (Updated Feb. 16, 2016, 6:12 p.m.) Review request for mesos, Alexander

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43367/ --- (Updated Feb. 16, 2016, 6:03 p.m.) Review request for mesos, Alexander

Re: Review Request 43035: Added a test for the interaction between timers and destroyed Groups.

> On Feb. 16, 2016, 2:09 p.m., Joris Van Remoortere wrote: > > src/tests/group_tests.cpp, line 492 > > > > > > Do you mean `Ensure that no pending messages are delivered.`? > > Or `if any`, then what? i.e., we

Re: Review Request 43035: Added a test for the interaction between timers and destroyed Groups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43035/ --- (Updated Feb. 16, 2016, 5:59 p.m.) Review request for mesos and Joris Van

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43367/ --- (Updated Feb. 16, 2016, 5:58 p.m.) Review request for mesos and Bernd

Re: Review Request 42696: Speed up FetcherCacheTest.Local* test by reduce loop.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42696/ --- (Updated Feb. 16, 2016, 5:55 p.m.) Review request for mesos, Alexander

Re: Review Request 43316: Decrease countCacheEntries in FetcherCacheTest.SimpleEviction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43316/ --- (Updated Feb. 16, 2016, 5:55 p.m.) Review request for mesos, Alexander

Re: Review Request 43367: Speed up FetcherCache test cases by advance allocation_interval.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43367/ --- (Updated Feb. 16, 2016, 5:55 p.m.) Review request for mesos and Bernd

Review Request 43608: Speed up FetcherCache test cases by disable framework checkpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43608/ --- Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Bernd

Re: Review Request 42696: Speed up FetcherCacheTest.Local* test cases.

> On Feb. 16, 2016, 11:02 a.m., Alexander Rukletsov wrote: > > Could you please explain in description why disabling checkpointing speeds > > up the test and why it is ok to disable it for these tests? > > haosdent huang wrote: > Sure! > > Bernd Mathiske wrote: > Not writing to disk

Re: Review Request 43583: Added documentation for multiple-disk support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43583/#review119326 --- Patch looks great! Reviews applied: [43583] Passed command:

Re: Review Request 43488: Adding framework capability for TASK_KILLING.

> On Feb. 16, 2016, 6:24 p.m., Klaus Ma wrote: > > include/mesos/mesos.proto, line 261 > > > > > > Do you mean framework can filter `killing` state? I thinke this's not > > necessary. > > Abhishek Dasgupta wrote:

Re: Review Request 42696: Speed up FetcherCacheTest.Local* test cases.

> On Feb. 16, 2016, 11:02 a.m., Alexander Rukletsov wrote: > > Could you please explain in description why disabling checkpointing speeds > > up the test and why it is ok to disable it for these tests? > > haosdent huang wrote: > Sure! > > Bernd Mathiske wrote: > Not writing to disk

Re: Review Request 43490: Added testcase for TASK_KILLING state.

> On Feb. 16, 2016, 10:27 a.m., Guangya Liu wrote: > > src/tests/scheduler_tests.cpp, lines 575-576 > > > > > > one line I think this the common style adapted across all of the test cases, so I am keeping them as

Re: Review Request 43490: Added testcase for TASK_KILLING state.

> On Feb. 16, 2016, 10:27 a.m., Guangya Liu wrote: > > src/tests/scheduler_tests.cpp, lines 578-579 > > > > > > one line Dropping the issue for the same reason like above. - Abhishek

Re: Review Request 43488: Adding framework capability for TASK_KILLING.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43488/ --- (Updated Feb. 16, 2016, 3:30 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 43488: Adding framework capability for TASK_KILLING.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43488/ --- (Updated Feb. 16, 2016, 3:22 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/#review119315 --- Patch looks great! Reviews applied: [42516] Passed command:

Re: Review Request 43034: Added EXPECT_NO_FUTURE_DISPATCHES to libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43034/#review119313 --- Ship it! Ship It! - Joris Van Remoortere On Feb. 1, 2016,

Re: Review Request 43035: Added a test for the interaction between timers and destroyed Groups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43035/#review119309 --- src/tests/group_tests.cpp (lines 450 - 454)

Re: Review Request 43033: Cleaned up code style and fixed typos in comments.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43033/#review119308 --- Ship it! Ship It! - Joris Van Remoortere On Jan. 31, 2016,

Re: Review Request 43583: Added documentation for multiple-disk support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43583/ --- (Updated Feb. 16, 2016, 1:58 p.m.) Review request for mesos, Jie Yu and Neil

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/ --- (Updated Feb. 16, 2016, 12:39 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 42516: Add support for user-defined networks.

> On Feb. 16, 2016, 4:04 a.m., Timothy Chen wrote: > > Thinking about it a bit more I think it's fine without a unit test as it > > requires docker network create. Did you test this manually and made sure it > > worked? > > Once you update the comments I can merge it. I fixed all the typos

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43367/#review119303 --- Patch looks great! Reviews applied: [42696, 43316, 43367]

Re: Review Request 43593: Add test for spliting revocable resources in separate offer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43593/ --- (Updated Feb. 16, 2016, 12:02 p.m.) Review request for mesos, Guangya Liu,

Re: Review Request 42696: Speed up FetcherCacheTest.Local* test cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42696/#review119302 --- Ship it! - Benjamin Bannier On Feb. 16, 2016, 12:39 p.m.,

Re: Review Request 43316: Decrease countCacheEntries in FetcherCacheTest.SimpleEviction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43316/#review119301 --- Ship it! Ship It! - Benjamin Bannier On Feb. 16, 2016,

Re: Review Request 43041: Update Master to send revocable resources in separate offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43041/ --- (Updated Feb. 16, 2016, 11:57 a.m.) Review request for mesos, Guangya Liu,

Re: Review Request 43041: Update Master to send revocable resources in separate offers.

> On Feb. 16, 2016, 10:08 a.m., Klaus Ma wrote: > > src/master/master.cpp, line 5285 > > > > > > Use `Resources::nonRevocable()` > > > > Maybe use `Try createOffer(...)` is better; so we can check the > >

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

> On Feb. 16, 2016, 3:02 a.m., Bernd Mathiske wrote: > > src/tests/fetcher_cache_tests.cpp, line 422 > > > > > > In some fetcher cache tests, we specifically want to find out if > > concurrent execution of

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43367/ --- (Updated Feb. 16, 2016, 11:42 a.m.) Review request for mesos and Bernd

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43367/ --- (Updated Feb. 16, 2016, 11:41 a.m.) Review request for mesos and Bernd

Re: Review Request 43316: Decrease countCacheEntries in FetcherCacheTest.SimpleEviction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43316/ --- (Updated Feb. 16, 2016, 11:39 a.m.) Review request for mesos and Bernd

Re: Review Request 42696: Speed up FetcherCacheTest.Local* test cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42696/ --- (Updated Feb. 16, 2016, 11:39 a.m.) Review request for mesos and Bernd

Re: Review Request 42696: Speed up FetcherCacheTest.Local* test cases.

> On Feb. 16, 2016, 3:02 a.m., Alexander Rukletsov wrote: > > Could you please explain in description why disabling checkpointing speeds > > up the test and why it is ok to disable it for these tests? > > haosdent huang wrote: > Sure! Not writing to disk costs less time. If a test does

Re: Review Request 42696: Speed up FetcherCacheTest.Local* test cases.

> On Feb. 16, 2016, 11:02 a.m., Alexander Rukletsov wrote: > > Could you please explain in description why disabling checkpointing speeds > > up the test and why it is ok to disable it for these tests? Sure! - haosdent --- This is an

Re: Review Request 42696: Speed up FetcherCacheTest.Local* test cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42696/#review119291 --- src/tests/fetcher_cache_tests.cpp (line 115)

Re: Review Request 43367: Speed up FetcherCache test cases by advance allocation_interval.

> On Feb. 16, 2016, 11:02 a.m., Bernd Mathiske wrote: > > src/tests/fetcher_cache_tests.cpp, line 422 > > > > > > In some fetcher cache tests, we specifically want to find out if > > concurrent execution of

Re: Review Request 43488: Adding framework capability for TASK_KILLING.

> On Feb. 16, 2016, 10:24 a.m., Klaus Ma wrote: > > include/mesos/mesos.proto, line 261 > > > > > > Do you mean framework can filter `killing` state? I thinke this's not > > necessary. No. This is framework

Re: Review Request 42696: Speed up FetcherCacheTest.Local* test cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42696/#review119294 --- Could you please explain in description why disabling

Re: Review Request 43367: Speed up FetcherCache test cases by advance allocation_interval.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43367/#review119293 --- src/tests/fetcher_cache_tests.cpp (line 422)

Re: Review Request 42696: Speed up FetcherCacheTest.Local* test cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42696/#review119290 --- Ship it! Ship It! - Bernd Mathiske On Feb. 9, 2016, 4:48

Re: Review Request 43490: Added testcase for TASK_KILLING state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43490/#review119289 --- Patch looks great! Reviews applied: [43487, 43488, 43489, 43490]

Re: Review Request 43490: Added testcase for TASK_KILLING state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43490/#review119285 --- src/tests/mesos.hpp (line 420)

Re: Review Request 43488: Adding framework capability for TASK_KILLING.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43488/#review119288 --- include/mesos/mesos.proto (line 261)

Re: Review Request 43489: KillTask introduces TASK_KILLING state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43489/ --- (Updated Feb. 16, 2016, 10:23 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 43041: Update Master to send revocable resources in separate offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43041/#review119279 --- src/master/master.cpp (line 5283)

Re: Review Request 43489: KillTask introduces TASK_KILLING state.

> On 二月 16, 2016, 9:06 a.m., Guangya Liu wrote: > > src/launcher/executor.cpp, line 461 > > > > > > adjust the alignment: Keep 4 space align with `foreach` Sorry, not 4 spaces, but keep align with above

Re: Review Request 43487: Add TASK_KILLING state.

> On Feb. 12, 2016, 10:39 a.m., Ben Mahler wrote: > > Thanks Abhishek! > > > > Please also do the following in this patch: > > > > * Add gauges for `tasks_killing`. See src/master/metrics.hpp and > > src/slave/metrics.hpp and compare with `tasks_running`. Hi Ben, added the gauges. -

  1   2   >