Re: Review Request 44975: Updated cgroups test cases for cgroups device support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44975/#review124110 --- Patch looks great! Reviews applied: [44974, 44975] Passed comman

Re: Review Request 44944: Handled chunked responses in docker URI fetcher.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44944/ --- (Updated March 17, 2016, 1:50 a.m.) Review request for mesos, Gilbert Song, Joj

Review Request 44998: Fixed m4 macro to enable strict C++11 conformance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44998/ --- Review request for mesos and Joris Van Remoortere. Bugs: MESOS-4963 https:/

Re: Review Request 45016: Fixed Python build breakage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45016/#review124199 --- Ship it! Ship It! - Joris Van Remoortere On March 18, 2016,

Re: Review Request 43613: Refactor cluster test helpers into self-contained objects.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43613/#review123785 --- Committed with the following formatting fixes. src/tests/cluster

Review Request 44893: Remove fetcher header file in containerizer.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44893/ --- Review request for mesos and Till Toenshoff. Repository: mesos Description --

Re: Review Request 44767: Added authentication information to master endpoints.

> On March 14, 2016, 10:51 p.m., Greg Mann wrote: > > docs/endpoints/master/create-volumes.md, line 24 > > > > > > I wonder if the shorthand "iff" might be a bit too esoteric for these > > help strings? We actually

Re: Review Request 44707: Added validation for task's kill policy.

> On March 15, 2016, 8:35 p.m., Ben Mahler wrote: > > Could you add a corresponding test? Having it in the header should make > > this really easy :) Sure, but I'll write a more complex test than just unit testing the validation function. - Alexander ---

Re: Review Request 44379: Correctly parse perf stat format for non-vanilla 3.10 kernel.

Hey Fan, Left some comments, mostly I'm a bit confused by your comment that OS vendors can tweak the format. How did you know they only tweak it that particular way? Ben On Wed, Mar 9, 2016 at 11:53 PM, Mesos ReviewBot wrote: > This is an automatically generated e-mail. To reply, visit: > http

Re: Review Request 44547: Added functions in promises to the collect header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44547/ --- (Updated March 18, 2016, 12:29 a.m.) Review request for mesos and Benjamin Hind

Re: Review Request 44543: Removed unnecessary MasterContender and MasterDetector definitions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44543/#review124284 --- src/master/contender.hpp (lines 16 - 17)

Re: Review Request 44555: Implemented the framework and create() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44555/#review123973 --- Fix it, then Ship it! src/slave/containerizer/mesos/isolators/

Re: Review Request 44662: Added kill policies and shutdown grace period to the CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44662/ --- (Updated March 18, 2016, 5:24 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44975: Updated cgroups test cases for cgroups device support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44975/#review124417 --- Patch looks great! Reviews applied: [44974, 44975] Passed comman

Re: Review Request 44553: Added authentication to agent HTTP endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44553/#review124207 --- src/slave/slave.cpp (line 677)

Review Request 44981: Marked some private `json` functions as `static`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44981/ --- Review request for mesos and Michael Park. Repository: mesos Description

Re: Review Request 44653: Cleaned up formatting in command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44653/#review124271 --- Ship it! Ship It! - Ben Mahler On March 17, 2016, 11:28 p.m.

Review Request 45006: Added `devolve` overloads for `v1::TaskStatus`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45006/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-3559 https://issues.ap

Review Request 44897: Update containerizer construction in hook_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44897/ --- Review request for mesos and Till Toenshoff. Repository: mesos Description --

Re: Review Request 44854: Added validation for executor's shutdown grace period.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44854/ --- (Updated March 17, 2016, 11:34 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44229: Added upgrade testing script.

> On March 16, 2016, 12:43 a.m., Vinod Kone wrote: > > support/test-upgrade.py, line 63 > > > > > > s/persistent-volume-framework/test-framework/ ? > > > > actuallly we should be testing the long-lived-framew

Review Request 45010: Fixed newlines for include directives.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45010/ --- Review request for mesos, Jie Yu and Neil Conway. Repository: mesos Descripti

Re: Review Request 44826: Remove `SlaveState` in `TestContainerizer` during recover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44826/ --- (Updated March 16, 2016, 5:56 p.m.) Review request for mesos and Till Toenshoff

Re: Review Request 45034: Removed superfluous blank line in slave/http.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45034/#review124291 --- Ship it! Ship It! - Adam B On March 18, 2016, 8:18 a.m., Joe

Re: Review Request 44975: Updated cgroups test cases for cgroups device support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44975/ --- (Updated March 18, 2016, 9:35 a.m.) Review request for mesos, Ben Mahler, Felix

Re: Review Request 44989: Fixed a race in the resource offers tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44989/ --- (Updated March 18, 2016, 4:35 p.m.) Review request for mesos, Adam B and Joerg

Re: Review Request 44798: Update `Slave::_recoverContainerizer` to use `ContainerState`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44798/ --- (Updated March 16, 2016, 5:56 p.m.) Review request for mesos and Till Toenshoff

Re: Review Request 44703: Added Doxygen docs for basic HTTP authenticator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44703/ --- (Updated March 17, 2016, 7:40 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).

> On March 18, 2016, 7:03 p.m., haosdent huang wrote: > > support/non-ascii.py, line 21 > > > > > > Seems we have to update this when we update third part dependencies > > every time? For example, if we update protob

Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45033/ --- (Updated March 19, 2016, 6:26 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33174/ --- (Updated March 16, 2016, 7:15 p.m.) Review request for mesos, Ian Downes, Jie Y

Re: Review Request 44905: Update containerizer construction in isolator_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44905/ --- (Updated March 16, 2016, 5:57 p.m.) Review request for mesos and Till Toenshoff

Re: Review Request 44654: Fixed hard-coded executor shutdown grace period in executor library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44654/ --- (Updated March 17, 2016, 11:30 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 43884: Added allocator metrics for used quotas.

> On March 17, 2016, 9:07 p.m., Ben Mahler wrote: > > docs/monitoring.md, lines 876-883 > > > > > > Thanks! How about: > > > > ``` > > > > > > allocator/mesos/quota//_allocated > >

Re: Review Request 44810: Documentation change for the update quota feature.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44810/#review123988 --- Patch looks great! Reviews applied: [44810] Passed command: expo

Re: Review Request 44912: Used the same fixture for all related tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44912/#review123911 --- Ship it! Ship It! - Ben Mahler On March 16, 2016, 3:47 p.m.,

Re: Review Request 44989: Fixed a race in the resource offers tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44989/ --- (Updated March 18, 2016, 2:48 a.m.) Review request for mesos, Adam B and Joerg

Re: Review Request 44678: Modified basic HTTP authenticator creator to accept realm.

> On March 17, 2016, 10:38 p.m., Joerg Schad wrote: > > src/authentication/http/basic_authenticator_factory.cpp, line 67 > > > > > > We do nor add additional information to the error is that a concious > > choice? If

Re: Review Request 44898: Update containerizer construction in health_check_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44898/ --- (Updated March 16, 2016, 5:57 p.m.) Review request for mesos and Till Toenshoff

Review Request 44901: Update containerizer construction in filesystem_isolator_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44901/ --- Review request for mesos and Till Toenshoff. Repository: mesos Description --

Re: Review Request 44999: Fixed m4 macro to enable strict C++11 conformance in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44999/#review124134 --- Ship it! Ship It! - Joris Van Remoortere On March 17, 2016,

Re: Review Request 44851: Renamed an allocator metric.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44851/#review124143 --- src/master/allocator/mesos/metrics.hpp (lines 40 - 42)

Re: Review Request 44543: Removed unnecessary MasterContender and MasterDetector definitions.

> On March 18, 2016, 2:03 p.m., Joseph Wu wrote: > > src/master/contender.hpp, lines 16-17 > > > > > > You might have missed my earlier comment (because I didn't make it a RB > > "issue"). Are these two files delete

Review Request 45003: Fixed rmdir comment for FTS_SLNONE as per coding guidelines.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45003/ --- Review request for mesos, Jie Yu and Neil Conway. Repository: mesos Descripti

Re: Review Request 44949: Add XFS disk isolator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44949/ --- (Updated March 17, 2016, 10:42 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45033/ --- (Updated March 19, 2016, 6:08 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 44934: Updated mesos-execute to add support for Appc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44934/ --- (Updated March 18, 2016, 5:39 p.m.) Review request for mesos and Jie Yu. Bugs

Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).

> On March 18, 2016, 7:08 p.m., haosdent huang wrote: > > support/non-ascii.py, line 47 > > > > > > Is it possible to print the match test as well? Sometimes find the > > invalid char in a long line is not easy. I a

Review Request 44979: Filled in the guts of the Nvidia GPU isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44979/ --- Review request for mesos, Ben Mahler, Kevin Klues, and Vikrama Ditya. Bugs: Mes

Re: Review Request 44822: Remove `SlaveState` in `MesosContainerizer` during recover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44822/ --- (Updated March 16, 2016, 5:56 p.m.) Review request for mesos and Till Toenshoff

Re: Review Request 44895: Update containerizer construction in container_logger_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44895/ --- (Updated March 16, 2016, 5:56 p.m.) Review request for mesos and Till Toenshoff

Re: Review Request 44825: Remove `SlaveState` in `ExternalContainerizer` during recover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44825/ --- (Updated March 16, 2016, 5:56 p.m.) Review request for mesos and Till Toenshoff

Re: Review Request 44883: Fix the mis-leading URI fetcher error message (MESOS-4954).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44883/#review123830 --- Fix it, then Ship it! LGTM. Thanks for putting out a patch for

Review Request 44985: Fix the broken ProvisionerDockerPullerTest on Centos7.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44985/ --- Review request for mesos, Bernd Mathiske and Joseph Wu. Bugs: MESOS-4810 ht

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/#review123891 --- src/tests/containerizer/port_mapping_tests.cpp (line 2004)

Re: Review Request 44989: Fixed a race in the resource offers tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44989/ --- (Updated March 18, 2016, 6:55 p.m.) Review request for mesos, Adam B and Joerg

Re: Review Request 44908: Update `MockDockerContainerizer` construction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44908/ --- (Updated March 16, 2016, 5:57 p.m.) Review request for mesos and Till Toenshoff

Review Request 45018: MESOS-3481 Add const accessor to Master flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45018/ --- Review request for mesos, Joris Van Remoortere and Joseph Wu. Repository: mesos

Re: Review Request 44660: Used `KillPolicy` and shutdown grace period in docker executor.

> On March 15, 2016, 11:21 p.m., Ben Mahler wrote: > > src/docker/executor.cpp, lines 101-105 > > > > > > Ditto feedback from previous reviews about this no longer being a > > default. Per offline discussion, we de

Re: Review Request 44672: Added normalize method to registry puller.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44672/#review123690 --- Please add a test to test if we can properly handle images like 'a

Re: Review Request 44435: Fixed a bug that causes the task stuck in staging state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44435/#review124414 --- Ship it! Ship It! - Jie Yu On March 19, 2016, 3:35 a.m., Shu

Review Request 45038: Fixed email address in Python build file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45038/ --- Review request for mesos and Joris Van Remoortere. Repository: mesos Descript

Re: Review Request 44660: Used `KillPolicy` and shutdown grace period in docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44660/ --- (Updated March 18, 2016, 5:21 p.m.) Review request for mesos, Ben Mahler, Gilbe

Re: Review Request 44825: Remove `SlaveState` in `ExternalContainerizer` during recover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44825/ --- (Updated March 16, 2016, 11:26 a.m.) Review request for mesos and Till Toenshof

Re: Review Request 45000: MESOS-3902: Fix in location header during redirect from non-leader.

> On March 19, 2016, 1:24 a.m., Ben Whitehead wrote: > > src/master/http.cpp, line 959 > > > > > > According to the rules defined in > > https://tools.ietf.org/html/rfc3986#section-5 we should be fine to use a > >

Re: Review Request 44762: [WIP][PROPOSAL_1]Add CgroupsIsolator. This is only used for discussion.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44762/#review124411 --- Let me discard this because we perfer https://reviews.apache.org/r

Re: Review Request 44655: Made `shutdown_grace_period` configurable in `ExecutorInfo`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44655/ --- (Updated March 17, 2016, 11:33 p.m.) Review request for mesos, Ben Mahler and G

Re: Review Request 44899: Update containerizer construction in slave_recovery_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44899/ --- (Updated March 16, 2016, 5:57 p.m.) Review request for mesos and Till Toenshoff

Re: Review Request 45046: Created URI.filename to name fetched files in sandbox where appropriate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45046/ --- (Updated March 18, 2016, 11:30 p.m.) Review request for mesos, Vinod Kone and Z

Re: Review Request 44989: Fixed a race in the resource offers tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44989/#review124116 --- src/tests/resource_offers_tests.cpp (line 63)

Re: Review Request 44758: Upgrade to clang-format-3.8 (MESOS-4906).

> On March 17, 2016, 4:09 p.m., Michael Park wrote: > > The patch looks good to me. Would you like to send an announcement email to > > the dev list about this upgrade? I can do it if you'd rather not. Hi Michael, Thanks a lot for the help! I will send out the email to the dev list shortly.

Review Request 44945: Add autoconf tests for XFS project quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44945/ --- Review request for mesos, Jie Yu and Jiang Yan Xu. Bugs: MESOS-4828 https:/

Re: Review Request 44515: Added agent flags for HTTP authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44515/#review124157 --- Fix it, then Ship it! Only minor nits src/slave/flags.cpp (li

Review Request 44902: Update containerizer construction in memory_pressure_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44902/ --- Review request for mesos and Till Toenshoff. Repository: mesos Description --

Re: Review Request 45008: Moved command scheduler to use the scheduler library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45008/#review124147 --- src/cli/execute.cpp (line 448)

Re: Review Request 44421: Added support for "overlay" keyword.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44421/#review124155 --- Is this chunk of code testable? - Jay Guo On March 11, 2016, 11

Review Request 44994: Added a test for executor shutdown grace period.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44994/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-4949 https://issues.ap

Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45033/ --- Review request for mesos, Alexander Rukletsov and Bernd Mathiske. Bugs: MESOS-4

Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45033/#review124408 --- Patch looks great! Reviews applied: [45033] Passed command: expo

Re: Review Request 44758: Upgrade to clang-format-3.8 (MESOS-4906).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44758/#review124090 --- Fix it, then Ship it! support/clang-format (line 3)

Re: Review Request 44080: Windows:[1/2] Implemented `os::gmtime_r`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44080/#review124228 --- 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp (li

Re: Review Request 44894: Remove `Fetcher` in `MesosContainerizer::create`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44894/ --- (Updated March 16, 2016, 5:56 p.m.) Review request for mesos and Till Toenshoff

Review Request 45040: Added a test for task's kill policy.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45040/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-4909 https://issues.ap

Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).

> On March 18, 2016, 7:03 p.m., haosdent huang wrote: > > docs/versioning.md, line 85 > > > > > > Any reason we need change here? Hi haosdent, the left is one unicode (U+2026) of "Horizontal Ellipsis" (three dots).

Review Request 44989: Fixed a race in the resource offers tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44989/ --- Review request for mesos, Adam B and Joerg Schad. Bugs: MESOS-4849 https://

Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45033/#review124256 --- support/non-ascii.py (line 47)

Re: Review Request 44989: Fixed a race in the resource offers tests.

> On March 18, 2016, 9:47 a.m., Adam B wrote: > > src/tests/resource_offers_tests.cpp, line 63 > > > > > > Why pause so soon? You can wait until after the master is started, but > > just before you start calling Star

Re: Review Request 44709: Allowed unknown flags in command and docker executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44709/#review124280 --- Bad patch! Reviews applied: [44709, 44662, 44661, 44660, 44658, 4

Re: Review Request 44974: Added device support in cgroups abstraction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44974/ --- (Updated March 18, 2016, 9:41 a.m.) Review request for mesos, Ben Mahler, Felix

Re: Review Request 44544: Moved contender and detector definitions into separate directories.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44544/ --- (Updated March 18, 2016, 12:29 a.m.) Review request for mesos and Benjamin Hind

Re: Review Request 44678: Modified basic HTTP authenticator creator to accept realm.

> On March 18, 2016, 8:55 a.m., Adam B wrote: > > src/authentication/http/basic_authenticator_factory.cpp, lines 87-91 > > > > > > Is it ok to specify a realm but no credentials? Does that just mean > > that nobody c

Re: Review Request 44760: Windows: Fixed non-blocking connect.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44760/#review124144 --- Ship it! Ship It! - Alex Naparu On March 17, 2016, 6:54 p.m.

Re: Review Request 44954: Regenerated master endpoint documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44954/#review124055 --- Bad patch! Reviews applied: [44954, 44767, 44766, 44768] Failed

Re: Review Request 44435: Fixed a bug that causes the task stuck in staging state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44435/#review124405 --- Patch looks great! Reviews applied: [44435] Passed command: expo

Re: Review Request 44554: Added agent HTTP authentication to the docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44554/#review124162 --- Looks pretty good. Thanks! docs/authentication.md (lines 88 - 89

Re: Review Request 44622: Introduced a protobuf message "NetworkResult".

> On March 12, 2016, 2:51 a.m., Avinash sridharan wrote: > > Can we introduce the protobuf before the `prepare` method patch? Sure. > On March 12, 2016, 2:51 a.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/spec.proto, line 77 > >

Re: Review Request 44138: Windows:[1/2] Lifted socket API into Stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44138/ --- (Updated March 17, 2016, 6:48 p.m.) Review request for mesos, Alex Naparu, Dani

Re: Review Request 44549: Introduced a protobuf message "NetworkConfig".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44549/#review123972 --- Fix it, then Ship it! src/CMakeLists.txt (line 279)

Re: Review Request 44758: Upgrade to clang-format-3.8 (MESOS-4906).

> On March 17, 2016, 8:34 p.m., Michael Park wrote: > > support/clang-format, line 3 > > > > > > Can we uncomment this? Our style by definition is > > > > > The Mesos codebase follows the Google C++ Style Guid

Re: Review Request 44660: Used `KillPolicy` and shutdown grace period in docker executor.

> On March 15, 2016, 11:21 p.m., Ben Mahler wrote: > > src/docker/executor.cpp, lines 235-239 > > > > > > Ditto earlier comments. I would expect the buffer to be in addition to > > the reap interval. It also wasn't

<    1   2   3   4   >