Re: Review Request 47485: Added utility for parsing ld.so.cache on linux.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47485/ --- (Updated May 19, 2016, 5:38 a.m.) Review request for mesos and Benjamin

Re: Review Request 47400: Documentation quota authorization changes in 0.29.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47400/#review133881 --- Patch looks great! Reviews applied: [47400] Passed command:

Re: Review Request 47400: Documentation quota authorization changes in 0.29.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47400/ --- (Updated May 19, 2016, 4:34 a.m.) Review request for mesos, Adam B and

Re: Review Request 47400: Documentation quota authorization changes in 0.29.

> On May 19, 2016, 3:25 a.m., Guangya Liu wrote: > > CHANGELOG, line 59 > > > > > > s/set_quotas/`set_quotas` > > s/remove_quotas/`remove_quotas` > > > > s/in/in favor > > > > Do we need to

Review Request 47577: Agent: Added minor changes to various .cpp files to support Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47577/ --- Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van

Re: Review Request 47484: Added -lelf to default dynamic libraries on Linux.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47484/#review133870 --- Ship it! configure.ac (line 580)

Re: Review Request 47483: Added -lelf to default dynamic libraries for libprocess on Linux.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47483/#review133869 --- Ship it! 3rdparty/libprocess/configure.ac (line 342)

Re: Review Request 47482: Added preliminary support for parsing ELF files in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47482/#review133838 --- Fix it, then Ship it! 3rdparty/stout/configure.ac (line 154)

Re: Review Request 45474: MESOS-1739: Allow slave reconfiguration on restart, Phase 1.

> On March 31, 2016, 2:03 a.m., Jie Yu wrote: > > This is a high level question: I am now sure if adding attributes is safe > > or not. For instance, my framework has the following rule: only schedule > > tasks to agents that do not have attribute "not_safe". Now, say agent A is > > initially

Re: Review Request 47400: Documentation quota authorization changes in 0.29.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47400/#review133865 --- CHANGELOG (line 59)

Re: Review Request 47576: Agent: Add Windows support to the containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47576/#review133866 --- Bad patch! Reviews applied: [47576, 47536, 47472, 47471, 47470,

Re: Review Request 47536: Agent: Added Windows isolators.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47536/ --- (Updated May 19, 2016, 2:50 a.m.) Review request for mesos, Daniel Pravat,

Review Request 47576: Agent: Add Windows support to the containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47576/ --- Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van

Re: Review Request 47511: Added documentation for `docker/volume` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47511/#review133859 --- Bad patch! Reviews applied: [47511] Failed command:

Re: Review Request 46369: Added capabilities support in ContanerInfo protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46369/#review133858 --- Fix it, then Ship it! include/mesos/mesos.proto (line 1734)

Re: Review Request 47511: Added documentation for `docker/volume` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47511/ --- (Updated May 19, 2016, 1:38 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 47511: Added documentation for `docker/volume` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47511/ --- (Updated May 19, 2016, 1:37 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 47481: Rewrote os::read() to be friendlier to reading binary data.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47481/#review133834 --- Ship it! 3rdparty/stout/include/stout/os/read.hpp (line 108)

Re: Review Request 46613: Introduced filtering relevant actions and acls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46613/ --- (Updated May 18, 2016, 10:16 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 47530: Added authorization to agent's '/containers' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47530/#review133820 --- Patch looks great! Reviews applied: [47530] Passed command:

Re: Review Request 47400: Documentation quota authorization changes in 0.29.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47400/#review133802 --- Patch looks great! Reviews applied: [47400] Passed command:

Re: Review Request 47485: Added utility for parsing ld.so.cache on linux.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47485/ --- (Updated May 18, 2016, 8:21 p.m.) Review request for mesos and Benjamin

Re: Review Request 47530: Added authorization to agent's '/containers' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47530/ --- (Updated May 18, 2016, 8 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 47530: Added authorization to agent's '/containers' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47530/ --- (Updated May 18, 2016, 7:59 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 47482: Added preliminary support for parsing ELF files in stout.

> On May 18, 2016, 5:35 p.m., Jojy Varghese wrote: > > 3rdparty/stout/include/stout/elf.hpp, line 56 > > > > > > Wondering why the implementation is in the header file. For better or worse, stout is a header-only

Re: Review Request 47530: Added authorization to agent's '/containers' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47530/#review133797 --- Patch looks great! Reviews applied: [47530] Passed command:

Re: Review Request 45474: MESOS-1739: Allow slave reconfiguration on restart, Phase 1.

> On March 30, 2016, 2:08 a.m., Adam B wrote: > > src/tests/slave_tests.cpp, lines 3541-3545 > > > > > > Here you shutdown the slave and wait (you'll probably want to advance > > the clock rather than wait for

Re: Review Request 47463: Added documentation for `network/cni` isolator.

> On May 18, 2016, 6:39 p.m., Vinod Kone wrote: > > docs/cni.md, line 5 > > > > > > Should we make it explicit that this is not supported for > > DockerContainerizer? I don't think we should be explicit about the

Re: Review Request 47364: Set env variable used to toggle executor implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47364/ --- (Updated May 18, 2016, 6:55 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 47463: Added documentation for `network/cni` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47463/#review133782 --- Fix it, then Ship it! LGTM. I'm assuming Jie already verified

Re: Review Request 47510: Adjusted style to make website mobile friendly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47510/#review133788 --- Ship it! Ship It! - Vinod Kone On May 18, 2016, 6:04 p.m.,

Re: Review Request 47510: Adjusted style to make website mobile friendly.

> On May 18, 2016, 6:05 p.m., Vinod Kone wrote: > > site/source/layouts/layout.erb, lines 66-83 > > > > > > what does this do? > > > > also, can you attach before and after screen shots? > > Tim Anderegg

Re: Review Request 47510: Adjusted style to make website mobile friendly.

> On May 18, 2016, 6:05 p.m., Vinod Kone wrote: > > site/source/layouts/layout.erb, lines 66-83 > > > > > > what does this do? > > > > also, can you attach before and after screen shots? @vinodkone That

Re: Review Request 47510: Adjusted style to make website mobile friendly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47510/ --- (Updated May 18, 2016, 6:04 p.m.) Review request for mesos, Freddy

Re: Review Request 47510: Adjusted style to make website mobile friendly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47510/#review133774 --- site/source/layouts/layout.erb (lines 65 - 82)

Re: Review Request 46761: Slave/Agent Rename Phase I - Update terms in WebUI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46761/#review133778 --- Ship it! Ship It! - Vinod Kone On May 18, 2016, 2:16 a.m.,

Re: Review Request 47536: Agent: Added Windows isolators.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47536/#review133775 --- Bad patch! Reviews applied: [47536, 47472, 47471, 47470, 47469,

Re: Review Request 47482: Added preliminary support for parsing ELF files in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47482/#review133770 --- 3rdparty/stout/include/stout/elf.hpp (line 56)

Re: Review Request 47511: Added documentation for `docker/volume` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47511/#review133771 --- Bad patch! Reviews applied: [47511] Failed command:

Re: Review Request 47509: Fixed authorization::Request initializings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47509/#review133766 --- Bad patch! Reviews applied: [47509] Failed command:

Re: Review Request 47400: Documentation quota authorization changes in 0.29.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47400/ --- (Updated May 18, 2016, 4:53 p.m.) Review request for mesos, Adam B and

Re: Review Request 47516: Added creator principal to tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47516/#review133762 --- Patch looks great! Reviews applied: [47515, 47528, 47519, 47520,

Re: Review Request 47399: New update_quotas ACL for both set and remove cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47399/#review133623 --- Fix it, then Ship it! I'll fix the last issues and commit

Re: Review Request 47518: Added test case for no volume and no checkpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47518/#review133753 --- Patch looks great! Reviews applied: [46428, 36383, 47518]

Re: Review Request 47515: Enforced a constraint on `DiskInfo.Persistence.principal`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47515/#review133744 --- src/master/master.cpp (line 3750)

Re: Review Request 46373: Request /files/read.json with a negative length value causes error.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46373/#review133742 --- Patch looks great! Reviews applied: [46373] Passed command:

Re: Review Request 47530: Added authorization to agent's '/containers' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47530/#review133734 --- src/slave/http.cpp (line 788)

Re: Review Request 47530: Added authorization to agent's '/containers' endpoint.

> On May 18, 2016, 12:55 p.m., Jan Schlicht wrote: > > src/slave/http.cpp, line 787 > > > > > > Please call `authorizeEndpoint` as soon as possible, i.e. after the > > endpoint has been extracted from the URL. > >

Review Request 47536: Agent: Added Windows isolators.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47536/ --- Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van

Re: Review Request 47532: Updated release guide to recommend regenerating endpoint help.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47532/#review133732 --- Ship it! Ship It! - Alexander Rukletsov On May 18, 2016,

Re: Review Request 47499: Make Mesos site responsive.

> On May 18, 2016, 3 a.m., haosdent huang wrote: > > Hi, @janisz May you merge changes from > > https://reviews.apache.org/r/47510/diff/1#index_header . It looks better > > according my test. I checked 47510 and indeed it looks better than this. I'll close this PR, in favour of 47510 -

Re: Review Request 47491: Added `environment` field to `Task` protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47491/ --- (Updated May 18, 2016, 1:18 p.m.) Review request for mesos and Michael Park.

Re: Review Request 47510: Adjusted style to make website mobile friendly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47510/#review133729 --- Ship it! Ship It! - Tomasz Janiszewski On May 18, 2016,

Review Request 47532: Updated release guide to recommend regenerating endpoint help.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47532/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos

Re: Review Request 47530: Added authorization to agent's '/containers' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47530/ --- (Updated May 18, 2016, 12:59 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 47530: Added authorization to agent's '/containers' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47530/#review133719 --- src/slave/http.cpp (line 756)

Re: Review Request 47499: Make Mesos site responsive.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47499/#review133723 --- Patch looks great! Reviews applied: [47499] Passed command:

Re: Review Request 47400: Documentation quota authorization changes in 0.29.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47400/#review133720 --- I've committed https://reviews.apache.org/r/46501/ , could you

Re: Review Request 46501: Updated authorization.md to reflect current changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46501/#review133711 --- Fix it, then Ship it! I've wrapped the text and did a final

Review Request 47530: Added authorization to agent's '/containers' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47530/ --- Review request for mesos, Adam B, Alexander Rukletsov, Greg Mann, Jan Schlicht,

Review Request 47511: Added documentation for `docker/volume` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47511/ --- Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-5216

Re: Review Request 47505: Updated authorizer.proto Subject, Object and Request.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47505/#review133718 --- Also you would need to update "authorization.md". However, it

Re: Review Request 47510: Adjusted style to make website mobile friendly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47510/#review133716 --- Patch looks great! Reviews applied: [47510] Passed command:

Re: Review Request 47505: Updated authorizer.proto Subject, Object and Request.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47505/#review133707 --- Additionally, you should also update the local authorizer

Re: Review Request 46761: Slave/Agent Rename Phase I - Update terms in WebUI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46761/#review133708 --- Patch looks great! Reviews applied: [46761] Passed command:

Review Request 47516: Added creator principal to tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47516/ --- Review request for mesos, Bernd Mathiske, Joerg Schad, and Neil Conway. Bugs:

Re: Review Request 47509: Fixed authorization::Request initializings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47509/#review133706 --- As per comment on MESOS-5405, I'd rather go the other path,

Review Request 47522: Added creator principal to persistent volume tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47522/ --- Review request for mesos, Bernd Mathiske, Joerg Schad, and Neil Conway. Bugs:

Review Request 47521: Added creator principal to '/create-volumes' tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47521/ --- Review request for mesos, Bernd Mathiske, Joerg Schad, and Neil Conway. Bugs:

Review Request 47520: Updated test helpers with creator principal.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47520/ --- Review request for mesos, Bernd Mathiske, Joerg Schad, and Neil Conway. Bugs:

Review Request 47519: Updated an example framework to specify its principal.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47519/ --- Review request for mesos, Bernd Mathiske, Joerg Schad, and Neil Conway. Bugs:

Review Request 47528: Updated validation tests with creator principal.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47528/ --- Review request for mesos, Bernd Mathiske, Joerg Schad, and Neil Conway. Bugs:

Review Request 47515: Enforced a constraint on `DiskInfo.Persistence.principal`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47515/ --- Review request for mesos, Bernd Mathiske, Joerg Schad, and Neil Conway. Bugs:

Re: Review Request 45474: MESOS-1739: Allow slave reconfiguration on restart, Phase 1.

> On 三月 30, 2016, 9:08 a.m., Adam B wrote: > > src/tests/slave_tests.cpp, lines 3541-3545 > > > > > > Here you shutdown the slave and wait (you'll probably want to advance > > the clock rather than wait for 90s)

Re: Review Request 47505: Updated authorizer.proto Subject, Object and Request.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47505/#review133704 --- Patch looks great! Reviews applied: [47505] Passed command: