Re: Review Request 52070: Mentioned `reserved_resources_full` info on the agent in relevant docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52070/#review149613 --- Patch looks great! Reviews applied: [52070] Passed command:

Re: Review Request 52059: Added test for running the logrotate module as non-root.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52059/#review149612 --- I just had a chance to look at the fixture.

Re: Review Request 52001: Allow text based disk resources to indicate source type and root.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52001/#review149611 --- src/common/resources.cpp (line 613)

Re: Review Request 46187: Terminate when receiving the ACK of terminal status update.

> On Sept. 6, 2016, 7:33 p.m., Vinod Kone wrote: > > > > Vinod Kone wrote: > also, can you add a test for this? > > Qian Zhang wrote: > Sure, I can add a test. I am just wondering how to use a test to verify > the logic we added in this patch, maybe we can just add a test to launch a

Re: Review Request 51631: Tracked recovered and prepared cgroups subsystems for containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51631/#review149609 --- Fix it, then Ship it!

Re: Review Request 51631: Tracked recovered and prepared cgroups subsystems for containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51631/ --- (Updated Sept. 20, 2016, 4:13 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 52065: Fixed warnings in Windows `shell.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52065/#review149606 --- Patch looks great! Reviews applied: [52061, 52062, 52063, 52065]

Re: Review Request 51999: Refactor parsing of resources to include all valid resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51999/#review149603 --- Ditto for v1 include/mesos/resources.hpp (lines 187 - 188)

Review Request 52075: Added the test `HTTPCommandExecutorTest.TerminateWithACK`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52075/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Bugs: MESOS-5276

Re: Review Request 51865: Added validation for `ContainerInfo`.

> On Sept. 19, 2016, 5:24 p.m., Jan Schlicht wrote: > > src/master/validation.cpp, lines 63-78 > > > > > > This will cause problems with tasks that don't use a container image: > > While `ContainerInfo.type` is

Re: Review Request 51999: Refactor parsing of resources to include all valid resources.

> On 九月 19, 2016, 6 a.m., Guangya Liu wrote: > > src/slave/containerizer/containerizer.cpp, lines 64-71 > > > > > > A question here: Does the `resources` here will include the zero value > > resource? > > > >

Re: Review Request 50271: Created an isolator for Linux capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50271/#review149587 --- Haven't looked at the tests yet. src/Makefile.am (line 833)

Re: Review Request 52059: Added test for running the logrotate module as non-root.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52059/#review149598 --- Patch looks great! Reviews applied: [52059] Passed command:

Re: Review Request 52001: Allow text based disk resources to indicate source type and root.

> On Sept. 19, 2016, 4:55 p.m., haosdent huang wrote: > > src/common/resources.cpp, lines 616-648 > > > > > > This is conflict with range resources `ports:[21000-24000,3-34000]`. > > Anindya Sinha wrote: >

Re: Review Request 52033: Escalated some openssl logs from VLOG to INFO.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52033/#review149594 --- 3rdparty/libprocess/src/openssl.cpp (line 289)

Re: Review Request 52031: Added openssl error string output to initializing failures.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52031/#review149593 --- Agree with @Joseph's comments about keeping the error codes.

Review Request 52056: Exposed unknown container case from Containerizer::destroy.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52056/ --- Review request for mesos, Jie Yu and Vinod Kone. Repository: mesos

Re: Review Request 52031: Added openssl error string output to initializing failures.

> On Sept. 19, 2016, 7:02 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/src/openssl.cpp, lines 509-510 > > > > > > I'd prefer the parentheses containing the `stringify(error)` to mention > > OpenSSL, since the

Re: Review Request 51857: Modified the `prepare` method to be aware of nested containers.

> On Sept. 19, 2016, 11:43 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, lines 666-668 > > > > > > Do we need a new mount namespace if i just want execute some command on > >

Re: Review Request 40411: Libprocess Reinit: Modify test to use PID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40411/ --- (Updated Sept. 19, 2016, 5:41 p.m.) Review request for mesos, Greg Mann, Artem

Review Request 52055: Exposed unknown container case from Containerizer::wait.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52055/ --- Review request for mesos, Jie Yu and Vinod Kone. Repository: mesos

Re: Review Request 51931: Added `ping` to test linux rootfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51931/#review149586 --- Ship it! Ship It! - Jie Yu On Sept. 19, 2016, 2:19 p.m.,

Re: Review Request 51930: Introduced Linux capabilities support for Mesos executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51930/#review149583 --- src/launcher/executor.cpp (line 817)

Re: Review Request 51930: Introduced Linux capabilities support for Mesos executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51930/#review149585 --- Ship it! Ship It! - Jie Yu On Sept. 19, 2016, 2:19 p.m.,

Re: Review Request 40266: Libprocess Reinit: Cleanup SocketManager alongside ProcessManager.

> On Aug. 13, 2016, 9:13 p.m., Vinod Kone wrote: > > 3rdparty/libprocess/src/process.cpp, line 413 > > > > > > `all` is a bit misleading since "gc" is not being terminated. can you > > just call it "terminate"? i

Re: Review Request 40266: Libprocess Reinit: Cleanup SocketManager alongside ProcessManager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40266/ --- (Updated Sept. 19, 2016, 5:26 p.m.) Review request for mesos, Greg Mann, Artem

Re: Review Request 51857: Modified the `prepare` method to be aware of nested containers.

> On Sept. 19, 2016, 11:43 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, lines 666-668 > > > > > > Do we need a new mount namespace if i just want execute some command on > >

Re: Review Request 52069: Moved `CHECK_NE` close to the `if (task.isSome())`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52069/#review149576 --- Ship it! Ship It! - Vinod Kone On Sept. 19, 2016, 11:14

Re: Review Request 51871: Modified the `isolate` method to be nesting aware.

> On Sept. 19, 2016, 11:55 p.m., Jie Yu wrote: > > Let's merge the patches into one single patch. These patches are highly > > related. It's nice to review them in a single diff. Will do. > On Sept. 19, 2016, 11:55 p.m., Jie Yu wrote: > >

Re: Review Request 51857: Modified the `prepare` method to be aware of nested containers.

> On Sept. 19, 2016, 11:54 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, lines 600-604 > > > > > > I was under the impressesion child container's always need to have

Re: Review Request 51857: Modified the `prepare` method to be aware of nested containers.

> On Sept. 19, 2016, 11:54 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, lines 600-604 > > > > > > I was under the impressesion child container's always need to have

Re: Review Request 51857: Modified the `prepare` method to be aware of nested containers.

> On Sept. 19, 2016, 11:43 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, line 607 > > > > > > Why we need to do that? If we copy containerNetworks, that means > > 'isolate'

Re: Review Request 51871: Modified the `isolate` method to be nesting aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51871/#review149569 --- Let's merge the patches into one single patch. These patches are

Re: Review Request 52058: Fixed fetcher to not call chown on sandbox again.

> On Sept. 19, 2016, 8:35 p.m., Joseph Wu wrote: > > src/slave/containerizer/fetcher.cpp, lines 773-775 > > > > > > (You'll want to update this comment.) > > > > There isn't always a stdout/stderr file in

Re: Review Request 52054: Updated slave test to expect 500 rather than 503 from libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52054/#review149570 --- Patch looks great! Reviews applied: [52053, 52054] Passed

Re: Review Request 52058: Fixed fetcher to not call chown on sandbox again.

> On Sept. 19, 2016, 1:35 p.m., Joseph Wu wrote: > > src/slave/containerizer/fetcher.cpp, lines 773-775 > > > > > > (You'll want to update this comment.) > > > > There isn't always a stdout/stderr file in

Re: Review Request 51869: Export "reserved_resources" in the agent HTTP endpoint.

> On Sept. 18, 2016, 6:51 a.m., haosdent huang wrote: > > It would be better that we add this in the new operator api as well. Should > > I create a ticket at https://issues.apache.org/jira/browse/MESOS-6007 ? > > Jiang Yan Xu wrote: > We should (my comment above). I'll take care of it.

Re: Review Request 52069: Moved `CHECK_NE` close to the `if (task.isSome())`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52069/ --- (Updated 九月 19, 2016, 11:14 p.m.) Review request for mesos, Abhishek Dasgupta

Re: Review Request 52058: Fixed fetcher to not call chown on sandbox again.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52058/ --- (Updated Sept. 19, 2016, 11:08 p.m.) Review request for mesos and Jiang Yan

Re: Review Request 52058: Fixed fetcher to not call chown on sandbox again.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52058/ --- (Updated Sept. 19, 2016, 11:04 p.m.) Review request for mesos and Jiang Yan

Re: Review Request 52069: Moved `CHECK_NE` out of the offers loop.

> On Sept. 19, 2016, 10:40 p.m., Vinod Kone wrote: > > src/cli/execute.cpp, line 384 > > > > > > While it's true that this can only be done once, I would vote to keep > > it close to the `if (task.isSome())` loop

Re: Review Request 52069: Moved `CHECK_NE` out of the offers loop.

> On 九月 19, 2016, 10:40 p.m., Vinod Kone wrote: > > src/cli/execute.cpp, line 384 > > > > > > While it's true that this can only be done once, I would vote to keep > > it close to the `if (task.isSome())` loop

Review Request 52071: Updated docs to reflect handling of disk resource with size of 0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52071/ --- Review request for mesos and Jiang Yan Xu. Bugs: MESOS-6062

Re: Review Request 51879: Determine disk size when not specified in static resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51879/ --- (Updated Sept. 19, 2016, 10:43 p.m.) Review request for mesos and Jiang Yan

Re: Review Request 51880: Added unit tests to determine disk size for MOUNT disks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51880/ --- (Updated Sept. 19, 2016, 10:43 p.m.) Review request for mesos and Jiang Yan

Re: Review Request 51879: Determine disk size when not specified in static resources.

> On Sept. 18, 2016, 6:22 p.m., haosdent huang wrote: > > src/slave/containerizer/containerizer.cpp, lines 198-259 > > > > > > I suggest that we move the logic which parse `disk(0)` to resources.cpp > > or

Re: Review Request 52002: Added helper methods to determine types of disk resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52002/ --- (Updated Sept. 19, 2016, 10:43 p.m.) Review request for mesos and Jiang Yan

Re: Review Request 52001: Allow text based disk resources to indicate source type and root.

> On Sept. 19, 2016, 4:55 p.m., haosdent huang wrote: > > src/common/resources.cpp, lines 616-648 > > > > > > This is conflict with range resources `ports:[21000-24000,3-34000]`. I do not think so.

Re: Review Request 52001: Allow text based disk resources to indicate source type and root.

> On Sept. 19, 2016, 6:40 a.m., Guangya Liu wrote: > > src/common/resources.cpp, line 611 > > > > > > A unit test is needed to test the case when token size is 3 Tests for various cases of token sizes (2 and 3) are

Re: Review Request 51999: Refactor parsing of resources to include all valid resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51999/ --- (Updated Sept. 19, 2016, 10:42 p.m.) Review request for mesos and Jiang Yan

Re: Review Request 51999: Refactor parsing of resources to include all valid resources.

> On Sept. 19, 2016, 6 a.m., Guangya Liu wrote: > > src/slave/containerizer/containerizer.cpp, lines 64-71 > > > > > > A question here: Does the `resources` here will include the zero value > > resource? > > >

Re: Review Request 52001: Allow text based disk resources to indicate source type and root.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52001/ --- (Updated Sept. 19, 2016, 10:43 p.m.) Review request for mesos and Jiang Yan

Re: Review Request 52069: Moved `CHECK_NE` out of the offers loop.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52069/#review149558 --- src/cli/execute.cpp (line 384)

Review Request 52069: Moved `CHECK_NE` out of the offers loop.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52069/ --- Review request for mesos, Abhishek Dasgupta and Vinod Kone. Repository: mesos

Review Request 52070: Mentioned `reserved_resources_full` info on the agent in relevant docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52070/ --- Review request for mesos, (Disabled_DoNotUse) Anindya Sinha and haosdent huang.

Re: Review Request 52042: Changed error message in pailer if user is unauthorized.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52042/#review149556 --- Bad patch! Reviews applied: [52042] Failed command:

Re: Review Request 52063: Fixed warnings in Windows `os.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52063/#review149554 --- Ship it! Ship It! - Joseph Wu On Sept. 19, 2016, 1:05 p.m.,

Re: Review Request 52062: Fixed warnings in `numify.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52062/#review149549 --- 3rdparty/stout/include/stout/numify.hpp (lines 29 - 32)

Re: Review Request 52061: Fixed warnings in `duration.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52061/#review149548 --- Fix it, then Ship it! I'll tweak the spacing before

Re: Review Request 51870: Added a test for reservation info in the agent's endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51870/#review149546 --- Ship it! Ship It! - Anindya Sinha On Sept. 19, 2016, 8:48

Re: Review Request 52048: Fixed OsTest.User test failure due to gids ordering.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52048/#review149544 --- Patch looks great! Reviews applied: [52048] Passed command:

Re: Review Request 51984: Cleaned up initialization of atomic fields in ProcessManager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51984/#review149543 --- Ship it! Ship It! - Joseph Wu On Sept. 17, 2016, 8:25 a.m.,

Re: Review Request 51958: Removed use of "--registry_strict" master flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51958/#review149542 --- Ship it! Ship It! - Vinod Kone On Sept. 17, 2016, 2:23

Re: Review Request 51870: Added a test for reservation info in the agent's endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51870/ --- (Updated Sept. 19, 2016, 1:48 p.m.) Review request for mesos, Anindya Sinha

Re: Review Request 52064: Support for multiple versions of docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52064/ --- (Updated Sept. 19, 2016, 8:43 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 51921: Added backports for a potential double-close in libevent sockets.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51921/ --- (Updated Sept. 19, 2016, 1:40 p.m.) Review request for mesos, Benjamin

Re: Review Request 50857: Modified a scheduler test to run with SSL enabled.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50857/ --- (Updated Sept. 19, 2016, 8:23 p.m.) Review request for mesos, Joseph Wu and

Review Request 52064: Support for multiple versions of docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52064/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-3011

Review Request 52062: Fixed warnings in `numify.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52062/ --- Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joseph

Review Request 52063: Fixed warnings in Windows `os.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52063/ --- Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joseph

Review Request 52065: Fixed warnings in Windows `shell.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52065/ --- Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joseph

Review Request 52061: Fixed warnings in `duration.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52061/ --- Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joseph

Re: Review Request 51623: Updated mesos-execute to support task groups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51623/ --- (Updated Sept. 19, 2016, 7:45 p.m.) Review request for mesos, Anand Mazumdar

Review Request 52059: Added test for running the logrotate module as non-root.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52059/ --- Review request for mesos, Artem Harutyunyan and Sivaram Kannan. Bugs:

Re: Review Request 52039: Avoided using SIGUSR1 in two test cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52039/#review149538 --- Patch looks great! Reviews applied: [50235, 50416, 50417, 50418,

Re: Review Request 51921: Added backports for a potential double-close in libevent sockets.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51921/#review149537 --- Ship it! Ship It! - Vinod Kone On Sept. 15, 2016, 5:26

Re: Review Request 52031: Added openssl error string output to initializing failures.

> On Sept. 19, 2016, 12:02 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/src/openssl.cpp, lines 509-510 > > > > > > I'd prefer the parentheses containing the `stringify(error)` to mention > > OpenSSL, since the

Re: Review Request 51921: Added backports for a potential double-close in libevent sockets.

> On Sept. 15, 2016, 5:56 p.m., Joris Van Remoortere wrote: > > Did you want to fold the minor fix into your original patch to backport? > > Joseph Wu wrote: > Do you mean MESOS-6152? (i.e. `s/fd/owned_fd`) > > I kept the cherry-picks un-squashed to retain history. > > Joris Van

Re: Review Request 51985: Waited for agent finish registering in test case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51985/#review149534 --- src/tests/slave_recovery_tests.cpp (lines 4073 - 4081)

Review Request 52058: Fixed fetcher to not call chown on sandbox again.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52058/ --- Review request for mesos. Bugs: MESOS-5218

Re: Review Request 52054: Updated slave test to expect 500 rather than 503 from libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52054/#review149533 --- Fix it, then Ship it! src/tests/slave_tests.cpp (line 1919)

Re: Review Request 52053: Return 500 rather than 503 when response handlers fail.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52053/#review149532 --- Ship it! Ship It! - Vinod Kone On Sept. 19, 2016, 7:15

Re: Review Request 51623: Updated mesos-execute to support task groups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51623/#review149531 --- Ship it! LGTM module "taskGroup" flag name to "task_group" per

Review Request 52054: Updated slave test to expect 500 rather than 503 from libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52054/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Review Request 52053: Return 500 rather than 503 when response handlers fail.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52053/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 52031: Added openssl error string output to initializing failures.

> On Sept. 19, 2016, 7:02 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/src/openssl.cpp, lines 509-510 > > > > > > I'd prefer the parentheses containing the `stringify(error)` to mention > > OpenSSL, since the

Re: Review Request 51865: Added validation for `ContainerInfo`.

> On Sept. 19, 2016, 9:24 a.m., Jan Schlicht wrote: > > src/master/validation.cpp, lines 63-78 > > > > > > This will cause problems with tasks that don't use a container image: > > While `ContainerInfo.type` is

Re: Review Request 52033: Escalated some openssl logs from VLOG to INFO.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52033/#review149525 --- Ship it! This isn't noisy since it only happens once. Might

Re: Review Request 51990: Added << operator to stringify v1::TaskGroupInfo protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51990/#review149524 --- Ship it! Ship It! - Vinod Kone On Sept. 18, 2016, 9:08

Re: Review Request 51978: Refactored commandScheduler in cli/execute.cpp to take TaskInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51978/#review149523 --- Ship it! Ship It! - Vinod Kone On Sept. 19, 2016, 6:15

Re: Review Request 52031: Added openssl error string output to initializing failures.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52031/#review149514 --- Fix it, then Ship it! 3rdparty/libprocess/src/openssl.cpp

Re: Review Request 51804: Fixed typos in subprocess_base.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51804/#review149518 --- Ship it! Ship It! - Alexander Rukletsov On Sept. 19, 2016,

Re: Review Request 51786: Fixed Typo in subprocess.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51786/#review149519 --- Ship it! Ship It! - Alexander Rukletsov On Sept. 11, 2016,

Re: Review Request 51065: Changed hostname used for SSL cert creation in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51065/ --- (Updated Sept. 19, 2016, 6:47 p.m.) Review request for mesos, Joseph Wu and

Re: Review Request 51804: Fixed typos in subprocess_base.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51804/ --- (Updated Sept. 19, 2016, 6:48 p.m.) Review request for mesos and Alexander

Re: Review Request 51865: Added validation for `ContainerInfo`.

> On Sept. 19, 2016, 9:24 a.m., Jan Schlicht wrote: > > src/master/validation.cpp, lines 63-78 > > > > > > This will cause problems with tasks that don't use a container image: > > While `ContainerInfo.type` is

Re: Review Request 52048: Fixed OsTest.User test failure due to gids ordering.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52048/ --- (Updated Sept. 19, 2016, 6:42 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 52048: Fixed OsTest.User test failure due to gids ordering.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52048/ --- (Updated Sept. 19, 2016, 6:41 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 52020: Fixed indent in allocator.

> On Sept. 19, 2016, 6:20 a.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1653 > > > > > > This looks fine: 4 spaces after '('. > > Guangya Liu wrote: > Does the indent

Re: Review Request 50271: Created an isolator for Linux capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50271/#review149505 --- Patch looks great! Reviews applied: [51784, 51930, 51931, 50271]

  1   2   >