Re: Review Request 54410: Made the style of the cluster name consistent with others.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54410/ --- (Updated Dec. 13, 2016, 7:58 a.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 54410: Made the style of the cluster name consistent with others.

> On Dec. 9, 2016, 7:51 p.m., Benjamin Mahler wrote: > > If it looks the same as the other navbar tabs, it seems clickable? At least > > when it is greyed out I wouldn't think I can click it. Got it, use `btn disabled` to make it grey now. - haosdent

Re: Review Request 54410: Made the style of the cluster name consistent with others.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54410/ --- (Updated Dec. 13, 2016, 7:51 a.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 54693: Add ProtoBuf schema for Blkio cgroup subsystem

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54693/#review158963 --- include/mesos/mesos.proto (line 1106)

Re: Review Request 54664: Acked correct task id in DefaultExecutorTest.KillTaskGroupOnTaskFailure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54664/#review158961 --- Patch looks great! Reviews applied: [54663, 54664] Passed

Review Request 54693: Add ProtoBuf schema for Blkio cgroup subsystem

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54693/ --- Review request for mesos, Xiaojian Huang, Gilbert Song, haosdent huang, Jie Yu,

Re: Review Request 54678: Added John Kordich to contributors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54678/#review158960 --- Patch looks great! Reviews applied: [54678] Passed command:

Re: Review Request 54650: Added validation for roles in ACCEPT call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54650/ --- (Updated Dec. 13, 2016, 12:41 p.m.) Review request for mesos, Benjamin

Re: Review Request 54650: Added validation for roles in ACCEPT call.

> On Dec. 12, 2016, 9:41 p.m., Qian Zhang wrote: > > src/master/validation.cpp, line 1337 > > > > > > I would suggest to change to: > > ``` > > return Error("Offer " + stringify(offerId) + " is no longer

Re: Review Request 54589: Improved operator HTTP API docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54589/ --- (Updated Dec. 13, 2016, 3:02 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 54650: Added validation for roles in ACCEPT call.

> On Dec. 13, 2016, 8:40 a.m., Benjamin Mahler wrote: > > src/master/validation.cpp, line 1425 > > > > > > This return here looks incorrect? Maybe copy over a similar comment > > from validateSlave: > > > >

Re: Review Request 54650: Added validation for roles in ACCEPT call.

> On Dec. 12, 2016, 9:41 p.m., Qian Zhang wrote: > > src/master/validation.cpp, line 1337 > > > > > > I would suggest to change to: > > ``` > > return Error("Offer " + stringify(offerId) + " is no longer

Re: Review Request 52064: Support for multiple versions of docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52064/#review158952 --- Patch looks great! Reviews applied: [52064] Passed command:

Re: Review Request 50415: Added build step to build Java Protobuf.

> On Dec. 8, 2016, 8:59 p.m., Alex Clemmer wrote: > > 3rdparty/CMakeLists.txt, line 347 > > > > > > If I'm understanding this correctly, this will download a fresh copy of > > the protobuf tarball, and then build

Re: Review Request 54081: Added `--pidfile` option to master and agent binaries.

> On Dec. 6, 2016, 10:42 p.m., Benjamin Mahler wrote: > > Thanks Ilya! > > > > Have you looked at other pidfile related libraries? Looks like BSD provides > > some functions for this (they're also available on Linux): > > https://www.freebsd.org/cgi/man.cgi?query=pidfile=3=FreeBSD+6.1-RELEASE

Re: Review Request 54687: Moved `IOSwitchboard::requiresServer()` implementation to cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54687/#review158945 --- Ship it! Ship It! - Kevin Klues On Dec. 13, 2016, 1:10

Review Request 54687: Moved `IOSwitchboard::requiresServer()` implementation to cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54687/ --- Review request for mesos and Kevin Klues. Repository: mesos Description

Re: Review Request 54686: Moved the `IOSwitchboardServer::isRequired` to `IOSwitchBoard`.

> On Dec. 13, 2016, 12:54 a.m., Kevin Klues wrote: > > src/slave/containerizer/mesos/io/switchboard.hpp, lines 81-99 > > > > > > Is there a reason not to put the implementation of this in the .cpp > > file? Seems

Re: Review Request 54686: Moved the `IOSwitchboardServer::isRequired` to `IOSwitchBoard`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54686/#review158941 --- Fix it, then Ship it!

Review Request 54686: Moved the `IOSwitchboardServer::isRequired` to `IOSwitchBoard`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54686/ --- Review request for mesos, Alex Clemmer and Kevin Klues. Repository: mesos

Re: Review Request 53344: Updated `/slaves.md` doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53344/#review158940 --- Did you manually edit this file or reran the

Re: Review Request 50415: Added build step to build Java Protobuf.

> On Dec. 8, 2016, 8:59 p.m., Alex Clemmer wrote: > > 3rdparty/CMakeLists.txt, line 347 > > > > > > If I'm understanding this correctly, this will download a fresh copy of > > the protobuf tarball, and then build

Re: Review Request 52639: Added test for `recovered` AgentID and `AGENT_ADDED` after reregister.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52639/#review158935 --- Did an initial pass on the test. Refer to my comments around

Re: Review Request 54650: Added validation for roles in ACCEPT call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54650/#review158937 --- src/master/validation.cpp (lines 1329 - 1337)

Re: Review Request 54677: Windows: Enabled 495 passing tests on Agent builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54677/ --- (Updated Dec. 13, 2016, 12:35 a.m.) Review request for mesos, Andrew

Review Request 54685: Windows: Fix build break in libprocess tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54685/ --- Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, Greg Mann, John

Re: Review Request 54650: Added validation for roles in ACCEPT call.

> On Dec. 12, 2016, 1:41 p.m., Qian Zhang wrote: > > src/master/validation.cpp, line 1337 > > > > > > I would suggest to change to: > > ``` > > return Error("Offer " + stringify(offerId) + " is no longer

Re: Review Request 54449: Check quotas are enabled in the XFS disk isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54449/ --- (Updated Dec. 13, 2016, 12:15 a.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 54681: Made some IOSwitchboardServer flags optional.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54681/#review158934 --- Ship it! I'm fine with shipping this as is. It might be nice

Re: Review Request 54664: Acked correct task id in DefaultExecutorTest.KillTaskGroupOnTaskFailure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54664/#review158926 --- Fix it, then Ship it! Nice Catch! - Can you update the

Re: Review Request 54682: Fixed the tests by turning off agent subsystems in IOSwitchboard tests.

> On Dec. 13, 2016, 12:01 a.m., Kevin Klues wrote: > > Should we add TODOs above all of these so we know to fix it once we add a > > proper dependency check? Yup, will add a TODO in the agent code. - Jie --- This is an automatically

Re: Review Request 54681: Made some IOSwitchboardServer flags optional.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54681/ --- (Updated Dec. 13, 2016, 12:11 a.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 54683: Moved IOSwitchboardServerFlags nested inside IOSwitchboardServer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54683/#review158930 --- Ship it! Ship It! - Kevin Klues On Dec. 12, 2016, 11:43

Re: Review Request 54682: Fixed the tests by turning off agent subsystems in IOSwitchboard tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54682/#review158931 --- Ship it! Should we add TODOs above all of these so we know to

Re: Review Request 54681: Used None() for some IOSwitchboardServer flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54681/#review158927 --- I would reword the commit message to say: ``` Made some

Review Request 54683: Moved IOSwitchboardServerFlags nested inside IOSwitchboardServer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54683/ --- Review request for mesos, Benjamin Bannier and Kevin Klues. Repository: mesos

Re: Review Request 54681: Used None() for some IOSwitchboardServer flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54681/ --- (Updated Dec. 12, 2016, 11:43 p.m.) Review request for mesos, Benjamin Bannier

Review Request 54682: Fixed the tests by turning off agent subsystems in IOSwitchboard tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54682/ --- Review request for mesos and Kevin Klues. Repository: mesos Description

Review Request 54681: Used None() for some IOSwitchboardServer flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54681/ --- Review request for mesos, Benjamin Bannier and Kevin Klues. Repository: mesos

Re: Review Request 54613: Install a symlink rather than building mesos-slave twice.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54613/#review158920 --- Patch looks great! Reviews applied: [54613] Passed command:

Re: Review Request 54676: Fixed the environment overriding order in MesosContainerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54676/#review158911 --- Fix it, then Ship it! LGTM modulo earlier comments from

Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45962/ --- (Updated Dec. 12, 2016, 10:35 p.m.) Review request for mesos, Greg Mann, Jie

Re: Review Request 49571: Added a benchmark test for allocations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49571/ --- (Updated Dec. 12, 2016, 10:35 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 53096: Fix handling in shared count in total resources in the sorter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53096/ --- (Updated Dec. 12, 2016, 10:35 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 54678: Added John Kordich to contributors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54678/#review158912 --- Ship it! - Alex Clemmer On Dec. 12, 2016, 10:26 p.m., John

Review Request 54678: Added John Kordich to contributors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54678/ --- Review request for mesos and Alex Clemmer. Repository: mesos Description

Re: Review Request 54561: Added tests for IOSwitchboard heartbeat.

> On Dec. 12, 2016, 8:31 p.m., Vinod Kone wrote: > > Make sure to run AgentAPI tests as well, i.e., GTEST_FILTER="*AgentAPI*" I reran all tests (with a workaround patch for the domain socket bug mentioned in "Testing" above and everything passed). - Kevin

Re: Review Request 54589: Improved operator HTTP API docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54589/#review158909 --- Thanks for the cleanup. docs/endpoints/index.md (line 14)

Re: Review Request 52765: Populated `recovered_slaves` in `/state` and `/slaves` endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52765/#review158902 --- Sorry for the delay on this. As per our offline discussion, can

Review Request 54677: Windows: Enabled 495 passing tests on Agent builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54677/ --- Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.

Re: Review Request 54574: Updated test case for call based metrics for scheduler api.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54574/#review158908 --- Ship it! Ship It! - Zhitao Li On Dec. 9, 2016, 4:45 a.m.,

Re: Review Request 54573: Updated metrics counter during scheduler api calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54573/#review158907 --- Ship it! Ship It! - Zhitao Li On Dec. 9, 2016, 4:40 a.m.,

Re: Review Request 54676: Fixed the environment overriding order in MesosContainerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54676/#review158903 --- Fix it, then Ship it! Ship It!

Re: Review Request 52064: Support for multiple versions of docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52064/ --- (Updated Dec. 12, 2016, 10:03 p.m.) Review request for mesos, haosdent huang

Re: Review Request 52064: Support for multiple versions of docs.

> On Sept. 28, 2016, 3:55 a.m., haosdent huang wrote: > > site/source/layouts/basic.erb, line 79 > > > > > > We need to make sure the style of verson selection here to match the > > breadcrumb above. > > > >

Re: Review Request 54661: Enable authorization for the GET_FLAGS API Call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54661/#review158905 --- Patch looks great! Reviews applied: [54535, 54661] Passed

Review Request 54676: Fixed the environment overriding order in MesosContainerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54676/ --- Review request for mesos, Anand Mazumdar, Avinash sridharan, Gilbert Song, and

Re: Review Request 54572: Added metrics counter for scheduler calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54572/#review158694 --- src/master/metrics.cpp (lines 212 - 213)

Re: Review Request 54561: Added tests for IOSwitchboard heartbeat.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54561/#review158899 --- Ship it! Make sure to run AgentAPI tests as well, i.e.,

Re: Review Request 53299: Fixed memory leak in implementation of Future::after().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53299/#review158898 --- 3rdparty/libprocess/include/process/future.hpp (line 1307)

Re: Review Request 54561: Added tests for IOSwitchboard heartbeat.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54561/ --- (Updated Dec. 12, 2016, 8:21 p.m.) Review request for mesos, Jie Yu and Vinod

Re: Review Request 54630: Added a `http_heartbeat_interval` flag to the agent flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54630/ --- (Updated Dec. 12, 2016, 8:19 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 54650: Added validation for roles in ACCEPT call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54650/#review158897 --- Patch looks great! Reviews applied: [54649, 54650] Passed

Re: Review Request 54671: Changed the timing of entering mount namespace for DEBUG container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54671/#review158896 --- Ship it! Ship It! - Kevin Klues On Dec. 12, 2016, 7:21

Re: Review Request 54673: Fixed an unreachable statement in launch.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54673/#review158895 --- Ship it! Ship It! - Kevin Klues On Dec. 12, 2016, 7:30

Re: Review Request 54628: Changed 'Socket::create()' in IOSwitchboard to always be of 'kind' POLL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54628/ --- (Updated Dec. 12, 2016, 8:14 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 54673: Fixed an unreachable statement in launch.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54673/ --- (Updated Dec. 12, 2016, 7:30 p.m.) Review request for mesos and Kevin Klues.

Review Request 54673: Fixed an unreachable statement in launch.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54673/ --- Review request for mesos and Kevin Klues. Repository: mesos Description

Review Request 54672: Used exitWithStatus(EXIT_SUCCESS) at the end of launch.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54672/ --- Review request for mesos and Kevin Klues. Repository: mesos Description

Review Request 54671: Changed the timing of entering mount namespace for DEBUG container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54671/ --- Review request for mesos and Kevin Klues. Repository: mesos Description

Re: Review Request 54183: Improved management of unreachable and completed tasks in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54183/ --- (Updated Dec. 12, 2016, 7:06 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 54182: Improved various comments.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54182/ --- (Updated Dec. 12, 2016, 7:05 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 54179: Updated master to use BoundedHashMap.

> On Nov. 30, 2016, 3:18 p.m., Neil Conway wrote: > > src/master/master.hpp, line 2589 > > > > > > On reflection, this does change behavior slightly: previously, > > `completedTasks` could contain multiple

Re: Review Request 54179: Updated master to use BoundedHashMap.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54179/ --- (Updated Dec. 12, 2016, 7:03 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 54643: Added union assignment operator in hashset.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54643/#review158887 --- Ship it! Ship It! - Benjamin Mahler On Dec. 12, 2016, 3:13

Re: Review Request 54081: Added `--pidfile` option to master and agent binaries.

> On Dec. 6, 2016, 10:42 p.m., Benjamin Mahler wrote: > > Thanks Ilya! > > > > Have you looked at other pidfile related libraries? Looks like BSD provides > > some functions for this (they're also available on Linux): > > https://www.freebsd.org/cgi/man.cgi?query=pidfile=3=FreeBSD+6.1-RELEASE

Re: Review Request 54561: Added tests for IOSwitchboard heartbeat.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54561/ --- (Updated Dec. 12, 2016, 6:36 p.m.) Review request for mesos, Jie Yu and Vinod

Re: Review Request 54627: Updated address of 'http::connect()' with http scheme for SSL support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54627/ --- (Updated Dec. 12, 2016, 6:34 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 54628: Changed 'Socket::create()' in IOSwitchboard to always be of 'kind' POLL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54628/ --- (Updated Dec. 12, 2016, 6:34 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 52534: Dispatch filter expiration twice.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52534/#review158879 --- src/master/allocator/mesos/hierarchical.cpp (lines 1077 - 1078)

Re: Review Request 52534: Dispatch filter expiration twice.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52534/#review158858 --- Fix it, then Ship it! I feel it's hard to explain this patch

Re: Review Request 54538: Enabled fine grained authorization for the getContainers API Call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54538/#review158864 --- Patch looks great! Reviews applied: [54535, 54538] Passed

Review Request 54664: Acked correct task id in DefaultExecutorTest.KillTaskGroupOnTaskFailure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54664/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Bugs: MESOS-6744

Review Request 54663: Acked correct task id in DefaultExecutorTest.KillTask test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54663/ --- Review request for mesos and Anand Mazumdar. Bugs: MESOS-6745

Re: Review Request 54081: Added `--pidfile` option to master and agent binaries.

> On Dec. 6, 2016, 10:42 p.m., Benjamin Mahler wrote: > > Thanks Ilya! > > > > Have you looked at other pidfile related libraries? Looks like BSD provides > > some functions for this (they're also available on Linux): > > https://www.freebsd.org/cgi/man.cgi?query=pidfile=3=FreeBSD+6.1-RELEASE

Review Request 54662: Enabled authorization in SET_LOG_LEVEL API call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54662/ --- Review request for mesos and Adam B. Bugs: MESOS-6670

Review Request 54661: Enable authorization for the GET_FLAGS API Call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54661/ --- Review request for mesos and Adam B. Bugs: MESOS-6670

Re: Review Request 54650: Added validation for roles in ACCEPT call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54650/ --- (Updated Dec. 12, 2016, 10:30 p.m.) Review request for mesos, Benjamin

Re: Review Request 54650: Added validation for roles in ACCEPT call.

> On Dec. 12, 2016, 9:41 p.m., Qian Zhang wrote: > > src/master/validation.cpp, line 1337 > > > > > > I would suggest to change to: > > ``` > > return Error("Offer " + stringify(offerId) + " is no longer

Re: Review Request 54650: Added validation for roles in ACCEPT call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54650/#review158842 --- src/master/validation.cpp (line 1331)

Re: Review Request 54649: Fixed minor argument style.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54649/#review158840 --- Ship it! Ship It! - Qian Zhang On Dec. 12, 2016, 4:41 p.m.,

Re: Review Request 54538: Enabled fine grained authorization for the getContainers API Call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54538/ --- (Updated Dec. 12, 2016, 11:46 a.m.) Review request for mesos and Adam B.

Re: Review Request 54535: Added authorization actions VIEW_CONTAINERS and SET_LOG_LEVEL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54535/ --- (Updated Dec. 12, 2016, 11:45 a.m.) Review request for mesos and Adam B.

Re: Review Request 54650: Added validation for roles in ACCEPT call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54650/#review158835 --- Patch looks great! Reviews applied: [54649, 54650] Passed

Re: Review Request 54655: Renamed LocalNestedContainerObjectApprover for a more generic name.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54655/ --- (Updated Dec. 12, 2016, 10:51 a.m.) Review request for mesos and Adam B.

Re: Review Request 54538: Enabled fine grained authorization for the getContainers API Call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54538/ --- (Updated Dec. 12, 2016, 10:45 a.m.) Review request for mesos and Adam B.

Re: Review Request 54538: WIP: Enabled fine grained authorization for the getContainers API Call.

> On Dec. 11, 2016, 1:24 p.m., Adam B wrote: > > src/slave/http.cpp, line 1833 > > > > > > double-underscore? Do we just skip over `_containers()`? I suppose > > that's part of `/containers`? pretty much so. -

Review Request 54655: Renamed LocalNestedContainerObjectApprover for a more generic name.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54655/ --- Review request for mesos and Adam B. Bugs: MESOS-6670

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/#review158818 --- This patch itself LGTM. Will give ship it once we confirm the

Re: Review Request 49571: Added a benchmark test for allocations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49571/ --- (Updated Dec. 12, 2016, 9:16 a.m.) Review request for mesos and Jiang Yan Xu.

  1   2   >