Re: Review Request 60758: Windows: Updated documentation for NTFS long path support.

OK, Thanks Andy. I think I find it from latest source code in github. -Haijiang > On 11 Jul 2017, at 11:38 AM, Andrew Schwartzmeyer > wrote: > > It is all the patches in the series that this patch ended. The start of the > chain is here:

Re: Review Request 60758: Windows: Updated documentation for NTFS long path support.

Thanks. Can you please help to point out which ticket that fixed it? I am interested with code changes as well. Regards, Haijiang > On 11 Jul 2017, at 9:21 AM, Andrew Schwartzmeyer > wrote: > > It means that it is fixed for Mesos entirely, in code. I rewrote all our

Re: Review Request 60600: Set container DNS with `--default_container_dns` in CNI isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60600/ --- (Updated July 11, 2017, 10 a.m.) Review request for mesos, Avinash sridharan

Re: Review Request 60558: Set container DNS with `--default_container_dns` in Docker executor.

> On July 9, 2017, 3:09 p.m., Avinash sridharan wrote: > > Hi Qian, the changes LGTM but I think we should follow these patches up > > with a test for CNI and CNM networks? Definitely, I am working on it now. And actually I have a comment, in this patch I have handled the case of launching a

Re: Review Request 60758: Windows: Updated documentation for NTFS long path support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60758/#review180149 --- Ship it! Ship It! - Joseph Wu On July 10, 2017, 5:51 p.m.,

Re: Review Request 60758: Windows: Updated documentation for NTFS long path support.

Almost didn't notice your message as people typically do not reply to these emails (except by commenting on the associated review). The master branch of Mesos now contains support for long paths natively in Mesos. This means you no longer have to run Mesos in short paths, with short task names.

Re: Review Request 60600: Set container DNS with `--default_container_dns` in CNI isolator.

> On July 9, 2017, 3:11 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp > > Lines 1003 (patched) > > > > > > s/even the/even though the Fixed. - Qian

Re: Review Request 60500: Introduced `--default_container_dns` agent flag.

> On July 4, 2017, 1:22 a.m., Avinash sridharan wrote: > > docs/configuration.md > > Lines 1312 (patched) > > > > > > `ContainerInfo.docker.parameter` > > Qian Zhang wrote: > The field name is `parameters`

Re: Review Request 60758: Windows: Updated documentation for NTFS long path support.

Does it mean that the Windows Long path will be fixed somewhere in the installation? Thanks, Haijiang > On 11 Jul 2017, at 8:51 AM, Andrew Schwartzmeyer > wrote: > > > --- > This is an automatically generated

Re: Review Request 60325: Windows: Replaced `ping` with `Start-Sleep`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60325/#review180075 --- Ship it! 3rdparty/stout/include/stout/gtest.hpp Line 229

Review Request 60758: Windows: Updated documentation for NTFS long path support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60758/ --- Review request for mesos, Joseph Wu and Li Li. Repository: mesos Description

Re: Review Request 60339: Windows: Deleted `os::hstrerror()` as it is unused.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60339/#review180127 --- Ship it! - Joseph Wu On June 21, 2017, 3:16 p.m., Andrew

Re: Review Request 60308: Refactored `enum FollowSymlink` to an `enum class FollowSymlink`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60308/#review179907 --- Ship it! I'll tweak the below.

Re: Review Request 60317: Windows: Fixed `os::access()` to support long paths.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60317/#review179989 --- Ship it! - Joseph Wu On June 21, 2017, 3:05 p.m., Andrew

Re: Review Request 60341: Windows: Changed job object names to `wstring`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60341/#review180129 --- Ship it! - Joseph Wu On June 21, 2017, 3:16 p.m., Andrew

Re: Review Request 60328: Windows: Added `create_process()` wrapper to `shell.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60328/#review180093 --- Ship it! I can make the tweak below and the cascading changes

Re: Review Request 60332: Windows: Fixed `fs::usage()` to support long paths.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60332/#review180112 --- Ship it! - Joseph Wu On June 21, 2017, 3:13 p.m., Andrew

Re: Review Request 60320: Windows: Cleaned up `os::var()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60320/#review180046 --- Ship it! - Joseph Wu On June 21, 2017, 3:07 p.m., Andrew

Re: Review Request 60329: Windows: Replaced `CreateProcess()` with `create_process()` helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60329/#review180105 --- Ship it!

Re: Review Request 60338: Windows: Made `dynamiclibrary.hpp` use Unicode.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60338/#review180126 --- Ship it!

Re: Review Request 60337: Windows: Made `os::user()` use Unicode.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60337/#review180125 --- Ship it! 3rdparty/stout/include/stout/os/windows/su.hpp Line

Re: Review Request 60324: Windows: Implemented `WSTRINGIFY()` to print exit codes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60324/#review180072 --- Ship it! src/common/status_utils.hpp Lines 35-37 (original),

Re: Review Request 60342: Windows: Made version info use Unicode.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60342/#review180131 --- Ship it! - Joseph Wu On June 21, 2017, 3:17 p.m., Andrew

Re: Review Request 59921: Added agent domain to Offer message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59921/#review180146 --- Ship it! Ship It! - Vinod Kone On July 5, 2017, 10:32 p.m.,

Re: Review Request 59764: Ignore registration attempts by agents with misconfigured domain.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59764/#review180143 --- Fix it, then Ship it! src/master/master.cpp Lines 6090

Re: Review Request 60344: Windows: Require building with `_UNICODE` and `UNICODE`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60344/#review180133 --- Ship it! - Joseph Wu On June 21, 2017, 3:17 p.m., Andrew

Re: Review Request 60311: Windows: Replaced use of `_stat()` with `os::stat::isdir()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60311/#review179942 --- Fix it, then Ship it! I'll make some tweaks before committing.

Re: Review Request 60322: Windows: Fixed `os::rename()` to support long paths.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60322/#review180065 --- Ship it! - Joseph Wu On June 21, 2017, 3:07 p.m., Andrew

Re: Review Request 60345: Windows: Set Unicode compilation flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60345/#review180138 --- Ship it! - Joseph Wu On June 21, 2017, 3:17 p.m., Andrew

Re: Review Request 59766: Changed allocator to offer remote resources to region-aware frameworks.

> On July 11, 2017, 12:08 a.m., Vinod Kone wrote: > > src/tests/master_tests.cpp > > Lines 7406 (patched) > > > > > > can you check that offer contains the domain? i see that this happens in the next review. nm.

Re: Review Request 60340: Windows: Made job object APIs use Unicode.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60340/#review180128 --- Ship it! - Joseph Wu On June 21, 2017, 3:16 p.m., Andrew

Re: Review Request 59766: Changed allocator to offer remote resources to region-aware frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59766/#review180144 --- Fix it, then Ship it!

Re: Review Request 60343: Windows: Made `process_entry()` use Unicode.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60343/#review180132 --- Ship it! - Joseph Wu On June 21, 2017, 3:17 p.m., Andrew

Re: Review Request 60336: Windows: Made environment abstractions use Unicode.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60336/#review180124 --- Ship it! 3rdparty/stout/include/stout/os/windows/getenv.hpp

Re: Review Request 60331: Windows: Disable code using `os::shell()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60331/#review180110 --- Ship it! I'll disable that new flag: src/slave/main.cpp

Re: Review Request 60335: Windows: Made `net.hpp` use Unicode.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60335/#review180121 --- Ship it! - Joseph Wu On June 21, 2017, 3:16 p.m., Andrew

Re: Review Request 60330: Windows: Fixed use of `get_system_env()` in containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60330/#review180108 --- Ship it! - Joseph Wu On June 21, 2017, 3:12 p.m., Andrew

Re: Review Request 60326: Added `vector` explicit cast to `Argv`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60326/#review180077 --- I'm going to rewrite this a bit because of the below:

Re: Review Request 60323: Windows: Fixed `process::createIoPath()` to support long paths.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60323/#review180067 --- Ship it! - Joseph Wu On June 21, 2017, 3:07 p.m., Andrew

Re: Review Request 60299: Windows: Fixed `os::exists()` to support long paths.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60299/#review179665 --- Ship it! LGTM. I'll tweak the below before committing.

Re: Review Request 60321: Windows: Fixed `fs::list()` to support long paths.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60321/#review180061 --- Ship it! - Joseph Wu On June 21, 2017, 3:07 p.m., Andrew

Re: Review Request 60318: Windows: Made `os::temp()` use UTF-16 system calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60318/#review180036 --- Ship it! - Joseph Wu On June 21, 2017, 3:07 p.m., Andrew

Re: Review Request 60313: Windows: Fixed `os::rm()` to support long paths.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60313/#review179949 --- Ship it! - Joseph Wu On June 21, 2017, 3:02 p.m., Andrew

Re: Review Request 60314: Windows: Fixed `os::rmdir()` to support long paths.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60314/#review179961 --- Ship it! 3rdparty/stout/include/stout/os/windows/rmdir.hpp

Re: Review Request 60315: Windows: Fixed `os::open()` to support long paths.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60315/#review179985 --- Ship it! - Joseph Wu On June 21, 2017, 3:04 p.m., Andrew

Re: Review Request 60296: Windows: Added long path test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60296/#review179064 --- Ship it! Hum, looks like this test shouldn't pass until after

Re: Review Request 60305: Windows: Refactored `reparse_point_attribute_set()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60305/#review179743 --- Ship it! - Joseph Wu On June 21, 2017, 2:58 p.m., Andrew

Re: Review Request 60310: Fixed fetcher to use `enum class FollowSymlink`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60310/#review179918 --- Ship it! - Joseph Wu On June 21, 2017, 2:59 p.m., Andrew

Re: Review Request 60307: Windows: Fixed `CreateSymbolicLink()` to support long paths.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60307/#review179744 --- Ship it! LGTM. - Joseph Wu On June 21, 2017, 2:59 p.m.,

Re: Review Request 60300: Windows: Fixed `isdir()` and `isfile()` to support long paths.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60300/#review179682 --- Ship it! 3rdparty/stout/include/stout/os/windows/stat.hpp

Re: Review Request 60294: Windows: Added `os::LONGPATH_PREFIX` constant.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60294/#review179045 --- Ship it! LGTM. - Joseph Wu On June 21, 2017, 2:54 p.m.,

Re: Review Request 59762: Added domain to MasterInfo and SlaveInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59762/ --- (Updated July 10, 2017, 11:12 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 60293: Windows: Switched from `gethostname` to `GetComputerName`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60293/#review179042 --- Ship it! 3rdparty/stout/include/stout/windows/os.hpp Lines

Re: Review Request 60292: Windows: Added a `wstring wide_stringify(string)` helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60292/#review179039 --- Ship it! Note: There are a few minor whitespace nits scattered

Re: Review Request 56895: Added tests to ensure slave recovery post reboot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56895/ --- (Updated July 10, 2017, 11:15 p.m.) Review request for mesos, Neil Conway,

Re: Review Request 60520: Remove posix/subprocess.hpp dependencies.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60520/#review180099 --- src/checks/checker_process.cpp Lines 126-136 (patched)

Re: Review Request 60729: Fixed persistent volume and host volume conflict issue.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60729/#review180074 --- src/slave/containerizer/mesos/isolators/filesystem/linux.cpp

Re: Review Request 60720: Fixed initialization of `__address__` in the abscense of `--ip` flag.

> On July 7, 2017, 11:18 p.m., Jiang Yan Xu wrote: > > 3rdparty/libprocess/src/process.cpp > > Line 1135 (original), 1135 (patched) > > > > > > You are (re)initalizing/resetting this `__address__` but not > >

Re: Review Request 60750: Added unit tests for persistent volume and host volume conflict issue.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60750/#review180079 --- Ship it! Ship It! - Jie Yu On July 10, 2017, 6 p.m.,

Re: Review Request 60105: Clean rebooted slave's state if slaveInfo mismatches.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60105/#review180073 --- Please comment with the result of a real reboot test. - Jiang

Re: Review Request 60724: Fixed initialization of `LIBPROCESS_IP6` on agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60724/#review180066 --- Ship it! - Benjamin Hindman On July 9, 2017, 8:23 p.m.,

Re: Review Request 60729: Fixed persistent volume and host volume conflict issue.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60729/ --- (Updated July 10, 2017, 11 a.m.) Review request for mesos, James DeFelice, Jie

Review Request 60750: Added unit tests for persistent volume and host volume conflict issue.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60750/ --- Review request for mesos, James DeFelice, Jie Yu, and Vinod Kone. Bugs:

Re: Review Request 59766: Changed allocator to offer remote resources to region-aware frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59766/ --- (Updated July 10, 2017, 5:26 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 60724: Fixed initialization of `LIBPROCESS_IP6` on agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60724/#review180050 --- Ship it! Ship It! - Benjamin Bannier On July 9, 2017, 10:23

Re: Review Request 60720: Fixed initialization of `__address__` in the abscense of `--ip` flag.

> On July 7, 2017, 4:18 p.m., Jiang Yan Xu wrote: > > 3rdparty/libprocess/src/process.cpp > > Line 1135 (original), 1135 (patched) > > > > > > You are (re)initalizing/resetting this `__address__` but not > >

Re: Review Request 60723: Made intialization for `__address__` consistent.

> On July 10, 2017, 9:15 a.m., Jiang Yan Xu wrote: > > Ship It! I still found it a bit odd that initialization of `__address__` is both above and below `__address6__` but the initialization of `__address__` is way more complex than that of `__address6__` at this point and it's intertwined

Re: Review Request 60723: Made intialization for `__address__` consistent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60723/#review180045 --- Ship it! Ship It! - Jiang Yan Xu On July 7, 2017, 5:22

Re: Review Request 60598: Replaced `abort()` with `_exit()` in `ChildHook::SUPERVISOR`.

> On July 10, 2017, 2:19 p.m., Alexander Rojas wrote: > > 3rdparty/libprocess/src/subprocess.cpp > > Line 118 (original), 118 (patched) > > > > > > Here and below, we use the macro `EXIT(EXIT_FAILURE)` with a log

Re: Review Request 60598: Replaced `abort()` with `_exit()` in `ChildHook::SUPERVISOR`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60598/#review180034 --- 3rdparty/libprocess/src/subprocess.cpp Line 118 (original), 118

Re: Review Request 60214: Logged when an offer is removed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60214/#review180031 --- Ship it! - Armand Grillet On June 19, 2017, 10:42 p.m.,

Re: Review Request 60215: WIP: Logged offer ids of sent offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60215/#review180032 --- Ship it! Ship It! - Armand Grillet On June 19, 2017, 11:08

Re: Review Request 60397: Check perf version compatibility in tests with disabled coredumps.

> On July 7, 2017, 1:15 p.m., Alexander Rojas wrote: > > src/linux/perf.cpp > > Lines 245 (patched) > > > > > > In this case, `LOG(ERROR)` is the wrong log level, since you may expect > > in certain cases for the

Re: Review Request 60697: Added mesos.http module for abstracting out http requests in the new cli.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60697/#review180020 --- Patch looks great! Reviews applied: [60697] Passed command:

Re: Review Request 60525: Fixed the default filter used by the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60525/#review180013 --- Fix it, then Ship it! The change makes sense to me: if the