Re: Review Request 62003: Added `network/ports` isolator nested container tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62003/#review188814 --- FAIL: Failed to apply the dependent review: 60491. Failed

Re: Review Request 63173: Refactored and fixed `DefaultExecutorTest.CommitSuicideOnKillTask`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63173/#review188813 --- PASS: Mesos patch 63173 was successfully built and tested.

Re: Review Request 55334: Checkpoint and recover `ContainerConfig` in Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55334/ --- (Updated Oct. 20, 2017, 4:41 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 63174: Added a benchmark for agent reregistration during master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63174/#review188802 --- Patch looks great! Reviews applied: [63174] Passed command:

Re: Review Request 63174: Added a benchmark for agent reregistration during master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63174/#review188799 --- Thanks Yan! I will dig in soon. Just some quick questions: (1)

Re: Review Request 60628: Enabled fetcher_tests.cpp unit test module on Windows platform.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60628/#review188798 --- PASS: Mesos patch 60628 was successfully built and tested.

Re: Review Request 63021: Added functions to launch CSI plugin in storage local resource provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63021/#review188726 --- src/resource_provider/storage/provider.cpp Line 57 (original),

Re: Review Request 63172: Added and used more v1 scheduler API test helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63172/ --- (Updated Oct. 19, 2017, 5:24 p.m.) Review request for mesos and Alexander

Review Request 63175: Do not generate UnavailableResources for inactive frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63175/ --- Review request for mesos and Joseph Wu. Bugs: MESOS-8085

Re: Review Request 63173: Refactored and fixed `DefaultExecutorTest.CommitSuicideOnKillTask`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63173/#review188796 --- Patch looks great! Reviews applied: [63172, 63173] Passed

Re: Review Request 63076: Windows: Fixed off-by-one error in long path support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63076/ --- (Updated Oct. 19, 2017, 4:36 p.m.) Review request for mesos and Joseph Wu.

Re: Review Request 63076: Windows: Fixed off-by-one error in long path support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63076/ --- (Updated Oct. 19, 2017, 4:37 p.m.) Review request for mesos and Joseph Wu.

Review Request 63174: Added a benchmark for agent reregistration during master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63174/ --- Review request for mesos, Benjamin Mahler, Dmitry Zhuk, and Ilya Pronin. Bugs:

Re: Review Request 63170: Eliminated unnecssary copying within process::Mutex.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63170/#review188793 --- PASS: Mesos patch 63170 was successfully built and tested.

Re: Review Request 63105: Added 'apply' handlers for storage operations.

> On Oct. 19, 2017, 10:42 p.m., Chun-Hung Hsiao wrote: > > src/common/resources.cpp > > Line 1765 (original), 1765 (patched) > > > > > > We need a separated validation function. A resource provider will do > > the

Re: Review Request 62003: Added `network/ports` isolator nested container tests.

> On Oct. 19, 2017, 10:44 p.m., Gaston Kleiman wrote: > > src/tests/containerizer/ports_isolator_tests.cpp > > Lines 1133 (patched) > > > > > > Nit: I prefer `ASSERT_FALSE(offers->offers().empty());` Yes

Re: Review Request 62003: Added `network/ports` isolator nested container tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62003/#review188777 --- I love the new helper ;-).

Re: Review Request 63105: Added 'apply' handlers for storage operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63105/#review188775 --- src/common/resources.cpp Line 1765 (original), 1765 (patched)

Re: Review Request 60765: Added basic `network/ports` isolator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60765/#review188782 --- src/tests/containerizer/ports_isolator_tests.cpp Lines 142

Re: Review Request 62911: Added a ReadWriteLock to libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62911/#review188779 --- 3rdparty/libprocess/include/process/rwlock.hpp Lines 155

Review Request 63173: Refactored and fixed `DefaultExecutorTest.CommitSuicideOnKillTask`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63173/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos

Review Request 63172: Added and used more v1 scheduler API test helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63172/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos

Re: Review Request 62911: Added a ReadWriteLock to libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62911/#review188771 --- Ship it! Made some minor tweaks to the comments and added some

Re: Review Request 62912: Added tests for ReadWriteLock.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62912/#review188769 --- Fix it, then Ship it! I made some minor tweaks to the code,

Re: Review Request 63170: Eliminated unnecssary copying within process::Mutex.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63170/#review188770 --- Ship it! Ship It! - Zhitao Li On Oct. 19, 2017, 9:20 p.m.,

Re: Review Request 60620: Modifed os::write to write binary files on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60620/ --- (Updated Oct. 19, 2017, 9:47 p.m.) Review request for mesos, Andrew

Re: Review Request 60628: Enabled fetcher_tests.cpp unit test module on Windows platform.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60628/#review188768 --- Patch looks great! Reviews applied: [60291, 60292, 60293, 60294,

Re: Review Request 63094: Added resource version uuid for offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63094/ --- (Updated Oct. 19, 2017, 9:35 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 60620: Modifed os::write to write binary files on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60620/ --- (Updated Oct. 19, 2017, 9:34 p.m.) Review request for mesos, Andrew

Re: Review Request 60628: Enabled fetcher_tests.cpp unit test module on Windows platform.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60628/ --- (Updated Oct. 19, 2017, 9:33 p.m.) Review request for mesos, Andrew

Re: Review Request 60624: Enabled HDFS compilation and associated tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60624/ --- (Updated Oct. 19, 2017, 9:33 p.m.) Review request for mesos, Andrew

Re: Review Request 60622: Added new stout functions for path and URI conversions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60622/ --- (Updated Oct. 19, 2017, 9:33 p.m.) Review request for mesos, Andrew

Re: Review Request 60626: Eliminated os::shell calls from HDFS for Windows compatibility.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60626/ --- (Updated Oct. 19, 2017, 9:33 p.m.) Review request for mesos, Andrew

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

> On Oct. 18, 2017, 8:21 p.m., Chun-Hung Hsiao wrote: > > include/mesos/v1/mesos.proto > > Lines 2170 (patched) > > > > > > This protobuf is exposed to RP API. Do we want an RP to be aware of the > > scheduler? Do

Re: Review Request 60623: Converted "file://" URI handling to use new uri function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60623/ --- (Updated Oct. 19, 2017, 9:33 p.m.) Review request for mesos, Andrew

Re: Review Request 60621: Added new stout capability: os::copyfile(source, dest).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60621/ --- (Updated Oct. 19, 2017, 9:32 p.m.) Review request for mesos, Andrew

Re: Review Request 60628: Enabled fetcher_tests.cpp unit test module on Windows platform.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60628/#review188764 --- Ship it! src/launcher/fetcher.cpp Lines 99 (patched)

Re: Review Request 60624: Enabled HDFS compilation and associated tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60624/#review188762 --- Ship it! Ship It! - Andrew Schwartzmeyer On Oct. 19, 2017,

Re: Review Request 60626: Eliminated os::shell calls from HDFS for Windows compatibility.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60626/#review188763 --- Ship it! Ship It! - Andrew Schwartzmeyer On Oct. 19, 2017,

Review Request 63170: Eliminated unnecssary copying within process::Mutex.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63170/ --- Review request for mesos and Zhitao Li. Repository: mesos Description

Re: Review Request 62003: Added `network/ports` isolator nested container tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62003/#review188751 --- FAIL: Failed to apply the dependent review: 60491. Failed

Re: Review Request 62003: Added `network/ports` isolator nested container tests.

> On Oct. 18, 2017, 8:38 a.m., Qian Zhang wrote: > > src/tests/containerizer/ports_isolator_tests.cpp > > Lines 1225 (patched) > > > > > > Why do we need the `slaveId`? Can we just call `StartSlave()` like what >

Re: Review Request 60628: Enabled fetcher_tests.cpp unit test module on Windows platform.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60628/#review188739 --- FAIL: Failed to apply the dependent review: 60292. Failed

Re: Review Request 63146: Replaced std::cerr by LOG(ERROR) in process.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63146/#review188738 --- PASS: Mesos patch 63146 was successfully built and tested.

Re: Review Request 63146: Replaced std::cerr by LOG(ERROR) in process.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63146/#review188736 --- Patch looks great! Reviews applied: [63146] Passed command:

Re: Review Request 63146: Replaced std::cerr by LOG(ERROR) in process.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63146/#review188730 --- Fix it, then Ship it! 3rdparty/libprocess/src/process.cpp

Re: Review Request 60622: Added new stout functions for path and URI conversions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60622/#review188727 --- Ship it! Ship It! - Andrew Schwartzmeyer On Oct. 19, 2017,

Re: Review Request 60624: Enabled HDFS compilation and associated tests.

> On Oct. 17, 2017, 11:24 p.m., Andrew Schwartzmeyer wrote: > > src/tests/hdfs_tests.cpp > > Lines 55-57 (original), 55-60 (patched) > > > > > > Nit: this comment isn't great... we do know how to handle execution >

Re: Review Request 60624: Enabled HDFS compilation and associated tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60624/ --- (Updated Oct. 19, 2017, 6:18 p.m.) Review request for mesos, Andrew

Re: Review Request 60628: Enabled fetcher_tests.cpp unit test module on Windows platform.

> On Oct. 18, 2017, 1:36 a.m., Andrew Schwartzmeyer wrote: > > src/launcher/fetcher.cpp > > Lines 192-211 (original), 198-209 (patched) > > > > > > I've mentioned this a few times, but this function at least appears

Re: Review Request 60628: Enabled fetcher_tests.cpp unit test module on Windows platform.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60628/ --- (Updated Oct. 19, 2017, 6:18 p.m.) Review request for mesos, Andrew

Re: Review Request 60626: Eliminated os::shell calls from HDFS for Windows compatibility.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60626/ --- (Updated Oct. 19, 2017, 6:17 p.m.) Review request for mesos, Andrew

Re: Review Request 60623: Converted "file://" URI handling to use new uri function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60623/ --- (Updated Oct. 19, 2017, 6:17 p.m.) Review request for mesos, Andrew

Re: Review Request 60626: Eliminated os::shell calls from HDFS for Windows compatibility.

> On Oct. 18, 2017, 12:45 a.m., Andrew Schwartzmeyer wrote: > > Needs a description still. Ok. > On Oct. 18, 2017, 12:45 a.m., Andrew Schwartzmeyer wrote: > > src/hdfs/hdfs.cpp > > Lines 125-134 (patched) > > > > > >

Re: Review Request 60622: Added new stout functions for path and URI conversions.

> On Oct. 17, 2017, 11:21 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/stout/include/stout/path.hpp > > Lines 45-52 (patched) > > > > > > The `startsWith` is unecessary. This can be replaced with one line: > >

Re: Review Request 60622: Added new stout functions for path and URI conversions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60622/ --- (Updated Oct. 19, 2017, 6:16 p.m.) Review request for mesos, Andrew

Re: Review Request 60621: Added new stout capability: os::copyfile(source, dest).

> On Oct. 17, 2017, 11:16 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/stout/include/stout/os/posix/copyfile.hpp > > Lines 38 (patched) > > > > > > nit: whitespace Removed blank line. > On Oct. 17, 2017, 11:16

Re: Review Request 60621: Added new stout capability: os::copyfile(source, dest).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60621/ --- (Updated Oct. 19, 2017, 6:16 p.m.) Review request for mesos, Andrew

Re: Review Request 60620: Modifed os::write to write binary files on Windows.

> On Oct. 17, 2017, 11:12 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/stout/include/stout/os/write.hpp > > Lines 107 (patched) > > > > > > nit: extra whitespace introduced Removed blank line. - Jeff

Re: Review Request 60620: Modifed os::write to write binary files on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60620/ --- (Updated Oct. 19, 2017, 6:15 p.m.) Review request for mesos, Andrew

Re: Review Request 63060: Added utility functions and structures for CSI.

> On Oct. 19, 2017, 5:51 p.m., Jie Yu wrote: > > src/csi/utils.cpp > > Lines 25 (patched) > > > > > > Do you need `csi::` prefix? Yes. `Version` is also defined in stout. - Chun-Hung

Re: Review Request 63019: Encapsulated common error handling in CSI clients.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63019/#review188715 --- src/csi/client.cpp Lines 34-66 (patched)

Re: Review Request 63060: Added utility functions and structures for CSI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63060/#review188712 --- Fix it, then Ship it! src/csi/utils.hpp Lines 77-78 (patched)

Re: Review Request 60511: Added MockMetadataManager and test concurrent prune and pull.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60511/#review188694 --- FAIL: Failed to apply the current review. Failed command:

Re: Review Request 60511: Added MockMetadataManager and test concurrent prune and pull.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60511/ --- (Updated Oct. 19, 2017, 4:29 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 56721: Implemented pruneImages with a mark and sweep in docker store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56721/ --- (Updated Oct. 19, 2017, 4:28 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 55335: Backfilled required fields in TaskInfo in MesosContainerizer* tests.

> On Sept. 26, 2017, 1:23 a.m., Gilbert Song wrote: > > src/tests/containerizer/mesos_containerizer_tests.cpp > > Line 714 (original), 714-720 (patched) > > > > > > will it look cleaner if use `createTask()` helper?

Re: Review Request 62912: Added tests for ReadWriteLock.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62912/ --- (Updated Oct. 19, 2017, 4:25 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 63146: Replaced std::cerr by LOG(ERROR) in process.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63146/#review188692 --- PASS: Mesos patch 63146 was successfully built and tested.

Re: Review Request 62911: Added a ReadWriteLock to libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62911/ --- (Updated Oct. 19, 2017, 4:24 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 63035: Made `getMountNamespaceTarget` more reliable by ignoring exited childs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63035/#review188690 --- Ship it! Ship It! - Jie Yu On Oct. 17, 2017, 1:45 p.m.,

Re: Review Request 63074: Changed return type of `ns::getns()` from `Try` to `Result`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63074/#review188689 --- Ship it! Ship It! - Jie Yu On Oct. 17, 2017, 1:44 p.m.,

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

> On Oct. 18, 2017, 4:04 a.m., Chun-Hung Hsiao wrote: > > include/mesos/resource_provider/resource_provider.proto > > Lines 47-48 (original), 47-48 (patched) > > > > > > Do we need to expose `framework_id` to RP if

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

> On Oct. 19, 2017, 11:50 a.m., Benjamin Bannier wrote: > > include/mesos/mesos.proto > > Lines 2199-2201 (patched) > > > > > > We will also need to model the case where an offer operation succeeds > > only

Re: Review Request 63148: Fixed 'PortMappingMesosTest.ROOT_NetworkNamespaceHandleSymlink'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63148/#review188685 --- Ship it! Ship It! - Alexander Rukletsov On Oct. 19, 2017,

Re: Review Request 63146: Replaced std::cerr by LOG(ERROR) in process.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63146/#review188684 --- Patch looks great! Reviews applied: [63146] Passed command:

Re: Review Request 63093: Moved building docs to `building.md`.

> On Oct. 18, 2017, 10 a.m., Vinod Kone wrote: > > docs/getting-started.md > > Line 241 (original), 241 (patched) > > > > > > Should we move this to a "Running Mesos" section/page? This is not > > technically

Re: Review Request 63093: Moved building docs to `building.md`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63093/#review188683 --- Ship it! Ship It! - Vinod Kone On Oct. 18, 2017, 2:58 a.m.,

Re: Review Request 62548: Reorganized and updated the contribution guidelines.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62548/#review188681 --- Ship it! Ship It! - Vinod Kone On Oct. 18, 2017, 7:36 p.m.,

Review Request 63148: Fixed 'PortMappingMesosTest.ROOT_NetworkNamespaceHandleSymlink'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63148/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos

Re: Review Request 62579: Added a test `BlkioIsolatorTest.ROOT_BlkioUsage`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62579/#review188679 --- PASS: Mesos patch 62579 was successfully built and tested.

Review Request 63146: Replaced std::cerr by LOG(ERROR) in process.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63146/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos

Re: Review Request 62579: Added a test `BlkioIsolatorTest.ROOT_BlkioUsage`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62579/#review188673 --- Bad patch! Reviews applied: [62579] Failed command: ['bash',

Re: Review Request 62579: Added a test `BlkioIsolatorTest.ROOT_BlkioUsage`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62579/ --- (Updated Oct. 19, 2017, 8:29 p.m.) Review request for mesos and Gilbert Song.

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63001/#review188668 --- include/mesos/mesos.proto Lines 2199-2201 (patched)

Re: Review Request 62595: Added test module wrapping the basic HTTP authenticatee.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62595/#review188655 --- Ship it! Ship It! - Armand Grillet On Sept. 26, 2017, 10:54

Re: Review Request 62595: Added test module wrapping the basic HTTP authenticatee.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62595/#review188654 --- LGTM. - Armand Grillet On Sept. 26, 2017, 10:54 p.m., Till