Re: Review Request 67960: Added support for instrumenting HTTP endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67960/#review206192 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 67952: Windows: Ported remaining tests in the `HTTPTest` suite.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67952/#review206191 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 67823: Added a master benchmark test for metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67823/#review206190 --- FAIL: Failed to apply the dependent review: 67809. Failed

Re: Review Request 67953: Disabled the clang `-Winconsistent-missing-override` warning.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67953/#review206189 --- PASS: Mesos patch 67953 was successfully built and tested.

Re: Review Request 67235: Added per-framework metrics for types of resources contained in offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67235/ --- (Updated July 18, 2018, 1:46 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 67823: Added a master benchmark test for metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67823/ --- (Updated July 18, 2018, 1:47 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 67187: Tested per-framework task state metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67187/ --- (Updated July 18, 2018, 1:46 a.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 67878: Added/updated tests to check per-framework metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67878/ --- (Updated July 18, 2018, 1:46 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 66870: Added per-framework metrics for suppressed roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66870/ --- (Updated July 18, 2018, 1:45 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 66856: Tracked completed framework metrics in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66856/ --- (Updated July 18, 2018, 1:45 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 66861: Added per-framework DRF position metrics to the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66861/ --- (Updated July 18, 2018, 1:44 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 66855: Changed the 'capacity_' member of 'BoundedHashMap' to non-const.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66855/ --- (Updated July 18, 2018, 1:44 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 66843: Enabled per-framework metrics in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66843/ --- (Updated July 18, 2018, 1:43 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 67776: Added per-framework metrics for scheduler calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67776/ --- (Updated July 18, 2018, 1:42 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 67147: Included a missing header in the master metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67147/ --- (Updated July 18, 2018, 1:41 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 66841: Added a hash function for 'Duration'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66841/ --- (Updated July 18, 2018, 1:36 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 67813: Added per-framework metrics for task states.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67813/ --- (Updated July 18, 2018, 1:35 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 67812: Added per-framework offer metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67812/ --- (Updated July 18, 2018, 1:34 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 67809: Added per-framework metrics for scheduler events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67809/ --- (Updated July 18, 2018, 1:34 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 66820: Added per-framework 'subscribed' metric and helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66820/ --- (Updated July 18, 2018, 1:33 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 67776: Added per-framework metrics for scheduler calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67776/ --- (Updated July 18, 2018, 1:34 a.m.) Review request for mesos, Benjamin Mahler,

Review Request 67962: Enabled per-framework metrics in the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67962/ --- Review request for mesos and Gastón Kleiman. Repository: mesos Description

Review Request 67959: Added support for instrumenting processes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67959/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Review Request 67958: Added LibprocessTest for easily configuring the library for a test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67958/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Review Request 67960: Added support for instrumenting HTTP endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67960/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Review Request 67957: Refactored TemporaryDirectoryTest to be a mixin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67957/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Review Request 67956: Removed some generic flag parsers that are now in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67956/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Review Request 67955: Added some new generic flag parsers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67955/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Re: Review Request 67875: Added `normalizeMetricKey()` and `getFrameworkMetricPrefix()`.

> On July 16, 2018, 8:28 p.m., Gastón Kleiman wrote: > > src/master/metrics.cpp > > Lines 551-554 (patched) > > > > > > Per offline discussion we can inline this method in > > `getFrameworkMetricPrefix()`. I've

Re: Review Request 67952: Windows: Ported remaining tests in the `HTTPTest` suite.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67952/ --- (Updated July 17, 2018, 5:52 p.m.) Review request for mesos, Eric Mumau, John

Re: Review Request 67952: Windows: Ported remaining tests in the `HTTPTest` suite.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67952/#review206186 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 67951: Added optional `path_separator` parameter to `Path` constructor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67951/#review206185 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 67953: Disabled the clang `-Winconsistent-missing-override` warning.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67953/#review206184 --- Ship it! Ship It! - Gilbert Song On July 17, 2018, 5:05

Review Request 67953: Disabled the clang `-Winconsistent-missing-override` warning.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67953/ --- Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, and Benjamin

Re: Review Request 67950: Disabled override warnings for mocked methods.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67950/#review206182 --- PASS: Mesos patch 67950 was successfully built and tested.

Re: Review Request 67932: Use `wclayer` from `hcsshim` to extract file layers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67932/#review206183 --- Bad review! Error: Circular dependency detected for review

Re: Review Request 67951: Added optional `path_separator` parameter to `Path` constructor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67951/#review206181 --- Ship it! Ship It! - Radhika Jandhyala On July 17, 2018,

Re: Review Request 67932: Use `wclayer` from `hcsshim` to extract file layers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67932/ --- (Updated July 17, 2018, 11:15 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 67930: Get tests ready for Windows UCR development.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67930/ --- (Updated July 17, 2018, 11:15 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 67931: Support Image Manifest Version 2 Schema 2.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67931/ --- (Updated July 17, 2018, 11:14 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 67952: Windows: Ported remaining tests in the `HTTPTest` suite.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67952/#review206180 --- Ship it! Ship It! - John Kordich On July 17, 2018, 10:27

Re: Review Request 67951: Added optional `path_separator` parameter to `Path` constructor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67951/#review206179 --- Ship it! Ship It! - John Kordich On July 17, 2018, 10:27

Review Request 67951: Added optional `path_separator` parameter to `Path` constructor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67951/ --- Review request for mesos, Eric Mumau, John Kordich, Joseph Wu, Liangyu Zhao,

Review Request 67952: Windows: Ported remaining tests in the `HTTPTest` suite.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67952/ --- Review request for mesos, Eric Mumau, John Kordich, Joseph Wu, Liangyu Zhao,

Re: Review Request 67827: Added a helper `stripIncapableResources` in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67827/#review206178 --- FAIL: Failed to apply the current review. Failed command:

Re: Review Request 67936: Fixed ephemeral ports deallocation in network/port_mapping isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67936/#review206177 --- PASS: Mesos patch 67936 was successfully built and tested.

Re: Review Request 67947: Passed the default options when making gRPC calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67947/#review206175 --- PASS: Mesos patch 67947 was successfully built and tested.

Review Request 67950: Disabled override warnings for mocked methods.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67950/ --- Review request for mesos and Benjamin Bannier. Repository: mesos Description

Re: Review Request 67827: Added a helper `stripIncapableResources` in the allocator.

> On July 5, 2018, 3:16 p.m., Benjamin Mahler wrote: > > src/master/allocator/mesos/hierarchical.hpp > > Lines 687 (patched) > > > > > > s/ based on the ..././ > > > > Or this might be clearer? > > > >

Re: Review Request 67827: Added a helper `stripIncapableResources` in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67827/ --- (Updated July 17, 2018, 2:32 p.m.) Review request for mesos and Benjamin

Re: Review Request 67945: Made getters in the Slave class in the allocator return references.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67945/#review206171 --- PASS: Mesos patch 67945 was successfully built and tested.

Re: Review Request 67444: Persisted role consumed quota info in the allocator.

> On July 5, 2018, 2:22 p.m., Benjamin Mahler wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Lines 2586-2588 (patched) > > > > > > It's pretty hard to reason from here about whether this is correct. For

Re: Review Request 67871: Optimized the generation of metrics snapshots.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67871/ --- (Updated July 17, 2018, 8:36 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 67777: Added a helper to match agent-framework capabilities in the allocator.

> On July 5, 2018, 2:33 p.m., Benjamin Mahler wrote: > > src/master/allocator/mesos/hierarchical.hpp > > Lines 666 (patched) > > > > > > Can you just take the Framework struct here? Feels a little odd that we > >

Re: Review Request 67947: Passed the default options when making gRPC calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67947/#review206168 --- Ship it! Nice! Note that if we always wanted compilable

Re: Review Request 67777: Added a helper to match agent-framework capabilities in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6/ --- (Updated July 17, 2018, 1:35 p.m.) Review request for mesos and Benjamin

Re: Review Request 67871: Optimized the generation of metrics snapshots.

> On July 16, 2018, 7:46 p.m., Benjamin Mahler wrote: > > 3rdparty/libprocess/src/metrics/metrics.cpp > > Lines 174 (patched) > > > > > > How about s/result/waited/? SGTM - Greg

Re: Review Request 67871: Optimized the generation of metrics snapshots.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67871/ --- (Updated July 17, 2018, 8:33 p.m.) Review request for mesos, Benjamin Mahler,

Review Request 67947: Passed the default options when making gRPC calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67947/ --- Review request for mesos, Benjamin Bannier and Jie Yu. Bugs: MESOS-9055

Re: Review Request 67938: Made gRPC call options configurable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67938/ --- (Updated July 17, 2018, 8:20 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 67936: Fixed ephemeral ports deallocation in network/port_mapping isolator.

> On July 16, 2018, 4:59 p.m., Jie Yu wrote: > > src/tests/containerizer/port_mapping_tests.cpp > > Lines 1826 (patched) > > > > > > instead of hard code 512 which is fragile, i'd get `ephemeral_ports` > >

Re: Review Request 67936: Fixed ephemeral ports deallocation in network/port_mapping isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67936/ --- (Updated July 17, 2018, 1:12 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 67826: Made `Slave::getAvailable()` return all shared resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67826/ --- (Updated July 17, 2018, 12:47 p.m.) Review request for mesos, Benjamin Mahler

Review Request 67945: Made getters in the Slave class in the allocator return references.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67945/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Re: Review Request 67931: Support Image Manifest Version 2 Schema 2.

> On July 17, 2018, 6:16 p.m., Andrew Schwartzmeyer wrote: > > include/mesos/docker/spec.hpp > > Lines 141 (patched) > > > > > > Dumb question, but is there an S1/S2 for V1 as well? I don't think so. > On July

Re: Review Request 67932: Use `wclayer` from `hcsshim` to extract file layers.

> On July 16, 2018, 12:48 p.m., Mesos Reviewbot Windows wrote: > > FAIL: Some of the unit tests failed. Please check the relevant logs. > > > > Reviews applied: `['67930', '67931', '67932']` > > > > Failed command: `Start-MesosCITesting` > > > > All the build artifacts available at: > >

Re: Review Request 67931: Support Image Manifest Version 2 Schema 2.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67931/#review206157 --- There is still more to review... I'll get to it.

Re: Review Request 67928: Added balloon framework metric for tasks which were running.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67928/#review206154 --- Ship it! Ship It! - Meng Zhu On July 16, 2018, 3:01 p.m.,

Re: Review Request 67488: Updated CLI to Python 3.

> On July 16, 2018, 1:32 p.m., Andrew Schwartzmeyer wrote: > > Did you have an automated way of finding where we should apply `override` > > in existing code? I'd like to see if there's any Windows-only code/tests we > > should fix too. > > Armand Grillet wrote: > What do you mean by

Re: Review Request 67488: Updated CLI to Python 3.

> On July 16, 2018, 8:32 p.m., Andrew Schwartzmeyer wrote: > > Did you have an automated way of finding where we should apply `override` > > in existing code? I'd like to see if there's any Windows-only code/tests we > > should fix too. What do you mean by `override`? I have applied `2to3` on

Re: Review Request 67938: Made gRPC call options configurable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67938/#review206147 --- Fix it, then Ship it!