d39ee9bb0ee782bd756b7a5fc0dec70d056c9589
Diff: https://reviews.apache.org/r/39420/diff/
Testing
---
Tested with python 2.7.
- With and without '-c'.
- Tested reviews with and without parents.
Thanks,
Artem Harutyunyan
---
Thanks,
Artem Harutyunyan
-
support/apply-reviews.py d39ee9bb0ee782bd756b7a5fc0dec70d056c9589
Diff: https://reviews.apache.org/r/39420/diff/
Testing
---
Tested with python 2.7.
- With and without '-c'.
- Tested reviews with and without parents.
Thanks,
Artem Harutyunyan
cally generated e-mail. To reply, visit:
https://reviews.apache.org/r/39420/#review105755
---
On Nov. 10, 2015, 12:03 a.m., Artem Harutyunyan wrote:
>
> ---
> This is an automa
-reviews.py PRE-CREATION
Diff: https://reviews.apache.org/r/39410/diff/
Testing
---
Tested with python 2.7
Thanks,
Artem Harutyunyan
Diff: https://reviews.apache.org/r/38883/diff/
Testing
---
Tested the script with python 2.7.
Thanks,
Artem Harutyunyan
://reviews.apache.org/r/39410/diff/
Testing
---
Tested with python 2.7
Thanks,
Artem Harutyunyan
/apply-review.sh 6391451542e9e8847ec38e2ad9d9acf552afead3
support/apply-reviews.py PRE-CREATION
Diff: https://reviews.apache.org/r/39420/diff/
Testing
---
Tested with python 2.7.
- with and without '-p'.
- Tested reviews with and without parents.
Thanks,
Artem Harutyunyan
6391451542e9e8847ec38e2ad9d9acf552afead3
support/apply-reviews.py PRE-CREATION
Diff: https://reviews.apache.org/r/39420/diff/
Testing
---
Tested with python 2.7.
- with and without '-p'.
- Tested reviews with and without parents.
Thanks,
Artem Harutyunyan
-reviews.py d39ee9bb0ee782bd756b7a5fc0dec70d056c9589
Diff: https://reviews.apache.org/r/39410/diff/
Testing
---
Tested with python 2.7
Thanks,
Artem Harutyunyan
ich can take several seconds.
TIL Python does not have a ternary operator, but point taken :).
- Artem
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39410/#review105786
----
: https://reviews.apache.org/r/39420/diff/
Testing (updated)
---
Tested with python 2.7.
- With and without '-c'.
- Tested reviews with and without parents.
Thanks,
Artem Harutyunyan
-reviews.py d39ee9bb0ee782bd756b7a5fc0dec70d056c9589
Diff: https://reviews.apache.org/r/39420/diff/
Testing (updated)
---
Tested with python 2.7.
- with and without '-c'.
- Tested reviews with and without parents.
Thanks,
Artem Harutyunyan
://reviews.apache.org/r/38705/diff/
Testing
---
Tested the script with python 2.7.
Thanks,
Artem Harutyunyan
://reviews.apache.org/r/38883/diff/
Testing
---
Tested the script with python 2.7.
Thanks,
Artem Harutyunyan
PRE-CREATION
Diff: https://reviews.apache.org/r/39410/diff/
Testing
---
Tested with python 2.7
Thanks,
Artem Harutyunyan
/apply-review.sh 6391451542e9e8847ec38e2ad9d9acf552afead3
support/apply-reviews.py PRE-CREATION
Diff: https://reviews.apache.org/r/39420/diff/
Testing
---
Tested with python 2.7.
- with and without '-p'.
- Tested reviews with and without parents.
Thanks,
Artem Harutyunyan
/apply-review.sh 6391451542e9e8847ec38e2ad9d9acf552afead3
support/apply-reviews.py PRE-CREATION
Diff: https://reviews.apache.org/r/39420/diff/
Testing
---
Tested with python 2.7.
- with and without '-p'.
- Tested reviews with and without parents.
Thanks,
Artem Harutyunyan
PRE-CREATION
Diff: https://reviews.apache.org/r/39410/diff/
Testing
---
Tested with python 2.7
Thanks,
Artem Harutyunyan
://reviews.apache.org/r/38883/diff/
Testing
---
Tested the script with python 2.7.
Thanks,
Artem Harutyunyan
://reviews.apache.org/r/38705/diff/
Testing
---
Tested the script with python 2.7.
Thanks,
Artem Harutyunyan
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39410/#review104831
---
On Oct. 30, 2015, 1:55 a.m., Artem Harutyunyan wrote:
>
> ---
/apply-review.sh 6391451542e9e8847ec38e2ad9d9acf552afead3
support/apply-reviews.py PRE-CREATION
Diff: https://reviews.apache.org/r/39420/diff/
Testing
---
Tested with python 2.7.
- with and without '-p'.
- Tested reviews with and without parents.
Thanks,
Artem Harutyunyan
://reviews.apache.org/r/38883/diff/
Testing
---
Tested the script with python 2.7.
Thanks,
Artem Harutyunyan
-reviews.py PRE-CREATION
Diff: https://reviews.apache.org/r/39410/diff/
Testing
---
Tested with python 2.7
Thanks,
Artem Harutyunyan
://reviews.apache.org/r/38883/diff/
Testing
---
Tested the script with python 2.7.
Thanks,
Artem Harutyunyan
/apply-review.sh 6391451542e9e8847ec38e2ad9d9acf552afead3
support/apply-reviews.py PRE-CREATION
Diff: https://reviews.apache.org/r/39420/diff/
Testing
---
Tested with python 2.7.
- with and without '-p'.
- Tested reviews with and without parents.
Thanks,
Artem Harutyunyan
, however the Linux launcher fails because the file system is not mounted.
Thanks,
Artem Harutyunyan
://reviews.apache.org/r/39841/diff/
Testing
---
Thanks,
Artem Harutyunyan
8014eea999cf4e63dde01921
>
> Diff: https://reviews.apache.org/r/39604/diff/
>
>
> Testing
> ---
>
> - Ran Mesoss tests in a Docker container where cgroup was not available.
> - Ran the new Jenkins script (https://reviews.apache.org/r/37787/).
>
>
> Thanks,
>
> Artem Harutyunyan
>
>
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38883/#review104106
---
On Oct. 30, 2015, 1:54 a.m., Artem Harutyunyan wrote:
>
> -
-reviews.py PRE-CREATION
Diff: https://reviews.apache.org/r/39410/diff/
Testing
---
Tested with python 2.7
Thanks,
Artem Harutyunyan
/apply-review.sh 6391451542e9e8847ec38e2ad9d9acf552afead3
support/apply-reviews.py PRE-CREATION
Diff: https://reviews.apache.org/r/39420/diff/
Testing
---
Tested with python 2.7.
- with and without '-p'.
- Tested reviews with and without parents.
Thanks,
Artem Harutyunyan
Diff: https://reviews.apache.org/r/38883/diff/
Testing
---
Tested the script with python 2.7.
Thanks,
Artem Harutyunyan
reply, visit:
https://reviews.apache.org/r/39604/#review104064
-------
On Oct. 23, 2015, 4:48 p.m., Artem Harutyunyan wrote:
>
> ---
> This is an automatically generated e-ma
://reviews.apache.org/r/38705/diff/
Testing
---
Tested the script with python 2.7.
Thanks,
Artem Harutyunyan
: https://reviews.apache.org/r/38883/diff/
Testing
---
Tested the script with python 2.7.
Thanks,
Artem Harutyunyan
.apache.org/r/38883/#review104106
---
On Oct. 28, 2015, 3:01 p.m., Artem Harutyunyan wrote:
>
> ---
> This is an automatically generated e-mail. To reply, v
/apply-review.sh 6391451542e9e8847ec38e2ad9d9acf552afead3
support/apply-reviews.py PRE-CREATION
Diff: https://reviews.apache.org/r/39420/diff/
Testing
---
Tested with python 2.7.
- with and without '-p'.
- Tested reviews with and without parents.
Thanks,
Artem Harutyunyan
/apply-reviews.py PRE-CREATION
Diff: https://reviews.apache.org/r/39410/diff/
Testing
---
Tested with python 2.7
Thanks,
Artem Harutyunyan
200>
s/guarantee/a guarantee/
It'd be great to expand this comment a bit and describe what the gurantee
represents.
- Artem Harutyunyan
On Oct. 23, 2015, 9:38 a.m., Alexander Rukletsov wrote:
>
> ---
> This is an au
visit:
https://reviews.apache.org/r/39604/#review103823
-------
On Oct. 23, 2015, 11:50 a.m., Artem Harutyunyan wrote:
>
> ---
> This is an automatically generat
/
Testing
---
- Ran Mesoss tests in a Docker container where cgroup was not available.
- Ran the new Jenkins script (https://reviews.apache.org/r/37787/).
Thanks,
Artem Harutyunyan
/apply-review.sh 6391451542e9e8847ec38e2ad9d9acf552afead3
support/apply-reviews.py PRE-CREATION
Diff: https://reviews.apache.org/r/39420/diff/
Testing
---
Tested with python 2.7.
- with and without '-p'.
- Tested reviews with and without parents.
Thanks,
Artem Harutyunyan
(updated)
-
support/apply-review.sh 6391451542e9e8847ec38e2ad9d9acf552afead3
support/apply-reviews.py PRE-CREATION
Diff: https://reviews.apache.org/r/39420/diff/
Testing
---
Tested with python 2.7.
- with and without '-p'.
- Tested reviews with and without parents.
Thanks,
Artem
t; > Python being able to use single and double quotes interchangeably (or even
> > use """ if you really want to be hip :)
>
> Artem Harutyunyan wrote:
> I actually do need to escape the quotes becasue {message} is multiline
> and I am executing the `cmd` in a
://reviews.apache.org/r/38883/diff/
Testing
---
Tested the script with python 2.7.
Thanks,
Artem Harutyunyan
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39420/#review103729
---
On Oct. 22, 2015, 11:58 p.m., Artem Harutyunyan wrote:
>
> --
> On Oct. 19, 2015, 10:06 p.m., Marco Massenzio wrote:
> > support/apply-reviews.py, lines 277-282
> > <https://reviews.apache.org/r/39410/diff/3/?file=1100642#file1100642line277>
> >
> > this code look familiar and I remember already commenting about
> &
To reply, visit:
https://reviews.apache.org/r/38705/#review103656
-------
On Oct. 22, 2015, 11:16 p.m., Artem Harutyunyan wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38705/
&
d1fc5a460e7313828014eea999cf4e63dde01921
Diff: https://reviews.apache.org/r/39604/diff/
Testing
---
- Ran Mesoss tests in a Docker container where cgroup was not available.
- Ran the new Jenkins script (https://reviews.apache.org/r/37787/).
Thanks,
Artem Harutyunyan
sets the value of the missing option to `None`.
- Artem
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39410/#review103731
---------
-reviews.py PRE-CREATION
Diff: https://reviews.apache.org/r/39410/diff/
Testing
---
Tested with python 2.7
Thanks,
Artem Harutyunyan
/mesos/containerizer.cpp
d1fc5a460e7313828014eea999cf4e63dde01921
Diff: https://reviews.apache.org/r/39604/diff/
Testing
---
- Ran Mesoss tests in a Docker container where cgroup was not available.
- Ran the new Jenkins script (https://reviews.apache.org/r/37787/).
Thanks,
Artem
,
Artem Harutyunyan
/diff/
Testing
---
- Ran Mesoss tests in a Docker container where cgroup was not available.
- Ran the new Jenkins script (https://reviews.apache.org/r/37787/).
Thanks,
Artem Harutyunyan
://reviews.apache.org/r/39604/diff/
Testing
---
- Ran Mesoss tests in a Docker container where cgroup was not available.
- Ran the new Jenkins script (https://reviews.apache.org/r/37787/).
Thanks,
Artem Harutyunyan
--enable-libevent'
./jenkins_build_docker.sh`
Working integration with Jenkins:
https://builds.apache.org/view/All/job/Mesos%20new%20jenkins/15/
Thanks,
Artem Harutyunyan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39420/#review103312
---
On Oct. 20, 2015, 11:04 p.m., Artem Harutyunyan wrote:
>
> --
/apply-review.sh 6391451542e9e8847ec38e2ad9d9acf552afead3
support/apply-reviews.py PRE-CREATION
Diff: https://reviews.apache.org/r/39420/diff/
Testing
---
Tested with python 2.7.
- with and without '-p'.
- Tested reviews with and without parents.
Thanks,
Artem Harutyunyan
-reviews.py PRE-CREATION
Diff: https://reviews.apache.org/r/39410/diff/
Testing
---
Tested with python 2.7
Thanks,
Artem Harutyunyan
;
> >
> > this code look familiar and I remember already commenting about
> > `applied` :)
Yep, it used to be a `dict`, and I changed it to a `set`. Did I miss anything?
- Artem
---
This is an automatically generated
://reviews.apache.org/r/38705/diff/
Testing
---
Tested the script with python 2.7.
Thanks,
Artem Harutyunyan
://reviews.apache.org/r/38883/diff/
Testing
---
Tested the script with python 2.7.
Thanks,
Artem Harutyunyan
/apply-review.sh 6391451542e9e8847ec38e2ad9d9acf552afead3
support/apply-reviews.py PRE-CREATION
Diff: https://reviews.apache.org/r/39420/diff/
Testing
---
Tested with python 2.7.
- with and without '-p'.
- Tested reviews with and without parents.
Thanks,
Artem Harutyunyan
PRE-CREATION
Diff: https://reviews.apache.org/r/39410/diff/
Testing
---
Tested with python 2.7
Thanks,
Artem Harutyunyan
: https://reviews.apache.org/r/39194/diff/
Testing
---
Thanks,
Artem Harutyunyan
315
-----------
On Oct. 20, 2015, 1:51 p.m., Artem Harutyunyan wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39194/
: https://reviews.apache.org/r/39194/diff/
Testing
---
Thanks,
Artem Harutyunyan
: https://reviews.apache.org/r/39194/diff/
Testing
---
Thanks,
Artem Harutyunyan
://reviews.apache.org/r/39194/diff/
Testing
---
Thanks,
Artem Harutyunyan
uses.
- Artem
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39420/#review103056
---
On Oct. 17, 2015, 7:43 p.m., Artem Ha
)
-
support/apply-review.sh 6391451542e9e8847ec38e2ad9d9acf552afead3
support/apply-reviews.py PRE-CREATION
Diff: https://reviews.apache.org/r/39420/diff/
Testing
---
Tested with python 2.7.
- with and without '-p'.
- Tested reviews with and without parents.
Thanks,
Artem Harutyunyan
.apache.org/r/39420/#review103056
---
On Oct. 18, 2015, 3:33 p.m., Artem Harutyunyan wrote:
>
> ---
> This is an automatically generated e-mail. To reply, v
://reviews.apache.org/r/38883/diff/
Testing
---
Tested the script with python 2.7.
Thanks,
Artem Harutyunyan
-reviews.py PRE-CREATION
Diff: https://reviews.apache.org/r/39410/diff/
Testing
---
Tested with python 2.7
Thanks,
Artem Harutyunyan
://reviews.apache.org/r/38705/diff/
Testing
---
Tested the script with python 2.7.
Thanks,
Artem Harutyunyan
:).
- Artem Harutyunyan
On Oct. 15, 2015, 11:50 p.m., Artem Harutyunyan wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
quot;" blah blah
> >
> > @param options: these are the fuz bits that god the baz, in a map
> > that can contain the following keys: [`dry_run`, `verbose`, `bitz`] and if
> > not specified assumes `dry_run` to be False.
> >
://reviews.apache.org/r/38883/diff/
Testing
---
Tested the script with python 2.7.
Thanks,
Artem Harutyunyan
; ```
> > print("Applying review {}: {}".format(review_id, summary))
> > ```
> > (same also below to build `cmd`)
I am not sure whether we should use python 3. Other python scripts in Mesos
repo seem to be written for 2.x versions, so I'd like to stay consistent.
- Artem
-
://reviews.apache.org/r/38705/diff/
Testing
---
Tested the script with python 2.7.
Thanks,
Artem Harutyunyan
: https://reviews.apache.org/r/38883/diff/
Testing
---
Tested the script with python 2.7.
Thanks,
Artem Harutyunyan
---
Tested with python 2.7
Thanks,
Artem Harutyunyan
g/r/39325/#comment160450>
micro-nit: period is missing.
- Artem Harutyunyan
On Oct. 14, 2015, 11:33 a.m., Neil Conway wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
(lines 62 - 64)
<https://reviews.apache.org/r/39076/#comment160034>
micro-nit: shall the values be aligned here and below (in the else branch)?
- Artem Harutyunyan
On Oct. 12, 2015, 10:51 a.m., Alex Clemmer
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39092/#review102405
---
LGTM.
- Artem Harutyunyan
On Oct. 7, 2015, 9 a.m., Alex Clemmer
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39091/#review102404
---
LGTM.
- Artem Harutyunyan
On Oct. 7, 2015, 9 a.m., Alex Clemmer
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39093/#review102458
---
LGTM.
- Artem Harutyunyan
On Oct. 12, 2015, 12:41 p.m., Alex
tps://reviews.apache.org/r/39096/#comment160240>
Is the actuall example missing here?
LGTM.
- Artem Harutyunyan
On Oct. 13, 2015, 11:26 a.m., Alex Clemmer wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39097/#review102549
---
LGTM.
- Artem Harutyunyan
On Oct. 13, 2015, 11:26 a.m., Alex
/open.hpp (lines 50 - 52)
<https://reviews.apache.org/r/39180/#comment160264>
It'd be great to clarify this comment (discussed offline with Alex).
- Artem Harutyunyan
On Oct. 13, 2015, 11:26 a.m., Alex Clemmer
---
Thanks,
Artem Harutyunyan
ges (including the ones you proposed in the email
on dev@ list).
- Artem
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39194/#review102126
----------
/
Testing
---
Tested the script with python 2.7.
Thanks,
Artem Harutyunyan
justify your reasoning?
- Artem
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38705/#review101225
---
On Sept. 29, 2015, 11
://reviews.apache.org/r/38883/diff/
Testing
---
Tested the script with python 2.7.
Thanks,
Artem Harutyunyan
.
Thanks,
Artem Harutyunyan
://reviews.apache.org/r/38705/diff/
Testing (updated)
---
Tested the script with python 2.7.
Thanks,
Artem Harutyunyan
(updated)
---
Tested the script with python 2.7.
Thanks,
Artem Harutyunyan
101 - 200 of 334 matches
Mail list logo
