Re: Review Request 73136: Added support for multiple event loop / IO threads for libev.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73136/#review222515 --- Ship it! Ship It! - Ilya Pronin On Jan. 21, 2021, 10:51 a.m

Re: Review Request 73136: Added support for multiple event loop / IO threads for libev.

> On Jan. 19, 2021, 4:17 p.m., Ilya Pronin wrote: > > 3rdparty/libprocess/src/posix/libev/libev.hpp > > Line 30 (original), 30 (patched) > > <https://reviews.apache.org/r/73136/diff/1/?file=2244173#file2244173line30> > > > > Why don't we use a `std::v

Re: Review Request 73136: Added support for multiple event loop / IO threads for libev.

unction-definition-invocation 3rdparty/libprocess/src/posix/libev/libev.cpp Lines 185-186 (original), 257-258 (patched) <https://reviews.apache.org/r/73136/#comment311601> Should we reduce the number of libprocess actor threads by the number of additional IO threads we spawn here? -

Re: Review Request 73137: Avoid using the libev default loop.

<https://reviews.apache.org/r/73137/#comment311539> Move this closer to the `loop` declaration? 3rdparty/libprocess/src/posix/libev/libev.cpp Lines 200 (patched) <https://reviews.apache.org/r/73137/#comment311540> Seems unnecessary. - Ilya Pronin On Jan. 12, 2021, 11:22 a.m., Ben

Re: Review Request 73131: Fixed agent reregistration and marking as unreachable race.

/master_tests.cpp cd0973ed4cc8fc33de714d59c7680aef05b97b47 Diff: https://reviews.apache.org/r/73131/diff/3/ Changes: https://reviews.apache.org/r/73131/diff/2-3/ Testing --- Ran `make check`. Verified that the new test crashes without the fix. Thanks, Ilya Pronin

Re: Review Request 73131: Fixed agent reregistration and marking as unreachable race.

src/tests/master_tests.cpp cd0973ed4cc8fc33de714d59c7680aef05b97b47 Diff: https://reviews.apache.org/r/73131/diff/2/ Changes: https://reviews.apache.org/r/73131/diff/1-2/ Testing --- Ran `make check`. Verified that the new test crashes without the fix. Thanks, Ilya Pronin

Re: Review Request 73131: Fixed agent reregistration and marking as unreachable race.

-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73131/#review222447 --- On Jan. 11, 2021, 5:23 p.m., Ilya Pronin wrote: > > ---

Re: Review Request 73135: Removed unused io watcher queue from libev.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73135/#review222446 --- Ship it! Ship It! - Ilya Pronin On Jan. 12, 2021, 11:21 a.m

Review Request 73131: Fixed agent reregistration and marking as unreachable race.

://reviews.apache.org/r/73131/diff/1/ Testing --- Ran `make check`. Verified that the new test crashes without the fix. Thanks, Ilya Pronin

Re: Review Request 69441: Fixed sandbox creation chmod error handling in the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69441/#review210872 --- Ship it! Ship It! - Ilya Pronin On Nov. 23, 2018, 9:22 p.m

Re: Review Request 69306: Fixed parallel test runner ulimit check for setups without limits.

nerated e-mail. To reply, visit: > https://reviews.apache.org/r/69306/ > --- > > (Updated Nov. 9, 2018, 1:53 p.m.) > > > Review request for mesos, Benjamin Mahler and Ilya Pronin. > > > Bugs: MESOS-9382 &

Re: Review Request 69306: Fixed parallel test runner ulimit check for setups without limits.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69306/#review210444 --- Ship it! Ship It! - Ilya Pronin On Nov. 9, 2018, 1:53 p.m

Re: Review Request 69149: Automatically remounted read-only bind mounts.

0 (patched) <https://reviews.apache.org/r/69149/#comment294743> Delete the old line with `MS_BIND`. src/linux/fs.cpp Line 752 (original), 747-748 (patched) <https://reviews.apache.org/r/69149/#comment294744> Ditto. - Ilya Pronin On Oct. 24, 2018, 4:49 p

Re: Review Request 69132: Used mount(8) to make XFS loop device mounts.

format( "mount -t xfs%s %s %s", mountOptions.isNone() ? " " : " -o " + mountOptions.get(), loopDevice.get(), mntPath); ``` - Ilya Pronin On Oct. 23, 2018, 4:17 p.m., James Peach wrote: > >

Re: Review Request 68999: Fixed the XFS project ID labeling to not cross mount points.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68999/#review209567 --- Ship it! Nice trick! LGTM. - Ilya Pronin On Oct. 11, 2018

Re: Review Request 68402: Added a test for XFS persistent volume isolation.

g/r/68402/#comment293328> Ditto, our device file is 40MB. - Ilya Pronin On Sept. 24, 2018, 1:15 p.m., James Peach wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 68401: Added persistent volume support to the `disk/xfs` isolator.

volume quota. - Ilya Pronin On Sept. 24, 2018, 9:58 a.m., James Peach wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 68404: Updated XFS recovery tests with persistent volumes.

- > > (Updated Aug. 16, 2018, 4:52 p.m.) > > > Review request for mesos, Chun-Hung Hsiao, Ilya Pronin, Jie Yu, Joseph Wu, > and Jiang Yan Xu. > > > Bugs: MESOS-5158 > https://issues.apache.org/jira/browse/MESOS-5158 > > > Repository: mesos

Re: Review Request 68404: Updated XFS recovery tests with persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68404/#review208820 --- Ship it! Ship It! - Ilya Pronin On Aug. 16, 2018, 4:52 p.m

Re: Review Request 68403: Updated tests for XFS disk resource statistics.

eviews.apache.org/r/68403/#comment293030> Ditto, move the call closer to where its result is used. - Ilya Pronin On Aug. 16, 2018, 4:52 p.m., James Peach wrote: > > --- > This is an automatically generated e

Re: Review Request 68402: Added a test for XFS persistent volume isolation.

--- > > (Updated Aug. 16, 2018, 4:52 p.m.) > > > Review request for mesos, Chun-Hung Hsiao, Ilya Pronin, Jie Yu, Joseph Wu, > and Jiang Yan Xu. > > > Bugs: MESOS-5158 > https://issues.apache.org/jira/browse/MESOS-5158 > > >

Re: Review Request 68401: Added persistent volume support to the `disk/xfs` isolator.

nes 438-440 (original), 609-611 (patched) <https://reviews.apache.org/r/68401/#comment292974> Add which quota, i.e. sandbox/volume? - Ilya Pronin On Sept. 10, 2018, 2:34 p.m., James Peach wrote: > > --- > This

Review Request 68769: Fixed rtnl_act leak in routing::filter::internal::attach().

--- Tested with Valgrind Memcheck. Ran `sudo make check`. Thanks, Ilya Pronin

Re: Review Request 68400: Exposed an XFS helper to find the block device for a given path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68400/#review208010 --- Ship it! Ship It! - Ilya Pronin On Aug. 24, 2018, 4:25 p.m

Re: Review Request 68399: Exposed a helper to access for the agent persistent volumes directories.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68399/#review208008 --- Ship it! Ship It! - Ilya Pronin On Aug. 24, 2018, 4:24 p.m

Re: Review Request 68398: Added `fs::used` helper API to stout.

test. 3rdparty/stout/tests/os_tests.cpp Lines 1157-1164 (patched) <https://reviews.apache.org/r/68398/#comment291726> What if current directory is a different partition than `/`? - Ilya Pronin On Aug. 24, 2018, 4:24 p.m., James Peach

Review Request 68090: Added log_auto_compact flag to the master.

storage doesn't grow over time with `--log_auto_compact=true`. Thanks, Ilya Pronin

Review Request 68089: Added LevelDB compaction after replicated log truncation.

Diff: https://reviews.apache.org/r/68089/diff/1/ Testing --- Updated `LogStorageTest` cases to run with and without compaction enabled. Ran `make check`. Thanks, Ilya Pronin

Re: Review Request 67914: Updated XFS disk isolator to reclaim project IDs after disk GC.

is reclaimed and reused after sandbox GC. Ran `sudo make check`. Thanks, Ilya Pronin

Re: Review Request 68029: Updated XFS disk isolator docs.

e2063343line50> > > > > Can you document these in docs/monitoring.md as well? Done. - Ilya --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68029/#review206396 ---

Re: Review Request 68029: Updated XFS disk isolator docs.

96bb39ec51bfdc4b297099baf1a4cef3efe2c92f docs/monitoring.md 2f06e9b7b05d9cd3f447cbd3eab43bc493e25cd1 Diff: https://reviews.apache.org/r/68029/diff/3/ Changes: https://reviews.apache.org/r/68029/diff/2-3/ Testing --- N/A. Thanks, Ilya Pronin

Re: Review Request 68029: Updated XFS disk isolator docs.

Diff: https://reviews.apache.org/r/68029/diff/2/ Changes: https://reviews.apache.org/r/68029/diff/1-2/ Testing --- N/A. Thanks, Ilya Pronin

Review Request 68029: Updated XFS disk isolator docs.

, Ilya Pronin

Re: Review Request 67914: Updated XFS disk isolator to reclaim project IDs after disk GC.

use > > `container_disk_watch_interval` or `disk_watch_interval` ... probably the > > former? > > Ilya Pronin wrote: > I think if we do this then we should rather use the latter because disk > GC is driven by `disk_watch_interval` and `gc_delay` (maybe use which one of > those 2 i

Re: Review Request 67914: Updated XFS disk isolator to reclaim project IDs after disk GC.

-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67914/#review206351 --- On July 23, 2018, 4:21 p.m., Ilya Pronin wrote: > > ---

Re: Review Request 67914: Updated XFS disk isolator to reclaim project IDs after disk GC.

Test.ProjectIDReclaiming` test that verifies that project ID is reclaimed and reused after sandbox GC. Ran `sudo make check`. Thanks, Ilya Pronin

Re: Review Request 67914: Updated XFS disk isolator to reclaim project IDs after disk GC.

you add an explanatory comment? Done. > On July 18, 2018, 1:51 p.m., James Peach wrote: > > src/tests/containerizer/xfs_quota_tests.cpp > > Lines 1333 (patched) > > <https://reviews.apache.org/r/67914/diff/2/?file=2059410#file2059410line1333> > > >

Re: Review Request 67914: Updated XFS disk isolator to reclaim project IDs after disk GC.

--- Added `ROOT_XFS_QuotaTest.ProjectIDReclaiming` test that verifies that project ID is reclaimed and reused after sandbox GC. Ran `sudo make check`. Thanks, Ilya Pronin

Re: Review Request 67931: Support Image Manifest Version 2 Schema 2.

that added V2 Schema 2 manifest support here: https://issues.apache.org/jira/browse/MESOS-6934. Just in case it may be helpful in any way :) - Ilya Pronin On July 18, 2018, 2:27 a.m., Liangyu Zhao wrote: > > --- > This is an auto

Re: Review Request 67936: Fixed ephemeral ports deallocation in network/port_mapping isolator.

-------- On July 17, 2018, 1:12 p.m., Ilya Pronin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67936/ > -

Re: Review Request 67936: Fixed ephemeral ports deallocation in network/port_mapping isolator.

deallocated when the container was not isolated and manually checked that if fails without the fix. Ran `sudo make check`. Thanks, Ilya Pronin

Review Request 67936: Fixed ephemeral ports deallocation in network/port_mapping isolator.

://reviews.apache.org/r/67936/diff/1/ Testing --- Added `PortMappingIsolatorTest.ROOT_CleanupNotIsolated` test to verify that ephemeral ports are properly deallocated when the container was not isolated and manually checked that if fails without the fix. Ran `sudo make check`. Thanks, Ilya Pronin

Re: Review Request 67914: Updated XFS disk isolator to reclaim project IDs after disk GC.

://reviews.apache.org/r/67914/diff/2/ Changes: https://reviews.apache.org/r/67914/diff/1-2/ Testing --- Added `ROOT_XFS_QuotaTest.ProjectIDReclaiming` test that verifies that project ID is reclaimed and reused after sandbox GC. Ran `sudo make check`. Thanks, Ilya Pronin

Review Request 67915: Factored out ROOT_XFS_TestBase::getSandboxes().

--- Factored out ROOT_XFS_TestBase::getSandboxes(). Diffs - src/tests/containerizer/xfs_quota_tests.cpp bee0c2db7adc1dc7d774f9152931130093fe5b50 Diff: https://reviews.apache.org/r/67915/diff/1/ Testing --- Ran `sudo make check`. Thanks, Ilya Pronin

Review Request 67914: Updated XFS disk isolator to reclaim project IDs after disk GC.

`ROOT_XFS_QuotaTest.ProjectIDReclaiming` test that verifies that project ID is reclaimed and reused after sandbox GC. Ran `sudo make check`. Thanks, Ilya Pronin

Re: Review Request 67820: Fixed recover() virtual method signature in several isolators.

--- On July 5, 2018, 2:31 p.m., Ilya Pronin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67820/ > --- >

Re: Review Request 67820: Fixed recover() virtual method signature in several isolators.

.apache.org/r/67820/#review205716 --- On July 5, 2018, 2:31 p.m., Ilya Pronin wrote: > > --- > This is an automatically generated e-mail. To reply, v

Re: Review Request 67821: Added override specifiers to virtual methods of several isolators.

Mesos with `--enable-xfs-disk-isolator` and ran `sudo make check`. Thanks, Ilya Pronin

Re: Review Request 67820: Fixed recover() virtual method signature in several isolators.

en because of the issue, passed. Thanks, Ilya Pronin

Review Request 67821: Added override specifiers to XfsDiskIsolatorProcess methods.

-disk-isolator` and ran `sudo make check`. Thanks, Ilya Pronin

Review Request 67820: Fixed XfsDiskIsolatorProcess::recover() signature.

make check`. `ROOT_XFS_QuotaTest.NoCheckpointRecovery` test, that was broken because of the issue, passed. Thanks, Ilya Pronin

Re: Review Request 67354: Removed `os::getenv()` calls from `MesosExecutorDriver`.

--- > > (Updated May 29, 2018, 7:20 a.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Bannier, haosdent > huang, Ilya Pronin, and James Peach. > > > Bugs: MESOS-3475 > https://issues.apache.org/jira/browse/MESOS-3475 > > > Rep

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

sion (AFAIK it doesn't work like that, though I may be wrong)? - Ilya Pronin On April 4, 2018, 10:41 a.m., Harold Dost wrote: > > --- > This is an automatically generated e-mail. To reply, v

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

> On March 27, 2018, 9:35 a.m., James Peach wrote: > > src/slave/containerizer/mesos/isolators/xfs/disk.cpp > > Lines 420 (patched) > > > > > > It's unfortunately verbose, but we should do this: > > > >

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

rg/r/66001/#comment280999> Keep this newline. src/slave/containerizer/mesos/isolators/xfs/utils.hpp Line 105 (original), 108-110 (patched) <https://reviews.apache.org/r/66001/#comment281000> Add 1 more newline between the proto

Review Request 66030: Fixed perf stat output parsing.

/containerizer/perf_tests.cpp 7176240bd9caff1efc8b213fe7ae7faae59c0e3e Diff: https://reviews.apache.org/r/66030/diff/1/ Testing --- Added new test cases. Ran `sudo make check`. Thanks, Ilya Pronin

Re: Review Request 64630: Narrowed task sandbox permissions from 0755 to 0750.

- > > (Updated Dec. 14, 2017, 4:10 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Ilya Pronin, Jie Yu, and > Vinod Kone. > > > Bugs: MESOS-8332 > https://issues.apache.org/jira/browse/MESOS-8332 > > > Repository: mesos > >

Re: Review Request 64630: Narrowed task sandbox permissions from 0755 to 0750.

.org/r/64630/#comment273998> Misleading naming. Maybe we can create a function like "create, set mode and own" and call it from here and from `createSandboxDirectory()`? src/slave/paths.cpp Lines 763 (patched) <https://reviews.apache.org/r/64630/#comment273999> No error chec

Re: Review Request 64940: Prevented a crash when an agent with terminal tasks is lost.

you pause the clock here? To speed up the test (i.e. not wait for `allocation_interval`)? - Ilya Pronin On Jan. 3, 2018, 5:35 p.m., James Peach wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > ht

Re: Review Request 64939: Abort libprocess when a Process throws an uncaught exception.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64939/#review194733 --- Ship it! Ship It! - Ilya Pronin On Jan. 3, 2018, 5:30 p.m

Review Request 64938: Fixed RecoverTest.CatchupTruncated test flakiness.

only owner of the replica. Diffs - src/tests/log_tests.cpp 7554a1e281323222d3be12aa1ec6fd809799ff65 Diff: https://reviews.apache.org/r/64938/diff/1/ Testing --- Ran `./src/mesos-tests --gtest_filter='RecoverTest.CatchupTruncated' --gtest_repeat=1000 --gtest_break_on_failure=1`. Tha

Review Request 64923: Added replicated log reader catch-up section to the upgrades doc.

on GitHub: https://github.com/ipronin/mesos/blob/log-replica-catchup-docs/docs/upgrades.md Thanks, Ilya Pronin

Review Request 64922: Added VOTING replica catch-up section to replicated log docs.

--- Verified on GitHub: https://github.com/ipronin/mesos/blob/log-replica-catchup-docs/docs/replicated-log-internals.md Thanks, Ilya Pronin

Review Request 64921: Fixed a typo and formatting in docs.

://github.com/ipronin/mesos/blob/log-replica-catchup-docs/docs/replicated-log-internals.md Thanks, Ilya Pronin

Re: Review Request 64626: Prototype: Added LIBPROCESS_LOCAL_MESSAGE_PASSING option.

h `tcpdump`. Thanks, Ilya Pronin

Review Request 64626: Prototype: Added LIBPROCESS_LOCAL_MESSAGE_PASSING option.

torProcess::checkLearnPhase()](https://github.com/apache/mesos/blob/784b7f599f8ad8350fc7d6703a4b584301b23edc/src/log/coordinator.cpp#L396)). Thanks, Ilya Pronin

Re: Review Request 64098: Send status updates when agent re-registers.

> On Dec. 7, 2017, 1:36 p.m., Ilya Pronin wrote: > > src/tests/master_tests.cpp > > Lines 7477 (patched) > > <https://reviews.apache.org/r/64098/diff/11/?file=1908759#file1908759line7499> > > > > Ditto re replicated log based registry. > > Megha

Re: Review Request 64098: Send status updates when agent re-registers.

tched) <https://reviews.apache.org/r/64098/#comment271671> Ditto re replicated log based registry. src/tests/upgrade_tests.cpp Lines 106 (patched) <https://reviews.apache.org/r/64098/#comment271672> Ditto re replicated log based registry. - Ilya P

Re: Review Request 64098: Send status updates when agent re-registers.

> This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64098/ > ------- > > (Updated Dec. 1, 2017, 4:29 p.m.) > > > Review request for mesos, Ilya Pronin, James Peach, and Jiang Yan

Re: Review Request 64250: Added new reasons task status update.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64250/#review192600 --- Ship it! Ship It! - Ilya Pronin On Dec. 1, 2017, 1:06 p.m

Re: Review Request 64250: Added new reasons task status update.

> On Dec. 1, 2017, 1:55 p.m., Ilya Pronin wrote: > > docs/task-state-reasons.md > > Lines 474-477 (patched) > > <https://reviews.apache.org/r/64250/diff/2/?file=1906002#file1906002line474> > > > > I don't quite follow this note. A modified copy o

Re: Review Request 64250: Added new reasons task status update.

--- > > (Updated Dec. 1, 2017, 1:06 p.m.) > > > Review request for mesos, Ilya Pronin, James Peach, and Jiang Yan Xu. > > > Repository: mesos > > > Description > --- > > Added new reasons `REASON_SLAVE_REREGISTERED` and > `REASON_AGEN

Re: Review Request 64217: Added scheduler driver benchmarks.

-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64217/#review192386 ------- On Nov. 30, 2017, 10:03 a.m., Ilya Pronin wrote: > > -

Re: Review Request 59294: Optionally scale egress bandwidth with CPU.

gged. Should be `flags.minimum_egress_rate_limit`. - Ilya Pronin On July 24, 2017, 11:36 a.m., Ian Downes wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 64217: Added scheduler driver benchmarks.

d4f1af4f072efdc68fa0b722f42b1d8aa1779b6e src/examples/test_scheduler_driver_bench.cpp PRE-CREATION src/examples/test_scheduler_v1_bench.cpp PRE-CREATION Diff: https://reviews.apache.org/r/64217/diff/1/ Testing --- Verified manually by launching a master and runninng benchmarks. Thanks, Ilya Pronin

Review Request 64217: Added scheduler driver benchmarks.

/test_scheduler_driver_bench.cpp PRE-CREATION src/examples/test_scheduler_v1_bench.cpp PRE-CREATION Diff: https://reviews.apache.org/r/64217/diff/1/ Testing --- Verified manually by launching a master and runninng benchmarks. Thanks, Ilya Pronin

Re: Review Request 64098: Send status updates when agent re-registers.

gt; > and use it? > > > > Note that the tag numbers in the proto enum need to match. > > > > Also note that there are also documentation related changes for these > > fields: > > https://github.com/apache/mesos/blob/master/docs/task-state-reasons.md

Re: Review Request 64098: Send status updates when agent re-registers.

iews.apache.org/r/64098/#review192041 --- On Nov. 27, 2017, 4:55 p.m., Megha Sharma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64098/ &

Re: Review Request 61473: Do not kill non partition aware tasks.

> On Nov. 28, 2017, 12:46 a.m., Jiang Yan Xu wrote: > > src/master/master.cpp > > Line 9370 (original), 9322 (patched) > > > > > > I have the similar feeling as Ilya, without context it's hard to > > understand

Re: Review Request 64098: Send status updates when agent re-registers.

uld we just ignore this status update here? It doesn't seem related to the thing under test. src/tests/upgrade_tests.cpp Lines 219-221 (patched) <https://reviews.apache.org/r/64098/#comment270033> Ditto, should we just ignore this status update since it's not related to the thing test?

Re: Review Request 61473: Do not kill non partition aware tasks.

> On Nov. 27, 2017, 4:25 p.m., Ilya Pronin wrote: > > src/master/master.cpp > > Line 9370 (original), 9322 (patched) > > <https://reviews.apache.org/r/61473/diff/20/?file=1902101#file1902101line9370> > > > > I would suggest moving this c

Re: Review Request 61473: Do not kill non partition aware tasks.

10271-10272 (patched) <https://reviews.apache.org/r/61473/#comment269912> Is there any reason not to iterate like this? ```cpp foreachvalue (const Owned& task, framework->unreachableTasks) { // ... } ``` - Ilya Pronin On Nov

Re: Review Request 63527: Added MESOS-8165 to the 1.5.0 CHANGELOG.

://reviews.apache.org/r/63527/diff/2/ Changes: https://reviews.apache.org/r/63527/diff/1-2/ Testing --- N/A Thanks, Ilya Pronin

Re: Review Request 63526: Fixed TASK_UNKNOWN status ambiguity.

-2/ Testing --- Adjusted existing tests. Ran `make check`. Thanks, Ilya Pronin

Re: Review Request 63527: Added MESOS-8165 to the 1.5.0 CHANGELOG.

e.c > > Microsoft (R) C/C++ Optimizing Compiler Version 19.10.25019 for x64 > > Copyright (C) Microsoft Corporation. All rights reserved. > > > > cl /c /Zi /W3 /WX- /diagnostics:classic /MP /Od /Ob0 /D WIN32 /D _WINDOWS > > /D UNICODE

Review Request 63526: Fixed TASK_UNKNOWN status ambiguity.

7b11264718b1ab7edbe594335a1f8130bef0236d src/tests/reconciliation_tests.cpp 8ae2860591afc8eec04b7c23322cd7dd964bbcb3 Diff: https://reviews.apache.org/r/63526/diff/1/ Testing --- Adjusted existing tests. Ran `make check`. Thanks, Ilya Pronin

Review Request 63527: Added MESOS-8165 to the 1.5.0 CHANGELOG.

://issues.apache.org/jira/browse/MESOS-8165 Repository: mesos Description --- Added MESOS-8165 to the 1.5.0 CHANGELOG. Diffs - CHANGELOG b7bcc98de51b7bcd0c2f5b2e703a5c51af10c2fb Diff: https://reviews.apache.org/r/63527/diff/1/ Testing --- N/A Thanks, Ilya Pronin

Re: Review Request 62241: Added SchedulerHttpApiTest.UpdateHttpToPidSchedulerAndBack test.

> On Oct. 13, 2017, 6:40 p.m., Anand Mazumdar wrote: > > src/tests/scheduler_http_api_tests.cpp > > Lines 737-747 (patched) > > <https://reviews.apache.org/r/62241/diff/1/?file=1820104#file1820104line737> > > > > Kill this? We don't need this to test if

Re: Review Request 62241: Added SchedulerHttpApiTest.UpdateHttpToPidSchedulerAndBack test.

the previous patch. Thanks, Ilya Pronin

Re: Review Request 62241: Added SchedulerHttpApiTest.UpdateHttpToPidSchedulerAndBack test.

s://reviews.apache.org/r/62241/#review188053 --- On Oct. 16, 2017, 11:17 a.m., Ilya Pronin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: &g

Re: Review Request 62241: Added SchedulerHttpApiTest.UpdateHttpToPidSchedulerAndBack test.

without the previous patch. Thanks, Ilya Pronin

Re: Review Request 62959: Added doc for filesystem isolators.

g/r/62959/#comment264989> The isolator link here and below leads to the same section where it is located. - Ilya Pronin On Oct. 12, 2017, 5:06 p.m., Jie Yu wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request 62962: Added doc for cgroups/cpu isolator.

/reviews.apache.org/r/62962/diff/1/?file=1854299#file1854299line48> > > > > that are latency sensitive? Yes :) - Ilya --- This is an automatically generated e-mail. To reply, visit: https://reviews.ap

Re: Review Request 62962: Added doc for cgroups/cpu isolator.

: https://reviews.apache.org/r/62962/diff/2/ Changes: https://reviews.apache.org/r/62962/diff/1-2/ Testing --- Verified on GitHub https://github.com/ipronin/mesos/blob/docathon/docs/isolators/cgroups-cpu.md Thanks, Ilya Pronin

Review Request 62962: Added doc for cgroups/cpu isolator.

://github.com/ipronin/mesos/blob/docathon/docs/isolators/cgroups-cpu.md Thanks, Ilya Pronin

Re: Review Request 62287: Added Log::Reader::catchup() method.

/62287/diff/2/ Testing --- Added a test that verifies that it's possible to catch-up the lagging replica using the `Reader` and successfully read entries that were caught-up. Ran `make check`. Thanks, Ilya Pronin

Re: Review Request 62287: Added Log::Reader::catchup() method.

check`. Thanks, Ilya Pronin

Re: Review Request 62286: Added CatchupMissing log process.

ache.org/r/62286/diff/1/?file=1820908#file1820908line730> > > > > Can you explain why we need to recover the same `begin` after a restart? Discussed offline. - Ilya --- This is an automatically genera

Re: Review Request 62286: Added CatchupMissing log process.

recovery process correctly performs and produces meaningful result under various circumstances (recovered positions were truncated, replica was lagging far behind). Ran `make check`. Thanks, Ilya Pronin

Review Request 62761: Moved retry logic from RecoverProtocolProcess to RecoverProcess.

/log_tests.cpp f9f9400c901152779ae0ebfe74cf8f7aac1d3396 Diff: https://reviews.apache.org/r/62761/diff/1/ Testing --- Added a test that verifies that retry logic is working in `recover()`. Ran `make check`. Thanks, Ilya Pronin

  1   2   3   >