---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71445/#review217699
---
Ship it!
Ship It!
- Jan Schlicht
On Sept. 12, 2019, 11:01
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71453/#review217649
---
Ship it!
Ship It!
- Jan Schlicht
On Sept. 9, 2019, 3:54 p.m
536 (patched)
<https://reviews.apache.org/r/71385/#comment304805>
Should we restart here? Though the future currently won't be set to ready,
it might do that in the future. If a resource provider is exited normally, is
it supposed to be restarted?
- Jan Schlicht
On Aug. 28, 2019,
> On Sept. 3, 2019, 3:02 p.m., Jan Schlicht wrote:
> > src/resource_provider/storage/provider.cpp
> > Line 268 (original), 268 (patched)
> > <https://reviews.apache.org/r/71384/diff/1/?file=2163044#file2163044line268>
> >
> > Let's not use `Failure` he
/provider.cpp
Line 268 (original), 268 (patched)
<https://reviews.apache.org/r/71384/#comment304794>
Let's not use `Failure` here, as this class is meant to represent a failed
future. Use `string` instead.
- Jan Schlicht
On Aug. 28, 2019, 11:12 a.m., Benjamin Bannier
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71383/#review217540
---
Ship it!
Ship It!
- Jan Schlicht
On Aug. 28, 2019, 11:12
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71382/#review217538
---
Ship it!
Ship It!
- Jan Schlicht
On Aug. 28, 2019, 11:12
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71420/#review217527
---
Ship it!
Ship It!
- Jan Schlicht
On Sept. 2, 2019, 10:14
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71419/#review217526
---
Ship it!
Ship It!
- Jan Schlicht
On Sept. 2, 2019, 10:14
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71414/#review217507
---
Ship it!
Ship It!
- Jan Schlicht
On Aug. 30, 2019, 2:48 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71351/#review217396
---
Ship it!
Ship It!
- Jan Schlicht
On Aug. 22, 2019, 3:17 p.m
Line 15 (original), 13 (patched)
<https://reviews.apache.org/r/71350/#comment304681>
s/MESOS_RUNTIME_DIR/MESOS_WORK_DIR/
- Jan Schlicht
On Aug. 22, 2019, 3:17 p.m., Benjamin Bannier wrote:
>
> ---
> This is an automatica
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71341/#review217380
---
Ship it!
Ship It!
- Jan Schlicht
On Aug. 22, 2019, 3:04 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71339/#review217378
---
Ship it!
Ship It!
- Jan Schlicht
On Aug. 21, 2019, 3:22 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71340/#review217377
---
Ship it!
Ship It!
- Jan Schlicht
On Aug. 21, 2019, 3:22 p.m
hpp`.
src/resource_provider/validation.cpp
Lines 98 (patched)
<https://reviews.apache.org/r/71341/#comment304667>
s/provider/resource provider/
- Jan Schlicht
On Aug. 21, 2019, 3:22 p.m., Benjamin Bannier wrote:
>
> ---
> This is
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71200/#review216952
---
Ship it!
Ship It!
- Jan Schlicht
On July 30, 2019, 11:08
/
Testing
---
Build Mesos with `cmake -G Ninja -DCMAKE_BUILD_TYPE=Debug`
Thanks,
Jan Schlicht
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70699/#review215452
---
Ship it!
Ship It!
- Jan Schlicht
On May 22, 2019, 10:14 a.m
---
make check
I could not reproduce the flaky behavior of this test case, hence only assume
that this patch resolves the flakiness.
Thanks,
Jan Schlicht
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70539/#review214846
---
Ship it!
Ship It!
- Jan Schlicht
On April 24, 2019, 9:29
://reviews.apache.org/r/70165/diff/3-4/
Testing
---
make check
Thanks,
Jan Schlicht
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70293/#review213982
---
Ship it!
Ship It!
- Jan Schlicht
On March 25, 2019, 11:58
nager.cpp
Lines 96 (patched)
<https://reviews.apache.org/r/70168/#comment299764>
Remove the `explicit`.
- Jan Schlicht
On March 12, 2019, 7:59 p.m., Chun-Hung Hsiao wrote:
>
> ---
> This is an automatically generated
not reproduce the flaky behavior of this test case, hence only assume
that this patch resolves the flakiness.
Thanks,
Jan Schlicht
://reviews.apache.org/r/70165/diff/2-3/
Testing
---
make check
Thanks,
Jan Schlicht
7d3338ea7fbf330a25416f848db7742ad1bea52f
src/tests/storage_local_resource_provider_tests.cpp
7945384867f26fa15dc734a235ae509d5d6d350f
Diff: https://reviews.apache.org/r/70165/diff/1/
Testing
---
make check
Thanks,
Jan Schlicht
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70154/#review213517
---
Ship it!
Ship It!
- Jan Schlicht
On March 7, 2019, 2:41 p.m
sert `` here?
src/tests/resource_provider_manager_tests.cpp
Lines 19 (patched)
<https://reviews.apache.org/r/69718/#comment297458>
Double `` instead of `` before ``.
- Jan Schlicht
On Jan. 11, 2019, 11:02 a.m., Benj
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69563/#review211396
---
Ship it!
Ship It!
- Jan Schlicht
On Dec. 18, 2018, midnight
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69571/#review211395
---
Ship it!
Ship It!
- Jan Schlicht
On Dec. 17, 2018, 11:58
up::validate(
taskGroup, executor, framework, slave, _offeredResources);
if (error.isSome()) {
reason = TaskStatus::REASON_TASK_GROUP_INVALID;
}
}
```
- Jan Schlicht
On Dec. 17, 2018, 7:29 a.m., Chun-Hung
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69157/#review210540
---
Ship it!
Ship It!
- Jan Schlicht
On Nov. 13, 2018, 10:10
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69160/#review210090
---
Ship it!
Ship It!
- Jan Schlicht
On Oct. 25, 2018, 12:54
(original), 2911-2920 (patched)
<https://reviews.apache.org/r/69159/#comment294728>
Indent with 4 spaces.
- Jan Schlicht
On Oct. 25, 2018, 12:54 p.m., Benjamin Bannier wrote:
>
> ---
> This is an automatically generated e
710 (original), 710 (patched)
<https://reviews.apache.org/r/69041/#comment294239>
Nit: This is redundant.
- Jan Schlicht
On Oct. 16, 2018, 12:23 p.m., Benjamin Bannier wrote:
>
> ---
> This is an automatically g
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69042/#review209686
---
Ship it!
Ship It!
- Jan Schlicht
On Oct. 16, 2018, 12:23
&& cd build
cmake -DENABLE_LIBEVENT=ON -DUNBUNDLED_LIBEVENT=ON -GNinja ..
ninja
Thanks,
Jan Schlicht
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68757/#review208761
---
Ship it!
Ship It!
- Jan Schlicht
On Sept. 19, 2018, 6:49
---
>
> (Updated Sept. 19, 2018, 6:48 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
>
>
> Bugs: MESOS-9228
> https://issues.apache.org/jira/browse/MESOS-9228
>
>
> Repository: mesos
>
>
> Description
&
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68755/#review208758
---
Ship it!
Ship It!
- Jan Schlicht
On Sept. 19, 2018, 6:47
---
Documented 'cquery' support in Sublime Text.
Diffs
-
docs/cquery.md b893bc522561306a2cdf15e1c1876108ec8d329c
Diff: https://reviews.apache.org/r/68668/diff/1/
Testing
---
Previewed the formatted doc.
Thanks,
Jan Schlicht
check
Thanks,
Jan Schlicht
ea391f1d541a42b73c4e91f27b99b79a6908150d
src/tests/slave_tests.cpp 73c481fa9d5e87a0df935df1e9ff427ca985a1a6
Diff: https://reviews.apache.org/r/68276/diff/1/
Testing
---
make check
Thanks,
Jan Schlicht
28a854fb96443ea13afbd034dc6d20bfbce1fec1
Diff: https://reviews.apache.org/r/68030/diff/2/
Changes: https://reviews.apache.org/r/68030/diff/1-2/
Testing
---
make check
Thanks,
Jan Schlicht
Thanks,
Jan Schlicht
ts.cpp
Line 1921 (original), 1860 (patched)
<https://reviews.apache.org/r/67864/#comment289012>
s/target/source/
- Jan Schlicht
On July 12, 2018, 6:57 a.m., Chun-Hung Hsiao wrote:
>
> ---
> This is an automatically gener
turns/return/.
src/resource_provider/storage/provider.cpp
Line 3249 (original), 3223 (patched)
<https://reviews.apache.org/r/67863/#comment289010>
Shouldn't this case result in a `Failure`?
- Jan Schlicht
On July 12, 2018, 6:55 a.m., Chu
(patched)
<https://reviews.apache.org/r/67779/#comment288957>
s/MONUT/MOUNT/
include/mesos/v1/mesos.proto
Lines 1986 (patched)
<https://reviews.apache.org/r/67779/#comment288958>
s/MONUT/MOUNT/
- Jan Schlicht
On July 12, 2018, 6:38 a.m., Chun-Hung
ing a `MOUNT`?
- Jan Schlicht
On July 10, 2018, 11:15 p.m., Chun-Hung Hsiao wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
oto
Lines 1998 (patched)
<https://reviews.apache.org/r/67779/#comment288898>
s/target/disk/
- Jan Schlicht
On July 10, 2018, 5:10 a.m., Chun-Hung Hsiao wrote:
>
> ---
> This is an automatica
e scope of this diff. Maybe break this out into a
separate diff?
src/resource_provider/storage/provider.cpp
Lines 3248-3249 (original), 3218-3219 (patched)
<https://reviews.apache.org/r/67863/#comment288893>
Ditto.
- Jan Schlicht
On
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67783/#review205571
---
Ship it!
Ship It!
- Jan Schlicht
On June 29, 2018, 2:02 p.m
(patched)
<https://reviews.apache.org/r/67664/#comment288451>
Not yours, but let's remove this comment, as it's just stating what is done
in the code below.
- Jan Schlicht
On June 21, 2018, 6:29 a.m., Chun-Hung Hsiao
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67693/#review205501
---
Ship it!
Ship It!
- Jan Schlicht
On June 21, 2018, 5:53 p.m
4ade16f044f8a4fdafd5afaba4e6a23232f83a5a
src/tests/authorization_tests.cpp f6f77692112d2299f3009fde4468f82bfd934c60
Diff: https://reviews.apache.org/r/67501/diff/7/
Changes: https://reviews.apache.org/r/67501/diff/6-7/
Testing
---
make check
Thanks,
Jan Schlicht
Thanks,
Jan Schlicht
/tests/authorization_tests.cpp f6f77692112d2299f3009fde4468f82bfd934c60
Diff: https://reviews.apache.org/r/67501/diff/5/
Changes: https://reviews.apache.org/r/67501/diff/4-5/
Testing
---
make check
Thanks,
Jan Schlicht
4180341e2c7b16503a4376c501f611bb78ba901c
src/master/master.cpp 4ade16f044f8a4fdafd5afaba4e6a23232f83a5a
src/tests/authorization_tests.cpp f6f77692112d2299f3009fde4468f82bfd934c60
Diff: https://reviews.apache.org/r/67501/diff/4/
Changes: https://reviews.apache.org/r/67501/diff/3-4/
Testing
---
make check
Thanks,
Jan
ole, destroy operations authorized per
creator principal.
- Jan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67501/#review205178
-------
On June 21, 2018, 2:34 p.m., Jan Schlicht wrote:
>
>
/tests/authorization_tests.cpp f6f77692112d2299f3009fde4468f82bfd934c60
Diff: https://reviews.apache.org/r/67501/diff/3/
Changes: https://reviews.apache.org/r/67501/diff/2-3/
Testing
---
make check
Thanks,
Jan Schlicht
://reviews.apache.org/r/67501/diff/1-2/
Testing
---
make check
Thanks,
Jan Schlicht
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67547/#review204684
---
Ship it!
Ship It!
- Jan Schlicht
On June 13, 2018, 1:02 p.m
ched)
<https://reviews.apache.org/r/67547/#comment287288>
We don't have to start a master to test this response of the agent API.
- Jan Schlicht
On June 12, 2018, 6:08 p.m., Benno Evers wrote:
>
> ---
> This is an automatically
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67522/#review204532
---
Ship it!
Ship It!
- Jan Schlicht
On June 11, 2018, 11:58
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67521/#review204531
---
Ship it!
Ship It!
- Jan Schlicht
On June 11, 2018, 11:58
f6f77692112d2299f3009fde4468f82bfd934c60
Diff: https://reviews.apache.org/r/67501/diff/1/
Testing
---
make check
Thanks,
Jan Schlicht
/
Testing
---
make check
Thanks,
Jan Schlicht
: https://reviews.apache.org/r/66932/diff/2/
Changes: https://reviews.apache.org/r/66932/diff/1-2/
Testing
---
make check
Thanks,
Jan Schlicht
n automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66933/#review202623
-------
On May 7, 2018, 2:12 p.m., Jan Schlicht wrote:
>
> ---
> Th
---
make check
Thanks,
Jan Schlicht
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66939/#review202548
---
Ship it!
Ship It!
- Jan Schlicht
On May 5, 2018, 1:41 a.m
: https://reviews.apache.org/r/66934/diff/1-2/
Testing
---
make check
Thanks,
Jan Schlicht
/diff/1-2/
Testing
---
make check
Thanks,
Jan Schlicht
await that one
before we reset `resourceProvider` with a new instance.
- Jan Schlicht
On May 3, 2018, 1:46 p.m., Benjamin Bannier wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
://reviews.apache.org/r/66934/diff/1/
Testing
---
make check
Thanks,
Jan Schlicht
6ca3d79fd38c800f258c571bb58164427db2ac7c
src/tests/cluster.cpp c071da69500e1d8a223f255904acf7e28100e774
Diff: https://reviews.apache.org/r/66933/diff/1/
Testing
---
make check
Thanks,
Jan Schlicht
,
Jan Schlicht
b7362d2be75e4de06092f16698a784b7a78994cb
Diff: https://reviews.apache.org/r/66904/diff/1/
Testing
---
Ran
```
mkdir build && cd build &&
cmake -G Ninja -D ENABLE_JEMALLOC_ALLOCATOR=ON &&
ninja
```
and checked that `jemalloc` third-party dependency is build.
Thanks,
Jan Schlicht
def09f1104213bf73d9f95cb5ad2fb80e3bdb04a
Diff: https://reviews.apache.org/r/66759/diff/1/
Testing
---
make check
Thanks,
Jan Schlicht
ine above.
3rdparty/libprocess/src/tests/jwt_tests.cpp
Lines 347 (patched)
<https://reviews.apache.org/r/66621/#comment282264>
Blank line above.
3rdparty/libprocess/src/tests/jwt_tests.cpp
Lines 505 (patched)
<https://reviews.apache.org/r/66621/#comment282266>
the `FAILED` state, but not other failure states,
e.g. `DISCARDED`. How about checking for `!admitResourceProvider.isReady()`
here?
- Jan Schlicht
On April 11, 2018, 11:23 a.m., Benjamin Bannier wrote:
>
> ---
> This is an aut
Lines 288 (patched)
<https://reviews.apache.org/r/66528/#comment281716>
Let's use `WARNING` instead of `INFO` here.
- Jan Schlicht
On April 10, 2018, 2:56 p.m., Benjamin Bannier wrote:
>
> ---
> This is an automatically g
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66527/#review200818
---
Ship it!
Ship It!
- Jan Schlicht
On April 10, 2018, 2:56
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66508/#review200817
---
Ship it!
Ship It!
- Jan Schlicht
On April 9, 2018, 4:07 p.m
s/recovery/recover
src/resource_provider/registrar.cpp
Lines 97 (patched)
<https://reviews.apache.org/r/66311/#comment281584>
`Registry` is in scope here and used without the namespace in other parts
of this unit. Let's be consistent and drop the namespace here and below.
- Jan Schl
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66471/#review200733
---
Ship it!
Ship It!
- Jan Schlicht
On April 5, 2018, 10:48
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66451/#review200732
---
Ship it!
Ship It!
- Jan Schlicht
On April 4, 2018, 2:35 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66476/#review200730
---
Ship it!
Ship It!
- Jan Schlicht
On April 5, 2018, 4:14 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66450/#review200727
---
Ship it!
Ship It!
- Jan Schlicht
On April 4, 2018, 2:21 p.m
/66354/diff/1/
Testing
---
Thanks,
Jan Schlicht
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66331/#review200110
---
Ship it!
Ship It!
- Jan Schlicht
On March 28, 2018, 4:21
t state.
src/resource_provider/registrar.hpp
Line 110 (original), 111 (patched)
<https://reviews.apache.org/r/66309/#comment280755>
Please rename, see above.
- Jan Schlicht
On March 27, 2018, 5:34 p.m., B
w --prefix) == /usr/local`)
* Press "c" to configure again. There shouldn't be an error now.
* Press "g" to generate the configuration.
$ ninja
Thanks,
Jan Schlicht
s.cpp
Lines 3194-3195 (patched)
<https://reviews.apache.org/r/65666/#comment280052>
As this prefix is used in more than one test case, how about making it part
of the test fixture?
- Jan Schlicht
On March 20, 2018, 4:27 a.m., Chun-Hung Hsiao wrote:
>
>
` loop. Looks great!
- Jan Schlicht
On March 23, 2018, 7:46 p.m., Benjamin Bannier wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66037/#review199864
---
Ship it!
Ship It!
- Jan Schlicht
On March 21, 2018, 3:58
.
- Jan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66210/#review199764
---
On March 22, 2018, 10:37 a.m., Jan Schli
;
Needs an additional `if (LINUX)` guard, as explained above.
- Jan Schlicht
On March 21, 2018, 12:47 a.m., Chun-Hung Hsiao wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
56ce55480553c08450830987f217d0abedd5b2b8
Diff: https://reviews.apache.org/r/66210/diff/1/
Testing
---
make check (on macOS, configured with `--enable-grpc`)
Thanks,
Jan Schlicht
1 - 100 of 927 matches
Mail list logo
