like it could fit in a single line.
- Joerg Schad
On Jan. 30, 2016, 5:25 p.m., Timothy Chen wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http
914/#comment177894>
According to the code it also supports .gz and .zip.
- Joerg Schad
On Jan. 28, 2016, 4:29 p.m., Bernd Mathiske wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
> On Jan. 26, 2016, 8:44 a.m., Joerg Schad wrote:
> > docs/home.md, line 17
> > <https://reviews.apache.org/r/42791/diff/1/?file=1221338#file1221338line17>
> >
> > With https://issues.apache.org/jira/browse/MESOS-4295 we changed the
> > link struc
> On Jan. 26, 2016, 8:48 a.m., Joerg Schad wrote:
> > docs/home.md, line 12
> > <https://reviews.apache.org/r/42791/diff/1/?file=1221338#file1221338line12>
> >
> > FYI: The links from
> > http://c99.millennium.berkeley.edu/documentation/latest/endpoint
791/#comment177373>
FYI: The links from
http://c99.millennium.berkeley.edu/documentation/latest/endpoints don't seem to
work for me... e.g.
http://c99.millennium.berkeley.edu/documentation/latest/version/
- Joerg Schad
On Jan. 26, 2016, 7:49 a.m., Kevin Klues
791/#comment177371>
With https://issues.apache.org/jira/browse/MESOS-4295 we changed the link
structure [label](file.md). I.e. s/endpoints/ /endpoints.md
- Joerg Schad
On Jan. 26, 2016, 7:49 a.m., Kevin Klues
7af6581f2eef10c78c76c07c44e88c6841465398
Diff: https://reviews.apache.org/r/42458/diff/
Testing
---
Viewed via Docker Website Container (including changes to rakefile provided by
previous review).
Thanks,
Joerg Schad
to change this right
now? The documentation look good nevertheless, so maybe just submit those?
include/mesos/mesos.proto
<https://reviews.apache.org/r/42697/#comment177042>
We planned to wait for this deprecation cycle, any reason to change this
right now?
- Joerg Schad
On Jan. 24, 2
> On Jan. 24, 2016, 3:28 p.m., Joerg Schad wrote:
> > include/mesos/mesos.proto, line 482
> > <https://reviews.apache.org/r/42697/diff/1/?file=1218952#file1218952line482>
> >
> > We planned to wait for this deprecation cycle, any reason to change
> &
> On Jan. 24, 2016, 3:28 p.m., Joerg Schad wrote:
> > include/mesos/mesos.proto, line 482
> > <https://reviews.apache.org/r/42697/diff/1/?file=1218952#file1218952line482>
> >
> > We planned to wait for this deprecation cycle, any reason to change
> &
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42477/
> ---
>
> (Updated Jan. 22, 2016, 3:43 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Joer
---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42477/
> ---
>
> (Updated Jan. 22, 2016, 3:43 p.m.)
>
>
> Review request for mesos, Bernd Mathis
Conway.
Repository: mesos
Description
---
Removed superfluous word from quota.md.
Diffs
-
docs/quota.md 1a6d2f07fb74d168a7eb30764ab9ff80cea5e3b6
Diff: https://reviews.apache.org/r/42575/diff/
Testing
---
Thanks,
Joerg Schad
est.
src/master/quota_handler.cpp (line 246)
<https://reviews.apache.org/r/42476/#comment175990>
Not an issue, but question/remark: the protoRequest.error() is most likely
to be less concise compared to the previous error messages?
- Joerg Schad
On Jan. 18, 2016, 11:37 p.m., A
3e5f4d786ccfcef85b341cdb698c4d0579019980
docs/versioning.md 7af6581f2eef10c78c76c07c44e88c6841465398
Diff: https://reviews.apache.org/r/42458/diff/
Testing
---
Viewed via Docker Website Container (including changes to rakefile provided by
previous review).
Thanks,
Joerg Schad
docs/versioning.md 7af6581f2eef10c78c76c07c44e88c6841465398
Diff: https://reviews.apache.org/r/42458/diff/
Testing
---
Viewed via Docker Website Container (including changes to rakefile provided by
previous review).
Thanks,
Joerg Schad
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42477/#review115126
---
Ship it!
Ship It!
- Joerg Schad
On Jan. 18, 2016, 11:37 p.m
> On Jan. 19, 2016, 8:37 a.m., Joerg Schad wrote:
> > include/mesos/quota/quota.proto, line 54
> > <https://reviews.apache.org/r/42476/diff/2/?file=1200759#file1200759line54>
> >
> > Given the naming scheme QuotaStatus wouldn't a more consistent name
s.cpp (line 1934)
<https://reviews.apache.org/r/41769/#comment176134>
s/2048;/2048
he
- Joerg Schad
On Jan. 19, 2016, 12:38 p.m., Guangya Liu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visi
r below (e.g. l 1823)-- add some description
that we are also testing the behavior on addSlave()?
- Joerg Schad
On Jan. 19, 2016, 2:25 p.m., Klaus Ma wrote:
>
> ---
> This is an automatically generated e-mail. To
94833488c8e29f9b07e3cab3c8adce223f685679
Diff: https://reviews.apache.org/r/42457/diff/
Testing
---
Tested with docker website container.
Additionally regex is nicely visualized here: https://regex101.com/r/zP6sH6/1
Thanks,
Joerg Schad
://reviews.apache.org/r/42457/diff/
Testing
---
Tested with docker website container.
Additionally regex is nicely visualized here: https://regex101.com/r/zP6sH6/1
Thanks,
Joerg Schad
by
previous review).
Thanks,
Joerg Schad
with docker website container.
Thanks,
Joerg Schad
3e5f4d786ccfcef85b341cdb698c4d0579019980
docs/versioning.md 7af6581f2eef10c78c76c07c44e88c6841465398
Diff: https://reviews.apache.org/r/42458/diff/
Testing
---
Viewed via Docker Website Container (including changes to rakefile provided by
previous review).
Thanks,
Joerg Schad
by misshaped? Mistyped?
- Joerg Schad
On Jan. 13, 2016, 10:07 a.m., Bernd Mathiske wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
it would be great to great
to have a test here, but as discussed it seems quite complex (and therefore
unproportional) to test.
- Joerg Schad
On Jan. 13, 2016, 10:07 a.m., Bernd Mathiske wrote:
>
> ---
> This is an automatically ge
---
Fixed broken link in scheduler-http-api.md.
Diffs
-
docs/scheduler-http-api.md 15ffb1e45cc169f4313598aa65aa8b4d41ce2308
Diff: https://reviews.apache.org/r/42347/diff/
Testing
---
Checked with docker website container.
Thanks,
Joerg Schad
-api.md 15ffb1e45cc169f4313598aa65aa8b4d41ce2308
Diff: https://reviews.apache.org/r/42347/diff/
Testing
---
Checked with docker website container.
Thanks,
Joerg Schad
tps://reviews.apache.org/r/41789/#comment175545>
Would it make sense to add a test (e.g. testing DELETE)?
- Joerg Schad
On Jan. 15, 2016, 7:50 a.m., Yongqiao Wang wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42248/
---
(Updated Jan. 13, 2016, 12:42 p.m.)
Review request for mesos, Joerg Schad
md (line 232)
<https://reviews.apache.org/r/41438/#comment175014>
s/uri/URI or consistent with the rest of the file...
docs/fetcher.md (line 260)
<https://reviews.apache.org/r/41438/#comment175012>
Any reason for two blank lines here?
- Joerg Schad
On Dec. 24, 2015, 1:
)
docs/fetcher.md (line 239)
<https://reviews.apache.org/r/41438/#comment175016>
s/is of the format/has the format:?
- Joerg Schad
On Dec. 24, 2015, 1:22 p.m., Shuai Lin wrote:
>
> ---
> This is an automatically generated e
Documentation.
Diffs (updated)
-
docs/home.md 344c5617dfb003453fa17974500d44a8f766cb16
docs/quota.md PRE-CREATION
Diff: https://reviews.apache.org/r/42040/diff/
Testing
---
Rendered version: https://gist.github.com/joerg84/a2c32e25d91e33045b56
Thanks,
Joerg Schad
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42248/
---
(Updated Jan. 13, 2016, 12:47 p.m.)
Review request for mesos, Joerg Schad
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42248/
---
(Updated Jan. 13, 2016, 1:01 p.m.)
Review request for mesos, Joerg Schad
438/#comment175018>
s/check/check the
- Joerg Schad
On Dec. 24, 2015, 1:22 p.m., Shuai Lin wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42262/
---
(Updated Jan. 13, 2016, 8:38 p.m.)
Review request for mesos, Joerg Schad
g/r/42196/#comment175077>
Is that true in general? Process isolation might rely on cgroups, but not
necessarly or?
- Joerg Schad
On Jan. 13, 2016, 3:18 p.m., Jan Schlicht wrote:
>
> ---
> This is an automatically g
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42263/
---
(Updated Jan. 13, 2016, 8:38 p.m.)
Review request for mesos, Joerg Schad
Description
---
Fixed broken links in mesos-provisioner.md.
Diffs
-
docs/mesos-provisioner.md f2777b21ce3b2278613b5915a6500c20f7db94e1
Diff: https://reviews.apache.org/r/42269/diff/
Testing
---
Thanks,
Joerg Schad
generator.
Thanks,
Joerg Schad
PRE-CREATION
Diff: https://reviews.apache.org/r/42040/diff/
Testing (updated)
---
Rendered version: https://gist.github.com/joerg84/a2c32e25d91e33045b56
Used docker website renderer to check output and links
Thanks,
Joerg Schad
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42253/
---
(Updated Jan. 13, 2016, 3:25 p.m.)
Review request for mesos, Joerg Schad, Till
6f0f4b9cb9d0da1f9960ebe7f36ce186c1317535
docs/quota.md PRE-CREATION
Diff: https://reviews.apache.org/r/42040/diff/
Testing
---
Rendered version: https://gist.github.com/joerg84/a2c32e25d91e33045b56
Thanks,
Joerg Schad
/slave_recovery_tests.cpp c0e4ff75b35c9e806741aab5696771e66d2c2ea8
src/tests/slave_tests.cpp 77750eda99184c0bf4404df8468461e3c7f8cde0
Diff: https://reviews.apache.org/r/41649/diff/
Testing
---
make check
Thanks,
Joerg Schad
6f0f4b9cb9d0da1f9960ebe7f36ce186c1317535
docs/quota.md PRE-CREATION
Diff: https://reviews.apache.org/r/42040/diff/
Testing
---
Rendered version: https://gist.github.com/joerg84/a2c32e25d91e33045b56
Thanks,
Joerg Schad
ot sure what rb does...
- Joerg
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42040/#review113916
---
On Jan. 11, 2
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41937/#review113987
---
Ship it!
Ship It!
- Joerg Schad
On Jan. 5, 2016, 6:08 p.m
tps://reviews.apache.org/r/41950/#comment174774>
Should we maybe make the name more descriptive? EMPTY sounds very
general....
- Joerg Schad
On Jan. 5, 2016, 11:45 p.m., Alexander Rukletsov wrote:
>
> ---
> This is an automati
c0e4ff75b35c9e806741aab5696771e66d2c2ea8
src/tests/slave_tests.cpp e4fb490a1d877547fe883c22dbc47bb4969ecef6
Diff: https://reviews.apache.org/r/41649/diff/
Testing
---
make check
Thanks,
Joerg Schad
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41882/#review113708
---
Ship it!
Ship It!
- Joerg Schad
On Jan. 11, 2016, 9:25 a.m
ps://reviews.apache.org/r/41649/#review113556
-------
On Jan. 11, 2016, 10:07 a.m., Joerg Schad wrote:
>
> ---
> This is an automatically generated e-mail.
ps://reviews.apache.org/r/41649/#review113532
-------
On Jan. 11, 2016, 10:07 a.m., Joerg Schad wrote:
>
> ---
> This is an automatically generated e-mail.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42040/#review113358
---
On Jan. 8, 2016, 10:26 a.m., Joerg Schad
9d80c96d8e28085c7fa47ce21b9b055c0926d12c
src/slave/state.cpp b912c554fc9cb5593f541a7803422c22dc03dffd
src/tests/slave_recovery_tests.cpp c0e4ff75b35c9e806741aab5696771e66d2c2ea8
Diff: https://reviews.apache.org/r/41649/diff/
Testing
---
make check
Thanks,
Joerg Schad
now
Same as above.
- Joerg
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42040/#review113601
---
On Jan. 8,
epository: mesos
>
>
> Description
> ---
>
> Added Quota Operator Documentation.
>
>
> Diffs
> -
>
> docs/home.md 6f0f4b9cb9d0da1f9960ebe7f36ce186c1317535
> docs/quota.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/42040/diff/
>
>
> Testing
> ---
>
> Rendered version: https://gist.github.com/joerg84/a2c32e25d91e33045b56
>
>
> Thanks,
>
> Joerg Schad
>
>
> On Jan. 9, 2016, 4:09 a.m., Guangya Liu wrote:
> > docs/quota.md, line 175
> > <https://reviews.apache.org/r/42040/diff/2/?file=1187349#file1187349line175>
> >
> > Do we need to mention that the 80% is not configurable now?
>
> Joerg Schad wr
> On Jan. 9, 2016, 4:09 a.m., Guangya Liu wrote:
> > docs/quota.md, lines 33-34
> > <https://reviews.apache.org/r/42040/diff/2/?file=1187349#file1187349line33>
> >
> > But we did have plan to introduce maximal limit in MESOS-3858 , can we
> > calarify
> On Jan. 9, 2016, 4:09 a.m., Guangya Liu wrote:
> > docs/quota.md, line 70
> > <https://reviews.apache.org/r/42040/diff/2/?file=1187349#file1187349line70>
> >
> > s/to even/even ?
>
> Joerg Schad wrote:
> changed it to 'event to ignore'
>
6f0f4b9cb9d0da1f9960ebe7f36ce186c1317535
docs/quota.md PRE-CREATION
Diff: https://reviews.apache.org/r/42040/diff/
Testing
---
Rendered version: https://gist.github.com/joerg84/a2c32e25d91e33045b56
Thanks,
Joerg Schad
aster is configured without an explicit
[role whitelist](roles.md) a set request can introduce new roles.```
- Joerg
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4204
/home.md 6f0f4b9cb9d0da1f9960ebe7f36ce186c1317535
docs/quota.md PRE-CREATION
Diff: https://reviews.apache.org/r/42040/diff/
Testing
---
Rendered version: https://gist.github.com/joerg84/a2c32e25d91e33045b56
Thanks,
Joerg Schad
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41936/#review113477
---
Ship it!
Ship It!
- Joerg Schad
On Jan. 5, 2016, 6:08 p.m
/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c
src/slave/state.cpp b912c554fc9cb5593f541a7803422c22dc03dffd
src/tests/slave_recovery_tests.cpp c0e4ff75b35c9e806741aab5696771e66d2c2ea8
Diff: https://reviews.apache.org/r/41649/diff/
Testing
---
make check
Thanks,
Joerg Schad
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41949/#review113475
---
Ship it!
Ship It!
- Joerg Schad
On Jan. 5, 2016, 11:43 p.m
version: https://gist.github.com/joerg84/a2c32e25d91e33045b56
Thanks,
Joerg Schad
g/r/42025/#comment173766>
Please add to configuration.md
- Joerg Schad
On Jan. 7, 2016, 2:38 p.m., Till Toenshoff wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c
src/slave/state.cpp b912c554fc9cb5593f541a7803422c22dc03dffd
src/tests/slave_recovery_tests.cpp c0e4ff75b35c9e806741aab5696771e66d2c2ea8
Diff: https://reviews.apache.org/r/41649/diff/
Testing
---
make check
Thanks,
Joerg Schad
> On Jan. 7, 2016, 7:39 p.m., Joerg Schad wrote:
> > src/master/master.cpp, line 527
> > <https://reviews.apache.org/r/42025/diff/5/?file=1186406#file1186406line527>
> >
> > Does it make sense to document this behavior (the master not starting
> > if
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42025/#review113318
---
Ship it!
- Joerg Schad
On Jan. 7, 2016, 8:29 p.m., Till
g/r/42025/#comment173831>
See proposal above...
src/master/master.cpp (line 527)
<https://reviews.apache.org/r/42025/#comment173825>
Does it make sense to document this behavior (the master not starting if
flag and no credentials) to either some documentation and/or flags?
-
g/r/42025/#comment173833>
How about:
If true only authenticated requests for HTTP endpoint
requiring authentification are allowed.
'If false also unauthenticated requests for HTTP endpoint
requiring authentification are also allowed.'
- Joerg Schad
On Jan. 7, 2016, 7:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41947/#review113044
---
Ship it!
Ship It!
- Joerg Schad
On Jan. 5, 2016, 11:38 p.m
tps://reviews.apache.org/r/41938/#comment173525>
Shouldn't this be SetNonExistentRole?
src/tests/master_quota_tests.cpp (line 297)
<https://reviews.apache.org/r/41938/#comment173527>
SetResourcesSpecifyRole?
- Joerg Schad
On Jan. 5, 2016, 11:39 p.m., Alexander Ruk
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41948/#review113060
---
Ship it!
Ship It!
- Joerg Schad
On Jan. 5, 2016, 11:38 p.m
have a brief discussion on the dev mailing list?
- Joerg Schad
On Jan. 4, 2016, 8:01 p.m., Benjamin Bannier wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
> On Jan. 3, 2016, 10:48 a.m., Joerg Schad wrote:
> > This pretty much duplicates https://reviews.apache.org/r/39466/ (except
> > also has a test case). Even though the long term approach should be to
> > replace all the individual http method call with a general one (acc
/ (except also
has a test case). Even though the long term approach should be to replace all
the individual http method call with a general one (accepting a Request
object), we should decide which of these reviews we want to commit/focus on
right now.
- Joerg Schad
On Jan. 3, 2016, 10:38 a.m
/libprocess/src/http.cpp e937df6875c8024ea9c178833b9faceede990969
3rdparty/libprocess/src/tests/http_tests.cpp
19261502be220aaa40add7ce30a9b2b65d1d9fdc
Diff: https://reviews.apache.org/r/39466/diff/
Testing
---
make check
Thanks,
Joerg Schad
nd in
> > the other `put` method? It looks like they are mostly concerned with
> > creating the `Request`.
>
> Joerg Schad wrote:
> I beleive a larger refactoring to just one common `Request` object would
> also adress this issue. See https://issues.apache.org/jira/bro
mentation on this array of isolators?
- Joerg Schad
On Dec. 28, 2015, 8:23 p.m., Jojy Varghese wrote:
>
> ---
> This is an automatically generated e-mail. To reply
m "Pull from docker
registry" to "pull from a local file location"? Wouldn't that impact users
experimenting with Mesos? If this is not the case feel to drop.
- Joerg Schad
On Dec. 27, 2015
troduce the other containerizer (I
assume you went for alphabetical order)? Feel free to ignore if you disagree ...
- Joerg Schad
On Dec. 22, 2015, 10:27 p.m., Jojy Varghese wrote:
>
> ---
> This is an automatically generated
on documentation
(https://github.com/apache/mesos/blob/master/docs/configuration.md)
- Joerg Schad
On Dec. 26, 2015, 8:28 p.m., Timothy Chen wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
> On Dec. 27, 2015, 8:16 a.m., Joerg Schad wrote:
> > src/slave/flags.cpp, line 146
> > <https://reviews.apache.org/r/41731/diff/1/?file=1176474#file1176474line146>
> >
> > Do I understand correctly that we change the default from "Pull from
> >
Diff: https://reviews.apache.org/r/41680/diff/
Testing
---
make check and checked logs
Thanks,
Joerg Schad
: https://reviews.apache.org/r/41682/diff/
Testing
---
Viewed rendered doc.
Thanks,
Joerg Schad
/diff/
Testing
---
viewed rendered doc.
Thanks,
Joerg Schad
o reply, visit:
> https://reviews.apache.org/r/41656/
> ---
>
> (Updated Dec. 22, 2015, 10:11 p.m.)
>
>
> Review request for mesos, Jie Yu and Joerg Schad.
>
>
> Repository: mesos
>
>
> Descri
tps://reviews.apache.org/r/41656/#comment171900>
Not yours, but didn't we want to remove such fully specified links to
github?
- Joerg Schad
On Dec. 22, 2015, 10:11 p.m., Jojy Varghese wrote:
>
> ---
> This is an automatically g
- Joerg
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39492/#review111547
---
On Dec. 22, 2015, 8:38 a.m., Joerg Sc
89130ce9b09afe7c6dd332c8b5278abe0d2674f1
Diff: https://reviews.apache.org/r/39614/diff/
Testing
---
make check
Thanks,
Joerg Schad
7f5e51948616036378b8993134ba6df09dad5d88
Diff: https://reviews.apache.org/r/40293/diff/
Testing
---
viewed rendered version.
Thanks,
Joerg Schad
://reviews.apache.org/r/39614/diff/
Testing
---
make check
Thanks,
Joerg Schad
src/master/master.hpp 8af82a0bbc2038e18180136c82cbaeeacc7b3526
src/master/quota_handler.cpp 0217149a865ede751b3a03fe40b2d91b487b7b10
Diff: https://reviews.apache.org/r/39492/diff/
Testing
---
Tests are in Review 39614.
Thanks,
Joerg Schad
src/master/master.hpp 8af82a0bbc2038e18180136c82cbaeeacc7b3526
src/master/quota_handler.cpp 0217149a865ede751b3a03fe40b2d91b487b7b10
Diff: https://reviews.apache.org/r/39492/diff/
Testing (updated)
---
Tests are in Review 39614.
Thanks,
Joerg Schad
ng array sizes or calling get() on a Try.
- Joerg
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39614/#review111597
------
://reviews.apache.org/r/39614/diff/
Testing
---
make check
Thanks,
Joerg Schad
601 - 700 of 1024 matches
Mail list logo
