Re: Review Request 39068: RegistryClient refactor: Renamed fsLayerInfoList

/registry_client.cpp 471783d88b73b62afacac3d7952ebb5d5f442097 src/tests/containerizer/provisioner_docker_tests.cpp 9c3c45a81be6398722a37911788e347a4e91cce8 Diff: https://reviews.apache.org/r/39068/diff/ Testing --- make check. Thanks, Jojy Varghese

Re: Review Request 39014: RegistryClient refactor: renamed ManifestResponse

/containerizer/provisioner/docker/registry_client.cpp 471783d88b73b62afacac3d7952ebb5d5f442097 src/tests/containerizer/provisioner_docker_tests.cpp 9c3c45a81be6398722a37911788e347a4e91cce8 Diff: https://reviews.apache.org/r/39014/diff/ Testing --- make check. Thanks, Jojy Varghese

Re: Review Request 38579: Refactored registry client

/provisioner_docker_tests.cpp 9c3c45a81be6398722a37911788e347a4e91cce8 Diff: https://reviews.apache.org/r/38579/diff/ Testing --- make check. Thanks, Jojy Varghese

Re: Review Request 39155: RegistryClient refactor: removed nested namespace references

/39155/diff/ Testing --- make check. Thanks, Jojy Varghese

Re: Review Request 39156: RegistryClient refactor: changed getManifest interface

/registry_client.cpp 471783d88b73b62afacac3d7952ebb5d5f442097 src/tests/containerizer/provisioner_docker_tests.cpp 9c3c45a81be6398722a37911788e347a4e91cce8 Diff: https://reviews.apache.org/r/39156/diff/ Testing --- make check. Thanks, Jojy Varghese

Re: Review Request 39250: Puller refactor: moved untar to a common place

/ Testing --- make check. Thanks, Jojy Varghese

Re: Review Request 38747: Adding digest utilities

, Jojy Varghese

Re: Review Request 39250: Puller refactor: moved untar to a common place

check. Thanks, Jojy Varghese

Re: Review Request 39156: RegistryClient refactor: changed getManifest interface

/registry_client.cpp 4931ae8869a697b1e9d8d4cbc0a871e7cd506285 src/tests/containerizer/provisioner_docker_tests.cpp d895eb9d0723e52cff8b21ef2deeaef1911d019c Diff: https://reviews.apache.org/r/39156/diff/ Testing --- make check. Thanks, Jojy Varghese

Re: Review Request 38580: Added docker registry RemotePuller

f76f0f6a0c7a01c7f061a225d7f6ef52be0ee7b5 src/slave/flags.cpp 029aa1eb00e1aa3e92c2155925022c17fd905862 src/tests/containerizer/provisioner_docker_tests.cpp d895eb9d0723e52cff8b21ef2deeaef1911d019c Diff: https://reviews.apache.org/r/38580/diff/ Testing --- make check. Thanks, Jojy

Re: Review Request 39014: RegistryClient refactor: renamed ManifestResponse

/provisioner/docker/registry_client.cpp 4931ae8869a697b1e9d8d4cbc0a871e7cd506285 src/tests/containerizer/provisioner_docker_tests.cpp d895eb9d0723e52cff8b21ef2deeaef1911d019c Diff: https://reviews.apache.org/r/39014/diff/ Testing --- make check. Thanks, Jojy Varghese

Re: Review Request 38579: Refactored registry client

/provisioner_docker_tests.cpp d895eb9d0723e52cff8b21ef2deeaef1911d019c Diff: https://reviews.apache.org/r/38579/diff/ Testing --- make check. Thanks, Jojy Varghese

Re: Review Request 39155: RegistryClient refactor: removed nested namespace references

/39155/diff/ Testing --- make check. Thanks, Jojy Varghese

Re: Review Request 39112: RegistryClient refactor: fixed variable names

4931ae8869a697b1e9d8d4cbc0a871e7cd506285 src/tests/containerizer/provisioner_docker_tests.cpp d895eb9d0723e52cff8b21ef2deeaef1911d019c Diff: https://reviews.apache.org/r/39112/diff/ Testing --- make check. Thanks, Jojy Varghese

Re: Review Request 39053: RegistryClient refactor: priv method const'ness

/diff/ Testing --- make check. Thanks, Jojy Varghese

Re: Review Request 39017: RegistryClient refactor: encapsulated Manifest

src/slave/containerizer/provisioner/docker/registry_client.cpp 4931ae8869a697b1e9d8d4cbc0a871e7cd506285 src/tests/containerizer/provisioner_docker_tests.cpp d895eb9d0723e52cff8b21ef2deeaef1911d019c Diff: https://reviews.apache.org/r/39017/diff/ Testing --- make check. Thanks, Jojy

Re: Review Request 39015: RegistryClient refactor: expanded abbreviated names.

/registry_client.cpp 4931ae8869a697b1e9d8d4cbc0a871e7cd506285 Diff: https://reviews.apache.org/r/39015/diff/ Testing --- make check. Thanks, Jojy Varghese

Re: Review Request 39016: RegistryClient refactor: refactored lambdas

://reviews.apache.org/r/39016/diff/ Testing --- Make check. Thanks, Jojy Varghese

Re: Review Request 38941: Moved structs outside RegistryClient

/provisioner/docker/registry_client.cpp 4931ae8869a697b1e9d8d4cbc0a871e7cd506285 src/tests/containerizer/provisioner_docker_tests.cpp d895eb9d0723e52cff8b21ef2deeaef1911d019c Diff: https://reviews.apache.org/r/38941/diff/ Testing --- make check. Thanks, Jojy Varghese

Re: Review Request 39068: RegistryClient refactor: Renamed fsLayerInfoList

/registry_client.cpp 4931ae8869a697b1e9d8d4cbc0a871e7cd506285 src/tests/containerizer/provisioner_docker_tests.cpp d895eb9d0723e52cff8b21ef2deeaef1911d019c Diff: https://reviews.apache.org/r/39068/diff/ Testing --- make check. Thanks, Jojy Varghese

Re: Review Request 38747: Adding digest utilities

This of course becomes a moot point is we don't use template as I was > > suggesting above. One of the reasons the templates are in header file is to allow client code like: ``` DigestUtil::digest(string) ``` - Jojy --- This is an autom

Re: Review Request 38580: Added docker registry RemotePuller

somewhere shared? We can create a > > base puller class and move this there. > > Jojy Varghese wrote: > Thought about it a little more and realized that the functionality of > "untar a tarball into a dierctory" should belong in a common place like > libprocess. Its n

Re: Review Request 39250: Puller refactor: moved untar to a common place

/diff/ Testing --- make check. Thanks, Jojy Varghese

Review Request 39250: Puller refactor: moved untar to a common place

/provisioner/docker/puller.cpp cb05324689ffa26ce830b513e2d71b55517da3cb src/slave/containerizer/provisioner/docker/remote_puller.cpp PRE-CREATION Diff: https://reviews.apache.org/r/39250/diff/ Testing --- make check. Thanks, Jojy Varghese

Re: Review Request 38580: Added docker registry RemotePuller

somewhere shared? We can create a > > base puller class and move this there. > > Jojy Varghese wrote: > Thought about it a little more and realized that the functionality of > "untar a tarball into a dierctory" should belong in a common place like > libprocess. Its n

Re: Review Request 38580: Added docker registry RemotePuller

, Jojy Varghese

Re: Review Request 38747: Adding digest utilities

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38747/#review101451 --- On Oct. 12, 2015, 9:14 p.m., Jojy Varghese wrote: > > --

Re: Review Request 38747: Adding digest utilities

/diff/ Testing --- make check. Thanks, Jojy Varghese

Re: Review Request 38747: Adding digest utilities

256sum > > sha512sum are part of GNU coreutils while shasum is on every mac). The > > linked review needs to address some comments but it's not far from ready > > for shipit (it's not a priority for us right now but you can take it if you > > like). > >

Review Request 39197: Provider tests: minor style fixes.

--- Provider tests: minor style fixes. Diffs - src/tests/containerizer/provisioner_docker_tests.cpp d895eb9d0723e52cff8b21ef2deeaef1911d019c Diff: https://reviews.apache.org/r/39197/diff/ Testing --- make check. Thanks, Jojy Varghese

Review Request 39196: Puller tests: removed extraneous sandbox directory

--- Puller tests: removed extraneous sandbox directory Diffs - src/tests/containerizer/provisioner_docker_tests.cpp d895eb9d0723e52cff8b21ef2deeaef1911d019c Diff: https://reviews.apache.org/r/39196/diff/ Testing --- make check. Thanks, Jojy Varghese

Re: Review Request 39014: RegistryClient refactor: renamed ManifestResponse

/provisioner/docker/registry_client.cpp 4931ae8869a697b1e9d8d4cbc0a871e7cd506285 src/tests/containerizer/provisioner_docker_tests.cpp d895eb9d0723e52cff8b21ef2deeaef1911d019c Diff: https://reviews.apache.org/r/39014/diff/ Testing --- make check. Thanks, Jojy Varghese

Re: Review Request 39156: RegistryClient refactor: changed getManifest interface

/registry_client.cpp 4931ae8869a697b1e9d8d4cbc0a871e7cd506285 src/tests/containerizer/provisioner_docker_tests.cpp d895eb9d0723e52cff8b21ef2deeaef1911d019c Diff: https://reviews.apache.org/r/39156/diff/ Testing --- make check. Thanks, Jojy Varghese

Re: Review Request 38579: Refactored registry client

/provisioner_docker_tests.cpp d895eb9d0723e52cff8b21ef2deeaef1911d019c Diff: https://reviews.apache.org/r/38579/diff/ Testing --- make check. Thanks, Jojy Varghese

Re: Review Request 39184: RegistryClient refactor: reordered ctor parameters

/containerizer/provisioner/docker/registry_client.cpp 4931ae8869a697b1e9d8d4cbc0a871e7cd506285 Diff: https://reviews.apache.org/r/39184/diff/ Testing --- make check. Thanks, Jojy Varghese

Re: Review Request 38443: Added layerid information to ManifestResponse

/containerizer/provisioner/docker/registry_client.cpp 4931ae8869a697b1e9d8d4cbc0a871e7cd506285 src/tests/containerizer/provisioner_docker_tests.cpp d895eb9d0723e52cff8b21ef2deeaef1911d019c Diff: https://reviews.apache.org/r/38443/diff/ Testing --- make check. Thanks, Jojy Varghese

Re: Review Request 39155: RegistryClient refactor: removed nested namespace references

://reviews.apache.org/r/39155/diff/ Testing --- make check. Thanks, Jojy Varghese

Review Request 39184: RegistryClient refactor: reordered ctor parameters

://reviews.apache.org/r/39184/diff/ Testing --- make check. Thanks, Jojy Varghese

Re: Review Request 38579: Refactored registry client

/containerizer/provisioner_docker_tests.cpp d895eb9d0723e52cff8b21ef2deeaef1911d019c Diff: https://reviews.apache.org/r/38579/diff/ Testing --- make check. Thanks, Jojy Varghese

Re: Review Request 39014: RegistryClient refactor: renamed ManifestResponse

, Jojy Varghese

Review Request 39155: RegistryClient refactor: removed nested namespace references

--- RegistryClient refactor: removed nested namespace references Diffs - src/slave/containerizer/provisioner/docker/registry_client.cpp 4931ae8869a697b1e9d8d4cbc0a871e7cd506285 Diff: https://reviews.apache.org/r/39155/diff/ Testing --- make check. Thanks, Jojy Varghese

Review Request 39156: RegistryClient refactor: changed getManifest interface

/tests/containerizer/provisioner_docker_tests.cpp d895eb9d0723e52cff8b21ef2deeaef1911d019c Diff: https://reviews.apache.org/r/39156/diff/ Testing --- make check. Thanks, Jojy Varghese

Re: Review Request 39141: Store: minor style changes

/diff/ Testing --- make check. Thanks, Jojy Varghese

Re: Review Request 39141: Store: minor style changes

-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39141/#review101951 --- On Oct. 8, 2015, 7:30 p.m., Jojy Varghese wrote: > > -

Review Request 39141: Store: minor style changes

--- Store: minor style changes Diffs - src/slave/containerizer/provisioner/docker/store.cpp cbb67686d45513f0395a0cf1bc5c43cb4935adae Diff: https://reviews.apache.org/r/39141/diff/ Testing --- make check. Thanks, Jojy Varghese

Review Request 39136: Fixed log message when untarring local image

--- Fixed log message when untarring local image Diffs - src/slave/containerizer/provisioner/docker/local_puller.cpp 4a0b7d11f013941084571f2d89d835a4668a3d8b Diff: https://reviews.apache.org/r/39136/diff/ Testing --- make check. Thanks, Jojy Varghese

Review Request 39137: Local puller: fixed minor style issues.

--- Local puller: fixed minor style issues. Diffs - src/slave/containerizer/provisioner/docker/local_puller.cpp 4a0b7d11f013941084571f2d89d835a4668a3d8b Diff: https://reviews.apache.org/r/39137/diff/ Testing --- make check. Thanks, Jojy Varghese

Re: Review Request 38747: Adding digest utilities

/r/38747/diff/ Testing --- make check. Thanks, Jojy Varghese

Review Request 39112: RegistryClient refactor: fixed variable names

/provisioner_docker_tests.cpp d895eb9d0723e52cff8b21ef2deeaef1911d019c Diff: https://reviews.apache.org/r/39112/diff/ Testing --- make check. Thanks, Jojy Varghese

Re: Review Request 38580: Added docker registry RemotePuller

029aa1eb00e1aa3e92c2155925022c17fd905862 src/tests/containerizer/provisioner_docker_tests.cpp d895eb9d0723e52cff8b21ef2deeaef1911d019c Diff: https://reviews.apache.org/r/38580/diff/ Testing --- make check. Thanks, Jojy Varghese

Re: Review Request 39053: RegistryClient refactor: priv method const'ness

https://reviews.apache.org/r/39053/diff/ Testing --- make check. Thanks, Jojy Varghese

Re: Review Request 39016: RegistryClient refactor: refactored lambdas

: https://reviews.apache.org/r/39016/diff/ Testing --- Make check. Thanks, Jojy Varghese

Re: Review Request 39017: RegistryClient refactor: encapsulated Manifest

check. Thanks, Jojy Varghese

Re: Review Request 39015: RegistryClient refactor: expanded abbreviated names.

/containerizer/provisioner/docker/registry_client.cpp 4931ae8869a697b1e9d8d4cbc0a871e7cd506285 Diff: https://reviews.apache.org/r/39015/diff/ Testing --- make check. Thanks, Jojy Varghese

Re: Review Request 38941: Moved structs outside RegistryClient

/slave/containerizer/provisioner/docker/registry_client.cpp 4931ae8869a697b1e9d8d4cbc0a871e7cd506285 src/tests/containerizer/provisioner_docker_tests.cpp d895eb9d0723e52cff8b21ef2deeaef1911d019c Diff: https://reviews.apache.org/r/38941/diff/ Testing --- make check. Thanks, Jojy Varghese

Re: Review Request 39068: RegistryClient refactor: Renamed fsLayerInfoList

/containerizer/provisioner/docker/registry_client.cpp 4931ae8869a697b1e9d8d4cbc0a871e7cd506285 src/tests/containerizer/provisioner_docker_tests.cpp d895eb9d0723e52cff8b21ef2deeaef1911d019c Diff: https://reviews.apache.org/r/39068/diff/ Testing --- make check. Thanks, Jojy Varghese

Re: Review Request 38941: Moved structs outside RegistryClient

/slave/containerizer/provisioner/docker/registry_client.cpp 4931ae8869a697b1e9d8d4cbc0a871e7cd506285 src/tests/containerizer/provisioner_docker_tests.cpp d895eb9d0723e52cff8b21ef2deeaef1911d019c Diff: https://reviews.apache.org/r/38941/diff/ Testing --- make check. Thanks, Jojy

Review Request 39068: RegistryClient refactor: Renamed fsLayerInfoList

/provisioner_docker_tests.cpp d895eb9d0723e52cff8b21ef2deeaef1911d019c Diff: https://reviews.apache.org/r/39068/diff/ Testing --- make check. Thanks, Jojy Varghese

Re: Review Request 39014: RegistryClient refactor: renamed ManifestResponse

src/slave/containerizer/provisioner/docker/registry_client.cpp 4931ae8869a697b1e9d8d4cbc0a871e7cd506285 src/tests/containerizer/provisioner_docker_tests.cpp d895eb9d0723e52cff8b21ef2deeaef1911d019c Diff: https://reviews.apache.org/r/39014/diff/ Testing --- make check. Thanks, Jojy

Re: Review Request 39014: RegistryClient refactor: renamed ManifestResponse

m the name as well. The idea was to make it obvious 50 lines down from initialization. I can change it and create another patch for replacing all xxxFuture with xxx for variable names. - Jojy --- This is an automatical

Re: Review Request 38580: Added docker registry RemotePuller

029aa1eb00e1aa3e92c2155925022c17fd905862 src/tests/containerizer/provisioner_docker_tests.cpp d895eb9d0723e52cff8b21ef2deeaef1911d019c Diff: https://reviews.apache.org/r/38580/diff/ Testing --- make check. Thanks, Jojy Varghese

Review Request 39053: RegistryClient refactor: priv method const'ness

--- RegistryClient refactor: priv method const'ness Diffs - src/slave/containerizer/provisioner/docker/registry_client.cpp c2040b48ea43fdb29766994c244273d3fa9ee3cd Diff: https://reviews.apache.org/r/39053/diff/ Testing --- make check. Thanks, Jojy Varghese

Re: Review Request 38579: Refactored registry client

/containerizer/provisioner/docker/registry_client.cpp c2040b48ea43fdb29766994c244273d3fa9ee3cd src/tests/containerizer/provisioner_docker_tests.cpp d895eb9d0723e52cff8b21ef2deeaef1911d019c Diff: https://reviews.apache.org/r/38579/diff/ Testing --- make check. Thanks, Jojy Varghese

Re: Review Request 38579: Refactored registry client

, Jojy Varghese

Re: Review Request 38443: Added layerid information to ManifestResponse

/docker/registry_client.cpp c2040b48ea43fdb29766994c244273d3fa9ee3cd src/tests/containerizer/provisioner_docker_tests.cpp d895eb9d0723e52cff8b21ef2deeaef1911d019c Diff: https://reviews.apache.org/r/38443/diff/ Testing --- make check. Thanks, Jojy Varghese

Re: Review Request 39013: RegistryClient refactor: Fixed comments style.

/provisioner/docker/registry_client.cpp c2040b48ea43fdb29766994c244273d3fa9ee3cd Diff: https://reviews.apache.org/r/39013/diff/ Testing --- make check. Thanks, Jojy Varghese

Re: Review Request 38579: Refactored registry client

, Jojy Varghese

Re: Review Request 39013: RegistryClient refactor: Fixed comments style.

/docker/registry_client.cpp c2040b48ea43fdb29766994c244273d3fa9ee3cd Diff: https://reviews.apache.org/r/39013/diff/ Testing --- make check. Thanks, Jojy Varghese

Re: Review Request 38580: Added docker registry RemotePuller

/slave/flags.cpp 029aa1eb00e1aa3e92c2155925022c17fd905862 src/tests/containerizer/provisioner_docker_tests.cpp d895eb9d0723e52cff8b21ef2deeaef1911d019c Diff: https://reviews.apache.org/r/38580/diff/ Testing --- make check. Thanks, Jojy Varghese

Re: Review Request 38941: Moved structs outside RegistryClient

check. Thanks, Jojy Varghese

Review Request 39013: RegistryClient refactor: Fixed comments style.

://reviews.apache.org/r/39013/diff/ Testing --- make check. Thanks, Jojy Varghese

Review Request 39014: RegistryClient refactor: renamed ManifestResponse

c2040b48ea43fdb29766994c244273d3fa9ee3cd src/tests/containerizer/provisioner_docker_tests.cpp d895eb9d0723e52cff8b21ef2deeaef1911d019c Diff: https://reviews.apache.org/r/39014/diff/ Testing --- make check. Thanks, Jojy Varghese

Review Request 39015: RegistryClient refactor: expanded abbreviated names.

://reviews.apache.org/r/39015/diff/ Testing --- make check. Thanks, Jojy Varghese

Review Request 39016: RegistryClient refactor: refactored lambdas

--- RegistryClient refactor: refactored lambdas as per review comments. Diffs - src/slave/containerizer/provisioner/docker/registry_client.cpp c2040b48ea43fdb29766994c244273d3fa9ee3cd Diff: https://reviews.apache.org/r/39016/diff/ Testing --- Make check. Thanks, Jojy Varghese

Review Request 39017: RegistryClient refactor: encapsulated Manifest

c2040b48ea43fdb29766994c244273d3fa9ee3cd src/tests/containerizer/provisioner_docker_tests.cpp d895eb9d0723e52cff8b21ef2deeaef1911d019c Diff: https://reviews.apache.org/r/39017/diff/ Testing --- make check. Thanks, Jojy Varghese

Re: Review Request 38579: Refactored registry client

mail. To reply, visit: https://reviews.apache.org/r/38579/#review101382 --- On Oct. 2, 2015, 12:24 a.m., Jojy Varghese wrote: > > --- > This is an autom

Re: Review Request 38579: Refactored registry client

t acceptable to hold the whole blob in memory like this?? How big > > can these blobs be? Thats a good point. Ideally we should have a buffered socker reader. Would appreciate if you could point me to an example of buffered reader from http. - Jojy

Re: Review Request 38814: add test cases for sha512 digest verifier

with DigestTypeTraits::is_implemented. - Jojy Varghese On Oct. 2, 2015, 6:29 p.m., Gilbert Song wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 38580: Added docker registry RemotePuller

/slave/flags.cpp 029aa1eb00e1aa3e92c2155925022c17fd905862 src/tests/containerizer/provisioner_docker_tests.cpp d895eb9d0723e52cff8b21ef2deeaef1911d019c Diff: https://reviews.apache.org/r/38580/diff/ Testing --- make check. Thanks, Jojy Varghese

Re: Review Request 38580: Added docker registry RemotePuller

/slave/flags.cpp 029aa1eb00e1aa3e92c2155925022c17fd905862 src/tests/containerizer/provisioner_docker_tests.cpp d895eb9d0723e52cff8b21ef2deeaef1911d019c Diff: https://reviews.apache.org/r/38580/diff/ Testing --- make check. Thanks, Jojy Varghese

Re: Review Request 38941: Moved structs outside RegistryClient

/docker/registry_client.cpp c2040b48ea43fdb29766994c244273d3fa9ee3cd src/tests/containerizer/provisioner_docker_tests.cpp d895eb9d0723e52cff8b21ef2deeaef1911d019c Diff: https://reviews.apache.org/r/38941/diff/ Testing --- make check. Thanks, Jojy Varghese

Re: Review Request 38443: Added layerid information to ManifestResponse

/docker/registry_client.cpp c2040b48ea43fdb29766994c244273d3fa9ee3cd src/tests/containerizer/provisioner_docker_tests.cpp d895eb9d0723e52cff8b21ef2deeaef1911d019c Diff: https://reviews.apache.org/r/38443/diff/ Testing --- make check. Thanks, Jojy Varghese

Review Request 38941: Moved structs outside RegistryClient

/containerizer/provisioner_docker_tests.cpp d895eb9d0723e52cff8b21ef2deeaef1911d019c Diff: https://reviews.apache.org/r/38941/diff/ Testing --- make check. Thanks, Jojy Varghese

Re: Review Request 38579: Refactored registry client

. Thanks, Jojy Varghese

Re: Review Request 38579: Refactored registry client

/38941 - Jojy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38579/#review101267 --- On Oct. 1, 2015, 6:39 p.m., Jojy

Re: Review Request 38580: Added docker registry RemotePuller

unction of puller but maybe a Tar class. - Jojy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/#review101261 ---

Re: Review Request 38580: Added docker registry RemotePuller

changed to Docker or all of them? - Jojy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/#review101260 --- On Oct. 1, 201

Re: Review Request 38580: Added docker registry RemotePuller

ttps://reviews.apache.org/r/38580/#review101261 --- On Oct. 1, 2015, 6:40 p.m., Jojy Varghese wrote: > > --- > This is an automatically generated e-mail. To reply, visit:

Re: Review Request 38579: Refactored registry client

test had to be updated. - Jojy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38579/#review101263 --- On Oct. 1, 201

Re: Review Request 38580: Added docker registry RemotePuller

cbb67686d45513f0395a0cf1bc5c43cb4935adae src/slave/flags.hpp f76f0f6a0c7a01c7f061a225d7f6ef52be0ee7b5 src/slave/flags.cpp 029aa1eb00e1aa3e92c2155925022c17fd905862 Diff: https://reviews.apache.org/r/38580/diff/ Testing --- make check. Thanks, Jojy Varghese

Re: Review Request 38579: Refactored registry client

, Jojy Varghese

Re: Review Request 38747: Adding digest utilities

d in https://reviews.apache.org/r/34138/. -jojy - Jojy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38747/#review101257 --- On Sept

Re: Review Request 38910: Added `-v` flag to `docker rm`.

g/r/38910/#comment158537> wondering this behavior should be defaulted or not. We might be overloading stop with more than what it should be doing isnt it? Do we always want to force remove the volumes when docker stops? - Jojy Varghese On Sept. 30, 2015, 11:51 p.m., Greg Mann

Re: Review Request 38580: Added docker registry RemotePuller

cbb67686d45513f0395a0cf1bc5c43cb4935adae src/slave/flags.hpp f76f0f6a0c7a01c7f061a225d7f6ef52be0ee7b5 src/slave/flags.cpp 029aa1eb00e1aa3e92c2155925022c17fd905862 Diff: https://reviews.apache.org/r/38580/diff/ Testing --- make check. Thanks, Jojy Varghese

Re: Review Request 38579: Refactored registry client

://reviews.apache.org/r/38579/diff/ Testing --- make check. Thanks, Jojy Varghese

Re: Review Request 38747: Adding digest utilities

/diff/ Testing --- make check. Thanks, Jojy Varghese

Re: Review Request 38747: Adding digest utilities

://reviews.apache.org/r/38747/diff/ Testing --- make check. Thanks, Jojy Varghese

Re: Review Request 38747: Adding digest utilities

- On Sept. 29, 2015, 9:40 p.m., Jojy Varghese wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38747/ > -

Re: Review Request 38747: Adding digest utilities

check. Thanks, Jojy Varghese

Re: Review Request 38747: Adding digest utilities

--- make check. Thanks, Jojy Varghese

<    1   2   3   4   5   6   7   8   >