Re: Review Request 37827: Added a test for converting JSON arrays to repeated protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37827/#review96713 --- Ship it!

Re: Review Request 37187: Use std::unordered_{set, map} instead of boost::unordered_{set, map}.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37187/ --- (Updated Aug. 27, 2015, 6:22 p.m.) Review request for mesos, Alexander Rojas

Re: Review Request 37189: Added std::hash template specializations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37189/ --- (Updated Aug. 27, 2015, 8:02 p.m.) Review request for mesos, Alexander Rojas

Re: Review Request 37655: MESOS-3299: Add protobuf to represent time with integer precision.

On Aug. 27, 2015, 5:34 a.m., Neil Conway wrote: include/mesos/mesos.proto, line 102 https://reviews.apache.org/r/37655/diff/2/?file=1049806#file1049806line102 BTW, have you considered using a simpler representation, such as just a single int64 holding # of nanoseconds (or

Re: Review Request 37826: Introduced conversion of JSON arrays to repeated protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37826/#review96709 --- Ship it! Ship It! Note: This would be useful for maintenance

Re: Review Request 37189: Added std::hash template specializations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37189/#review96689 --- Patch looks great! Reviews applied: [37187, 37188, 37189] All

Re: Review Request 37189: Added std::hash template specializations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37189/ --- (Updated Aug. 27, 2015, 6:24 p.m.) Review request for mesos, Alexander Rojas

Re: Review Request 37655: MESOS-3299: Add protobuf to represent time with integer precision.

On Aug. 26, 2015, 10:34 p.m., Neil Conway wrote: Thanks for your comments! On Aug. 26, 2015, 10:34 p.m., Neil Conway wrote: include/mesos/mesos.proto, line 101 https://reviews.apache.org/r/37655/diff/2/?file=1049806#file1049806line101 It might be useful to specify what the

Re: Review Request 37655: MESOS-3299: Add protobuf to represent time with integer precision.

On Aug. 26, 2015, 11 p.m., Alexander Rukletsov wrote: Do you plan to migrate existing protobufs to `TimeSpec` or use it for new protobufs only? For now, the plan is to have new protobufs use it. And we can change existing protobufs to use it, if they benefit from having integer time.

Re: Review Request 37187: Use std::unordered_{set, map} instead of boost::unordered_{set, map}.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37187/ --- (Updated Aug. 27, 2015, 5:12 p.m.) Review request for mesos, Alexander Rojas

Re: Review Request 37189: Added std::hash template specializations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37189/ --- (Updated Aug. 27, 2015, 5:15 p.m.) Review request for mesos, Alexander Rojas

Re: Review Request 36404: Added support for peek() to process::io

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36404/ --- (Updated Aug. 27, 2015, 9:24 a.m.) Review request for mesos, Joris Van

Re: Review Request 36620: Added Non-Freezeer Task Killer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/#review96734 --- What's the status on this review? Is it still WIP? Would love to

Re: Review Request 36571: Maintenance Primitives: Add maintenance-related, registry protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36571/ --- (Updated Aug. 27, 2015, 12:33 p.m.) Review request for mesos, Benjamin

Re: Review Request 37655: MESOS-3299: Add protobuf to represent time with integer precision.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37655/ --- (Updated Aug. 27, 2015, 1:14 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 36571: Maintenance Primitives: Add maintenance-related, registry protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36571/ --- (Updated Aug. 27, 2015, 11:58 a.m.) Review request for mesos, Benjamin

Re: Review Request 36571: Maintenance Primitives: Add maintenance-related, registry protobufs.

On Aug. 26, 2015, 11:04 p.m., Alexander Rukletsov wrote: include/mesos/maintenance/maintenance.proto, line 56 https://reviews.apache.org/r/36571/diff/15/?file=1053335#file1053335line56 I'm not sure `0` is a valid protobuf tag. After double checking the docs... It is valid for

Re: Review Request 36321: Maintenance primitives: Add Unavailability and InverseOffer protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36321/#review96743 --- Ship it! include/mesos/mesos.proto (lines 926 - 927)

Re: Review Request 37189: Added std::hash template specializations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37189/#review96739 --- Ship it! Ship It! - Michael Park On Aug. 27, 2015, 6:02 p.m.,

Re: Review Request 37187: Use std::unordered_{set, map} instead of boost::unordered_{set, map}.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37187/#review96736 --- Ship it! Ship It! - Michael Park On Aug. 27, 2015, 4:22 p.m.,

Re: Review Request 37823: libprocess: Update vendored copy of google-glog to 0.3.4

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37823/ --- (Updated Aug. 27, 2015, 8:11 p.m.) Review request for mesos. Bugs:

Review Request 37853: Overlay filesystem provisioning backend

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37853/ --- Review request for mesos. Repository: mesos Description --- Implemented

Re: Review Request 37314: Maintenance Primitives: Populate master's maintenance-related local state upon recovery from registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37314/#review96748 --- Ship it! include/mesos/type_utils.hpp (lines 152 - 153)

Re: Review Request 37812: Used linux filesystem isolator by default if possible.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37812/ --- (Updated Aug. 27, 2015, 9:05 p.m.) Review request for mesos, Timothy Chen,

Re: Review Request 37197: Docker image store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37197/ --- (Updated Aug. 27, 2015, 9:49 p.m.) Review request for mesos, Ian Downes, Jie

Re: Review Request 37824: mesos: Updates for google-glog upgrade to 0.3.4

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37824/#review96747 --- Bad patch! Reviews applied: [37823] Failed command:

Re: Review Request 36571: Maintenance Primitives: Add maintenance-related, registry protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36571/#review96746 --- Ship it! include/mesos/maintenance/maintenance.proto (line 54)

Re: Review Request 37500: Update the FrameworkInfo.user on scheduler failover

On Aug. 24, 2015, 11:56 p.m., Vinod Kone wrote: This review is a bit hard to follow because it's doing multiple things. I would recommend you to split this into multiple reviews #1) Expose framework user in state.json #2) Update framework user on re-registration (need a test for

Re: Review Request 37856: Ensured that cgroups isolation is not used if multiple slaves are launched.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37856/#review96770 --- src/tests/environment.cpp

Re: Review Request 37497: Added Docker provisioner paths which handles path manipulation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37497/ --- (Updated Aug. 27, 2015, 9:57 p.m.) Review request for mesos, Ian Downes, Jie

Re: Review Request 37856: Ensured that cgroups isolation is not used if multiple slaves are launched.

On Aug. 27, 2015, 9:58 p.m., Timothy Chen wrote: src/tests/environment.cpp, line 298 https://reviews.apache.org/r/37856/diff/1/?file=1056473#file1056473line298 It works now? See my change in MultipleSlaves test. Basically, I fixed the isolation used in that test so that port

Re: Review Request 36571: Maintenance Primitives: Add maintenance-related, registry protobufs.

On Aug. 27, 2015, 6:04 a.m., Alexander Rukletsov wrote: include/mesos/maintenance/maintenance.proto, line 56 https://reviews.apache.org/r/36571/diff/15/?file=1053335#file1053335line56 I'm not sure `0` is a valid protobuf tag. Joseph Wu wrote: After double checking the

Re: Review Request 37325: Maintenance Primitives: Adds an endpoint for scheduling agents for maintenance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37325/#review96762 --- Ship it! src/master/http.cpp (line 1407)

Re: Review Request 37812: Used linux filesystem isolator by default if possible.

On Aug. 27, 2015, 12:03 a.m., Timothy Chen wrote: src/slave/containerizer/mesos/containerizer.cpp, line 145 https://reviews.apache.org/r/37812/diff/1/?file=1055255#file1055255line145 This is quite subtle, I think we should log and also put some documentation around slave that we

Re: Review Request 37813: Added additional diagnostic output when a fetcher cache test fails.

On Aug. 26, 2015, 4:03 p.m., Joseph Wu wrote: src/tests/fetcher_cache_tests.cpp, line 458 https://reviews.apache.org/r/37813/diff/1/?file=1055256#file1055256line458 Is it common knowledge that the sandbox holds the logs? (If not, a short comment would suffice.) It kinda is, but

Re: Review Request 36571: Maintenance Primitives: Add maintenance-related, registry protobufs.

On Aug. 27, 2015, 6:04 a.m., Alexander Rukletsov wrote: include/mesos/maintenance/maintenance.proto, lines 31-37 https://reviews.apache.org/r/36571/diff/15/?file=1053335#file1053335line31 IIUC, here you group a bunch of machines based on time intervals. Why this grouping is

Re: Review Request 37856: Ensured that cgroups isolation is not used if multiple slaves are launched.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37856/#review96775 --- Patch looks great! Reviews applied: [37726, 37734, 37735, 37738,

Re: Review Request 37497: Added Docker provisioner paths which handles path manipulation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37497/#review96780 --- Bad patch! Reviews applied: [37196, 37197, 37198, 37200] Failed

Re: Review Request 37497: Added Docker provisioner paths which handles path manipulation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37497/ --- (Updated Aug. 27, 2015, 11:44 p.m.) Review request for mesos, Ian Downes, Jie

Re: Review Request 37496: Move docker provisioner local store into dedicated folders.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37496/ --- (Updated Aug. 27, 2015, 11:43 p.m.) Review request for mesos, Till Toenshoff

Re: Review Request 37495: Docker provisioner local store unit tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37495/ --- (Updated Aug. 27, 2015, 11:42 p.m.) Review request for mesos, Ian Downes, Jie

Re: Review Request 36571: Maintenance Primitives: Add maintenance-related, registry protobufs.

On Aug. 26, 2015, 11:04 p.m., Alexander Rukletsov wrote: include/mesos/maintenance/maintenance.proto, lines 31-37 https://reviews.apache.org/r/36571/diff/15/?file=1053335#file1053335line31 IIUC, here you group a bunch of machines based on time intervals. Why this grouping is

Re: Review Request 37655: MESOS-3299: Add protobuf to represent time with integer precision.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37655/ --- (Updated Aug. 27, 2015, 3:24 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37853: Overlay filesystem provisioning backend

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37853/#review96763 --- This looks great! Thanks Mei! I think the main thing left here is

Re: Review Request 37821: Join threads in libprocess when shutting down.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37821/ --- (Updated Aug. 27, 2015, 10:59 p.m.) Review request for mesos, Benjamin

Re: Review Request 37655: MESOS-3299: Add protobuf to represent time with integer precision.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37655/#review96778 --- include/mesos/mesos.proto (line 97)

Re: Review Request 36321: Maintenance primitives: Add Unavailability and InverseOffer protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36321/ --- (Updated Aug. 27, 2015, 3:46 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37200: Refactored DockerImage struct to store a list of layer ids instead of linked list of DockerLayers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37200/ --- (Updated Aug. 27, 2015, 11:41 p.m.) Review request for mesos, Ian Downes, Jie

Re: Review Request 37247: Added Docker image reference store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37247/ --- (Updated Aug. 27, 2015, 11:41 p.m.) Review request for mesos, Till Toenshoff

Re: Review Request 37198: Add Docker image provisioner and copy backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37198/ --- (Updated Aug. 27, 2015, 11:40 p.m.) Review request for mesos, Ian Downes, Jie

Re: Review Request 36571: Maintenance Primitives: Add maintenance-related, registry protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36571/ --- (Updated Aug. 27, 2015, 4:41 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37314: Maintenance Primitives: Populate master's maintenance-related local state upon recovery from registry.

On Aug. 26, 2015, 11:05 p.m., Alexander Rukletsov wrote: include/mesos/maintenance/maintenance.hpp, line 29 https://reviews.apache.org/r/37314/diff/6/?file=1053339#file1053339line29 If it's not a protobuf, remove `Info` suffix. The suffix is there only to avoid collisions between

Re: Review Request 37821: Join threads in libprocess when shutting down.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37821/#review96823 --- Patch looks great! Reviews applied: [37821] All tests passed. -

Re: Review Request 37532: Add QUIESCE call interface to the scheduler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37532/ --- (Updated Aug. 28, 2015, 5:53 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 37532: Add QUIESCE call interface to the scheduler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37532/ --- (Updated Aug. 28, 2015, 1:35 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 37173: Maintenance Primitives: Added unavailability to Allocator's Slave struct.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37173/#review96809 --- include/mesos/master/allocator.proto (line 31)

Re: Review Request 37773: Docker: Adding registry client.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37773/#review96813 --- Bad patch! Reviews applied: [37426, 37427] Failed command:

Re: Review Request 37280: Maintenance Primitives: Added updateInverseOffer to Allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37280/#review96836 --- Ship it! Ship It! - Jian Qiu On 八月 26, 2015, 2:13 a.m., Joris

Re: Review Request 37314: Maintenance Primitives: Populate master's maintenance-related local state upon recovery from registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37314/#review96643 --- include/mesos/maintenance/maintenance.hpp (line 29)

Re: Review Request 36571: Maintenance Primitives: Add maintenance-related, registry protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36571/#review96642 --- include/mesos/maintenance/maintenance.proto (lines 31 - 37)

Re: Review Request 37325: Maintenance Primitives: Adds an endpoint for scheduling agents for maintenance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37325/#review96649 --- Not a full review, mostly nit-picks. Will do a second pass.

Re: Review Request 37821: Join threads in libprocess when shutting down.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37821/#review96655 --- 3rdparty/libprocess/src/process.cpp (line 2210)

Re: Review Request 37821: Join threads in libprocess when shutting down.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37821/#review96653 --- Patch looks great! Reviews applied: [37821] All tests passed. -

Re: Review Request 37821: Join threads in libprocess when shutting down.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37821/#review96654 --- Sorry folks, there seems to be some kind of data race here... after

Re: Review Request 36404: Added support for peek() to process::io

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36404/#review96657 --- Patch looks great! Reviews applied: [36999, 36646, 36404] All

Re: Review Request 37187: Use std::unordered_{set, map} instead of boost::unordered_{set, map}.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37187/ --- (Updated Aug. 27, 2015, 1:38 p.m.) Review request for mesos, Alexander Rojas

Re: Review Request 36571: Maintenance Primitives: Add maintenance-related, registry protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36571/#review96796 --- include/mesos/maintenance/maintenance.proto (lines 37 - 39)

Re: Review Request 35330: Capped number of parallel inspect instances on a docker ps call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35330/#review96798 --- Ship it! Ship It! - Timothy Chen On Aug. 27, 2015, 11 p.m.,

Re: Review Request 37863: Fixed user cgroup failing test on centos 7.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37863/#review96797 --- Ship it! src/tests/containerizer/isolator_tests.cpp (lines 1268 -

Re: Review Request 37821: Join threads in libprocess when shutting down.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37821/#review96802 --- Patch looks great! Reviews applied: [37821] All tests passed. -

Re: Review Request 37773: Docker: Adding registry client.

On Aug. 26, 2015, midnight, Lily Chen wrote: This was a WIP for you to get the patch :). Anywaz addressed the issues. On Aug. 26, 2015, midnight, Lily Chen wrote: src/slave/containerizer/provisioners/docker/registry_client.hpp, line 89

Re: Review Request 37170: Maintenance Primitives: Added `Machine` to Slave struct in Master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37170/#review96806 --- Ship it! Barring the s/MachineInfo/MachineID/ renames from

Re: Review Request 37427: Docker registry: adding TokenManager.

On Aug. 28, 2015, 12:18 a.m., Timothy Chen wrote: src/slave/containerizer/provisioners/docker/token_manager.hpp, line 69 https://reviews.apache.org/r/37427/diff/12/?file=1052806#file1052806line69 is exp and nbf web token fields? Yes. On Aug. 28, 2015, 12:18 a.m., Timothy Chen

Re: Review Request 37773: Docker: Adding registry client.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37773/ --- (Updated Aug. 28, 2015, 12:47 a.m.) Review request for mesos, Lily Chen and

Re: Review Request 37497: Added Docker provisioner paths which handles path manipulation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37497/#review96812 --- Patch looks great! Reviews applied: [37196, 37197, 37198, 37200,

Re: Review Request 36571: Maintenance Primitives: Add maintenance-related, registry protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36571/ --- (Updated Aug. 27, 2015, 5:57 p.m.) Review request for mesos, Benjamin Hindman,