Re: Review Request 38158: Refactored Value::Ranges coalesce().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38158/#review99491 --- Patch looks great! Reviews applied: [38158] All tests passed. -

Re: Review Request 38470: Maintenance Primitives: Fix error in master's Accept/Decline for inverse offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38470/#review99496 --- Ship it! Ship It! - Guangya Liu On 九月 17, 2015, 10:50 p.m.,

Re: Review Request 38158: Refactored Value::Ranges coalesce().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38158/ --- (Updated Sept. 18, 2015, 6:39 a.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 38475: Maintenance Primitives: Add test for inverse offer filters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38475/#review99631 --- Patch looks great! Reviews applied: [38244, 38246, 38324, 38475]

Re: Review Request 37714: Updated Multimap and multihashmap so their signatures resemble that of hashmap and hashset.

> On Sept. 9, 2015, 11:46 p.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/multihashmap.hpp, lines > > 96-97 > > > > > > `s/std::make_pair(key, value)/{key, value}/` > > Alexander

Re: Review Request 38074: Calculate schedule latency with trace events

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38074/#review99634 --- Patch looks great! Reviews applied: [37540, 37541, 38074] All

Re: Review Request 38279: Enabled resources/attributes discovery

> On Sept. 14, 2015, 5:34 p.m., Connor Doyle wrote: > > src/hook/manager.cpp, line 261 > > > > > > Please add a comment describing how the order of hook execution is > > determined. e.g. order in which they appear

Re: Review Request 37585: Maintenance primitives: Add a user doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37585/#review99635 --- docs/maintenance.md (line 25)

Re: Review Request 38259: [MESOS-3340] Command-line flags should take precedence over OS Env variables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38259/ --- (Updated Sept. 19, 2015, 12:51 a.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 38496: Added devolve operation for V1 Executor Protobuf

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38496/#review99640 --- Ship it! Ship It! - Guangya Liu On 九月 18, 2015, 5:18 p.m.,

Re: Review Request 38347: Add HELP Message for Reserve/Unreserve endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38347/#review99641 --- Patch looks great! Reviews applied: [38347] All tests passed. -

Re: Review Request 37585: Maintenance primitives: Add a user doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37585/ --- (Updated Sept. 18, 2015, 12:51 p.m.) Review request for mesos, Benjamin

Re: Review Request 38497: Introduced Executor HTTP endpoint on Agent

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38497/#review99590 --- Ship it! Ship It! - Vinod Kone On Sept. 18, 2015, 5:18 p.m.,

Review Request 38516: Changed quiesceOffers to SuppressOffers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38516/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-3037

Review Request 38514: Update QUIESCE to SUPPRESS in Mesos Call

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38514/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-3037

Re: Review Request 38279: Enabled resources/attributes discovery

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38279/ --- (Updated Sept. 19, 2015, 12:51 a.m.) Review request for mesos, Connor Doyle

Re: Review Request 38259: [MESOS-3340] Command-line flags should take precedence over OS Env variables

> On Sept. 18, 2015, 8:03 p.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp, lines > > 240-241 > > > > > > How about we remove this, inline the string literal at the 2

Re: Review Request 38279: Enabled resources/attributes discovery

> On Sept. 14, 2015, 6:12 p.m., Connor Doyle wrote: > > src/hook/manager.cpp, line 261 > > > > > > Please also add a test that verifies that the hooks are executed in the > > expected order. For example, have two

Review Request 38517: Make attributes.hpp public

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38517/ --- Review request for mesos, Connor Doyle and Niklas Nielsen. Bugs: MESOS-3366

Re: Review Request 38516: Changed quiesceOffers to SuppressOffers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38516/ --- (Updated Sept. 19, 2015, 1:27 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 37585: Maintenance primitives: Add a user doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37585/ --- (Updated Sept. 18, 2015, 6:27 p.m.) Review request for mesos, Benjamin

Re: Review Request 38251: FrameworkInfo should only be updated if the re-registration is valid

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38251/#review99632 --- Thanks for fixing this @gyliu ! Just a minor comment about a

Re: Review Request 38514: Update QUIESCE to SUPPRESS in Mesos Call

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38514/ --- (Updated Sept. 19, 2015, 1:27 a.m.) Review request for mesos and Vinod Kone.

Review Request 38519: Change function quiesce() to suppressRes()

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38519/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-3037

Re: Review Request 37585: Maintenance primitives: Add a user doc.

> On Sept. 18, 2015, 5:52 p.m., Artem Harutyunyan wrote: > > docs/maintenance.md, line 27 > > > > > > Did the notion of an operator not exist before Maintenance Primitives > > were introduced? I would rephrase the

Review Request 38481: Fix UUID::random compile error in OSX.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38481/ --- Review request for mesos, Alexander Rojas, Ben Mahler, Klaus Ma, and Michael

Re: Review Request 38051: Only update the task status when its old status is not terminal.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38051/ --- (Updated Sept. 18, 2015, 7:15 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 38051: Only update the task status when its old status is not terminal.

> On Sept. 17, 2015, 10:25 p.m., Vinod Kone wrote: > > Can you write a test for this? I find the code changes in this patch does not be tested with an end-to-end case except to check the error log messages of master, so my test strategy are: 1. Change the python test executor to send the

Re: Review Request 38481: Fix UUID::random compile error in OSX.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38481/#review99510 --- Ship it! Assuming the mix of `thread local` and `static` work as

Re: Review Request 38481: Fix UUID::random compile error in OSX.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38481/ --- (Updated Sept. 18, 2015, 9:25 a.m.) Review request for mesos, Alexander Rojas,

Re: Review Request 38051: Only update the task status when its old status is not terminal.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38051/#review99508 --- Patch looks great! Reviews applied: [38051] All tests passed. -

Re: Review Request 38499: Tests for executor endpoint on agent

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38499/#review99584 --- Patch looks great! Reviews applied: [38496, 38497, 38499] All

Re: Review Request 37585: Maintenance primitives: Add a user doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37585/#review99596 --- Patch looks great! Reviews applied: [37585] All tests passed. -

Re: Review Request 38259: [MESOS-3340] Command-line flags should take precedence over OS Env variables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38259/#review99588 --- Ship it!

Re: Review Request 38470: Maintenance Primitives: Fix error in master's Accept/Decline for inverse offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38470/#review99587 --- Ship it! Fixed before committing.

Re: Review Request 38347: Add HELP Message for Reserve/Unreserve endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38347/#review99585 --- Bad patch! Reviews applied: [38347] Failed command:

Re: Review Request 38470: Maintenance Primitives: Fix error in master's Accept/Decline for inverse offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38470/#review99572 --- Patch looks great! Reviews applied: [38470] All tests passed. -

Re: Review Request 38347: Add HELP Message for Reserve/Unreserve endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38347/#review99574 --- src/master/http.cpp (line 669)

Re: Review Request 38496: Added devolve operation for V1 Executor Protobuf

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38496/#review99589 --- Ship it! Ship It! - Vinod Kone On Sept. 18, 2015, 5:18 p.m.,

Re: Review Request 38517: Make attributes.hpp public

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38517/#review99652 --- Patch looks great! Reviews applied: [38517] All tests passed. -

Re: Review Request 38259: [MESOS-3340] Command-line flags should take precedence over OS Env variables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38259/#review99646 --- Patch looks great! Reviews applied: [38259] All tests passed. -

Re: Review Request 38511: Added a warning comment to the copy provisioner backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38511/#review99644 --- Patch looks great! Reviews applied: [38511] All tests passed. -

Re: Review Request 38279: Enabled resources/attributes discovery

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38279/#review99647 --- Patch looks great! Reviews applied: [38279] All tests passed. -

Re: Review Request 38473: Add flag to disable hostname lookup.

> On 九月 18, 2015, 10:57 p.m., Cong Wang wrote: > > Why not just set --host_name=$LIBPROCESS_IP for your case since you anyway > > need to provide a flag? I also have the same question with Cong, @Marco, can you please show more detail for why not using the solution as above? What is the

Re: Review Request 38511: Added a warning comment to the copy provisioner backend.

> On Sept. 18, 2015, 10:22 p.m., Timothy Chen wrote: > > src/slave/containerizer/provisioner/backends/copy.hpp, line 38 > > > > > > most of the comments makes sense. > > however what do you mean by writing to

Re: Review Request 38246: Added propagation of Resources and Unavailability from the InverseOffer protobuf to the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38246/#review99649 --- Ship it! Ship It! - Guangya Liu On 九月 18, 2015, 10:55 p.m.,

Re: Review Request 38244: Renamed Filter to OfferFilter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38244/#review99650 --- Ship it! Ship It! - Guangya Liu On 九月 18, 2015, 10:55 p.m.,

Re: Review Request 37873: Add quiesce logic in allocator

> On 九月 17, 2015, 9:42 p.m., Vinod Kone wrote: > > src/tests/mesos.hpp, line 1608 > > > > > > Needs a test for the scheduler driver. I've only see one for the http > > scheduler library. > > > > Also, can

Re: Review Request 38511: Added a warning comment to the copy provisioner backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38511/#review99653 --- src/slave/containerizer/provisioner/backends/copy.hpp (line 38)

Re: Review Request 37541: Add trace event API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37541/ --- (Updated Sept. 18, 2015, 10:12 p.m.) Review request for mesos, Chi Zhang, Ian

Re: Review Request 38473: Add flag to disable hostname lookup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38473/#review99628 --- Why not just set --host_name=$LIBPROCESS_IP for your case since you

Re: Review Request 38457: CMake: Fix MESOS-3250, a dynamic load error in Stout tests on OS X.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38457/#review99599 --- You should consider adding a CMake macro to make this more

Re: Review Request 37813: Added additional diagnostic output when a fetcher cache test fails.

> On Aug. 26, 2015, 4:03 p.m., Joseph Wu wrote: > > Looks good. Any updates on this? (Haven't come across this test failure recently, but it's still nice to have.) - Joseph --- This is an automatically generated e-mail. To reply,

Re: Review Request 38496: Added devolve operation for V1 Executor Protobuf

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38496/#review99614 --- Ship it! Ship It! - Isabel Jimenez On Sept. 18, 2015, 5:18

Re: Review Request 38511: Added a warning comment to the copy provisioner backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38511/#review99625 --- Ship it! Ship It! - Jie Yu On Sept. 18, 2015, 10:13 p.m., Jiang

Re: Review Request 37532: Add QUIESCE call interface to the scheduler

> On 九月 18, 2015, 9:06 p.m., Vinod Kone wrote: > > i'm going to commit this chain now. after talking some other committers, > > SUPPRESS name is still preferablet o QUIESCE. so lets see if you or I can > > make that work (after this chain gets committed). Thanks Vinod. I can work on the

Review Request 38511: Added a warning comment to the copy provisioner backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38511/ --- Review request for mesos, Jie Yu, Jojy Varghese, and Timothy Chen. Repository:

Re: Review Request 38074: Calculate schedule latency with trace events

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38074/ --- (Updated Sept. 18, 2015, 10:13 p.m.) Review request for mesos, Chi Zhang, Ian

Re: Review Request 38473: Add flag to disable hostname lookup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38473/ --- (Updated Sept. 18, 2015, 9:53 p.m.) Review request for mesos, Benjamin

Re: Review Request 38475: Maintenance Primitives: Add test for inverse offer filters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38475/ --- (Updated Sept. 18, 2015, 3 p.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 38246: Added propagation of Resources and Unavailability from the InverseOffer protobuf to the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38246/ --- (Updated Sept. 18, 2015, 3:55 p.m.) Review request for mesos, Benjamin

Re: Review Request 38244: Renamed Filter to OfferFilter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38244/ --- (Updated Sept. 18, 2015, 3:55 p.m.) Review request for mesos, Benjamin

Re: Review Request 38324: Added support for setting accept and decline filters on inverse offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38324/ --- (Updated Sept. 18, 2015, 3:55 p.m.) Review request for mesos, Joris Van

Re: Review Request 38051: Only update the task status when its old status is not terminal.

> On Sept. 17, 2015, 10:25 p.m., Vinod Kone wrote: > > Can you write a test for this? > > Yong Qiao Wang wrote: > I find the code changes in this patch does not be tested with an > end-to-end case except to check the error log messages of master, so my test > strategy are: > > 1.

Re: Review Request 38473: Add flag to disable hostname lookup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38473/#review99616 --- Ship it! Ship It! - Neil Conway On Sept. 18, 2015, 9:53 p.m.,

Re: Review Request 38158: Refactored Value::Ranges coalesce().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38158/#review99500 --- Patch looks great! Reviews applied: [38158] All tests passed. -

Re: Review Request 38481: Fix UUID::random compile error in OSX.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38481/#review99528 --- Ship it! Ship It! - Klaus Ma On Sept. 18, 2015, 9:25 a.m.,

Re: Review Request 37969: Maintenance primitives: Tweak validation error messages to return JSON rather than protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37969/#review99555 --- Ship it! Ship It! - Joris Van Remoortere On Sept. 15, 2015,

Re: Review Request 38011: Maintenance Primitives: Use the parse<RepeatedPtrField> helper instead of a plural MachineID protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38011/#review99579 --- Ship it! Fixed inline. src/tests/master_maintenance_tests.cpp

Re: Review Request 38470: Maintenance Primitives: Fix error in master's Accept/Decline for inverse offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38470/ --- (Updated Sept. 18, 2015, 1:29 p.m.) Review request for mesos, Benjamin

Re: Review Request 38481: Fix UUID::random compile error in OSX.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38481/#review99542 --- Ship it! Ship It! - Ben Mahler On Sept. 18, 2015, 9:25 a.m.,

Re: Review Request 38491: Logged requests related to dynamic reservations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38491/#review99537 --- Patch looks great! Reviews applied: [38491] All tests passed. -

Re: Review Request 38470: Maintenance Primitives: Fix error in master's Accept/Decline for inverse offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38470/ --- (Updated Sept. 18, 2015, 10:06 a.m.) Review request for mesos, Benjamin

Review Request 38496: Added devolve operation for V1 Executor Protobuf

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38496/ --- Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone. Bugs:

Review Request 38497: Introduced Executor HTTP endpoint on Agent

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38497/ --- Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone. Bugs:

Review Request 38499: Tests for executor endpoint on agent

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38499/ --- Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone. Bugs: