Re: Review Request 42172: Add documentation for logging and ContainerLogger.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42172/#review115374 --- Patch looks great! Reviews applied: [42172] Passed command: expor

Re: Review Request 41772: Added helper function to flatten resources.

> On Jan. 20, 2016, 6:18 a.m., Joseph Wu wrote: > > src/common/resources.cpp, line 880 > > > > > > It should be fine to just name this `flatten`. > > > > You should also consider changing the parameter type

Re: Review Request 42516: Add support for user-defined networks.

> On 一月 19, 2016, 11:29 p.m., Guangya Liu wrote: > > include/mesos/mesos.proto, line 1469 > > > > > > What about name it as OVERLAY? > > Ezra Silvera wrote: > We choose USER because it is defined by Docker as "

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/#review115372 --- include/mesos/mesos.proto (line 1499)

Re: Review Request 41772: Added helper function to flatten resources.

> On 一月 19, 2016, 10:18 p.m., Joseph Wu wrote: > > src/common/resources.cpp, line 880 > > > > > > It should be fine to just name this `flatten`. > > > > You should also consider changing the parameter type f

Re: Review Request 41789: Expose the http::internal::request function.

> On Jan. 11, 2016, 8:12 a.m., Adam B wrote: > > 3rdparty/libprocess/src/http.cpp, lines 1218-1221 > > > > > > Will you add `query` as a parameter only once you've moved `get()` over > > to this? > > > >

Re: Review Request 42252: Enabled master totalResources include allocation slack.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42252/ --- (Updated 一月 20, 2016, 7:29 a.m.) Review request for mesos, Ben Mahler, Artem Ha

Re: Review Request 41789: Expose the http::internal::request function.

> On Jan. 20, 2016, 3:11 a.m., Adam B wrote: > > 3rdparty/libprocess/include/process/http.hpp, lines 812-814 > > > > > > Seems like a good candidate for a doxygen-style @param I think @param is for /* */ style.

Re: Review Request 42252: Enabled master totalResources include allocation slack.

> On 一月 20, 2016, 12:16 a.m., Joseph Wu wrote: > > Considering that https://reviews.apache.org/r/41847/ has the same change, > > it may be appropriate to add a `Resources::nonUsageSlack()` helper. Added a helper here https://reviews.apache.org/r/42547/ - Guangya

Review Request 42547: Added helper function to get non usage slack resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42547/ --- Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, J

Re: Review Request 42535: Made allocator's pause/resume idempotent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42535/#review115365 --- src/master/allocator/mesos/hierarchical.cpp (line 1048)

Re: Review Request 41672: Test case(s) for weights + allocation behaviour.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41672/#review115364 --- src/tests/hierarchical_allocator_tests.cpp (line 2352)

Re: Review Request 42252: Enabled master totalResources include allocation slack.

> On 一月 20, 2016, 3:43 a.m., Klaus Ma wrote: > > src/master/master.cpp, line 4659 > > > > > > It checked Optimistic Offer Phase 1 is enabled in > > https://reviews.apache.org/r/41847/. But I think it's not necessar

Re: Review Request 41672: Test case(s) for weights + allocation behaviour.

> On Jan. 20, 2016, 6:09 a.m., Adam B wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 2177-2178 > > > > > > Where do you verify that role2 doesn't get any offers? Shouldn't you > > verify that `alloca

Re: Review Request 41672: Test case(s) for weights + allocation behaviour.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41672/ --- (Updated Jan. 20, 2016, 6:49 a.m.) Review request for mesos, Adam B, Neil Conwa

Re: Review Request 42516: Add support for user-defined networks.

> On Jan. 19, 2016, 11:29 p.m., Guangya Liu wrote: > > A unit test also needed, please refer to > > https://github.com/apache/mesos/blob/master/src/tests/containerizer/docker_containerizer_tests.cpp#L297 > > for detail Thanks. I'll have a look. We will probably need to add support for "create

Re: Review Request 42194: Handle unreserve logic for dynamic reservation (3/3).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42194/ --- (Updated 一月 20, 2016, 6:42 a.m.) Review request for mesos, Ben Mahler, Artem Ha

Re: Review Request 42113: Handle unreserve logic for dynamic reservation (2/3).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42113/ --- (Updated 一月 20, 2016, 6:41 a.m.) Review request for mesos, Ben Mahler, Artem Ha

Re: Review Request 41791: Updated allocation slack when dynamic reserve new resources (1/3).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41791/ --- (Updated 一月 20, 2016, 6:38 a.m.) Review request for mesos, Ben Mahler, Artem Ha

Re: Review Request 41791: Updated allocation slack for dynamic reserve (1/3).

> On 一月 19, 2016, 11:34 p.m., Joseph Wu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 676 > > > > > > I see several places where you overwrite changes from this review in > > the subsequent two. Did

Re: Review Request 41847: Updated allocation slack when slave was updated.

> On 一月 16, 2016, 2:21 a.m., Joseph Wu wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 529-535 > > > > > > What if you did this? > > ``` > > slaves[slaveId]total = slaves[slaveId].total.nonUsage

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40632/ --- (Updated 一月 20, 2016, 6:25 a.m.) Review request for mesos, Ben Mahler, Artem Ha

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

> On 一月 19, 2016, 11:09 p.m., Joseph Wu wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 1995-1997 > > > > > > Consider moving this test to after you've implemented optimistic offers > > for `Allocator

Re: Review Request 41597: Extending allocator interface to support dynamic weights.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Jan. 20, 2016, 6:21 a.m.) Review request for mesos, Adam B, Neil Conwa

Re: Review Request 41672: Test case(s) for weights + allocation behaviour.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41672/#review115354 --- Ship it! Looks great! Doesn't look like you're verifying the first

Re: Review Request 40731: Added a fixture to test the floating point precision during CPU resource allocation. This patch is based on the commit submitted by : Mandeep (@mchadha) https://reviews.apach

> On Jan. 19, 2016, 10:37 a.m., Bernd Mathiske wrote: > > src/tests/reservation_tests.cpp, line 253 > > > > > > Could we check for 0.2 CPU here? This makes sense. Will modify the expectation, test and upload a chang

Re: Review Request 40731: Added a fixture to test the floating point precision during CPU resource allocation. This patch is based on the commit submitted by : Mandeep (@mchadha) https://reviews.apach

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40731/ --- (Updated Jan. 20, 2016, 6:08 a.m.) Review request for mesos, Bernd Mathiske, Kl

Re: Review Request 41772: Added helper function to flatten resources.

> On Jan. 20, 2016, 6:18 a.m., Joseph Wu wrote: > > src/common/resources.cpp, line 880 > > > > > > It should be fine to just name this `flatten`. > > > > You should also consider changing the parameter type

Re: Review Request 41963: Logger Module: Implement ContainerLogger recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41963/#review115355 --- Patch looks great! Reviews applied: [42052, 41779, 41780, 42358, 4

Re: Review Request 41672: Test case(s) for weights + allocation behaviour.

> On Jan. 11, 2016, 2:13 a.m., Adam B wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 2218-2219 > > > > > > Why hardcode 3? I'd think you could just run a while loop and actually > > assert the size th

Re: Review Request 41597: Extending allocator interface to support dynamic weights.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/#review115349 --- Ship it! Looks great. Just a couple of nits after your recent chan

Re: Review Request 42211: Added filters to disable NetClsIsolator tests in case the net_cls cgroup subsystem is disabled.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42211/ --- (Updated Jan. 20, 2016, 5:15 a.m.) Review request for mesos and Jie Yu. Summa

Re: Review Request 42098: Added unit test-case for CgroupsNetClsIsolatorProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42098/ --- (Updated Jan. 20, 2016, 5:13 a.m.) Review request for mesos, Jie Yu and Joseph

Re: Review Request 42097: Added cgroup/net_cls to the mesos containerizer isolation flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42097/ --- (Updated Jan. 20, 2016, 5:11 a.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 42048: Implemented the CgroupsNetClsIsolatorProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42048/ --- (Updated Jan. 20, 2016, 5:10 a.m.) Review request for mesos and Jie Yu. Summa

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

> On 一月 16, 2016, 2:11 a.m., Joseph Wu wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 1291-1319 > > > > > > None of this should be necessary: > > > > 1) You should have all the allocation sl

Re: Review Request 42047: Specified the CgroupsNetClsIsolatorProcess class. This adds the ability to isolate a mesos container using the net_cls cgroup subsystem.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42047/ --- (Updated Jan. 20, 2016, 5:05 a.m.) Review request for mesos and Jie Yu. Summa

Re: Review Request 42355: Removed the timeout from the filter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42355/#review115347 --- Patch looks great! Reviews applied: [42355] Passed command: expor

Review Request 42546: Updated `Master::Http::stateSummary` to use `jsonify`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42546/ --- Review request for mesos and Benjamin Hindman. Repository: mesos Description

Review Request 42543: Added overloads for `JSON::NumberWriter` and `json` to handle `size_t`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42543/ --- Review request for mesos and Benjamin Hindman. Bugs: MESOS-4435 https://iss

Re: Review Request 41780: Changed ContainerLogger and Fetcher to not duplicate FDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41780/ --- (Updated Jan. 19, 2016, 7:41 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 42252: Enabled master totalResources include allocation slack.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42252/#review115341 --- Patch looks great! Reviews applied: [40375, 41334, 41333, 40529, 4

Re: Review Request 42368: Added reservation endpoint test without auth and principal.

> On Jan. 20, 2016, 12:44 a.m., Michael Park wrote: > > src/tests/reservation_endpoints_tests.cpp, lines 1173-1184 > > > > > > Why are we testing for this? > > Greg Mann wrote: > When we met previously, Vinod m

Re: Review Request 41781: Logger Module: Add test for the rotating container logger module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41781/ --- (Updated Jan. 19, 2016, 7:41 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 42530: Changed `createReservationInfo` to take `Option`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42530/ --- (Updated Jan. 20, 2016, 3:40 a.m.) Review request for mesos and Michael Park.

Re: Review Request 42172: Add documentation for logging and ContainerLogger.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42172/ --- (Updated Jan. 19, 2016, 7:41 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 41783: Logger Module: Implement the rotating container logger module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41783/ --- (Updated Jan. 19, 2016, 7:41 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 42368: Added reservation endpoint test without auth and principal.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42368/ --- (Updated Jan. 20, 2016, 3:43 a.m.) Review request for mesos, Jie Yu, Michael Pa

Re: Review Request 41772: Added helper function to flatten resources.

> On Jan. 20, 2016, 6:18 a.m., Joseph Wu wrote: > > src/common/resources.cpp, lines 874-877 > > > > > > This is pretty much a copy of `Resources::reserved` now. You can > > remove it. > > Guangya Liu wrote: >

Re: Review Request 42361: Added dynamic reservation test with no principal.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42361/ --- (Updated Jan. 20, 2016, 3:42 a.m.) Review request for mesos, Jie Yu, Michael Pa

Re: Review Request 41962: Logger Module: Add tests for module recovery after agent failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41962/ --- (Updated Jan. 19, 2016, 7:42 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 42252: Enabled master totalResources include allocation slack.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42252/#review115339 --- src/master/master.cpp (line 4659)

Re: Review Request 41782: Logger Module: Wire up the rotating container logger module and test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41782/ --- (Updated Jan. 19, 2016, 7:41 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 41963: Logger Module: Implement ContainerLogger recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41963/ --- (Updated Jan. 19, 2016, 7:41 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 41779: Extended Subprocess::FD to optionally not duplicate the given FD.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41779/ --- (Updated Jan. 19, 2016, 7:41 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 42374: Logger Module: Add test filter for tests requiring `logrotate`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42374/ --- (Updated Jan. 19, 2016, 7:41 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 41772: Added helper function to flatten resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41772/ --- (Updated 一月 20, 2016, 3:40 a.m.) Review request for mesos, Ben Mahler, Artem Ha

Re: Review Request 41772: Added helper function to flatten resources.

> On 一月 19, 2016, 10:18 p.m., Joseph Wu wrote: > > src/common/resources.cpp, lines 874-877 > > > > > > This is pretty much a copy of `Resources::reserved` now. You can > > remove it. The reason that I keep this is

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

> On 十二月 30, 2015, 12:42 p.m., Klaus Ma wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1321 > > > > > > As framework can not use ALLOCATION_SLACK mixed with other resources, > > allocator need to chec

Re: Review Request 40379: MESOS-3930: Set resource type as USAGE_SLACK for Oversubscription.

> On Jan. 20, 2016, 8:25 a.m., Joseph Wu wrote: > > Can you talk to Guangya and merge this patch with > > https://reviews.apache.org/r/42123/ ? Logically, they're touching the same > > things. Sure, we'll sync up to merge them. - Klaus -

Re: Review Request 41858: Added helper functions to kill executor.

> On Jan. 8, 2016, 3:49 p.m., Jian Qiu wrote: > > src/slave/slave.cpp, line 4886 > > > > > > Should this be used also by qos_correction? > > Guangya Liu wrote: > Want to leverage but because of `log` issues, th

Re: Review Request 41789: Expose the http::internal::request function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41789/#review115326 --- Looks good. Besides the previously mentioned `http::request()` name

Re: Review Request 41491: Exposed docker/appc image manifest to mesos containerizer.

> On Jan. 17, 2016, 10:57 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/provisioner/provisioner.hpp, line 60 > > > > > > We only expose Docker image manifest? But the summary of this RR says > > we will

Re: Review Request 41491: Exposed docker image manifest to mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41491/ --- (Updated Jan. 19, 2016, 6:56 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 41333: Added helper functions to filter usage slack resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41333/ --- (Updated 一月 20, 2016, 2:55 a.m.) Review request for mesos, Ben Mahler, Artem Ha

Re: Review Request 41789: Expose the http::internal::request function.

> On Jan. 11, 2016, 12:12 a.m., Adam B wrote: > > 3rdparty/libprocess/src/http.cpp, lines 1218-1221 > > > > > > Will you add `query` as a parameter only once you've moved `get()` over > > to this? > > > >

Re: Review Request 41334: Added helper functions to filter allocation slack resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41334/ --- (Updated 一月 20, 2016, 2:51 a.m.) Review request for mesos, Ben Mahler, Artem Ha

Re: Review Request 42517: Added discussion about allowing multiple frameworks in a role.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42517/#review115330 --- docs/persistent-volume.md (line 404)

Re: Review Request 42390: Fixed fetching uris when slave is running inside a container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42390/#review115328 --- Ship it! Ship It! - haosdent huang On Jan. 17, 2016, 3:33 a.m.,

Re: Review Request 42355: Removed the timeout from the filter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42355/#review115327 --- What about inverseOfferFilter? - Guangya Liu On 一月 19, 2016, 11:

Re: Review Request 42471: Multiple Disk: Adjusted resource arithmetic for 'DiskInfo.Source'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42471/#review115324 --- Ship it! Ship It! - Jie Yu On Jan. 20, 2016, 2:29 a.m., Joris V

Re: Review Request 42470: Multiple Disk: Added 'Source' to 'Resource.DiskInfo'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42470/#review115323 --- Ship it! Ship It! - Jie Yu On Jan. 20, 2016, 2:28 a.m., Joris V

Re: Review Request 40266: Libprocess Reinitialization: Cleanup SocketManager along side ProcessManager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40266/#review115322 --- 3rdparty/libprocess/src/process.cpp (line 1306)

Re: Review Request 42471: Multiple Disk: Adjusted resource arithmetic for 'DiskInfo.Source'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42471/ --- (Updated Jan. 20, 2016, 2:29 a.m.) Review request for mesos, Jie Yu and Michael

Re: Review Request 42470: Multiple Disk: Added 'Source' to 'Resource.DiskInfo'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42470/ --- (Updated Jan. 20, 2016, 2:28 a.m.) Review request for mesos, Jie Yu and Michael

Re: Review Request 42535: Made allocator's pause/resume idempotent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42535/#review115321 --- Ship it! Ship It! - Guangya Liu On 一月 20, 2016, 2:09 a.m., Alex

Re: Review Request 41783: Implement the rotating container logger module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41783/#review115318 --- src/slave/container_loggers/rotate.cpp (lines 128 - 131)

Review Request 42535: Made allocator's pause/resume idempotent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42535/ --- Review request for mesos, Ben Mahler and Joris Van Remoortere. Bugs: MESOS-4417

Re: Review Request 42355: Removed the timeout from the filter.

> On Jan. 20, 2016, 1:49 a.m., Qian Zhang wrote: > > One question: Say allocation interval is 10s, at the time 5s, framework > > sets a filter with 3s, so with this patch, we will expire the filter 10s > > (max(10, 3)) later, i.e., at the time 15s. Then at the time of 10s (the > > next allocat

Re: Review Request 42355: Removed the timeout from the filter.

> On Jan. 20, 2016, 9:49 a.m., Qian Zhang wrote: > > One question: Say allocation interval is 10s, at the time 5s, framework > > sets a filter with 3s, so with this patch, we will expire the filter 10s > > (max(10, 3)) later, i.e., at the time 15s. Then at the time of 10s (the > > next allocat

Re: Review Request 42355: Removed the timeout from the filter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42355/#review115315 --- One question: Say allocation interval is 10s, at the time 5s, frame

Re: Review Request 41285: Made Executor struct assign `pid/http` to be None() explicitly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41285/#review115311 --- Patch looks great! Reviews applied: [41285] Passed command: expor

Re: Review Request 42491: Updated allocatable() to distinguish different resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42491/ --- (Updated 一月 20, 2016, 1:41 a.m.) Review request for mesos, Ben Mahler, Artem Ha

Re: Review Request 41285: Made Executor struct assign `pid/http` to be None() explicitly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41285/ --- (Updated Jan. 20, 2016, 1:41 a.m.) Review request for mesos, Ben Mahler, Jie Yu

Re: Review Request 42491: WIP: Updated allocatable() to distinguish different resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42491/ --- (Updated 一月 20, 2016, 1:41 a.m.) Review request for mesos, Ben Mahler, Artem Ha

Re: Review Request 42530: Changed `createReservationInfo` to take `Option`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42530/#review115310 --- src/tests/mesos.hpp (line 479)

Re: Review Request 42524: Simplified SchedulerDriver.run().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42524/#review115308 --- src/sched/sched.cpp (lines 1929 - 1930)

Re: Review Request 42361: Added dynamic reservation test with no principal.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42361/#review115307 --- Ship it! src/tests/reservation_tests.cpp (line 1826)

Re: Review Request 42530: Changed `createReservationInfo` to take `Option`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42530/#review115306 --- Ship it! Ship It! - Michael Park On Jan. 20, 2016, 1:30 a.m., G

Re: Review Request 41285: Made Executor struct assign `pid` to be None() explicitly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41285/ --- (Updated Jan. 20, 2016, 1:31 a.m.) Review request for mesos, Ben Mahler, Jie Yu

Re: Review Request 42368: Added reservation endpoint test without auth and principal.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42368/ --- (Updated Jan. 20, 2016, 1:30 a.m.) Review request for mesos, Jie Yu, Michael Pa

Re: Review Request 42530: Changed `createReservationInfo` to take `Option`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42530/ --- (Updated Jan. 20, 2016, 1:30 a.m.) Review request for mesos and Michael Park.

Re: Review Request 41285: PID none bug in slave

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41285/ --- (Updated Jan. 20, 2016, 1:28 a.m.) Review request for mesos, Ben Mahler, Jie Yu

Re: Review Request 42361: Added dynamic reservation test with no principal.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42361/ --- (Updated Jan. 20, 2016, 1:27 a.m.) Review request for mesos, Jie Yu, Michael Pa

Review Request 42530: Changed 'createReservationInfo' to take 'Option'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42530/ --- Review request for mesos and Michael Park. Repository: mesos Description

Re: Review Request 42471: Multiple Disk: Adjusted resource arithmetic for 'DiskInfo.Source'.

> On Jan. 19, 2016, 10:50 p.m., Jie Yu wrote: > > include/mesos/v1/values.hpp, line 22 > > > > > > Why this change? It was due to a cyclical include between `values.hpp` and `mesos.hpp`; however, since I moved the o

Re: Review Request 41858: Added helper functions to kill executor.

> On Jan. 7, 2016, 11:49 p.m., Jian Qiu wrote: > > src/slave/slave.cpp, line 4886 > > > > > > Should this be used also by qos_correction? > > Guangya Liu wrote: > Want to leverage but because of `log` issues, t

Re: Review Request 42505: Multiple Disk: Adjusted DiskInfo validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42505/#review115304 --- src/master/validation.cpp (lines 206 - 210)

Re: Review Request 42471: Multiple Disk: Adjusted resource arithmetic for 'DiskInfo.Source'.

> On Jan. 19, 2016, 10:50 p.m., Jie Yu wrote: > > include/mesos/type_utils.hpp, line 29 > > > > > > Do you need this? Not after we get rid of `total_size`. I needed it for the scalar comparison. - Joris -

Re: Review Request 42368: Added reservation endpoint test without auth and principal.

> On Jan. 20, 2016, 12:44 a.m., Michael Park wrote: > > src/tests/reservation_endpoints_tests.cpp, lines 1173-1184 > > > > > > Why are we testing for this? When we met previously, Vinod mentioned that we sometimes

  1   2   3   >