Re: Review Request 42946: Replaced tabs with spaces in configure.ac.

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42946/
---

(Updated Jan. 29, 2016, 4:19 p.m.)


Review request for mesos, Benjamin Bannier and Joris Van Remoortere.


Changes
---

Update summary :).


Summary (updated)
-

Replaced tabs with spaces in configure.ac.


Bugs: MESOS-4519
https://issues.apache.org/jira/browse/MESOS-4519


Repository: mesos


Description
---

Replace tabs with spaces in configure.ac.


Diffs
-

  configure.ac cb39c7f 

Diff: https://reviews.apache.org/r/42946/diff/


Testing
---

../configure
make


Thanks,

Klaus Ma

Re: Review Request 42908: Fixed a flaky test in quota tests.

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42908/#review116908
---




src/tests/master_quota_tests.cpp (line 957)


Just check the code on `setQuota-->rescindOffer`, why not let allocator to 
do the `rescindOffer`? It makes sense to let allocator to descide how many 
resources/offer should be rescind.



src/tests/master_quota_tests.cpp (line 992)


```
driver.stop();
driver.join();
```


- Klaus Ma


On Jan. 28, 2016, 8:20 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42908/
> ---
> 
> (Updated Jan. 28, 2016, 8:20 p.m.)
> 
> 
> Review request for mesos, Michael Park and Qian Zhang.
> 
> 
> Bugs: MESOS-4542
> https://issues.apache.org/jira/browse/MESOS-4542
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The `AvailableResourcesAfterRescinding` test became flaky after we
> stopped offering unreserved resources beyond quota in
> https://reviews.apache.org/r/42835. Hence the allocator offers
> rescinded resources to `framework1` if an allocation happens before
> the test finishes, which violates the expectation that `framework1`
> receives resources only once. Since we do not really care about
> allocations in this test but rather about rescinded resources, the
> fix is just to ignore subsequent offers to `framework1`.
> 
> 
> Diffs
> -
> 
>   src/tests/master_quota_tests.cpp 04efcf3362d3594e0ad8077793fa1f32536dd658 
> 
> Diff: https://reviews.apache.org/r/42908/diff/
> 
> 
> Testing
> ---
> 
> On Mac OS 10.10.4:
> `GTEST_FILTER="MasterQuotaTest.AvailableResourcesAfterRescinding" 
> ./bin/mesos-tests.sh --gtest_shuffle --gtest_break_on_failure 
> --gtest_repeat=5000`
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Review Request 42955: Added variadic template for process::collect.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42955/
---

Review request for mesos, Joris Van Remoortere and Michael Park.


Repository: mesos


Description
---

Previously, templates only existed to allow collect to take either a
std::list of Futures, or *exactly* 2 Futures as arguments.

This commit removes the 2 argument template and replaces it with a
variadic template that accepts an arbitrary number of Futures as
arguments.


Diffs
-

  3rdparty/libprocess/include/process/collect.hpp 
cd78b6c211c2e4ca2b1ebbe728cfc2dfad1a32c9 

Diff: https://reviews.apache.org/r/42955/diff/


Testing
---


Thanks,

Kevin Klues

Review Request 42956: Added variadic template for process::await.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42956/
---

Review request for mesos, Joris Van Remoortere and Michael Park.


Bugs: MESOS-4551
https://issues.apache.org/jira/browse/MESOS-4551


Repository: mesos


Description
---

Previously, templates only existed to allow await to take either a
std::list of Futures, *exactly* 2 Futures as arguments, or *exactly* 3
Futures as arguments.

This commit removes the 2 and 3 argument templates and replaces them
with a variadic template that accepts an arbitrary number of Futures as
arguments.


Diffs
-

  3rdparty/libprocess/include/process/collect.hpp 
cd78b6c211c2e4ca2b1ebbe728cfc2dfad1a32c9 

Diff: https://reviews.apache.org/r/42956/diff/


Testing
---


Thanks,

Kevin Klues

Re: Review Request 42955: Added variadic template for process::collect.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42955/
---

(Updated Jan. 29, 2016, 10:10 a.m.)


Review request for mesos, Joris Van Remoortere and Michael Park.


Bugs: MESOS-4551
https://issues.apache.org/jira/browse/MESOS-4551


Repository: mesos


Description
---

Previously, templates only existed to allow collect to take either a
std::list of Futures, or *exactly* 2 Futures as arguments.

This commit removes the 2 argument template and replaces it with a
variadic template that accepts an arbitrary number of Futures as
arguments.


Diffs
-

  3rdparty/libprocess/include/process/collect.hpp 
cd78b6c211c2e4ca2b1ebbe728cfc2dfad1a32c9 

Diff: https://reviews.apache.org/r/42955/diff/


Testing
---


Thanks,

Kevin Klues

Re: Review Request 42786: Exposed the global 'help' process and added getter functions to it.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42786/
---

(Updated Jan. 29, 2016, 10:13 a.m.)


Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway.


Changes
---

Addressed comments. Aftr thinking more about it a bit more, copying the map 
actually makes the most sense.


Repository: mesos


Description
---

Previously, there was no way to extract the help strings from the help
process once they had been installed into it.  The only way to get at
them was to visit the http endpoint they were associated with and pull
it from there.

This commit adds API calls to the process::Help class to get at these
strings more easily.


Diffs (updated)
-

  3rdparty/libprocess/include/process/help.hpp 
2e76a6a5b1069abce879374a88cea65036873f1d 
  3rdparty/libprocess/include/process/process.hpp 
1e4126f1082c24debd9d713b490d18f5ed83f0be 
  3rdparty/libprocess/src/help.cpp 2f718b9e160113518fb4a0260db916cb2242dbae 

Diff: https://reviews.apache.org/r/42786/diff/


Testing
---


Thanks,

Kevin Klues

Re: Review Request 42908: Fixed a flaky test in quota tests.

[Alexander Rukletsov]

> On Jan. 29, 2016, 8:42 a.m., Klaus Ma wrote:
> > src/tests/master_quota_tests.cpp, line 957
> > 
> >
> > Just check the code on `setQuota-->rescindOffer`, why not let allocator 
> > to do the `rescindOffer`? It makes sense to let allocator to descide how 
> > many resources/offer should be rescind.

If I understand you correctly, then it's because the allocator should manage 
offers. Currently, the allocator allocates resources which are packed into 
offers by the master. Moving this to allocator is quite a bit of refactoring, 
agreed? Do you propose to do this refactoring as part of the patch? I'm not 
sure how schould I "fix" the issue.


> On Jan. 29, 2016, 8:42 a.m., Klaus Ma wrote:
> > src/tests/master_quota_tests.cpp, line 992
> > 
> >
> > ```
> > driver.stop();
> > driver.join();
> > ```

Good catch, thanks!


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42908/#review116908
---


On Jan. 28, 2016, 12:20 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42908/
> ---
> 
> (Updated Jan. 28, 2016, 12:20 p.m.)
> 
> 
> Review request for mesos, Michael Park and Qian Zhang.
> 
> 
> Bugs: MESOS-4542
> https://issues.apache.org/jira/browse/MESOS-4542
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The `AvailableResourcesAfterRescinding` test became flaky after we
> stopped offering unreserved resources beyond quota in
> https://reviews.apache.org/r/42835. Hence the allocator offers
> rescinded resources to `framework1` if an allocation happens before
> the test finishes, which violates the expectation that `framework1`
> receives resources only once. Since we do not really care about
> allocations in this test but rather about rescinded resources, the
> fix is just to ignore subsequent offers to `framework1`.
> 
> 
> Diffs
> -
> 
>   src/tests/master_quota_tests.cpp 04efcf3362d3594e0ad8077793fa1f32536dd658 
> 
> Diff: https://reviews.apache.org/r/42908/diff/
> 
> 
> Testing
> ---
> 
> On Mac OS 10.10.4:
> `GTEST_FILTER="MasterQuotaTest.AvailableResourcesAfterRescinding" 
> ./bin/mesos-tests.sh --gtest_shuffle --gtest_break_on_failure 
> --gtest_repeat=5000`
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Review Request 42957: Added remove() calls to process::Help.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42957/
---

Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway.


Bugs: MESOS-4552
https://issues.apache.org/jira/browse/MESOS-4552


Repository: mesos


Description
---

Previously, there was no way to remove an installed help
string for a given endpoint.

This commit adds the ability to remove these help strings.


Diffs
-

  3rdparty/libprocess/include/process/help.hpp 
2e76a6a5b1069abce879374a88cea65036873f1d 
  3rdparty/libprocess/src/help.cpp 2f718b9e160113518fb4a0260db916cb2242dbae 

Diff: https://reviews.apache.org/r/42957/diff/


Testing
---


Thanks,

Kevin Klues

Review Request 42958: Added a unit test for manipulating strings in the global help process.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42958/
---

Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway.


Bugs: MESOS-4552
https://issues.apache.org/jira/browse/MESOS-4552


Repository: mesos


Description
---

This test exercises the add/get/remove paths for all variants of these
functions in process::Help.


Diffs
-

  3rdparty/libprocess/src/tests/process_tests.cpp 
df1c7b3f37ab1103991a4f27a9e0359bcf06cc68 

Diff: https://reviews.apache.org/r/42958/diff/


Testing
---


Thanks,

Kevin Klues

Re: Review Request 42786: Exposed the global 'help' process and added getter functions to it.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42786/
---

(Updated Jan. 29, 2016, 10:24 a.m.)


Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway.


Bugs: MESOS-4552
https://issues.apache.org/jira/browse/MESOS-4552


Repository: mesos


Description
---

Previously, there was no way to extract the help strings from the help
process once they had been installed into it.  The only way to get at
them was to visit the http endpoint they were associated with and pull
it from there.

This commit adds API calls to the process::Help class to get at these
strings more easily.


Diffs
-

  3rdparty/libprocess/include/process/help.hpp 
2e76a6a5b1069abce879374a88cea65036873f1d 
  3rdparty/libprocess/include/process/process.hpp 
1e4126f1082c24debd9d713b490d18f5ed83f0be 
  3rdparty/libprocess/src/help.cpp 2f718b9e160113518fb4a0260db916cb2242dbae 

Diff: https://reviews.apache.org/r/42786/diff/


Testing
---


Thanks,

Kevin Klues

Re: Review Request 42908: Fixed a flaky test in quota tests.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42908/
---

(Updated Jan. 29, 2016, 10:34 a.m.)


Review request for mesos, Michael Park and Qian Zhang.


Changes
---

Addressed Klaus' comment.


Bugs: MESOS-4542
https://issues.apache.org/jira/browse/MESOS-4542


Repository: mesos


Description
---

The `AvailableResourcesAfterRescinding` test became flaky after we
stopped offering unreserved resources beyond quota in
https://reviews.apache.org/r/42835. Hence the allocator offers
rescinded resources to `framework1` if an allocation happens before
the test finishes, which violates the expectation that `framework1`
receives resources only once. Since we do not really care about
allocations in this test but rather about rescinded resources, the
fix is just to ignore subsequent offers to `framework1`.


Diffs (updated)
-

  src/tests/master_quota_tests.cpp 04efcf3362d3594e0ad8077793fa1f32536dd658 

Diff: https://reviews.apache.org/r/42908/diff/


Testing
---

On Mac OS 10.10.4:
`GTEST_FILTER="MasterQuotaTest.AvailableResourcesAfterRescinding" 
./bin/mesos-tests.sh --gtest_shuffle --gtest_break_on_failure 
--gtest_repeat=5000`


Thanks,

Alexander Rukletsov

Re: Review Request 42910: Added a note about revocable resources beyond quota in the user doc.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42910/
---

(Updated Jan. 29, 2016, 10:58 a.m.)


Review request for mesos, Joris Van Remoortere and Michael Park.


Changes
---

Clarified the comment as per Guangya's comment.


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  docs/quota.md 2762557ad1cec0655a27c4dda4016e07c7f63cd9 

Diff: https://reviews.apache.org/r/42910/diff/


Testing
---

None.


Thanks,

Alexander Rukletsov

Re: Review Request 42910: Added a note about revocable resources beyond quota in the user doc.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42910/#review116944
---


Ship it!




Ship It!

- Guangya Liu


On 一月 29, 2016, 10:58 a.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42910/
> ---
> 
> (Updated 一月 29, 2016, 10:58 a.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   docs/quota.md 2762557ad1cec0655a27c4dda4016e07c7f63cd9 
> 
> Diff: https://reviews.apache.org/r/42910/diff/
> 
> 
> Testing
> ---
> 
> None.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 42908: Fixed a flaky test in quota tests.

[Klaus Ma]

> On Jan. 29, 2016, 4:42 p.m., Klaus Ma wrote:
> > src/tests/master_quota_tests.cpp, line 957
> > 
> >
> > Just check the code on `setQuota-->rescindOffer`, why not let allocator 
> > to do the `rescindOffer`? It makes sense to let allocator to descide how 
> > many resources/offer should be rescind.
> 
> Alexander Rukletsov wrote:
> If I understand you correctly, then it's because the allocator should 
> manage offers. Currently, the allocator allocates resources which are packed 
> into offers by the master. Moving this to allocator is quite a bit of 
> refactoring, agreed? Do you propose to do this refactoring as part of the 
> patch? I'm not sure how schould I "fix" the issue.

Yes, I agree it's quite a bit of refactoring; we definely not "fix" it in this 
path :). I thinke we can log a JIRA to discuss it: whether it worth to do; if 
worth, how. Is that OK?


- Klaus


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42908/#review116908
---


On Jan. 29, 2016, 6:34 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42908/
> ---
> 
> (Updated Jan. 29, 2016, 6:34 p.m.)
> 
> 
> Review request for mesos, Michael Park and Qian Zhang.
> 
> 
> Bugs: MESOS-4542
> https://issues.apache.org/jira/browse/MESOS-4542
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The `AvailableResourcesAfterRescinding` test became flaky after we
> stopped offering unreserved resources beyond quota in
> https://reviews.apache.org/r/42835. Hence the allocator offers
> rescinded resources to `framework1` if an allocation happens before
> the test finishes, which violates the expectation that `framework1`
> receives resources only once. Since we do not really care about
> allocations in this test but rather about rescinded resources, the
> fix is just to ignore subsequent offers to `framework1`.
> 
> 
> Diffs
> -
> 
>   src/tests/master_quota_tests.cpp 04efcf3362d3594e0ad8077793fa1f32536dd658 
> 
> Diff: https://reviews.apache.org/r/42908/diff/
> 
> 
> Testing
> ---
> 
> On Mac OS 10.10.4:
> `GTEST_FILTER="MasterQuotaTest.AvailableResourcesAfterRescinding" 
> ./bin/mesos-tests.sh --gtest_shuffle --gtest_break_on_failure 
> --gtest_repeat=5000`
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 42908: Fixed a flaky test in quota tests.

[Klaus Ma]

> On Jan. 29, 2016, 4:42 p.m., Klaus Ma wrote:
> > src/tests/master_quota_tests.cpp, line 957
> > 
> >
> > Just check the code on `setQuota-->rescindOffer`, why not let allocator 
> > to do the `rescindOffer`? It makes sense to let allocator to descide how 
> > many resources/offer should be rescind.
> 
> Alexander Rukletsov wrote:
> If I understand you correctly, then it's because the allocator should 
> manage offers. Currently, the allocator allocates resources which are packed 
> into offers by the master. Moving this to allocator is quite a bit of 
> refactoring, agreed? Do you propose to do this refactoring as part of the 
> patch? I'm not sure how schould I "fix" the issue.
> 
> Klaus Ma wrote:
> Yes, I agree it's quite a bit of refactoring; we definely not "fix" it in 
> this path :). I thinke we can log a JIRA to discuss it: whether it worth to 
> do; if worth, how. Is that OK?

I log MESOS-4553 for our discussion, I'd like to drop this comments :).


- Klaus


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42908/#review116908
---


On Jan. 29, 2016, 6:34 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42908/
> ---
> 
> (Updated Jan. 29, 2016, 6:34 p.m.)
> 
> 
> Review request for mesos, Michael Park and Qian Zhang.
> 
> 
> Bugs: MESOS-4542
> https://issues.apache.org/jira/browse/MESOS-4542
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The `AvailableResourcesAfterRescinding` test became flaky after we
> stopped offering unreserved resources beyond quota in
> https://reviews.apache.org/r/42835. Hence the allocator offers
> rescinded resources to `framework1` if an allocation happens before
> the test finishes, which violates the expectation that `framework1`
> receives resources only once. Since we do not really care about
> allocations in this test but rather about rescinded resources, the
> fix is just to ignore subsequent offers to `framework1`.
> 
> 
> Diffs
> -
> 
>   src/tests/master_quota_tests.cpp 04efcf3362d3594e0ad8077793fa1f32536dd658 
> 
> Diff: https://reviews.apache.org/r/42908/diff/
> 
> 
> Testing
> ---
> 
> On Mac OS 10.10.4:
> `GTEST_FILTER="MasterQuotaTest.AvailableResourcesAfterRescinding" 
> ./bin/mesos-tests.sh --gtest_shuffle --gtest_break_on_failure 
> --gtest_repeat=5000`
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 42928: Updated docker_build.sh to generate xml output for all OSes.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42928/#review116958
---


Ship it!




Ship It!

- Greg Mann


On Jan. 29, 2016, 12:06 a.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42928/
> ---
> 
> (Updated Jan. 29, 2016, 12:06 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Greg Mann, and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> xml output was originally only enabled for ubuntu. This enables it for all 
> OSes.
> 
> 
> Diffs
> -
> 
>   support/docker_build.sh da94be87fae98825e60331634259eab0e7a4ebd1 
> 
> Diff: https://reviews.apache.org/r/42928/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 42832: Added a status method to the Isolator interface.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42832/#review116960
---


Ship it!




Can you also add a test to the test suite?

- Kapil Arya


On Jan. 28, 2016, 12:57 p.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42832/
> ---
> 
> (Updated Jan. 28, 2016, 12:57 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Kapil Arya.
> 
> 
> Bugs: MESOS-4520
> https://issues.apache.org/jira/browse/MESOS-4520
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a status method to the Isolator interface. This method can be used to 
> query the run-time state of isolator specific properties associated with a 
> container.
> 
> 
> Diffs
> -
> 
>   include/mesos/slave/isolator.hpp 2ea1fb77b4bbe811466fac18fdf7cd48d482bc75 
>   src/slave/containerizer/mesos/isolator.hpp 
> b3babd09c9dc70d6ca3dac1964eda321cb0f8be9 
>   src/slave/containerizer/mesos/isolator.cpp 
> 6d6863814fde5601bd311f6dc0816f7f1e446537 
> 
> Diff: https://reviews.apache.org/r/42832/diff/
> 
> 
> Testing
> ---
> 
> make
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 42929: Updated docker_build.sh to make build environment configurable.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42929/#review116964
---


Ship it!




Ship It!

- Greg Mann


On Jan. 29, 2016, 1:32 a.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42929/
> ---
> 
> (Updated Jan. 29, 2016, 1:32 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Greg Mann, and Kevin Klues.
> 
> 
> Bugs: MESOS-4523
> https://issues.apache.org/jira/browse/MESOS-4523
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated docker_build.sh to make build environment configurable.
> 
> 
> Diffs
> -
> 
>   support/docker_build.sh da94be87fae98825e60331634259eab0e7a4ebd1 
>   support/verify_reviews.py 251d57ec050b087f13b3f5e0d8f421fe8eb76787 
> 
> Diff: https://reviews.apache.org/r/42929/diff/
> 
> 
> Testing
> ---
> 
> Tested this via a custom CI job on ASF CI.
> 
> Note that the benchmark tests need to be reconfigured to not take a long 
> time. Currently they get aborted because they ran for > 5 hours.
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 42794: URL query string order is defined.

[Abhishek Dasgupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42794/
---

(Updated Jan. 29, 2016, 5:15 p.m.)


Review request for mesos, Kapil Arya and Jan Schlicht.


Bugs: MESOS-3317
https://issues.apache.org/jira/browse/MESOS-3317


Repository: mesos


Description
---

URL query string order is defined.


Diffs (updated)
-

  3rdparty/libprocess/src/http.cpp 762da9a9038fc0a81156b5c03b556084df1bd7e0 
  3rdparty/libprocess/src/tests/http_tests.cpp 
66d185e3fd8a165d8a98d3d2752e756f8de3499b 

Diff: https://reviews.apache.org/r/42794/diff/


Testing
---

The following test cases in http_test.cpp have been modified -
HTTPTest.QueryEncodeDecode to check generated query strings in URL to be 
according alphabatic order.
URLTest.Stringification to check generated query strings in URL to be according 
alphabatic order.


Thanks,

Abhishek Dasgupta

Re: Review Request 42362: Added persistent volume endpoint test without authentication.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42362/#review116966
---


Ship it!




Ship It!

- Kapil Arya


On Jan. 28, 2016, 12:59 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42362/
> ---
> 
> (Updated Jan. 28, 2016, 12:59 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Kapil Arya, and Neil Conway.
> 
> 
> Bugs: MESOS-4395
> https://issues.apache.org/jira/browse/MESOS-4395
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added persistent volume endpoint tests with HTTP authentication disabled.
> 
> The persistent volume endpoint tests allow volume creation and destruction 
> when HTTP authentication is disabled; this patch introduces a test for this 
> scenario: `PersistentVolumeEndpointsTest.NoAuthentication`.
> 
> 
> Diffs
> -
> 
>   src/tests/persistent_volume_endpoints_tests.cpp 
> 22e18758ee91a649486725473d9e50fae9d43b01 
> 
> Diff: https://reviews.apache.org/r/42362/diff/
> 
> 
> Testing
> ---
> 
> A new test, `PersistentVolumeEndpointsTest.NoAuthentication`, was added to 
> the persistent volume endpoint tests.
> 
> `make check` was used to test, and the new test was run with 
> `--gtest_repeat=1000 -gtest_break_on_failure=1`.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 42939: Synchronized 'configuration.md' with the 'flags.cpp' files.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42939/
---

(Updated Jan. 29, 2016, 5:41 p.m.)


Review request for mesos and Vinod Kone.


Bugs: MESOS-4298
https://issues.apache.org/jira/browse/MESOS-4298


Repository: mesos


Description
---

Synchronized 'configuration.md' with the 'flags.cpp' files.

Programatically generated HTML from the flag help strings and imported that 
text into 'configuration.md', thus synchronizing the documentation with the 
source code.


Diffs (updated)
-

  docs/configuration.md b1ef1314eb9482a55015baa42b51d59b9f464a29 

Diff: https://reviews.apache.org/r/42939/diff/


Testing
---

Viewed with the mesos website container: 
https://github.com/mesosphere/mesos-website-container


Thanks,

Greg Mann

Re: Review Request 42828: Updated ReviewBot to tee build output to a file.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42828/#review116968
---


Fix it, then Ship it!





support/verify_reviews.py (line 150)


Should probably read something like "If we are here, it is because the 
docker build command failed to read the output..."


- Greg Mann


On Jan. 29, 2016, 1:15 a.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42828/
> ---
> 
> (Updated Jan. 29, 2016, 1:15 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Greg Mann, Kevin Klues, and Michael 
> Park.
> 
> 
> Bugs: MESOS-1469 and MESOS-4478
> https://issues.apache.org/jira/browse/MESOS-1469
> https://issues.apache.org/jira/browse/MESOS-4478
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated ReviewBot to tee build output to a file.
> 
> 
> Diffs
> -
> 
>   support/verify_reviews.py 251d57ec050b087f13b3f5e0d8f421fe8eb76787 
> 
> Diff: https://reviews.apache.org/r/42828/diff/
> 
> 
> Testing
> ---
> 
> ?  mesos git:(vinod/review_bot_tee_output) 
> BUILD_URL=https://builds.apache.org/job/mesos-reviewbot/10980/ 
> ./support/verify_reviews.py vinod kone 1
> git rev-parse HEAD
> Checking if review: 41092 needs verification
> Latest diff timestamp: 2016-01-26 13:53:35
> Verifying review 41092
> Dependent review: https://reviews.apache.org/api/review-requests/41090/ 
> Dependent review: https://reviews.apache.org/api/review-requests/40951/ 
> Applying review 41092
> ./support/apply-review.sh -n -r 41092
> + : ubuntu:14.04
> + : gcc
> + : --verbose
> +++ dirname ./support/docker_build.sh
> ++ cd ./support/..
> ++ pwd
> + MESOS_DIRECTORY=/Users/vinodkone/workspace/mesos
> + cd /Users/vinodkone/workspace/mesos
> + DOCKERFILE=Dockerfile
> + rm -f Dockerfile
> + case $OS in
> + append_dockerfile 'FROM ubuntu:14.04'
> + echo FROM ubuntu:14.04
> + append_dockerfile 'RUN rm -rf /var/lib/apt/lists/*'
> + echo RUN rm -rf '/var/lib/apt/lists/*'
> + append_dockerfile 'RUN apt-get update'
> + echo RUN apt-get update
> + append_dockerfile 'RUN apt-get -y install build-essential clang git maven 
> autoconf libtool'
> + echo RUN apt-get -y install build-essential clang git maven autoconf libtool
> + append_dockerfile 'RUN apt-get -y install openjdk-7-jdk python-dev 
> python-boto libcurl4-nss-dev libsasl2-dev libapr1-dev libsvn-dev libevent-dev 
> libev-dev'
> + echo RUN apt-get -y install openjdk-7-jdk python-dev python-boto 
> libcurl4-nss-dev libsasl2-dev libapr1-dev libsvn-dev libevent-dev libev-dev
> + append_dockerfile 'RUN adduser --disabled-password --gecos '\'''\'' mesos'
> + echo RUN adduser --disabled-password --gecos ''\'''\''' mesos
> + append_dockerfile 'ENV GTEST_FILTER -FsTest.FileSystemTableRead'
> + echo ENV GTEST_FILTER -FsTest.FileSystemTableRead
> + append_dockerfile 'ENV GTEST_OUTPUT xml:report.xml'
> + echo ENV GTEST_OUTPUT xml:report.xml
> + case $COMPILER in
> + append_dockerfile 'ENV CC gcc'
> + echo ENV CC gcc
> + append_dockerfile 'ENV CXX g++'
> + echo ENV CXX g++
> + append_dockerfile 'WORKDIR mesos'
> + echo WORKDIR mesos
> + append_dockerfile 'COPY . /mesos/'
> + echo COPY . /mesos/
> + append_dockerfile 'RUN chown -R mesos /mesos'
> + echo RUN chown -R mesos /mesos
> + append_dockerfile 'USER mesos'
> + echo USER mesos
> + append_dockerfile 'CMD ./bootstrap && ./configure --verbose && 
> DISTCHECK_CONFIGURE_FLAGS="--verbose" GLOG_v=1 MESOS_VERBOSE=1 make -j8 
> distcheck'
> + echo CMD ./bootstrap '&&' ./configure --verbose '&&' 
> 'DISTCHECK_CONFIGURE_FLAGS="--verbose"' GLOG_v=1 MESOS_VERBOSE=1 make -j8 
> distcheck
> ++ date +%s
> + TAG=mesos-1453845969-21946
> + docker build --no-cache=true -t mesos-1453845969-21946 .
> ./support/docker_build.sh: line 117: docker: command not found
> Posting review: Bad patch!
> 
> Reviews applied: [40951, 41090, 41092]
> 
> Failed command: ['bash', '-c', 'set -o pipefail; export 
> OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; 
> ./support/docker_build.sh 2>&1 | tee build_41092']
> 
> Error:
>  ..
> + : ubuntu:14.04
> + : gcc
> + : --verbose
> +++ dirname ./support/docker_build.sh
> ++ cd ./support/..
> ++ pwd
> + MESOS_DIRECTORY=/Users/vinodkone/workspace/mesos
> + cd /Users/vinodkone/workspace/mesos
> + DOCKERFILE=Dockerfile
> + rm -f Dockerfile
> + case $OS in
> + append_dockerfile 'FROM ubuntu:14.04'
> + echo FROM ubuntu:14.04
> + append_dockerfile 'RUN rm -rf /var/lib/apt/lists/*'
> + echo RUN rm -rf '/var/lib/apt/lists/*'
> + append_dockerfile 'RUN apt-get update'
> + echo RUN apt-get update
> + append_dockerfile 'RUN apt-get -y install build-essential clang git maven 
> autoconf libtool'
> + echo RUN apt-get

Re: Review Request 42927: Deleted Dockerfile in favor of `support/docker_build.sh`.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42927/#review116969
---


Ship it!




Ship It!

- Greg Mann


On Jan. 29, 2016, 12:05 a.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42927/
> ---
> 
> (Updated Jan. 29, 2016, 12:05 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Greg Mann, and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> No one seems to be using it and this is not maintained anymore.
> 
> 
> Diffs
> -
> 
>   Dockerfile 35abf25aa77ef3f8a68b803eb8ff18ad90a0ff7b 
> 
> Diff: https://reviews.apache.org/r/42927/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 42939: Synchronized 'configuration.md' with the 'flags.cpp' files.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42939/#review116967
---



A couple of fixes you can make to the help strings and then auto-generate to 
this review:


docs/configuration.md (line 50)


Consider surrounding all these flags with `` blocks.



docs/configuration.md (line 263)


Remove the extra "Defaults to..."?



docs/configuration.md (lines 277 - 278)


Do you want to add a `` here (as an automatic replacement for "\n\n")?  
The space here has no effect on the rendered text; and the resulting paragraph 
is somewhat harder to read.



docs/configuration.md (line 280)


Remove extra default?



docs/configuration.md (line 325)


Do you want to retain the spacing and the boldness?



docs/configuration.md (lines 344 - 346)


Does this render correctly for you?  Adjacent `` blocks are rendered 
inline.


- Joseph Wu


On Jan. 29, 2016, 9:41 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42939/
> ---
> 
> (Updated Jan. 29, 2016, 9:41 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4298
> https://issues.apache.org/jira/browse/MESOS-4298
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Synchronized 'configuration.md' with the 'flags.cpp' files.
> 
> Programatically generated HTML from the flag help strings and imported that 
> text into 'configuration.md', thus synchronizing the documentation with the 
> source code.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md b1ef1314eb9482a55015baa42b51d59b9f464a29 
> 
> Diff: https://reviews.apache.org/r/42939/diff/
> 
> 
> Testing
> ---
> 
> Viewed with the mesos website container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 42794: URL query string order is defined.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42794/#review116971
---


Fix it, then Ship it!





3rdparty/libprocess/src/http.cpp (line 788)


Please end a period at the end of the sentence.


- Kapil Arya


On Jan. 29, 2016, 12:15 p.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42794/
> ---
> 
> (Updated Jan. 29, 2016, 12:15 p.m.)
> 
> 
> Review request for mesos, Kapil Arya and Jan Schlicht.
> 
> 
> Bugs: MESOS-3317
> https://issues.apache.org/jira/browse/MESOS-3317
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> URL query string order is defined.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/http.cpp 762da9a9038fc0a81156b5c03b556084df1bd7e0 
>   3rdparty/libprocess/src/tests/http_tests.cpp 
> 66d185e3fd8a165d8a98d3d2752e756f8de3499b 
> 
> Diff: https://reviews.apache.org/r/42794/diff/
> 
> 
> Testing
> ---
> 
> The following test cases in http_test.cpp have been modified -
> HTTPTest.QueryEncodeDecode to check generated query strings in URL to be 
> according alphabatic order.
> URLTest.Stringification to check generated query strings in URL to be 
> according alphabatic order.
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Review Request 42968: Fixed broken build due to signed comparison warning with GCC 5.3.0

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42968/
---

Review request for mesos.


Bugs: MESOS-4555
https://issues.apache.org/jira/browse/MESOS-4555


Repository: mesos


Description
---

Fixed broken build due to signed comparison warning with GCC 5.3.0


Diffs
-

  src/slave/containerizer/mesos/provisioner/docker/store.cpp 
632746211b1b43a23877de63a05777137be74c71 

Diff: https://reviews.apache.org/r/42968/diff/


Testing
---

make check


Thanks,

Neil Conway

Re: Review Request 42900: Fixed some typos.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42900/#review116978
---


Ship it!




Ship It!

- Jie Yu


On Jan. 28, 2016, 7:26 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42900/
> ---
> 
> (Updated Jan. 28, 2016, 7:26 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed some typos.
> 
> 
> Diffs
> -
> 
>   docs/reservation.md 8d2d33a6518c73542cbfb3a5ee36da1c00c6ff1a 
>   src/slave/containerizer/mesos/isolators/posix/disk.cpp 
> fd9b3abfe2c502c69ba7b2f0b2015fe90888d5bc 
> 
> Diff: https://reviews.apache.org/r/42900/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 42968: Fixed broken build due to signed comparison warning with GCC 5.3.0

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42968/#review116977
---


Ship it!




- Benjamin Bannier


On Jan. 29, 2016, 7:32 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42968/
> ---
> 
> (Updated Jan. 29, 2016, 7:32 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-4555
> https://issues.apache.org/jira/browse/MESOS-4555
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed broken build due to signed comparison warning with GCC 5.3.0
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 
> 632746211b1b43a23877de63a05777137be74c71 
> 
> Diff: https://reviews.apache.org/r/42968/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 42968: Fixed broken build due to signed comparison warning with GCC 5.3.0

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42968/#review116979
---


Ship it!




Ship It!

- Jie Yu


On Jan. 29, 2016, 6:32 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42968/
> ---
> 
> (Updated Jan. 29, 2016, 6:32 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-4555
> https://issues.apache.org/jira/browse/MESOS-4555
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed broken build due to signed comparison warning with GCC 5.3.0
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 
> 632746211b1b43a23877de63a05777137be74c71 
> 
> Diff: https://reviews.apache.org/r/42968/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 42968: Fixed broken build due to signed comparison warning with GCC 5.3.0

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42968/#review116981
---


Ship it!




Thanks Neil. Repeated field should compare with `int`.

- Gilbert Song


On Jan. 29, 2016, 10:32 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42968/
> ---
> 
> (Updated Jan. 29, 2016, 10:32 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-4555
> https://issues.apache.org/jira/browse/MESOS-4555
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed broken build due to signed comparison warning with GCC 5.3.0
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 
> 632746211b1b43a23877de63a05777137be74c71 
> 
> Diff: https://reviews.apache.org/r/42968/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 42936: Edited flag help strings for style.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42936/#review116982
---


Fix it, then Ship it!





src/master/main.cpp (line 126)


s/this/This/



src/master/main.cpp (line 132)


No need to explicitly specify the default?



src/slave/flags.cpp (line 66)


backticks around `filepath` like you did below for `--modules`.



src/slave/flags.cpp (line 156)


no back ticks around `rack:2`?



src/slave/flags.cpp (line 542)


why is this a backtick?



src/slave/main.cpp (line 99)


s/this/This/



src/slave/main.cpp (line 105)


no need for "(default: 5050).


- Vinod Kone


On Jan. 29, 2016, 5:34 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42936/
> ---
> 
> (Updated Jan. 29, 2016, 5:34 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4298
> https://issues.apache.org/jira/browse/MESOS-4298
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Edited flag help strings for style.
> 
> Backticks were inserted where appropriate. This not only matches the 
> convention in the comments within our code, helps to enable the automatic 
> generation of markdown-formatted documentation from these help strings.
> 
> 
> Diffs
> -
> 
>   src/logging/flags.cpp 978d735c8c8e9f3c46669cc633773f1ec1e1725d 
>   src/master/flags.cpp 6e7e17650341bc17c3af6f92fe83f974d4ce1efd 
>   src/master/main.cpp 0d5ac49121491152d8426cd764a1f1a0f37483ae 
>   src/slave/flags.cpp 75d7429a4e3e1d6259296257c0ace1ade365ac2b 
>   src/slave/main.cpp 9d48a0823189ea6505073a2803f02d90dc382ab4 
> 
> Diff: https://reviews.apache.org/r/42936/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 42939: Synchronized 'configuration.md' with the 'flags.cpp' files.

[Greg Mann]

> On Jan. 29, 2016, 5:56 p.m., Joseph Wu wrote:
> > docs/configuration.md, lines 350-352
> > 
> >
> > Does this render correctly for you?  Adjacent `` blocks are 
> > rendered inline.

Good catch, thanks Joseph!


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42939/#review116967
---


On Jan. 29, 2016, 7:16 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42939/
> ---
> 
> (Updated Jan. 29, 2016, 7:16 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4298
> https://issues.apache.org/jira/browse/MESOS-4298
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Synchronized 'configuration.md' with the 'flags.cpp' files.
> 
> Programatically generated HTML from the flag help strings and imported that 
> text into 'configuration.md', thus synchronizing the documentation with the 
> source code.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md b1ef1314eb9482a55015baa42b51d59b9f464a29 
> 
> Diff: https://reviews.apache.org/r/42939/diff/
> 
> 
> Testing
> ---
> 
> Viewed with the mesos website container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 42939: Synchronized 'configuration.md' with the 'flags.cpp' files.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42939/
---

(Updated Jan. 29, 2016, 7:16 p.m.)


Review request for mesos and Vinod Kone.


Changes
---

Changed flag order, edited to improve HTML rendering.


Bugs: MESOS-4298
https://issues.apache.org/jira/browse/MESOS-4298


Repository: mesos


Description
---

Synchronized 'configuration.md' with the 'flags.cpp' files.

Programatically generated HTML from the flag help strings and imported that 
text into 'configuration.md', thus synchronizing the documentation with the 
source code.


Diffs (updated)
-

  docs/configuration.md b1ef1314eb9482a55015baa42b51d59b9f464a29 

Diff: https://reviews.apache.org/r/42939/diff/


Testing
---

Viewed with the mesos website container: 
https://github.com/mesosphere/mesos-website-container


Thanks,

Greg Mann

Review Request 42971: stout: Mark an unused function parameter appropriately.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42971/
---

Review request for mesos and Jie Yu.


Repository: mesos


Description
---

stout: Mark an unused function parameter appropriately.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp 
a3dc7697f5f041a503e4aa84df67c915c43b76b5 

Diff: https://reviews.apache.org/r/42971/diff/


Testing
---

make check


Thanks,

Neil Conway

Review Request 42972: stout: Fixed typo (unintended inequality between pointer value and 0).

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42972/
---

Review request for mesos and Jie Yu.


Repository: mesos


Description
---

stout: Fixed typo (unintended inequality between pointer value and 0).


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 
2a188459465a5203c56d788a74e69d403790c5bf 

Diff: https://reviews.apache.org/r/42972/diff/


Testing
---

make check


Thanks,

Neil Conway

Review Request 42973: libprocess: Mark some unused function parameters appropriately.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42973/
---

Review request for mesos and Jie Yu.


Repository: mesos


Description
---

libprocess: Mark some unused function parameters appropriately.


Diffs
-

  3rdparty/libprocess/include/process/event.hpp 
a03824c061c4a0eb865b163999a763635e56744c 
  3rdparty/libprocess/include/process/filter.hpp 
2f7e6fb4be8725c8a91f56f42baed071a3ef10c3 
  3rdparty/libprocess/include/process/process.hpp 
1e4126f1082c24debd9d713b490d18f5ed83f0be 

Diff: https://reviews.apache.org/r/42973/diff/


Testing
---

make check


Thanks,

Neil Conway

Re: Review Request 42936: Edited flag help strings for style.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42936/
---

(Updated Jan. 29, 2016, 7:42 p.m.)


Review request for mesos and Vinod Kone.


Changes
---

Added missing default values, addressed comments.


Bugs: MESOS-4298
https://issues.apache.org/jira/browse/MESOS-4298


Repository: mesos


Description
---

Edited flag help strings for style.

Backticks were inserted where appropriate. This not only matches the convention 
in the comments within our code, helps to enable the automatic generation of 
markdown-formatted documentation from these help strings.


Diffs (updated)
-

  src/logging/flags.cpp 978d735c8c8e9f3c46669cc633773f1ec1e1725d 
  src/master/flags.cpp 6e7e17650341bc17c3af6f92fe83f974d4ce1efd 
  src/master/main.cpp 0d5ac49121491152d8426cd764a1f1a0f37483ae 
  src/slave/flags.cpp 75d7429a4e3e1d6259296257c0ace1ade365ac2b 
  src/slave/main.cpp 9d48a0823189ea6505073a2803f02d90dc382ab4 

Diff: https://reviews.apache.org/r/42936/diff/


Testing
---

`make check`


Thanks,

Greg Mann

Review Request 42974: libprocess: Remove unused variable.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42974/
---

Review request for mesos and Jie Yu.


Repository: mesos


Description
---

libprocess: Removed unused variable.


Diffs
-

  3rdparty/libprocess/src/process.cpp d8a74d7637d20c81f384e974e4fdeba22effb437 

Diff: https://reviews.apache.org/r/42974/diff/


Testing
---

make check


Thanks,

Neil Conway

Re: Review Request 42971: stout: Mark an unused function parameter appropriately.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42971/#review116992
---


Ship it!




Ship It!

- Anand Mazumdar


On Jan. 29, 2016, 7:42 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42971/
> ---
> 
> (Updated Jan. 29, 2016, 7:42 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> stout: Mark an unused function parameter appropriately.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp 
> a3dc7697f5f041a503e4aa84df67c915c43b76b5 
> 
> Diff: https://reviews.apache.org/r/42971/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 42972: stout: Fixed typo (unintended inequality between pointer value and 0).

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42972/#review116993
---


Ship it!





3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp (line 624)


Not yours: Should we add a `CHECK_NOTNULL` before this statement now?


- Anand Mazumdar


On Jan. 29, 2016, 7:42 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42972/
> ---
> 
> (Updated Jan. 29, 2016, 7:42 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> stout: Fixed typo (unintended inequality between pointer value and 0).
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 
> 2a188459465a5203c56d788a74e69d403790c5bf 
> 
> Diff: https://reviews.apache.org/r/42972/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 42972: stout: Fixed typo (unintended inequality between pointer value and 0).

[Neil Conway]

> On Jan. 29, 2016, 7:50 p.m., Anand Mazumdar wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp, line 624
> > 
> >
> > Not yours: Should we add a `CHECK_NOTNULL` before this statement now?

Is there value in doing that? In principle, we'd need a `CHECK_NOTNULL` before 
dereferencing _any_ pointer, which seems like it would add a lot of clutter...


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42972/#review116993
---


On Jan. 29, 2016, 7:42 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42972/
> ---
> 
> (Updated Jan. 29, 2016, 7:42 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> stout: Fixed typo (unintended inequality between pointer value and 0).
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 
> 2a188459465a5203c56d788a74e69d403790c5bf 
> 
> Diff: https://reviews.apache.org/r/42972/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 42973: libprocess: Mark some unused function parameters appropriately.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42973/#review116996
---


Ship it!




Thanks for cleaning this up.

- Anand Mazumdar


On Jan. 29, 2016, 7:42 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42973/
> ---
> 
> (Updated Jan. 29, 2016, 7:42 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> libprocess: Mark some unused function parameters appropriately.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/event.hpp 
> a03824c061c4a0eb865b163999a763635e56744c 
>   3rdparty/libprocess/include/process/filter.hpp 
> 2f7e6fb4be8725c8a91f56f42baed071a3ef10c3 
>   3rdparty/libprocess/include/process/process.hpp 
> 1e4126f1082c24debd9d713b490d18f5ed83f0be 
> 
> Diff: https://reviews.apache.org/r/42973/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 42939: Synchronized 'configuration.md' with the 'flags.cpp' files.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42939/#review116994
---


Fix it, then Ship it!




My only question is about line wrapping. Doesn't seem to be consistent across 
the file. Is the plan to wrap them all at 80 chars?


docs/configuration.md (line 1159)


60s?


- Vinod Kone


On Jan. 29, 2016, 7:16 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42939/
> ---
> 
> (Updated Jan. 29, 2016, 7:16 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4298
> https://issues.apache.org/jira/browse/MESOS-4298
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Synchronized 'configuration.md' with the 'flags.cpp' files.
> 
> Programatically generated HTML from the flag help strings and imported that 
> text into 'configuration.md', thus synchronizing the documentation with the 
> source code.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md b1ef1314eb9482a55015baa42b51d59b9f464a29 
> 
> Diff: https://reviews.apache.org/r/42939/diff/
> 
> 
> Testing
> ---
> 
> Viewed with the mesos website container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 42936: Edited flag help strings for style.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42936/
---

(Updated Jan. 29, 2016, 8:02 p.m.)


Review request for mesos and Vinod Kone.


Changes
---

Removed unnecessary defaults.


Bugs: MESOS-4298
https://issues.apache.org/jira/browse/MESOS-4298


Repository: mesos


Description
---

Edited flag help strings for style.

Backticks were inserted where appropriate. This not only matches the convention 
in the comments within our code, helps to enable the automatic generation of 
markdown-formatted documentation from these help strings.


Diffs (updated)
-

  src/logging/flags.cpp 978d735c8c8e9f3c46669cc633773f1ec1e1725d 
  src/master/flags.cpp 6e7e17650341bc17c3af6f92fe83f974d4ce1efd 
  src/master/main.cpp 0d5ac49121491152d8426cd764a1f1a0f37483ae 
  src/slave/flags.cpp 75d7429a4e3e1d6259296257c0ace1ade365ac2b 
  src/slave/main.cpp 9d48a0823189ea6505073a2803f02d90dc382ab4 

Diff: https://reviews.apache.org/r/42936/diff/


Testing
---

`make check`


Thanks,

Greg Mann

Re: Review Request 42939: Synchronized 'configuration.md' with the 'flags.cpp' files.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42939/
---

(Updated Jan. 29, 2016, 8:02 p.m.)


Review request for mesos and Vinod Kone.


Changes
---

Added boldface.


Bugs: MESOS-4298
https://issues.apache.org/jira/browse/MESOS-4298


Repository: mesos


Description
---

Synchronized 'configuration.md' with the 'flags.cpp' files.

Programatically generated HTML from the flag help strings and imported that 
text into 'configuration.md', thus synchronizing the documentation with the 
source code.


Diffs (updated)
-

  docs/configuration.md b1ef1314eb9482a55015baa42b51d59b9f464a29 

Diff: https://reviews.apache.org/r/42939/diff/


Testing
---

Viewed with the mesos website container: 
https://github.com/mesosphere/mesos-website-container


Thanks,

Greg Mann

Re: Review Request 42972: stout: Fixed typo (unintended inequality between pointer value and 0).

[Anand Mazumdar]

> On Jan. 29, 2016, 7:50 p.m., Anand Mazumdar wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp, line 624
> > 
> >
> > Not yours: Should we add a `CHECK_NOTNULL` before this statement now?
> 
> Neil Conway wrote:
> Is there value in doing that? In principle, we'd need a `CHECK_NOTNULL` 
> before dereferencing _any_ pointer, which seems like it would add a lot of 
> clutter...

Certainly. Especially in places where you are relying on the _invariant_ that 
the pointer would be non-null. This seems to be the case here.


- Anand


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42972/#review116993
---


On Jan. 29, 2016, 7:42 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42972/
> ---
> 
> (Updated Jan. 29, 2016, 7:42 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> stout: Fixed typo (unintended inequality between pointer value and 0).
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 
> 2a188459465a5203c56d788a74e69d403790c5bf 
> 
> Diff: https://reviews.apache.org/r/42972/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 42974: libprocess: Remove unused variable.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42974/#review116999
---



Bad patch!

Reviews applied: [42971]

Failed command: ./support/apply-review.sh -n -r 42971

Error:
 ..
2016-01-29 20:04:54 URL:https://reviews.apache.org/r/42971/diff/raw/ [633/633] 
-> "42971.patch" [1]
Total errors found: 0
Checking 1 files
Error: Commit message summary (the first line) must start with a capital letter.

Full log: https://builds.apache.org/job/mesos-reviewbot/11124/console

- Mesos ReviewBot


On Jan. 29, 2016, 7:42 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42974/
> ---
> 
> (Updated Jan. 29, 2016, 7:42 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> libprocess: Removed unused variable.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp 
> d8a74d7637d20c81f384e974e4fdeba22effb437 
> 
> Diff: https://reviews.apache.org/r/42974/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 42974: libprocess: Remove unused variable.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42974/#review117000
---


Ship it!




- Anand Mazumdar


On Jan. 29, 2016, 7:42 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42974/
> ---
> 
> (Updated Jan. 29, 2016, 7:42 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> libprocess: Removed unused variable.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp 
> d8a74d7637d20c81f384e974e4fdeba22effb437 
> 
> Diff: https://reviews.apache.org/r/42974/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 42940: Removed command-line flags from 'logging.md'.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42940/#review117001
---


Ship it!




Ship It!

- Vinod Kone


On Jan. 29, 2016, 2:18 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42940/
> ---
> 
> (Updated Jan. 29, 2016, 2:18 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4298
> https://issues.apache.org/jira/browse/MESOS-4298
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed command-line flags from 'logging.md'.
> 
> Documentation for these flags were moved back to 'configuration.md' in order 
> to keep all command-line flag documentation in one place.
> 
> 
> Diffs
> -
> 
>   docs/logging.md d79a74708775e5dc01df559042cdf790dfd20bd6 
> 
> Diff: https://reviews.apache.org/r/42940/diff/
> 
> 
> Testing
> ---
> 
> Viewed with the mesos website container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 42939: Synchronized 'configuration.md' with the 'flags.cpp' files.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42939/
---

(Updated Jan. 29, 2016, 8:13 p.m.)


Review request for mesos and Vinod Kone.


Bugs: MESOS-4298
https://issues.apache.org/jira/browse/MESOS-4298


Repository: mesos


Description
---

Synchronized 'configuration.md' with the 'flags.cpp' files.

Programatically generated HTML from the flag help strings and imported that 
text into 'configuration.md', thus synchronizing the documentation with the 
source code.


Diffs
-

  docs/configuration.md b1ef1314eb9482a55015baa42b51d59b9f464a29 

Diff: https://reviews.apache.org/r/42939/diff/


Testing
---

Viewed with the mesos website container: 
https://github.com/mesosphere/mesos-website-container


Thanks,

Greg Mann

Re: Review Request 42939: Synchronized 'configuration.md' with the 'flags.cpp' files.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42939/
---

(Updated Jan. 29, 2016, 8:18 p.m.)


Review request for mesos and Vinod Kone.


Bugs: MESOS-4298
https://issues.apache.org/jira/browse/MESOS-4298


Repository: mesos


Description
---

Synchronized 'configuration.md' with the 'flags.cpp' files.

Programatically generated HTML from the flag help strings and imported that 
text into 'configuration.md', thus synchronizing the documentation with the 
source code.


Diffs (updated)
-

  docs/configuration.md b1ef1314eb9482a55015baa42b51d59b9f464a29 

Diff: https://reviews.apache.org/r/42939/diff/


Testing
---

Viewed with the mesos website container: 
https://github.com/mesosphere/mesos-website-container


Thanks,

Greg Mann

Re: Review Request 42939: Synchronized 'configuration.md' with the 'flags.cpp' files.

[Greg Mann]

> On Jan. 29, 2016, 7:52 p.m., Vinod Kone wrote:
> > My only question is about line wrapping. Doesn't seem to be consistent 
> > across the file. Is the plan to wrap them all at 80 chars?

The current wrapping is based on the help strings found in the various 
`flags.cpp` files. Backticks are converted to `` tags, which leads 
to some lines running over 80 characters.


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42939/#review116994
---


On Jan. 29, 2016, 8:18 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42939/
> ---
> 
> (Updated Jan. 29, 2016, 8:18 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4298
> https://issues.apache.org/jira/browse/MESOS-4298
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Synchronized 'configuration.md' with the 'flags.cpp' files.
> 
> Programatically generated HTML from the flag help strings and imported that 
> text into 'configuration.md', thus synchronizing the documentation with the 
> source code.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md b1ef1314eb9482a55015baa42b51d59b9f464a29 
> 
> Diff: https://reviews.apache.org/r/42939/diff/
> 
> 
> Testing
> ---
> 
> Viewed with the mesos website container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 42972: stout: Fixed typo (unintended inequality between pointer value and 0).

[Neil Conway]

> On Jan. 29, 2016, 7:50 p.m., Anand Mazumdar wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp, line 624
> > 
> >
> > Not yours: Should we add a `CHECK_NOTNULL` before this statement now?
> 
> Neil Conway wrote:
> Is there value in doing that? In principle, we'd need a `CHECK_NOTNULL` 
> before dereferencing _any_ pointer, which seems like it would add a lot of 
> clutter...
> 
> Anand Mazumdar wrote:
> Certainly. Especially in places where you are relying on the _invariant_ 
> that the pointer would be non-null. This seems to be the case here.

Anytime you dereference a pointer, you rely on the invariant that the pointer 
is non-null. Not sure why this particular place merits special treatment.


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42972/#review116993
---


On Jan. 29, 2016, 7:42 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42972/
> ---
> 
> (Updated Jan. 29, 2016, 7:42 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> stout: Fixed typo (unintended inequality between pointer value and 0).
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 
> 2a188459465a5203c56d788a74e69d403790c5bf 
> 
> Diff: https://reviews.apache.org/r/42972/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 42936: Edited flag help strings for style.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42936/
---

(Updated Jan. 29, 2016, 8:51 p.m.)


Review request for mesos and Vinod Kone.


Bugs: MESOS-4298
https://issues.apache.org/jira/browse/MESOS-4298


Repository: mesos


Description
---

Edited flag help strings for style.

Backticks were inserted where appropriate. This not only matches the convention 
in the comments within our code, helps to enable the automatic generation of 
markdown-formatted documentation from these help strings.


Diffs (updated)
-

  src/logging/flags.cpp 978d735c8c8e9f3c46669cc633773f1ec1e1725d 
  src/master/flags.cpp 6e7e17650341bc17c3af6f92fe83f974d4ce1efd 
  src/master/main.cpp 0d5ac49121491152d8426cd764a1f1a0f37483ae 
  src/slave/flags.cpp 75d7429a4e3e1d6259296257c0ace1ade365ac2b 
  src/slave/main.cpp 9d48a0823189ea6505073a2803f02d90dc382ab4 

Diff: https://reviews.apache.org/r/42936/diff/


Testing
---

`make check`


Thanks,

Greg Mann

Re: Review Request 42936: Edited flag help strings for style.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42936/
---

(Updated Jan. 29, 2016, 9:09 p.m.)


Review request for mesos and Vinod Kone.


Changes
---

Rebase.


Bugs: MESOS-4298
https://issues.apache.org/jira/browse/MESOS-4298


Repository: mesos


Description
---

Edited flag help strings for style.

Backticks were inserted where appropriate. This not only matches the convention 
in the comments within our code, helps to enable the automatic generation of 
markdown-formatted documentation from these help strings.


Diffs (updated)
-

  src/logging/flags.cpp 978d735c8c8e9f3c46669cc633773f1ec1e1725d 
  src/master/flags.cpp 6e7e17650341bc17c3af6f92fe83f974d4ce1efd 
  src/master/main.cpp 0d5ac49121491152d8426cd764a1f1a0f37483ae 
  src/slave/flags.cpp 75d7429a4e3e1d6259296257c0ace1ade365ac2b 
  src/slave/main.cpp 9d48a0823189ea6505073a2803f02d90dc382ab4 

Diff: https://reviews.apache.org/r/42936/diff/


Testing
---

`make check`


Thanks,

Greg Mann

Re: Review Request 42921: Fixed flaky MaxCompletedTasksPerFrameworkFlag test.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42921/#review117018
---


Ship it!




Ship It!

- Ben Mahler


On Jan. 28, 2016, 10:56 p.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42921/
> ---
> 
> (Updated Jan. 28, 2016, 10:56 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Ben Mahler.
> 
> 
> Bugs: MESOS-4518
> https://issues.apache.org/jira/browse/MESOS-4518
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Previously, this test was calling EXPECT_CALL() on
> SchedulerDriver.resourceOffers() after the scheduler driver itself had
> already been started. This resulted in flaky test results when offers
> came in between schedDriver.start() and the EXPECT_CALL().
> 
> This commit fixes this test by moving the EXPECT_CALL() above the
> schedDriver.start() call. However, because of the nature of this test,
> this introduced a few complexities related to processing the incoming offers
> in a loop later on. To allow this, we had to introduce a custom gmock
> ACTION to enqueue offers in a process::Queue for later processing. This
> ACTION is generally useful and has been placed in src/tests/mesos.hpp.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp ce6ce25a03cdb0883612fe40b20996ec2e50de40 
>   src/tests/mesos.hpp 845b637c765b5b97568e9b3797b53814d2ab7782 
> 
> Diff: https://reviews.apache.org/r/42921/diff/
> 
> 
> Testing
> ---
> 
> Tested locally on my mac, as well as with running support/docker_build.sh on 
> a linux machine.
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 42787: Fixed whitespace errors in help strings for mesos/src.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42787/#review117017
---


Ship it!




Ship It!

- Ben Mahler


On Jan. 26, 2016, 7:41 a.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42787/
> ---
> 
> (Updated Jan. 26, 2016, 7:41 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Previously some of the help strings included a blank space at the end of
> some of their lines of text. This was causing problems when using these
> strings to generate .md files and then attempting to commit them back to
> the repo.
> 
> This commit removes this unnecessary whitespace.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 12c1fe5a514903f657911302e8770e9b245fdbb7 
>   src/master/registrar.cpp c46cc064413c02e22d48a47a17f8d3df2546c9c9 
>   src/slave/http.cpp 0ba2e82fd8ce58508f364aff761d50dc4f264f65 
> 
> Diff: https://reviews.apache.org/r/42787/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 42955: Added variadic template for process::collect.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42955/
---

(Updated Jan. 29, 2016, 9:18 p.m.)


Review request for mesos, Jie Yu, Joris Van Remoortere, and Michael Park.


Changes
---

GCC 4.8 has a bug using variadic templates with lambdas. This patch changes the 
previous one to use a std::bind as a workaround for this bug.

http://binglongx.com/2014/04/25/workaround-for-gcc-bug-in-lambda-capturing-variadic-templates/


Bugs: MESOS-4551
https://issues.apache.org/jira/browse/MESOS-4551


Repository: mesos


Description
---

Previously, templates only existed to allow collect to take either a
std::list of Futures, or *exactly* 2 Futures as arguments.

This commit removes the 2 argument template and replaces it with a
variadic template that accepts an arbitrary number of Futures as
arguments.


Diffs (updated)
-

  3rdparty/libprocess/include/process/collect.hpp 
cd78b6c211c2e4ca2b1ebbe728cfc2dfad1a32c9 

Diff: https://reviews.apache.org/r/42955/diff/


Testing
---


Thanks,

Kevin Klues

Re: Review Request 42956: Added variadic template for process::await.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42956/
---

(Updated Jan. 29, 2016, 9:18 p.m.)


Review request for mesos, Jie Yu, Joris Van Remoortere, and Michael Park.


Changes
---

GCC 4.8 has a bug using variadic templates with lambdas. This patch changes the 
previous one to use a std::bind as a workaround for this bug.

http://binglongx.com/2014/04/25/workaround-for-gcc-bug-in-lambda-capturing-variadic-templates/


Bugs: MESOS-4551
https://issues.apache.org/jira/browse/MESOS-4551


Repository: mesos


Description
---

Previously, templates only existed to allow await to take either a
std::list of Futures, *exactly* 2 Futures as arguments, or *exactly* 3
Futures as arguments.

This commit removes the 2 and 3 argument templates and replaces them
with a variadic template that accepts an arbitrary number of Futures as
arguments.


Diffs (updated)
-

  3rdparty/libprocess/include/process/collect.hpp 
cd78b6c211c2e4ca2b1ebbe728cfc2dfad1a32c9 

Diff: https://reviews.apache.org/r/42956/diff/


Testing
---


Thanks,

Kevin Klues

Re: Review Request 42788: Fixed whitespace errors in help strings for 3rdparty/libprocess.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42788/#review117019
---


Ship it!




Ship It!

- Ben Mahler


On Jan. 26, 2016, 7:41 a.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42788/
> ---
> 
> (Updated Jan. 26, 2016, 7:41 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Previously some of the help strings includes a blank space at the end of
> some of their lines of text. This was causing problems when using these
> strings to generate .md files and then attempting to commit them back to
> the repo.
> 
> This commit removes this unnecessary whitespace.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/metrics/metrics.cpp 
> 985fb5fcf3201ca767e6defc72a10b412ffd20a1 
> 
> Diff: https://reviews.apache.org/r/42788/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 42538: Supported image specified env var.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42538/
---

(Updated Jan. 29, 2016, 1:27 p.m.)


Review request for mesos, Jie Yu and Timothy Chen.


Bugs: MESOS-4383
https://issues.apache.org/jira/browse/MESOS-4383


Repository: mesos


Description
---

Supported image specified env var.


Diffs (updated)
-

  src/slave/containerizer/mesos/containerizer.hpp 
811ab7937279c4a55da450c136f9fcb1303ea0d5 
  src/slave/containerizer/mesos/containerizer.cpp 
4b504dbb58823ce7675f1d2048dcc7a27c05663d 

Diff: https://reviews.apache.org/r/42538/diff/


Testing
---

make check(ubuntu14.04 + clang-3.6)


Thanks,

Gilbert Song

Re: Review Request 42538: Supported image specified env var.

[Gilbert Song]

> On Jan. 29, 2016, 11:09 a.m., Timothy Chen wrote:
> > src/slave/containerizer/mesos/containerizer.cpp, line 931
> > 
> >
> > s/Overwrting/Overwriting/g
> > 
> > I also wonder if this is too verbose? Should we make this VLOG(2) 
> > instead?

It looks good to me with `VLOG(1)`, because it is just one line string. We may 
want some giant error msg or string objects using `VLOG(2)`.


- Gilbert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42538/#review116985
---


On Jan. 29, 2016, 1:27 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42538/
> ---
> 
> (Updated Jan. 29, 2016, 1:27 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Timothy Chen.
> 
> 
> Bugs: MESOS-4383
> https://issues.apache.org/jira/browse/MESOS-4383
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Supported image specified env var.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.hpp 
> 811ab7937279c4a55da450c136f9fcb1303ea0d5 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 4b504dbb58823ce7675f1d2048dcc7a27c05663d 
> 
> Diff: https://reviews.apache.org/r/42538/diff/
> 
> 
> Testing
> ---
> 
> make check(ubuntu14.04 + clang-3.6)
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 42939: Synchronized 'configuration.md' with the 'flags.cpp' files.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42939/
---

(Updated Jan. 29, 2016, 9:31 p.m.)


Review request for mesos and Vinod Kone.


Changes
---

removed dangling "depends on" link -- @vinodkone


Bugs: MESOS-4298
https://issues.apache.org/jira/browse/MESOS-4298


Repository: mesos


Description
---

Synchronized 'configuration.md' with the 'flags.cpp' files.

Programatically generated HTML from the flag help strings and imported that 
text into 'configuration.md', thus synchronizing the documentation with the 
source code.


Diffs
-

  docs/configuration.md b1ef1314eb9482a55015baa42b51d59b9f464a29 

Diff: https://reviews.apache.org/r/42939/diff/


Testing
---

Viewed with the mesos website container: 
https://github.com/mesosphere/mesos-website-container


Thanks,

Greg Mann

Re: Review Request 42929: Updated docker_build.sh to make build environment configurable.

[Kevin Klues]

> On Jan. 29, 2016, 1:01 a.m., Kevin Klues wrote:
> > Ship It!

Actually, would it be possible to make the --no-cache=true option configurable 
as well?  This is useful when running locally to speed up the build process 
when I know nothing significant has changed.


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42929/#review116854
---


On Jan. 29, 2016, 1:32 a.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42929/
> ---
> 
> (Updated Jan. 29, 2016, 1:32 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Greg Mann, and Kevin Klues.
> 
> 
> Bugs: MESOS-4523
> https://issues.apache.org/jira/browse/MESOS-4523
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated docker_build.sh to make build environment configurable.
> 
> 
> Diffs
> -
> 
>   support/docker_build.sh da94be87fae98825e60331634259eab0e7a4ebd1 
>   support/verify_reviews.py 251d57ec050b087f13b3f5e0d8f421fe8eb76787 
> 
> Diff: https://reviews.apache.org/r/42929/diff/
> 
> 
> Testing
> ---
> 
> Tested this via a custom CI job on ASF CI.
> 
> Note that the benchmark tests need to be reconfigured to not take a long 
> time. Currently they get aborted because they ran for > 5 hours.
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 42955: Added variadic template for process::collect.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42955/#review117021
---



Looks good, would be great if you could get some feedback from michael park on 
the gcc bug you encountered.


3rdparty/libprocess/include/process/collect.hpp (lines 43 - 44)


s/TYPES/Ts/ here and below



3rdparty/libprocess/include/process/collect.hpp (lines 217 - 225)


This looks ok to me, but could you ping mpark to see if he has any feedback 
on this?



3rdparty/libprocess/include/process/collect.hpp (line 223)


s/func/f/


- Ben Mahler


On Jan. 29, 2016, 9:18 p.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42955/
> ---
> 
> (Updated Jan. 29, 2016, 9:18 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Joris Van Remoortere, and Michael Park.
> 
> 
> Bugs: MESOS-4551
> https://issues.apache.org/jira/browse/MESOS-4551
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Previously, templates only existed to allow collect to take either a
> std::list of Futures, or *exactly* 2 Futures as arguments.
> 
> This commit removes the 2 argument template and replaces it with a
> variadic template that accepts an arbitrary number of Futures as
> arguments.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/collect.hpp 
> cd78b6c211c2e4ca2b1ebbe728cfc2dfad1a32c9 
> 
> Diff: https://reviews.apache.org/r/42955/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 42929: Updated docker_build.sh to make build environment configurable.

[Vinod Kone]

> On Jan. 29, 2016, 1:01 a.m., Kevin Klues wrote:
> > Ship It!
> 
> Kevin Klues wrote:
> Actually, would it be possible to make the --no-cache=true option 
> configurable as well?  This is useful when running locally to speed up the 
> build process when I know nothing significant has changed.

I'll let you do that in a separate patch :)


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42929/#review116854
---


On Jan. 29, 2016, 1:32 a.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42929/
> ---
> 
> (Updated Jan. 29, 2016, 1:32 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Greg Mann, and Kevin Klues.
> 
> 
> Bugs: MESOS-4523
> https://issues.apache.org/jira/browse/MESOS-4523
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated docker_build.sh to make build environment configurable.
> 
> 
> Diffs
> -
> 
>   support/docker_build.sh da94be87fae98825e60331634259eab0e7a4ebd1 
>   support/verify_reviews.py 251d57ec050b087f13b3f5e0d8f421fe8eb76787 
> 
> Diff: https://reviews.apache.org/r/42929/diff/
> 
> 
> Testing
> ---
> 
> Tested this via a custom CI job on ASF CI.
> 
> Note that the benchmark tests need to be reconfigured to not take a long 
> time. Currently they get aborted because they ran for > 5 hours.
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 42928: Updated docker_build.sh to generate xml output for all OSes.

[Vinod Kone]

> On Jan. 29, 2016, 12:11 a.m., Anand Mazumdar wrote:
> > Can we also set up the Jenkins xUnit Plugin to find the XML files we are 
> > now generating? AFAICT, we don't seem to be doing that currently.

Yes. Tracked at https://issues.apache.org/jira/browse/MESOS-4258.


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42928/#review116844
---


On Jan. 29, 2016, 12:06 a.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42928/
> ---
> 
> (Updated Jan. 29, 2016, 12:06 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Greg Mann, and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> xml output was originally only enabled for ubuntu. This enables it for all 
> OSes.
> 
> 
> Diffs
> -
> 
>   support/docker_build.sh da94be87fae98825e60331634259eab0e7a4ebd1 
> 
> Diff: https://reviews.apache.org/r/42928/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 42539: Support image specified Entrypoint and Cmd.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42539/
---

(Updated Jan. 29, 2016, 2:15 p.m.)


Review request for mesos, Jie Yu and Timothy Chen.


Bugs: MESOS-4004
https://issues.apache.org/jira/browse/MESOS-4004


Repository: mesos


Description
---

Support image specified Entrypoint and Cmd.


Diffs (updated)
-

  src/launcher/executor.cpp 356d311fdf97b2c4663c60e13ede7cdb71a264c7 
  src/slave/containerizer/mesos/containerizer.hpp 
811ab7937279c4a55da450c136f9fcb1303ea0d5 
  src/slave/containerizer/mesos/containerizer.cpp 
4b504dbb58823ce7675f1d2048dcc7a27c05663d 

Diff: https://reviews.apache.org/r/42539/diff/


Testing
---

make check(ubuntu14.04 + clang-3.6)


Thanks,

Gilbert Song

Re: Review Request 42539: Support image specified Entrypoint and Cmd.

[Gilbert Song]

> On Jan. 28, 2016, 6:48 p.m., haosdent huang wrote:
> > src/launcher/executor.cpp, line 269
> > 
> >
> > I could understand we need TaskCommand to combine different things. But 
> > because the interface is `void launchTask(ExecutorDriver* driver, const 
> > TaskInfo& task)`. Ignore it and use the command line param to launchTaks 
> > looks a bit strange. Maybe we change to `void launchTask(ExecutorDriver* 
> > driver, const TaskCommand& task)`

Hi, haosdent. Thank you for the reviews above. I understand that the way we do 
it in command executor is a little hacky. but:
1. It may not be realistic to change the api interface at this moment. 
2. Even if we can change the interface, it is still hard to pass information 
from containerizer back to slave.
3. If you look at the logic table in `mesos/containerizer.hpp` comments, you 
can see for most of the case in command executor, we will still use the 
`CommandInfo` from `TaskInfo` directly if no image is specified /or `value` is 
specified. Only for the cases that we need image default config, the 
`--task_command` flag will be attached.


- Gilbert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42539/#review116882
---


On Jan. 29, 2016, 2:15 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42539/
> ---
> 
> (Updated Jan. 29, 2016, 2:15 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Timothy Chen.
> 
> 
> Bugs: MESOS-4004
> https://issues.apache.org/jira/browse/MESOS-4004
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Support image specified Entrypoint and Cmd.
> 
> 
> Diffs
> -
> 
>   src/launcher/executor.cpp 356d311fdf97b2c4663c60e13ede7cdb71a264c7 
>   src/slave/containerizer/mesos/containerizer.hpp 
> 811ab7937279c4a55da450c136f9fcb1303ea0d5 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 4b504dbb58823ce7675f1d2048dcc7a27c05663d 
> 
> Diff: https://reviews.apache.org/r/42539/diff/
> 
> 
> Testing
> ---
> 
> make check(ubuntu14.04 + clang-3.6)
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 42786: Exposed the global 'help' process and added getter functions to it.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42786/
---

(Updated Jan. 29, 2016, 10:30 p.m.)


Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway.


Changes
---

Reversed order of patches between adding suppport for remove() and exposing 
Help externally with get() functions.


Bugs: MESOS-4552
https://issues.apache.org/jira/browse/MESOS-4552


Repository: mesos


Description
---

Previously, there was no way to extract the help strings from the help
process once they had been installed into it.  The only way to get at
them was to visit the http endpoint they were associated with and pull
it from there.

This commit adds API calls to the process::Help class to get at these
strings more easily.


Diffs (updated)
-

  3rdparty/libprocess/include/process/help.hpp 
2e76a6a5b1069abce879374a88cea65036873f1d 
  3rdparty/libprocess/include/process/process.hpp 
1e4126f1082c24debd9d713b490d18f5ed83f0be 
  3rdparty/libprocess/src/help.cpp 2f718b9e160113518fb4a0260db916cb2242dbae 

Diff: https://reviews.apache.org/r/42786/diff/


Testing
---


Thanks,

Kevin Klues

Re: Review Request 42957: Added remove() calls to process::Help.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42957/
---

(Updated Jan. 29, 2016, 10:30 p.m.)


Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway.


Changes
---

Reversed order of patches between adding suppport for remove() and exposing 
Help externally with get() functions.


Bugs: MESOS-4552
https://issues.apache.org/jira/browse/MESOS-4552


Repository: mesos


Description
---

Previously, there was no way to remove an installed help
string for a given endpoint.

This commit adds the ability to remove these help strings.


Diffs (updated)
-

  3rdparty/libprocess/include/process/help.hpp 
2e76a6a5b1069abce879374a88cea65036873f1d 
  3rdparty/libprocess/src/help.cpp 2f718b9e160113518fb4a0260db916cb2242dbae 

Diff: https://reviews.apache.org/r/42957/diff/


Testing
---


Thanks,

Kevin Klues

Re: Review Request 42955: Added variadic template for process::collect.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42955/
---

(Updated Jan. 29, 2016, 10:34 p.m.)


Review request for mesos, Jie Yu, Joris Van Remoortere, and Michael Park.


Changes
---

Addressed comment for 's/func/f/', still waiting for feedback on the gcc bug.


Bugs: MESOS-4551
https://issues.apache.org/jira/browse/MESOS-4551


Repository: mesos


Description
---

Previously, templates only existed to allow collect to take either a
std::list of Futures, or *exactly* 2 Futures as arguments.

This commit removes the 2 argument template and replaces it with a
variadic template that accepts an arbitrary number of Futures as
arguments.


Diffs (updated)
-

  3rdparty/libprocess/include/process/collect.hpp 
cd78b6c211c2e4ca2b1ebbe728cfc2dfad1a32c9 

Diff: https://reviews.apache.org/r/42955/diff/


Testing
---


Thanks,

Kevin Klues

Re: Review Request 42956: Added variadic template for process::await.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42956/
---

(Updated Jan. 29, 2016, 10:35 p.m.)


Review request for mesos, Jie Yu, Joris Van Remoortere, and Michael Park.


Changes
---

Addressed similar comment in 42955 for 's/func/f/', still waiting for feedback 
on the gcc bug.


Bugs: MESOS-4551
https://issues.apache.org/jira/browse/MESOS-4551


Repository: mesos


Description
---

Previously, templates only existed to allow await to take either a
std::list of Futures, *exactly* 2 Futures as arguments, or *exactly* 3
Futures as arguments.

This commit removes the 2 and 3 argument templates and replaces them
with a variadic template that accepts an arbitrary number of Futures as
arguments.


Diffs (updated)
-

  3rdparty/libprocess/include/process/collect.hpp 
cd78b6c211c2e4ca2b1ebbe728cfc2dfad1a32c9 

Diff: https://reviews.apache.org/r/42956/diff/


Testing
---


Thanks,

Kevin Klues

Review Request 42980: Increased the default registry_store_timeout.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42980/
---

Review request for mesos, David Robinson and Vinod Kone.


Repository: mesos


Description
---

In order to be more tolerant of disk bandwidth interference
on the master machines, we should increase the default
registry store timeout. As it stands, the master is prone
to induce a failover when the master is temporarily starved
of disk bandwidth.


Diffs
-

  docs/configuration.md 2f0628a71539ad66fbd96c6a7ff2c7c8eb518e32 
  src/master/flags.cpp 4a0e21092bfad8baee0279d473e6056842139be7 

Diff: https://reviews.apache.org/r/42980/diff/


Testing
---

N/A


Thanks,

Ben Mahler

Re: Review Request 42980: Increased the default registry_store_timeout.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42980/#review117039
---


Ship it!




Ship It!

- Vinod Kone


On Jan. 29, 2016, 10:46 p.m., Ben Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42980/
> ---
> 
> (Updated Jan. 29, 2016, 10:46 p.m.)
> 
> 
> Review request for mesos, David Robinson and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In order to be more tolerant of disk bandwidth interference
> on the master machines, we should increase the default
> registry store timeout. As it stands, the master is prone
> to induce a failover when the master is temporarily starved
> of disk bandwidth.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 2f0628a71539ad66fbd96c6a7ff2c7c8eb518e32 
>   src/master/flags.cpp 4a0e21092bfad8baee0279d473e6056842139be7 
> 
> Diff: https://reviews.apache.org/r/42980/diff/
> 
> 
> Testing
> ---
> 
> N/A
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Re: Review Request 42980: Increased the default registry_store_timeout.

[David Robinson]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42980/#review117040
---


Ship it!




Ship It!

- David Robinson


On Jan. 29, 2016, 10:46 p.m., Ben Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42980/
> ---
> 
> (Updated Jan. 29, 2016, 10:46 p.m.)
> 
> 
> Review request for mesos, David Robinson and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In order to be more tolerant of disk bandwidth interference
> on the master machines, we should increase the default
> registry store timeout. As it stands, the master is prone
> to induce a failover when the master is temporarily starved
> of disk bandwidth.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 2f0628a71539ad66fbd96c6a7ff2c7c8eb518e32 
>   src/master/flags.cpp 4a0e21092bfad8baee0279d473e6056842139be7 
> 
> Diff: https://reviews.apache.org/r/42980/diff/
> 
> 
> Testing
> ---
> 
> N/A
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Review Request 42947: Implemented the `status` method in `CgroupNetClsIsolatorProcess`.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42947/
---

Review request for mesos and Jie Yu.


Bugs: MESOS-4489
https://issues.apache.org/jira/browse/MESOS-4489


Repository: mesos


Description
---

Implemented the `status` method in `CgroupNetClsIsolatorProcess`.


Diffs
-

  src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp 
b4bc52114389d1c1efce2830f4292bd89bb0de7c 
  src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp 
ddc1bf0939e5e8995e6f34fe7b8509b51704f63e 

Diff: https://reviews.apache.org/r/42947/diff/


Testing
---


Thanks,

Avinash sridharan

Re: Review Request 42539: Support image specified Entrypoint and Cmd.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42539/#review116972
---




src/launcher/executor.cpp (line 86)


Please use camel case for variable names. So please use `_taskCommmand` 
here.



src/launcher/executor.cpp (line 99)


Ditto.



src/slave/containerizer/mesos/containerizer.hpp (lines 224 - 264)


No need to show this table here. you can just move it to the cpp file. This 
is implementation detail.



src/slave/containerizer/mesos/containerizer.hpp (line 268)


If command executor is used, the provisionInfo here should be the 
provisionInfo returned for .rootfs volume, right? Have you figured out this 
part?



src/slave/containerizer/mesos/containerizer.cpp (line 995)


s/commandInfo/executorLaunchCommand/



src/slave/containerizer/mesos/containerizer.cpp (line 996)


I would rename it to `getExecutorLaunchCommand`



src/slave/containerizer/mesos/containerizer.cpp (line 999)


The error message could be more informative:
```
Failed to determine the executor launch command...
```



src/slave/containerizer/mesos/containerizer.cpp (line 1084)


You want to move the commments in the header here. The method level 
comments should explain what this function is doing and returns what.

You can put the giant table in the method body.



src/slave/containerizer/mesos/containerizer.cpp (lines 1084 - 1100)


I would suggest the following flow for this function:

1. Get 'command' in Mesos. The command is executorInfo.command if 
taskInfo.isNone(). Otherwise, use taskInfo.command().

2. Use the table to calculate the final command based on docker manifest.

3. if taskInfo.isNone(), return the command obtained in step 2. Otherwise, 
set override command flag for executorInfo.command().



src/slave/containerizer/mesos/containerizer.cpp (line 1100)


s/commandInfo/command/



src/slave/containerizer/mesos/containerizer.cpp (line 1117)


why not container_config here?



src/slave/containerizer/mesos/containerizer.cpp (line 1159)


return Error?


- Jie Yu


On Jan. 29, 2016, 10:15 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42539/
> ---
> 
> (Updated Jan. 29, 2016, 10:15 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Timothy Chen.
> 
> 
> Bugs: MESOS-4004
> https://issues.apache.org/jira/browse/MESOS-4004
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Support image specified Entrypoint and Cmd.
> 
> 
> Diffs
> -
> 
>   src/launcher/executor.cpp 356d311fdf97b2c4663c60e13ede7cdb71a264c7 
>   src/slave/containerizer/mesos/containerizer.hpp 
> 811ab7937279c4a55da450c136f9fcb1303ea0d5 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 4b504dbb58823ce7675f1d2048dcc7a27c05663d 
> 
> Diff: https://reviews.apache.org/r/42539/diff/
> 
> 
> Testing
> ---
> 
> make check(ubuntu14.04 + clang-3.6)
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 42947: Implemented the `status` method in `CgroupNetClsIsolatorProcess`.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42947/
---

(Updated Jan. 29, 2016, 11:16 p.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-4489
https://issues.apache.org/jira/browse/MESOS-4489


Repository: mesos


Description
---

Implemented the `status` method in `CgroupNetClsIsolatorProcess`.


Diffs
-

  src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp 
b4bc52114389d1c1efce2830f4292bd89bb0de7c 
  src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp 
ddc1bf0939e5e8995e6f34fe7b8509b51704f63e 

Diff: https://reviews.apache.org/r/42947/diff/


Testing (updated)
---

make and make check.


Thanks,

Avinash sridharan

Review Request 42986: Updated webui to show count for tasks in `TASK_RUNNING` state.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42986/
---

Review request for mesos, Ben Mahler and Joris Van Remoortere.


Bugs: MESOS-4562
https://issues.apache.org/jira/browse/MESOS-4562


Repository: mesos


Description
---

Previously, it was showing the count for tasks in `TASK_STARTING` state.


Diffs
-

  src/webui/master/static/js/controllers.js 
36865f1cd6a4518ba30cd6e64d4d7347762066ec 

Diff: https://reviews.apache.org/r/42986/diff/


Testing
---

Launched 100 sleeps tasks and verified the status in webui.


Thanks,

Kapil Arya

Review Request 42987: Renamed a parameter for the sake of clarity.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42987/
---

Review request for mesos and Joris Van Remoortere.


Repository: mesos


Description
---

We use several different "timeouts" in this code and the "Zk session timeout"
has a very specific meaning in this context.


Diffs
-

  src/zookeeper/group.hpp cf82fec290a2fa9bec122539c2eb0f12b45c2fb2 
  src/zookeeper/group.cpp 2ae3193e0e138c90b205d45400d80e80853e1b99 
  src/zookeeper/zookeeper.hpp 573ff5bca56cbb7efb98f6eb4f1796a2bc176b5e 
  src/zookeeper/zookeeper.cpp 3c4fdad972dcd1728c52a05970646c713dcf98c8 

Diff: https://reviews.apache.org/r/42987/diff/


Testing
---

make check


Thanks,

Neil Conway

Review Request 42988: Changed ZooKeeper reconnection logic to retry more aggressively.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42988/
---

Review request for mesos and Joris Van Remoortere.


Bugs: MESOS-4546
https://issues.apache.org/jira/browse/MESOS-4546


Repository: mesos


Description
---

The previous implementation of `GroupProcess` tried to establish a single
ZooKeeper connection on startup, but didn't attempt to retry. ZooKeeper will
retry internally, but it only retries by attempting to reconnect to a list of
previously resolved; it doesn't attempt to re-resolve those IPs to pickup
updates to DNS configuration. Because DNS configuration can be quite dynamic,
arrange to close the current Zk handle and open a new one if we've seen a
successful `zookeeper_init` but haven't been connected within the ZooKeeper
session timeout.


Diffs
-

  src/zookeeper/group.hpp cf82fec290a2fa9bec122539c2eb0f12b45c2fb2 
  src/zookeeper/group.cpp 2ae3193e0e138c90b205d45400d80e80853e1b99 
  src/zookeeper/zookeeper.cpp 3c4fdad972dcd1728c52a05970646c713dcf98c8 

Diff: https://reviews.apache.org/r/42988/diff/


Testing
---

make check, on both OSX and Arch Linux. Manually configured a situation in 
which the Mesos agent uses stale DNS information in a loop: validated that 
without the patch, we don't pickup DNS changes, whereas with the patch, we do.


Thanks,

Neil Conway

Re: Review Request 42955: Added variadic template for process::collect.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42955/#review117060
---



LGTM, but it would be nice to include a pointer to the GCC bug 
(https://gcc.gnu.org/bugzilla/show_bug.cgi?id=47226) and probably also the 
workaround more prominently.

- Benjamin Bannier


On Jan. 29, 2016, 11:34 p.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42955/
> ---
> 
> (Updated Jan. 29, 2016, 11:34 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Joris Van Remoortere, and Michael Park.
> 
> 
> Bugs: MESOS-4551
> https://issues.apache.org/jira/browse/MESOS-4551
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Previously, templates only existed to allow collect to take either a
> std::list of Futures, or *exactly* 2 Futures as arguments.
> 
> This commit removes the 2 argument template and replaces it with a
> variadic template that accepts an arbitrary number of Futures as
> arguments.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/collect.hpp 
> cd78b6c211c2e4ca2b1ebbe728cfc2dfad1a32c9 
> 
> Diff: https://reviews.apache.org/r/42955/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 42956: Added variadic template for process::await.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42956/#review117061
---



LGTM, but it would be nice to include a pointer to the GCC bug 
(https://gcc.gnu.org/bugzilla/show_bug.cgi?id=47226) and probably also the 
workaround more prominently.

- Benjamin Bannier


On Jan. 29, 2016, 11:35 p.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42956/
> ---
> 
> (Updated Jan. 29, 2016, 11:35 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Joris Van Remoortere, and Michael Park.
> 
> 
> Bugs: MESOS-4551
> https://issues.apache.org/jira/browse/MESOS-4551
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Previously, templates only existed to allow await to take either a
> std::list of Futures, *exactly* 2 Futures as arguments, or *exactly* 3
> Futures as arguments.
> 
> This commit removes the 2 and 3 argument templates and replaces them
> with a variadic template that accepts an arbitrary number of Futures as
> arguments.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/collect.hpp 
> cd78b6c211c2e4ca2b1ebbe728cfc2dfad1a32c9 
> 
> Diff: https://reviews.apache.org/r/42956/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 42990: Suppressed AngularJS "Interpolation Error" in browser console.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42990/
---

(Updated Jan. 29, 2016, 6:55 p.m.)


Review request for mesos.


Summary (updated)
-

Suppressed AngularJS "Interpolation Error" in browser console.


Repository: mesos


Description
---

Suppressed Interpolation Error in browser console.


Diffs
-

  src/webui/master/static/js/controllers.js 
36865f1cd6a4518ba30cd6e64d4d7347762066ec 

Diff: https://reviews.apache.org/r/42990/diff/


Testing
---

Verified that no errors are generated in the browser console.


Thanks,

Kapil Arya

Review Request 42990: Suppressed Interpolation Error in browser console.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42990/
---

Review request for mesos.


Repository: mesos


Description
---

Suppressed Interpolation Error in browser console.


Diffs
-

  src/webui/master/static/js/controllers.js 
36865f1cd6a4518ba30cd6e64d4d7347762066ec 

Diff: https://reviews.apache.org/r/42990/diff/


Testing
---

Verified that no errors are generated in the browser console.


Thanks,

Kapil Arya

Re: Review Request 42988: Changed ZooKeeper reconnection logic to retry more aggressively.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42988/
---

(Updated Jan. 29, 2016, 11:57 p.m.)


Review request for mesos and Joris Van Remoortere.


Changes
---

Tweak commit message.


Bugs: MESOS-4546
https://issues.apache.org/jira/browse/MESOS-4546


Repository: mesos


Description (updated)
---

The previous implementation of `GroupProcess` tried to establish a single
ZooKeeper connection on startup, but didn't attempt to retry. ZooKeeper will
retry internally, but it only retries by attempting to reconnect to a list of
previously resolved IPs; it doesn't attempt to re-resolve those IPs to pickup
updates to DNS configuration. Because DNS configuration can be quite dynamic,
we now close the current Zk handle and open a new one if we've seen a
successful `zookeeper_init` but haven't been connected within the ZooKeeper
session timeout.


Diffs (updated)
-

  src/zookeeper/group.hpp cf82fec290a2fa9bec122539c2eb0f12b45c2fb2 
  src/zookeeper/group.cpp 2ae3193e0e138c90b205d45400d80e80853e1b99 
  src/zookeeper/zookeeper.cpp 3c4fdad972dcd1728c52a05970646c713dcf98c8 

Diff: https://reviews.apache.org/r/42988/diff/


Testing
---

make check, on both OSX and Arch Linux. Manually configured a situation in 
which the Mesos agent uses stale DNS information in a loop: validated that 
without the patch, we don't pickup DNS changes, whereas with the patch, we do.


Thanks,

Neil Conway

Re: Review Request 42990: Suppressed AngularJS "Interpolation Error" in browser console.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42990/
---

(Updated Jan. 29, 2016, 7 p.m.)


Review request for mesos.


Repository: mesos


Description (updated)
---

Suppressed Interpolation Error in browser console. Here is an example:
https://docs.angularjs.org/error/$interpolate/interr?p0=%7B%7Btotal_cpus%20%7C%20decimalFloat%7D%7D&p1=TypeError:%20Cannot%20read%20property%20%27toFixed%27%20of%20undefined


Diffs
-

  src/webui/master/static/js/controllers.js 
36865f1cd6a4518ba30cd6e64d4d7347762066ec 

Diff: https://reviews.apache.org/r/42990/diff/


Testing
---

Verified that no errors are generated in the browser console.


Thanks,

Kapil Arya

Re: Review Request 42988: Changed ZooKeeper reconnection logic to retry more aggressively.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42988/
---

(Updated Jan. 30, 2016, midnight)


Review request for mesos and Joris Van Remoortere.


Changes
---

Tweak comment.


Bugs: MESOS-4546
https://issues.apache.org/jira/browse/MESOS-4546


Repository: mesos


Description
---

The previous implementation of `GroupProcess` tried to establish a single
ZooKeeper connection on startup, but didn't attempt to retry. ZooKeeper will
retry internally, but it only retries by attempting to reconnect to a list of
previously resolved IPs; it doesn't attempt to re-resolve those IPs to pickup
updates to DNS configuration. Because DNS configuration can be quite dynamic,
we now close the current Zk handle and open a new one if we've seen a
successful `zookeeper_init` but haven't been connected within the ZooKeeper
session timeout.


Diffs (updated)
-

  src/zookeeper/group.hpp cf82fec290a2fa9bec122539c2eb0f12b45c2fb2 
  src/zookeeper/group.cpp 2ae3193e0e138c90b205d45400d80e80853e1b99 
  src/zookeeper/zookeeper.cpp 3c4fdad972dcd1728c52a05970646c713dcf98c8 

Diff: https://reviews.apache.org/r/42988/diff/


Testing
---

make check, on both OSX and Arch Linux. Manually configured a situation in 
which the Mesos agent uses stale DNS information in a loop: validated that 
without the patch, we don't pickup DNS changes, whereas with the patch, we do.


Thanks,

Neil Conway

Re: Review Request 42988: Changed ZooKeeper reconnection logic to retry more aggressively.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42988/#review117063
---




src/zookeeper/group.cpp (line 366)


I _believe_ that the connect timer will always be set when we reach here, 
but I want to double-check this.


- Neil Conway


On Jan. 30, 2016, midnight, Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42988/
> ---
> 
> (Updated Jan. 30, 2016, midnight)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-4546
> https://issues.apache.org/jira/browse/MESOS-4546
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The previous implementation of `GroupProcess` tried to establish a single
> ZooKeeper connection on startup, but didn't attempt to retry. ZooKeeper will
> retry internally, but it only retries by attempting to reconnect to a list of
> previously resolved IPs; it doesn't attempt to re-resolve those IPs to pickup
> updates to DNS configuration. Because DNS configuration can be quite dynamic,
> we now close the current Zk handle and open a new one if we've seen a
> successful `zookeeper_init` but haven't been connected within the ZooKeeper
> session timeout.
> 
> 
> Diffs
> -
> 
>   src/zookeeper/group.hpp cf82fec290a2fa9bec122539c2eb0f12b45c2fb2 
>   src/zookeeper/group.cpp 2ae3193e0e138c90b205d45400d80e80853e1b99 
>   src/zookeeper/zookeeper.cpp 3c4fdad972dcd1728c52a05970646c713dcf98c8 
> 
> Diff: https://reviews.apache.org/r/42988/diff/
> 
> 
> Testing
> ---
> 
> make check, on both OSX and Arch Linux. Manually configured a situation in 
> which the Mesos agent uses stale DNS information in a loop: validated that 
> without the patch, we don't pickup DNS changes, whereas with the patch, we do.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 42990: Suppressed AngularJS "Interpolation Error" in browser console.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42990/
---

(Updated Jan. 29, 2016, 7:05 p.m.)


Review request for mesos.


Repository: mesos


Description (updated)
---

The "decimalFloat" filter was being applied to undefined variables causing an 
"Interpolation Error". We now check for 'undefined' and return 0 instead of 
applying the filter.


Diffs
-

  src/webui/master/static/js/controllers.js 
36865f1cd6a4518ba30cd6e64d4d7347762066ec 

Diff: https://reviews.apache.org/r/42990/diff/


Testing
---

Verified that no errors are generated in the browser console.


Thanks,

Kapil Arya

Review Request 42993: [2 of 7] Support for multiple frameworks sharing the same resource.

[Anindya Sinha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42993/
---

Review request for mesos and Adam B.


Bugs: MESOS-4431
https://issues.apache.org/jira/browse/MESOS-4431


Repository: mesos


Description
---

The allocator tracks allocated shared resources separately from the
remaining allocated resources so that multiple frameworks see the
same view of the shared resource at any given time.


Diffs
-

  src/master/allocator/mesos/hierarchical.cpp 
1a07d69016407e5aad2209586da37fecbcddb765 
  src/master/allocator/sorter/drf/sorter.hpp 
4669149b81de39b4bb921ef7cd6787aa583f6e40 
  src/master/allocator/sorter/drf/sorter.cpp 
db47d640e36c0302d7c6254a9c58caa878feac01 
  src/master/allocator/sorter/sorter.hpp 
a0a779b81f6d048271f15256b38ff907ae144b83 
  src/master/master.cpp 98441a543611d4083b2495ee103f0ab5e2187e83 

Diff: https://reviews.apache.org/r/42993/diff/


Testing
---

make check done.


Thanks,

Anindya Sinha

Review Request 42992: [1 of 7] Support sharing of resources through reference counting of resources.

[Anindya Sinha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42992/
---

Review request for mesos and Adam B.


Bugs: MESOS-4431
https://issues.apache.org/jira/browse/MESOS-4431


Repository: mesos


Description
---

* Added new Offer::Operation of SHARE and UNSHARE for resources.
* Added ShareInfo within Resources protobuf to allow for sharing of resources
  and keep track of consumers of such resources.
* Allow DESTROY or UNSHARE for shared volumes only if reference count is 0.


Diffs
-

  include/mesos/mesos.proto 194750e92020753e60154083a47bdc3398d31466 
  include/mesos/resources.hpp 6bfac2e7e8799e74d87c7570fc5eef320ba76eb1 
  include/mesos/v1/mesos.proto 1102bbc92f46f97c1915c03a71c7cf829003e0ed 
  include/mesos/v1/resources.hpp 5a88c0756db2ea8db0f5df7ea3019b511ea135af 
  src/common/resources.cpp 588a279c3cdebbeb58047bfbff5e78a42f53fc13 
  src/common/resources_utils.cpp 70e6f025d89383084ab8b2cda23ab1cd55d959b2 
  src/master/allocator/mesos/hierarchical.cpp 
1a07d69016407e5aad2209586da37fecbcddb765 
  src/master/allocator/sorter/drf/sorter.cpp 
db47d640e36c0302d7c6254a9c58caa878feac01 
  src/master/master.hpp 3a7e18232323a1c051bcc97915484b1195fffe58 
  src/master/master.cpp 98441a543611d4083b2495ee103f0ab5e2187e83 
  src/master/validation.hpp 380b40279faf180a6f401a5e28280b601dbc648c 
  src/master/validation.cpp f2bc1bad79e3b0812c019be3774cd65b58ea2d07 
  src/v1/resources.cpp be4a5d153e9313cb71a6e85d1ed25a358537f2b7 

Diff: https://reviews.apache.org/r/42992/diff/


Testing
---

make check done.


Thanks,

Anindya Sinha

Review Request 42994: [3 of 7] Added a persistent volume test framework for shared volumes.

[Anindya Sinha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42994/
---

Review request for mesos and Adam B.


Bugs: MESOS-4431
https://issues.apache.org/jira/browse/MESOS-4431


Repository: mesos


Description
---

Added a persistent volume test framework for shared volumes.


Diffs
-

  src/Makefile.am fac17f4bac3b2ddda0384dec8b0ed6f960bd24d1 
  src/examples/persistent_shared_volume_framework.cpp PRE-CREATION 
  src/tests/examples_tests.cpp a9b685b0290f23461f43b12f05f6071fa46412a6 
  src/tests/persistent_shared_volume_framework_test.sh PRE-CREATION 

Diff: https://reviews.apache.org/r/42994/diff/


Testing
---

make check done.


Thanks,

Anindya Sinha

Review Request 42981: Rename `IO::DUPLICATE` to avoid conflict with Windows macro.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42981/
---

Review request for mesos, Joris Van Remoortere and Joseph Wu.


Repository: mesos


Description
---

Rename `IO::DUPLICATE` to avoid conflict with Windows macro.


Diffs
-

  3rdparty/libprocess/include/process/subprocess.hpp 
482ea23410300997956e2a8ece397cb96157894c 
  3rdparty/libprocess/src/subprocess.cpp 
ef0568789277510471713337d7675bdcc3e7d74b 

Diff: https://reviews.apache.org/r/42981/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 42981: Rename `IO::DUPLICATE` to avoid conflict with Windows macro.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42981/#review117072
---


Ship it!




Ship It!

- Joseph Wu


On Jan. 29, 2016, 4:30 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42981/
> ---
> 
> (Updated Jan. 29, 2016, 4:30 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Rename `IO::DUPLICATE` to avoid conflict with Windows macro.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/subprocess.hpp 
> 482ea23410300997956e2a8ece397cb96157894c 
>   3rdparty/libprocess/src/subprocess.cpp 
> ef0568789277510471713337d7675bdcc3e7d74b 
> 
> Diff: https://reviews.apache.org/r/42981/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 42988: Changed ZooKeeper reconnection logic to retry more aggressively.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42988/
---

(Updated Jan. 30, 2016, 1:16 a.m.)


Review request for mesos and Joris Van Remoortere.


Changes
---

Added unit test.


Bugs: MESOS-4546
https://issues.apache.org/jira/browse/MESOS-4546


Repository: mesos


Description
---

The previous implementation of `GroupProcess` tried to establish a single
ZooKeeper connection on startup, but didn't attempt to retry. ZooKeeper will
retry internally, but it only retries by attempting to reconnect to a list of
previously resolved IPs; it doesn't attempt to re-resolve those IPs to pickup
updates to DNS configuration. Because DNS configuration can be quite dynamic,
we now close the current Zk handle and open a new one if we've seen a
successful `zookeeper_init` but haven't been connected within the ZooKeeper
session timeout.


Diffs (updated)
-

  src/tests/group_tests.cpp 77349465e0163c8aa6bed6deefe3f98efb442f3d 
  src/zookeeper/group.hpp cf82fec290a2fa9bec122539c2eb0f12b45c2fb2 
  src/zookeeper/group.cpp 2ae3193e0e138c90b205d45400d80e80853e1b99 
  src/zookeeper/zookeeper.cpp 3c4fdad972dcd1728c52a05970646c713dcf98c8 

Diff: https://reviews.apache.org/r/42988/diff/


Testing (updated)
---

make check, on both OSX and Arch Linux. Manually configured a situation in 
which the Mesos agent uses stale DNS information in a loop: validated that 
without the patch, we don't pickup DNS changes, whereas with the patch, we do.

Also added a new unit test. Verified that the test fails w/o this patch applied 
and passes deterministically (`gtest_repeat=100`) with the patch applied.


Thanks,

Neil Conway

Re: Review Request 42947: Implemented the `status` method in `CgroupNetClsIsolatorProcess`.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42947/#review117075
---



Bad patch!

Reviews applied: [42947]

Failed command: ./support/apply-review.sh -n -r 42947

Error:
2016-01-30 01:26:23 URL:https://reviews.apache.org/r/42947/diff/raw/ 
[2135/2135] -> "42947.patch" [1]
error: patch failed: 
src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp:57
error: src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp: patch does 
not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/11129/console

- Mesos ReviewBot


On Jan. 29, 2016, 11:16 p.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42947/
> ---
> 
> (Updated Jan. 29, 2016, 11:16 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4489
> https://issues.apache.org/jira/browse/MESOS-4489
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented the `status` method in `CgroupNetClsIsolatorProcess`.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp 
> b4bc52114389d1c1efce2830f4292bd89bb0de7c 
>   src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp 
> ddc1bf0939e5e8995e6f34fe7b8509b51704f63e 
> 
> Diff: https://reviews.apache.org/r/42947/diff/
> 
> 
> Testing
> ---
> 
> make and make check.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Review Request 42997: [6 of 7] Offer shareable resources to frameworks only if opted in.

[Anindya Sinha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42997/
---

Review request for mesos and Adam B.


Bugs: MESOS-4325
https://issues.apache.org/jira/browse/MESOS-4325


Repository: mesos


Description
---

Added a new capability SHAREABLE_RESOURCES that frameworks need to opt in
if they are interested in receiving shared resources in their offers.


Diffs
-

  include/mesos/mesos.proto 194750e92020753e60154083a47bdc3398d31466 
  include/mesos/v1/mesos.proto 1102bbc92f46f97c1915c03a71c7cf829003e0ed 
  src/examples/persistent_shared_volume_framework.cpp PRE-CREATION 
  src/master/master.cpp 98441a543611d4083b2495ee103f0ab5e2187e83 

Diff: https://reviews.apache.org/r/42997/diff/


Testing
---

make check done.


Thanks,

Anindya Sinha

Review Request 42995: [4 of 7] Allow tasks to set persistent volume as readonly or readwrite resource.

[Anindya Sinha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42995/
---

Review request for mesos and Adam B.


Bugs: MESOS-4324
https://issues.apache.org/jira/browse/MESOS-4324


Repository: mesos


Description
---

* If the task is the first consumer of the shared persistent volume, then
  set the ownership of the persistent volume to match that of the task.
  Otherwise, allow the task to be executed only if the ownership of the
  persistent volume matches that of the task.
* Allow the task to specify the persistent volume access to be read-only
  or read-write. Note that the persistent volume is always created as
  read-write.


Diffs
-

  src/examples/persistent_shared_volume_framework.cpp PRE-CREATION 
  src/master/master.cpp 98441a543611d4083b2495ee103f0ab5e2187e83 
  src/master/validation.hpp 380b40279faf180a6f401a5e28280b601dbc648c 
  src/master/validation.cpp f2bc1bad79e3b0812c019be3774cd65b58ea2d07 
  src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
24ff8194bb5ea86a31224d2d2c20d367472168aa 
  src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 
bce5ab9a1913ee7cebaf55b5ee0b42fa4a325e87 

Diff: https://reviews.apache.org/r/42995/diff/


Testing
---

make check done.


Thanks,

Anindya Sinha