Re: Review Request 43634: Consistent markdown code style in persistent-volumes.md.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43634/#review121210
---




docs/persistent-volume.md (lines 82 - 106)


Turns out this part actually needs 8 spaces since it's a body of a list. 
Fixed and committed.


- Michael Park


On Feb. 22, 2016, 5:18 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43634/
> ---
> 
> (Updated Feb. 22, 2016, 5:18 p.m.)
> 
> 
> Review request for mesos, Michael Park and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Consistent markdown code style in persistent-volumes.md.
> 
> 
> Diffs
> -
> 
>   docs/persistent-volume.md 2a794a572ff930aa1f95706b89fef9243be627de 
> 
> Diff: https://reviews.apache.org/r/43634/diff/
> 
> 
> Testing
> ---
> 
> Viewed via gist (https://gist.github.com/joerg84/74e065fbcfd130d90cf7) and 
> Docker website container.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 43798: Added overview section to upgrades.md.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43798/#review121211
---



Sorry about the premature `ShipIt`. Upon inspection of the local generation of 
the website, I think we should figure out an alternative layout for the 
"Overview" section.

Could you check it out for yourself as well and let me know what you think?


docs/upgrades.md (lines 28 - 29)


We need a newline in between these for the `*` to get rendered properly.


- Michael Park


On Feb. 23, 2016, 9:39 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43798/
> ---
> 
> (Updated Feb. 23, 2016, 9:39 p.m.)
> 
> 
> Review request for mesos, Michael Park, Neil Conway, and Till Toenshoff.
> 
> 
> Bugs: MESOS-4381
> https://issues.apache.org/jira/browse/MESOS-4381
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added overview section to upgrades.md.
> 
> 
> Diffs
> -
> 
>   docs/upgrades.md 4f30d725c6ed28c09a1c5528fd4193c3f06b2d93 
> 
> Diff: https://reviews.apache.org/r/43798/diff/
> 
> 
> Testing
> ---
> 
> Viewed via gist (https://gist.github.com/joerg84/eddbc0302a5a4b291e81) and 
> docker website container.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 42590: Removed reserved() API.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42590/#review121213
---



Bad patch!

Reviews applied: [42590]

Failed command: ./support/apply-review.sh -n -r 42590

Error:
2016-02-29 08:34:54 URL:https://reviews.apache.org/r/42590/diff/raw/ 
[5284/5284] -> "42590.patch" [1]
error: patch failed: include/mesos/resources.hpp:235
error: include/mesos/resources.hpp: patch does not apply
error: patch failed: include/mesos/v1/resources.hpp:235
error: include/mesos/v1/resources.hpp: patch does not apply
error: patch failed: src/common/resources.cpp:808
error: src/common/resources.cpp: patch does not apply
error: patch failed: src/master/http.cpp:475
error: src/master/http.cpp: patch does not apply
error: patch failed: src/v1/resources.cpp:802
error: src/v1/resources.cpp: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/11729/console

- Mesos ReviewBot


On Feb. 29, 2016, 7:54 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42590/
> ---
> 
> (Updated Feb. 29, 2016, 7:54 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van 
> Remoortere, Joseph Wu, and Klaus Ma.
> 
> 
> Bugs: MESOS-4447
> https://issues.apache.org/jira/browse/MESOS-4447
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed reserved() API.
> 
> 
> Diffs
> -
> 
>   include/mesos/resources.hpp cc8fef9470d779078aa408ed03e747e5a492deaa 
>   include/mesos/v1/resources.hpp f4892977f8d7b0439db6e9cf7921334f606a496c 
>   src/common/resources.cpp 575d6651185d8431f01d589f4afc255cb751181a 
>   src/master/http.cpp 12c1fe5a514903f657911302e8770e9b245fdbb7 
>   src/tests/resources_tests.cpp b42610f1bf8eacfd7bf388d351f8745f1d96f666 
>   src/v1/resources.cpp 8de6672ba9b34947db81c74b8e03e8965e8af5fc 
> 
> Diff: https://reviews.apache.org/r/42590/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 43701: Added a command executor based on the new V1 API.

[Qian Zhang]

> On Feb. 29, 2016, 1:42 a.m., Shuai Lin wrote:
> > src/launcher/http_executor.cpp, line 82
> > 
> >
> > Maybe we should also add some tests that launches tasks with this new 
> > http cmd executor?

Yes, agree!


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43701/#review121155
---


On Feb. 20, 2016, 9:44 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43701/
> ---
> 
> (Updated Feb. 20, 2016, 9:44 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3558
> https://issues.apache.org/jira/browse/MESOS-3558
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a command executor based on the new V1 API.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md b04e873009dc783cc50eb02a459f0587d020ad23 
>   include/mesos/v1/mesos.proto e4224afe2245d649afa1a6c97bae26c215e6fada 
>   src/Makefile.am 27aec37524aa33211e0ca4594e127ebb4279e9b0 
>   src/launcher/http_executor.cpp PRE-CREATION 
>   src/slave/flags.hpp 54c1a69d8777f417cdd8f73ce638447d9951ab61 
>   src/slave/flags.cpp 855812e9f7cb4b96d4297f4bd5ac5de7f1d3c39a 
>   src/slave/slave.cpp f0be0d5bf4b853952caf06e2e262c2903d79ead3 
> 
> Diff: https://reviews.apache.org/r/43701/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 44096: Fixed assignment line wrapping in style guide example.

[Till Toenshoff]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44096/#review121216
---


Ship it!




Ship It!

- Till Toenshoff


On Feb. 26, 2016, 6:49 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44096/
> ---
> 
> (Updated Feb. 26, 2016, 6:49 p.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Bugs: MESOS-4786
> https://issues.apache.org/jira/browse/MESOS-4786
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed assignment line wrapping in style guide example.
> 
> 
> Diffs
> -
> 
>   docs/c++-style-guide.md 5e2d88d5a7ae06191346bf672f58dbe27b2bccee 
> 
> Diff: https://reviews.apache.org/r/44096/diff/
> 
> 
> Testing
> ---
> 
> Confirmed correct rendering with bundled site-docker container.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 42590: Removed reserved() API.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42590/
---

(Updated 二月 29, 2016, 9:11 a.m.)


Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, 
Joseph Wu, and Klaus Ma.


Bugs: MESOS-4447
https://issues.apache.org/jira/browse/MESOS-4447


Repository: mesos


Description
---

Removed reserved() API.


Diffs (updated)
-

  include/mesos/resources.hpp fe8a5745ea7d4943c47ac22c73db70488c6dfa9f 
  include/mesos/v1/resources.hpp c27927e4f0d7f45e69fe3312b2423afb64c5c51e 
  src/common/resources.cpp 4fa1e78606485d6657d3776e28b78a43cc6449d2 
  src/master/http.cpp 5e9e28e904ba0045ee27eb828f47231632a91d74 
  src/tests/resources_tests.cpp a545100522bf4b1f03e50656d461b3cda6b41e11 
  src/v1/resources.cpp bca523159577994d5890f832e4f61101b5dbf3bc 

Diff: https://reviews.apache.org/r/42590/diff/


Testing (updated)
---

make
make check
./bin/mesos-tests.sh  --gtest_filter="ResourcesTest.*"


Thanks,

Guangya Liu

Re: Review Request 43701: Added a command executor based on the new V1 API.

[Qian Zhang]

> On Feb. 29, 2016, 10:24 a.m., Vinod Kone wrote:
> > Thanks for working on this Qian!
> > 
> > It's really hard to tell what changes were made to the http command 
> > executor that are different from the command executor. I would suggest you 
> > to split this into multiple reviews to make reviewers' life easy.
> > 
> > 1) Add http command executor to make files. Just copy executor.cpp to 
> > http_command_executor.cpp without any changes.
> > 2) Update http_command_executor.cpp to use v1 API.
> > 3) Make changes to flags.cpp and slave.cpp.
> > 4) Update/parameterize tests (slave recovery tests?) to use http command 
> > executor.

Sure Vinod, I will discard this patch, and upload multiple sub-patches 
accordingly.


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43701/#review121177
---


On Feb. 20, 2016, 9:44 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43701/
> ---
> 
> (Updated Feb. 20, 2016, 9:44 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3558
> https://issues.apache.org/jira/browse/MESOS-3558
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a command executor based on the new V1 API.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md b04e873009dc783cc50eb02a459f0587d020ad23 
>   include/mesos/v1/mesos.proto e4224afe2245d649afa1a6c97bae26c215e6fada 
>   src/Makefile.am 27aec37524aa33211e0ca4594e127ebb4279e9b0 
>   src/launcher/http_executor.cpp PRE-CREATION 
>   src/slave/flags.hpp 54c1a69d8777f417cdd8f73ce638447d9951ab61 
>   src/slave/flags.cpp 855812e9f7cb4b96d4297f4bd5ac5de7f1d3c39a 
>   src/slave/slave.cpp f0be0d5bf4b853952caf06e2e262c2903d79ead3 
> 
> Diff: https://reviews.apache.org/r/43701/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 44163: Used temporary directory for fixture creating output files.

[Jan Schlicht]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44163/#review121224
---




src/tests/state_tests.cpp (line 404)


IMHO this comment is unnecessary.



src/tests/state_tests.cpp (line 409)


This is no longer needed, because `TemporaryDirectoryTest::TearDown` will 
remove the sandbox directory.



src/tests/state_tests.cpp (line 416)


Make this the last statement of the function, because `storage` and `state` 
rely on directories that will be deleted by this function.



src/tests/state_tests.cpp (line 420)


Same as above.


- Jan Schlicht


On Feb. 29, 2016, 11:53 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44163/
> ---
> 
> (Updated Feb. 29, 2016, 11:53 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Jan Schlicht, and Till Toenshoff.
> 
> 
> Bugs: MESOS-4806
> https://issues.apache.org/jira/browse/MESOS-4806
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Used temporary directory for fixture creating output files.
> 
> 
> Diffs
> -
> 
>   src/tests/state_tests.cpp 0b0bc9cb1c6e4906aa65c113207e5a2d8ebe61d9 
> 
> Diff: https://reviews.apache.org/r/44163/diff/
> 
> 
> Testing
> ---
> 
> make check (OS X, not optimized)
> 
> * before this patch running the test from a non-writable directory fails; 
> with this patch the test passes,
> * before this patch running gtest-parallel with filter `LevelDBState*` fails; 
> with the patch the test passes.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 43561: Improve Ranges parsing to handle single values.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43561/#review121229
---



Patch looks great!

Reviews applied: [43561]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 29, 2016, 9:57 a.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43561/
> ---
> 
> (Updated Feb. 29, 2016, 9:57 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-4627
> https://issues.apache.org/jira/browse/MESOS-4627
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Improve Ranges parsing to handle single values.
> 
> 
> Diffs
> -
> 
>   src/common/values.cpp 9f3c0b9930bd3dd9d84d97119419825862f531c3 
>   src/tests/resources_tests.cpp a545100522bf4b1f03e50656d461b3cda6b41e11 
>   src/tests/values_tests.cpp 929861549e3155c33966896f817f9bf9e6d14354 
> 
> Diff: https://reviews.apache.org/r/43561/diff/
> 
> 
> Testing
> ---
> 
> make
> make check GTEST_FILTER=~"*"
> ./src/mesos-test
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 44163: Used temporary directory for fixture creating output files.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44163/#review121237
---



Patch looks great!

Reviews applied: [44163]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 29, 2016, 11:37 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44163/
> ---
> 
> (Updated Feb. 29, 2016, 11:37 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Jan Schlicht, and Till Toenshoff.
> 
> 
> Bugs: MESOS-4806
> https://issues.apache.org/jira/browse/MESOS-4806
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Used temporary directory for fixture creating output files.
> 
> 
> Diffs
> -
> 
>   src/tests/state_tests.cpp 0b0bc9cb1c6e4906aa65c113207e5a2d8ebe61d9 
> 
> Diff: https://reviews.apache.org/r/44163/diff/
> 
> 
> Testing
> ---
> 
> make check (OS X, not optimized)
> 
> * before this patch running the test from a non-writable directory fails; 
> with this patch the test passes,
> * before this patch running gtest-parallel with filter `LevelDBState*` fails; 
> with the patch the test passes.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 43691: CMake:[2/2] Fixed http-parser library directory for Windows builds.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43691/#review121222
---


Ship it!




Ship It!

- Michael Park


On Feb. 18, 2016, 2:24 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43691/
> ---
> 
> (Updated Feb. 18, 2016, 2:24 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> CMake:[2/2] Fixed http-parser library directory for Windows builds.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 
> d36fa2fbe903fb278e6c00b47bfa4b81cf8f4673 
> 
> Diff: https://reviews.apache.org/r/43691/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 44163: Used temporary directory for fixture creating output files.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44163/
---

(Updated Feb. 29, 2016, 11:53 a.m.)


Review request for mesos, Benjamin Hindman, Jan Schlicht, and Till Toenshoff.


Bugs: MESOS-4806
https://issues.apache.org/jira/browse/MESOS-4806


Repository: mesos


Description
---

Used temporary directory for fixture creating output files.


Diffs
-

  src/tests/state_tests.cpp 0b0bc9cb1c6e4906aa65c113207e5a2d8ebe61d9 

Diff: https://reviews.apache.org/r/44163/diff/


Testing (updated)
---

make check (OS X, not optimized)

* before this patch running the test from a non-writable directory fails; with 
this patch the test passes,
* before this patch running gtest-parallel with filter `LevelDBState*` fails; 
with the patch the test passes.


Thanks,

Benjamin Bannier

Re: Review Request 44163: Used temporary directory for fixture creating output files.

[Jan Schlicht]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44163/#review121231
---


Ship it!




Ship It!

- Jan Schlicht


On Feb. 29, 2016, 12:37 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44163/
> ---
> 
> (Updated Feb. 29, 2016, 12:37 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Jan Schlicht, and Till Toenshoff.
> 
> 
> Bugs: MESOS-4806
> https://issues.apache.org/jira/browse/MESOS-4806
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Used temporary directory for fixture creating output files.
> 
> 
> Diffs
> -
> 
>   src/tests/state_tests.cpp 0b0bc9cb1c6e4906aa65c113207e5a2d8ebe61d9 
> 
> Diff: https://reviews.apache.org/r/44163/diff/
> 
> 
> Testing
> ---
> 
> make check (OS X, not optimized)
> 
> * before this patch running the test from a non-writable directory fails; 
> with this patch the test passes,
> * before this patch running gtest-parallel with filter `LevelDBState*` fails; 
> with the patch the test passes.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 42590: Removed reserved() API.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42590/#review121220
---



Patch looks great!

Reviews applied: [42590]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 29, 2016, 9:11 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42590/
> ---
> 
> (Updated Feb. 29, 2016, 9:11 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van 
> Remoortere, Joseph Wu, and Klaus Ma.
> 
> 
> Bugs: MESOS-4447
> https://issues.apache.org/jira/browse/MESOS-4447
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed reserved() API.
> 
> 
> Diffs
> -
> 
>   include/mesos/resources.hpp fe8a5745ea7d4943c47ac22c73db70488c6dfa9f 
>   include/mesos/v1/resources.hpp c27927e4f0d7f45e69fe3312b2423afb64c5c51e 
>   src/common/resources.cpp 4fa1e78606485d6657d3776e28b78a43cc6449d2 
>   src/master/http.cpp 5e9e28e904ba0045ee27eb828f47231632a91d74 
>   src/tests/resources_tests.cpp a545100522bf4b1f03e50656d461b3cda6b41e11 
>   src/v1/resources.cpp bca523159577994d5890f832e4f61101b5dbf3bc 
> 
> Diff: https://reviews.apache.org/r/42590/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> ./bin/mesos-tests.sh  --gtest_filter="ResourcesTest.*"
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 44163: Used temporary directory for fixture creating output files.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44163/
---

(Updated Feb. 29, 2016, 12:37 p.m.)


Review request for mesos, Benjamin Hindman, Jan Schlicht, and Till Toenshoff.


Changes
---

Addressed comments from Jan.


Bugs: MESOS-4806
https://issues.apache.org/jira/browse/MESOS-4806


Repository: mesos


Description
---

Used temporary directory for fixture creating output files.


Diffs (updated)
-

  src/tests/state_tests.cpp 0b0bc9cb1c6e4906aa65c113207e5a2d8ebe61d9 

Diff: https://reviews.apache.org/r/44163/diff/


Testing
---

make check (OS X, not optimized)

* before this patch running the test from a non-writable directory fails; with 
this patch the test passes,
* before this patch running gtest-parallel with filter `LevelDBState*` fails; 
with the patch the test passes.


Thanks,

Benjamin Bannier

Re: Review Request 44004: Add 'name' field into NetworkInfo.

[Qian Zhang]

> On Feb. 25, 2016, 11:32 p.m., Avinash sridharan wrote:
> > include/mesos/v1/mesos.proto, line 1573
> > 
> >
> > Ditto.

Agree.


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44004/#review120710
---


On Feb. 26, 2016, 10:01 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44004/
> ---
> 
> (Updated Feb. 26, 2016, 10:01 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.
> 
> 
> Bugs: MESOS-4758
> https://issues.apache.org/jira/browse/MESOS-4758
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add 'name' field into NetworkInfo.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 33f6b0838360b61db70a247e5d6dfb16af15aa06 
>   include/mesos/v1/mesos.proto 1b0e709e76f3f6b44ab0434c649c064e8866c8a1 
> 
> Diff: https://reviews.apache.org/r/44004/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 43882: Added allocation metrics for allocation time.

[Alexander Rojas]

> On Feb. 27, 2016, 2:11 a.m., Alexander Rojas wrote:
> > src/master/allocator/mesos/hierarchical.cpp, line 1220
> > 
> >
> > Add a `CHECK_NOT_NULL`
> 
> Benjamin Bannier wrote:
> `timer` is initialized from a ref in the line above, so I think it can 
> never be null by construction.

you are right. My bad.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43882/#review121029
---


On Feb. 28, 2016, 10:28 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43882/
> ---
> 
> (Updated Feb. 28, 2016, 10:28 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Ben Mahler.
> 
> 
> Bugs: MESOS-4721
> https://issues.apache.org/jira/browse/MESOS-4721
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added allocation metrics for allocation time.
> 
> 
> Diffs
> -
> 
>   docs/monitoring.md 827f7073204fcf8575ca980a5571c8be4f5e4110 
>   src/master/allocator/mesos/hierarchical.hpp 
> 3043888630b066505410d3b32c5b3f813cc458c1 
>   src/master/allocator/mesos/hierarchical.cpp 
> 24fa50f62dec10ed43089297473cc386d6ba2f78 
>   src/tests/hierarchical_allocator_tests.cpp 
> 5f771f02db9bd098f3cd36730cd84bf2f5e87a33 
> 
> Diff: https://reviews.apache.org/r/43882/diff/
> 
> 
> Testing
> ---
> 
> make check (OS X)
> 
> I confirmed that this does not lead to general performance regressions in the 
> allocator; this is partially expected since the added code only inserts 
> metrics in the allocator while the actual work is perform asynchronously. 
> These tests where performed with 
> `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build 
> under OS X using clang(trunk) as compiler.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 44073: Disabled metrics endpoint rate limiting in mesos tests.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44073/#review121252
---


Ship it!




Ship It!

- Alexander Rojas


On Feb. 28, 2016, 10:28 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44073/
> ---
> 
> (Updated Feb. 28, 2016, 10:28 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-4783
> https://issues.apache.org/jira/browse/MESOS-4783
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Disabled metrics endpoint rate limiting in mesos tests.
> 
> 
> Diffs
> -
> 
>   src/tests/main.cpp 942488e57419ace8b7a821f53024aced0f43c7d9 
> 
> Diff: https://reviews.apache.org/r/44073/diff/
> 
> 
> Testing
> ---
> 
> make distcheck (ubuntu 12 & 14), make check (OS X)
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 43999: Use relative path to create libraries symbolic link.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43999/#review121264
---


Ship it!




This looks fine to me. I think it would help future generations to add a 
comment about where the relative paths actually point to and constructing this 
path is safe.

- James Peach


On Feb. 27, 2016, 1:55 a.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43999/
> ---
> 
> (Updated Feb. 27, 2016, 1:55 a.m.)
> 
> 
> Review request for mesos, James Peach and Kapil Arya.
> 
> 
> Bugs: MESOS-4774
> https://issues.apache.org/jira/browse/MESOS-4774
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Use relative path to create libraries symbolic link.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 2a26261b513bb7c03437ed8e850c3b36b93d82f5 
> 
> Diff: https://reviews.apache.org/r/43999/diff/
> 
> 
> Testing
> ---
> 
> After make install, the library links will be relative path.
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

[Alexander Rojas]

> On Feb. 25, 2016, 5:30 p.m., Klaus Ma wrote:
> > src/master/allocator/mesos/hierarchical.hpp, line 376
> > 
> >
> > We also need to remove counter in `removeFramework`; or we'll see 
> > metrics of removed framework.
> 
> Benjamin Bannier wrote:
> Right now this is intended behavior, any preference @bmahler?
> 
> Klaus Ma wrote:
> For the cluster running for a long time, there'll be several un-available 
> metrics after doing operation.
> Just go through the other patches of metrics, similar comments on quota 
> and filters.

I think I will join Klaus in this one. It makes no sense to keep gone 
frameworks appearing in the metrics for long times. But overall, I'm not even 
sure we need a metric at all.

Another solution would be to launch a timer when we remove the framework so it 
will show up for a time and then we remove it.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43881/#review120716
---


On Feb. 28, 2016, 10:28 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43881/
> ---
> 
> (Updated Feb. 28, 2016, 10:28 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Ben Mahler.
> 
> 
> Bugs: MESOS-4719
> https://issues.apache.org/jira/browse/MESOS-4719
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added allocator metric for the number of allocations to a framework.
> 
> 
> Diffs
> -
> 
>   docs/monitoring.md 827f7073204fcf8575ca980a5571c8be4f5e4110 
>   src/master/allocator/mesos/hierarchical.hpp 
> 3043888630b066505410d3b32c5b3f813cc458c1 
>   src/master/allocator/mesos/hierarchical.cpp 
> 24fa50f62dec10ed43089297473cc386d6ba2f78 
>   src/tests/hierarchical_allocator_tests.cpp 
> 5f771f02db9bd098f3cd36730cd84bf2f5e87a33 
> 
> Diff: https://reviews.apache.org/r/43881/diff/
> 
> 
> Testing
> ---
> 
> make check (OS X)
> 
> I confirmed that this does not lead to general performance regressions in the 
> allocator; this is partially expected since the added code only inserts 
> metrics in the allocator while the actual work is perform asynchronously. 
> These tests where performed with 
> `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build 
> under OS X using clang(trunk) as compiler.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43881/#review121254
---




src/tests/hierarchical_allocator_tests.cpp (lines 2498 - 2502)


This is my fault, I don't know how I missed this, but here you can even 
reused the last value `metricKey` here.


- Alexander Rojas


On Feb. 28, 2016, 10:28 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43881/
> ---
> 
> (Updated Feb. 28, 2016, 10:28 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Ben Mahler.
> 
> 
> Bugs: MESOS-4719
> https://issues.apache.org/jira/browse/MESOS-4719
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added allocator metric for the number of allocations to a framework.
> 
> 
> Diffs
> -
> 
>   docs/monitoring.md 827f7073204fcf8575ca980a5571c8be4f5e4110 
>   src/master/allocator/mesos/hierarchical.hpp 
> 3043888630b066505410d3b32c5b3f813cc458c1 
>   src/master/allocator/mesos/hierarchical.cpp 
> 24fa50f62dec10ed43089297473cc386d6ba2f78 
>   src/tests/hierarchical_allocator_tests.cpp 
> 5f771f02db9bd098f3cd36730cd84bf2f5e87a33 
> 
> Diff: https://reviews.apache.org/r/43881/diff/
> 
> 
> Testing
> ---
> 
> make check (OS X)
> 
> I confirmed that this does not lead to general performance regressions in the 
> allocator; this is partially expected since the added code only inserts 
> metrics in the allocator while the actual work is perform asynchronously. 
> These tests where performed with 
> `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build 
> under OS X using clang(trunk) as compiler.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Review Request 44164: Improved debug ability for docker puller.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44164/
---

Review request for mesos, Gilbert Song and Jie Yu.


Bugs: MESOS-4796
https://issues.apache.org/jira/browse/MESOS-4796


Repository: mesos


Description
---

Improved debug ability for docker puller.


Diffs
-

  src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp 
ea4c2fff14a271e1e9c514d151407a5d8785e2a4 
  src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp 
f391a943551792c8edf5759d9491fda33116f2b4 
  src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
3fd58f61a6daa3e03bd79931947084c50b1b80d4 

Diff: https://reviews.apache.org/r/44164/diff/


Testing
---

make
make check

Tested with both local puller and registery puller, all related logs can be 
logged.


Thanks,

Guangya Liu

Re: Review Request 44164: Improved debug ability for docker puller.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44164/#review121257
---



Patch looks great!

Reviews applied: [44164]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 29, 2016, 3:55 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44164/
> ---
> 
> (Updated Feb. 29, 2016, 3:55 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-4796
> https://issues.apache.org/jira/browse/MESOS-4796
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Improved debug ability for docker puller.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp 
> ea4c2fff14a271e1e9c514d151407a5d8785e2a4 
>   src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp 
> f391a943551792c8edf5759d9491fda33116f2b4 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
> 3fd58f61a6daa3e03bd79931947084c50b1b80d4 
> 
> Diff: https://reviews.apache.org/r/44164/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> Tested with both local puller and registery puller, all related logs can be 
> logged.
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 44004: Add 'name' field into NetworkInfo.

[Qian Zhang]

> On Feb. 26, 2016, 9 a.m., Avinash sridharan wrote:
> > include/mesos/mesos.proto, line 1577
> > 
> >
> > In order to expose this field in state.json, I think you need to add 
> > the filed to the corresponding `model` function in src/common/http.cpp as 
> > well. 
> > 
> > We won't need this once we move to the new JSONIFY api, but I think we 
> > would need it in the immediate future.

Agree.


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44004/#review120810
---


On Feb. 26, 2016, 10:01 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44004/
> ---
> 
> (Updated Feb. 26, 2016, 10:01 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.
> 
> 
> Bugs: MESOS-4758
> https://issues.apache.org/jira/browse/MESOS-4758
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add 'name' field into NetworkInfo.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 33f6b0838360b61db70a247e5d6dfb16af15aa06 
>   include/mesos/v1/mesos.proto 1b0e709e76f3f6b44ab0434c649c064e8866c8a1 
> 
> Diff: https://reviews.apache.org/r/44004/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 44073: Disabled metrics endpoint rate limiting in mesos tests.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44073/#review121241
---


Ship it!




Ship It!

- Alexander Rukletsov


On Feb. 28, 2016, 9:28 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44073/
> ---
> 
> (Updated Feb. 28, 2016, 9:28 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-4783
> https://issues.apache.org/jira/browse/MESOS-4783
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Disabled metrics endpoint rate limiting in mesos tests.
> 
> 
> Diffs
> -
> 
>   src/tests/main.cpp 942488e57419ace8b7a821f53024aced0f43c7d9 
> 
> Diff: https://reviews.apache.org/r/44073/diff/
> 
> 
> Testing
> ---
> 
> make distcheck (ubuntu 12 & 14), make check (OS X)
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 44004: Add 'name' field into NetworkInfo.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44004/#review121247
---



Patch looks great!

Reviews applied: [44004]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 29, 2016, 2:04 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44004/
> ---
> 
> (Updated Feb. 29, 2016, 2:04 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.
> 
> 
> Bugs: MESOS-4758
> https://issues.apache.org/jira/browse/MESOS-4758
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add 'name' field into NetworkInfo.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 3d22ec32655dca741169e1f0e382303e061c38b7 
>   include/mesos/v1/mesos.proto 31960a52061f70d80528fb8326522ae1d6f75b2c 
>   src/common/http.cpp be8538fc222d83d802611392f6c94e80a1e56fa8 
> 
> Diff: https://reviews.apache.org/r/44004/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 44004: Add 'name' field into NetworkInfo.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44004/
---

(Updated Feb. 29, 2016, 10:04 p.m.)


Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.


Changes
---

Addressed Avinash's comments.


Bugs: MESOS-4758
https://issues.apache.org/jira/browse/MESOS-4758


Repository: mesos


Description
---

Add 'name' field into NetworkInfo.


Diffs (updated)
-

  include/mesos/mesos.proto 3d22ec32655dca741169e1f0e382303e061c38b7 
  include/mesos/v1/mesos.proto 31960a52061f70d80528fb8326522ae1d6f75b2c 
  src/common/http.cpp be8538fc222d83d802611392f6c94e80a1e56fa8 

Diff: https://reviews.apache.org/r/44004/diff/


Testing
---

make check


Thanks,

Qian Zhang

Re: Review Request 43694: Windows:[3/4] Transitioned to static-everything builds on Windows.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43694/
---

(Updated Feb. 29, 2016, 6:17 p.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Bugs: MESOS-3525
https://issues.apache.org/jira/browse/MESOS-3525


Repository: mesos


Description
---

Windows:[3/4] Transitioned to static-everything builds on Windows.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/CMakeLists.txt 
9b61376ea6aad304607c20c9823d9ef19013eca0 
  3rdparty/libprocess/3rdparty/http-parser/CMakeLists.txt.template 
bf2aa384e0a3df5a08f2aeb2a267eddd83b8fe01 
  3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 
d36fa2fbe903fb278e6c00b47bfa4b81cf8f4673 
  3rdparty/libprocess/cmake/ProcessConfigure.cmake 
2a37fdb6501aaf7baac2ada0a714bbe67e7c5aca 
  3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 
3a2e0999722007475c023ade75719093e35cfc80 
  3rdparty/libprocess/src/CMakeLists.txt 
12dfaf61b801372b6ec70c535080fde350866fb8 

Diff: https://reviews.apache.org/r/43694/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 43698: CMake:[2/3] Use new Stout config script in libprocess 3rdparty build.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43698/
---

(Updated Feb. 29, 2016, 6:15 p.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Bugs: MESOS-4703
https://issues.apache.org/jira/browse/MESOS-4703


Repository: mesos


Description
---

CMake:[2/3] Use new Stout config script in libprocess 3rdparty build.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/CMakeLists.txt 
9b61376ea6aad304607c20c9823d9ef19013eca0 
  3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 
d36fa2fbe903fb278e6c00b47bfa4b81cf8f4673 
  3rdparty/libprocess/cmake/ProcessConfigure.cmake 
2a37fdb6501aaf7baac2ada0a714bbe67e7c5aca 

Diff: https://reviews.apache.org/r/43698/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 43698: CMake:[2/3] Use new Stout config script in libprocess 3rdparty build.

[Alex Clemmer]

> On Feb. 18, 2016, 6:35 p.m., Yi Sun wrote:
> > 3rdparty/libprocess/cmake/ProcessConfigure.cmake, line 54
> > 
> >
> > Does STOUT_DEPENDENCIES already contain PICOJSON_TARGET?

GOod catch, thanks Yi. :)


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43698/#review119659
---


On Feb. 29, 2016, 6:15 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43698/
> ---
> 
> (Updated Feb. 29, 2016, 6:15 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-4703
> https://issues.apache.org/jira/browse/MESOS-4703
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> CMake:[2/3] Use new Stout config script in libprocess 3rdparty build.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/CMakeLists.txt 
> 9b61376ea6aad304607c20c9823d9ef19013eca0 
>   3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 
> d36fa2fbe903fb278e6c00b47bfa4b81cf8f4673 
>   3rdparty/libprocess/cmake/ProcessConfigure.cmake 
> 2a37fdb6501aaf7baac2ada0a714bbe67e7c5aca 
> 
> Diff: https://reviews.apache.org/r/43698/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 43692: CMake:[1/4] Transitioned to 64-bit build of ZK on Windows.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43692/
---

(Updated Feb. 29, 2016, 6:42 p.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Bugs: MESOS-3525
https://issues.apache.org/jira/browse/MESOS-3525


Repository: mesos


Description
---

CMake:[1/4] Transitioned to 64-bit build of ZK on Windows.


Diffs (updated)
-

  3rdparty/CMakeLists.txt 3253da73aa517a335be94148d567510147dae08d 
  3rdparty/cmake/Mesos3rdpartyConfigure.cmake 
0c80fb8d799ea1252492cd98ac0780f1228aadcd 
  3rdparty/zookeeper-06d3f3f.patch 8f8f72cb712c4bca328bf865ab082926106fbd94 
  cmake/MesosConfigure.cmake 9a4fdb57e1281d9ec421e639819de5786c11744a 
  src/CMakeLists.txt 5cf0ec8c475839ad8717192a37f01546cbcccd7a 

Diff: https://reviews.apache.org/r/43692/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 44153: Obtained uid/gids before changing filesystem root.

[Cong Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44153/#review121289
---



1. Looks like after this patch all os::su() callers are gone, can we remove it?
2. How about making getuid()+getgid()+getgrouplist() a helper function to 
reduce code duplication? Same for setgroups()+setuid().

- Cong Wang


On Feb. 29, 2016, 12:09 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44153/
> ---
> 
> (Updated Feb. 29, 2016, 12:09 a.m.)
> 
> 
> Review request for mesos, Ian Downes and Timothy Chen.
> 
> 
> Bugs: MESOS-4757
> https://issues.apache.org/jira/browse/MESOS-4757
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Currently, we call os::su(user) after pivot_root. This is problematic
> because /etc/passwd and /etc/group might be missing in container's root
> filesystem. We should instead, get the uid/gids before pivot_root, and
> call setuid/setgroups after pivot_root.
> 
> 
> Diffs
> -
> 
>   src/launcher/executor.cpp 4149f084b0b234fb995df04e9d1ca704feec082e 
>   src/slave/containerizer/mesos/launch.cpp 
> 6b3bf163e2a577e6318a4a62f96d6bfd98ef9ae9 
> 
> Diff: https://reviews.apache.org/r/44153/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 43884: Added allocator metrics for used quotas.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43884/#review121310
---



Bad review!

Reviews applied: [43884, 43883, 43882, 43881, 43880, 43879]

Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing 
list.

- Mesos ReviewBot


On Feb. 29, 2016, 7:59 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43884/
> ---
> 
> (Updated Feb. 29, 2016, 7:59 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Ben Mahler.
> 
> 
> Bugs: MESOS-4723
> https://issues.apache.org/jira/browse/MESOS-4723
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added allocator metrics for used quotas.
> 
> 
> Diffs
> -
> 
>   docs/monitoring.md 827f7073204fcf8575ca980a5571c8be4f5e4110 
>   src/master/allocator/mesos/hierarchical.hpp 
> 3043888630b066505410d3b32c5b3f813cc458c1 
>   src/master/allocator/mesos/hierarchical.cpp 
> 24fa50f62dec10ed43089297473cc386d6ba2f78 
>   src/tests/hierarchical_allocator_tests.cpp 
> 5f771f02db9bd098f3cd36730cd84bf2f5e87a33 
> 
> Diff: https://reviews.apache.org/r/43884/diff/
> 
> 
> Testing
> ---
> 
> make check (OS X)
> 
> I confirmed that this does not lead to general performance regressions in the 
> allocator; this is partially expected since the added code only inserts 
> metrics in the allocator while the actual work is perform asynchronously. 
> These tests where performed with 
> `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build 
> under OS X using clang(trunk) as compiler.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 44004: Add 'name' field into NetworkInfo.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44004/#review121315
---




include/mesos/mesos.proto (line 1585)


s/, E.g., for MesosContainerizer/. For ,e.g., in case of the 
`MesosContainerizer`/



include/mesos/v1/mesos.proto (line 1582)


Ditto.


- Avinash sridharan


On Feb. 29, 2016, 2:04 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44004/
> ---
> 
> (Updated Feb. 29, 2016, 2:04 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.
> 
> 
> Bugs: MESOS-4758
> https://issues.apache.org/jira/browse/MESOS-4758
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add 'name' field into NetworkInfo.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 3d22ec32655dca741169e1f0e382303e061c38b7 
>   include/mesos/v1/mesos.proto 31960a52061f70d80528fb8326522ae1d6f75b2c 
>   src/common/http.cpp be8538fc222d83d802611392f6c94e80a1e56fa8 
> 
> Diff: https://reviews.apache.org/r/44004/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 44004: Add 'name' field into NetworkInfo.

[Avinash sridharan]

> On Feb. 29, 2016, 8:16 p.m., Avinash sridharan wrote:
> > Ship It!

Fix it, then ship it !!


- Avinash


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44004/#review121313
---


On Feb. 29, 2016, 2:04 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44004/
> ---
> 
> (Updated Feb. 29, 2016, 2:04 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.
> 
> 
> Bugs: MESOS-4758
> https://issues.apache.org/jira/browse/MESOS-4758
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add 'name' field into NetworkInfo.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 3d22ec32655dca741169e1f0e382303e061c38b7 
>   include/mesos/v1/mesos.proto 31960a52061f70d80528fb8326522ae1d6f75b2c 
>   src/common/http.cpp be8538fc222d83d802611392f6c94e80a1e56fa8 
> 
> Diff: https://reviews.apache.org/r/44004/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 44110: Updated flag examples to refer to /metrics/snapshot instead of stats.json.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44110/
---

(Updated Feb. 29, 2016, 7:43 p.m.)


Review request for mesos, Alexander Rojas and Vinod Kone.


Summary (updated)
-

Updated flag examples to refer to /metrics/snapshot instead of stats.json.


Bugs: MESOS-4509
https://issues.apache.org/jira/browse/MESOS-4509


Repository: mesos


Description (updated)
---

Updated flag examples to refer to /snapshot instead of deprecated stats.json.


Diffs
-

  docs/configuration.md 2353e78a80548b63f871c52e840ffe2fe869f4d7 
  src/master/flags.cpp 60e085bd5c6689adb625a736edc76e814860ea7d 
  src/slave/flags.cpp 1c6a87b670efde2deab4d6e3f24fd6eb3704a47d 

Diff: https://reviews.apache.org/r/44110/diff/


Testing
---

make test + manually checked the flags example.


Thanks,

Joerg Schad

Re: Review Request 43884: Added allocator metrics for used quotas.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43884/
---

(Updated Feb. 29, 2016, 8:59 p.m.)


Review request for mesos, Alexander Rukletsov and Ben Mahler.


Changes
---

Rebased.


Bugs: MESOS-4723
https://issues.apache.org/jira/browse/MESOS-4723


Repository: mesos


Description
---

Added allocator metrics for used quotas.


Diffs (updated)
-

  docs/monitoring.md 827f7073204fcf8575ca980a5571c8be4f5e4110 
  src/master/allocator/mesos/hierarchical.hpp 
3043888630b066505410d3b32c5b3f813cc458c1 
  src/master/allocator/mesos/hierarchical.cpp 
24fa50f62dec10ed43089297473cc386d6ba2f78 
  src/tests/hierarchical_allocator_tests.cpp 
5f771f02db9bd098f3cd36730cd84bf2f5e87a33 

Diff: https://reviews.apache.org/r/43884/diff/


Testing
---

make check (OS X)

I confirmed that this does not lead to general performance regressions in the 
allocator; this is partially expected since the added code only inserts metrics 
in the allocator while the actual work is perform asynchronously. These tests 
where performed with `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an 
optimized build under OS X using clang(trunk) as compiler.


Thanks,

Benjamin Bannier

Re: Review Request 43882: Added allocation metrics for allocation time.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43882/
---

(Updated Feb. 29, 2016, 8:59 p.m.)


Review request for mesos, Alexander Rukletsov and Ben Mahler.


Changes
---

Rebased.


Bugs: MESOS-4721
https://issues.apache.org/jira/browse/MESOS-4721


Repository: mesos


Description
---

Added allocation metrics for allocation time.


Diffs (updated)
-

  docs/monitoring.md 827f7073204fcf8575ca980a5571c8be4f5e4110 
  src/master/allocator/mesos/hierarchical.hpp 
3043888630b066505410d3b32c5b3f813cc458c1 
  src/master/allocator/mesos/hierarchical.cpp 
24fa50f62dec10ed43089297473cc386d6ba2f78 
  src/tests/hierarchical_allocator_tests.cpp 
5f771f02db9bd098f3cd36730cd84bf2f5e87a33 

Diff: https://reviews.apache.org/r/43882/diff/


Testing
---

make check (OS X)

I confirmed that this does not lead to general performance regressions in the 
allocator; this is partially expected since the added code only inserts metrics 
in the allocator while the actual work is perform asynchronously. These tests 
where performed with `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an 
optimized build under OS X using clang(trunk) as compiler.


Thanks,

Benjamin Bannier

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43881/
---

(Updated Feb. 29, 2016, 8:59 p.m.)


Review request for mesos, Alexander Rukletsov and Ben Mahler.


Changes
---

Comment from Alexander.


Bugs: MESOS-4719
https://issues.apache.org/jira/browse/MESOS-4719


Repository: mesos


Description
---

Added allocator metric for the number of allocations to a framework.


Diffs (updated)
-

  docs/monitoring.md 827f7073204fcf8575ca980a5571c8be4f5e4110 
  src/master/allocator/mesos/hierarchical.hpp 
3043888630b066505410d3b32c5b3f813cc458c1 
  src/master/allocator/mesos/hierarchical.cpp 
24fa50f62dec10ed43089297473cc386d6ba2f78 
  src/tests/hierarchical_allocator_tests.cpp 
5f771f02db9bd098f3cd36730cd84bf2f5e87a33 

Diff: https://reviews.apache.org/r/43881/diff/


Testing
---

make check (OS X)

I confirmed that this does not lead to general performance regressions in the 
allocator; this is partially expected since the added code only inserts metrics 
in the allocator while the actual work is perform asynchronously. These tests 
where performed with `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an 
optimized build under OS X using clang(trunk) as compiler.


Thanks,

Benjamin Bannier

Re: Review Request 43883: Added allocator metrics for number of offer filters per framework.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43883/
---

(Updated Feb. 29, 2016, 8:59 p.m.)


Review request for mesos, Alexander Rukletsov and Ben Mahler.


Changes
---

Rebased.


Bugs: MESOS-4722
https://issues.apache.org/jira/browse/MESOS-4722


Repository: mesos


Description
---

Added allocator metrics for number of offer filters per framework.


Diffs (updated)
-

  docs/monitoring.md 827f7073204fcf8575ca980a5571c8be4f5e4110 
  src/master/allocator/mesos/hierarchical.hpp 
3043888630b066505410d3b32c5b3f813cc458c1 
  src/master/allocator/mesos/hierarchical.cpp 
24fa50f62dec10ed43089297473cc386d6ba2f78 
  src/tests/hierarchical_allocator_tests.cpp 
5f771f02db9bd098f3cd36730cd84bf2f5e87a33 

Diff: https://reviews.apache.org/r/43883/diff/


Testing
---

make check (OS X)

I confirmed that this does not lead to general performance regressions in the 
allocator; this is partially expected since the added code only inserts metrics 
in the allocator while the actual work is perform asynchronously. These tests 
where performed with `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an 
optimized build under OS X using clang(trunk) as compiler.


Thanks,

Benjamin Bannier

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

[Benjamin Bannier]

> On Feb. 29, 2016, 6:08 p.m., Alexander Rojas wrote:
> > src/tests/hierarchical_allocator_tests.cpp, lines 2498-2502
> > 
> >
> > This is my fault, I don't know how I missed this, but here you can even 
> > reused the last value `metricKey` here.

Missed that one as well. I choose to recalc `metricKey` here to keep the value 
locally visible.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43881/#review121254
---


On Feb. 29, 2016, 8:59 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43881/
> ---
> 
> (Updated Feb. 29, 2016, 8:59 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Ben Mahler.
> 
> 
> Bugs: MESOS-4719
> https://issues.apache.org/jira/browse/MESOS-4719
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added allocator metric for the number of allocations to a framework.
> 
> 
> Diffs
> -
> 
>   docs/monitoring.md 827f7073204fcf8575ca980a5571c8be4f5e4110 
>   src/master/allocator/mesos/hierarchical.hpp 
> 3043888630b066505410d3b32c5b3f813cc458c1 
>   src/master/allocator/mesos/hierarchical.cpp 
> 24fa50f62dec10ed43089297473cc386d6ba2f78 
>   src/tests/hierarchical_allocator_tests.cpp 
> 5f771f02db9bd098f3cd36730cd84bf2f5e87a33 
> 
> Diff: https://reviews.apache.org/r/43881/diff/
> 
> 
> Testing
> ---
> 
> make check (OS X)
> 
> I confirmed that this does not lead to general performance regressions in the 
> allocator; this is partially expected since the added code only inserts 
> metrics in the allocator while the actual work is perform asynchronously. 
> These tests where performed with 
> `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build 
> under OS X using clang(trunk) as compiler.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 44004: Add 'name' field into NetworkInfo.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44004/#review121313
---


Ship it!




Ship It!

- Avinash sridharan


On Feb. 29, 2016, 2:04 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44004/
> ---
> 
> (Updated Feb. 29, 2016, 2:04 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.
> 
> 
> Bugs: MESOS-4758
> https://issues.apache.org/jira/browse/MESOS-4758
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add 'name' field into NetworkInfo.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 3d22ec32655dca741169e1f0e382303e061c38b7 
>   include/mesos/v1/mesos.proto 31960a52061f70d80528fb8326522ae1d6f75b2c 
>   src/common/http.cpp be8538fc222d83d802611392f6c94e80a1e56fa8 
> 
> Diff: https://reviews.apache.org/r/44004/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 44151: Added stout functions to get and set supplementary groud ids.

[Cong Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44151/#review121280
---




3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp (line 322)


You can construct vector with array, no need to bother a loop.



3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp (line 335)


Use vector::data()?


- Cong Wang


On Feb. 29, 2016, 12:08 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44151/
> ---
> 
> (Updated Feb. 29, 2016, 12:08 a.m.)
> 
> 
> Review request for mesos, Ian Downes and Timothy Chen.
> 
> 
> Bugs: MESOS-4757
> https://issues.apache.org/jira/browse/MESOS-4757
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added stout functions to get and set supplementary groud ids.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
> 84a2a021859d4e5c8547ad2a509eebda428a8255 
> 
> Diff: https://reviews.apache.org/r/44151/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 43915: Introduced the `--cgroups_net_cls_secondary_handles` flag in the agent.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43915/
---

(Updated Feb. 29, 2016, 10:16 p.m.)


Review request for mesos and Jie Yu.


Changes
---

Changed patch dependency.


Bugs: MESOS-4700
https://issues.apache.org/jira/browse/MESOS-4700


Repository: mesos


Description
---

Introduced the `--cgroups_net_cls_secondary_handles` flag in the agent.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp 
f05cd55a9e080f44566ec7dcef22f11950496d6f 
  src/slave/flags.hpp 54c1a69d8777f417cdd8f73ce638447d9951ab61 
  src/slave/flags.cpp 855812e9f7cb4b96d4297f4bd5ac5de7f1d3c39a 

Diff: https://reviews.apache.org/r/43915/diff/


Testing
---

make and make check


Thanks,

Avinash sridharan

Review Request 44182: Added the flag --cgroups_net_cls_secondary_handles to documentation.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44182/
---

Review request for mesos and Jie Yu.


Bugs: MESOS-4700
https://issues.apache.org/jira/browse/MESOS-4700


Repository: mesos


Description
---

Added the flag --cgroups_net_cls_secondary_handles to documentation.


Diffs
-

  docs/configuration.md b04e873009dc783cc50eb02a459f0587d020ad23 

Diff: https://reviews.apache.org/r/44182/diff/


Testing
---

Ran the website in docker and verified the changes.


Thanks,

Avinash sridharan

Re: Review Request 43916: Modified testcase to test `--cgroups_net_cls_secondary_handles` flag.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43916/
---

(Updated Feb. 29, 2016, 10:16 p.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-4700
https://issues.apache.org/jira/browse/MESOS-4700


Repository: mesos


Description
---

Modified testcase to test `--cgroups_net_cls_secondary_handles` flag.


Diffs (updated)
-

  src/tests/containerizer/isolator_tests.cpp 
653b037c489072f43e53dec01a811a9249dcd660 

Diff: https://reviews.apache.org/r/43916/diff/


Testing
---

make check and sudo make check (for NetClsIsolator)


Thanks,

Avinash sridharan

Re: Review Request 43630: Especially updated scheduler tests to use the updated MesosTest helpers.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43630/
---

(Updated Feb. 29, 2016, 1:32 p.m.)


Review request for mesos, Bernd Mathiske and Artem Harutyunyan.


Changes
---

Rebase and update all tests (all of them conflicted >.<).


Bugs: MESOS-4633 and MESOS-4634
https://issues.apache.org/jira/browse/MESOS-4633
https://issues.apache.org/jira/browse/MESOS-4634


Repository: mesos


Description
---

Continuation of https://reviews.apache.org/r/43615/ with re-ordering of some 
local variables due to the order of destruction.


Diffs (updated)
-

  src/tests/master_maintenance_tests.cpp 
3faa8136cf57276295553910319480028f433e4c 
  src/tests/scheduler_tests.cpp 70c5b218aa231b21277580567d92f31c16a95efb 

Diff: https://reviews.apache.org/r/43630/diff/


Testing
---

Tests are run at the end of this review chain.


Thanks,

Joseph Wu

Re: Review Request 44004: Add 'name' field into NetworkInfo.

[Avinash sridharan]

> On Feb. 29, 2016, 8:19 p.m., Avinash sridharan wrote:
> > include/mesos/mesos.proto, line 1585
> > 
> >
> > s/, E.g., for MesosContainerizer/. For ,e.g., in case of the 
> > `MesosContainerizer`/

Actually, made a mistake, the right sentence would be.
s/, E.g., for MesosContainerizer/. E.g., in case of the `MesosContainerizer`/

E.g. is short for exempl? gr?ti? or "for example". So this substitution makes 
more sense.


- Avinash


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44004/#review121315
---


On Feb. 29, 2016, 2:04 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44004/
> ---
> 
> (Updated Feb. 29, 2016, 2:04 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.
> 
> 
> Bugs: MESOS-4758
> https://issues.apache.org/jira/browse/MESOS-4758
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add 'name' field into NetworkInfo.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 3d22ec32655dca741169e1f0e382303e061c38b7 
>   include/mesos/v1/mesos.proto 31960a52061f70d80528fb8326522ae1d6f75b2c 
>   src/common/http.cpp be8538fc222d83d802611392f6c94e80a1e56fa8 
> 
> Diff: https://reviews.apache.org/r/44004/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 43629: Especially updated tests to use the updated MesosTest helpers.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43629/
---

(Updated Feb. 29, 2016, 1:32 p.m.)


Review request for mesos, Bernd Mathiske and Artem Harutyunyan.


Changes
---

Rebase and update conflict on the FetcherCacheTest setup.


Bugs: MESOS-4633 and MESOS-4634
https://issues.apache.org/jira/browse/MESOS-4633
https://issues.apache.org/jira/browse/MESOS-4634


Repository: mesos


Description
---

Continuation of https://reviews.apache.org/r/43615/ with a slightly different 
pattern.


Diffs (updated)
-

  src/tests/fetcher_cache_tests.cpp f9c48f5d938c2601cb8f826029d6969d676ab98e 
  src/tests/resource_offers_tests.cpp 0bad45dd1dabecc88fef1ab46e8ea26718070b33 
  src/tests/slave_recovery_tests.cpp bd7b94f3f1fac6705e5bf14c6f6103b540cde56c 

Diff: https://reviews.apache.org/r/43629/diff/


Testing
---

Tests are run at the end of this review chain.


Thanks,

Joseph Wu

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43615/
---

(Updated Feb. 29, 2016, 1:55 p.m.)


Review request for mesos, Bernd Mathiske and Artem Harutyunyan.


Changes
---

Rebase and update:

* TeardownTests
* A few new PersistentVolumeEndpointsTests
* A few new ReservationEndpointsTests
* A new ProvisionerDockerRegistryPullerTest


Bugs: MESOS-4633 and MESOS-4634
https://issues.apache.org/jira/browse/MESOS-4633
https://issues.apache.org/jira/browse/MESOS-4634


Repository: mesos


Description
---

Includes the following changes:

* Added the `` header where appropriate.
* Added the namespace `using process::Owned;` where appropriate.
* Generally replaced `Try` with `Owned`.  And 
`Try` with `Owned`.
* Added the (now required) `MasterDetector` argument to all slaves.  Before, 
this was fetched from the first master in `Cluster`.
* Removed `Shutdown();` from all tests.
* Replaced `Stop(...)` with the appropriate master/slave destruction calls.
* Wrap various slave objects in `Owned` (i.e. containerizers, isolators, 
launchers, etc).
* Replace `CHECK` in tests with `ASSERT`.


Diffs (updated)
-

  src/tests/authentication_tests.cpp 85f14c3d453ca5aeffa1c915f38fe3031c2cf712 
  src/tests/command_executor_tests.cpp 0d2fcf6d4b8d9a925eb6748e6bd33cf279b8f7f8 
  src/tests/container_logger_tests.cpp 00f4129e46aa9268fbb66da25b34e61004fa87b2 
  src/tests/containerizer/docker_containerizer_tests.cpp 
6aecd912fc84b72d2b64f7a842891fddcbc469ac 
  src/tests/containerizer/external_containerizer_test.cpp 
8e1dbe306a088eb16cd3b9c6174b95fad5685da4 
  src/tests/containerizer/filesystem_isolator_tests.cpp 
6a60962b4593b3521c182c7320331743ccffd4ba 
  src/tests/containerizer/isolator_tests.cpp 
7b257de2afbc66f63c47a80c1f828e3e95bd602d 
  src/tests/containerizer/memory_pressure_tests.cpp 
79f134996c4b80bf49cbb8bee28eab5e6b4f5822 
  src/tests/containerizer/mesos_containerizer_tests.cpp 
15f0f93d2e5c19a22f6cc4a71a7d94be4aaec2c1 
  src/tests/containerizer/port_mapping_tests.cpp 
983a6be160aefe5a32acb6111bb3c85230ec 
  src/tests/containerizer/provisioner_docker_tests.cpp 
5b685bfd842d0d98e8ea5ec5ddea8d2cd893dd81 
  src/tests/credentials_tests.cpp 7edcc857e0f6f8e80e265deeec59d6349d392224 
  src/tests/disk_quota_tests.cpp 413e562026a4fc9779f616e921ae2fa2ca51e012 
  src/tests/exception_tests.cpp 6b71316d545e97f14a45daa14d0fd95204befd3b 
  src/tests/executor_http_api_tests.cpp 
2fc0893f5f5e80a783296fb31b30abe86d92df1b 
  src/tests/fault_tolerance_tests.cpp 982468f851cd9d95eb6cde7c57f2d737d46a827c 
  src/tests/gc_tests.cpp 61a8abb9581dc4602b197a88a677b19386969cbf 
  src/tests/health_check_tests.cpp 59ef31970af2d255abe169dfbc2e6e0314d29e9a 
  src/tests/hook_tests.cpp 88ad7806bf9f3194e434743c35199a896edea92c 
  src/tests/master_allocator_tests.cpp cba7c36471f93b678d94e1da0251a28a893696b1 
  src/tests/master_authorization_tests.cpp 
29c89fb11da792c3e71eb880a19657ea225b3cc8 
  src/tests/master_contender_detector_tests.cpp 
255ab8119a04b55bb4f1b61dee19c4be64499376 
  src/tests/master_maintenance_tests.cpp 
3faa8136cf57276295553910319480028f433e4c 
  src/tests/master_quota_tests.cpp 8357ec911b2a158632a708ae3adff6eabc536697 
  src/tests/master_slave_reconciliation_tests.cpp 
d41178eb41df519073fc0890c5716bbc9fed6ad2 
  src/tests/master_tests.cpp 0bd8c0e42f335cad7ed858c6af5aa4f07bb37dbf 
  src/tests/master_validation_tests.cpp 
c9bc38ce604d2d44d6e6b1286507d1c45e5e9e25 
  src/tests/metrics_tests.cpp 419d275e0b32817388120222bd433ee6f4835efd 
  src/tests/monitor_tests.cpp 869c9e032817e8859a968232d4a61556a3d53d45 
  src/tests/oversubscription_tests.cpp e528476cd83b0e3f7ae8cea7d86dfabc1f66484e 
  src/tests/partition_tests.cpp 3776a0a104582f60b9f19ea58b011485194399b9 
  src/tests/persistent_volume_endpoints_tests.cpp 
81185a161498394020a27f1f5bf747bac5425f43 
  src/tests/persistent_volume_tests.cpp 
bf19c81fbcf973d1ac27fbd42eedfd7118b7ba50 
  src/tests/rate_limiting_tests.cpp caced732ded05a334861a53488ef6391885b2263 
  src/tests/reconciliation_tests.cpp 97112c4d64c75a16fdd7bbefd517a039fbf55b64 
  src/tests/registrar_zookeeper_tests.cpp 
3df9779ee5d076e16f6a538326693a36f986b6d0 
  src/tests/repair_tests.cpp bb104562659e135492f9857e5b452c8a0a9e97da 
  src/tests/reservation_endpoints_tests.cpp 
f3a143812aa10bc445ac5d27c00318e91eb086aa 
  src/tests/reservation_tests.cpp d7f9de6f2bce061316916260f356efdb96ecd482 
  src/tests/resource_offers_tests.cpp 0bad45dd1dabecc88fef1ab46e8ea26718070b33 
  src/tests/role_tests.cpp fc3a72894631279460ee7971a4627d73c3d8c351 
  src/tests/scheduler_driver_tests.cpp f6dc25d82ae5f1e77fc6ede7ff2660ed0d9ea039 
  src/tests/scheduler_event_call_tests.cpp 
8c02ceeb3ec1783cb2f63f100700508e70f586e4 
  src/tests/scheduler_http_api_tests.cpp 
428e12646d80b45daec30cfe607b97f36170fdf5 
  src/tests/slave_recovery_tests.cpp 

Re: Review Request 43413: CMake:[1/2] Allow downloading third-party dependencies from mirror.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43413/#review121219
---




3rdparty/CMakeLists.txt (line 36)


Committed with `s/we us different/we use a different/`


- Michael Park


On Feb. 18, 2016, 12:59 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43413/
> ---
> 
> (Updated Feb. 18, 2016, 12:59 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> CMake:[1/2] Allow downloading third-party dependencies from mirror.
> 
> 
> Diffs
> -
> 
>   3rdparty/CMakeLists.txt 3253da73aa517a335be94148d567510147dae08d 
>   CMakeLists.txt 7f83dc84997d3b824d1f63012894bd9fc5284053 
> 
> Diff: https://reviews.apache.org/r/43413/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Review Request 44163: Used temporary directory for fixture creating output files.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44163/
---

Review request for mesos, Benjamin Hindman and Till Toenshoff.


Bugs: MESOS-4806
https://issues.apache.org/jira/browse/MESOS-4806


Repository: mesos


Description
---

Used temporary directory for fixture creating output files.


Diffs
-

  src/tests/state_tests.cpp 0b0bc9cb1c6e4906aa65c113207e5a2d8ebe61d9 

Diff: https://reviews.apache.org/r/44163/diff/


Testing
---


Thanks,

Benjamin Bannier

Re: Review Request 43561: Improve Ranges parsing to handle single values.

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43561/
---

(Updated Feb. 29, 2016, 5:57 p.m.)


Review request for mesos and Ben Mahler.


Changes
---

Rebase


Bugs: MESOS-4627
https://issues.apache.org/jira/browse/MESOS-4627


Repository: mesos


Description
---

Improve Ranges parsing to handle single values.


Diffs (updated)
-

  src/common/values.cpp 9f3c0b9930bd3dd9d84d97119419825862f531c3 
  src/tests/resources_tests.cpp a545100522bf4b1f03e50656d461b3cda6b41e11 
  src/tests/values_tests.cpp 929861549e3155c33966896f817f9bf9e6d14354 

Diff: https://reviews.apache.org/r/43561/diff/


Testing
---

make
make check GTEST_FILTER=~"*"
./src/mesos-test


Thanks,

Klaus Ma

Re: Review Request 43883: Added allocator metrics for number of offer filters per framework.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43883/#review121363
---




src/master/allocator/mesos/hierarchical.cpp (lines 276 - 282)


As in previous reviews, let's go for:

```c++
metrics.framework_offer_filters.put(
frameworkId,
process::metrics::Gauge(
strings::join(
"/", 
"allocator/framework_offer_filters",
frameworkId.value()),
process::defer(self(), [this, frameworkId]() {
  return this->
frameworks[frameworkId].offerFilters.size();
})));
```


- Alexander Rojas


On Feb. 29, 2016, 8:59 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43883/
> ---
> 
> (Updated Feb. 29, 2016, 8:59 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Ben Mahler.
> 
> 
> Bugs: MESOS-4722
> https://issues.apache.org/jira/browse/MESOS-4722
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added allocator metrics for number of offer filters per framework.
> 
> 
> Diffs
> -
> 
>   docs/monitoring.md 827f7073204fcf8575ca980a5571c8be4f5e4110 
>   src/master/allocator/mesos/hierarchical.hpp 
> 3043888630b066505410d3b32c5b3f813cc458c1 
>   src/master/allocator/mesos/hierarchical.cpp 
> 24fa50f62dec10ed43089297473cc386d6ba2f78 
>   src/tests/hierarchical_allocator_tests.cpp 
> 5f771f02db9bd098f3cd36730cd84bf2f5e87a33 
> 
> Diff: https://reviews.apache.org/r/43883/diff/
> 
> 
> Testing
> ---
> 
> make check (OS X)
> 
> I confirmed that this does not lead to general performance regressions in the 
> allocator; this is partially expected since the added code only inserts 
> metrics in the allocator while the actual work is perform asynchronously. 
> These tests where performed with 
> `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build 
> under OS X using clang(trunk) as compiler.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Review Request 44189: Document docker runtime isolator.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44189/
---

Review request for mesos, Artem Harutyunyan, Jie Yu, Neil Conway, and Timothy 
Chen.


Bugs: MESOS-4683
https://issues.apache.org/jira/browse/MESOS-4683


Repository: mesos


Description
---

Document docker runtime isolator.


Diffs
-

  docs/mesos-containerizer.md 5edfbc3af3a3233cf9ab651290c298e8b6b77890 

Diff: https://reviews.apache.org/r/44189/diff/


Testing
---

Tested with support/site-docker. Verified that the table works correctly.


Thanks,

Gilbert Song

Re: Review Request 43884: Added allocator metrics for used quotas.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43884/#review121366
---




src/master/allocator/mesos/hierarchical.hpp (line 302)


Let's use `typedef` instead. If you do a search this would be the only 
instance in the codebase of type aliasing using `using`.



src/master/allocator/mesos/hierarchical.hpp (line 303)


I'm even wondering whether `auto` here is a better idea than aliasing.



src/master/allocator/mesos/hierarchical.cpp (line 1094)


Comment in next line.



src/master/allocator/mesos/hierarchical.cpp (lines 1100 - 1109)


As in my previous comments, let's shy away from implicit calling a 
constructor. I  this case I think creating the `Deferred` object outside even 
makes more sense.


- Alexander Rojas


On Feb. 29, 2016, 8:59 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43884/
> ---
> 
> (Updated Feb. 29, 2016, 8:59 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Ben Mahler.
> 
> 
> Bugs: MESOS-4723
> https://issues.apache.org/jira/browse/MESOS-4723
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added allocator metrics for used quotas.
> 
> 
> Diffs
> -
> 
>   docs/monitoring.md 827f7073204fcf8575ca980a5571c8be4f5e4110 
>   src/master/allocator/mesos/hierarchical.hpp 
> 3043888630b066505410d3b32c5b3f813cc458c1 
>   src/master/allocator/mesos/hierarchical.cpp 
> 24fa50f62dec10ed43089297473cc386d6ba2f78 
>   src/tests/hierarchical_allocator_tests.cpp 
> 5f771f02db9bd098f3cd36730cd84bf2f5e87a33 
> 
> Diff: https://reviews.apache.org/r/43884/diff/
> 
> 
> Testing
> ---
> 
> make check (OS X)
> 
> I confirmed that this does not lead to general performance regressions in the 
> allocator; this is partially expected since the added code only inserts 
> metrics in the allocator while the actual work is perform asynchronously. 
> These tests where performed with 
> `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build 
> under OS X using clang(trunk) as compiler.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43881/#review121343
---




src/tests/hierarchical_allocator_tests.cpp (line 2481)


s/{}/None()/


- Alexander Rojas


On Feb. 29, 2016, 8:59 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43881/
> ---
> 
> (Updated Feb. 29, 2016, 8:59 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Ben Mahler.
> 
> 
> Bugs: MESOS-4719
> https://issues.apache.org/jira/browse/MESOS-4719
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added allocator metric for the number of allocations to a framework.
> 
> 
> Diffs
> -
> 
>   docs/monitoring.md 827f7073204fcf8575ca980a5571c8be4f5e4110 
>   src/master/allocator/mesos/hierarchical.hpp 
> 3043888630b066505410d3b32c5b3f813cc458c1 
>   src/master/allocator/mesos/hierarchical.cpp 
> 24fa50f62dec10ed43089297473cc386d6ba2f78 
>   src/tests/hierarchical_allocator_tests.cpp 
> 5f771f02db9bd098f3cd36730cd84bf2f5e87a33 
> 
> Diff: https://reviews.apache.org/r/43881/diff/
> 
> 
> Testing
> ---
> 
> make check (OS X)
> 
> I confirmed that this does not lead to general performance regressions in the 
> allocator; this is partially expected since the added code only inserts 
> metrics in the allocator while the actual work is perform asynchronously. 
> These tests where performed with 
> `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build 
> under OS X using clang(trunk) as compiler.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 43882: Added allocation metrics for allocation time.

[Alexander Rojas]

> On Feb. 27, 2016, 2:11 a.m., Alexander Rojas wrote:
> > src/master/allocator/mesos/hierarchical.hpp, line 360
> > 
> >
> > There is a second parameter in the `Timer` object which allows you to 
> > specify a window, once this window is enabled we can get statistics of the 
> > run beyond how long the last allocation took place (note that allocation 
> > varies a lot since sometimes it goes through a few elements and other times 
> > goes throught the whole cluster).
> 
> Benjamin Bannier wrote:
> Yes, the timer I added here can only be sampled and provides no stats. Do 
> you have a suggestion how many `allocation_intervals` the window should be?

I'm not really sure, I think it would be better if you consult with your 
shepherd on this matter.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43882/#review121029
---


On Feb. 29, 2016, 8:59 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43882/
> ---
> 
> (Updated Feb. 29, 2016, 8:59 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Ben Mahler.
> 
> 
> Bugs: MESOS-4721
> https://issues.apache.org/jira/browse/MESOS-4721
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added allocation metrics for allocation time.
> 
> 
> Diffs
> -
> 
>   docs/monitoring.md 827f7073204fcf8575ca980a5571c8be4f5e4110 
>   src/master/allocator/mesos/hierarchical.hpp 
> 3043888630b066505410d3b32c5b3f813cc458c1 
>   src/master/allocator/mesos/hierarchical.cpp 
> 24fa50f62dec10ed43089297473cc386d6ba2f78 
>   src/tests/hierarchical_allocator_tests.cpp 
> 5f771f02db9bd098f3cd36730cd84bf2f5e87a33 
> 
> Diff: https://reviews.apache.org/r/43882/diff/
> 
> 
> Testing
> ---
> 
> make check (OS X)
> 
> I confirmed that this does not lead to general performance regressions in the 
> allocator; this is partially expected since the added code only inserts 
> metrics in the allocator while the actual work is perform asynchronously. 
> These tests where performed with 
> `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build 
> under OS X using clang(trunk) as compiler.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 44185: Clarified docs for `--offer_timeout` master flag.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44185/
---

(Updated Feb. 29, 2016, 11:34 p.m.)


Review request for mesos and Vinod Kone.


Bugs: MESOS-4702
https://issues.apache.org/jira/browse/MESOS-4702


Repository: mesos


Description
---

Clarified docs for `--offer_timeout` master flag.


Diffs
-

  docs/configuration.md c4d094aac4acb95fd6648071413a3d5160dbf381 
  src/master/flags.cpp 60e085bd5c6689adb625a736edc76e814860ea7d 

Diff: https://reviews.apache.org/r/44185/diff/


Testing
---

Compiled on OSX.


Thanks,

Neil Conway

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43880/#review121330
---




src/master/allocator/mesos/hierarchical.hpp (line 478)


Not very sure about the _Installs metrics_ since metrics are usually not 
installed but taken. The comment is lost outside the context, how about: 
_Installs gauges to obtain metrics of resources of kind `name`_ or something 
along those lines.



src/master/allocator/mesos/hierarchical.hpp (line 479)


s/add/create/ when I see a method called add I generally assume I am 
passing what is going to be added (in this case, I though about passing the 
resource as a second parameter).



src/master/allocator/mesos/hierarchical.cpp (lines 413 - 418)


This is really unreadable. I wasn't unsure of what it was happening here. I 
felt like an `std::initializer_list` was being created with two elements of 
complete different types.

Then I realized that it was called implicitly the constructor of 
`process::metrics::Gauge`. So there are some fixes I feel these lines need:

1. No implicit constructor calls, let's not make it hard for people reading 
the code so that they will need to jump back to see the declaration of 
`metrics.allocated`.
2. There aren't many constructors in this file, but the few there use 
parenthesis instead of brackets. Let's aim for consistency and readability 
instead of brace-initialization lets use parenthesis.
3. I think creating the deferred object outside will improve readability.

All in all, I would go for code that looks like:

```c++
Deferred totalGenerator = 
  process::defer(self(), [this, name]() {
Option value =
  this->roleSorter->totalScalars().get(name);
return value.isSome() ? value.get().value() ? 0.0;
  });

metrics.allocated.put(
name,
process::metrics::Gauge(
strings::join("/", "allocator/allocated", name),
totalGenerator));

```



src/master/allocator/mesos/hierarchical.cpp (lines 424 - 435)


Same as above.



src/master/allocator/mesos/hierarchical.cpp (line 426)


s/result/allocated/


- Alexander Rojas


On Feb. 28, 2016, 10:28 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43880/
> ---
> 
> (Updated Feb. 28, 2016, 10:28 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Ben Mahler.
> 
> 
> Bugs: MESOS-4720
> https://issues.apache.org/jira/browse/MESOS-4720
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added allocator metrics for total and allocated scalar resources.
> 
> 
> Diffs
> -
> 
>   docs/monitoring.md 827f7073204fcf8575ca980a5571c8be4f5e4110 
>   src/master/allocator/mesos/hierarchical.hpp 
> 3043888630b066505410d3b32c5b3f813cc458c1 
>   src/master/allocator/mesos/hierarchical.cpp 
> 24fa50f62dec10ed43089297473cc386d6ba2f78 
>   src/tests/hierarchical_allocator_tests.cpp 
> 5f771f02db9bd098f3cd36730cd84bf2f5e87a33 
> 
> Diff: https://reviews.apache.org/r/43880/diff/
> 
> 
> Testing
> ---
> 
> make check (OS X)
> 
> I confirmed that this does not lead to general performance regressions in the 
> allocator; this is partially expected since the added code only inserts 
> metrics in the allocator while the actual work is perform asynchronously. 
> These tests where performed with 
> `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build 
> under OS X using clang(trunk) as compiler.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 43914: Modified `NetClsHandleManager` to take a range of secondary handles.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43914/#review121339
---


Fix it, then Ship it!





src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp (lines 125 - 127)


I think you should be able to use `foreach` here



src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp (lines 166 - 168)


Ditto on using foreach


- Jie Yu


On Feb. 24, 2016, 4:44 p.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43914/
> ---
> 
> (Updated Feb. 24, 2016, 4:44 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4700
> https://issues.apache.org/jira/browse/MESOS-4700
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The `alloc`, `free` and `reserve` methods of `NetClsHandleManager` can
> now work with a specified range of secondary handles instead of
> assuming that the entire 64K space of secondary handles is available
> for use.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp 
> acd61e615951e18dd51a2ce1e746ba733e9159ae 
>   src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp 
> f05cd55a9e080f44566ec7dcef22f11950496d6f 
> 
> Diff: https://reviews.apache.org/r/43914/diff/
> 
> 
> Testing
> ---
> 
> make and make check.
> 
> Also ran sudo make check for the "NetClsIsolatoTest"
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43881/#review121360
---




src/master/allocator/mesos/hierarchical.cpp (lines 268 - 271)


As in the previous review, I find much more readable:

```c++
metrics.framework_allocations.put(
frameworkId,
process::metrics::Counter(
  strings::join(
  "/", 
  "allocator/framework_allocations",
  frameworkId.value(;
```


- Alexander Rojas


On Feb. 29, 2016, 8:59 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43881/
> ---
> 
> (Updated Feb. 29, 2016, 8:59 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Ben Mahler.
> 
> 
> Bugs: MESOS-4719
> https://issues.apache.org/jira/browse/MESOS-4719
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added allocator metric for the number of allocations to a framework.
> 
> 
> Diffs
> -
> 
>   docs/monitoring.md 827f7073204fcf8575ca980a5571c8be4f5e4110 
>   src/master/allocator/mesos/hierarchical.hpp 
> 3043888630b066505410d3b32c5b3f813cc458c1 
>   src/master/allocator/mesos/hierarchical.cpp 
> 24fa50f62dec10ed43089297473cc386d6ba2f78 
>   src/tests/hierarchical_allocator_tests.cpp 
> 5f771f02db9bd098f3cd36730cd84bf2f5e87a33 
> 
> Diff: https://reviews.apache.org/r/43881/diff/
> 
> 
> Testing
> ---
> 
> make check (OS X)
> 
> I confirmed that this does not lead to general performance regressions in the 
> allocator; this is partially expected since the added code only inserts 
> metrics in the allocator while the actual work is perform asynchronously. 
> These tests where performed with 
> `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build 
> under OS X using clang(trunk) as compiler.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Review Request 44185: Clarified docs for `--offer_timeout` master flag.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44185/
---

Review request for mesos and Vinod Kone.


Repository: mesos


Description
---

Clarified docs for `--offer_timeout` master flag.


Diffs
-

  docs/configuration.md c4d094aac4acb95fd6648071413a3d5160dbf381 
  src/master/flags.cpp 60e085bd5c6689adb625a736edc76e814860ea7d 

Diff: https://reviews.apache.org/r/44185/diff/


Testing
---

Compiled on OSX.


Thanks,

Neil Conway

Re: Review Request 44185: Clarified docs for `--offer_timeout` master flag.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44185/#review121369
---



Patch looks great!

Reviews applied: [44185]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 29, 2016, 11:34 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44185/
> ---
> 
> (Updated Feb. 29, 2016, 11:34 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4702
> https://issues.apache.org/jira/browse/MESOS-4702
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Clarified docs for `--offer_timeout` master flag.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md c4d094aac4acb95fd6648071413a3d5160dbf381 
>   src/master/flags.cpp 60e085bd5c6689adb625a736edc76e814860ea7d 
> 
> Diff: https://reviews.apache.org/r/44185/diff/
> 
> 
> Testing
> ---
> 
> Compiled on OSX.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 43824: Addressed comments of 41672.

[Yongqiao Wang]

> On Feb. 28, 2016, 9:39 a.m., Adam B wrote:
> > src/tests/hierarchical_allocator_tests.cpp, lines 2658-2661
> > 
> >
> > Can you say 100% and 0% instead of 1 and 0? And how is framework1's 
> > "share" '6'? Is that the number of agents/offers, rather than the 
> > framework's "share"?

I refer to the styles in above tests in this file? for example: 
https://github.com/apache/mesos/blob/master/src/tests/hierarchical_allocator_tests.cpp?262#L262
 so I used 1 rather than 100%. I think we should keep consistent, especially in 
a same file. For framework's "share", I have updated them to a ratio.


- Yongqiao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43824/#review121132
---


On Feb. 22, 2016, 7:23 a.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43824/
> ---
> 
> (Updated Feb. 22, 2016, 7:23 a.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-4200
> https://issues.apache.org/jira/browse/MESOS-4200
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Addressed comments of 41672.
> 
> 
> Diffs
> -
> 
>   src/tests/hierarchical_allocator_tests.cpp 
> 5f771f02db9bd098f3cd36730cd84bf2f5e87a33 
> 
> Diff: https://reviews.apache.org/r/43824/diff/
> 
> 
> Testing
> ---
> 
> make && make check successfully.
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>

Re: Review Request 41672: Test case(s) for weights + allocation behaviour.

[Yongqiao Wang]

> On Feb. 19, 2016, 9:31 a.m., Alexander Rukletsov wrote:
> > src/tests/hierarchical_allocator_tests.cpp, line 2373
> > 
> >
> > You can put framework id's into a `std::set` instead. Given there are 
> > two allocations, there is a guarantee, that there will be no attempts to 
> > put the same framework into the set twice.
> 
> Yongqiao Wang wrote:
> In the current implementation, we only need to check the allocation size 
> for each framework, it does not care the size of whole contianer (currentt is 
> hashmap), so I think use hashmap can meet the current requirement.
> 
> Adam B wrote:
> I think he's saying you can use a `std::set 
> allocatedFrameworks;` and inside your loop do: 
> `allocatedFrameworks.insert(allocation.get().frameworkId);`
> and verify the allocations afterwards with: 
> `EXPECT_EQ(expectedFrameworksSet, allocatedFrameworks);`

Have changed `hashmap` to `std::set`


- Yongqiao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41672/#review119839
---


On Jan. 20, 2016, 8:36 a.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41672/
> ---
> 
> (Updated Jan. 20, 2016, 8:36 a.m.)
> 
> 
> Review request for mesos, Adam B, Neil Conway, and Qian Zhang.
> 
> 
> Bugs: MESOS-4200
> https://issues.apache.org/jira/browse/MESOS-4200
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Test case(s) for weights + allocation behaviour.
> 
> 
> Diffs
> -
> 
>   src/tests/hierarchical_allocator_tests.cpp 
> 953712149bd951789beb29c72779c4ac65aa48dc 
> 
> Diff: https://reviews.apache.org/r/41672/diff/
> 
> 
> Testing
> ---
> 
> Make check done:
> $ ./src/mesos-tests --gtest_filter=HierarchicalAllocatorTest.UpdateWeight
> Source directory: /Users/yqwyq/Desktop/mesos
> Build directory: /Users/yqwyq/Desktop/mesos/build
> [==] Running 1 test from 1 test case.
> [--] Global test environment set-up.
> [--] 1 test from HierarchicalAllocatorTest
> [ RUN  ] HierarchicalAllocatorTest.UpdateWeight
> [   OK ] HierarchicalAllocatorTest.UpdateWeight (87 ms)
> [--] 1 test from HierarchicalAllocatorTest (87 ms total)
> 
> [--] Global test environment tear-down
> [==] 1 test from 1 test case ran. (176 ms total)
> [  PASSED  ] 1 test.
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>

Re: Review Request 44189: Document docker runtime isolator.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44189/#review121384
---




docs/mesos-containerizer.md (line 115)


s/we/the docker runtime isolator

ditto for the following


- Guangya Liu


On 三月 1, 2016, 12:03 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44189/
> ---
> 
> (Updated 三月 1, 2016, 12:03 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, Neil Conway, and Timothy 
> Chen.
> 
> 
> Bugs: MESOS-4683
> https://issues.apache.org/jira/browse/MESOS-4683
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Document docker runtime isolator.
> 
> 
> Diffs
> -
> 
>   docs/mesos-containerizer.md 5edfbc3af3a3233cf9ab651290c298e8b6b77890 
> 
> Diff: https://reviews.apache.org/r/44189/diff/
> 
> 
> Testing
> ---
> 
> Tested with support/site-docker. Verified that the table works correctly.
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 44179: Reintroduce deleted anchor in configuration.md.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44179/#review121385
---



Patch looks great!

Reviews applied: [44179]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 1, 2016, 12:36 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44179/
> ---
> 
> (Updated March 1, 2016, 12:36 a.m.)
> 
> 
> Review request for mesos, Greg Mann and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This anchor was deleted by https://reviews.apache.org/r/42939 but is still 
> referenced by sandbox.md.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md c4d094aac4acb95fd6648071413a3d5160dbf381 
> 
> Diff: https://reviews.apache.org/r/44179/diff/
> 
> 
> Testing
> ---
> 
> Checked via gist.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Review Request 44190: Made `Bytes` usable in `constexpr` expressions [stout].

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44190/
---

Review request for mesos and Ben Mahler.


Bugs: MESOS-4790
https://issues.apache.org/jira/browse/MESOS-4790


Repository: mesos


Description
---

Also marked a few Duration constants as `constexpr`.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/stout/bytes.hpp 
88a8bd4019fcbdaa5fcde4867cee9a198c83c1c6 
  3rdparty/libprocess/3rdparty/stout/include/stout/duration.hpp 
ecec70672313666124ee6a951b3db09e9401b9ff 

Diff: https://reviews.apache.org/r/44190/diff/


Testing
---

make check


Thanks,

Neil Conway

Re: Review Request 44191: Avoided external linkage for master constants.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44191/
---

(Updated March 1, 2016, 2:26 a.m.)


Review request for mesos and Ben Mahler.


Bugs: MESOS-4790
https://issues.apache.org/jira/browse/MESOS-4790


Repository: mesos


Description
---

We were only using external linkage to workaround bugs in ancient
(4.1.x) of GCC. We can also mark most of these constants `constexpr`,
which should be both slightly more efficient (in theory) and
safer (see MESOS-1023).


Diffs
-

  src/CMakeLists.txt a62042fbd45b46217a88098875524f93d3079de3 
  src/Makefile.am 5d8fe8bf33acb352589b2b3e0341987f9a41bc17 
  src/master/constants.hpp 2c3299bc1aaa0888f7e47a71965c56ada8ecc21f 
  src/master/constants.cpp e316f9772d880b694faeee6d001dc56bc088c118 

Diff: https://reviews.apache.org/r/44191/diff/


Testing (updated)
---

make check

Note that I left a few string constants as `const std::string`; you might 
arguably want them to be `constexpr char[]` (per Google Style Guide).


Thanks,

Neil Conway

Re: Review Request 43824: Addressed comments of 41672.

[Yongqiao Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43824/
---

(Updated March 1, 2016, 6:42 a.m.)


Review request for mesos, Adam B and Alexander Rukletsov.


Changes
---

Addressed comments of Adam.


Bugs: MESOS-4200
https://issues.apache.org/jira/browse/MESOS-4200


Repository: mesos


Description
---

Addressed comments of 41672.


Diffs (updated)
-

  src/tests/hierarchical_allocator_tests.cpp 
5f771f02db9bd098f3cd36730cd84bf2f5e87a33 

Diff: https://reviews.apache.org/r/43824/diff/


Testing
---

make && make check successfully.


Thanks,

Yongqiao Wang

Review Request 44200: Add agent flags for specifying CNI plugin and config directories.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44200/
---

Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.


Bugs: MESOS-4761
https://issues.apache.org/jira/browse/MESOS-4761


Repository: mesos


Description
---

Add agent flags for specifying CNI plugin and config directories.


Diffs
-

  docs/configuration.md c4d094aac4acb95fd6648071413a3d5160dbf381 
  docs/endpoints/slave/state.json.md a6403eea3426bdec81d170d0829ffe7174862e55 
  docs/endpoints/slave/state.md bdd555e0231935c668dea1ba63582348db2b3629 
  src/slave/flags.hpp c07932157ffe36ea36f1def4c7d92b79d2219c48 
  src/slave/flags.cpp 7f139e99e8392fe95bb30070896ed9d95dfe5701 
  src/slave/http.cpp 4eb1fafdfa72094511b0b2684a3c2705bd8c7c5e 

Diff: https://reviews.apache.org/r/44200/diff/


Testing
---

make check


Thanks,

Qian Zhang

Review Request 44191: Avoided external linkage for master constants.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44191/
---

Review request for mesos and Ben Mahler.


Bugs: MESOS-4790
https://issues.apache.org/jira/browse/MESOS-4790


Repository: mesos


Description
---

We were only using external linkage to workaround bugs in ancient
(4.1.x) of GCC. We can also mark most of these constants `constexpr`,
which should be both slightly more efficient (in theory) and
safer (see MESOS-1023).


Diffs
-

  src/CMakeLists.txt a62042fbd45b46217a88098875524f93d3079de3 
  src/Makefile.am 5d8fe8bf33acb352589b2b3e0341987f9a41bc17 
  src/master/constants.hpp 2c3299bc1aaa0888f7e47a71965c56ada8ecc21f 
  src/master/constants.cpp e316f9772d880b694faeee6d001dc56bc088c118 

Diff: https://reviews.apache.org/r/44191/diff/


Testing
---

make check


Thanks,

Neil Conway

Re: Review Request 44191: Avoided external linkage for master constants.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44191/#review121391
---



Patch looks great!

Reviews applied: [44190, 44191]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 1, 2016, 2:26 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44191/
> ---
> 
> (Updated March 1, 2016, 2:26 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-4790
> https://issues.apache.org/jira/browse/MESOS-4790
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We were only using external linkage to workaround bugs in ancient
> (4.1.x) of GCC. We can also mark most of these constants `constexpr`,
> which should be both slightly more efficient (in theory) and
> safer (see MESOS-1023).
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt a62042fbd45b46217a88098875524f93d3079de3 
>   src/Makefile.am 5d8fe8bf33acb352589b2b3e0341987f9a41bc17 
>   src/master/constants.hpp 2c3299bc1aaa0888f7e47a71965c56ada8ecc21f 
>   src/master/constants.cpp e316f9772d880b694faeee6d001dc56bc088c118 
> 
> Diff: https://reviews.apache.org/r/44191/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> Note that I left a few string constants as `const std::string`; you might 
> arguably want them to be `constexpr char[]` (per Google Style Guide).
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 44189: Document docker runtime isolator.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44189/#review121382
---



Patch looks great!

Reviews applied: [44189]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 1, 2016, 12:03 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44189/
> ---
> 
> (Updated March 1, 2016, 12:03 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, Neil Conway, and Timothy 
> Chen.
> 
> 
> Bugs: MESOS-4683
> https://issues.apache.org/jira/browse/MESOS-4683
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Document docker runtime isolator.
> 
> 
> Diffs
> -
> 
>   docs/mesos-containerizer.md 5edfbc3af3a3233cf9ab651290c298e8b6b77890 
> 
> Diff: https://reviews.apache.org/r/44189/diff/
> 
> 
> Testing
> ---
> 
> Tested with support/site-docker. Verified that the table works correctly.
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 44004: Add 'name' field into NetworkInfo.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44004/
---

(Updated March 1, 2016, 3:28 p.m.)


Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.


Bugs: MESOS-4758
https://issues.apache.org/jira/browse/MESOS-4758


Repository: mesos


Description
---

Add 'name' field into NetworkInfo.


Diffs (updated)
-

  include/mesos/mesos.proto 3d22ec32655dca741169e1f0e382303e061c38b7 
  include/mesos/v1/mesos.proto 31960a52061f70d80528fb8326522ae1d6f75b2c 
  src/common/http.cpp be8538fc222d83d802611392f6c94e80a1e56fa8 

Diff: https://reviews.apache.org/r/44004/diff/


Testing
---

make check


Thanks,

Qian Zhang

Re: Review Request 42719: Add doc for weights.

[Yongqiao Wang]

> On Feb. 28, 2016, 8:21 a.m., Adam B wrote:
> > Thanks! Couple of tweaks as I review it again.
> > - How did you test that this renders correctly? Did you try 
> > `support/site-docker` to see if the markdown translates properly to html? 
> > Just because it looks good in github doesn't mean our Rakefile will make it 
> > look as good.

Yes, I have tried `support/site-docker`. This new doc looks good.


> On Feb. 28, 2016, 8:21 a.m., Adam B wrote:
> > docs/weights.md, line 16
> > 
> >
> > Are we officially deprecating --weights in this release? If so, we'll 
> > need to update upgrades.md and the CHANGELOG to mention this.
> > 
> > Could you also document what happens when a master restarts with a 
> > --weights flag that differs from what's in the registry? (We warn and use 
> > the registry value, correct?)

`--weights` does not deprecate in this release (0.28), for backwark 
compitibility, it will be deprecated in a future release (Maybe six months 
later).


- Yongqiao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42719/#review121129
---


On Feb. 19, 2016, 7:56 a.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42719/
> ---
> 
> (Updated Feb. 19, 2016, 7:56 a.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-3945
> https://issues.apache.org/jira/browse/MESOS-3945
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add doc for weights.
> 
> 
> Diffs
> -
> 
>   docs/home.md 07214b927c112d7a180507ae03245892455fd757 
>   docs/weights.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/42719/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>

Re: Review Request 42719: Add doc for weights.

[Yongqiao Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42719/
---

(Updated March 1, 2016, 7:53 a.m.)


Review request for mesos and Adam B.


Changes
---

Addressed comments of Adam.


Bugs: MESOS-3945
https://issues.apache.org/jira/browse/MESOS-3945


Repository: mesos


Description
---

Add doc for weights.


Diffs (updated)
-

  docs/home.md 821026a12f422385e347e0037d6527efa9ffa2e1 
  docs/weights.md PRE-CREATION 

Diff: https://reviews.apache.org/r/42719/diff/


Testing
---


Thanks,

Yongqiao Wang