Re: Review Request 44554: Added agent HTTP authentication to the docs.

2016-03-11 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44554/#review123146 --- docs/authentication.md (line 12)

Review Request 44706: Implemented isolate() method of "network/cni" isolator.

2016-03-11 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44706/ --- Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu. Bugs:

Re: Review Request 44553: Added authentication to agent HTTP endpoints.

2016-03-11 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44553/#review123139 --- Fix it, then Ship it!

Re: Review Request 44553: Added authentication to agent HTTP endpoints.

2016-03-11 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44553/#review123142 --- src/tests/health_check_tests.cpp (line 642)

Re: Review Request 44620: Documented how to make executors work with SSL.

2016-03-11 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44620/ --- (Updated March 11, 2016, 4:21 p.m.) Review request for mesos, Adam B and

Re: Review Request 41791: Updated allocation slack when dynamic reserve called.

2016-03-11 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41791/ --- (Updated 三月 11, 2016, 3:01 p.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 44553: Added authentication to agent HTTP endpoints.

2016-03-11 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44553/#review123137 --- Ship it! Ship It! - Alexander Rojas On March 11, 2016,

Re: Review Request 44678: Modified basic HTTP authenticator creator to accept realm.

2016-03-11 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44678/#review123144 --- src/authentication/http/basic_authenticator_factory.cpp (lines

Re: Review Request 44703: Added Doxygen docs for basic HTTP authenticator.

2016-03-11 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44703/#review123140 ---

Re: Review Request 44515: Added agent flags for HTTP authentication.

2016-03-11 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44515/ --- (Updated March 11, 2016, 9:48 a.m.) Review request for mesos, Adam B,

Review Request 44703: Added Doxygen docs for basic HTTP authenticator.

2016-03-11 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44703/ --- Review request for mesos, Adam B, Alexander Rojas, Joerg Schad, and Till

Re: Review Request 44087: Moved logic to assign process to freezer hierarchy into parentHook.

2016-03-11 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44087/#review123125 --- Patch looks great! Reviews applied: [44247, 44087] Passed

Re: Review Request 44549: Introduced a protobuf message "NetworkConfig".

2016-03-11 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44549/#review123170 --- src/CMakeLists.txt (line 52)

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

2016-03-11 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44514/#review123176 --- src/slave/containerizer/mesos/isolators/network/cni.hpp (line

Re: Review Request 44191: Avoided external linkage for master constants.

2016-03-11 Thread Neil Conway
> On March 11, 2016, 12:38 a.m., Ben Mahler wrote: > > src/master/constants.hpp, line 108 > > > > > > Could you also go ahead and do the change to `constexpr char[]` if > > possible for strings here? Done, as a

Review Request 44720: Replaced `const string` slave constants with `constexpr char[]`.

2016-03-11 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44720/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Re: Review Request 44191: Avoided external linkage for master constants.

2016-03-11 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44191/ --- (Updated March 11, 2016, 6:31 p.m.) Review request for mesos and Ben Mahler.

Review Request 44717: Marked a few Duration constants `constexpr`.

2016-03-11 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44717/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Re: Review Request 44620: Documented how to make executors work with SSL.

2016-03-11 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44620/#review123130 --- Patch looks great! Reviews applied: [44620] Passed command:

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

2016-03-11 Thread Anurag Singh
> On March 3, 2016, 10:15 p.m., Joseph Wu wrote: > > src/master/contender.hpp, lines 17-18 > > > > > > This whole file seems like a pretty substantial change. I'd recommend > > pulling it out into a separate review

Re: Review Request 43630: Especially updated scheduler tests to use the updated MesosTest helpers.

2016-03-11 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43630/ --- (Updated March 11, 2016, 10:24 a.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 44190: Made `Bytes` usable in `constexpr` expressions [stout].

2016-03-11 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44190/ --- (Updated March 11, 2016, 6:30 p.m.) Review request for mesos and Ben Mahler.

Review Request 44718: Replaced `const string` master constants with `constexpr char[]`.

2016-03-11 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44718/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Review Request 44719: Avoided external linkage for slave constants.

2016-03-11 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44719/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Re: Review Request 44554: Added agent HTTP authentication to the docs.

2016-03-11 Thread Greg Mann
> On March 11, 2016, 3:10 p.m., Joerg Schad wrote: > > docs/authentication.md, line 12 > > > > > > s/certain/most (I can also change that while adding authn to master > > endpoints). I'll let you make this change

Re: Review Request 44678: Modified basic HTTP authenticator creator to accept realm.

2016-03-11 Thread Greg Mann
> On March 11, 2016, 2:52 p.m., Alexander Rojas wrote: > > src/authentication/http/basic_authenticator_factory.cpp, lines 70-71 > > > > > > Wouldn't it be better to just get a `Credentials` object? > > > >

Re: Review Request 44627: Removed a stale comment in the 1.0 mesos.proto.

2016-03-11 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44627/ --- (Updated March 11, 2016, 4 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44652: Omitted names of unused parameters in command executor.

2016-03-11 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44652/ --- (Updated March 11, 2016, 4 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 44626: Fixed whitespaces in mesos.proto.

2016-03-11 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44626/ --- (Updated March 11, 2016, 4 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44650: Omitted names of unused parameters in executor library.

2016-03-11 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44650/ --- (Updated March 11, 2016, 4 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 44629: Fixed ordering and inconsistencies in slave constants.

2016-03-11 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44629/ --- (Updated March 11, 2016, 4 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44628: Fixed a comment and ordering in mesos.proto.

2016-03-11 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44628/ --- (Updated March 11, 2016, 4 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44634: Updated the log message in the HTTP API executor library.

2016-03-11 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44634/ --- (Updated March 11, 2016, 4 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44635: Corrected the log message and variable name in executor library.

2016-03-11 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44635/ --- (Updated March 11, 2016, 4 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44703: Added Doxygen docs for basic HTTP authenticator.

2016-03-11 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44703/ --- (Updated March 11, 2016, 4:04 p.m.) Review request for mesos, Adam B,

Re: Review Request 44703: Added Doxygen docs for basic HTTP authenticator.

2016-03-11 Thread Greg Mann
> On March 11, 2016, 4:22 p.m., Alexander Rojas wrote: > > include/mesos/authentication/http/basic_authenticator_factory.hpp, lines > > 54-61 > > > > > > s/"value:"/"value":/ > > > > also, the contents of

Re: Review Request 44200: Add agent flags for specifying CNI plugin and config directories.

2016-03-11 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44200/#review123161 --- Fix it, then Ship it! src/slave/flags.hpp (lines 133 - 134)

Re: Review Request 44706: Implemented isolate() method of "network/cni" isolator.

2016-03-11 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44706/#review123150 --- Patch looks great! Reviews applied: [44004, 44200, 44549, 44555,

Re: Review Request 44710: Fixed placement of mock call expectation for fetcher cache tests.

2016-03-11 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44710/ --- (Updated March 11, 2016, 7:53 a.m.) Review request for mesos, Jie Yu, Jan

Review Request 44709: Allowed unknown flags in command and docker executors.

2016-03-11 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44709/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Re: Review Request 44661: Deprecated the `docker_stop_timeout` flag.

2016-03-11 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44661/ --- (Updated March 11, 2016, 4 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 44657: Used `KillPolicy` in command executor.

2016-03-11 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44657/ --- (Updated March 11, 2016, 4 p.m.) Review request for mesos, Ben Mahler and

Review Request 44707: Added validation for task's kill policy.

2016-03-11 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44707/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-4909

Re: Review Request 44653: Fixed formatting in command executor.

2016-03-11 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44653/ --- (Updated March 11, 2016, 4 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44549: Introduced a protobuf message "NetworkConfig".

2016-03-11 Thread Avinash sridharan
> On March 11, 2016, 3:43 p.m., Avinash sridharan wrote: > > Can you remove the dependency from 44200? - Avinash --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44549/#review123148

Re: Review Request 44660: Used `KillPolicy` and shutdown grace period in docker executor.

2016-03-11 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44660/ --- (Updated March 11, 2016, 4 p.m.) Review request for mesos, Ben Mahler, Gilbert

Re: Review Request 44659: Updated the comment about docker executor.

2016-03-11 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44659/ --- (Updated March 11, 2016, 4 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 44662: Added kill policies and shutdown grace period to the CHANGELOG.

2016-03-11 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44662/ --- (Updated March 11, 2016, 4 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44658: Removed unused signal escalation constant.

2016-03-11 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44658/ --- (Updated March 11, 2016, 4 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44655: Made `shutdown_grace_period` configurable in `ExecutorInfo`.

2016-03-11 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44655/ --- (Updated March 11, 2016, 4 p.m.) Review request for mesos and Gilbert Song.

Re: Review Request 44651: Fixed formatting in executor library.

2016-03-11 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44651/ --- (Updated March 11, 2016, 4 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44656: Introduced `KillPolicy` protobuf.

2016-03-11 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44656/ --- (Updated March 11, 2016, 4 p.m.) Review request for mesos and Ben Mahler.

Review Request 44708: Fixed signed / unsigned comparison in docker.cpp.

2016-03-11 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44708/ --- Review request for mesos, Ben Mahler and Timothy Chen. Repository: mesos

Re: Review Request 43763: Passed `Duration` as const reference in the executor library.

2016-03-11 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43763/ --- (Updated March 11, 2016, 4 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44630: Renamed `EXECUTOR_SHUTDOWN_GRACE_PERIOD` constant.

2016-03-11 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44630/ --- (Updated March 11, 2016, 4 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44631: Cleaned up the comment around executor shutdown event.

2016-03-11 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44631/ --- (Updated March 11, 2016, 4 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44553: Added authentication to agent HTTP endpoints.

2016-03-11 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44553/ --- (Updated March 11, 2016, 4:06 p.m.) Review request for mesos, Adam B,

Review Request 44711: Updated authentication.md after most endpoints enable authentication.

2016-03-11 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44711/ --- Review request for mesos, Adam B and Greg Mann. Bugs: MESOS-4844

Re: Review Request 44549: Introduced a protobuf message "NetworkConfig".

2016-03-11 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44549/#review123148 --- src/CMakeLists.txt (line 52)

Review Request 44710: Fixed placement of mock call expectation for fetcher cache tests.

2016-03-11 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44710/ --- Review request for mesos. Repository: mesos Description --- The

Re: Review Request 44554: Added agent HTTP authentication to the docs.

2016-03-11 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44554/ --- (Updated March 11, 2016, 3:52 p.m.) Review request for mesos, Adam B,

Re: Review Request 44555: Implemented the framework and create() method of "network/cni" isolator.

2016-03-11 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44555/#review123162 --- Ship it! Ship It! - Avinash sridharan On March 9, 2016,

Re: Review Request 44322: Implemented a generalized interface for the authorizer.

2016-03-11 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44322/ --- (Updated March 11, 2016, 4:57 p.m.) Review request for mesos, Adam B, Joerg

Re: Review Request 44621: Added tests for http endpoints with bad authentication.

2016-03-11 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44621/ --- (Updated March 11, 2016, 7:49 p.m.) Review request for mesos, Adam B and

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

2016-03-11 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44514/#review123200 --- src/slave/containerizer/mesos/isolators/network/cni.hpp (line

Re: Review Request 44721: Avoided external linkage for sched constants.

2016-03-11 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44721/#review123204 --- Patch looks great! Reviews applied: [44190, 44717, 44191, 44718,

Re: Review Request 44320: Moved authorizer.proto to acls.proto.

2016-03-11 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44320/#review123211 --- Ship it! Ship It! - Vinod Kone On March 11, 2016, 1:47

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

2016-03-11 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44287/#review122832 --- I think you should send an email to the user and dev mailing

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

2016-03-11 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44288/#review123196 --- Mostly nits here. include/mesos/v1/scheduler.hpp (line 39)

Re: Review Request 44545: Separated standalone and zookeeper classes.

2016-03-11 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44545/#review123201 --- src/master/contender.hpp (lines 17 - 18)

Re: Review Request 44544: Moved contender and detector definitions into separate directories.

2016-03-11 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44544/#review123199 --- Looking through the review chain, I don't see where you've

Review Request 44733: Added fault tolerance tests for the V1 API.

2016-03-11 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44733/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-4629

Review Request 44729: Close the connection upon framework teardown for HTTP frameworks.

2016-03-11 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44729/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-4629

Review Request 44727: Made `ExamplesTest.TestHTTPFramework` use the example http executor.

2016-03-11 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44727/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 44555: Implemented the framework and create() method of "network/cni" isolator.

2016-03-11 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44555/#review123163 --- Ship it! Ship It! - Avinash sridharan On March 9, 2016,

Re: Review Request 44045: Style fixes to `stout/include/Makefile.am`.

2016-03-11 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44045/#review123090 --- Ship it! - Joris Van Remoortere On Feb. 25, 2016, 10:28

Re: Review Request 44075: Windows: [1/3] Add platform-dependent `os::execlp`.

2016-03-11 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44075/#review123092 --- Fix it, then Ship it!

Re: Review Request 44456: Added Appc provisioner integration test.

2016-03-11 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44456/ --- (Updated March 11, 2016, 5:06 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 44046: Windows: Used `evutil_socket_t` typedef for sockets.

2016-03-11 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44046/#review123091 --- Ship it! - Joris Van Remoortere On Feb. 26, 2016, 4:09 p.m.,

Re: Review Request 44042: Windows: Fixed `UUID::random` and added utime/touch to stout/os.hpp.

2016-03-11 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44042/#review121558 --- Ship it! - Joris Van Remoortere On Feb. 25, 2016, 9:16 p.m.,

Re: Review Request 44555: Implemented the framework and create() method of "network/cni" isolator.

2016-03-11 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44555/#review123164 --- Ship it! - Avinash sridharan On March 9, 2016, 6:01 a.m.,

Re: Review Request 44709: Allowed unknown flags in command and docker executors.

2016-03-11 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44709/#review123165 --- Patch looks great! Reviews applied: [44626, 44627, 44628, 44629,

Re: Review Request 43956: Created base docker image for test suite.

2016-03-11 Thread Gilbert Song
> On March 10, 2016, 6:22 p.m., Jie Yu wrote: > > I think we should not use `Option` here, because in a docker manifest, it does not exist None case. If any field does not exist, it should be JSON::null. Entrypoint/cmd should be either JSON::null or a JSON::array `["a", "b", ...]`. So we

Re: Review Request 43708: Windows:[2/3] Added zlib compilation steps for Windows.

2016-03-11 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43708/#review123167 --- Ship it! - Joris Van Remoortere On March 11, 2016, 9:24

Re: Review Request 43707: Windows:[1/3] Added zlib definitions for Windows.

2016-03-11 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43707/#review123088 --- Ship it! - Joris Van Remoortere On Feb. 18, 2016, 5:25 a.m.,

Re: Review Request 44076: Windows: [2/3] Used `os::execlp` in launch.cpp.

2016-03-11 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44076/#review123159 --- Ship it! - Joris Van Remoortere On March 11, 2016, 9:24

Re: Review Request 44077: Windows:[3/3] Transitioned Windows `system` to use `os::execlp`.

2016-03-11 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44077/#review123093 --- Ship it! - Joris Van Remoortere On Feb. 26, 2016, 4:11 p.m.,

Re: Review Request 43709: Windows:[3/3] Enabled zlib compression tests.

2016-03-11 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43709/#review123089 --- Ship it! - Joris Van Remoortere On March 11, 2016, 9:24

Re: Review Request 44711: Updated authentication.md after most endpoints enable authentication.

2016-03-11 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44711/#review123168 --- Ship it! Ship It! - Greg Mann On March 11, 2016, 4:48 p.m.,

Re: Review Request 44045: Style fixes to `stout/include/Makefile.am`.

2016-03-11 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44045/ --- (Updated March 11, 2016, 5:18 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 43956: Created base docker image for test suite.

2016-03-11 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43956/#review123173 --- src/tests/containerizer/docker_archive.hpp (line 169)

Review Request 44721: Avoided external linkage for sched constants.

2016-03-11 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44721/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Re: Review Request 44078: Windows: Added Socket compatibility `#define`s to windows.hpp.

2016-03-11 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44078/ --- (Updated March 11, 2016, 6:39 p.m.) Review request for mesos, Alex Naparu,

Review Request 44722: Libprocess: Add `SOL_TCP` flag for Windows.

2016-03-11 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44722/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris

Re: Review Request 44620: Documented how to make executors work with SSL.

2016-03-11 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44620/#review123184 --- Fix it, then Ship it! Verified the paragraph shows up

Re: Review Request 44706: Implemented isolate() method of "network/cni" isolator.

2016-03-11 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44706/#review123181 --- src/slave/containerizer/mesos/isolators/network/cni.hpp (line

Re: Review Request 44553: Added authentication to agent HTTP endpoints.

2016-03-11 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44553/ --- (Updated March 11, 2016, 6:54 p.m.) Review request for mesos, Adam B,

Re: Review Request 44553: Added authentication to agent HTTP endpoints.

2016-03-11 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44553/ --- (Updated March 11, 2016, 6:56 p.m.) Review request for mesos, Adam B,

Re: Review Request 44549: Introduced a protobuf message "NetworkConfig".

2016-03-11 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44549/#review123190 --- src/slave/containerizer/mesos/isolators/network/spec.proto

Re: Review Request 44621: Added tests for http endpoints with bad authentication.

2016-03-11 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44621/#review123185 --- Fix it, then Ship it! src/tests/master_maintenance_tests.cpp

<    1   2   3   >