Review Request 51913: Ignored agent registrations with duplicate agent IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51913/ --- Review request for mesos, Benjamin Mahler and Vinod Kone. Repository: mesos

Re: Review Request 51864: Added logs for container state transitions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51864/ --- (Updated Sept. 15, 2016, 1:35 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 51865: Added validation for `ContainerInfo`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51865/ --- (Updated Sept. 15, 2016, 1:34 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 46187: Terminate when receiving the ACK of terminal status update.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46187/#review149057 --- Patch looks great! Reviews applied: [46187] Passed command:

Re: Review Request 51913: Ignored agent registrations with duplicate agent IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51913/ --- (Updated Sept. 15, 2016, 1:40 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 51785: [HBASE-16608] Merge for the segments in the compaction pipeline and simplifying the user interface for in-memory flush

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51785/#review149062 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 51864: Added logs for container state transitions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51864/#review149067 --- Patch looks great! Reviews applied: [51865, 51864] Passed

Re: Review Request 51885: Added a basic default executor implementation.

> On Sept. 14, 2016, 1:08 p.m., Guangya Liu wrote: > > src/launcher/default_executor.cpp, line 203 > > > > > > s/multiple task groups /multiple tasks in task group > > Vinod Kone wrote: > what anand reads

Re: Review Request 46187: Terminate when receiving the ACK of terminal status update.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46187/ --- (Updated Sept. 15, 2016, 4:57 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 45966: Offer shared resources to frameworks only if opted in.

> On Sept. 7, 2016, 10:09 p.m., Jiang Yan Xu wrote: > > Can we have a simple allocator test with two frameworks, one framework > > without the capability doesn't get allocated the shared resource and the > > other with the capability gets it? > > > > Could be in a follow up review. > >

Re: Review Request 45962: Added a persistent volume test framework for shared volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45962/ --- (Updated Sept. 15, 2016, 4:47 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45966: Offer shared resources to frameworks only if opted in.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45966/ --- (Updated Sept. 15, 2016, 4:45 p.m.) Review request for mesos and Jiang Yan Xu.

Review Request 51919: Added test to validate capability of SHARED_RESOURCES.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51919/ --- Review request for mesos and Jiang Yan Xu. Bugs: MESOS-4325

Re: Review Request 51885: Added a basic default executor implementation.

> On 九月 14, 2016, 1:08 p.m., Guangya Liu wrote: > > src/launcher/default_executor.cpp, line 203 > > > > > > s/multiple task groups /multiple tasks in task group > > Vinod Kone wrote: > what anand reads correct

Review Request 51921: Added backports for a potential double-close in libevent sockets.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51921/ --- Review request for mesos, Benjamin Bannier, Benjamin Mahler, Greg Mann, Artem

Re: Review Request 51879: Determine disk size when not specified in static resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51879/#review149033 --- The addition of `parseText` and `parseValidResources` feels

Re: Review Request 51866: Made the agent verify resource compatibility in checkpointResources().

> On Sept. 14, 2016, 4:53 p.m., Anindya Sinha wrote: > > src/slave/slave.cpp, line 5064 > > > > > > Why is it verified against the old flag? `Slave::recover()` is the last > > step in `Slave::initialize()` by

Re: Review Request 51921: Added backports for a potential double-close in libevent sockets.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51921/#review149085 --- Did you want to fold the minor fix into your original patch to

Re: Review Request 51921: Added backports for a potential double-close in libevent sockets.

> On Sept. 15, 2016, 10:56 a.m., Joris Van Remoortere wrote: > > Did you want to fold the minor fix into your original patch to backport? Do you mean MESOS-6152? (i.e. `s/fd/owned_fd`) I kept the cherry-picks un-squashed to retain history. - Joseph

Re: Review Request 51884: Removed tasks belonging to a task group from queued tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51884/ --- (Updated Sept. 15, 2016, 5:32 p.m.) Review request for mesos and Vinod Kone.

Review Request 51922: Rename Unified Containerizer to Universal Containerizer in docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51922/ --- Review request for mesos, Gilbert Song and Joseph Wu. Repository: mesos

Re: Review Request 51922: Rename Unified Containerizer to Universal Containerizer in docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51922/#review149082 --- Ship it! Ship It! - Gilbert Song On Sept. 15, 2016, 10:37

Re: Review Request 51913: Ignored agent registrations with duplicate agent IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51913/#review149083 --- Patch looks great! Reviews applied: [50235, 50416, 50417, 50418,

Re: Review Request 51922: Rename Unified Containerizer to Universal Containerizer in docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51922/#review149084 --- Ship it! Is it appropriate to retro-actively update the name

Re: Review Request 51866: Made the agent verify resource compatibility in checkpointResources().

> On Sept. 14, 2016, 11:53 p.m., Anindya Sinha wrote: > > src/slave/slave.cpp, line 5064 > > > > > > Why is it verified against the old flag? `Slave::recover()` is the last > > step in `Slave::initialize()` by

Re: Review Request 51921: Added backports for a potential double-close in libevent sockets.

> On Sept. 15, 2016, 5:56 p.m., Joris Van Remoortere wrote: > > Did you want to fold the minor fix into your original patch to backport? > > Joseph Wu wrote: > Do you mean MESOS-6152? (i.e. `s/fd/owned_fd`) > > I kept the cherry-picks un-squashed to retain history. Yeah. Maybe

Re: Review Request 51922: Rename Unified Containerizer to Universal Containerizer in docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51922/ --- (Updated Sept. 15, 2016, 5:37 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 51885: Added a basic default executor implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51885/ --- (Updated Sept. 15, 2016, 6:05 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 51871: Modified the `isolate` method to be nesting aware.

> On Sept. 13, 2016, 6:35 p.m., Joseph Wu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, line 818 > > > > > > Will these symlinks resolve correctly if the child has a different > > rootfs

Re: Review Request 51825: Updated the streaming function for ContainerID to be nesting aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51825/#review149116 --- src/common/type_utils.cpp (line 417)

Re: Review Request 51919: Added test to validate capability of SHARED_RESOURCES.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51919/#review149117 --- Patch looks great! Reviews applied: [45966, 51919] Passed

Re: Review Request 51886: Added tests for default executor.

> On Sept. 14, 2016, 1:41 p.m., Guangya Liu wrote: > > src/tests/default_executor_tests.cpp, lines 119-123 > > > > > > How about adding another task to the task group? > > Guangya Liu wrote: > ``` >

Re: Review Request 51886: Added tests for default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51886/ --- (Updated Sept. 15, 2016, 6:25 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 51736: Added fields `chain` and `excludeDevices` to `PortMapper`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51736/#review149110 ---

Re: Review Request 51825: Updated the streaming function for ContainerID to be nesting aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51825/ --- (Updated Sept. 15, 2016, 12:46 p.m.) Review request for mesos, Benjamin

Re: Review Request 51825: Updated the streaming function for ContainerID to be nesting aware.

> On Sept. 15, 2016, 12:22 p.m., Avinash sridharan wrote: > > src/common/type_utils.cpp, line 417 > > > > > > Can we use "." instead of "/" as the delimiter. Reason being that in > > `network/cni` isolator we plan

Re: Review Request 51825: Updated the streaming function for ContainerID to be nesting aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51825/#review149120 --- Ship it! Ship It! - Avinash sridharan On Sept. 15, 2016,

Re: Review Request 51921: Added backports for a potential double-close in libevent sockets.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51921/#review149154 --- Patch looks great! Reviews applied: [51921] Passed command:

Re: Review Request 51909: Added benchmarks for new registry operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51909/#review149159 --- Ship it! Ship It! - Vinod Kone On Sept. 15, 2016, 11:13

Review Request 51942: Removed scalars() API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51942/ --- Review request for mesos, Benjamin Mahler, Neil Conway, and Jiang Yan Xu.

Re: Review Request 51919: Added test to validate capability of SHARED_RESOURCES.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51919/#review149128 --- Fix it, then Ship it!

Re: Review Request 50959: Added appc fetcher plugin to use rkt tool.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50959/#review149113 --- src/Makefile.am (line 854)

Re: Review Request 51942: Removed scalars() API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51942/#review149165 --- Patch looks great! Reviews applied: [51942] Passed command:

Re: Review Request 51919: Added test to validate capability of SHARED_RESOURCES.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51919/ --- (Updated Sept. 16, 2016, 4:14 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 51825: Updated the streaming function for ContainerID to be nesting aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51825/#review149158 --- Bad patch! Reviews applied: [51825, 51816, 51780, 51779, 51778,

Re: Review Request 51683: Avoided resource validation when flatten resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51683/#review148995 --- Fix it, then Ship it! src/cli/execute.cpp (line 379)

Re: Review Request 51375: Introduced MockRegistrar.

> On Sept. 14, 2016, 8:31 p.m., Vinod Kone wrote: > > src/tests/cluster.hpp, line 137 > > > > > > Can you add a NOTE here regarding why you declared it here? You can use > > most of the text from your review

Re: Review Request 51375: Introduced MockRegistrar.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51375/ --- (Updated Sept. 15, 2016, 7:36 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 51905: Added logging when sending a queued task group to the executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51905/#review149029 --- Patch looks great! Reviews applied: [51904, 51905] Passed

Re: Review Request 51922: Rename Unified Containerizer to Universal Containerizer in docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51922/#review149130 --- Ship it! Ship It! - Vinod Kone On Sept. 15, 2016, 5:37

Re: Review Request 46187: Terminate when receiving the ACK of terminal status update.

> On Sept. 6, 2016, 11:33 a.m., Vinod Kone wrote: > > > > Vinod Kone wrote: > also, can you add a test for this? > > Qian Zhang wrote: > Sure, I can add a test. I am just wondering how to use a test to verify > the logic we added in this patch, maybe we can just add a test to launch a

Re: Review Request 46187: Terminate when receiving the ACK of terminal status update.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46187/#review149146 --- Ship it! Ship It! - Vinod Kone On Sept. 15, 2016, 8:57

Re: Review Request 46187: Terminate when receiving the ACK of terminal status update.

> On Sept. 6, 2016, 11:33 a.m., Vinod Kone wrote: > > src/launcher/executor.cpp, line 682 > > > > > > hmm. what's the guarantee that an HTTP based executor receives an ACK > > within a second? what if the agent is

Re: Review Request 51905: Added logging when sending a queued task group to the executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51905/#review149144 --- Ship it! Ship It! - Vinod Kone On Sept. 15, 2016, 4:34

Re: Review Request 51904: Ensured that queued task groups killed before launch are cleaned up.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51904/#review149143 --- Fix it, then Ship it! src/slave/slave.cpp (line 6579)

Re: Review Request 51922: Rename Unified Containerizer to Universal Containerizer in docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51922/#review149137 --- Patch looks great! Reviews applied: [51922] Passed command:

Re: Review Request 51877: Updated comments for += and -= `Resource_` object.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51877/ --- (Updated 九月 15, 2016, 9:13 a.m.) Review request for mesos, Benjamin Mahler and

Re: Review Request 51683: Avoided resource validation when flatten resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51683/#review149040 --- Patch looks great! Reviews applied: [51683] Passed command:

Review Request 51909: Added benchmarks for new registry operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51909/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 51909: Added benchmarks for new registry operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51909/ --- (Updated Sept. 15, 2016, 11:13 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 51683: Avoided resource validation when flatten resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51683/ --- (Updated 九月 15, 2016, 8:48 a.m.) Review request for mesos, Benjamin Mahler and

Re: Review Request 51785: [HBASE-16608] Merge for the segments in the compaction pipeline and simplifying the user interface for in-memory flush

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51785/ --- (Updated Sept. 15, 2016, 12:03 p.m.) Review request for mesos. Repository:

Re: Review Request 51877: Updated comments for += and -= `Resource_` object.

> On 九月 14, 2016, 6 p.m., Jiang Yan Xu wrote: > > I didn't add additional comments because the conversion is intentionally > > implicit. I guess we can clarify further by saying "Note that `Resource` > > objects are implicitly converted to `Resource_`" here but this is true > > elsewhere in

Re: Review Request 46187: Terminate when receiving the ACK of terminal status update.

> On Sept. 6, 2016, 7:33 p.m., Vinod Kone wrote: > > src/launcher/executor.cpp, line 682 > > > > > > hmm. what's the guarantee that an HTTP based executor receives an ACK > > within a second? what if the agent is

Re: Review Request 51877: Updated comments for += and -= `Resource_` object.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51877/#review149048 --- Patch looks great! Reviews applied: [51877] Passed command: