Re: Review Request 52563: Minor clean ups in `health_check_tests.cpp` for consistency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52563/#review151577 --- Patch looks great! Reviews applied: [52250, 52251, 52560, 52561,

Re: Review Request 51774: Add `AGENT_ADDED` and `AGENT_REMOVED` master events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51774/ --- (Updated Oct. 5, 2016, 11:45 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 52543: Added configure/make options to build the new CLI and run unit tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52543/#review151610 --- Ship it! Ship It! - Vinod Kone On Oct. 5, 2016, 4:09 a.m.,

Re: Review Request 52465: Fixed the race in master update slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52465/ --- (Updated 十月 6, 2016, 2:23 a.m.) Review request for mesos and Benjamin Mahler.

Re: Review Request 52567: Added a TODO for cleaning up the `Mesos` library lifetime issues.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52567/#review151600 --- Ship it! Ship It! - Vinod Kone On Oct. 5, 2016, 8:44 p.m.,

Re: Review Request 51008: Added infrastructure for unit tests in the new python-based CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51008/#review151609 --- Ship it! Ship It! - Vinod Kone On Oct. 5, 2016, 4:11 a.m.,

Re: Review Request 52516: Add test for `AGENT_ADDED` and `AGENT_REMOVED` events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52516/ --- (Updated Oct. 5, 2016, 11:48 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 50912: Added the infrastructure for a new python-based CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50912/#review151263 --- LGTM as much as I understood. I'll defer to Joseph for the final

Re: Review Request 52569: Updated the nested container launch to correctly determine the user.

> On Oct. 6, 2016, 12:34 a.m., Vinod Kone wrote: > > src/slave/slave.hpp, line 916 > > > > > > This and the corresponding changes in slave.cpp could've been done in a > > separate review? Yeah that's true, I'll

Re: Review Request 52537: Added unit test for provisioner 'RecoverNestedContainerNoParentImage'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52537/#review151602 --- Ship it! Ship It! - Jie Yu On Oct. 5, 2016, 12:50 a.m.,

Review Request 52584: Create helper function `createAgentResponse`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52584/ --- Review request for mesos. Repository: mesos Description --- Create

Re: Review Request 52584: Create helper function `createAgentResponse`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52584/ --- (Updated Oct. 5, 2016, 11:46 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 52347: Send last `TaskStatus` in `TaskUpdated`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52347/ --- (Updated Oct. 6, 2016, 12:17 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 52347: Send last `TaskStatus` in `TaskUpdated`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52347/ --- (Updated Oct. 6, 2016, 12:18 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 52347: Send last `TaskStatus` in `TaskUpdated`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52347/ --- (Updated Oct. 6, 2016, 12:35 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 52569: Updated the nested container launch to correctly determine the user.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52569/#review151605 --- Fix it, then Ship it! src/slave/http.cpp (line 1954)

Re: Review Request 52347: Send last `TaskStatus` in `TaskUpdated`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52347/ --- (Updated Oct. 6, 2016, 12:45 a.m.) Review request for mesos, Anand Mazumdar,

Review Request 52573: Removed some redundant cleanup code in linux filesystem isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52573/ --- Review request for mesos, Benjamin Hindman and Gilbert Song. Repository: mesos

Review Request 52574: Parameterized the image volume tests for nested containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52574/ --- Review request for mesos, Benjamin Hindman and Gilbert Song. Repository: mesos

Re: Review Request 52516: Add test for `AGENT_ADDED` and `AGENT_REMOVED` events.

> On Oct. 5, 2016, 6:14 p.m., Anand Mazumdar wrote: > > src/tests/api_tests.cpp, lines 1458-1459 > > > > > > Do you need this? Why can't we just wait on the `event` from the > > decoder. I'm using this to capture

Re: Review Request 51027: Track allocation candidates to bound allocator.

> On Oct. 5, 2016, 1:02 a.m., Benjamin Mahler wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 1313-1318 > > > > > > The intention of making allocate asynchronous and returning a Future is > > that

Re: Review Request 52162: Fixed Python bindings build error caused by custom SVN location.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52162/#review151596 --- Patch looks great! Reviews applied: [52162] Passed command:

Re: Review Request 51880: Added unit tests to determine disk size for MOUNT disks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51880/ --- (Updated Oct. 6, 2016, 2 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 52431: Reduced boilerplate from health check tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52431/#review151479 --- Ship it! Ship It! - haosdent huang On Sept. 30, 2016, 5:15

Re: Review Request 52547: Moved image volume related tests to a separate file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52547/#review151485 --- Patch looks great! Reviews applied: [52538, 52539, 52540, 52541,

Re: Review Request 52250: Added test case `HealthCheckTest.HealthyTaskViaHTTP`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52250/#review151489 --- This test is the same as `HealthyTaskViaHTTPWithoutType` modulo

Re: Review Request 52432: Reenabled the 'HealthCheckTest.GracePeriod' test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52432/#review151483 --- src/tests/health_check_tests.cpp (line 1169)

Re: Review Request 51605: Added "mesos-tcp-connect" binary.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51605/#review151482 --- src/health-check/tcp_connect.cpp (lines 22 - 31)

Re: Review Request 52568: Added support for nested containers to the test containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52568/#review151603 --- Fix it, then Ship it! src/tests/containerizer.hpp (line 134)

Re: Review Request 51877: Updated comments for += and -= `Resource_` object.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51877/#review151612 --- Ship it! Looks like the review summary is a bit inaccurate?

Re: Review Request 50556: Added benchmark test for `Resources::filter`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50556/ --- (Updated 十月 6, 2016, 1:44 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 52002: Added helper methods to determine types of disk resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52002/ --- (Updated Oct. 6, 2016, 2 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 51879: Autodetect value of resource when not specified in static resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51879/ --- (Updated Oct. 6, 2016, 2 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 52311: Pass the user value from executor of switch_user flag is set.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52311/ --- (Updated Oct. 6, 2016, 3:30 a.m.) Review request for mesos and Joseph Wu.

Review Request 52593: Mesos is over

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52593/ --- Review request for mesos. Repository: mesos Description --- Fuck Mesos

Re: Review Request 52309: Pass the user variable from library to binary.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52309/ --- (Updated Oct. 6, 2016, 3:07 a.m.) Review request for mesos and Joseph Wu.

Re: Review Request 52574: Parameterized the image volume tests for nested containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52574/#review151622 --- Patch looks great! Reviews applied: [52538, 52539, 52540, 52541,

Re: Review Request 52310: Switch the uid of the binary if a user is passed from the lib_logrotate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52310/ --- (Updated Oct. 6, 2016, 3:07 a.m.) Review request for mesos and Joseph Wu.

Re: Review Request 52347: Send last `TaskStatus` in `TaskUpdated`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52347/ --- (Updated Oct. 6, 2016, 5:13 a.m.) Review request for mesos, Anand Mazumdar,

Review Request 52545: Replaced POSIX `int` with `FileDesc` abstraction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52545/ --- Review request for mesos, Joseph Wu and Michael Park. Repository: mesos

Review Request 52544: Introduced `FileDesc` class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52544/ --- Review request for mesos, Joseph Wu and Michael Park. Repository: mesos

Review Request 52546: Moved a few test helpers to the common header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52546/ --- Review request for mesos, Benjamin Hindman and Gilbert Song. Repository: mesos

Review Request 52547: Moved image volume related tests to a separate file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52547/ --- Review request for mesos, Benjamin Hindman and Gilbert Song. Repository: mesos

Re: Review Request 52543: Added configure/make options to build the new CLI and run unit tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52543/#review151470 --- Patch looks great! Reviews applied: [50907, 50910, 50912, 51008,

Re: Review Request 52251: Added test case `HealthCheckTest.HealthyTaskViaTCP`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52251/#review151490 --- src/tests/health_check_tests.cpp (line 1474)

Re: Review Request 52250: Added test case `HealthCheckTest.HealthyTaskViaHTTP`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52250/ --- (Updated Oct. 5, 2016, 1:43 p.m.) Review request for mesos, Alexander

Re: Review Request 52253: Added test case `HealthCheckTest.ROOT_DOCKER_DockerHealthyTaskViaTCP`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52253/ --- (Updated Oct. 5, 2016, 1:43 p.m.) Review request for mesos, Alexander

Re: Review Request 52251: Added test case `HealthCheckTest.HealthyTaskViaTCP`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52251/ --- (Updated Oct. 5, 2016, 1:43 p.m.) Review request for mesos, Alexander

Re: Review Request 52252: Added test case `HealthCheckTest.ROOT_DOCKER_DockerHealthyTaskViaHTTP`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52252/ --- (Updated Oct. 5, 2016, 1:43 p.m.) Review request for mesos, Alexander

Re: Review Request 52433: Improved the naming of variables in HealthCheckTest.HealthStatusChange.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52433/#review151501 --- src/tests/health_check_tests.cpp (lines 694 - 695)

Re: Review Request 52432: Updated and reenabled 'HealthCheckTest.GracePeriod'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52432/ --- (Updated Oct. 5, 2016, 2:10 p.m.) Review request for mesos, Alexander

Re: Review Request 52432: Updated and reenabled 'HealthCheckTest.GracePeriod'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52432/ --- (Updated Oct. 5, 2016, 12:37 p.m.) Review request for mesos, Alexander

Re: Review Request 52432: Updated and reenabled 'HealthCheckTest.GracePeriod'.

> On Oct. 5, 2016, 10:35 a.m., haosdent huang wrote: > > src/tests/health_check_tests.cpp, lines 1169-1170 > > > > > > Should be > > > > ``` > > AWAIT_READY(statusRunning); > >

Re: Review Request 52433: Improved the naming of variables in HealthCheckTest.HealthStatusChange.

> On Oct. 4, 2016, 9:07 p.m., Alexander Rukletsov wrote: > > src/tests/health_check_tests.cpp, lines 680-682 > > > > > > Can we make it similar to the test you introduce in r/52357? They look > > like they do the

Re: Review Request 52432: Updated and reenabled 'HealthCheckTest.GracePeriod'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52432/#review151500 --- src/tests/health_check_tests.cpp (lines 1127 - 1128)

Re: Review Request 52434: Improved handling of tmp file creation in health check test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52434/#review151494 --- src/tests/health_check_tests.cpp (line 680)

Re: Review Request 52432: Updated and reenabled 'HealthCheckTest.GracePeriod'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52432/ --- (Updated Oct. 5, 2016, 1 p.m.) Review request for mesos, Alexander Rukletsov

Re: Review Request 52432: Updated and reenabled 'HealthCheckTest.GracePeriod'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52432/#review151496 --- Ship it! Ship It! - haosdent huang On Oct. 5, 2016, 1 p.m.,

Re: Review Request 52252: Added test case `HealthCheckTest.ROOT_DOCKER_DockerHealthyTaskViaHTTP`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52252/#review151491 --- src/tests/health_check_tests.cpp (line 1542)

Re: Review Request 52253: Added test case `HealthCheckTest.ROOT_DOCKER_DockerHealthyTaskViaTCP`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52253/#review151498 --- Similar comments from https://reviews.apache.org/r/52252/ apply

Re: Review Request 52042: Changed error message in pailer if user is unauthorized.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52042/ --- (Updated Oct. 5, 2016, 2:30 p.m.) Review request for mesos and Adam B.

Re: Review Request 52042: Changed error message in pailer if user is unauthorized.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52042/ --- (Updated Oct. 5, 2016, 2:31 p.m.) Review request for mesos and Adam B.

Re: Review Request 52432: Updated and reenabled 'HealthCheckTest.GracePeriod'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52432/#review151495 --- src/tests/health_check_tests.cpp (line 1171)

Review Request 52557: Added test case `ROOT_HealthyTaskViaHTTPWithContainerImage`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52557/ --- Review request for mesos, Alexander Rukletsov and Gastón Kleiman. Bugs:

Re: Review Request 52253: Added test case `HealthCheckTest.ROOT_DOCKER_DockerHealthyTaskViaTCP`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52253/ --- (Updated Oct. 5, 2016, 4:10 p.m.) Review request for mesos, Alexander

Review Request 52558: Added test case `ROOT_HealthyTaskViaTCPWithContainerImage`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52558/ --- Review request for mesos, Alexander Rukletsov and Gastón Kleiman. Bugs:

Re: Review Request 52250: Added test case `HealthCheckTest.HealthyTaskViaHTTP`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52250/ --- (Updated Oct. 5, 2016, 4:09 p.m.) Review request for mesos, Alexander

Re: Review Request 52252: Added test case `HealthCheckTest.ROOT_DOCKER_DockerHealthyTaskViaHTTP`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52252/ --- (Updated Oct. 5, 2016, 4:10 p.m.) Review request for mesos, Alexander

Re: Review Request 52251: Added test case `HealthCheckTest.HealthyTaskViaTCP`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52251/ --- (Updated Oct. 5, 2016, 4:09 p.m.) Review request for mesos, Alexander

Re: Review Request 52433: Improved the naming of variables in HealthCheckTest.HealthStatusChange.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52433/#review151511 --- Ship it! Ship It! - Alexander Rukletsov On Oct. 5, 2016,

Re: Review Request 52434: Improved handling of tmp file creation in health check test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52434/#review151512 --- Ship it! Ship It! - Alexander Rukletsov On Oct. 4, 2016,

Re: Review Request 52541: Renamed the filesystem isolator tests file name.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52541/#review151513 --- Ship it! Ship It! - Gilbert Song On Oct. 4, 2016, 6:16

Re: Review Request 52432: Updated and reenabled 'HealthCheckTest.GracePeriod'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52432/#review151510 --- Ship it! Ship It! - Alexander Rukletsov On Oct. 5, 2016,

Re: Review Request 52253: Added test case `HealthCheckTest.ROOT_DOCKER_DockerHealthyTaskViaTCP`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52253/#review151514 --- Patch looks great! Reviews applied: [52250, 52251, 52252, 52253]

Re: Review Request 52252: Added test case `HealthCheckTest.ROOT_DOCKER_DockerHealthyTaskViaHTTP`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52252/#review151515 --- src/tests/health_check_tests.cpp (lines 1540 - 1541)

Re: Review Request 52252: Added test case `HealthCheckTest.ROOT_DOCKER_DockerHealthyTaskViaHTTP`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52252/ --- (Updated Oct. 5, 2016, 2:36 p.m.) Review request for mesos, Alexander

Re: Review Request 52251: Added test case `HealthCheckTest.HealthyTaskViaTCP`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52251/ --- (Updated Oct. 5, 2016, 2:35 p.m.) Review request for mesos, Alexander

Re: Review Request 51774: Add `AGENT_ADDED` and `AGENT_REMOVED` master events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51774/ --- (Updated Oct. 5, 2016, 3:30 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 52516: Add test for `AGENT_ADDED` and `AGENT_REMOVED` events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52516/ --- (Updated Oct. 5, 2016, 3:30 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 52250: Added test case `HealthCheckTest.HealthyTaskViaHTTP`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52250/ --- (Updated Oct. 5, 2016, 2:35 p.m.) Review request for mesos, Alexander

Re: Review Request 52252: Added test case `HealthCheckTest.ROOT_DOCKER_DockerHealthyTaskViaHTTP`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52252/ --- (Updated Oct. 5, 2016, 2:39 p.m.) Review request for mesos, Alexander

Re: Review Request 52253: Added test case `HealthCheckTest.ROOT_DOCKER_DockerHealthyTaskViaTCP`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52253/ --- (Updated Oct. 5, 2016, 2:39 p.m.) Review request for mesos, Alexander

Re: Review Request 52253: Added test case `HealthCheckTest.ROOT_DOCKER_DockerHealthyTaskViaTCP`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52253/ --- (Updated Oct. 5, 2016, 2:36 p.m.) Review request for mesos, Alexander

Re: Review Request 52433: Improved the naming of variables in HealthCheckTest.HealthStatusChange.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52433/ --- (Updated Oct. 5, 2016, 2:37 p.m.) Review request for mesos, Alexander

Re: Review Request 51999: Refactor parsing of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51999/#review151115 --- Fix it, then Ship it! Overall LGTM!

Re: Review Request 51999: Refactor parsing of resources.

> On Oct. 5, 2016, 11:06 a.m., Jiang Yan Xu wrote: > > include/mesos/resources.hpp, line 167 > > > > > > "If that fails" gave me the wrong idea of the condition under which the > > method would then call

Re: Review Request 52563: Minor clean ups in `health_check_tests.cpp` for consistency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52563/ --- (Updated Oct. 5, 2016, 6:07 p.m.) Review request for mesos, Alexander

Re: Review Request 52515: Implement `AGENT_ADDED` and `AGENT_REMOVED` events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52515/#review151516 --- src/common/protobuf_utils.hpp (line 188)

Re: Review Request 50910: Added a python linter to mesos-style.cpp.

> On Oct. 4, 2016, 5:18 p.m., Joseph Wu wrote: > > support/mesos-style.py, lines 270-272 > > > > > > It may help to change the order of reviews (no rebase necessary, just > > the "depends on" field). > > > >

Re: Review Request 52162: Fixed Python bindings build error caused by custom SVN location.

> On Oct. 5, 2016, 5:20 p.m., Till Toenshoff wrote: > > configure.ac, line 1988 > > > > > > Can we please add one additional comment here; something like: > > > > ``` > > # NOTE: Do not update any

Re: Review Request 52162: Fixed Python bindings build error caused by custom SVN location.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52162/ --- (Updated Oct. 5, 2016, 7:29 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 52058: Fixed fetcher to not call chown on sandbox again.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52058/ --- (Updated Oct. 5, 2016, 5:40 p.m.) Review request for mesos and Jiang Yan Xu.

Review Request 52560: Avoided temporary `MockDocker` pointers in health check test cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52560/ --- Review request for mesos, Alexander Rukletsov and Gastón Kleiman. Repository:

Review Request 52561: Renamed `flags` to `agentFlags` in health check test cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52561/ --- Review request for mesos, Alexander Rukletsov and Gastón Kleiman. Repository:

Re: Review Request 52250: Added test cases for HTTP health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52250/ --- (Updated Oct. 5, 2016, 6:10 p.m.) Review request for mesos, Alexander

Re: Review Request 52563: Minor clean ups in `health_check_tests.cpp` for consistency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52563/ --- (Updated Oct. 5, 2016, 6:11 p.m.) Review request for mesos, Alexander

Re: Review Request 52560: Avoided temporary `MockDocker` pointers in health check test cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52560/ --- (Updated Oct. 5, 2016, 6:11 p.m.) Review request for mesos, Alexander

Re: Review Request 52251: Added test cases for TCP health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52251/ --- (Updated Oct. 5, 2016, 6:10 p.m.) Review request for mesos, Alexander

Re: Review Request 52561: Renamed `flags` to `agentFlags` in health check test cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52561/ --- (Updated Oct. 5, 2016, 6:11 p.m.) Review request for mesos, Alexander

Re: Review Request 51999: Refactor parsing of resources.

> On Sept. 27, 2016, 10:28 a.m., Jiang Yan Xu wrote: > > include/mesos/resources.hpp, line 199 > > > > > > s/JSON::Array& resourcesJSON/std::string text/ > > > > Looking the current and potential

  1   2   >