Re: Review Request 53115: Implemented handling AUFS whiteouts for copy backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53115/ --- (Updated Nov. 1, 2016, 2:44 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 53116: Removed `ProvisionerProcess::__provision()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53116/ --- (Updated Nov. 1, 2016, 2:45 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 52587: Allow CREATE of shared volumes based on capability of framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52587/#review154378 --- Fix it, then Ship it! src/master/validation.hpp (line 197)

Re: Review Request 53053: Divided utils.hpp to utils.hpp and utils.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53053/ --- (Updated Nov. 1, 2016, 2:08 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 50599: Assigned Nvidia GPU devices to docker container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50599/#review154372 --- src/slave/containerizer/docker.cpp (lines 705 - 707)

Re: Review Request 50599: Assigned Nvidia GPU devices to docker container.

> On 十月 26, 2016, 3:22 a.m., Kevin Klues wrote: > > src/slave/containerizer/docker.cpp, line 691 > > > > > > This is OK since we do this the same in other functions for this class, > > but we should really wrap

Re: Review Request 50127: Added DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50127/ --- (Updated Nov. 1, 2016, 9:12 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 52735: Removed TODO message for docker killing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52735/ --- (Updated Nov. 1, 2016, 9:12 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50841/ --- (Updated Nov. 1, 2016, 6:10 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50599: Assigned Nvidia GPU devices to docker container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50599/ --- (Updated Nov. 1, 2016, 6:11 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50128: Added helper function to 'Docker::Device'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/ --- (Updated Nov. 1, 2016, 6:10 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50123: Added GPU scheduler for docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50123/ --- (Updated Nov. 1, 2016, 6:10 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 53127: Added the test `ProvisionerDockerWhiteoutTest`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53127/ --- (Updated Nov. 1, 2016, 2:58 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 53324: Add a column for FrameworkID when displaying tasks in the WebUI

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53324/#review154386 --- Patch looks great! Reviews applied: [53324] Passed command:

Re: Review Request 50125: Added mesos-docker-executor support for devices control.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50125/ --- (Updated Nov. 1, 2016, 6:11 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50127: Added DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50127/ --- (Updated Nov. 1, 2016, 6:12 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50947: Removed isolator flag 'gpu/nvidia' for docker containerizer using GPU.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50947/ --- (Updated Nov. 1, 2016, 6:12 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 52735: Removed TODO message for docker killing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52735/ --- (Updated Nov. 1, 2016, 6:13 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 53115: Implemented handling AUFS whiteouts for copy backend.

> On Oct. 28, 2016, 10:03 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/provisioner/backends/copy.cpp, line 133 > > > > > > I am not sure if we need to pass in 'image' to backend. If we added OCI > >

Re: Review Request 53161: Implemented the conversion from AUFS whiteouts to OverlayFS whiteouts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53161/ --- (Updated Nov. 1, 2016, 2:42 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 50125: Added mesos-docker-executor support for devices control.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50125/ --- (Updated Nov. 1, 2016, 9:11 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50947: Removed isolator flag 'gpu/nvidia' for docker containerizer using GPU.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50947/ --- (Updated Nov. 1, 2016, 9:11 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50128: Added helper function to 'Docker::Device'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/ --- (Updated Nov. 1, 2016, 9:11 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50599: Assigned Nvidia GPU devices to docker container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50599/ --- (Updated Nov. 1, 2016, 9:11 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50125: Added mesos-docker-executor support for devices control.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50125/#review154379 --- src/docker/docker.hpp (lines 71 - 96)

Re: Review Request 52997: Improve Socket::connect error message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52997/#review154382 --- Patch looks great! Reviews applied: [52997] Passed command:

Re: Review Request 52877: Fixed wrong float serialization in JSON in locales different from C.

> On Oct. 15, 2016, 1:23 a.m., Joris Van Remoortere wrote: > > I have a feeling that if you kept around a stringstream with the local set > > your benchmarks would look rather different. > > I also suggest using callgrind to get the instruction count / # of library > > calls made. > >

Re: Review Request 52877: Fixed wrong float serialization in JSON in locales different from C.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52877/ --- (Updated Nov. 1, 2016, 1:27 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 52735: Removed TODO message for docker killing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52735/#review154390 --- Patch looks great! Reviews applied: [51425, 50123, 50841, 50128,

Re: Review Request 53137: Fix build option argument handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53137/#review154394 --- Fix it, then Ship it! Thanks for this series, really looking

Re: Review Request 53138: Fix build option argument handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53138/#review154395 --- Ship it! - Benjamin Bannier On Oct. 31, 2016, 11:27 p.m.,

Re: Review Request 53136: Emit the build options at the end of configure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53136/#review154393 --- Ship it! configure.ac (line 2215)

Re: Review Request 52877: Fixed wrong float serialization in JSON in locales different from C.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52877/#review154397 --- 3rdparty/stout/include/stout/json.hpp (lines 680 - 681)

Re: Review Request 52879: Cleaned up the way in which the executors load configuration options.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52879/ --- (Updated Nov. 1, 2016, 2:06 p.m.) Review request for mesos, Alexander

Re: Review Request 52877: Fixed wrong float serialization in JSON in locales different from C.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52877/#review154402 --- Patch looks great! Reviews applied: [52877] Passed command:

Re: Review Request 52877: Fixed wrong float serialization in JSON in locales different from C.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52877/ --- (Updated Nov. 1, 2016, 3:45 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 50128: Added helper function to 'Docker::Device'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/#review154406 --- src/docker/docker.hpp (line 313)

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50841/#review154404 --- Fix it, then Ship it! Ship It!

Re: Review Request 50125: Added mesos-docker-executor support for devices control.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50125/#review154408 --- Fix it, then Ship it! Ship It! src/docker/executor.cpp (line

Re: Review Request 52877: Fixed wrong float serialization in JSON in locales different from C.

> On Nov. 1, 2016, 2:43 p.m., Benjamin Bannier wrote: > > 3rdparty/stout/include/stout/json.hpp, lines 680-681 > > > > > > I believe we can drop the `static` here as these variables should have > > internal linkage

Re: Review Request 50127: Added DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50127/#review154410 --- src/tests/containerizer/docker_containerizer_tests.cpp (line

Re: Review Request 50599: Assigned Nvidia GPU devices to docker container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50599/#review154407 --- Fix it, then Ship it! Ship It!

Re: Review Request 50128: Added helper function to 'Docker::Device'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/#review154409 --- src/docker/docker.cpp (line 756)

Re: Review Request 53137: Fix Mesos build option argument handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53137/ --- (Updated Nov. 1, 2016, 4:24 p.m.) Review request for mesos and Kapil Arya.

Re: Review Request 53138: Fix libprocess build option argument handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53138/ --- (Updated Nov. 1, 2016, 4:24 p.m.) Review request for mesos and Kapil Arya.

Re: Review Request 53136: Emit the build options at the end of configure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53136/ --- (Updated Nov. 1, 2016, 4:24 p.m.) Review request for mesos and Kapil Arya.

Re: Review Request 53138: Fix libprocess build option argument handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53138/#review154414 --- Patch looks great! Reviews applied: [53136, 53137, 53138]

Review Request 53341: Fix stout build option argument handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53341/ --- Review request for mesos, Benjamin Bannier and Kapil Arya. Bugs: MESOS-2537

Re: Review Request 52639: Added test for `recovered` AgentID and `AGENT_ADDED` after reregister.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52639/ --- (Updated Nov. 1, 2016, 5:30 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 53127: Added the test `ProvisionerDockerWhiteoutTest`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53127/#review154418 --- src/tests/containerizer/provisioner_docker_tests.cpp (lines 689

Re: Review Request 53095: Make `slaves.recovered` in master a hashmap.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53095/ --- (Updated Nov. 1, 2016, 5:28 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 52587: Allow CREATE of shared volumes based on capability of framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52587/ --- (Updated Nov. 1, 2016, 4:54 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 53161: Implemented the conversion from AUFS whiteouts to OverlayFS whiteouts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53161/#review154416 --- src/slave/containerizer/mesos/provisioner/docker/store.cpp

Re: Review Request 52645: Harden Mesos

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52645/ --- (Updated Nov. 1, 2016, 7:37 p.m.) Review request for mesos, James Peach,

Re: Review Request 52645: Harden Mesos

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52645/ --- (Updated Nov. 1, 2016, 7:06 p.m.) Review request for mesos, James Peach,

Re: Review Request 53253: Fixed the bug when search base hierarchy in `cgroups_tests.cpp`.

> On Oct. 31, 2016, 6:20 p.m., Jiang Yan Xu wrote: > > We unfortunately have to copy the cleanup code from > > `ContainerizerTest::SetUp()` to here. FWIW the > > test fixture originally was written with co-mounted subsystems in a single > > hierarchy (hence *Any*), later altered when Mesos

Re: Review Request 53341: Fix stout build option argument handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53341/#review154453 --- Patch looks great! Reviews applied: [53136, 53137, 53138, 53341]

Re: Review Request 52877: Fixed wrong float serialization in JSON in locales different from C.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52877/#review154435 --- Patch looks great! Reviews applied: [52877] Passed command:

Re: Review Request 53285: Show the leader information in WebUI.

> On Oct. 31, 2016, 10:47 p.m., Jiang Yan Xu wrote: > > src/webui/master/static/home.html, line 26 > > > > > > Since `hostname` is deprecated, use `address.hostname`? If that's not > > available, fall back to the

Re: Review Request 52695: Harden libprocess

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52695/ --- (Updated Nov. 1, 2016, 7:12 p.m.) Review request for mesos, James Peach,

Re: Review Request 53305: Add new param user to logrotate's prepare function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53305/#review154461 --- src/slave/container_loggers/lib_logrotate.cpp (line 167)

Re: Review Request 52695: Harden libprocess

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52695/#review154463 --- Ship it! Ship It! - James Peach On Nov. 1, 2016, 7:12 p.m.,

Re: Review Request 53324: Add a column for FrameworkID when displaying tasks in the WebUI

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53324/#review154471 --- Fix it, then Ship it! Checked out the tables on a local

Re: Review Request 53124: Add documentation on Windows support

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53124/#review154472 --- Fix it, then Ship it! docs/windows.md (lines 61 - 62)

Review Request 53351: Added 'ContainerClass' to help decide how best to launch a container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53351/ --- Review request for mesos and Jie Yu. Bugs: MESOS-6464

Review Request 53352: Updated 'LinuxLauncher->fork()` with *enter* and *clone* namespaces.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53352/ --- Review request for mesos and Jie Yu. Bugs: MESOS-6464

Review Request 53353: Introduced a new 'DEBUG' container class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53353/ --- Review request for mesos and Jie Yu. Bugs: MESOS-6464

Review Request 53354: Updated namespace isolators to customize based on 'ContainerClass'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53354/ --- Review request for mesos and Jie Yu. Bugs: MESOS-6464

Re: Review Request 52587: Allow CREATE of shared volumes based on capability of framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52587/#review154477 --- Patch looks great! Reviews applied: [52587] Passed command:

Re: Review Request 52765: Populated `recovered_slaves` in `/state` and `/slaves` endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52765/ --- (Updated Nov. 1, 2016, 6:40 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 52696: Harden stout

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52696/ --- (Updated Nov. 1, 2016, 7:10 p.m.) Review request for mesos, James Peach,

Re: Review Request 50128: Added helper function to 'Docker::Device'.

> On 十一月 1, 2016, 3:19 p.m., Guangya Liu wrote: > > src/docker/docker.cpp, line 756 > > > > > > I think that we actually need to check invalid permissions here, as it > > is possible that there are invalid

Re: Review Request 50128: Added helper function to 'Docker::Device'.

> On 十月 26, 2016, 3:22 a.m., Kevin Klues wrote: > > src/docker/docker.cpp, line 388 > > > > > > Add an error here to verify correct set of permissions in the > > permissions field. > > > > Once we have

Re: Review Request 53296: Added cgroup namespace support for unified container.

> On Nov. 1, 2016, 4:43 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/namespaces/cgroup.hpp, line 28 > > > > > > Instead of creating a new namespace/cgroup isolator, I would suggest we > > add the

Re: Review Request 53361: Fixed memory leak in request/response decoders.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53361/ --- (Updated Nov. 2, 2016, 4:27 a.m.) Review request for mesos and Benjamin

Re: Review Request 53253: Fixed the bug when search base hierarchy in `cgroups_tests.cpp`.

> On Nov. 1, 2016, 1:20 a.m., Jiang Yan Xu wrote: > > We unfortunately have to copy the cleanup code from > > `ContainerizerTest::SetUp()` to here. FWIW the > > test fixture originally was written with co-mounted subsystems in a single > > hierarchy (hence *Any*), later altered when Mesos

Re: Review Request 53344: Updated `/slaves.md` doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53344/ --- (Updated Nov. 1, 2016, 6:41 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 52647: Fix new sign comparison errors in libprocess produced by hardened flags

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52647/#review154439 --- Ship it! Ship It! - James Peach On Oct. 27, 2016, 4:51

Re: Review Request 52886: Fix new sign comparison errors in stout produced by hardened flags

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52886/#review154440 --- Ship it! Ship It! - James Peach On Oct. 27, 2016, 7:32

Review Request 53366: Introduced a streaming gzip::Decompressor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53366/ --- Review request for mesos and Anand Mazumdar. Bugs: MESOS-6530

Review Request 53365: Fixed an issue in the gzip error handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53365/ --- Review request for mesos and Anand Mazumdar. Repository: mesos Description

Re: Review Request 53361: Fixed memory leak in request/response decoders.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53361/#review154499 --- Fix it, then Ship it! 3rdparty/libprocess/src/decoder.hpp

Re: Review Request 53161: Implemented the conversion from AUFS whiteouts to OverlayFS whiteouts.

> On Nov. 1, 2016, 5 p.m., Zhitao Li wrote: > > src/slave/containerizer/mesos/provisioner/docker/store.cpp, lines 341-352 > > > > > > Do we need to worry about previously cached image layers in stores, if > > the

Review Request 53361: Fixed memory leak in request/response decoders.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53361/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-6527

Re: Review Request 53127: Added the test `ProvisionerDockerWhiteoutTest`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53127/#review154515 --- src/tests/containerizer/provisioner_docker_tests.cpp (line 665)

Re: Review Request 53369: Agent cgroup assignment should precede agent initialization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53369/#review154512 --- The agent subsystems is a hack to me. I think we should consider

Re: Review Request 50599: Assigned Nvidia GPU devices to docker container.

> On 十一月 1, 2016, 3:04 p.m., Guangya Liu wrote: > > src/slave/containerizer/docker.cpp, line 701 > > > > > > You need to keep the comments from Kevin as open here > >

Review Request 53372: MESOS-5662: Fixed parent class SetUpTestCase calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53372/ --- Review request for mesos and Anand Mazumdar. Bugs: MESOS-5662

Re: Review Request 53253: Fixed the bug when search base hierarchy in `cgroups_tests.cpp`.

> On Nov. 1, 2016, 1:20 a.m., Jiang Yan Xu wrote: > > We unfortunately have to copy the cleanup code from > > `ContainerizerTest::SetUp()` to here. FWIW the > > test fixture originally was written with co-mounted subsystems in a single > > hierarchy (hence *Any*), later altered when Mesos

Review Request 53369: Agent cgroup assignment should precede agent initialization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53369/ --- Review request for mesos and Jiang Yan Xu. Bugs: MESOS-6523

Re: Review Request 53115: Implemented handling AUFS whiteouts for copy backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53115/#review154513 --- Fix it, then Ship it!

Re: Review Request 52645: Harden Mesos

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52645/#review154503 --- Patch looks great! Reviews applied: [52647, 52886, 52754, 52645]

Review Request 53344: Updated `/slaves.md` doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53344/ --- Review request for mesos, Anand Mazumdar, Xiaojian Huang, and Kunal Thakar.

Re: Review Request 52765: Populated `recovered_slaves` in `/state` and `/slaves` endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52765/#review154424 --- src/master/http.cpp (line 2241)

Re: Review Request 53285: Show the leader information in WebUI.

> On Oct. 31, 2016, 3:47 p.m., Jiang Yan Xu wrote: > > src/webui/master/static/home.html, line 26 > > > > > > Since `hostname` is deprecated, use `address.hostname`? If that's not > > available, fall back to the

Re: Review Request 53285: Show the leader information in WebUI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53285/#review154428 --- Ship it! Ship It! - Jiang Yan Xu On Oct. 29, 2016, 8:05