Re: Review Request 61069: Introduced an optimized fixed size last-in-first-out semaphore.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61069/#review181329 --- Bad review! Reviews applied: [61069, 61068, 61067] Error: No

Re: Review Request 60913: Adds support for OpenSSL's ECDH key exchange.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60913/ --- (Updated July 25, 2017, 12:11 p.m.) Review request for mesos, Jie Yu and Till

Re: Review Request 60771: Implemented the 'SUBSCRIBE' call in the resource provider manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60771/ --- (Updated July 25, 2017, 4:55 p.m.) Review request for mesos, Benjamin Bannier

Review Request 61110: Added name flag to balloon framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61110/ --- Review request for mesos, Alexander Rukletsov and Alexander Rojas. Bugs:

Re: Review Request 61109: Used the default value when parsing an optional enum field.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61109/#review181351 --- Patch looks great! Reviews applied: [61109] Passed command:

Re: Review Request 61112: Added flag executor_extra_uris to balloon framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61112/#review181355 --- Patch looks great! Reviews applied: [61110, 6, 61112]

Review Request 61109: Used the default value when parsing an optional enum field.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61109/ --- Review request for mesos, Benjamin Mahler and James Peach. Bugs: MESOS-7828

Re: Review Request 60500: Introduced `--default_container_dns` agent flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60500/#review181349 --- src/slave/main.cpp Lines 411-457 (patched)

Review Request 61112: Added flag executor_extra_uris to balloon framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61112/ --- Review request for mesos, Alexander Rukletsov and Alexander Rojas. Bugs:

Review Request 61111: Extracted strings into constants in balloon framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6/ --- Review request for mesos, Alexander Rukletsov and Alexander Rojas. Bugs:

Re: Review Request 61109: Used the default value when parsing an optional enum field.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61109/#review181352 --- Could you construct a test for this by parsing a JSON object with

Re: Review Request 61031: Removed almost identical master and slave metrics tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61031/#review181390 --- Ship it! src/tests/metrics_tests.cpp Lines 103-146 (original)

Re: Review Request 61032: Fixed slaves_unreachable metric.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61032/#review181392 --- src/master/metrics.cpp Lines 223 (patched)

Re: Review Request 61032: Fixed slaves_unreachable metric.

> On July 25, 2017, 10:06 p.m., Vinod Kone wrote: > > src/master/metrics.cpp > > Lines 223 (patched) > > > > > > Ideally our tests should've caught this :( Can you please update the > > metrics test to verify this

Re: Review Request 61033: Added missing metrics to tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61033/#review181396 --- src/tests/slave_tests.cpp Line 1364 (original), 1365 (patched)

Re: Review Request 61034: Minor style cleanups in process.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61034/#review181397 --- Ship it! Ship It! - Vinod Kone On July 21, 2017, 2:32 p.m.,

Re: Review Request 61122: Fixed the host volume relative host path ownership.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61122/#review181403 --- src/slave/containerizer/mesos/isolators/filesystem/linux.cpp

Re: Review Request 61120: Fixed the sandbox_path volume source path ownership.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61120/#review181402 --- src/slave/containerizer/mesos/isolators/volume/sandbox_path.cpp

Review Request 61124: Push metric history entries with their timestamp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61124/ --- Review request for mesos, Benjamin Mahler, Kevin Klues, and Jiang Yan Xu.

Re: Review Request 60931: Added test cases for framework streaming events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60931/#review181404 --- Patch looks great! Reviews applied: [60928, 60929, 60930, 60931]

Review Request 61128: Improved log messages in master when adding/removing tasks/executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61128/ --- Review request for mesos and Qian Zhang. Repository: mesos Description

Re: Review Request 60439: Added scripts to automate website publishing.

> On July 3, 2017, 4:51 p.m., haosdent huang wrote: > > support/mesos-website/build.sh > > Lines 42-43 (patched) > > > > > > Should we move `bundle install` to here? No. As commented in entrypoint.sh, `bundle

Review Request 61125: Track the total number of time series samples.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61125/ --- Review request for mesos, Benjamin Mahler, Kevin Klues, and Jiang Yan Xu.

Re: Review Request 61112: Added flag executor_extra_uris to balloon framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61112/#review181366 --- src/examples/balloon_framework.cpp Lines 120-124 (patched)

Re: Review Request 61111: Extracted strings into constants in balloon framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6/#review181368 --- src/examples/balloon_framework.cpp Line 296 (original), 300

Re: Review Request 60961: Added Prometheus support to the `/metrics/snapshot` endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60961/#review181422 --- Patch looks great! Reviews applied: [61124, 60957, 61125, 60958,

Re: Review Request 61058: Added a lock-free event queue.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61058/#review181297 --- 3rdparty/libprocess/configure.ac Lines 72-75 (original), 72-80

Re: Review Request 61060: Cached a reference to a ProcessBase in every UPID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61060/#review181424 --- This is also updating process.cpp from a refs counter to a

Re: Review Request 60500: Introduced `--default_container_dns` agent flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60500/ --- (Updated July 26, 2017, 10:41 a.m.) Review request for mesos, Avinash

Re: Review Request 60500: Introduced `--default_container_dns` agent flag.

> On July 25, 2017, 11:33 p.m., Avinash sridharan wrote: > > src/slave/main.cpp > > Lines 411-457 (patched) > > > > > > Shouldn't this be a \lambda? > > > > Similar to how we do error handling for the flags

Re: Review Request 61015: Fixed cgroup device Entry.Selector major/minor number type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61015/#review181427 --- Patch looks great! Reviews applied: [60991, 60932, 60933, 60934,

Re: Review Request 60934: Implemented blkio subsystem usage() for resource statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60934/#review181428 --- Ship it! Ship It! - Qian Zhang On July 26, 2017, 9:02 a.m.,

Re: Review Request 61030: Added metrics for the number of active http and driver frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61030/#review181387 --- src/master/master.hpp Lines 1925-1926 (patched)

Re: Review Request 61028: Added metric for API subscribe calls in the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61028/#review181375 --- src/master/metrics.hpp Lines 142 (patched)

Re: Review Request 61097: Added gRPC support in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61097/ --- (Updated July 25, 2017, 9:13 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 61098: Added unit tests for gRPC support in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61098/ --- (Updated July 25, 2017, 9:14 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 61029: Added metric for connected API subscribers in the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61029/#review181385 --- src/master/metrics.cpp Lines 75 (patched)

Re: Review Request 61031: Removed almost identical master and slave metrics tests.

> On July 25, 2017, 10:02 p.m., Vinod Kone wrote: > > src/tests/metrics_tests.cpp > > Lines 103-146 (original) > > > > > > Hmm. there are lot more metrics that are deleted here than the ones > > that are present in

Re: Review Request 60791: Add fetcher cache space usage metrics.

> On July 18, 2017, 2:16 p.m., Jiang Yan Xu wrote: > > src/slave/containerizer/fetcher.cpp > > Lines 272-275 (patched) > > > > > > Aside from styling/convention, would this require defer? > > James Peach wrote: >

Re: Review Request 61031: Removed almost identical master and slave metrics tests.

> On July 25, 2017, 10:02 p.m., Vinod Kone wrote: > > src/tests/metrics_tests.cpp > > Lines 103-146 (original) > > > > > > Hmm. there are lot more metrics that are deleted here than the ones > > that are present in

Re: Review Request 61053: Removed unnecessary states RUNNING and TERMINATED.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61053/#review181304 --- Fix it, then Ship it! 3rdparty/libprocess/src/process.cpp

Re: Review Request 60791: Add fetcher cache space usage metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60791/#review181395 --- Ship it! Left a reply to the issue for further discussion

Re: Review Request 61059: Added --enable-lock-free-event-queue configuration in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61059/#review181399 --- configure.ac Lines 151-154 (original), 151-159 (patched)

Re: Review Request 60898: Added more tests for agent reregistration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60898/#review181401 --- Ship it! Ship It! - James Peach On July 20, 2017, 4:26

Review Request 61123: Added regression test for host volume ownership issue.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61123/ --- Review request for mesos, Ilya Pronin, Jie Yu, James Peach, Stephan Erb, Vinod

Review Request 61120: Fixed the sandbox_path volume source path ownership.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61120/ --- Review request for mesos, Ilya Pronin, Jie Yu, James Peach, Vinod Kone, and

Review Request 61122: Fixed the host volume relative host path ownership.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61122/ --- Review request for mesos, Ilya Pronin, Jie Yu, James Peach, Stephan Erb, Vinod

Review Request 61121: Added regression test for sandbox_path volume ownership issue.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61121/ --- Review request for mesos, Ilya Pronin, Jie Yu, James Peach, Vinod Kone, and

Re: Review Request 61067: More optimizations for creating a MessageEvent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61067/#review181431 --- The encode and send changes look good, but I'm perplexed by the

Re: Review Request 60996: Adds documentation for LIBPROCESS_SSL_ECDH_CURVE environment variable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60996/#review181433 --- Ship it! Ship It! - James Peach On July 21, 2017, 9:30

Re: Review Request 60913: Adds support for OpenSSL's ECDH key exchange.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60913/#review181434 --- Ship it! Ship It! - James Peach On July 25, 2017, 10:11

Re: Review Request 61068: Added a copy-on-write optimization for UPID 'id' field.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61068/#review181432 --- Fix it, then Ship it! I guess address is much cheaper to copy?

Re: Review Request 61069: Introduced an optimized fixed size last-in-first-out semaphore.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61069/#review181435 --- 3rdparty/libprocess/src/run_queue.hpp Line 111 (original), 116

Re: Review Request 60996: Adds documentation for LIBPROCESS_SSL_ECDH_CURVE environment variable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60996/#review181436 --- Patch looks great! Reviews applied: [60913, 60996] Passed

Re: Review Request 60500: Introduced `--default_container_dns` agent flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60500/ --- (Updated July 25, 2017, 2:03 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 60558: Set container DNS with `--default_container_dns` in Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60558/ --- (Updated July 25, 2017, 2:05 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 60600: Set container DNS with `--default_container_dns` in CNI isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60600/ --- (Updated July 25, 2017, 2:06 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 60557: Passed default container DNS info to Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60557/ --- (Updated July 25, 2017, 2:04 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 60793: Added a test `CniIsolatorTest.ROOT_VerifyDefaultDNS`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60793/#review181321 --- Patch looks great! Reviews applied: [60500, 60557, 60558, 61075,

Re: Review Request 60793: Added a test `CniIsolatorTest.ROOT_VerifyDefaultDNS`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60793/ --- (Updated July 25, 2017, 2:08 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 60761: Added a test `DockerContainerizerTest.ROOT_DOCKER_DefaultDNS`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60761/ --- (Updated July 25, 2017, 2:07 p.m.) Review request for mesos, Avinash sridharan

Review Request 61127: Fixed unit tests for altered Timer semantics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61127/ --- Review request for mesos, Benjamin Mahler, Kevin Klues, and Jiang Yan Xu.

Re: Review Request 61122: Fixed the host volume relative host path ownership.

> On July 25, 2017, 4:26 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/filesystem/linux.cpp > > Line 487 (original), 498 (patched) > > > > > > This is sandbox volume, not host volume. Let's change

Re: Review Request 61120: Fixed the sandbox_path volume source path ownership.

> On July 25, 2017, 4:25 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/volume/sandbox_path.cpp > > Lines 164-175 (original), 164-177 (patched) > > > > > > If `source` already exists, let's try not

Review Request 61126: Converted Timer value to counting semantics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61126/ --- Review request for mesos, Benjamin Mahler, Kevin Klues, and Jiang Yan Xu.

Re: Review Request 61034: Minor style cleanups in process.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61034/#review181412 --- Patch looks great! Reviews applied: [61028, 61029, 61030, 61031,

Re: Review Request 61057: Removed ProcessBase::inject to support future event queues.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61057/#review181413 --- Fix it, then Ship it!

Re: Review Request 60933: Added stats/control helpers for the Blkio cgroup subsystem.

> On July 20, 2017, 11:43 p.m., Qian Zhang wrote: > > src/linux/cgroups.hpp > > Lines 451 (patched) > > > > > > Just curious, this refers to the blkio file `blkio.weight` and > > `blkio.leaf_weight`, right? Yes.

Re: Review Request 61123: Added regression test for host volume ownership issue.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61123/#review181417 --- Patch looks great! Reviews applied: [61120, 61121, 61122, 61123]

Re: Review Request 60934: Implemented blkio subsystem usage() for resource statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60934/ --- (Updated July 25, 2017, 6:02 p.m.) Review request for mesos, haosdent huang,

Re: Review Request 60933: Added stats/control helpers for the Blkio cgroup subsystem.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60933/ --- (Updated July 25, 2017, 6:02 p.m.) Review request for mesos, haosdent huang,

Re: Review Request 60934: Implemented blkio subsystem usage() for resource statistics.

> On July 21, 2017, 12:19 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/subsystems/blkio.cpp > > Lines 111 (patched) > > > > > > So it is possible there is an entry in `blkio.time`

Re: Review Request 61015: Fixed cgroup device Entry.Selector major/minor number type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61015/ --- (Updated July 25, 2017, 6:03 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 60932: Added protobuf scheme for blkio subsystem in CgroupInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60932/ --- (Updated July 25, 2017, 6:01 p.m.) Review request for mesos, haosdent huang,

Re: Review Request 60991: Changed Device::path to optional and introduced Device::Number.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60991/ --- (Updated July 25, 2017, 6:01 p.m.) Review request for mesos, haosdent huang,

Re: Review Request 60932: Added protobuf scheme for blkio subsystem in CgroupInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60932/#review181419 --- include/mesos/mesos.proto Lines 2921-2922 (patched)

Re: Review Request 61128: Improved log messages in master when adding/removing tasks/executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61128/#review181420 --- Patch looks great! Reviews applied: [61128] Passed command: