Re: Review Request 61732: Updated endpoints help.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61732/#review183240 --- Bad patch! Reviews applied: [61732, 61745, 61733, 61731] Failed

Re: Review Request 61731: Updated configuration.md to reflect new flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61731/#review183238 --- Patch looks great! Reviews applied: [61731] Passed command:

Re: Review Request 61748: Style cleanup for grpc tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61748/#review183256 --- Patch looks great! Reviews applied: [61600, 61748] Passed

Re: Review Request 61748: Style cleanup for grpc tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61748/#review183257 --- Ship it! Ship It! - Jie Yu On Aug. 18, 2017, 7 p.m.,

Re: Review Request 61600: Rewrited rules for generating Protobuf and gRPC code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61600/ --- (Updated Aug. 18, 2017, 6:58 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 61262: Added 'heartbeat' event for the operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61262/#review183251 --- Patch looks great! Reviews applied: [61262] Passed command:

Re: Review Request 61262: Added 'heartbeat' event for the operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61262/ --- (Updated Aug. 18, 2017, 6:54 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 61732: Updated endpoints help.

> On Aug. 18, 2017, 4:55 p.m., Till Toenshoff wrote: > > docs/endpoints/slave/api/v1/resource_provider.md > > Lines 12 (patched) > > > > > > Not yours but the capitalizing here is inconsitent - we should possibly >

Re: Review Request 61733: Synchronized comment in v1 and unversioned master.proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61733/ --- (Updated Aug. 18, 2017, 1:28 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 61725: Added secrets docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61725/ --- (Updated Aug. 18, 2017, 1:29 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 61262: Added 'heartbeat' event for the operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61262/ --- (Updated Aug. 18, 2017, 6:12 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 61732: Updated endpoints help.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61732/#review183231 --- Fix it, then Ship it! docs/endpoints/master/frameworks.md

Re: Review Request 61733: Synchronized comment in v1 and unversioned master.proto.

> On Aug. 18, 2017, 12:47 p.m., Till Toenshoff wrote: > > include/mesos/v1/master/master.proto > > Line 362 (original), 362 (patched) > > > > > > Is there any documentation around our deprecation cycles? > > I

Re: Review Request 61189: Added authorization for V1 events.

> On Aug. 8, 2017, 9:36 a.m., Alexander Rojas wrote: > > src/master/master.cpp > > Lines 9547-9569 (patched) > > > > > > I don't think this part should be done as it is. Consider the case when > > you have an

Re: Review Request 60496: Added socket checking to the network ports isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60496/ --- (Updated Aug. 18, 2017, 9 p.m.) Review request for mesos, Qian Zhang and Jiang

Re: Review Request 60496: Added socket checking to the network ports isolator.

> On Aug. 18, 2017, 2:39 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/ports.cpp > > Lines 362 (patched) > > > > > > I see you put the actual used resources (i.e. unallocated ports)

Re: Review Request 61733: Synchronized comment in v1 and unversioned master.proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61733/#review183228 --- include/mesos/v1/master/master.proto Line 362 (original), 362

Re: Review Request 61275: Added a URL parameter to the resource provider driver.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61275/#review183234 --- Ship it! Ship It! - Jie Yu On Aug. 2, 2017, 11:37 a.m., Jan

Re: Review Request 61262: Added 'heartbeat' event for the operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61262/#review183259 --- Patch looks great! Reviews applied: [61262] Logs available

Review Request 61745: Fixed capitalization and typos in endpoint helps.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61745/ --- Review request for mesos and Till Toenshoff. Repository: mesos Description

Re: Review Request 61732: Updated endpoints help.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61732/ --- (Updated Aug. 18, 2017, 1:24 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 61271: Implemented HTTP connection handling for the resource provider driver.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61271/#review183236 --- Fix it, then Ship it! Great job!!

Re: Review Request 61262: Added 'heartbeat' event for the operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61262/#review183244 --- src/master/master.hpp Lines 309-312 (patched)

Re: Review Request 61745: Fixed capitalization and typos in endpoint helps.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61745/#review183249 --- Ship it! Ship It! - Till Toenshoff On Aug. 18, 2017, 5:25

Re: Review Request 61725: Added secrets docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61725/#review183243 --- Bad patch! Reviews applied: [61725] Failed command: python

Review Request 61748: Style cleanup for grpc tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61748/ --- Review request for mesos, Benjamin Bannier and Jie Yu. Repository: mesos

Re: Review Request 61600: Rewrited rules for generating Protobuf and gRPC code.

> On Aug. 16, 2017, 8:36 a.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/src/tests/grpc_tests.cpp > > Line 95 (original), 95 (patched) > > > > > > Does it make sens to move this unrelated cleanup into a

Re: Review Request 61600: Rewrited rules for generating Protobuf and gRPC code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61600/#review183260 --- Ship it! Ship It! - Jie Yu On Aug. 18, 2017, 6:58 p.m.,

Re: Review Request 61189: Added authorization for V1 events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61189/#review183268 --- Bad patch! Reviews applied: [61189, 61262] Failed command:

Re: Review Request 61697: Included nested command checks output in the executor logs.

> On Aug. 17, 2017, 2:22 p.m., Alexander Rukletsov wrote: > > src/checks/checker_process.cpp > > Lines 144-145 (patched) > > > > > > Insert a blank line here. Ditto

Re: Review Request 61697: Included nested command checks output in the executor logs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61697/ --- (Updated Aug. 18, 2017, 11:20 p.m.) Review request for mesos, Alexander

Re: Review Request 61697: Included nested command checks output in the executor logs.

> On Aug. 16, 2017, 11:03 p.m., Greg Mann wrote: > > src/checks/checker_process.cpp > > Lines 145 (patched) > > > > > > s/It/This function/ Fixed, I guess that we'll wnat to change

Re: Review Request 61640: Improved the reason and message for killed queued tasks updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61640/#review183281 --- src/slave/slave.cpp Lines 3033 (patched)

Re: Review Request 61189: Added authorization for V1 events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61189/#review183274 --- src/master/master.cpp Lines 9626 (patched)

Re: Review Request 61697: Included nested command checks output in the executor logs.

> On Aug. 17, 2017, 2:22 p.m., Alexander Rukletsov wrote: > > src/checks/checker_process.cpp > > Lines 855-858 (original), 903-906 (patched) > > > > > > While we're on it, let's consistently print out HTTP and TCP

Re: Review Request 61706: Added Autotools rules to build the CSI client module in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61706/#review183287 --- Bad patch! Reviews applied: [61706, 61705, 61704, 61703, 61748,

Re: Review Request 61588: Added a `[-s|--skip-hooks]` option when applying reviews.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61588/#review183270 --- Fix it, then Ship it! Ship It! support/apply-reviews.py Line

Re: Review Request 61639: Fixed an bug where the agent kills and still launches a task.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61639/#review183266 --- Fix it, then Ship it! src/slave/slave.cpp Lines 4502

Re: Review Request 61600: Rewrited rules for generating Protobuf and gRPC code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61600/ --- (Updated Aug. 19, 2017, 12:34 a.m.) Review request for mesos, Benjamin Bannier

Review Request 61751: Updated Cotire.cmake module to version 1.7.10.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61751/ --- Review request for mesos and Joseph Wu. Repository: mesos Description

Review Request 61750: Updated ZooKeeper patch to link with /MTd in Debug configurations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61750/ --- Review request for mesos and Joseph Wu. Repository: mesos Description

Re: Review Request 61408: Added test cases for V1 teardown Call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61408/#review183271 --- Ship it! Ship It! - Greg Mann On Aug. 17, 2017, 9:33 p.m.,

Re: Review Request 61763: Added heartbeat interval for V1 Operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61763/ --- (Updated Aug. 18, 2017, 11:40 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 61704: Added CSI client classes to talk to CSI plugins.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61704/ --- (Updated Aug. 19, 2017, 12:36 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 61752: Audited linkage of 3rdparty dependencies.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61752/#review183262 --- Bad review! Reviews applied: [61752, 61751, 61750, 61597, 61516,

Re: Review Request 61763: Added heartbeat interval for V1 Operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61763/#review183276 --- Fix it, then Ship it! src/tests/api_tests.cpp Lines 2420-2422

Re: Review Request 60592: Configure the `network/ports` isolator watch interval.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60592/ --- (Updated Aug. 18, 2017, 9:17 p.m.) Review request for mesos, Qian Zhang and

Review Request 61759: Updated the docs for V1 HEARTBEAT Event.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61759/ --- Review request for mesos, Anand Mazumdar and Greg Mann. Bugs: MESOS-7695

Re: Review Request 61759: Updated the docs for V1 HEARTBEAT Event.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61759/#review183272 --- Ship it! Ship It! - Greg Mann On Aug. 18, 2017, 10:04 p.m.,

Review Request 61763: Added heartbeat interval for V1 Operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61763/ --- Review request for mesos, Anand Mazumdar and Greg Mann. Bugs: MESOS-7695

Re: Review Request 61763: Added heartbeat interval for V1 Operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61763/#review183283 --- Patch looks great! Reviews applied: [61759, 61763] Passed

Re: Review Request 61697: Included nested command checks output in the executor logs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61697/#review183284 --- Bad patch! Reviews applied: [61697] Failed command: python

Review Request 61752: Audited linkage of 3rdparty dependencies.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61752/ --- Review request for mesos and Joseph Wu. Repository: mesos Description

Re: Review Request 61189: Added authorization for V1 events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61189/#review183242 --- src/master/master.hpp Lines 1832-1833 (original), 1835-1841

Re: Review Request 61675: Updated doc for the changes of pid namespace sharing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61675/#review183265 --- Fix it, then Ship it! docs/mesos-containerizer.md Lines 79

Re: Review Request 61697: Included nested command checks output in the executor logs.

> On Aug. 17, 2017, 2:22 p.m., Alexander Rukletsov wrote: > > src/checks/checker_process.cpp > > Lines 630-631 (patched) > > > > > > I assume line feed and carriage return characters are included in the > > output.

Re: Review Request 61766: Made the output handling of TCP and HTTP checks consistent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61766/#review183285 --- Bad patch! Reviews applied: [61766, 61697] Failed command:

Review Request 61766: Made the output handling of TCP and HTTP checks consistent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61766/ --- Review request for mesos, Alexander Rukletsov, Greg Mann, and Vinod Kone.

Re: Review Request 61705: Added a mock CSI plugin and a unit test for CSI client classes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61705/ --- (Updated Aug. 19, 2017, 12:37 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 61706: Added Autotools rules to build the CSI client module in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61706/ --- (Updated Aug. 19, 2017, 12:38 a.m.) Review request for mesos, Benjamin

Review Request 61753: Refactored CMake build system.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61753/ --- Review request for mesos and Joseph Wu. Repository: mesos Description

Re: Review Request 61189: Added authorization for V1 events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61189/ --- (Updated Aug. 18, 2017, 9:53 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 61759: Updated the docs for V1 HEARTBEAT Event.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61759/#review183273 --- Patch looks great! Reviews applied: [61759] Passed command:

Re: Review Request 61763: Added heartbeat interval for V1 Operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61763/#review183280 --- src/tests/api_tests.cpp Line 2440 (original), 2447 (patched)

Re: Review Request 61600: WIP: Rewrited rules for generating Protobuf and gRPC code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61600/ --- (Updated Aug. 18, 2017, 11:58 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 61189: Added authorization for V1 events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61189/ --- (Updated Aug. 19, 2017, 3:33 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 61189: Added authorization for V1 events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61189/#review183291 --- Patch looks great! Reviews applied: [61262, 61189] Passed

Re: Review Request 61753: Refactored CMake build system.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61753/#review183293 --- Bad review! Reviews applied: [61753, 61752, 61751, 61750, 61597,

Re: Review Request 61262: Added 'heartbeat' event for the operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61262/#review183163 --- src/master/master.hpp Lines 309 (patched)

Re: Review Request 61753: Refactored CMake build system.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61753/#review183264 --- Bad review! Reviews applied: [61753, 61752, 61751, 61750, 61597,

Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61597/#review183199 --- Ship it! Ship It! - Alexander Rukletsov On Aug. 11, 2017,

Re: Review Request 61272: Added a MockResourceProvider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61272/ --- (Updated Aug. 18, 2017, 12:24 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 61271: Implemented HTTP connection handling for the resource provider driver.

> On Aug. 17, 2017, 6:11 a.m., Jie Yu wrote: > > src/resource_provider/http_connection.hpp > > Lines 321 (patched) > > > > > > This should be `UNREACHABLE` as well? > > Jan Schlicht wrote: > No, the instance

Re: Review Request 61271: Implemented HTTP connection handling for the resource provider driver.

> On Aug. 3, 2017, noon, Benjamin Bannier wrote: > > src/resource_provider/http_connection.hpp > > Lines 90 (patched) > > > > > > I wonder if it makes more sense to return e.g., a `Try` here in > > order to surface

Re: Review Request 61544: WIP: Rewrote Mesos CMake build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61544/ --- (Updated Aug. 18, 2017, 9:30 a.m.) Review request for mesos, Aaron Wood,

Re: Review Request 61271: Implemented HTTP connection handling for the resource provider driver.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61271/ --- (Updated Aug. 18, 2017, 12:18 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 61733: Synchronized comment in v1 and unversioned master.proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61733/#review183211 --- Patch looks great! Reviews applied: [61731, 61732, 61733]

Re: Review Request 61725: Added secrets docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61725/ --- (Updated Aug. 18, 2017, 10:18 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 61725: Added secrets docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61725/#review183218 --- Patch looks great! Reviews applied: [61731, 61732, 61733, 61725]

Review Request 61735: Removed diacritics from docs/health-checks.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61735/ --- Review request for mesos, Alexander Rukletsov, Gastón Kleiman, and Kapil Arya.

Re: Review Request 61735: Removed diacritics from docs/health-checks.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61735/#review183217 --- Ship it! Ship It! - Kapil Arya On Aug. 18, 2017, 10:41

Re: Review Request 61725: Added secrets docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61725/#review183207 --- Fix it, then Ship it! Great to see this being documented -

Review Request 61733: Synchronized comment in v1 and unversioned master.proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61733/ --- Review request for mesos, Anand Mazumdar and Till Toenshoff. Repository: mesos

Review Request 61731: Updated configuration.md to reflect new flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61731/ --- Review request for mesos, Anand Mazumdar and Till Toenshoff. Repository: mesos

Review Request 61732: Updated endpoints help.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61732/ --- Review request for mesos, Anand Mazumdar and Till Toenshoff. Repository: mesos

Re: Review Request 61732: Updated endpoints help.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61732/ --- (Updated Aug. 18, 2017, 9:48 a.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 61725: Added secrets docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61725/ --- (Updated Aug. 18, 2017, 10 a.m.) Review request for mesos, Gilbert Song, Greg

Re: Review Request 61149: Added Future::condition.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61149/#review183221 --- Looks like the summary became incorrect after the last diff

Re: Review Request 61725: Added secrets docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61725/ --- (Updated Aug. 18, 2017, 11:45 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 61725: Added secrets docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61725/ --- (Updated Aug. 18, 2017, 11:46 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 61735: Removed diacritics from docs/health-checks.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61735/#review183223 --- Patch looks great! Reviews applied: [61735] Passed command:

Review Request 61740: Added a no-op master registry operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61740/ --- Review request for mesos. Repository: mesos Description --- Added a

Re: Review Request 61528: Implemented a registrar for resource provider manager state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61528/ --- (Updated Aug. 18, 2017, 5:46 p.m.) Review request for mesos, Jie Yu and Jan

Review Request 61742: Added a master-registry back resource provider manager registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61742/ --- Review request for mesos. Repository: mesos Description --- This patch

Re: Review Request 61725: Added secrets docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61725/#review183226 --- Patch looks great! Reviews applied: [61731, 61732, 61733, 61725]

Re: Review Request 61742: Added a master-registry back resource provider manager registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61742/#review183227 --- Bad review! Reviews applied: [] Error: No reviewers specified.