Review Request 36683: Added a persistent volume test for slave recovery.

2015-07-21 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36683/ --- Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone. Bugs: MESOS

Re: Review Request 36677: Introduced 'recordio' encoding facilities to stout.

2015-07-21 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36677/ --- (Updated July 22, 2015, 6:33 a.m.) Review request for mesos, Anand Mazumdar, Be

Review Request 36680: Added recordio_test.cpp to libprocess Makefile.

2015-07-21 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36680/ --- Review request for mesos and Anand Mazumdar. Bugs: MESOS-3067 https://issue

Re: Review Request 36318: [MESOS-2294] Add support to master for streaming subscribed events

2015-07-21 Thread Ben Mahler
> On July 9, 2015, 10:24 p.m., Marco Massenzio wrote: > > src/master/http.cpp, line 307 > > > > > > while you are at it, do you mind adding javadoc doxy documentation to > > this method? > > what it does, what t

Re: Review Request 36677: Introduced 'recordio' encoding facilities to stout.

2015-07-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36677/#review92556 --- Bad patch! Reviews applied: [36677] Failed command: ./support/appl

Re: Review Request 36424: Created a command executor helper method.

2015-07-21 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36424/ --- (Updated July 22, 2015, 6:20 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 36617: Improved task reconciliation documentation.

2015-07-21 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36617/#review92554 --- Thank you!! No need to update, I will get this committed for you soo

Re: Review Request 36673: Removed pthread from Once and Gate.

2015-07-21 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36673/#review92553 --- Ship it! Ship It! - Artem Harutyunyan On July 21, 2015, 10:55 p.

Review Request 36677: Introduced 'recordio' encoding facilities to stout.

2015-07-21 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36677/ --- Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Jie Yu. Bugs: M

Review Request 36676: Removed pthread from Zookeeper test helper.

2015-07-21 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36676/ --- Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Michael Park.

Re: Review Request 36674: Removed pthread and used Latch in executor and scheduler drivers.

2015-07-21 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36674/ --- (Updated July 22, 2015, 5:56 a.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 36673: Removed pthread from Once and Gate.

2015-07-21 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36673/ --- (Updated July 22, 2015, 5:55 a.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 36424: Created a command executor helper method.

2015-07-21 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36424/ --- (Updated July 22, 2015, 5:49 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 36404: Added support for peek() to process::io

2015-07-21 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36404/ --- (Updated July 21, 2015, 10:29 p.m.) Review request for mesos, Joris Van Remoort

Re: Review Request 36620: WIP Added Non-Freezeer Task Killer.

2015-07-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/#review92549 --- Bad patch! Reviews applied: [36612] Failed command: ./support/appl

Re: Review Request 36673: Removed pthread from Once and Gate.

2015-07-21 Thread Benjamin Hindman
> On July 22, 2015, 4:35 a.m., Artem Harutyunyan wrote: > > 3rdparty/libprocess/src/gate.hpp, line 18 > > > > > > Is this todo still valid? > > Joris Van Remoortere wrote: > Sort of. Although it is true that std:

Re: Review Request 36673: Removed pthread from Once and Gate.

2015-07-21 Thread Joris Van Remoortere
> On July 22, 2015, 4:35 a.m., Artem Harutyunyan wrote: > > 3rdparty/libprocess/src/gate.hpp, line 18 > > > > > > Is this todo still valid? Sort of. Although it is true that std::mutex is implemented using futex, you

Re: Review Request 36618: Fixed ROOT_CGROUPS_Tasks and ROOT_CGROUPS_Read on Ubunu 14.04.

2015-07-21 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36618/#review92546 --- Ship it! Ship It! - Benjamin Hindman On July 20, 2015, 2:56 p.m.

Re: Review Request 36279: Doxygen-ification of comments in libprocess IO headers.

2015-07-21 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36279/#review92545 --- Ship it! Ship It! - Benjamin Hindman On July 7, 2015, 10:14 p.m.

Re: Review Request 36674: Removed pthread and used Latch in executor and scheduler drivers.

2015-07-21 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36674/#review92541 --- include/mesos/executor.hpp (line 243)

Re: Review Request 36658: Updated SSL documentation. Added to home page.

2015-07-21 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36658/#review92543 --- Ship it! docs/home.md (line 27)

Re: Review Request 36674: Removed pthread and used Latch in executor and scheduler drivers.

2015-07-21 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36674/#review92540 --- Ship it! include/mesos/executor.hpp (line 50)

Re: Review Request 36620: WIP Added Non-Freezeer Task Killer.

2015-07-21 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/ --- (Updated July 22, 2015, 4:37 a.m.) Review request for mesos and Timothy Chen.

Re: Review Request 36673: Removed pthread from Once and Gate.

2015-07-21 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36673/#review92539 --- Ship it! But see comments on https://reviews.apache.org/r/36629 reg

Re: Review Request 36673: Removed pthread from Once and Gate.

2015-07-21 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36673/#review92538 --- 3rdparty/libprocess/src/gate.hpp (line 18)

Re: Review Request 36629: stout: Added support for 'synchronized_wait'.

2015-07-21 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36629/#review92537 --- Ship it! Great, can we do the 70 character comment wraps here thoug

Re: Review Request 36672: Removed pthread specialization from Synchronized.

2015-07-21 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36672/#review92536 --- Ship it! Ship It! - Benjamin Hindman On July 22, 2015, 4:07 a.m.

Re: Review Request 36656: Removed 'SSL_ENABLE_SSL_V2' configuration flag for SSLv2.

2015-07-21 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36656/#review92534 --- Ship it! 3rdparty/libprocess/src/openssl.cpp (line 489)

Re: Review Request 36669: Fixed the order of expected value in EXPECT_EQ.

2015-07-21 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36669/#review92533 --- Ship it! Ship It! - Benjamin Hindman On July 22, 2015, 12:46 a.m

Re: Review Request 36667: Moved createLabel to protobuf_utils.

2015-07-21 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36667/#review92531 --- Ship it! Ship It! - Benjamin Hindman On July 21, 2015, 11:37 p.m

Re: Review Request 36668: Removed some trailing underscores from {master, slave}_tests.cpp.

2015-07-21 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36668/#review92532 --- Ship it! Ship It! - Benjamin Hindman On July 21, 2015, 11:37 p.m

Review Request 36674: Removed pthread and used Latch in executor and scheduler drivers.

2015-07-21 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36674/ --- Review request for mesos, Benjamin Hindman and Michael Park. Bugs: MESOS-3120

Review Request 36672: Removed pthread specialization from Synchronized.

2015-07-21 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36672/ --- Review request for mesos, Benjamin Hindman and Michael Park. Bugs: MESOS-3118

Review Request 36673: Removed pthread from Once and Gate.

2015-07-21 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36673/ --- Review request for mesos, Benjamin Hindman and Michael Park. Bugs: MESOS-3119

Re: Review Request 36669: Fixed the order of expected value in EXPECT_EQ.

2015-07-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36669/#review92524 --- Patch looks great! Reviews applied: [36667, 36668, 36669] All test

Review Request 36669: Fixed the order of expected value in EXPECT_EQ.

2015-07-21 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36669/ --- Review request for mesos and Benjamin Hindman. Repository: mesos Description

Re: Review Request 36669: Fixed the order of expected value in EXPECT_EQ.

2015-07-21 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36669/ --- (Updated July 21, 2015, 8:46 p.m.) Review request for mesos and Benjamin Hindma

Re: Review Request 36514: [MESOS-898] Add CMake-based build system for the process library

2015-07-21 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36514/#review92521 --- Ship it! 3rdparty/libprocess/cmake/ProcessConfigure.cmake (lines 1

Re: Review Request 36663: Added ip_address field to MasterInfo

2015-07-21 Thread Marco Massenzio
> On July 21, 2015, 11:59 p.m., Anand Mazumdar wrote: > > LGTM, thanks for adding much needed documentation too for the fields ! > > > > Upon reading the corresponding JIRA, I am assuming that we had an agreement > > to not use the Address field that BenM introduced in r36450 for readability >

Re: Review Request 36514: [MESOS-898] Add CMake-based build system for the process library

2015-07-21 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36514/#review92520 --- Ship it! Ship It! - Benjamin Hindman On July 21, 2015, 4:54 p.m.

Re: Review Request 36668: Removed some trailing underscores from {master, slave}_tests.cpp.

2015-07-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36668/#review92518 --- Patch looks great! Reviews applied: [36667, 36668] All tests passe

Re: Review Request 34135: Add filesystem/posix isolator for persistent volumes.

2015-07-21 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34135/#review92516 --- Ship it! Ship It! - Jie Yu On July 12, 2015, 4:46 a.m., Ian Down

Re: Review Request 34135: Add filesystem/posix isolator for persistent volumes.

2015-07-21 Thread Jie Yu
> On July 21, 2015, 9:41 p.m., Jie Yu wrote: > > src/slave/containerizer/isolators/filesystem/posix.cpp, lines 183-185 > > > > > > I just realized an issue here (not your fault). > > > > Since we don't check

Re: Review Request 36663: Added ip_address field to MasterInfo

2015-07-21 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36663/#review92514 --- Ship it! LGTM, thanks for adding much needed documentation too for

Re: Review Request 36580: Added TaskStatus label decorator hook for Slave

2015-07-21 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36580/#review92513 --- src/hook/manager.cpp (line 212)

Re: Review Request 34135: Add filesystem/posix isolator for persistent volumes.

2015-07-21 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34135/#review92512 --- src/slave/containerizer/isolators/filesystem/posix.cpp (lines 198 -

Re: Review Request 36663: Added ip_address field to MasterInfo

2015-07-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36663/#review92510 --- Patch looks great! Reviews applied: [36663] All tests passed. - M

Review Request 36668: Removed some trailing underscores from {master, slave}_tests.cpp.

2015-07-21 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36668/ --- Review request for mesos and Benjamin Hindman. Repository: mesos Description

Review Request 36667: Moved createLabel to protobuf_utils.

2015-07-21 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36667/ --- Review request for mesos and Benjamin Hindman. Repository: mesos Description

Re: Review Request 34135: Add filesystem/posix isolator for persistent volumes.

2015-07-21 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34135/#review92497 --- src/slave/containerizer/isolators/filesystem/posix.cpp (lines 91 -

Re: Review Request 34135: Add filesystem/posix isolator for persistent volumes.

2015-07-21 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34135/#review92494 --- src/slave/containerizer/mesos/containerizer.cpp (line 52)

Re: Review Request 36656: Removed 'SSL_ENABLE_SSL_V2' configuration flag for SSLv2.

2015-07-21 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36656/#review92492 --- Ship it! 3rdparty/libprocess/src/tests/ssl_tests.cpp (line 673)

Re: Review Request 36658: Updated SSL documentation. Added to home page.

2015-07-21 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36658/ --- (Updated July 21, 2015, 10:51 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 36656: Removed 'SSL_ENABLE_SSL_V2' configuration flag for SSLv2.

2015-07-21 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36656/ --- (Updated July 21, 2015, 10:51 p.m.) Review request for mesos, Benjamin Hindman

Review Request 36663: Added ip_address field to MasterInfo

2015-07-21 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36663/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Bugs: MESOS-2736 h

Re: Review Request 36658: Updated SSL documentation. Added to home page.

2015-07-21 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36658/#review92490 --- Ship it! Rendered affected files, everything looks good. - Artem H

Re: Review Request 36658: Updated SSL documentation. Added to home page.

2015-07-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36658/#review92487 --- Patch looks great! Reviews applied: [36656, 36658] All tests passe

Re: Review Request 34135: Add filesystem/posix isolator for persistent volumes.

2015-07-21 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34135/#review92480 --- src/slave/containerizer/isolators/filesystem/posix.cpp (lines 183 -

Review Request 36658: Updated SSL documentation. Added to home page.

2015-07-21 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36658/ --- Review request for mesos, Benjamin Hindman and Michael Park. Bugs: MESOS-3121

Review Request 36656: Removed 'SSL_ENABLE_SSL_V2' configuration flag for SSLv2.

2015-07-21 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36656/ --- Review request for mesos, Benjamin Hindman and Michael Park. Bugs: MESOS-3121

Re: Review Request 36646: Added 'CONFIGURATION' flag to jenkins_build script.

2015-07-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36646/#review92479 --- Patch looks great! Reviews applied: [36646] All tests passed. - M

Re: Review Request 36646: Added 'CONFIGURATION' flag to jenkins_build script.

2015-07-21 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36646/#review92478 --- did you also test with ubuntu? support/jenkins_build.sh (line 57)

Re: Review Request 36612: Cleanup of right angle brackets in cgroups code.

2015-07-21 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36612/#review92474 --- Ship it! Ship It! - Timothy Chen On July 20, 2015, 8:36 a.m., Jo

Review Request 36646: Added 'CONFIGURATION' flag to jenkins_build script.

2015-07-21 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36646/ --- Review request for mesos, Benjamin Hindman and Vinod Kone. Bugs: MESOS-2963

Re: Review Request 36585: Exposed docker container IP via state.json

2015-07-21 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36585/#review92471 --- Ship it! src/tests/docker_containerizer_tests.cpp (line 729)

Re: Review Request 36580: Added TaskStatus label decorator hook for Slave

2015-07-21 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36580/#review92467 --- Ship it! src/examples/test_hook_module.cpp (line 166)

Re: Review Request 36575: Added Labels to TaskStatus protobuf and expose them via state.json.

2015-07-21 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36575/#review92464 --- Ship it! src/tests/master_tests.cpp (line 3198)

Re: Review Request 36574: Added a helper testing functions for Labels.

2015-07-21 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36574/#review92463 --- Ship it! src/tests/mesos.hpp (line 1382)

Re: Review Request 34137: Add support for container image provisioners.

2015-07-21 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34137/#review92462 --- Ship it! Ship It! - Jie Yu On July 12, 2015, 4:47 a.m., Ian Down

Re: Review Request 34137: Add support for container image provisioners.

2015-07-21 Thread Jie Yu
> On July 17, 2015, 1:36 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/containerizer.cpp, lines 637-643 > > > > > > No test for checkpointing??? I decided to punt this in this review. Will follow up with a t

Re: Review Request 36620: WIP Added Non-Freezeer Task Killer.

2015-07-21 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/#review92459 --- src/linux/cgroups.cpp (line 1671)

Re: Review Request 36620: WIP Added Non-Freezeer Task Killer.

2015-07-21 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/#review92457 --- src/linux/cgroups.cpp (line 1504)

Re: Review Request 36585: Exposed docker container IP via state.json

2015-07-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36585/#review92456 --- Patch looks great! Reviews applied: [36574, 36575, 36580, 36585] A

Re: Review Request 36585: Exposed docker container IP via state.json

2015-07-21 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36585/#review92452 --- src/docker/executor.cpp (line 163)

Re: Review Request 36514: [MESOS-898] Add CMake-based build system for the process library

2015-07-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36514/#review92448 --- Bad patch! Reviews applied: [36513, 36514] Failed command: ./suppo

Re: Review Request 36625: Windows: Splitting platform specific functions into separate headers.

2015-07-21 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36625/ --- (Updated July 21, 2015, 11:10 a.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 36425: Enabling IP Discovery script

2015-07-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36425/#review92445 --- Patch looks great! Reviews applied: [36424, 36425] All tests passe

Re: Review Request 36617: Improved task reconciliation documentation.

2015-07-21 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36617/#review92436 --- can you add @bmahler to the review? docs/reconciliation.md (line 4

Re: Review Request 36620: WIP Added Non-Freezeer Task Killer.

2015-07-21 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/ --- (Updated July 21, 2015, 5:18 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 36620: WIP Added Non-Freezeer Task Killer.

2015-07-21 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/ --- (Updated July 21, 2015, 5:17 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 36620: WIP Added Non-Freezeer Task Killer.

2015-07-21 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/#review92432 --- Could you please attach a ticket or explain in the description about

Re: Review Request 36596: Added jsonify() to stout.

2015-07-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36596/#review92431 --- Bad patch! Reviews applied: [36596] Failed command: ./support/appl

Re: Review Request 36585: Exposed docker container IP via state.json

2015-07-21 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36585/ --- (Updated July 21, 2015, 1:02 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 36618: Fixed ROOT_CGROUPS_Tasks and ROOT_CGROUPS_Read on Ubunu 14.04.

2015-07-21 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36618/#review92428 --- Ship it! Ship It! - Timothy Chen On July 20, 2015, 2:56 p.m., Ar

Re: Review Request 36514: [MESOS-898] Add CMake-based build system for the process library

2015-07-21 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36514/ --- (Updated July 21, 2015, 4:54 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 36620: WIP Added Non-Freezeer Task Killer.

2015-07-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/#review92426 --- Patch looks great! Reviews applied: [36612, 36620] All tests passe

Re: Review Request 36425: Enabling IP Discovery script

2015-07-21 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36425/ --- (Updated July 21, 2015, 4:47 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 36514: [MESOS-898] Add CMake-based build system for the process library

2015-07-21 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36514/ --- (Updated July 21, 2015, 4:46 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 36580: Added TaskStatus label decorator hook for Slave

2015-07-21 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36580/ --- (Updated July 21, 2015, 12:46 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 36574: Added a helper testing functions for Labels.

2015-07-21 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36574/ --- (Updated July 21, 2015, 12:45 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 36574: Added a helper testing functions for Labels.

2015-07-21 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36574/ --- (Updated July 21, 2015, 12:45 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 36575: Added Labels to TaskStatus protobuf and expose them via state.json.

2015-07-21 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36575/ --- (Updated July 21, 2015, 12:45 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 36620: WIP Added Non-Freezeer Task Killer.

2015-07-21 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/ --- (Updated July 21, 2015, 4:42 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 36425: Enabling IP Discovery script

2015-07-21 Thread Marco Massenzio
> On July 19, 2015, 8:09 p.m., Benjamin Hindman wrote: > > src/master/main.cpp, line 139 > > > > > > We've tried to name our flags the same as how you'd see them on the > > command line, so s/ipDiscoveryScript/ip_di

Re: Review Request 36620: WIP Added Non-Freezeer Task Killer.

2015-07-21 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/ --- (Updated July 21, 2015, 3:59 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 36617: Improved task reconciliation documentation.

2015-07-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36617/#review92395 --- Patch looks great! Reviews applied: [36617] All tests passed. - M

Re: Review Request 36617: Improved task reconciliation documentation.

2015-07-21 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36617/ --- (Updated July 21, 2015, 11:29 a.m.) Review request for mesos and Joerg Schad.