Review Request 37562: The revocable resource information also are missed for slave node in monitoring doc , fix it in this patch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37562/ --- Review request for mesos. Bugs: MESOS-3286 https://issues.apache.org/jira/b

Re: Review Request 37512: Added user doc for Scheduler HTTP API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37512/#review95684 --- Ship it! LGTM - Anand Mazumdar On Aug. 18, 2015, 3:08 a.m., Vino

Re: Review Request 36404: Added support for peek() to process::io

> On July 26, 2015, 6:18 a.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/src/tests/io_tests.cpp, line 377 > > > > > > we can get rid of some of these literals by: > > s/3/sizeof(data)/ > > What do y

Re: Review Request 37512: Added user doc for Scheduler HTTP API.

> On Aug. 17, 2015, 6:37 p.m., Anand Mazumdar wrote: > > docs/scheduler_http_api.md, line 97 > > > > > > The other example don't have this line. Can we add this to the other > > example call except Subscribe too ? d

Re: Review Request 37512: Added user doc for Scheduler HTTP API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37512/ --- (Updated Aug. 18, 2015, 3:08 a.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 37559: Fixed mutex deadlock issue in ~scheduler::Mesos().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37559/#review95666 --- Ship it! src/scheduler/scheduler.cpp (lines 187 - 189)

Review Request 37559: Fixed mutex deadlock issue in ~scheduler::Mesos().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37559/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-3273 https://issues.ap

Re: Review Request 37558: Updated Proto <-> JSON conversion to use base64 for 'bytes' fields.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37558/#review95660 --- Ship it! Ship It! - Vinod Kone On Aug. 17, 2015, 10:51 p.m., Ben

Re: Review Request 37557: Updated mesos to reflect base64::decode returning a Try.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37557/#review95659 --- Ship it! Ship It! - Vinod Kone On Aug. 17, 2015, 10:49 p.m., Ben

Re: Review Request 37556: Updated base64::decode to reject forbidden characters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37556/#review95657 --- Ship it! 3rdparty/libprocess/3rdparty/stout/include/stout/base64.h

Re: Review Request 37336: [WIP] Added `wait()` method to process::Subprocess

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37336/#review95658 --- In the same vein as os::shell, we should probably introduce an 'os'

Review Request 37558: Updated Proto <-> JSON conversion to use base64 for 'bytes' fields.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37558/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-3284 https://issues.ap

Review Request 37556: Updated base64::decode to reject forbidden characters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37556/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-3284 https://issues.ap

Review Request 37557: Updated mesos to reflect base64::decode returning a Try.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37557/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-3284 https://issues.ap

Re: Review Request 37541: Add TraceEvent API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37541/ --- (Updated Aug. 17, 2015, 10:34 p.m.) Review request for mesos, Chi Zhang, Ian Do

Re: Review Request 37426: MESOS-3251 : Fixing "host" field of request header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37426/#review95652 --- Ship it! Ship It! - Timothy Chen On Aug. 17, 2015, 9:56 p.m., Jo

Re: Review Request 37505: Fix broken health check in docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37505/#review95651 --- Hi haosdent, thanks for working on this but I think running the heal

Re: Review Request 37426: MESOS-3251 : Fixing "host" field of request header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37426/ --- (Updated Aug. 17, 2015, 9:56 p.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 37549: Add jenkins script to run docker tests.

> On Aug. 17, 2015, 9:33 p.m., Vinod Kone wrote: > > 2 high level comments. > > > > Why did you write a whole new script instead of making the current > > jenkins_build.sh work? This is 90% duplicated code which makes me sad. > > > > Also, we shouldn't really depend on non-ASF hosted code (mes

Re: Review Request 37549: Add jenkins script to run docker tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37549/#review95648 --- 2 high level comments. Why did you write a whole new script instead

Re: Review Request 37532: Add QUIESCE call interface to the scheduler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37532/#review95645 --- Patch looks great! Reviews applied: [37532] All tests passed. - M

Re: Review Request 37555: Included /usr/bin/sh in the test root filesystem.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37555/#review95643 --- Ship it! Ship It! - Vinod Kone On Aug. 17, 2015, 8:56 p.m., Jie

Re: Review Request 37547: Used execlp instead of execl to exec processes in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37547/#review95642 --- Ship it! Ship It! - Vinod Kone On Aug. 17, 2015, 7:49 p.m., Jie

Re: Review Request 37545: Used execlp instead of execl to exec processes in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37545/#review95640 --- Ship it! Ship It! - Vinod Kone On Aug. 17, 2015, 7:48 p.m., Jie

Re: Review Request 37546: Used execlp instead of execl to exec processes in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37546/#review95641 --- Ship it! Ship It! - Vinod Kone On Aug. 17, 2015, 7:49 p.m., Jie

Re: Review Request 37544: Fixed a bug in port mapping tests due to os::shell refactor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37544/#review95639 --- Ship it! Ship It! - Vinod Kone On Aug. 17, 2015, 7:48 p.m., Jie

Re: Review Request 36620: WIP Added Non-Freezeer Task Killer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/#review95637 --- Ship it! Ship It! src/linux/cgroups.cpp (line 1686)

Review Request 37541: Add TraceEvent API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37541/ --- Review request for mesos, Chi Zhang, Ian Downes, and Jie Yu. Bugs: MESOS-2769

Review Request 37540: Add PerfEvent API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37540/ --- Review request for mesos, Chi Zhang, Ian Downes, and Jie Yu. Bugs: MESOS-2769

Re: Review Request 37555: Included /usr/bin/sh in the test root filesystem.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37555/ --- (Updated Aug. 17, 2015, 8:56 p.m.) Review request for mesos, Ben Mahler and Vin

Re: Review Request 37555: Included /usr/bin/sh in the test root filesystem.

> On Aug. 17, 2015, 8:52 p.m., Marco Massenzio wrote: > > src/tests/containerizer/rootfs.hpp, line 108 > > > > > > why the trailing comma? My bad. Removed. > On Aug. 17, 2015, 8:52 p.m., Marco Massenzio wrote: > >

Re: Review Request 37555: Included /usr/bin/sh in the test root filesystem.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37555/#review95633 --- Ship it! a couple of nits, but LGTM. src/tests/containerizer/root

Re: Review Request 37426: MESOS-3251 : Fixing "host" field of request header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37426/#review95632 --- 3rdparty/libprocess/src/http.cpp (line 798)

Review Request 37555: Included /usr/bin/sh in the test root filesystem.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37555/ --- Review request for mesos, Ben Mahler and Vinod Kone. Bugs: MESOS-3050 https

Re: Review Request 37512: Added user doc for Scheduler HTTP API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37512/#review95627 --- docs/scheduler_http_api.md (line 12)

Review Request 37549: Add jenkins script to run docker tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37549/ --- Review request for mesos. Repository: mesos Description --- Add jenkins

Re: Review Request 37531: MESOS-3070

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37531/#review95625 --- src/master/master.cpp (line 3218)

Review Request 37547: Used execlp instead of execl to exec processes in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37547/ --- Review request for mesos, Ben Mahler and Vinod Kone. Bugs: MESOS-3050 https

Review Request 37546: Used execlp instead of execl to exec processes in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37546/ --- Review request for mesos, Ben Mahler and Vinod Kone. Bugs: MESOS-3050 https

Review Request 37545: Used execlp instead of execl to exec processes in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37545/ --- Review request for mesos, Ben Mahler and Vinod Kone. Bugs: MESOS-3050 https

Review Request 37544: Fixed a bug in port mapping tests due to os::shell refactor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37544/ --- Review request for mesos, Ben Mahler and Vinod Kone. Repository: mesos Descri

Re: Review Request 33339: Add a Java example framework to test persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9/#review95611 --- src/examples/java/TestPersistentVolumeFramework.java (lines 535 - 5

Re: Review Request 37512: Added user doc for Scheduler HTTP API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37512/#review95591 --- This looks very thorough. Just some minor comments/nits around typos

Re: Review Request 37494: Fixed JSON wrapper to properly encode bytes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37494/#review95610 --- 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp (lines 49

Re: Review Request 37208: Fix the spell error in help message of slave component.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37208/#review95609 --- Ship it! Ship It! - Guangya Liu On 八月 17, 2015, 6:50 a.m., Yong

Re: Review Request 37460: Prevent perf test failures from killing the test harness.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37460/#review95607 --- src/tests/containerizer/perf_tests.cpp (lines 65 - 67)

Re: Review Request 37512: Added user doc for Scheduler HTTP API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37512/ --- (Updated Aug. 17, 2015, 6:26 p.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 37424: Timeout the perf future if the process does not complete.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37424/#review95606 --- src/linux/perf.cpp (line 199)

Re: Review Request 37208: Fix the spell error in help message of slave component.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37208/#review95603 --- Ship it! Ship It! - Niklas Nielsen On Aug. 16, 2015, 11:50 p.m.,

Re: Review Request 37208: Fix the spell error in help message of slave component.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37208/#review95602 --- Sorry it's taking so long - but I can't commit. I've asked one of my

Re: Review Request 37423: Split out common functions for running "perf" into a common perf class with wrapper functions to allow for reuse between sample, valid and version operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37423/#review95456 --- Ship it! Thanks Paul, just some cleanups and we can get this commit

Re: Review Request 37502: Add CMAKE_CXX_FLAGS to GMOCK_CONFIG_CMD in CMake.

> On Aug. 17, 2015, 5:45 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/3rdparty/CMakeLists.txt, line 174 > > > > > > I believe you need some more quotation marks. (So that the C++flags > > get properly assigned) >

Re: Review Request 37502: Add CMAKE_CXX_FLAGS to GMOCK_CONFIG_CMD in CMake.

> On Aug. 17, 2015, 5:45 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/3rdparty/CMakeLists.txt, line 174 > > > > > > I believe you need some more quotation marks. (So that the C++flags > > get properly assigned) >

Re: Review Request 37502: Add CMAKE_CXX_FLAGS to GMOCK_CONFIG_CMD in CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37502/#review95599 --- 3rdparty/libprocess/3rdparty/CMakeLists.txt (line 170)

Re: Review Request 37518: Add the revocable metrics information in monitoring doc

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37518/#review95597 --- Ship it! Ship It! - Vinod Kone On Aug. 17, 2015, 7:41 a.m., Yong

Re: Review Request 37493: Detect gflags when present and link when building Python module

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37493/#review95596 --- Patch looks great! Reviews applied: [37493] All tests passed. - M

Re: Review Request 37511: Fixed master to reject non-subscribe calls made before subscription.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37511/#review95590 --- Ship it! Ship It! - Anand Mazumdar On Aug. 16, 2015, 11:41 p.m.,

Review Request 37532: Add QUIESCE call interface to the scheduler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37532/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-3037 https://issues.ap

Review Request 37531: MESOS-3070

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37531/ --- Review request for mesos. Bugs: MESOS-3070 https://issues.apache.org/jira/b

Re: Review Request 37513: added Scrapinghub to "powered by mesos"

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37513/#review95583 --- Patch looks great! Reviews applied: [37513] All tests passed. - M

Re: Review Request 37511: Fixed master to reject non-subscribe calls made before subscription.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37511/#review95579 --- Patch looks great! Reviews applied: [37511] All tests passed. - M

Re: Review Request 37512: Added user doc for Scheduler HTTP API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37512/#review95572 --- Patch looks great! Reviews applied: [37512] All tests passed. - M

Re: Review Request 37518: Add the revocable metrics information in monitoring doc

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37518/ --- (Updated Aug. 17, 2015, 7:41 a.m.) Review request for mesos and Zhiwei Chen.

Review Request 37518: Add the revocable metrics information in monitoring doc

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37518/ --- Review request for mesos. Repository: mesos Description --- Add the revo