Review Request 41598: FreeBSD: use BSD cp in copy provisioner backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41598/ --- Review request for mesos and Ian Downes. Bugs: MESOS-4211 https://issues.ap

Re: Review Request 41596: FreeBSD: Fix includes in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41596/#review111444 --- Patch looks great! Reviews applied: [41596] Passed command: expor

Re: Review Request 41597: Extending allocator interface to support dynamic weights

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Dec. 21, 2015, 6:39 a.m.) Review request for mesos, Adam B and Qian Zh

Review Request 41597: Extending allocator interface to support dynamic weights

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- Review request for mesos, Adam B and Qian Zhang. Repository: mesos Descriptio

Review Request 41596: FreeBSD: Fix includes in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41596/ --- Review request for mesos and Ian Downes. Bugs: MESOS-4212 https://issues.ap

Re: Review Request 40429: Report executor exit to framework schedulers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40429/#review111440 --- src/sched/sched.cpp

Re: Review Request 41593: stout: Added `jsonify` function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41593/#review111438 --- 3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp (line

Re: Review Request 41593: stout: Added `jsonify` function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41593/ --- (Updated Dec. 21, 2015, 4:55 a.m.) Review request for mesos and Benjamin Hindma

Re: Review Request 41002: Logger Module: Introduce the ContainerLogger interface for logging the stdout/stderr of executors and tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41002/#review111436 --- include/mesos/slave/container_logger.hpp (lines 85 - 93)

Re: Review Request 41474: Added documentation for `defer` in libprocess README.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41474/#review111435 --- Ship it! Thanks Greg! I made a few more tweaks given the complicat

Re: Review Request 41002: Logger Module: Introduce the ContainerLogger interface for logging the stdout/stderr of executors and tasks.

> On Dec. 17, 2015, 12:56 p.m., Benjamin Hindman wrote: > > include/mesos/slave/container_logger.hpp, lines 73-75 > > > > > > Can we document what the failure case of using an IO::PIPE means? As > > in, what if someo

Re: Review Request 41004: Logger Module: Introduce the ContainerLogger module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41004/ --- (Updated Dec. 20, 2015, 4:39 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 41002: Logger Module: Introduce the ContainerLogger interface for logging the stdout/stderr of executors and tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41002/ --- (Updated Dec. 20, 2015, 4:39 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 41003: Logger Module: Add the SandboxContainerLogger, the default ContainerLogger implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41003/ --- (Updated Dec. 20, 2015, 4:39 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 41378: Logger Module: Update tests that use the DockerContainerizer to pass in a ContainerLogger.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41378/#review111433 --- So, are you sure we need `CreateContainerLogger` and not just `Con

Re: Review Request 41370: Logger Module: Update DockerContainerizer test helpers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41370/#review111432 --- Again, this looks mechanical given https://reviews.apache.org/r/412

Re: Review Request 41369: Logger Module: Add ContainerLogger support to the Mesos Docker executor

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41369/#review111431 --- This looks nicely mechanical given https://reviews.apache.org/r/412

Re: Review Request 41294: Logger Module: Adds the ContainerLogger into the DockerContainerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41294/#review111430 --- We shouldn't pass `ContainerLogger` into `Docker` while also keepin

Re: Review Request 41169: Logger Module: Update tests that use the MesosContainerizer to pass in an ContainerLogger

> On Dec. 20, 2015, 11:01 p.m., Benjamin Hindman wrote: > > This looks fine, assuming that we actually need `CreateContainerLogger` > > (see below). I looked ahead in the review chain and it doesn't look like you ever extend `CreateContainerLogger`, so why was it necessary? Why couldn't you ju

Re: Review Request 41169: Logger Module: Update tests that use the MesosContainerizer to pass in an ContainerLogger

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41169/#review111428 --- Ship it! This looks fine, assuming that we actually need `CreateCo

Re: Review Request 41168: Logger Module: Add ContainerLogger support to the MesosTest helpers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41168/#review111427 --- src/tests/mesos.hpp (line 152)

Re: Review Request 41167: Logger Module: Add support for the ContainerLogger to the Mesos Containerizer.

> On Dec. 14, 2015, 9:21 p.m., Jie Yu wrote: > > src/slave/main.cpp, lines 227-245 > > > > > > I am wondering why logger has to be injected, instead of being owned by > > containerizer? Let containerizer owning the

Re: Review Request 41167: Logger Module: Add support for the ContainerLogger to the Mesos Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41167/#review111425 --- I understand we'll be making some cleanups here, but otherwise this

Re: Review Request 41398: Added expectation for call to mocked function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41398/#review111424 --- Ship it! Ship It! - Till Toenshoff On Dec. 20, 2015, 10:39 p.m.

Re: Review Request 41166: Logger Module: Explicitly disallow use of the ContainerLogger with the External Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41166/#review111423 --- Ship it! src/slave/containerizer/containerizer.cpp (line 174)

Re: Review Request 41474: Added documentation for `defer` in libprocess README.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41474/#review111422 --- Patch looks great! Reviews applied: [41474] Passed command: expor

Re: Review Request 41474: Added documentation for `defer` in libprocess README.

> On Dec. 19, 2015, 3:03 a.m., Neil Conway wrote: > > 3rdparty/libprocess/README.md, line 211 > > > > > > What is this used for? I just removed the boilerplate methods that are not relevant to the discussion at han

Re: Review Request 41474: Added documentation for `defer` in libprocess README.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41474/ --- (Updated Dec. 20, 2015, 7:50 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 41474: Added documentation for `defer` in libprocess README.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41474/ --- (Updated Dec. 20, 2015, 7:46 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 41590: [WIP] Modulize the containerizer interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41590/ --- (Updated Dec. 20, 2015, 1:39 p.m.) Review request for mesos, Ben Mahler, Till T

Review Request 41590: [WIP] Modulize the containerizer interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41590/ --- Review request for mesos, Ben Mahler, Till Toenshoff, and Timothy Chen. Bugs: M