Re: Review Request 45964: Add unit tests for sharing of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45964/#review147976 --- Patch looks great! Reviews applied: [51553, 45961, 45964]

Re: Review Request 51672: Changed containerizer sub-container launch return bool type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51672/#review147975 --- Why this change? - Jie Yu On Sept. 6, 2016, 9:53 p.m., Gilbert

Re: Review Request 51673: Update mesos containerizer launch for sub-container support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51673/#review147974 --- src/slave/containerizer/mesos/containerizer.cpp (lines 1152 -

Re: Review Request 51671: Implement mesos conainertizer launch for sub-container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51671/#review147947 --- src/slave/containerizer/mesos/containerizer.cpp (line 1403)

Re: Review Request 49571: Added a benchmark test for allocations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49571/#review147966 --- Bad patch! Reviews applied: [49571, 45967, 45966, 45963, 45962]

Re: Review Request 51480: Added tests for launching task groups on the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51480/#review147965 --- Patch looks great! Reviews applied: [51475, 51476, 51477, 51478,

Re: Review Request 50836: Made add/subtract resource object as private method.

> On 八月 16, 2016, 11:44 p.m., Jiang Yan Xu wrote: > > include/mesos/resources.hpp, line 59 > > > > > > I think it would still work if you keep the `static` keyword right? > > > > The `friend` keyword

Review Request 51683: Avoided resource validation when flatten resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51683/ --- Review request for mesos, Benjamin Mahler and Jiang Yan Xu. Bugs: MESOS-6131

Re: Review Request 51477: Implemented `RunTaskGroupMessage` handler on the agent.

> On Sept. 1, 2016, 1:48 p.m., Qian Zhang wrote: > > src/slave/slave.cpp, line 2542 > > > > > > Here we send a `KillTaskMessage` to executor, but the task to be killed > > may be part of a task group, so that

Re: Review Request 51643: Modified network file setup in `network/cni` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51643/#review147956 --- Looks reasonable to me.

Re: Review Request 50836: Made add/subtract resource object as private method.

> On 八月 16, 2016, 11:44 p.m., Jiang Yan Xu wrote: > > include/mesos/resources.hpp, line 59 > > > > > > I think it would still work if you keep the `static` keyword right? > > > > The `friend` keyword

Re: Review Request 51670: Changed the containerizer launch interface for sub-container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51670/#review147944 --- src/slave/containerizer/containerizer.hpp (lines 96 - 97)

Re: Review Request 51631: Tracked recovered and prepared cgroups subsystems for containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51631/#review147943 --- Can you please add a test for this? - Qian Zhang On Sept. 6,

Re: Review Request 51669: Changed ContainerConfig::ExecutorInfo from required to optional.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51669/#review147942 --- Can you describe in the description field the purpse of this

Re: Review Request 51668: Changed the nested ContainerID from hashmap to list in memory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51668/#review147941 --- src/slave/containerizer/mesos/containerizer.hpp (line 333)

Re: Review Request 50695: Renamed agent used resources to `allocation` for benchmark test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50695/ --- (Updated 九月 6, 2016, 11:05 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 42861: Ensure two Mount Disk resources do not have the same root path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42861/#review147938 --- Thanks Haosdent! Looks good. Could you also add a test for this?

Re: Review Request 50326: Added script to build mesos-resolve.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50326/ --- (Updated Sept. 6, 2016, 10:06 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 50327: Added scripts to build sample framework executables.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50327/ --- (Updated Sept. 6, 2016, 10:06 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 50325: Added script to build mesos-log tool.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50325/ --- (Updated Sept. 6, 2016, 10:06 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45961/ --- (Updated Sept. 6, 2016, 10:02 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50695: Renamed agent used resources to `allocation` for benchmark test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50695/#review147932 --- Fix it, then Ship it!

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

> On Sept. 1, 2016, 5:43 p.m., Jiang Yan Xu wrote: > > Updated the review with the following changes. > > > > I have already committed all 'resources*.cpp's so they are removed from the > > review. > > I moved the tests to /r/45962/ so the remainder of the current set of tests > > are in one

Review Request 51669: Changed ContainerConfig::ExecutorInfo from required to optional.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51669/ --- Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph

Review Request 51673: Update mesos containerizer launch for sub-container support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51673/ --- Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph

Review Request 51671: Implement mesos conainertizer launch for sub-container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51671/ --- Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph

Review Request 51670: Changed the containerizer launch interface for sub-container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51670/ --- Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph

Review Request 51674: Supported mesos containerizer destroy to be nested aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51674/ --- Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph

Review Request 51675: Fixed mesos containerizer recover leak on provisioner orphan destroy.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51675/ --- Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph

Review Request 51672: Changed containerizer sub-container launch return bool type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51672/ --- Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph

Review Request 51668: Changed the nested ContainerID from hashmap to list in memory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51668/ --- Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph

Re: Review Request 45964: Add unit tests for sharing of resources.

> On Sept. 1, 2016, 7:30 p.m., Jiang Yan Xu wrote: > > Moved over some tests to their corresponding changes: > > > > https://github.com/apache/mesos/commit/d4970b78313943aecff7d0366621fbab43563c84 > > https://github.com/apache/mesos/commit/1d5ea3d48e95a10ba6064d9560718f75d14447fc > > > > Moved

Re: Review Request 49571: Added a benchmark test for allocations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49571/ --- (Updated Sept. 6, 2016, 9:44 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45966: Offer shared resources to frameworks only if opted in.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45966/ --- (Updated Sept. 6, 2016, 9:43 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 51480: Added tests for launching task groups on the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51480/ --- (Updated Sept. 6, 2016, 9:36 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 51479: Added mock overloads for `runTaskGroup()`/`launchGroup()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51479/ --- (Updated Sept. 6, 2016, 9:28 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 51478: Modified tests to account for `_runTask()` rename.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51478/ --- (Updated Sept. 6, 2016, 9:27 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 51477: Implemented `RunTaskGroupMessage` handler on the agent.

> On Sept. 2, 2016, 7:20 a.m., Qian Zhang wrote: > > src/slave/slave.hpp, line 908 > > > > > > Here the key of this map is all the task IDs of the `TaskGroupInfo`, > > but actually `TaskGroupInfo` already have such

Re: Review Request 51477: Implemented `RunTaskGroupMessage` handler on the agent.

> On Sept. 1, 2016, 5:48 a.m., Qian Zhang wrote: > > src/slave/slave.cpp, line 1882 > > > > > > I do not think we need this, because if we get here, `kill` must be > > still `false`. Good catch! I added an

Re: Review Request 51477: Implemented `RunTaskGroupMessage` handler on the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51477/ --- (Updated Sept. 6, 2016, 9:25 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 51475: Added an equality operator for `TaskGroupInfo`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51475/ --- (Updated Sept. 6, 2016, 9:15 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 51476: Made the `TaskInfo` argument in `launchExecutor()` optional.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51476/ --- (Updated Sept. 6, 2016, 9:16 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 50836: Made add/subtract resource object as private method.

> On Aug. 16, 2016, 4:44 p.m., Jiang Yan Xu wrote: > > include/mesos/resources.hpp, line 59 > > > > > > I think it would still work if you keep the `static` keyword right? > > > > The `friend` keyword

Re: Review Request 51643: Modified network file setup in `network/cni` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51643/ --- (Updated Sept. 6, 2016, 9:09 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 51501: Exposed metrics in scheduler library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51501/ --- (Updated Sept. 6, 2016, 8:53 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 51501: Exposed metrics in scheduler library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51501/ --- (Updated Sept. 6, 2016, 8:52 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 51654: Fixed help display for containerizer subcommands.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51654/#review147913 --- Patch looks great! Reviews applied: [51654] Passed command:

Re: Review Request 51565: Added a way to set logrotate settings per executor.

> On Sept. 5, 2016, 10:14 a.m., Vinod Kone wrote: > > src/slave/container_loggers/lib_logrotate.hpp, line 42 > > > > > > s/Options/Flags/ ? > > > > Also, can you add a comment for why you factored these out

Re: Review Request 51410: Enabled meta discovery using appc labels.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51410/ --- (Updated Sept. 6, 2016, 8:11 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 50960: Added appc uri fetcher tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50960/ --- (Updated Sept. 6, 2016, 8:11 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 51411: Added provisioner tests to provision using meta discovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51411/ --- (Updated Sept. 6, 2016, 8:11 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 50959: Added appc fetcher plugin to use rkt tool.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50959/ --- (Updated Sept. 6, 2016, 8:11 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 51623: Updated mesos-execute to support task groups.

> On Sept. 6, 2016, 6:24 p.m., Joseph Wu wrote: > > src/cli/execute.cpp, lines 111-121 > > > > > > There will be less code duplication if you made `--command` into an > > alias of `--commands`. You can parse a

Re: Review Request 50271: Created an isolator for Linux capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50271/#review147891 --- src/slave/containerizer/mesos/isolators/capabilities.hpp (line

Re: Review Request 50271: Created an isolator for Linux capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50271/#review147886 --- include/mesos/slave/containerizer.proto (line 144)

Re: Review Request 51607: Used mesos-tcp-connect binary in TCP health checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51607/#review147887 --- src/health-check/health_checker.cpp (line 117)

Re: Review Request 50270: Introduced linux capabilities support for mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50270/#review147872 --- src/slave/containerizer/mesos/launch.cpp (line 366)

Re: Review Request 51605: Added "mesos-tcp-connect" binary.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51605/#review147880 --- src/health-check/tcp_connect.cpp (line 74)

Re: Review Request 50707: Added test for agent removal behavior.

> On Sept. 6, 2016, 2:36 p.m., Vinod Kone wrote: > > src/tests/slave_tests.cpp, line 2907 > > > > > > I think pausing the rate limiter here is a bit confusing because you > > are essentially stopping

Re: Review Request 51623: Updated mesos-execute to support task groups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51623/#review147883 --- src/cli/execute.cpp (lines 111 - 121)

Re: Review Request 45966: Offer shared resources to frameworks only if opted in.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45966/ --- (Updated Sept. 6, 2016, 6:17 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 51553: Changed the way `HAP::updateAllocation()` calls `Resources.apply()`.

> On Sept. 2, 2016, 5:39 a.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 686-689 > > > > > > Since here you are applying the `operations` one by one, I think that > > it is better to

Re: Review Request 51553: Changed the way `HAP::updateAllocation()` calls `Resources.apply()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51553/ --- (Updated Sept. 6, 2016, 11:15 a.m.) Review request for mesos and Anindya

Re: Review Request 45962: Added a persistent volume test framework for shared volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45962/ --- (Updated Sept. 6, 2016, 6:15 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45961/ --- (Updated Sept. 6, 2016, 6:13 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 45964: Add unit tests for sharing of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45964/ --- (Updated Sept. 6, 2016, 6:13 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 51605: Added "mesos-tcp-connect" binary.

> On Sept. 2, 2016, 4:53 p.m., haosdent huang wrote: > > src/Makefile.am, line 1377 > > > > > > I think the name `mesos-tcp-connect` may be not clear enough. Should we > > add something like `health-check` into

Re: Review Request 46980: Implemented adding a cni network config via 'cni/config' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46980/#review147873 --- We can discard this right? Or are we still doing this? - Avinash

Re: Review Request 51650: Removed dependency on external Docker image for mesos-tidy.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51650/#review147861 --- Patch looks great! Reviews applied: [51650] Passed command:

Re: Review Request 51325: Removed unused function `os::dirent_size`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51325/#review147859 --- Ship it! Ship It! - Alexander Rukletsov On Aug. 23, 2016,

Re: Review Request 51324: Replaced use of `readdir_r` with `readdir`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51324/#review147858 --- Ship it! Ship It! - Alexander Rukletsov On Sept. 5, 2016,

Re: Review Request 51643: Modified network file setup in `network/cni` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51643/ --- (Updated Sept. 6, 2016, 4:10 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 51627: Performed systemd::exist() check if systemd support is enabled.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51627/#review147854 --- Ship it! This change should be ok; however, I would question

Re: Review Request 50706: Added test cases for PARTITION_AWARE behavior.

> On Sept. 6, 2016, 2:14 p.m., Vinod Kone wrote: > > src/tests/partition_tests.cpp, line 710 > > > > > > hmm. didn't realize that the TODO in `Master::reconcile` regarding > > assumption is actually wrong! tasks

Review Request 51643: Modified network file setup in `network/cni` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51643/ --- Review request for mesos. Repository: mesos Description --- In case

Re: Review Request 51607: Used mesos-tcp-connect binary in TCP health checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51607/#review147846 --- src/health-check/health_checker.cpp (line 519)

Re: Review Request 51606: Libprocess: Added target for "mesos-tcp-connect" binary.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51606/#review147845 --- 3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake (lines

Re: Review Request 50707: Added test for agent removal behavior.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50707/ --- (Updated Sept. 6, 2016, 3:27 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 50706: Added test cases for PARTITION_AWARE behavior.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50706/ --- (Updated Sept. 6, 2016, 3:24 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 50706: Added test cases for PARTITION_AWARE behavior.

> On Sept. 6, 2016, 2:14 p.m., Vinod Kone wrote: > > src/tests/partition_tests.cpp, line 723 > > > > > > `SlaveObserver` Fixed the other places where this occurs as well. > On Sept. 6, 2016, 2:14 p.m., Vinod Kone

Re: Review Request 51374: Change registry update order on removal, mark-unreachable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51374/ --- (Updated Sept. 6, 2016, 3:09 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 50845: Added `unreachable_time` to TaskStatus.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50845/ --- (Updated Sept. 6, 2016, 3:08 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 51653: Handled agents failing health checks multiple times.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51653/#review147842 --- Bad patch! Reviews applied: [51653, 51021, 51377, 51376, 51375,

Re: Review Request 50271: Created an isolator for Linux capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50271/ --- (Updated Sept. 6, 2016, 5:04 p.m.) Review request for mesos, Jay Guo and Jie

Re: Review Request 50270: Introduced linux capabilities support for mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50270/ --- (Updated Sept. 6, 2016, 5:04 p.m.) Review request for mesos, Jay Guo and Jie

Re: Review Request 50705: Changed master to allow partitioned slaves to reregister.

> On Sept. 6, 2016, 1:42 p.m., Vinod Kone wrote: > > src/master/master.cpp, line 5168 > > > > > > s/reregisters/re-registers/ > > > > AFAIK we use a dash for "re-register" whenever it is used in comments

Review Request 51650: Removed dependency on external Docker image for mesos-tidy.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51650/ --- Review request for mesos and Michael Park. Repository: mesos Description

Review Request 51654: Fixed help display for containerizer subcommands.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51654/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 50705: Changed master to allow partitioned slaves to reregister.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50705/ --- (Updated Sept. 6, 2016, 2:57 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 50844: Fixed outdated comment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50844/#review147840 --- Ship it! Ship It! - Vinod Kone On Aug. 5, 2016, 10:38 a.m.,

Re: Review Request 50707: Added test for agent removal behavior.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50707/#review147836 --- src/tests/slave_tests.cpp (line 2810)

Re: Review Request 50705: Changed master to allow partitioned slaves to reregister.

> On Sept. 6, 2016, 1:42 p.m., Vinod Kone wrote: > > src/master/master.cpp, line 5168 > > > > > > s/reregisters/re-registers/ > > > > AFAIK we use a dash for "re-register" whenever it is used in comments

Re: Review Request 51651: Updated sorting in 'MountInfoTable::read()' to use iterative algorithm.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51651/ --- (Updated Sept. 6, 2016, 2:18 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 50705: Changed master to allow partitioned slaves to reregister.

> On Sept. 6, 2016, 1:42 p.m., Vinod Kone wrote: > > src/master/master.cpp, line 5168 > > > > > > s/reregisters/re-registers/ > > > > AFAIK we use a dash for "re-register" whenever it is used in comments

Re: Review Request 50706: Added test cases for PARTITION_AWARE behavior.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50706/#review147827 --- Fix it, then Ship it! src/tests/partition_tests.cpp (line

Re: Review Request 51651: Updated sorting in 'MountInfoTable::read()' to use iterative algorithm.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51651/#review147832 --- Patch looks great! Reviews applied: [51651] Passed command:

Review Request 51653: Handled agents failing health checks multiple times.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51653/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5965

Re: Review Request 50705: Changed master to allow partitioned slaves to reregister.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50705/#review147825 --- Fix it, then Ship it! src/master/master.cpp (line 5132)

Review Request 51651: Updated sorting in 'MountInfoTable::read()' to use iterative algorithm.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51651/ --- Review request for mesos, Gilbert Song, Jie Yu, and Joseph Wu. Bugs:

Re: Review Request 51631: Tracked recovered and prepared cgroups subsystems for containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51631/#review147806 --- src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp

  1   2   >