Re: Review Request 50947: Removed isolator flag 'gpu/nvidia' for docker containerizer using GPU.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50947/ --- (Updated 九月 22, 2016, 6:21 a.m.) Review request for mesos, Benjamin Mahler, Gua

Re: Review Request 50127: Added DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50127/ --- (Updated 九月 22, 2016, 6:21 a.m.) Review request for mesos, Benjamin Mahler, Kev

Re: Review Request 50125: Added mesos-docker-executor support for devices control.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50125/ --- (Updated 九月 22, 2016, 6:21 a.m.) Review request for mesos, Benjamin Mahler, Kev

Re: Review Request 50599: Assigned Nvidia GPU devices to docker container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50599/ --- (Updated 九月 22, 2016, 6:20 a.m.) Review request for mesos, Benjamin Mahler, Gua

Re: Review Request 50128: Added helper functions to 'Docker::Device'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/ --- (Updated 九月 22, 2016, 6:20 a.m.) Review request for mesos, Benjamin Mahler, Kev

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

> On 八月 28, 2016, 12:57 a.m., Kevin Klues wrote: > > src/slave/containerizer/docker.hpp, line 506 > > > > > > Shoud we use `set` here like we do in the mesos containerizer? Yes, changed it to `set`. > On 八月 28, 20

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50841/ --- (Updated 九月 22, 2016, 6:16 a.m.) Review request for mesos, Benjamin Mahler, Gua

Review Request 52142: Adjust indentation alignment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52142/ --- Review request for mesos, Jie Yu and Vinod Kone. Repository: mesos Descriptio

Re: Review Request 50123: Added GPU scheduler for docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50123/ --- (Updated 九月 22, 2016, 6:09 a.m.) Review request for mesos, Benjamin Mahler, Kev

Re: Review Request 52135: Implemented the *_NESTED_CONTAINER calls in the agent API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52135/ --- (Updated Sept. 22, 2016, 6:06 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 52134: Pulled out the mock containerizer into a header for reuse.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52134/ --- (Updated Sept. 22, 2016, 6:06 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 52057: Introduced an agent API for managing nested containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52057/ --- (Updated Sept. 22, 2016, 6:05 a.m.) Review request for mesos, Anand Mazumdar, B

Re: Review Request 52100: Added validation of *_NESTED_CONTAINER calls in the agent API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52100/ --- (Updated Sept. 22, 2016, 6:05 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 52057: Introduced an agent API for managing child containers.

> On Sept. 20, 2016, 11:30 p.m., Vinod Kone wrote: > > Updated summary and description to say "nested" instead of "child" > > containers. Ah, good catch thanks. > On Sept. 20, 2016, 11:30 p.m., Vinod Kone wrote: > > include/mesos/v1/agent/agent.proto, line 103 > >

Re: Review Request 52100: Added validation of NESTED_CONTAINER_* calls in the agent API.

> On Sept. 21, 2016, 2:39 a.m., Guangya Liu wrote: > > src/Makefile.am, line 2121 > > > > > > Just a question here: for the new added test files for agent, do we > > want to continue name it as slave_xxx_tests.cpp

Re: Review Request 52100: Added validation of NESTED_CONTAINER_* calls in the agent API.

> On Sept. 20, 2016, 11:48 p.m., Vinod Kone wrote: > > src/slave/validation.cpp, lines 117-127 > > > > > > so `UUID::fromBytes()` (used for status update uuids) doesn't impose a > > restriction on the version but we

Review Request 52151: Fixed a wrong comment in `LocalPuller`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52151/ --- Review request for mesos, Jie Yu and Timothy Chen. Repository: mesos Descript

Re: Review Request 52135: Implemented the NESTED_CONTAINER_* calls in the agent API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52135/#review149946 --- Patch looks great! Reviews applied: [52053, 52054, 52055, 52056,

Re: Review Request 52118: Added support for opaque whiteout file `.wh..wh..opq`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52118/#review149939 --- Patch looks great! Reviews applied: [52118] Passed command: expo

Re: Review Request 52118: Added support for opaque whiteout file `.wh..wh..opq`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52118/ --- (Updated Sept. 22, 2016, 10:29 a.m.) Review request for mesos and Jie Yu. Cha

Re: Review Request 52048: Fixed OsTest.User test failure due to gids ordering.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52048/#review149936 --- Looks sane :) 3rdparty/stout/tests/os_tests.cpp (line 691)

Re: Review Request 51560: Deprecated using health checks without setting the type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51560/#review149937 --- Patch looks great! Reviews applied: [51561, 51803, 51560] Passed

Re: Review Request 51857: Modified the `network/cni` isolator to be nesting aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51857/#review149935 --- Ship it! Ship It! - Jie Yu On Sept. 21, 2016, 8:18 p.m., Avi

Re: Review Request 51857: Modified the `network/cni` isolator to be nesting aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51857/#review149934 --- src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (line

Re: Review Request 52075: Added the test `HTTPCommandExecutorTest.TerminateWithACK`.

> On Sept. 22, 2016, 1:18 a.m., Vinod Kone wrote: > > i'll fix the typos while committing. actually looks like you need to rebase. - Vinod --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5207

Re: Review Request 52075: Added the test `HTTPCommandExecutorTest.TerminateWithACK`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52075/#review149932 --- Fix it, then Ship it! i'll fix the typos while committing. sr

Re: Review Request 49571: Added a benchmark test for allocations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49571/ --- (Updated Sept. 22, 2016, 12:35 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45081: Excluded reserved resources when got nonRevocable resources in stage 1.

> On Aug. 11, 2016, 6:16 p.m., Michael Park wrote: > > Hi Klaus, could you explain what the motivation is for this patch? > > Currently, your analysis seems correct that reserved resources are always > > non-revocable. > > However, the current code seems that it'll be more future-proof. > > That

Re: Review Request 45967: Added documentation for shareable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45967/ --- (Updated Sept. 22, 2016, 12:35 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45962: Added a persistent volume test framework for shared volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45962/ --- (Updated Sept. 22, 2016, 12:34 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45963: Allow tasks to set persistent volume as readonly or readwrite resource.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45963/ --- (Updated Sept. 22, 2016, 12:35 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45962: Added a persistent volume test framework for shared volumes.

> On Sept. 18, 2016, 6:35 p.m., haosdent huang wrote: > > src/examples/persistent_shared_volume_framework.cpp, lines 207-209 > > > > > > Nit: > > ``` > > "COUNTER=0;" > >

Re: Review Request 52002: Added helper methods to determine types of disk resources.

> On Sept. 20, 2016, 10:29 p.m., Jiang Yan Xu wrote: > > include/mesos/resources.hpp, lines 276-278 > > > > > > Would it be simpler to just have > > > > ``` > > static bool Resources::isMountDisk(const

Re: Review Request 52105: Add smarter master redirects.

> On Sept. 21, 2016, 3:18 p.m., haosdent huang wrote: > > Hi, @drcrallen Thanks a lot for your patch! > > > > I saw your patch try to redirect > > `http://SOME_MASTER:5050/master/redirect/master/frameworks` to > > `http://LEADER_MASTER:5050/master/frameworks`. Could you elaborate the user > >

Re: Review Request 41613: Added `DEFAULT_ROLE` constant to persistent volume tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41613/#review149919 --- Patch looks great! Reviews applied: [41613] Passed command: expo

Re: Review Request 52002: Added helper methods to determine types of disk resources.

> On Sept. 20, 2016, 3:29 p.m., Jiang Yan Xu wrote: > > include/mesos/resources.hpp, lines 276-278 > > > > > > Would it be simpler to just have > > > > ``` > > static bool Resources::isMountDisk(const R

Re: Review Request 52056: Exposed unknown container case from Containerizer::destroy.

> On Sept. 20, 2016, 11:06 p.m., Vinod Kone wrote: > > src/slave/containerizer/composing.cpp, line 487 > > > > > > Maybe add at the end "If we do not defer here and instead associate the > > future right away, the s

Re: Review Request 52056: Exposed unknown container case from Containerizer::destroy.

> On Sept. 20, 2016, 1:27 p.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/containerizer.hpp, lines 107-108 > > > > > > one line? All other functions above are wrapped even if they fit on another line, so

Re: Review Request 40411: Libprocess Reinit: Modify test to use PID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40411/#review149914 --- Ship it! Ship It! - Greg Mann On Sept. 20, 2016, 12:41 a.m.,

Re: Review Request 40410: Libprocess Reinit: Move MetricsProcess instantiation into process.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40410/#review149913 --- Ship it! Ship It! - Greg Mann On July 29, 2016, 11:56 p.m.,

Re: Review Request 52055: Exposed unknown container case from Containerizer::wait.

> On Sept. 20, 2016, 7:45 a.m., Guangya Liu wrote: > > src/tests/containerizer/docker_containerizer_tests.cpp, line 3785 > > > > > > Why need `recover` here? > > Vinod Kone wrote: > yea, can you add a comment o

Re: Review Request 50857: Modified a scheduler test to run with SSL enabled.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50857/ --- (Updated Sept. 21, 2016, 10:20 p.m.) Review request for mesos, Joseph Wu and Vi

Re: Review Request 52092: Avoided to concat cgroup internally in subsystems.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52092/#review149907 --- Bad patch! Reviews applied: [52092] Failed command: ./support/ap

Re: Review Request 50621: Libprocess reinit: Moved HttpProxy finalization and destruction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50621/#review149908 --- Ship it! Ship It! - Greg Mann On Aug. 12, 2016, 10:02 p.m.,

Re: Review Request 51049: Libprocess Reinit: Removed authorizer callback leaks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51049/#review149906 --- Ship it! Ship It! - Greg Mann On Aug. 12, 2016, 10:02 p.m.,

Re: Review Request 52055: Exposed unknown container case from Containerizer::wait.

> On Sept. 20, 2016, 7:45 a.m., Guangya Liu wrote: > > src/tests/hook_tests.cpp, lines 326-327 > > > > > > This can fit to one line It's not a hard rule that it has to be placed on a single line if it can fit. In s

Re: Review Request 52055: Exposed unknown container case from Containerizer::wait.

> On Sept. 20, 2016, 9:10 a.m., Guangya Liu wrote: > > src/slave/containerizer/docker.cpp, line 1793 > > > > > > It's good to updat here as `at`, do you think we need a swept for this? I tried to only touch the one

Re: Review Request 52054: Updated slave test to expect 500 rather than 503 from libprocess.

> On Sept. 19, 2016, 7:24 p.m., Vinod Kone wrote: > > src/tests/slave_tests.cpp, line 1919 > > > > > > should we call this out in the CHANGELOG? best to create a ticket to > > link the reviews. Filed a ticket here

Review Request 52135: Implemented the NESTED_CONTAINER_* calls in the agent API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52135/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-2449 https://issues.ap

Review Request 52134: Pulled out the mock containerizer into a header for reuse.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52134/ --- Review request for mesos and Vinod Kone. Repository: mesos Description --

Re: Review Request 49063: Updating formatting of some lambda calls for readability.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49063/#review149895 --- Patch looks great! Reviews applied: [49063] Passed command: expo

Re: Review Request 52097: Functionality to switch user when executor launches as non-root user.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52097/#review149890 --- src/slave/container_loggers/logrotate.cpp (lines 203 - 205)

Re: Review Request 52129: Windows: Fixed subprocess and setsid compilation errors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52129/ --- (Updated Sept. 21, 2016, 1:31 p.m.) Review request for mesos, Daniel Pravat, Ar

Re: Review Request 52097: Functionality to switch user when executor launches as non-root user.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52097/#review149888 --- You have odd spacing throughout your patch. We use 2 spaces per i

Re: Review Request 51857: Modified the `network/cni` isolator to be nesting aware.

> On Sept. 21, 2016, 12:54 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, lines 1647-1652 > > > > > > What if the top level container join non-host network but its child > > co

Re: Review Request 51857: Modified the `network/cni` isolator to be nesting aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51857/ --- (Updated Sept. 21, 2016, 8:18 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 52096: Read user details passed in executorInfo and assign it to user flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52096/#review149886 --- src/slave/container_loggers/lib_logrotate.cpp (lines 142 - 145) <

Re: Review Request 52095: Add the new flag for executor launching with different user.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52095/#review149879 --- src/slave/container_loggers/lib_logrotate.hpp (line 89)

Re: Review Request 52002: Added helper methods to determine types of disk resources.

> On Sept. 20, 2016, 10:29 p.m., Jiang Yan Xu wrote: > > include/mesos/resources.hpp, lines 273-274 > > > > > > Does it need to be a Try? i.e., if it's not a disk, it's not a root > > disk, right? We have `validate(

Re: Review Request 52129: Windows: Fixed subprocess and setsid compilation errors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52129/#review149885 --- Ship it! Ship It! - Jie Yu On Sept. 21, 2016, 7:20 p.m., Jos

Re: Review Request 51124: Support more layers through symlink for overlay backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51124/#review149874 --- src/slave/containerizer/mesos/provisioner/backends/aufs.cpp (line

Review Request 52129: Windows: Fixed subprocess and setsid compilation errors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52129/ --- Review request for mesos, Daniel Pravat, Artem Harutyunyan, and Jie Yu. Reposit

Re: Review Request 52118: Added support for opaque whiteout file `.wh..wh..opq`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52118/#review149876 --- src/slave/containerizer/mesos/provisioner/provisioner.cpp (lines

Re: Review Request 51715: Added a parallel gtest runner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51715/#review149849 --- Looking good! Just a few more comments. support/mesos-gtest-runn

Re: Review Request 51857: Modified the `network/cni` isolator to be nesting aware.

> On Sept. 21, 2016, 12:54 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, line 615 > > > > > > We need to return failure if parent does not exist. > > Avinash sridharan wrote: >

Re: Review Request 51124: Support more layers through symlink for overlay backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51124/#review149863 --- THe patch looks good to me. I'd like to adjust the test to better

Re: Review Request 51857: Modified the `network/cni` isolator to be nesting aware.

> On Sept. 21, 2016, 12:54 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, line 378 > > > > > > Should we skip nested container recover here? It's better to be > > explicit. Yea

Re: Review Request 51803: Ensured `HealthCheck::HTTPCheckInfo` compatible with the old one.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51803/ --- (Updated Sept. 21, 2016, 6:21 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 51560: Deprecated using health checks without setting the type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51560/ --- (Updated Sept. 21, 2016, 6:21 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 43138: Updated a comment for oversubscribed resources for clarity.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43138/#review149871 --- Patch looks great! Reviews applied: [43105, 44331, 43138] Passed

Re: Review Request 51560: Deprecated using health checks without setting the type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51560/ --- (Updated Sept. 21, 2016, 6:19 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 51560: Deprecated using health checks without setting the type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51560/ --- (Updated Sept. 21, 2016, 6:18 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 51803: Ensured `HealthCheck::HTTPCheckInfo` compatible with the old one.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51803/ --- (Updated Sept. 21, 2016, 6:17 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 51561: Fixed the overview table style in upgrades.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51561/ --- (Updated Sept. 21, 2016, 6:17 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 41613: Added `DEFAULT_ROLE` constant to persistent volume tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41613/ --- (Updated Sept. 21, 2016, 6:04 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 51027: WIP: Track allocation candidates to bound allocator.

> On Sept. 12, 2016, 8:46 p.m., Benjamin Mahler wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 273-274 > > > > > > It seems a bit odd that the caller has to both touch allocation > > candidates and th

Re: Review Request 51027: WIP: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/ --- (Updated Sept. 21, 2016, 5:42 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/ --- (Updated Sept. 21, 2016, 5:41 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 52092: Avoided to concat cgroup internally in subsystems.

> On Sept. 20, 2016, 9:33 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, line 332 > > > > > > I'd prefer we pass in both containerId and cgroup. Ditto else where. > > ContainerI

Re: Review Request 52092: Avoided to concat cgroup internally in subsystems.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52092/ --- (Updated Sept. 21, 2016, 5:26 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 52113: Fixed an uninitialized variable warning.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52113/#review149851 --- Ship it! Ship It! - Jie Yu On Sept. 21, 2016, 8:58 a.m., Nei

Re: Review Request 52090: Fixed compile error in ppc64le.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52090/#review149848 --- Ship it! Ship It! - Jie Yu On Sept. 21, 2016, 4:44 p.m., hao

Re: Review Request 52091: Replaced `set` to `hashset` in perf interfaces.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52091/ --- (Updated Sept. 21, 2016, 4:51 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 52121: Converted watchdog option into childhook in Mesos [2/2].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52121/#review149845 --- Ship it! Ship It! - Jie Yu On Sept. 21, 2016, 3:16 p.m., Joe

Re: Review Request 52120: Converted watchdog option into a childhook in libprocess [1/2].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52120/#review149844 --- Ship it! Ship It! - Jie Yu On Sept. 21, 2016, 3:16 p.m., Joe

Re: Review Request 52018: Renamed Hook to ParentHook in Mesos [2/2].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52018/#review149843 --- Ship it! Ship It! - Jie Yu On Sept. 21, 2016, 3:21 p.m., Joe

Re: Review Request 52017: Renamed Hook to parent Hook in libprocess [1/2].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52017/#review149842 --- Ship it! Ship It! - Jie Yu On Sept. 21, 2016, 3:22 p.m., Joe

Re: Review Request 52015: Used {} instead of Hook::None() in libprocess [1/2].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52015/#review149840 --- Ship it! Ship It! - Jie Yu On Sept. 21, 2016, 3:23 p.m., Joe

Re: Review Request 52016: Replaces Hook::None() by {} in Mesos [2/2].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52016/#review149841 --- Ship it! Ship It! - Jie Yu On Sept. 18, 2016, 7:48 p.m., Joe

Re: Review Request 45492: Used ChildHooks in Mesos [2/2].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45492/#review149839 --- Ship it! Ship It! - Jie Yu On Sept. 21, 2016, 3:24 p.m., Joe

Re: Review Request 52090: Fixed compile error in ppc64le.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52090/ --- (Updated Sept. 21, 2016, 4:44 p.m.) Review request for mesos, Zhiwei Chen, Gilb

Re: Review Request 45491: Refactored subprocess options [1/2].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45491/#review149838 --- Ship it! Ship It! - Jie Yu On Sept. 21, 2016, 3:25 p.m., Joe

Re: Review Request 52090: Fixed compile error in ppc64le.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52090/ --- (Updated Sept. 21, 2016, 4:42 p.m.) Review request for mesos, Zhiwei Chen, Gilb

Re: Review Request 52118: Added support for opaque whiteout file `.wh..wh..opq`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52118/#review149837 --- Can you add a test? Like an image having opaque file. - Jie Yu

Re: Review Request 52090: Fixed compile error in ppc64le.

> On Sept. 20, 2016, 9:30 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.cpp, > > lines 110-115 > > > > > > you can use os::pagesize() here Orz, thank you very much! Didn'

Re: Review Request 49063: Updating formatting of some lambda calls for readability.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49063/ --- (Updated Sept. 21, 2016, 4:03 p.m.) Review request for mesos, Joerg Schad and M

Re: Review Request 45081: Excluded reserved resources when got nonRevocable resources in stage 1.

> On Aug. 11, 2016, 10:16 a.m., Michael Park wrote: > > Hi Klaus, could you explain what the motivation is for this patch? > > Currently, your analysis seems correct that reserved resources are always > > non-revocable. > > However, the current code seems that it'll be more future-proof. > > Tha

Re: Review Request 45491: Refactored subprocess options [1/2].

> On April 5, 2016, 6:40 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/include/process/subprocess.hpp, line 219 > > > > > > Do we use this `operator() ()` style elsewhere? > > Joerg Schad wrote: > If

Re: Review Request 45491: Refactored subprocess options [1/2].

> On April 7, 2016, 6:25 p.m., haosdent huang wrote: > > 3rdparty/libprocess/src/subprocess.cpp, line 67 > > > > > > I think we could use `os::chdir` here? > > > > ``` > > inline Try chdir(const std::stri

Re: Review Request 41613: Added `DEFAULT_ROLE` constant to persistent volume tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41613/ --- (Updated Sept. 21, 2016, 3:35 p.m.) Review request for mesos, Alexander Ruklets

  1   2   >