Re: Review Request 50871: Supported auto backend in Unified Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50871/#review163101 --- Patch looks great! Reviews applied: [54216, 54212, 54213, 54214,

Re: Review Request 55909: Added a function for available agent resources in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55909/#review163099 --- Ship it! Ship It! - Guangya Liu On 一月 25, 2017, 2:31 a.m., B

Re: Review Request 55908: Made a function static in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55908/#review163097 --- Ship it! Ship It! - Guangya Liu On 一月 25, 2017, 2:25 a.m., B

Re: Review Request 55868: Cleanups to the allocator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55868/#review163096 --- src/tests/hierarchical_allocator_tests.cpp (line 1870)

Re: Review Request 55868: Cleanups to the allocator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55868/#review163087 --- src/tests/hierarchical_allocator_tests.cpp

Re: Review Request 55937: Added constants for referring to request/response streaming headers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55937/ --- (Updated Jan. 26, 2017, 5:04 a.m.) Review request for mesos and Vinod Kone. C

Review Request 55978: Added some assertions to the switchboard request handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55978/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6936 https://issues.ap

Re: Review Request 55940: Added support for the new streaming request/response headers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55940/ --- (Updated Jan. 26, 2017, 5:03 a.m.) Review request for mesos and Vinod Kone. C

Re: Review Request 55940: Added support for the new streaming request/response headers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55940/ --- (Updated Jan. 26, 2017, 4:51 a.m.) Review request for mesos and Vinod Kone. C

Re: Review Request 55940: Added support for the new streaming request/response headers.

> On Jan. 26, 2017, 12:58 a.m., Vinod Kone wrote: > > src/slave/containerizer/mesos/io/switchboard.cpp, lines 1299-1322 > > > > > > Not yours, but I'm wondering if these should be CHECKs because the > > agent API h

Re: Review Request 55941: Modified existing tests to support new headers for request streaming.

> On Jan. 26, 2017, 1:11 a.m., Vinod Kone wrote: > > src/tests/api_tests.cpp, line 4761 > > > > > > you wanted to test the backwards compatibility here? i.e., setting > > accept to "application/json" and not "appli

Re: Review Request 55941: Modified existing tests to support new headers for request streaming.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55941/ --- (Updated Jan. 26, 2017, 4:50 a.m.) Review request for mesos and Vinod Kone. C

Re: Review Request 55942: Added a test for validating streaming request/response headers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55942/ --- (Updated Jan. 26, 2017, 4:49 a.m.) Review request for mesos and Vinod Kone. C

Re: Review Request 55946: Added agent capabilities as part of agent (re-)registration process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55946/ --- (Updated Jan. 26, 2017, 12:40 p.m.) Review request for mesos and Benjamin Mahle

Re: Review Request 55944: Modified agent capabilities struct to reflect protobuf changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55944/ --- (Updated Jan. 26, 2017, 12:40 p.m.) Review request for mesos and Benjamin Mahle

Re: Review Request 55943: Moved agent capabilities from SlaveInfo to (re-)registerSlaveMessage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55943/ --- (Updated Jan. 26, 2017, 12:39 p.m.) Review request for mesos and Benjamin Mahle

Re: Review Request 53993: Updated quota doc to support quota update.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53993/#review163094 --- May you mind add @neilc in reviewers? docs/quota.md (line 85)

Re: Review Request 54987: Updated `docs/monitoring/md` for new slave event queue metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54987/#review163092 --- Fix it, then Ship it! Ship It! docs/monitoring.md (lines 1532

Re: Review Request 54987: Updated `docs/monitoring/md` for new agent event queue metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54987/ --- (Updated Jan. 26, 2017, 4:29 a.m.) Review request for mesos, Anand Mazumdar, Xi

Re: Review Request 55970: Updated the master's HTTP operations to handle MULTI_ROLE changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55970/#review163091 --- Bad patch! Reviews applied: [55970, 55969, 55968, 55967, 55870, 5

Re: Review Request 55732: Added `--3way` option to apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55732/#review163089 --- Fix it, then Ship it! Ship It! support/apply-reviews.py (line

Re: Review Request 55732: Added `--3way` option to apply-reviews.py.

> On Jan. 20, 2017, 6:24 a.m., haosdent huang wrote: > > support/apply-reviews.py, lines 120-121 > > > > > > Is this change necessary? > > Zhitao Li wrote: > From what I observed, in `--3way` mode, git apply see

Re: Review Request 55964: Updates for executor, scheduler V1 API docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55964/#review163085 --- Patch looks great! Reviews applied: [55964] Passed command: expo

Re: Review Request 55954: Changed 'Environment.Variable.Value' from required to optional.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55954/ --- (Updated Jan. 26, 2017, 2:36 a.m.) Review request for mesos, Jan Schlicht and V

Re: Review Request 55955: Added validation tests to ensure environment variable value is set.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55955/ --- (Updated Jan. 26, 2017, 2:36 a.m.) Review request for mesos, Jan Schlicht and V

Re: Review Request 55893: Fixed OversubscriptionTest.RescindRevocableOfferWithIncreasedRevocable.

> On Jan. 25, 2017, 1:55 a.m., Guangya Liu wrote: > > @Yan, I posted some comments at https://reviews.apache.org/r/51027/ for > > this issue with some comments as: > > > > ``` > > Jacob, regaring the test failure of > > OversubscriptionTest.RescindRevocableOfferWithIncreasedRevocable, I think

Re: Review Request 55824: Updated hierarchical allocator tests to use -> operator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55824/#review163075 --- Ship it! I doubled checked that all of `.get().` has been repla

Re: Review Request 55866: Added CHECK failure logging to the sorter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55866/#review163074 --- Ship it! Ship It! - Guangya Liu On 一月 24, 2017, 12:28 a.m.,

Re: Review Request 55955: Added validation tests to ensure environment variable value is set.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55955/#review163073 --- Bad patch! Reviews applied: [55955, 55954] Failed command: pytho

Re: Review Request 54215: Fixed duplicate image layer ids returned by docker store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54215/ --- (Updated Jan. 25, 2017, 5:37 p.m.) Review request for mesos, Avinash sridharan,

Re: Review Request 50871: Supported auto backend in Unified Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50871/ --- (Updated Jan. 25, 2017, 5:37 p.m.) Review request for mesos, Avinash sridharan,

Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

> On Dec. 19, 2016, 12:01 a.m., Jiang Yan Xu wrote: > > src/examples/persistent_volume_framework.cpp, lines 244-248 > > > > > > Good find. However I think the fix would be cleaner if we just update > > the state

Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

> On Jan. 25, 2017, 5:27 p.m., Jiang Yan Xu wrote: > > Just a minor comment plus the reply to a previous comment. This can go in before /r/55359/ since that is a refactor. - Jiang Yan --- This is an automatically generated e-mail. To re

Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45962/#review163070 --- Fix it, then Ship it! Just a minor comment plus the reply to a

Re: Review Request 55829: Updated resources quantity stripping to strip AllocationInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55829/#review163069 --- Ship it! Ship It! - Guangya Liu On 一月 23, 2017, 2:09 a.m., B

Re: Review Request 55942: Added a test for validating streaming request/response headers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55942/#review163066 --- Fix it, then Ship it! src/tests/api_tests.cpp (line 4694)

Re: Review Request 55941: Modified existing tests to support new headers for request streaming.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55941/#review163065 --- Fix it, then Ship it! src/tests/api_tests.cpp (line 4572)

Re: Review Request 55359: Consolidate update of allocations in `updateAllocation()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55359/#review163031 --- My feeling is that we were using too many variables for the same t

Review Request 55970: Updated the master's HTTP operations to handle MULTI_ROLE changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55970/ --- Review request for mesos, Benjamin Bannier, Jay Guo, Guangya Liu, and Michael Pa

Re: Review Request 55969: Updated the master to handle non-MULTI_ROLE schedulers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55969/ --- (Updated Jan. 26, 2017, 1:05 a.m.) Review request for mesos, Benjamin Bannier,

Review Request 55969: Updated the master to handle non-MULTI_ROLE schedulers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55969/ --- Review request for mesos, Benjamin Bannier, Jay Guo, Guangya Liu, and Michael Pa

Re: Review Request 53096: Fix handling in shared count in total resources in the sorter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53096/#review162890 --- Fix it, then Ship it! This review is now closely related to the

Re: Review Request 55940: Added support for the new streaming request/response headers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55940/#review163057 --- src/slave/containerizer/mesos/io/switchboard.cpp (lines 1299 - 13

Review Request 55968: Added TODOs to make the master code safer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55968/ --- Review request for mesos and Michael Park. Repository: mesos Description

Review Request 55967: Update the allocator unit tests to reflect MULTI_ROLE support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55967/ --- Review request for mesos, Guangya Liu and Michael Park. Repository: mesos Des

Re: Review Request 54215: Fixed duplicate image layer ids returned by docker store.

> On Jan. 25, 2017, 7:45 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/provisioner/docker/store.cpp, lines 276-279 > > > > > > Can you also validate the ordering with docker code? For instance, say > > the l

Re: Review Request 54215: Fixed duplicate image layer ids returned by docker store.

> On Jan. 25, 2017, 7:45 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/provisioner/docker/store.cpp, lines 276-279 > > > > > > Can you also validate the ordering with docker code? For instance, say > > the l

Re: Review Request 55939: Introduced `RequestMediaTypes`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55939/#review163054 --- Ship it! Ship It! - Vinod Kone On Jan. 25, 2017, 7:47 p.m.,

Re: Review Request 55938: Renamed `streamingRequest` to `streamingMediaType`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55938/#review163052 --- Ship it! Ship It! - Vinod Kone On Jan. 25, 2017, 7:47 p.m.,

Re: Review Request 55942: Added a test for validating streaming request/response headers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55942/#review163051 --- Patch looks great! Reviews applied: [55936, 55937, 55938, 55939,

Re: Review Request 55937: Added constants for referring to request/response streaming headers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55937/#review163050 --- src/common/http.cpp (line 111)

Re: Review Request 55964: Updates for executor, scheduler V1 API docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55964/ --- (Updated Jan. 25, 2017, 11:58 p.m.) Review request for mesos and Anand Mazumdar

Re: Review Request 55936: Added an overload for `acceptsMediaType()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55936/#review163048 --- Ship it! Ship It! - Vinod Kone On Jan. 25, 2017, 7:46 p.m.,

Re: Review Request 55954: Changed 'Environment.Variable.Value' from required to optional.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55954/#review163046 --- Looks like you missed validation in a few other places: ExecutorI

Review Request 55964: Updates for executor, scheduler V1 API docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55964/ --- Review request for mesos and Anand Mazumdar. Repository: mesos Description --

Re: Review Request 53096: Fix handling in shared count in total resources in the sorter.

> On Dec. 18, 2016, 11:46 p.m., Jiang Yan Xu wrote: > > src/master/allocator/mesos/hierarchical.hpp, lines 477-478 > > > > > > Update the comment per the comment about the role of the method. > > > > ``` > >

Re: Review Request 54410: Made the style of the cluster name consistent with others.

> On Dec. 9, 2016, 7:51 p.m., Benjamin Mahler wrote: > > If it looks the same as the other navbar tabs, it seems clickable? At least > > when it is greyed out I wouldn't think I can click it. > > haosdent huang wrote: > Got it, use `btn disabled` to make it grey now. Hey, responding to you

Re: Review Request 55946: Added agent capabilities as part of agent (re-)registration process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55946/#review163032 --- Patch looks great! Reviews applied: [55943, 55944, 55945, 55946]

Review Request 55870: Update the allocator to handle frameworks with multiple roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55870/ --- Review request for mesos, Benjamin Bannier, Jay Guo, Guangya Liu, and Michael Pa

Re: Review Request 55900: Improved style in `HealthChecker`.

> On Jan. 25, 2017, 6:09 p.m., haosdent huang wrote: > > I remember we have special reason to use `Option` here instead of `const > > Option&` in previous patches. @alex may remember that, or I > > missunderstanding something here? The parameter was introduced here: https://reviews.apache.org/

Review Request 55955: Added validation tests to ensure environment variable value is set.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55955/ --- Review request for mesos, Jan Schlicht and Vinod Kone. Bugs: MESOS-6991 htt

Re: Review Request 53998: Fixed hook to allow for executor environment modifications.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53998/#review163010 --- Bad patch! Reviews applied: [53998] Failed command: python suppo

Review Request 55954: Changed 'Environment.Variable.Value' from required to optional.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55954/ --- Review request for mesos, Jan Schlicht and Vinod Kone. Bugs: MESOS-6991 htt

Re: Review Request 55911: Fixed flakiness in TaskValidationTest.TaskReusesUnreachableTaskID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55911/ --- (Updated Jan. 25, 2017, 7:51 p.m.) Review request for mesos and Vinod Kone. C

Review Request 55942: Added a test for validating streaming request/response headers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55942/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6936 https://issues.ap

Review Request 55941: Modified existing tests to support new headers for request streaming.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55941/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6936 https://issues.ap

Review Request 55940: Added support for the new streaming request/response headers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55940/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6936 https://issues.ap

Review Request 55939: Introduced `RequestMediaTypes`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55939/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6936 https://issues.ap

Review Request 55938: Renamed `streamingRequest` to `streamingMediaType`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55938/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6936 https://issues.ap

Review Request 55937: Added constants for referring to request/response streaming headers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55937/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6936 https://issues.ap

Review Request 55936: Added an overload for `acceptsMediaType()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55936/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6936 https://issues.ap

Re: Review Request 55911: Fixed flakiness in TaskValidationTest.TaskReusesUnreachableTaskID.

> On Jan. 25, 2017, 7:31 p.m., Joseph Wu wrote: > > If I understand this correctly, the test is failing (when run as ROOT) > > because: > > > > * Agent 1 starts a container. > > * Agent 1 is partitioned. > > * Agent 2 starts. > > * Agent 2 observes (via global cgroups) Agent 1's container as an

Re: Review Request 55911: Fixed flakiness in TaskValidationTest.TaskReusesUnreachableTaskID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55911/#review163007 --- Ship it! If I understand this correctly, the test is failing (w

Re: Review Request 55810: Fixed bug allowing IOSwitchboard::connect() after container destruction.

> On Jan. 24, 2017, 11:04 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/io/switchboard.cpp, lines 761-762 > > > > > > Hum, then, it's possible that we install two timers and sending sigterm > > twice? > > V

Re: Review Request 55910: Prevent unintended mutation in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55910/#review162998 --- Patch looks great! Reviews applied: [54842, 54836, 55825, 55826,

Re: Review Request 55858: Fixed bug when applying review chains.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55858/ --- (Updated Jan. 25, 2017, 7:06 p.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 53291: Fixed incorrect `/monitor/statistics` URL in WebUI.

> On Jan. 17, 2017, 8:14 p.m., Benjamin Mahler wrote: > > Is this the only agent url that needs this fix? yep. only agent url need to fix this. - haosdent --- This is an automatically generated e-mail. To reply, visit: https://reviews.a

Re: Review Request 53741: Display maintainance info in the webui.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53741/#review162986 --- Hi, may you mind rebase this. - haosdent huang On Nov. 16, 2016

Re: Review Request 55900: Improved style in `HealthChecker`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55900/ --- (Updated Jan. 25, 2017, 6:15 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 55899: Renamed `taskID` to `taskId` in `HealthChecker`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55899/#review162985 --- Ship it! Ship It! - haosdent huang On Jan. 25, 2017, 12:24 a

Re: Review Request 55900: Improved style in `HealthChecker`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55900/#review162982 --- I remember we have special reason to use `Option` here instead of

Review Request 55946: Added agent capabilities as part of agent (re-)registration process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55946/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description -

Review Request 55945: Added a `install` template method to support 8 arguments.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55945/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description -

Review Request 55944: Modified agent capabilities struct to reflect protobuf changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55944/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description -

Review Request 55943: Moved agent capabilities from SlaveInfo to (re-)registerSlaveMessage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55943/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description -

Re: Review Request 55791: Rework clipboard functionality in UI.

> On Jan. 25, 2017, 5:41 p.m., haosdent huang wrote: > > Do you forgot to update `src/Makefile.am` > > > > ``` > > nobase_dist_pkgdata_DATA += \ > > webui/master/static/js/angular-1.2.3.js \ > > webui/master/static/js/angular-

Re: Review Request 55791: Rework clipboard functionality in UI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55791/#review162975 --- Fix it, then Ship it! Do you forgot to update `src/Makefile.am`

Re: Review Request 55901: [WIP] Added support for command health checks to the default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55901/#review162972 --- It looks like there's a deadlock in the cleanup path of the Agent/

Re: Review Request 50871: Supported auto backend in Unified Containerizer.

> On Jan. 22, 2017, 7:12 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/provisioner/provisioner.hpp, lines 149-154 > > > > > > I'd suggest we call this `defaultBackend`. I would try to avoid passing > > `back

Re: Review Request 53998: Fixed hook to allow for executor environment modifications.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53998/#review162967 --- Ping. Do we still need this? - Adam B On Nov. 22, 2016, 12:26 p

Re: Review Request 54215: Fixed duplicate image layer ids returned by docker store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54215/#review162963 --- src/slave/containerizer/mesos/provisioner/docker/store.cpp (lines

Re: Review Request 54215: Fixed duplicate image layer ids returned by docker store.

> On Jan. 22, 2017, 7:19 p.m., Jie Yu wrote: > > Let's take a look how docker handles this case. > > > > My feeling is that it's ok to have duplicated layers because what if I want > > to apply the same content more than once? > > Gilbert Song wrote: > If there exists duplicate layers in a

Re: Review Request 54215: Fixed duplicate image layer ids returned by docker store.

> On Jan. 22, 2017, 7:19 p.m., Jie Yu wrote: > > Let's take a look how docker handles this case. > > > > My feeling is that it's ok to have duplicated layers because what if I want > > to apply the same content more than once? > > Gilbert Song wrote: > If there exists duplicate layers in a

Re: Review Request 54213: Supported more layers through symlink for aufs backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54213/#review162960 --- Fix it, then Ship it! src/slave/containerizer/mesos/provisione

Re: Review Request 54212: Fixed overlay backend provisioning multi images symlink.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54212/#review162959 --- Fix it, then Ship it! src/slave/containerizer/mesos/provisione

Re: Review Request 55889: Fixes to comments in review 54216.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55889/#review162951 --- Ship it! Ship It! - haosdent huang On Jan. 25, 2017, 12:53 a

Re: Review Request 55911: Fixed flakiness in TaskValidationTest.TaskReusesUnreachableTaskID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55911/#review162948 --- Patch looks great! Reviews applied: [55911] Passed command: expo

Re: Review Request 55903: Update XFS disk isolator documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55903/#review162943 --- Patch looks great! Reviews applied: [55895, 55896, 55897, 55903]

Re: Review Request 54836: Added helpers to allocate / unallocate Resources.

> On 一月 25, 2017, 9:54 a.m., Michael Park wrote: > > include/mesos/resources.hpp, lines 332-339 > > > > > > I would've expected: > > ```cpp > > void allocate(const std::string& role); > > void unallocate(

Re: Review Request 55825: Augmented printing of Resources to include AllocationInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55825/#review162939 --- src/tests/resources_tests.cpp (line 822)

  1   2   >