Re: Review Request 62733: Organized configuration documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62733/#review186930 --- Bad patch! Reviews applied: [62733, 62732, 62731, 62730, 62729]

Review Request 62743: Synced the MTU for container eth0 in port mapping isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62743/ --- Review request for mesos, Ian Downes, James Peach, and Pierre Cheynier. Bugs:

Review Request 62742: Handled discarded case in launch nested container handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62742/ --- Review request for mesos, Benjamin Mahler and Zhitao Li. Bugs: MESOS-8039

Re: Review Request 62353: Added a master-registry backed resource provider manager registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62353/#review186924 --- PASS: Mesos patch 62353 was successfully built and tested.

Re: Review Request 62739: Added a test using DefaultExecutor + health check + persistent volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62739/#review186923 --- PASS: Mesos patch 62739 was successfully built and tested.

Re: Review Request 61174: Added a test `ProtobufTest.ParseJSONUnrecognizedEnum`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61174/#review186922 --- Patch looks great! Reviews applied: [61109, 61174] Passed

Re: Review Request 56721: Implemented pruneImages with a mark and sweep in docker store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56721/#review186320 --- src/slave/containerizer/containerizer.hpp Lines 156 (patched)

Re: Review Request 62739: Added a test using DefaultExecutor + health check + persistent volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62739/#review186921 --- Ship it! Ship It! - Vinod Kone On Oct. 2, 2017, 11:11 p.m.,

Re: Review Request 62734: Added --markdown and --target-people to post-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62734/#review186918 --- FAIL: Some Mesos tests failed. Reviews applied: `['62734']`

Re: Review Request 62511: Fixed OpenSSL support in libprocess for Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62511/ --- (Updated Oct. 2, 2017, 4:48 p.m.) Review request for mesos, John Kordich,

Re: Review Request 62510: Fixed `LibeventSSLSocketImpl` for Windows file descriptors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62510/ --- (Updated Oct. 2, 2017, 4:47 p.m.) Review request for mesos, John Kordich,

Review Request 62740: Fixed using `FindOpenSSL` on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62740/ --- Review request for mesos, John Kordich, Joseph Wu, and Till Toenshoff.

Re: Review Request 62739: Added a test using DefaultExecutor + health check + persistent volume.

> On Oct. 2, 2017, 4:21 p.m., Vinod Kone wrote: > > src/tests/default_executor_tests.cpp > > Lines 2392 (patched) > > > > > > what's the guarantee that by the time health check command runs this > > file exists? >

Re: Review Request 62509: Added `intptr_t` constructor for `WindowsFD`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62509/ --- (Updated Oct. 2, 2017, 4:45 p.m.) Review request for mesos, John Kordich,

Re: Review Request 62735: Disable on Windows new tests that use file URIs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62735/#review186916 --- Ship it! I'm going to rephrase the description a bit to

Re: Review Request 62739: Added a test using DefaultExecutor + health check + persistent volume.

> On Oct. 2, 2017, 11:21 p.m., Vinod Kone wrote: > > src/tests/default_executor_tests.cpp > > Lines 2392 (patched) > > > > > > what's the guarantee that by the time health check command runs this > > file exists?

Re: Review Request 62739: Added a test using DefaultExecutor + health check + persistent volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62739/#review186911 --- src/tests/default_executor_tests.cpp Lines 2392 (patched)

Re: Review Request 62739: Added a test using DefaultExecutor + health check + persistent volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62739/#review186910 --- src/tests/default_executor_tests.cpp Lines 2392 (patched)

Review Request 62739: Added a test using DefaultExecutor + health check + persistent volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62739/ --- Review request for mesos, Alexander Rukletsov, Greg Mann, and Vinod Kone.

Re: Review Request 62732: Added CMake documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62732/#review186899 --- Partial skim-review-thing... docs/cmake-examples.md Lines 268

Re: Review Request 62696: Updated error messages in `getMountNamespaceTarget()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62696/#review186905 --- Patch looks great! Reviews applied: [62696] Passed command:

Re: Review Request 62511: Fixed OpenSSL support in libprocess for Windows.

> On Oct. 2, 2017, 1:50 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/src/ssl/utilities.cpp > > Lines 16-18 (patched) > > > > > > If possible, a `typedef` would be preferable. > > > > Is this type required

Re: Review Request 62509: Added `intptr_t` constructor for `WindowsFD`.

> On Oct. 2, 2017, 1:23 p.m., Joseph Wu wrote: > > 3rdparty/CMakeLists.txt > > Lines 516-518 (patched) > > > > > > There should be two separate conditionals here: > > > > 1) `if (ENABLE_SSL)` which appends

Re: Review Request 62696: Updated error messages in `getMountNamespaceTarget()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62696/#review186902 --- FAIL: Some Mesos tests failed. Reviews applied: `['62696']`

Re: Review Request 62731: Removed `MESOS_CPPFLAGS` from CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62731/#review186896 --- Ship it! src/CMakeLists.txt Lines 598 (patched)

Re: Review Request 62730: Used `TRUE|FALSE` instead of `ON|OFF` consistently in CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62730/#review186891 --- Ship it! True/false is a decent choice. - Joseph Wu On Oct.

Re: Review Request 62735: Disable on Windows new tests that use file URIs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62735/#review186890 --- Ship it! Ship It! - Andrew Schwartzmeyer On Oct. 2, 2017, 2

Re: Review Request 62353: Added a master-registry backed resource provider manager registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62353/ --- (Updated Oct. 2, 2017, 11:13 p.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 62729: Removed `LIBNAME_VERSION` from `External.cmake`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62729/#review186887 --- Ship it! 3rdparty/cmake/External.cmake Lines 55-61

Review Request 62735: Disable on Windows new tests that use file URIs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62735/ --- Review request for mesos, Andrew Schwartzmeyer and Joseph Wu. Repository:

Re: Review Request 62730: Used `TRUE|FALSE` instead of `ON|OFF` consistently in CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62730/#review186886 --- FYI I could go either way on this. `TRUE|FALSE` or `ON|OFF`. We

Re: Review Request 62511: Fixed OpenSSL support in libprocess for Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62511/#review186885 --- Ship it! LGTM. 3rdparty/libprocess/src/ssl/utilities.cpp

Re: Review Request 62510: Fixed `LibeventSSLSocketImpl` for Windows file descriptors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62510/#review186881 --- Ship it! LGTM. - Joseph Wu On Sept. 22, 2017, 11:34 a.m.,

Re: Review Request 62509: Added `intptr_t` constructor for `WindowsFD`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62509/#review186877 --- Socket modification LGTM. 3rdparty/CMakeLists.txt Lines 516-518

Re: Review Request 62353: Added a master-registry backed resource provider manager registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62353/#review186879 --- Patch looks great! Reviews applied: [62655, 62158, 61183, 61528,

Re: Review Request 62353: Added a master-registry backed resource provider manager registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62353/#review186876 --- FAIL: Mesos tests failed to build. Reviews applied: `['62655',

Re: Review Request 62508: Fixed ordering of Windows system headers.

> On Oct. 2, 2017, 12:26 p.m., Joseph Wu wrote: > > 3rdparty/stout/include/stout/ip.hpp > > Line 69 (original), 67 (patched) > > > > > > Nano-nit: Comment must start with a capital letter and end with a > > period.

Re: Review Request 62508: Fixed ordering of Windows system headers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62508/#review186870 --- Ship it! A couple nits, which I can fix before committing.

Re: Review Request 62733: Organized configuration documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62733/#review186869 --- FAIL: Failed to apply the dependent review: 62730. Failed

Re: Review Request 62213: Fix unit tests that were broken by the additional TASK_STARTING update.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62213/#review186868 --- FAIL: Some Mesos tests failed. Reviews applied: `['62212',

Re: Review Request 62731: Removed `MESOS_CPPFLAGS` from CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62731/ --- (Updated Oct. 2, 2017, 11:58 a.m.) Review request for mesos, Benjamin Bannier,

Review Request 62734: Added --markdown and --target-people to post-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62734/ --- Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, and Till

Re: Review Request 62587: Added HTTP authenticatee interface definition.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62587/ --- (Updated Oct. 2, 2017, 6:55 p.m.) Review request for mesos, Armand Grillet,

Review Request 62733: Organized configuration documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62733/ --- Review request for mesos, Benjamin Bannier, Jeff Coffler, Greg Mann, John

Review Request 62732: Added CMake documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62732/ --- Review request for mesos, Benjamin Bannier, Jeff Coffler, Greg Mann, John

Re: Review Request 62176: Added cmake dependency check for libsasl2 on non-Windows platforms.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62176/#review186866 --- Ship it! LGTM. - Joseph Wu On Sept. 27, 2017, 12:19 p.m.,

Review Request 62731: Removed `MESOS_CPPFLAGS` from CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62731/ --- Review request for mesos, Benjamin Bannier, Jeff Coffler, John Kordich, Joseph

Review Request 62730: Used `TRUE|FALSE` instead of `ON|OFF` consistently in CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62730/ --- Review request for mesos, Benjamin Bannier, Jeff Coffler, John Kordich, Joseph

Review Request 62729: Removed `LIBNAME_VERSION` from `External.cmake`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62729/ --- Review request for mesos, Benjamin Bannier, Jeff Coffler, John Kordich, and

Re: Review Request 62106: Enabled CRAM MD5 Authentication on Windows and associated tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62106/#review186864 --- Ship it! I'm going to modify the commit message to mention

Re: Review Request 62105: Enabled building of the Cyrus SASL CRAM MD5 lib on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62105/#review186622 --- Ship it! I can make the tweaks listed below before committing.

Re: Review Request 59746: Stopped accounting aborted container launches as failures.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59746/#review186859 --- src/slave/slave.cpp Lines 5225 (patched)

Re: Review Request 62616: Binary packaging for Centos 7.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62616/#review186855 --- support/packaging/Jenkinsfile Lines 26-49 (patched)

Re: Review Request 61174: Added a test `ProtobufTest.ParseJSONUnrecognizedEnum`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61174/#review186856 --- FAIL: Some Mesos tests failed. Reviews applied: `['61109',

Re: Review Request 62696: Updated error messages in `getMountNamespaceTarget()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62696/ --- (Updated Oct. 2, 2017, 4:54 p.m.) Review request for mesos, Alexander

Re: Review Request 62655: Made 'UpdateSlaveMessage' a union of possible updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62655/ --- (Updated Oct. 2, 2017, 6:53 p.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 62158: Rescinded offers possibly affected by updates to agent total resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62158/ --- (Updated Oct. 2, 2017, 6:53 p.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 61174: Added a test `ProtobufTest.ParseJSONUnrecognizedEnum`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61174/ --- (Updated Oct. 2, 2017, 11:14 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 61109: Fixed JSON protobuf deserialization to ignore unrecognized enum values.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61109/ --- (Updated Oct. 2, 2017, 11:12 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 62592: Added basic HTTP authenticatee implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62592/#review186846 --- LGTM. - Armand Grillet On Oct. 2, 2017, 10:12 a.m., Till

Re: Review Request 62591: Modularized HTTP authenticatee.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62591/#review186841 --- LGTM. - Armand Grillet On Sept. 26, 2017, 10:54 p.m., Till

Re: Review Request 62595: Added test module wrapping the basic HTTP authenticatee.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62595/#review186835 --- LGTM. - Armand Grillet On Sept. 26, 2017, 10:54 p.m., Till

Re: Review Request 62587: Added HTTP authenticatee interface definition.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62587/#review186833 --- include/mesos/authentication/http/authenticatee.hpp Lines 44

Re: Review Request 61172: Added mesos.http and mesos.exceptions for CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61172/#review186830 --- Patch looks great! Reviews applied: [61172] Passed command:

Re: Review Request 62594: Updated scheduler library for modularized HTTP authenticatee use.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62594/ --- (Updated Oct. 2, 2017, 10:29 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 62594: Updated scheduler library for modularized HTTP authenticatee use.

> On Sept. 27, 2017, 10:07 p.m., Greg Mann wrote: > > src/scheduler/flags.hpp > > Lines 57-59 (patched) > > > > > > s/kept in in sync/kept in sync/ > > > > Also, this seems bad :) (also for modules_dir) I

Re: Review Request 62592: Added basic HTTP authenticatee implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62592/ --- (Updated Oct. 2, 2017, 10:12 a.m.) Review request for mesos, Armand Grillet,

Re: Review Request 62587: Added HTTP authenticatee interface definition.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62587/ --- (Updated Oct. 2, 2017, 10:09 a.m.) Review request for mesos, Armand Grillet,

Re: Review Request 62595: Added test module wrapping the basic HTTP authenticatee.

> On Sept. 27, 2017, 10:17 p.m., Greg Mann wrote: > > src/examples/test_http_authenticator_module.cpp > > Line 30 (original), 34 (patched) > > > > > > Is there a reason to have `using namespace mesos` here instead of

Re: Review Request 62594: Updated scheduler library for modularized HTTP authenticatee use.

> On Sept. 27, 2017, 10:07 p.m., Greg Mann wrote: > > src/scheduler/flags.hpp > > Lines 57-59 (patched) > > > > > > s/kept in in sync/kept in sync/ > > > > Also, this seems bad :) (also for modules_dir) I

Re: Review Request 62592: Added basic HTTP authenticatee implementation.

> On Sept. 27, 2017, 9:21 p.m., Greg Mann wrote: > > src/authentication/http/basic_authenticatee.cpp > > Lines 75-76 (patched) > > > > > > Hmm wouldn't we usually indent two spaces after the linebreak here? > > Till

Re: Review Request 62587: Added HTTP authenticatee interface definition.

> On Sept. 28, 2017, 3:54 p.m., Benjamin Bannier wrote: > > include/mesos/authentication/http/authenticatee.hpp > > Lines 48-49 (patched) > > > > > > Since our Doxygen setup uses `JAVADOC_AUTOBRIEF` which makes the