Re: Review Request 63943: Renamed `TaskStatusEq()` to `TaskStatusTaskIdEq()`.

2017-11-19 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63943/#review191481 --- FAIL: mesos-java failed to build. Reviews applied: `['63577',

Re: Review Request 61157: Refactored ProcessManager::handle for future use with http::Server.

2017-11-19 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61157/#review191474 --- FAIL: mesos-java failed to build. Reviews applied: `['63941',

Re: Review Request 63912: Changed agent (re-)registration to set resource versions.

2017-11-19 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63912/#review191473 --- Fix it, then Ship it! src/master/master.cpp Lines 6257-6258

Re: Review Request 61155: Added http::Server.

2017-11-19 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61155/#review191471 --- Fix it, then Ship it! 3rdparty/libprocess/src/http.cpp Lines

Re: Review Request 63942: Added a state machine abstraction.

2017-11-19 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63942/#review191468 --- Fix it, then Ship it!

Re: Review Request 63911: Bumped up the number of args allowed in some libprocess templates.

2017-11-19 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63911/#review191472 --- Ship it! Ship It! - Jie Yu On Nov. 17, 2017, 1:07 p.m., Jan

Re: Review Request 63577: Fixed a task status update race in default executor tests.

2017-11-19 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63577/ --- (Updated Nov. 20, 2017, 10:46 a.m.) Review request for mesos, Alexander

Review Request 63943: Renamed `TaskStatusEq()` to `TaskStatusTaskIdEq()`.

2017-11-19 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63943/ --- Review request for mesos, Alexander Rukletsov and Gaston Kleiman. Repository:

Re: Review Request 63577: Fixed a task status update race in default executor tests.

2017-11-19 Thread Qian Zhang
> On Nov. 16, 2017, 7:45 p.m., Alexander Rukletsov wrote: > > src/tests/default_executor_tests.cpp > > Lines 364-372 (patched) > > > > > > Indentation again. Could you please carefully check other places in the > >

Re: Review Request 63652: Added d_type check in containerizer backend validation.

2017-11-19 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63652/#review191470 --- PASS: Mesos patch 63652 was successfully built and tested.

Re: Review Request 63941: Added support for enum's to hashset and hashmap.

2017-11-19 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63941/#review191466 --- Fix it, then Ship it!

Review Request 63942: Added a state machine abstraction.

2017-11-19 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63942/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Review Request 63941: Added support for enum's to hashset and hashmap.

2017-11-19 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63941/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Re: Review Request 61149: Added stringification support for Future.

2017-11-19 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61149/#review191464 --- 3rdparty/libprocess/include/process/future.hpp Lines 1782-1804

Re: Review Request 61149: Added stringification support for Future.

2017-11-19 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61149/#review191463 --- Ship it! 3rdparty/libprocess/include/process/future.hpp Lines

Re: Review Request 63940: Added a Future constructor for Try<Future>.

2017-11-19 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63940/#review191462 --- Ship it! Ship It! - Benjamin Hindman On Nov. 20, 2017,

Review Request 63940: Added a Future constructor for Try<Future>.

2017-11-19 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63940/ --- Review request for mesos and Benjamin Hindman. Repository: mesos Description

Re: Review Request 63765: Fixed an issue with the scheduler driver subscribe backoff time.

2017-11-19 Thread Meng Zhu
> On Nov. 18, 2017, 11:06 a.m., Vinod Kone wrote: > > src/tests/scheduler_driver_tests.cpp > > Lines 96 (patched) > > > > > > we use camel case for our variable names in mesos and snake case in > > libprocess/stout

Re: Review Request 63652: Added d_type check in containerizer backend validation.

2017-11-19 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63652/ --- (Updated Nov. 19, 2017, 3:49 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 63652: Added d_type check in containerizer backend validation.

2017-11-19 Thread James Peach
> On Nov. 14, 2017, 5:32 p.m., James Peach wrote: > > src/slave/containerizer/mesos/provisioner/provisioner.cpp > > Lines 154 (patched) > > > > > > The caller is responsible for logging the error. Let's be

Re: Review Request 63910: Added 3 tests for TCP/HTTP(S) health check support for Docker container.

2017-11-19 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63910/#review191457 --- PASS: Mesos patch 63910 was successfully built and tested.

Re: Review Request 63910: Added 3 tests for TCP/HTTP(S) health check support for Docker container.

2017-11-19 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63910/ --- (Updated Nov. 19, 2017, 9:41 p.m.) Review request for mesos, Alexander

Re: Review Request 63910: Added 3 tests for TCP/HTTP(S) health check support for Docker container.

2017-11-19 Thread Qian Zhang
> On Nov. 18, 2017, 3:25 a.m., Avinash sridharan wrote: > > src/tests/health_check_tests.cpp > > Lines 1972 (patched) > > > > > > What is `local mode`? :) That is not something added or modified in this patch :-)

Re: Review Request 63939: Added a script to build Mesos docker image.

2017-11-19 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63939/#review191452 --- PASS: Mesos patch 63939 was successfully built and tested.