---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64680/#review194156
---
Ship it!
Ship It!
- Alexander Rukletsov
On Dec. 18, 2017
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64379/#review194155
---
Ship it!
Ship It!
- Alexander Rukletsov
On Dec. 13, 2017, 7
.
Repository: mesos
Description
---
See summary.
Diffs
-
src/linux/ns.cpp 5e2df1ed56432c6c1bfa04a31dba7f9f547d6139
Diff: https://reviews.apache.org/r/64685/diff/1/
Testing
---
See https://reviews.apache.org/r/64686/
Thanks,
Alexander Rukletsov
and various Linux distros
Thanks,
Alexander Rukletsov
/
Thanks,
Alexander Rukletsov
y generated e-mail. To reply, visit:
https://reviews.apache.org/r/64574/#review193848
-------
On Dec. 13, 2017, 1:39 p.m., Alexander Rukletsov wrote:
>
> ---
> This is an automatical
(patched)
<https://reviews.apache.org/r/64575/#comment272563>
Please backtick class values.
- Alexander Rukletsov
On Dec. 13, 2017, 7:47 p.m., Armand Grillet wrote:
>
> ---
> This is an automatically generated e-mail.
odic manner).
src/slave/containerizer/mesos/containerizer.cpp
Line 2335 (original), 2338-2339 (patched)
<https://reviews.apache.org/r/63953/#comment272565>
Ups
- Alexander Rukletsov
On Dec. 13, 2017, 7:47 p.m., Arm
() && config->has_container_class())
? config->container_class()
: ContainerClass::DEFAULT;
``
- Alexander Rukletsov
On Dec. 13, 2017, 7:47 p.m., Armand Grillet wrote:
>
> ---
> This is an autom
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64603/#review193787
---
Ship it!
Ship It!
- Alexander Rukletsov
On Dec. 14, 2017
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64536/#review193708
---
Ship it!
Ship It!
- Alexander Rukletsov
On Dec. 12, 2017
ied test fails without the fix.
`make check` on Mac OS 10.11.6 and several Linux distributions.
Thanks,
Alexander Rukletsov
271819>
Ditto.
src/slave/containerizer/mesos/containerizer.cpp
Lines 2863 (patched)
<https://reviews.apache.org/r/63953/#comment271814>
Do you need to use a FQN here?
- Alexander Rukletsov
On Dec. 6, 2017, 2:47 p.m., Armand Grillet wrote:
>
> --
it in the
testing done section.
src/slave/slave.cpp
Lines 6795 (patched)
<https://reviews.apache.org/r/64379/#comment271806>
..., not just those started by Mesos!
- Alexander Rukletsov
On Dec. 8, 2017, 1:23 p.m., Armand Grillet
---
make check on Mac OS 10.11.6 and various Linux distributions.
Thanks,
Alexander Rukletsov
/health_check_tests.cpp c716ad9fa41fe9429de971bb2a1f2e790499572a
Diff: https://reviews.apache.org/r/64456/diff/1/
Testing
---
make check on Mac OS 10.11.6 and various Linux distributions.
Thanks,
Alexander Rukletsov
---
See summary.
Diffs
-
src/tests/containerizer/nested_mesos_containerizer_tests.cpp
bb2abbc09e8a560830fb9da5c5da8e0bd80c6bc5
Diff: https://reviews.apache.org/r/64455/diff/1/
Testing
---
See https://reviews.apache.org/r/64456/
Thanks,
Alexander Rukletsov
---
See summary.
Diffs
-
src/tests/containerizer/nvidia_gpu_isolator_tests.cpp
5e40a940770cb45c9ac181b953a4e57e4b053445
Diff: https://reviews.apache.org/r/64454/diff/1/
Testing
---
See https://reviews.apache.org/r/64456/
Thanks,
Alexander Rukletsov
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64391/#review193042
---
Ship it!
Ship It!
- Alexander Rukletsov
On Dec. 6, 2017, 8
942 (original)
<https://reviews.apache.org/r/64247/#comment271412>
Let's resume here to finish the test with the running clock.
- Alexander Rukletsov
On Dec. 6, 2017, 10:46 a.m., Jan Schlicht wrote:
>
> ---
> This
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64342/#review192921
---
Ship it!
Ship It!
- Alexander Rukletsov
On Dec. 5, 2017, 3
.
This should be logged at the warning level to simplify triaging.
Diffs
-
src/exec/exec.cpp cdbf149a9047ddad6beef64be1266e15e7643afc
Diff: https://reviews.apache.org/r/64032/diff/2/
Testing
---
None: not a functional change.
Thanks,
Alexander Rukletsov
gistration
confirmation.
Thanks,
Alexander Rukletsov
Manual testing using modified "exec.cpp" that drops executor registration
confirmation.
Thanks,
Alexander Rukletsov
ame line for consistency.
- Alexander Rukletsov
On Dec. 1, 2017, 9:06 p.m., Megha Sharma wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63831/#review192506
---
Ship it!
Ship It!
- Alexander Rukletsov
On Nov. 28, 2017
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63830/#review192505
---
Ship it!
Ship It!
- Alexander Rukletsov
On Nov. 21, 2017, 5
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63741/#review192503
---
Ship it!
Ship It!
- Alexander Rukletsov
On Nov. 28, 2017
> On Nov. 21, 2017, 6:04 p.m., Alexander Rukletsov wrote:
> > src/internal/devolve.cpp
> > Lines 203-204 (patched)
> > <https://reviews.apache.org/r/63741/diff/1/?file=1892879#file1892879line203>
> >
> > I believe we prefer writing `CopyFrom()`
> On Nov. 21, 2017, 6:27 p.m., Alexander Rukletsov wrote:
> > src/master/allocator/mesos/hierarchical.cpp
> > Lines 430-437 (original), 431-438 (patched)
> > <https://reviews.apache.org/r/63831/diff/1/?file=1894169#file1894169line431>
> >
> > Do we need
> On Nov. 21, 2017, 5:53 p.m., Alexander Rukletsov wrote:
> > src/tests/scheduler_tests.cpp
> > Lines 1515-1516 (original), 1534-1535 (patched)
> > <https://reviews.apache.org/r/63830/diff/1/?file=1892884#file1892884line1542>
> >
> > `.WillRepeate
-
>
> (Updated Nov. 28, 2017, 11:12 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Avinash sridharan.
>
>
> Bugs: MESOS-8050
> https://issues.apache.org/jira/browse/MESOS-8050
>
>
> Repository: mesos
>
>
> Description
> ---
tps://reviews.apache.org/r/63910/#comment270005>
This is invoked regardless of the fixture parameter. Is this on purpose? Is
it not a problem?
- Alexander Rukletsov
On Nov. 19, 2017, 1:41 p.m., Qian Zhang wrote:
>
> ---
---
None: not a functional change.
Thanks,
Alexander Rukletsov
18 (patched)
<https://reviews.apache.org/r/63953/#comment269830>
What about this?
- Alexander Rukletsov
On Nov. 27, 2017, 2:16 p.m., Armand Grillet wrote:
>
> ---
> This is an automatically generate
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64084/#review191883
---
Ship it!
Ship It!
- Alexander Rukletsov
On Nov. 27, 2017, 2
---
See summary.
Diffs
-
3rdparty/libprocess/README.md ba09653dbc26a997856b712c9f082c6e06c39137
Diff: https://reviews.apache.org/r/64081/diff/1/
Testing
---
None: not a functional change.
Thanks,
Alexander Rukletsov
`return`.
- Alexander Rukletsov
On Nov. 24, 2017, 2:07 p.m., Benjamin Bannier wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
4963-4964 (original), 4936-4937 (patched)
<https://reviews.apache.org/r/63910/#comment269822>
Swap these lines
- Alexander Rukletsov
On Nov. 19, 2017, 1:41 p.m., Qian Zhang wrote:
>
> ---
> This is an automatically gener
)
<https://reviews.apache.org/r/63795/#comment269820>
It is unfortunate that we now introduce a dependecy on process library.
- Alexander Rukletsov
On Nov. 27, 2017, 2:20 a.m., Qian Zhang wrote:
>
> ---
> This is an automati
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63796/#review191874
---
Ship it!
Ship It!
- Alexander Rukletsov
On Nov. 16, 2017, 7
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63794/#review191873
---
Ship it!
Ship It!
- Alexander Rukletsov
On Nov. 17, 2017
modified "exec.cpp" that drops executor registration
confirmation.
Thanks,
Alexander Rukletsov
.
Repository: mesos
Description
---
See summary.
Diffs
-
src/tests/mesos.hpp e5c2b697a4401f010a7d77ae9acb8a9cbd3846bc
Diff: https://reviews.apache.org/r/64068/diff/1/
Testing
---
See https://reviews.apache.org/r/64033/
Thanks,
Alexander Rukletsov
.
Diffs
-
src/executor/v0_v1executor.cpp 61d591993e6388ba3b4d64a3bdb63c3a3513fbeb
Diff: https://reviews.apache.org/r/64070/diff/1/
Testing
---
See https://reviews.apache.org/r/64033/
Thanks,
Alexander Rukletsov
c.cpp" that drops executor registration
confirmation.
Thanks,
Alexander Rukletsov
)
-
src/exec/exec.cpp cdbf149a9047ddad6beef64be1266e15e7643afc
Diff: https://reviews.apache.org/r/64032/diff/2/
Changes: https://reviews.apache.org/r/64032/diff/1-2/
Testing
---
None: not a functional change.
Thanks,
Alexander Rukletsov
.
Repository: mesos
Description
---
See summary.
Diffs
-
src/launcher/executor.cpp c688c04e598ac140421fd5e47359b0e48d30bcc5
Diff: https://reviews.apache.org/r/64069/diff/1/
Testing
---
See https://reviews.apache.org/r/64033/
Thanks,
Alexander Rukletsov
c688c04e598ac140421fd5e47359b0e48d30bcc5
Diff: https://reviews.apache.org/r/64033/diff/1/
Testing (updated)
---
make check on MacOS 10.11.6
Manual testing using modified "exec.cpp" that drops executor registration
confirmation.
Thanks,
Alexander Rukletsov
s.apache.org/r/64033/#review191748
---
On Nov. 22, 2017, 5:05 p.m., Alexander Rukletsov wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
ll update the patch in a while.
- Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64033/#review191835
-------
On Nov. 2
c688c04e598ac140421fd5e47359b0e48d30bcc5
Diff: https://reviews.apache.org/r/64033/diff/1/
Testing (updated)
---
make check on MacOS 10.11.6
Thanks,
Alexander Rukletsov
simplify triaging.
Diffs
-
src/exec/exec.cpp cdbf149a9047ddad6beef64be1266e15e7643afc
Diff: https://reviews.apache.org/r/64032/diff/1/
Testing
---
None: not a functional change.
Thanks,
Alexander Rukletsov
://reviews.apache.org/r/64033/diff/1/
Testing
---
In progress.
Thanks,
Alexander Rukletsov
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63984/#review191648
---
Ship it!
Ship It!
- Alexander Rukletsov
On Nov. 21, 2017, 2
a framework decides to suppress its roles on
reregisteration, no offers will be made.
- Alexander Rukletsov
On Nov. 16, 2017, 7:05 a.m., Jiang Yan Xu wrote:
>
> ---
> This is an automatically generated e-mail. To
src/internal/devolve.cpp
Lines 203-204 (patched)
<https://reviews.apache.org/r/63741/#comment269453>
I believe we prefer writing `CopyFrom()` explicitly, no?
- Alexander Rukletsov
On Nov. 15, 2017, 6:41 p.m., Jiang Yan Xu wrote:
>
> -
-1535 (patched)
<https://reviews.apache.org/r/63830/#comment269446>
`.WillRepeatedly(Return());`
- Alexander Rukletsov
On Nov. 21, 2017, 5:46 p.m., Jiang Yan Xu wrote:
>
> ---
> This is an automatically generated e-mail.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63943/#review191599
---
Ship it!
Ship It!
- Alexander Rukletsov
On Nov. 20, 2017, 2
> On Nov. 16, 2017, 11:45 a.m., Alexander Rukletsov wrote:
> > src/tests/mesos.hpp
> > Lines 2935-2941 (original), 2935-2941 (patched)
> > <https://reviews.apache.org/r/63577/diff/3/?file=1892763#file1892763line2935>
> >
> > This guy does the same a
> On Nov. 16, 2017, 11:45 a.m., Alexander Rukletsov wrote:
> > src/tests/default_executor_tests.cpp
> > Lines 926-928 (original), 1027-1029 (patched)
> > <https://reviews.apache.org/r/63577/diff/3/?file=1892762#file1892762line1167>
> >
> > What h
container is removed from the collection.
```
- Alexander Rukletsov
On Nov. 16, 2017, 8:42 p.m., Andrei Budnik wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://rev
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63888/#review191573
---
Ship it!
Ship It!
- Alexander Rukletsov
On Nov. 16, 2017, 8
case where termination promise is
set to `true` in `_launch()`.
- Alexander Rukletsov
On Nov. 16, 2017, 8:42 p.m., Andrei Budnik wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://rev
(patched)
<https://reviews.apache.org/r/63887/#comment269154>
You don't need to wrap in `Future` here, just say `.then([](const
Option& termination) {`
- Alexander Rukletsov
On Nov. 16, 2017, 8:42 p.m., Andr
if `termination` is already set in `_launch()`, `associate()` is a no-op and
this is intended.
- Alexander Rukletsov
On Nov. 16, 2017, 8:42 p.m., Andrei Budnik wrote:
>
> ---
> This is an automatically generated e-mail. T
.hpp
Lines 2945 (patched)
<https://reviews.apache.org/r/63577/#comment268802>
s/task/taskInfo
src/tests/mesos.hpp
Lines 2952 (patched)
<https://reviews.apache.org/r/63577/#comment268803>
s/state/taskState
- Alexander Rukletsov
On Nov. 15, 2017, 6:21 a.m.,
ent268744>
Let's explicitly check for `AF_INET6` and add another `else` where we error
out for unsupported family.
- Alexander Rukletsov
On Nov. 14, 2017, 1:30 p.m., Qian Zhang wrote:
>
> ---
> This is an automati
thCheck.tcp().protocol() == NetworkInfo::IPv6)) {
ipv6 = true;
}
```
- Alexander Rukletsov
On Nov. 14, 2017, 1:27 p.m., Qian Zhang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
eave a
comment saying why we do these magic movements?
- Alexander Rukletsov
On Nov. 14, 2017, 1:31 p.m., Qian Zhang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63846/#review191090
---
Ship it!
Ship It!
- Alexander Rukletsov
On Nov. 15, 2017, 6
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63833/#review191068
---
Ship it!
Ship It!
- Alexander Rukletsov
On Nov. 15, 2017
eviews.apache.org/r/63674/#review191003
---
On Nov. 13, 2017, 8:45 p.m., Alexander Rukletsov wrote:
>
> ---
> This is an automatically generated e-mail. To re
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63589/#review190880
---
Ship it!
Ship It!
- Alexander Rukletsov
On Nov. 6, 2017, 6
Vinod Kone.
Repository: mesos
Description
---
See summary.
Diffs
-
src/tests/mesos.hpp e25defeb55608136e77363aa48cf820092a13a59
Diff: https://reviews.apache.org/r/63612/diff/1/
Testing
---
See https://reviews.apache.org/r/63615/
Thanks,
Alexander Rukletsov
change removes the shared pointer altogether
and hence prevents possible segfaults.
Diffs
-
src/tests/mesos.hpp e25defeb55608136e77363aa48cf820092a13a59
Diff: https://reviews.apache.org/r/63613/diff/1/
Testing
---
See https://reviews.apache.org/r/63615/
Thanks,
Alexander
---
Tested in repetition on Mac OS 10.11.6
`GTEST_FILTER="*SchedulerTest.MasterFailover*" ./bin/mesos-tests.sh --verbose
--gtest_repeat=500 --gtest_break_on_failure`
Thanks,
Alexander Rukletsov
/63674/
Thanks,
Alexander Rukletsov
://reviews.apache.org/r/63672/diff/1-2/
Testing
---
See https://reviews.apache.org/r/63674/
Thanks,
Alexander Rukletsov
org/r/63366/#comment268424>
Additionally to a more descriptive name, could you please leave a comment
saying that jemalloc is not linked into project binaries by default, but only
linked by a specific set of binaries?
- Alexander Rukletsov
On Oct. 27, 2017, 7:03 p.m., Benno Evers
l free to leave a TODO to make it
configurable.
- Alexander Rukletsov
On Oct. 27, 2017, 7:04 p.m., Benno Evers wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https
g libraries are not supported.
src/master/flags.cpp
Lines 632 (patched)
<https://reviews.apache.org/r/63370/#comment268429>
Let's call it "inactive" for clarity.
- Alexander Rukletsov
On Oct. 27, 20
/io_switchboard_tests.cpp
Line 1104 (original), 1115 (patched)
<https://reviews.apache.org/r/63728/#comment268423>
It is not clear that this comment is related to the next two blocks in a
whole.
- Alexander Rukletsov
On Nov. 13, 2017, 4:24 p.m., Benno Evers
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62893/#review190806
---
Ship it!
Ship It!
- Alexander Rukletsov
On Nov. 10, 2017, 3
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63694/#review190740
---
Ship it!
Ship It!
- Alexander Rukletsov
On Nov. 10, 2017
> On Nov. 10, 2017, 4:31 p.m., Alexander Rukletsov wrote:
> > 3rdparty/libprocess/src/memory_profiler.cpp
> > Lines 287-296 (patched)
> > <https://reviews.apache.org/r/63368/diff/1/?file=1870338#file1870338line287>
> >
> > Looks like these guys did no
;t care?
3rdparty/libprocess/src/memory_profiler.cpp
Lines 531 (patched)
<https://reviews.apache.org/r/63368/#comment268338>
Also "if.isElse" : ). Let's s/success/schell/
- Alexander Rukletsov
On Oct. 27, 2017, 7:04 p.m., Benno Evers wrote:
>
> --
al), 1216-1219 (patched)
<https://reviews.apache.org/r/63366/#comment268311>
Ditto?
- Alexander Rukletsov
On Oct. 27, 2017, 7:03 p.m., Benno Evers wrote:
>
> ---
> This is an automatica
)
<https://reviews.apache.org/r/63365/#comment268308>
: )
- Alexander Rukletsov
On Oct. 27, 2017, 7:03 p.m., Benno Evers wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63173/#review190656
---
Ship it!
Ship It!
- Alexander Rukletsov
On Oct. 19, 2017
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63172/#review190655
---
Ship it!
Ship It!
- Alexander Rukletsov
On Oct. 20, 2017
OS 10.11.6
does not fail with the patch while consistently fails without.
Thanks,
Alexander Rukletsov
: )
src/tests/slave_recovery_tests.cpp
Lines 2101-2103 (original), 2119-2121 (patched)
<https://reviews.apache.org/r/63589/#comment268120>
Please resume
- Alexander Rukletsov
On Nov. 6, 2017, 6:41 p.m., Andrei Budnik wrote:
>
> ---
thor and
check whether we should make the field required or remove the check? Or maybe
there is some validation before?
src/slave/http.cpp
Lines 2878-2879 (patched)
<https://reviews.apache.org/r/63694/#comment268089>
Please leading space instead of a trailing one.
- Alexander Ruklets
tps://reviews.apache.org/r/63279/#comment268040>
cpu is not throttable on windows?!
- Alexander Rukletsov
On Nov. 2, 2017, 8:40 p.m., Andrew Schwartzmeyer wrote:
>
> ---
> This is an automatically generated e-mail.
e `detector->appoint(master.get()->pid);` statements.
Thanks,
Alexander Rukletsov
,
Alexander Rukletsov
framework id.
Diffs
-
src/tests/scheduler_tests.cpp 60f60ccd721a5362f827e284f6de6d6e80816ed8
Diff: https://reviews.apache.org/r/63673/diff/1/
Testing
---
https://reviews.apache.org/r/63674/
Thanks,
Alexander Rukletsov
/bin/mesos-tests.sh --verbose
--gtest_repeat=500 --gtest_break_on_failure`
Thanks,
Alexander Rukletsov
/bin/mesos-tests.sh
--verbose --gtest_repeat=100 --gtest_break_on_failure
```
and grepped for "Connection to master" to ensure that this path is taken.
`SchedulerTest.MasterFailover` is modified locally to increase chances by
adding multiple `detector->appoint(master.get()->pid);` statem
401 - 500 of 3026 matches
Mail list logo
