Re: Review Request 67992: Avoid performance cost of ostringstream in http::OK json constructors.

724 (original), 720 (patched) <https://reviews.apache.org/r/67992/#comment289177> Let's not use C-style casts. 3rdparty/libprocess/src/http.cpp Lines 729 (patched) <https://reviews.apache.org/r/67992/#comment289178> Ditto. - Benno Evers On July 20, 2018, 3:39 a.m.

Re: Review Request 67993: Avoid resource copying while serving state json.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67993/#review206275 --- Ship it! Ship It! - Benno Evers On July 20, 2018, 5:23 a.m

Re: Review Request 67991: Adjusted Mesos to compile against jsonify rapidjson changes.

. Maybe it would be possible to have an empty `std::string` member in `StringWriter` that can serve as a buffer and would be written in the destructor, so we can emulate `append()`? - Benno Evers On July 20, 2018, 3:38 a.m., Benjamin Mahler wrote

Re: Review Request 67985: Added rapidjson to the stout build.

against an unbundled version of rapidjson. - Benno Evers On July 20, 2018, 3:38 a.m., Benjamin Mahler wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://rev

Re: Review Request 67986: Added rapidjson to the libprocess build.

902 (patched) <https://reviews.apache.org/r/67986/#comment289180> Same issue as in the prior review. - Benno Evers On July 20, 2018, 3:38 a.m., Benjamin Mahler wrote: > > --- > This is an automatically generated e

Re: Review Request 67987: Added rapidjson to the mesos build.

lso came up when discussing the jemalloc patches - if we modify upstreame tarballs, should we maybe gpg-sign the result? - Benno Evers On July 20, 2018, 3:38 a.m., Benjamin Mahler wrote: > > --- > This is an automatically gener

Re: Review Request 67988: Improved performance of jsonify by integrating with rapidjson.

elpful, since its not immediately obvious that an empty object corresponds to the string "{}". - Benno Evers On July 20, 2018, 3:38 a.m., Benjamin Mahler wrote: > > -

Re: Review Request 67989: Fixed issues with the JSON serialization tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67989/#review206278 --- Ship it! Ship It! - Benno Evers On July 20, 2018, 3:38 a.m

Re: Review Request 67990: Fixed libprocess tests against rapidjson.

imply that users having written custom tooling to parse the response of `/metrics` might see their scripts break, right? - Benno Evers On July 20, 2018, 3:38 a.m., Benjamin Mahler wrote: > > --- > This is an automatically generat

Re: Review Request 67987: Added rapidjson to the mesos build.

> On July 20, 2018, 10:55 a.m., Benno Evers wrote: > > 3rdparty/Makefile.am > > Lines 517 (patched) > > <https://reviews.apache.org/r/67987/diff/1/?file=2061745#file2061745line517> > > > > What's the reason that we cannot use the same `DESTDIR=

Re: Review Request 67987: Added rapidjson to the mesos build.

) <https://reviews.apache.org/r/67987/#comment289266> This can be shortened a bit, since we already have the list stored in a variable: ``` $(nodist_rapidjson_HEADERS): $(RAPIDJSON)-stamp ``` - Benno Evers On July 20, 2018, 3:38 a.m., Benjamin Mahler

Re: Review Request 67987: Added rapidjson to the mesos build.

> --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67987/ > --- > > (Updated July 20, 2018, 3:38 a.m.) > > >

Review Request 68061: Eliminated unnecessary copy in DataEncoder constructor.

--- `make check` Thanks, Benno Evers

Re: Review Request 68061: Eliminated unnecessary copy in DataEncoder constructor.

://reviews.apache.org/r/68061/diff/2/ Changes: https://reviews.apache.org/r/68061/diff/1-2/ Testing --- `make check` Thanks, Benno Evers

Re: Review Request 68061: Eliminated unnecessary copy in DataEncoder constructor.

://reviews.apache.org/r/68061/diff/2/ Testing --- `make check` Thanks, Benno Evers

Review Request 68082: Clarified instructions in docs.

instructions for using libprocess memory profiling together with a custom libjemalloc.so had accidentally omitted a required condition. Diffs - docs/memory-profiling.md 0b829843943d686c0621054c798bb7b827f3432f Diff: https://reviews.apache.org/r/68082/diff/1/ Testing --- Thanks, Benno

Re: Review Request 68098: Fixed rapidjson make install directory structure.

message (`no_base` -> `nobase`, `strucutre` -> `structure`) - Benno Evers On July 29, 2018, 9:46 p.m., Benjamin Mahler wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Review Request 68141: Moved Framework implementation into separate file.

PRE-CREATION src/master/master.hpp 0353d550308816f219aedb6afe15c643fc8bb340 Diff: https://reviews.apache.org/r/68141/diff/1/ Testing --- Thanks, Benno Evers

Re: Review Request 68141: Moved Framework implementation into separate file.

45ffedbc314941f44a5330e78cf7dd2e402c9116 Diff: https://reviews.apache.org/r/68141/diff/2/ Changes: https://reviews.apache.org/r/68141/diff/1-2/ Testing (updated) --- `make check` Thanks, Benno Evers

Re: Review Request 68141: Moved Framework implementation into separate file.

eLists.txt 398ffdddb757e96cfeda376bd983823b9a93904e src/Makefile.am 2ad719e408e56294d308dca1da9f6ea800450a66 src/master/framework.cpp PRE-CREATION src/master/master.hpp 45ffedbc314941f44a5330e78cf7dd2e402c9116 Diff: https://reviews.apache.org/r/68141/diff/2/ Testing --- `make check` Thanks, Benno Evers

Re: Review Request 68141: Moved Framework implementation into separate file.

/ Changes: https://reviews.apache.org/r/68141/diff/2-3/ Testing --- `make check` Thanks, Benno Evers

Review Request 68166: Moved around some functions definitions between files.

top of the file in `framework.cpp`. Diffs - src/master/framework.cpp PRE-CREATION src/master/master.hpp 45ffedbc314941f44a5330e78cf7dd2e402c9116 Diff: https://reviews.apache.org/r/68166/diff/1/ Testing --- Thanks, Benno Evers

Re: Review Request 68141: Moved Framework implementation into separate file.

out-of-class definitions due to reasons (1) and (3) above. - Benno --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68141/#review206788 -------

Re: Review Request 68141: Moved Framework implementation into separate file.

master.cpp 192fe8299777f68bf6f48d693ef79ff75fecfe00 Diff: https://reviews.apache.org/r/68141/diff/4/ Changes: https://reviews.apache.org/r/68141/diff/3-4/ Testing --- `make check` Thanks, Benno Evers

Re: Review Request 68166: Moved around some functions definitions between files.

/diff/1-2/ Testing --- Thanks, Benno Evers

Review Request 68227: Updated git repository url.

move to gitbox, the canonical upstream url changed from `git-wip-us.apache.org` to `gitbox.apache.org`. Diffs - docs/building.md 2b9f61dca2235bfdf2e9c1f106110d83bd9a6ce8 Diff: https://reviews.apache.org/r/68227/diff/1/ Testing --- Thanks, Benno Evers

Re: Review Request 68225: Added 25th and 75th percentiles to `Statistics`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68225/#review206876 --- Ship it! Ship It! - Benno Evers On Aug. 6, 2018, 10:30 a.m

Re: Review Request 68224: Augmented `Statistics` to work with any collection.

ng an additional iteration should be faster than the additional memory allocations. 3rdparty/libprocess/src/tests/statistics_tests.cpp Lines 28 (patched) <https://reviews.apache.org/r/68224/#comment289974> This is adding more characters than just writing out the namespace in th

Re: Review Request 68131: Added MasterPooledStateQuery_BENCHMARK_Test.

cessary here, we can just call the function directly. src/tests/master_benchmarks.cpp Lines 634 (patched) <https://reviews.apache.org/r/68131/#comment289978> Maybe we should add one run here where we query only `stateEndpoint` without hitting `indicatorEndpoint` at the same time?

Review Request 68229: Removed unused local variable in `slave.cpp`.

/1/ Testing --- `make check` Thanks, Benno Evers

Re: Review Request 68229: Removed unused local variable in `slave.cpp`.

: https://reviews.apache.org/r/68229/diff/1/ Testing --- `make check` Thanks, Benno Evers

Re: Review Request 68132: Batch '/state' requests on Master.

ponse`. src/master/master.hpp Line 1467 (original), 1470 (patched) <https://reviews.apache.org/r/68132/#comment290183> Since the `batchedStateRequests` vector acts similarly to a cache, maybe we should keep the `const` here and make the vector `mutable`? - Benno Evers On Aug. 7,

Re: Review Request 68224: Augmented `Statistics` to work with any collection.

t_iterator_tag>::value) ``` (Or even add another `enable_if` to the signature, if you prefer) - Benno Evers On Aug. 9, 2018, 2:20 p.m., Alexander Rukletsov wrote: > > --- > This is an automatically generated e-mail

Review Request 68296: WIP: Add 'handler' field to batched state requests.

master/http.cpp 3812478afead2eba521e169d4e533c631c23f03d src/master/master.hpp cb9d74cd5edc53894955ff405addbba9b89147c9 src/master/master.cpp 21de9739d2891c96cd036621e3f87a160c1d7c30 Diff: https://reviews.apache.org/r/68296/diff/1/ Testing --- Thanks, Benno Evers

Re: Review Request 68296: Add 'handler' field to batched state requests.

6b46e2fa5e7f5e22cfa8 src/master/master.hpp 209b998db8d2bad7a3812df44f0939458f48eb11 src/master/master.cpp 21de9739d2891c96cd036621e3f87a160c1d7c30 Diff: https://reviews.apache.org/r/68296/diff/2/ Changes: https://reviews.apache.org/r/68296/diff/1-2/ Testing --- Thanks, Benno Evers

Review Request 68321: Add '/state-summary' to batched master endpoints.

Testing --- Thanks, Benno Evers

Review Request 68342: Added const versions of slave-counting functions in Master.

added with different names as a workaround. Diffs - src/master/master.hpp 85ef14c1cc72180b746a5f4375769b653cbe511d src/master/master.cpp 400a83e35451a3ee0ea42b5ca729357bf6c744e8 Diff: https://reviews.apache.org/r/68342/diff/1/ Testing --- Thanks, Benno Evers

Review Request 68343: Moved state serialization into separate function.

: https://reviews.apache.org/r/68343/diff/1/ Testing --- Thanks, Benno Evers

Re: Review Request 68296: Added 'handler' field to batched requests.

Testing --- Thanks, Benno Evers

Review Request 68360: Removed Principal object from ObjectApprovers class.

0901a5528b3c383e3e391a3ac1571fd0fd544998 Diff: https://reviews.apache.org/r/68360/diff/1/ Testing --- Thanks, Benno Evers

Review Request 68378: Changed vector of requests to be mutable.

85ef14c1cc72180b746a5f4375769b653cbe511d Diff: https://reviews.apache.org/r/68378/diff/1/ Testing --- Thanks, Benno Evers

Review Request 68379: Added 'handler' field to batched requests.

adds a handler field to be able to batch arbitrary requests, instead of having a hard-coded dispatch to `state`. Testing --- Thanks, Benno Evers

Re: Review Request 68360: Removed Principal object from ObjectApprovers class.

` object. Diffs (updated) - src/common/http.hpp 0901a5528b3c383e3e391a3ac1571fd0fd544998 Diff: https://reviews.apache.org/r/68360/diff/2/ Changes: https://reviews.apache.org/r/68360/diff/1-2/ Testing --- Thanks, Benno Evers

Re: Review Request 68321: Add '/state-summary' to batched master endpoints.

iff: https://reviews.apache.org/r/68321/diff/2/ Changes: https://reviews.apache.org/r/68321/diff/1-2/ Testing --- Thanks, Benno Evers

Re: Review Request 68378: Changed vector of requests to be mutable.

e2773ed78d3d07da13029a4d75143f062d97c852 src/master/master.hpp 85ef14c1cc72180b746a5f4375769b653cbe511d Diff: https://reviews.apache.org/r/68378/diff/2/ Changes: https://reviews.apache.org/r/68378/diff/1-2/ Testing --- Thanks, Benno Evers

Re: Review Request 68296: Added 'handler' field to batched requests.

/master.hpp 85ef14c1cc72180b746a5f4375769b653cbe511d Diff: https://reviews.apache.org/r/68296/diff/6/ Changes: https://reviews.apache.org/r/68296/diff/5-6/ Testing --- Thanks, Benno Evers

Re: Review Request 68343: Moved state serialization into separate function.

85ef14c1cc72180b746a5f4375769b653cbe511d Diff: https://reviews.apache.org/r/68343/diff/2/ Changes: https://reviews.apache.org/r/68343/diff/1-2/ Testing --- Thanks, Benno Evers

Re: Review Request 68343: Moved state serialization into separate function.

36994a18a8e9092c0a46834f56ce3d9448e2bca3 Diff: https://reviews.apache.org/r/68343/diff/3/ Changes: https://reviews.apache.org/r/68343/diff/2-3/ Testing --- Thanks, Benno Evers

Re: Review Request 68296: Added 'handler' field to batched requests.

e2773ed78d3d07da13029a4d75143f062d97c852 src/master/master.hpp 36994a18a8e9092c0a46834f56ce3d9448e2bca3 Diff: https://reviews.apache.org/r/68296/diff/7/ Changes: https://reviews.apache.org/r/68296/diff/6-7/ Testing --- Thanks, Benno Evers

Re: Review Request 68296: Added 'handler' field to batched requests.

- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68296/#review207606 --- On Aug. 20, 2018, 2:11 p.m., Benno Evers wrote: > >

Re: Review Request 68343: Moved state serialization into separate function.

------- On Aug. 20, 2018, 2:08 p.m., Benno Evers wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68343/ > ---

Re: Review Request 68343: Moved state serialization into separate function.

e2773ed78d3d07da13029a4d75143f062d97c852 src/master/master.hpp 36994a18a8e9092c0a46834f56ce3d9448e2bca3 Diff: https://reviews.apache.org/r/68343/diff/4/ Changes: https://reviews.apache.org/r/68343/diff/3-4/ Testing --- Thanks, Benno Evers

Re: Review Request 68321: Add '/state-summary' to batched master endpoints.

ache.org/r/68321/diff/2/ Testing --- Thanks, Benno Evers

Re: Review Request 68296: Added 'handler' field to batched requests.

e2773ed78d3d07da13029a4d75143f062d97c852 src/master/master.hpp 36994a18a8e9092c0a46834f56ce3d9448e2bca3 Diff: https://reviews.apache.org/r/68296/diff/8/ Testing (updated) --- `make check` on various Linux distros. Thanks, Benno Evers

Re: Review Request 68321: Add '/state-summary' to batched master endpoints.

master.hpp 85ef14c1cc72180b746a5f4375769b653cbe511d Diff: https://reviews.apache.org/r/68321/diff/2/ Testing --- Thanks, Benno Evers

Re: Review Request 68378: Changed vector of requests to be mutable.

. Diffs - src/master/http.cpp e2773ed78d3d07da13029a4d75143f062d97c852 src/master/master.hpp 85ef14c1cc72180b746a5f4375769b653cbe511d Diff: https://reviews.apache.org/r/68378/diff/2/ Testing (updated) --- See https://reviews.apache.org/r/68296/ Thanks, Benno Evers

Re: Review Request 68342: Added const versions of slave-counting functions in Master.

iff: https://reviews.apache.org/r/68342/diff/1/ Testing (updated) --- See https://reviews.apache.org/r/68296/ Thanks, Benno Evers

Re: Review Request 68343: Moved state serialization into separate function.

e2773ed78d3d07da13029a4d75143f062d97c852 src/master/master.hpp 36994a18a8e9092c0a46834f56ce3d9448e2bca3 Diff: https://reviews.apache.org/r/68343/diff/4/ Testing (updated) --- See https://reviews.apache.org/r/68296/ Thanks, Benno Evers

Review Request 68440: Added '/tasks' to the set of batched master endpoints.

'/tasks' to the set of batched master endpoints. Diffs - src/master/http.cpp ae28d525e5c0fe067ae77a4c71e8f18f772ff1dc src/master/master.hpp dc0080b24f19b77a4de34ab24aece657726343b8 Diff: https://reviews.apache.org/r/68440/diff/1/ Testing --- Thanks, Benno Evers

Review Request 68442: Added '/frameworks' to the set of batched master endpoints.

'/frameworks' to the set of batched master endpoints. Diffs - src/master/http.cpp ae28d525e5c0fe067ae77a4c71e8f18f772ff1dc src/master/master.hpp dc0080b24f19b77a4de34ab24aece657726343b8 Diff: https://reviews.apache.org/r/68442/diff/1/ Testing --- Thanks, Benno Evers

Re: Review Request 68321: Added '/state-summary' to the set of batched master endpoints.

/diff/2-3/ Testing --- Thanks, Benno Evers

Review Request 68441: Added '/slaves' to the set of batched master endpoints.

'/slaves' to the set of batched master endpoints. Diffs - src/master/http.cpp ae28d525e5c0fe067ae77a4c71e8f18f772ff1dc src/master/master.hpp dc0080b24f19b77a4de34ab24aece657726343b8 Diff: https://reviews.apache.org/r/68441/diff/1/ Testing --- Thanks, Benno Evers

Re: Review Request 68321: Added '/state-summary' to the set of batched master endpoints.

To reply, visit: https://reviews.apache.org/r/68321/#review207650 ------- On Aug. 21, 2018, 2:09 p.m., Benno Evers wrote: > > --- > This is an automatical

Review Request 68473: Moved members of ReadOnlyHandler into separate file.

1b6d266a1a7821c9de6871cbca43317b3c392a32 Diff: https://reviews.apache.org/r/68473/diff/1/ Testing --- `make` Thanks, Benno Evers

Re: Review Request 68473: Moved members of ReadOnlyHandler into separate file.

-CREATION src/master/readonly_handler.cpp PRE-CREATION src/slave/http.cpp 1b6d266a1a7821c9de6871cbca43317b3c392a32 Diff: https://reviews.apache.org/r/68473/diff/2/ Changes: https://reviews.apache.org/r/68473/diff/1-2/ Testing --- `make` Thanks, Benno Evers

Review Request 68484: Enforced disabling boost debug mode.

Description --- Enforced disabling boost debug mode. Diffs - src/master/master.hpp 85ef14c1cc72180b746a5f4375769b653cbe511d Diff: https://reviews.apache.org/r/68484/diff/1/ Testing --- Still todo. Thanks, Benno Evers

Re: Review Request 68484: Enforced disabling boost debug mode.

above script does not produce a segfault anymore. Thanks, Benno Evers

Re: Review Request 68484: Enforced disabling boost debug mode.

ated e-mail. To reply, visit: https://reviews.apache.org/r/68484/#review207855 --- On Aug. 23, 2018, 4:25 p.m., Benno Evers wrote: > > --- > This is an automatically generated

Re: Review Request 68484: Enforced disabling boost debug mode.

sted minimum version shouldn't be higher than 1.53 if we add it? - Benno --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68484/#review207832 -----

Re: Review Request 68484: Enforced disabling boost debug mode.

ply, visit: https://reviews.apache.org/r/68484/#review207865 --- On Aug. 23, 2018, 4:25 p.m., Benno Evers wrote: > > --- > This is an automatically generated e-mail. To reply, vis

Re: Review Request 68484: Added macros to unconditionally disable boost debug mode.

mesos master. * Recompiled mesos with this patch applied. * Verified that the above script does not produce a segfault anymore. Thanks, Benno Evers

Re: Review Request 68484: Unconditionally disabled boost debug mode.

s not produce a segfault anymore. Thanks, Benno Evers

Review Request 68503: Replaced boost includes with stout equivalents.

Diff: https://reviews.apache.org/r/68503/diff/1/ Testing --- Thanks, Benno Evers

Review Request 68502: Added stout wrapper for `boost::circular_buffer`.

/include/Makefile.am 0a4ea7b16b316cc8a411ac9c4d20783530b7168a 3rdparty/stout/include/stout/circular_buffer.hpp PRE-CREATION Diff: https://reviews.apache.org/r/68502/diff/1/ Testing --- Thanks, Benno Evers

Re: Review Request 68484: Unconditionally disabled boost debug mode.

are nicely encapsulated in > > `stout`. > > 2. Add these defines whenever we make use of Boost (simple in cmake, > > slightly more messy in autotools). That way users cannot forget to add them > > when using `boost/circular_buffer.hpp`. > > > > I perso

Re: Review Request 68503: Replaced boost includes with stout equivalents.

0420109ac93e1249906c52437e5859c5ee033fb6 Diff: https://reviews.apache.org/r/68503/diff/1/ Testing (updated) --- - Repeated the procedure described in https://reviews.apache.org/r/68484 - `make check` - Internal CI run. (Build #4239) Thanks, Benno Evers

Re: Review Request 68484: Unconditionally disabled boost debug mode.

acro because he wants to use boost's debug features. - Benno --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68484/#review207892 ------

Re: Review Request 68502: Added stout wrapper for `boost::circular_buffer`.

-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68502/#review207893 --- On Aug. 24, 2018, 1:48 p.m., Benno Evers wrote: > >

Re: Review Request 68502: Added stout wrapper for `boost::circular_buffer`.

://reviews.apache.org/r/68502/diff/2/ Changes: https://reviews.apache.org/r/68502/diff/1-2/ Testing --- See follow-up review r/68503. Thanks, Benno Evers

Re: Review Request 68484: Unconditionally disabled boost debug mode.

is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68484/#review207892 --- On Aug. 24, 2018, 12:28 p.m., Benno Evers wrote: > > --- > This is an automatica

Re: Review Request 68473: Moved members of ReadOnlyHandler into separate file.

/slave/http.cpp 1b6d266a1a7821c9de6871cbca43317b3c392a32 Diff: https://reviews.apache.org/r/68473/diff/3/ Changes: https://reviews.apache.org/r/68473/diff/2-3/ Testing (updated) --- [Revision 0] `make` [Revision 1] Triggered Internal CI run. (Jenkins id #4162) Thanks, Benno Evers

Re: Review Request 68473: Moved members of ReadOnlyHandler into separate file.

e-mail. To reply, visit: https://reviews.apache.org/r/68473/#review207963 ------- On Aug. 27, 2018, 2:57 p.m., Benno Evers wrote: > > --- > This is an automatically ge

Re: Review Request 68473: Moved members of ReadOnlyHandler into separate file.

e/http.cpp 1b6d266a1a7821c9de6871cbca43317b3c392a32 Diff: https://reviews.apache.org/r/68473/diff/3/ Testing (updated) --- `make check` Internal CI run (Build #4249) Thanks, Benno Evers

Re: Review Request 68321: Added '/state-summary' to the set of batched master endpoints.

------ On Aug. 21, 2018, 2:09 p.m., Benno Evers wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68321/ > ---

Re: Review Request 68321: Added '/state-summary' to the set of batched master endpoints.

src/master/master.hpp dc0080b24f19b77a4de34ab24aece657726343b8 Diff: https://reviews.apache.org/r/68321/diff/3/ Testing (updated) --- https://reviews.apache.org/r/68473/ Thanks, Benno Evers

Re: Review Request 68440: Added '/tasks' to the set of batched master endpoints.

440/diff/1/ Testing (updated) --- https://reviews.apache.org/r/68473/ Thanks, Benno Evers

Re: Review Request 68440: Added '/tasks' to the set of batched master endpoints.

atically generated e-mail. To reply, visit: https://reviews.apache.org/r/68440/#review207954 ------- On Aug. 28, 2018, 10:09 a.m., Benno Evers wrote: > > --- > This is a

Re: Review Request 68440: Added '/tasks' to the set of batched master endpoints.

master.hpp 1e01dab8b5160e0b69670c896cb5e9fc0bf31005 Diff: https://reviews.apache.org/r/68440/diff/2/ Changes: https://reviews.apache.org/r/68440/diff/1-2/ Testing --- See https://reviews.apache.org/r/68473/ Thanks, Benno Evers

Re: Review Request 68321: Added '/state-summary' to the set of batched master endpoints.

r/http.cpp ae28d525e5c0fe067ae77a4c71e8f18f772ff1dc src/master/master.hpp 1e01dab8b5160e0b69670c896cb5e9fc0bf31005 Diff: https://reviews.apache.org/r/68321/diff/4/ Changes: https://reviews.apache.org/r/68321/diff/3-4/ Testing --- See https://reviews.apache.org/r/68473/ Thanks, Benno Evers

Review Request 68537: Cleaned up some style issues in `ReadOnlyHandler`.

. Diffs - src/master/master.hpp 1e01dab8b5160e0b69670c896cb5e9fc0bf31005 src/master/readonly_handler.cpp PRE-CREATION Diff: https://reviews.apache.org/r/68537/diff/1/ Testing --- Thanks, Benno Evers

Re: Review Request 68441: Added '/slaves' to the set of batched master endpoints.

gether. Fixed in https://reviews.apache.org/r/68537/ - Benno --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68441/#review207960 --- On Aug

Re: Review Request 68442: Added '/frameworks' to the set of batched master endpoints.

g/r/68441/ Fixed in https://reviews.apache.org/r/68537/ - Benno --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68442/#review207961 --

Re: Review Request 68537: Cleaned up some style issues in `ReadOnlyHandler`.

g (updated) --- Started Internal CI Run (Jenkins Id #4262) Thanks, Benno Evers

Re: Review Request 68537: Cleaned up some style issues in `ReadOnlyHandler`.

://reviews.apache.org/r/68537/diff/1-2/ Testing --- Started Internal CI Run (Jenkins Id #4262) Thanks, Benno Evers

Review Request 68542: De-duplicated identical read-only requests to master.

ae28d525e5c0fe067ae77a4c71e8f18f772ff1dc src/master/master.hpp 1e01dab8b5160e0b69670c896cb5e9fc0bf31005 Diff: https://reviews.apache.org/r/68542/diff/1/ Testing --- Accessed `localhost:5050/state` on master including these changes. Thanks, Benno Evers

Re: Review Request 68440: Added '/tasks' to the set of batched master endpoints.

master.hpp 1e01dab8b5160e0b69670c896cb5e9fc0bf31005 Diff: https://reviews.apache.org/r/68440/diff/2/ Testing --- See https://reviews.apache.org/r/68473/ Thanks, Benno Evers

Re: Review Request 68442: Added '/frameworks' to the set of batched master endpoints.

master.hpp 1e01dab8b5160e0b69670c896cb5e9fc0bf31005 Diff: https://reviews.apache.org/r/68442/diff/2/ Testing --- Thanks, Benno Evers

Re: Review Request 68441: Added '/slaves' to the set of batched master endpoints.

master.hpp 1e01dab8b5160e0b69670c896cb5e9fc0bf31005 Diff: https://reviews.apache.org/r/68441/diff/2/ Testing --- See https://reviews.apache.org/r/68473/ Thanks, Benno Evers

Re: Review Request 68442: Added '/frameworks' to the set of batched master endpoints.

master.hpp 1e01dab8b5160e0b69670c896cb5e9fc0bf31005 Diff: https://reviews.apache.org/r/68442/diff/2/ Testing (updated) --- See https://reviews.apache.org/r/68473/ Thanks, Benno Evers

Review Request 68568: Added '/roles' to the set of batched master endpoints.

r/http.cpp e074a93666d82944774e7b0c3fa32d7021d93c97 src/master/master.hpp eecb66c8826b2b681ef94e6457c2651fc63c724b src/master/readonly_handler.cpp 47d7de5bce4f6b21134596fe53dd02e457f9c069 Diff: https://reviews.apache.org/r/68568/diff/1/ Testing --- Thanks, Benno Evers

<    1   2   3   4   5   6   7   8   9   >