---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60647/#review179647
---
Ship it!
Ship It!
- Gilbert Song
On July 5, 2017, 2:15 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58645/#review172992
---
Ship it!
Ship It!
- Gilbert Song
On April 21, 2017, 7:48
tps://reviews.apache.org/r/58725/#comment246135>
Please fix the indentation.
src/uri/fetchers/docker.cpp
Lines 476 (patched)
<https://reviews.apache.org/r/58725/#comment246136>
Could you paste the link to the docker doc for `Accept` header.
- Gilbert Song
On April 25, 2017, 5:30 p.m
/58747/diff/1/
Testing
---
make check
Thanks,
Gilbert Song
---
Fixed the internet curl flaky test due to short timeout.
Diffs
-
src/tests/containerizer/provisioner_docker_tests.cpp
c26e1f9b093fda66f14e474006d8148c0b9f3245
Diff: https://reviews.apache.org/r/58748/diff/1/
Testing
---
make check
Thanks,
Gilbert Song
ps://reviews.apache.org/r/58747/#review173085
-------
On April 26, 2017, 12:14 p.m., Gilbert Song wrote:
>
> ---
> This is an automatically generated e-mail.
Description
---
Fixed a typo in container-image.md doc.
Diffs
-
docs/container-image.md fad4fd22533de960c2c5cfc52ae7d13a9cffdc67
Diff: https://reviews.apache.org/r/58749/diff/1/
Testing
---
N/A.
Thanks,
Gilbert Song
; > error message saying that some fields are missing. What do you think?
>
> Jie Yu wrote:
> Also related to https://reviews.apache.org/r/58725
>
> Maybe we should just land Ilya's scheme 2 support? Gilbert, thouughts?
>
> Gilbert Song wrote:
> Tha
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58725/#review173122
---
Ship it!
Ship It!
- Gilbert Song
On April 26, 2017, 3:27
-v2-1/
Diffs (updated)
-
src/uri/fetchers/docker.cpp 1c6ab929deacfc29aa6b4f1df04c2b9782044a90
Diff: https://reviews.apache.org/r/58747/diff/2/
Changes: https://reviews.apache.org/r/58747/diff/1-2/
Testing
---
make check
Thanks,
Gilbert Song
/58775/diff/1/
Testing
---
make
Thanks,
Gilbert Song
eviews.apache.org/r/58747/#review173136
---
On April 26, 2017, 4:12 p.m., Gilbert Song wrote:
>
> ---
> This is an automatically generated e-mail. To re
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58642/#review172836
---
Ship it!
Ship It!
- Gilbert Song
On April 21, 2017, 7:47
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58646/#review172835
---
Ship it!
Ship It!
- Gilbert Song
On April 21, 2017, 7:49
che.org/r/58644/#comment246030>
Could we merge these two `if` into one?
- Gilbert Song
On April 21, 2017, 7:48 p.m., Jie Yu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
Could we add some comments?
- Gilbert Song
On April 26, 2017, 4:38 p.m., Kapil Arya wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58758/#review173382
---
Ship it!
Ship It!
- Gilbert Song
On April 28, 2017, 11:49
---
Disabled unit test relying on AliCloud Registry.
Diffs
-
src/tests/containerizer/provisioner_docker_tests.cpp
4341621767a9fa5be2c66e77ef60f0c65dae58ca
Diff: https://reviews.apache.org/r/58824/diff/1/
Testing
---
make check
Thanks,
Gilbert Song
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61406/#review182232
---
Ship it!
Ship It!
- Gilbert Song
On Aug. 4, 2017, 9 a.m
ched)
<https://reviews.apache.org/r/61428/#comment258140>
We can just return launchInfo, right?
- Gilbert Song
On Aug. 4, 2017, 9:39 a.m., Qian Zhang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http
85-86 (patched)
<https://reviews.apache.org/r/61428/#comment258142>
I know in proto2 and proto3 `boolean` defaults to be `false`. But how about
`optional bool`? do you know if `has_share_pid_namespace` can be false?
- Gilbert Song
On Aug. 4, 2017, 9:39 a.m., Qian Zhang
/
Changes: https://reviews.apache.org/r/61120/diff/3-4/
Testing
---
make check
Thanks,
Gilbert Song
ocker for this test? The problem should be reproducible
> > without it.
>
> Ilya Pronin wrote:
> I meant an image. Not Docker itself :)
>
> Gilbert Song wrote:
> We don't allow `host_path` and `container_path` to be both relative.
>
>
> https://git
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61406/#review182455
---
Ship it!
Ship It!
- Gilbert Song
On Aug. 6, 2017, 7:52 p.m
"op": "ASYNC",
"value": 1
},
{
"op": "TOTAL",
"value": 1
}
]
},
{
"io_service_bytes": [
{
"op": "TOTAL",
"value": 4096
}
],
"io_serviced": [
{
"op": "TOTAL",
"value": 1
}
]
}
]
},
"cpus_limit": 1.1,
"mem_limit_bytes": 167772160,
"timestamp": 1500335339.30187
}
}
]
```
Thanks,
Gilbert Song
41e42b4996235cbee26f580f4a7aa2daed166b7f
include/mesos/v1/mesos.proto 9de282f85b8d0ba91fa3de85acd5d0f4082a47d8
Diff: https://reviews.apache.org/r/60932/diff/7/
Changes: https://reviews.apache.org/r/60932/diff/6-7/
Testing
---
make
Thanks,
Gilbert Song
66386a84bc21989d1c1237e629d5d04662a368fa
Diff: https://reviews.apache.org/r/61270/diff/2/
Changes: https://reviews.apache.org/r/61270/diff/1-2/
Testing
---
make
Thanks,
Gilbert Song
://reviews.apache.org/r/61531/diff/3/
Changes: https://reviews.apache.org/r/61531/diff/2-3/
Testing
---
make check
Thanks,
Gilbert Song
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61463/#review182343
---
Ship it!
Ship It!
- Gilbert Song
On Aug. 7, 2017, 8:12 a.m
> On Aug. 4, 2017, 5:33 p.m., Gilbert Song wrote:
> > src/slave/containerizer/mesos/isolators/namespaces/pid.cpp
> > Lines 130 (patched)
> > <https://reviews.apache.org/r/61428/diff/2/?file=1789465#file1789465line132>
> >
> > Could we reverse two logi
/volume_sandbox_path_isolator_tests.cpp
3228b9a7df0fcb7973b210a1d0c17a18869c73d4
Diff: https://reviews.apache.org/r/61121/diff/2/
Changes: https://reviews.apache.org/r/61121/diff/1-2/
Testing
---
make check
Verified that this test failed if we don't have the bugfix patch.
Thanks,
Gilbert Song
. To reply, visit:
https://reviews.apache.org/r/61121/#review181464
-------
On July 27, 2017, 6:43 p.m., Gilbert Song wrote:
>
> ---
> This is an automatic
x volume, not host volume. Let's change the commit title
> > as well.
>
> Gilbert Song wrote:
> I regard a `host_path` 1)absolute and 2)relative both as `host volume`.
> Otherwise, people will get confused by `sandbox volume` vs `sandbox path
> volume`. Shouldn't we de
check
Verified that this test failed if we don't have the bugfix patch.
Thanks,
Gilbert Song
/isolators/filesystem/linux.cpp#L453~#L460
- Gilbert
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61123/#review181467
-------
bf35b7f00d6e80672ffc27cfc3f3a2fd8de69a99
Diff: https://reviews.apache.org/r/61122/diff/3/
Changes: https://reviews.apache.org/r/61122/diff/2-3/
Testing
---
make check
Thanks,
Gilbert Song
n't we define the name by `type`?
- Gilbert
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61122/#review181403
-------
On
------
On July 25, 2017, 4:15 p.m., Gilbert Song wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61120/
> ---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60933/#review181093
-------
On July 20, 2017, 4:58 p.m., Gilbert Song wrote:
>
> -
"op": "ASYNC",
"value": 1
},
{
"op": "TOTAL",
"value": 1
}
]
},
{
"io_service_bytes": [
{
"op": "TOTAL",
"value": 4096
}
],
"io_serviced": [
{
"op": "TOTAL",
"value": 1
}
]
}
]
},
"cpus_limit": 1.1,
"mem_limit_bytes": 167772160,
"timestamp": 1500335339.30187
}
}
]
```
Thanks,
Gilbert Song
://reviews.apache.org/r/60933/diff/3-4/
Testing
---
make check
Thanks,
Gilbert Song
t? What about putting it
> > into `totalCfq`?
+1.
- Gilbert
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60934/#review181101
--------
,
Gilbert Song
8f8079bd7c2de4e8b2f8f9a56e2731b77b8e1575
include/mesos/v1/mesos.proto 720f307f8d738b0787e7c47be7ee15be38b2c0d0
Diff: https://reviews.apache.org/r/60932/diff/4/
Changes: https://reviews.apache.org/r/60932/diff/3-4/
Testing
---
make
Thanks,
Gilbert Song
/
Changes: https://reviews.apache.org/r/60991/diff/1-2/
Testing
---
make
Thanks,
Gilbert Song
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58759/#review174911
---
Ship it!
Ship It!
- Gilbert Song
On May 12, 2017, 10:52 a.m
(patched)
<https://reviews.apache.org/r/58760/#comment248183>
Newline above.
src/secret/resolver.cpp
Lines 78 (patched)
<https://reviews.apache.org/r/58760/#comment248184>
Newline above.
- Gilbert Song
On May 12, 2017, 10:52 a.m., Kapi
tps://reviews.apache.org/r/58759/#comment248182>
Did we try to get rid of the c style comments:
```
/**
*
*/
```
and insist on c++ ctyle comments:
```
//
//
//
```
ditto to the others.
- Gilbert Song
On May 12, 2017, 10:52 a.m.,
g/r/59018/#review174584
---
On May 10, 2017, 5:48 a.m., Gilbert Song wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
omatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59015/#review174580
-------
On May 10, 2017, 5:47 a.m., Gilbert Song wrote:
>
> ---
> This is
different image secrets
works correctly.
Thanks,
Gilbert Song
://reviews.apache.org/r/59141/diff/2/
Changes: https://reviews.apache.org/r/59141/diff/1-2/
Testing
---
make check
Thanks,
Gilbert Song
8>
s/secret resolve module/secret resolver module/g ?
- Gilbert Song
On May 12, 2017, 10:52 a.m., Kapil Arya wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
nes 100-107 (patched)
<https://reviews.apache.org/r/59000/#comment248242>
Let's add a `TODO` here to refactor the helper `createEnvironment()` to
support value based/secret based env var respectively.
- Gilbert Song
On May 12, 2017, 10:52 a.m., Kapil Arya wrote:
>
> -
ache.org/r/59012/#review174103
---
On May 5, 2017, 4:16 p.m., Gilbert Song wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visi
t does not hurt here. but we should set a default.
- Gilbert
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59012/#review174251
-------
On May
eviews.apache.org/r/59017/#review174398
-------
On May 4, 2017, 4:22 p.m., Gilbert Song wrote:
>
> ---
> This is an automatically generated e-mail. To re
/
Testing
---
N/A
Thanks,
Gilbert Song
her this image is cached
or not.
- Gilbert
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59013/#review174253
-------
On May 4, 2017, 4:22 p.m., Gilbert Song wrote:
>
> ---
check
Thanks,
Gilbert Song
68ce265a5d0a61f8d9ed55dd14c630dcf893a7d2
src/tests/containerizer/provisioner_docker_tests.cpp
4341621767a9fa5be2c66e77ef60f0c65dae58ca
Diff: https://reviews.apache.org/r/59013/diff/2/
Changes: https://reviews.apache.org/r/59013/diff/1-2/
Testing
---
make check
Thanks,
Gilbert Song
/r/59012/diff/3-4/
Testing
---
make check
Thanks,
Gilbert Song
an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59015/#review174256
-------
On May 4, 2017, 4:22 p.m., Gilbert Song wrote:
>
> ---
> This is
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59140/#review174462
---
Ship it!
Ship It!
- Gilbert Song
On May 10, 2017, 5:34 a.m
.apache.org/r/59012/#review174251
---
On May 5, 2017, 4:16 p.m., Gilbert Song wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> htt
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59012/#review174280
-------
On May 5, 2017, 4:16 p.m., Gilbert Song wrote:
>
> -
avoid updating tests?
yes.
- Gilbert
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59012/#review174251
-------
On May
e. We are not using the uri to pass docker
config now.
- Gilbert
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59018/#review174075
--------
different image secrets
works correctly.
Thanks,
Gilbert Song
/hadoop.hpp 4923dc6491d7cc6efc6ced4f5356af9f945ba5d2
src/uri/fetchers/hadoop.cpp 3c5ffe607c92ea1ab66ba261bd70031f2907cea6
Diff: https://reviews.apache.org/r/59141/diff/1/
Testing
---
make check
Thanks,
Gilbert Song
b90f731ef07c22259715543526eaf25cb94eab03
src/docker/spec.cpp 6b5588e534215451593cc20011847c3abbab9b17
Diff: https://reviews.apache.org/r/59017/diff/2/
Changes: https://reviews.apache.org/r/59017/diff/1-2/
Testing
---
make check
Thanks,
Gilbert Song
> On May 15, 2017, 6:42 a.m., Gilbert Song wrote:
> > src/slave/containerizer/mesos/isolators/environment_secret.cpp
> > Lines 137-138 (patched)
> > <https://reviews.apache.org/r/59000/diff/6/?file=1717035#file1717035line137>
> >
> > How
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58999/#review175258
---
Ship it!
Ship It!
- Gilbert Song
On May 16, 2017, 12:22 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59000/#review175262
---
Ship it!
Ship It!
- Gilbert Song
On May 16, 2017, 12:22 p.m
have another `getAuthHeaders()` helper.
- Gilbert Song
On May 12, 2017, 5:45 p.m., Chun-Hung Hsiao wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
at #L4097.
src/tests/master_tests.cpp
Line 6289 (original), 6289 (patched)
<https://reviews.apache.org/r/59318/#comment248799>
Should we fix the other two `EXPECT_` in this file?
- Gilbert Song
On May 16, 2017, 12:28 p.m., Kapil Arya
/volume/secret.cpp
Lines 289 (patched)
<https://reviews.apache.org/r/59001/#comment248258>
two more space.
src/slave/containerizer/mesos/isolators/volume/secret.cpp
Lines 298 (patched)
<https://reviews.apache.org/r/59001/#comment248257>
Use `collect`?
- Gilbert Song
On M
)
<https://reviews.apache.org/r/58778/#comment248407>
I like the `__fetchBlob()` change. More readable in code.
- Gilbert Song
On May 15, 2017, 5:50 p.m., Chun-Hung Hsiao wrote:
>
> ---
> This is an automatically g
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58778/#review175061
---
Ship it!
LGTM! Ship it!
- Gilbert Song
On May 15, 2017, 5
eply, visit:
https://reviews.apache.org/r/59141/#review174535
-------
On May 10, 2017, 5:48 a.m., Gilbert Song wrote:
>
> ---
> This is an automatically g
---------
On May 10, 2017, 5:48 a.m., Gilbert Song wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59018/
> -
--
On May 10, 2017, 5:47 a.m., Gilbert Song wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59015/
> --
make check
Thanks,
Gilbert Song
Thanks,
Gilbert Song
---
make check
Thanks,
Gilbert Song
://reviews.apache.org/r/59017/diff/2-3/
Testing
---
make check
Thanks,
Gilbert Song
> On May 9, 2017, 4:25 p.m., Vinod Kone wrote:
> > include/mesos/docker/spec.hpp
> > Lines 83 (patched)
> > <https://reviews.apache.org/r/59017/diff/1/?file=1709140#file1709140line83>
> >
> > no unit test for this?
>
> Gilbert Song wrote:
&
ally generated e-mail. To reply, visit:
https://reviews.apache.org/r/59141/#review175360
-------
On May 12, 2017, 4:19 a.m., Gilbert Song wrote:
>
> ---
> This is an au
://reviews.apache.org/r/59141/diff/3/
Changes: https://reviews.apache.org/r/59141/diff/2-3/
Testing
---
make check
Thanks,
Gilbert Song
/mesos.proto ab617bfd2bc46e44f7d71cefecf5eac3630d22b3
Diff: https://reviews.apache.org/r/59010/diff/3/
Changes: https://reviews.apache.org/r/59010/diff/2-3/
Testing
---
N/A.
Thanks,
Gilbert Song
different registries using different image secrets
works correctly.
Thanks,
Gilbert Song
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59318/#review175739
---
Ship it!
Ship It!
- Gilbert Song
On May 22, 2017, 1:55 p.m
et.cpp
Lines 164 (patched)
<https://reviews.apache.org/r/59001/#comment248994>
Just a nit:
`const Secret&`
src/slave/containerizer/mesos/isolators/volume/secret.cpp
Lines 264 (patched)
<https://reviews.apache.org/r/59001/#comment249004>
Do we have to do `force`
)
-
src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp
6db788dd0c582deadf3e91c4d21bb9c20cf94e6b
Diff: https://reviews.apache.org/r/59015/diff/4/
Changes: https://reviews.apache.org/r/59015/diff/3-4/
Testing
---
make check
Thanks,
Gilbert Song
private image from different registries using different image secrets
works correctly.
Thanks,
Gilbert Song
Diff: https://reviews.apache.org/r/59141/diff/4/
Changes: https://reviews.apache.org/r/59141/diff/3-4/
Testing
---
make check
Thanks,
Gilbert Song
://reviews.apache.org/r/59016/diff/2/
Changes: https://reviews.apache.org/r/59016/diff/1-2/
Testing
---
N/A
Thanks,
Gilbert Song
82a9be64264ae829773c1e2e8a4360f78641cbf6
src/slave/containerizer/mesos/provisioner/store.cpp
7141d63fcf2dbc3fbf00508c7f92945aab014fb2
Diff: https://reviews.apache.org/r/59012/diff/5/
Changes: https://reviews.apache.org/r/59012/diff/4-5/
Testing
---
make check
Thanks,
Gilbert Song
://reviews.apache.org/r/59011/diff/2/
Changes: https://reviews.apache.org/r/59011/diff/1-2/
Testing
---
make check
Thanks,
Gilbert Song
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59749/#review176864
---
Ship it!
Ship It!
- Gilbert Song
On June 2, 2017, 9:13 a.m
1301 - 1400 of 2187 matches
Mail list logo
