.
Repository: mesos
Description
---
Removed old comment from 'mesos.proto'.
Diffs
-
include/mesos/mesos.proto b965f5a6b1aff28feb2ab088c30ea927b9247403
Diff: https://reviews.apache.org/r/45168/diff/
Testing
---
Thanks,
Greg Mann
b77afa956834bb5b1f85301d7a5f386ab9da41e3
src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697
src/tests/mesos.cpp 90aef6bfe619dc0acdb4ccba6a7180482dd13ce5
Diff: https://reviews.apache.org/r/44515/diff/
Testing
---
`sudo make check` was used to test on both OSX and Ubuntu 14.04.
Thanks,
Greg
Ubuntu 14.04.
Thanks,
Greg Mann
buntu 14.04. The new test
was run 1000 times to look for flakiness.
Thanks,
Greg Mann
buntu 14.04. The new test
was run 1000 times to look for flakiness.
Thanks,
Greg Mann
/*`
endpoints.
Thanks,
Greg Mann
were no pre-existing tests for that
endpoint.
Diffs
-
src/tests/files_tests.cpp b3894954e32b14f879f24fac17869fc32ad2ce0e
Diff: https://reviews.apache.org/r/45249/diff/
Testing
---
`sudo make check` was used to test on OSX and CentOS 7.
Thanks,
Greg Mann
ake check` was used to test on OSX and CentOS 7.
The master and agent binaries were run both with and without HTTP
authentication, and tested for the expected behavior at the `/files/*`
endpoints.
Thanks,
Greg Mann
make check` was used to test on OSX and CentOS 7.
Thanks,
Greg Mann
tps://reviews.apache.org/r/43935/#comment188100>
s/sepcified/specified/
- Greg Mann
On March 22, 2016, 2:57 a.m., Jian Qiu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
aries were run both with and without HTTP
authentication, and tested for the expected behavior at the `/files/*`
endpoints.
Thanks,
Greg Mann
sting
---
`sudo make check` was used to test on OSX and CentOS 7.
Thanks,
Greg Mann
---
`GTEST_FILTER="FilesTest.AuthenticationTest" bin/mesos-tests.sh
--gtest_repeat=1000 --gtest_break_on_failure=1` was used to test on OSX.
Thanks,
Greg Mann
files_tests.cpp b3894954e32b14f879f24fac17869fc32ad2ce0e
Diff: https://reviews.apache.org/r/45249/diff/
Testing
---
`sudo make check` was used to test on OSX and CentOS 7.
Thanks,
Greg Mann
b3894954e32b14f879f24fac17869fc32ad2ce0e
Diff: https://reviews.apache.org/r/45290/diff/
Testing
---
`GTEST_FILTER="FilesTest.AuthenticationTest" bin/mesos-tests.sh
--gtest_repeat=1000 --gtest_break_on_failure=1` was used to test on OSX.
Thanks,
Greg Mann
> On March 24, 2016, 7:57 p.m., Greg Mann wrote:
> > src/cli/execute.cpp, line 215
> > <https://reviews.apache.org/r/43935/diff/3/?file=1309822#file1309822line215>
> >
> > s/sepcified/specified/
>
> Jian Qiu wrote:
> Sorry for the typo... plea
b3894954e32b14f879f24fac17869fc32ad2ce0e
Diff: https://reviews.apache.org/r/45290/diff/
Testing
---
`GTEST_FILTER="FilesTest.AuthenticationTest" bin/mesos-tests.sh
--gtest_repeat=1000 --gtest_break_on_failure=1` was used to test on OSX.
Thanks,
Greg Mann
failure=1` were
used to test on OSX and CentOS 7.
Thanks,
Greg Mann
> On March 20, 2016, 5:44 p.m., Greg Mann wrote:
> > Personally, I'm not convinced that this is a useful way to format our flag
> > documentation. I've been meaning to propose eliminating it from
> > 'configuration.md'. I think it's more confusing
b3894954e32b14f879f24fac17869fc32ad2ce0e
Diff: https://reviews.apache.org/r/45290/diff/
Testing
---
`GTEST_FILTER="FilesTest.AuthenticationTest" bin/mesos-tests.sh
--gtest_repeat=1000 --gtest_break_on_failure=1` was used to test on OSX.
Thanks,
Greg Mann
est_repeat=1000 --gtest_break_on_failure=1` were
used to test on OSX and CentOS 7.
Thanks,
Greg Mann
Testing
---
`../configure --enable-libevent --enable-ssl && make check` was used to text on
OSX.
Thanks,
Greg Mann
423b0c5a8a
3rdparty/libprocess/3rdparty/http-parser-2.6.1.patch PRE-CREATION
Diff: https://reviews.apache.org/r/45397/diff/
Testing
---
`../configure --enable-libevent --enable-ssl && make check` was used to text on
OSX.
Thanks,
Greg Mann
akefile.am
385302a491aba5a38ff74c0debfc2a423b0c5a8a
3rdparty/libprocess/3rdparty/http-parser-2.6.1.patch PRE-CREATION
Diff: https://reviews.apache.org/r/45397/diff/
Testing
---
`../configure --enable-libevent --enable-ssl && make check` was used to text on
OSX.
Thanks,
Greg Mann
generated e-mail. To reply, visit:
https://reviews.apache.org/r/45397/#review125745
---
On March 28, 2016, 9:18 p.m., Greg Mann wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.or
p;& make check` was used to text on
OSX.
Thanks,
Greg Mann
have a problem with this
> > conflict?
> >
> > Also, the real fix is for stout to namespace its flags (e.g.,
> > stout::flags) implementation instead of fixing the library. But I don't
> > know how big of a change is that.
>
> Greg Mann wrote:
>
3rdparty/libprocess/3rdparty/http-parser-2.6.1.patch PRE-CREATION
Diff: https://reviews.apache.org/r/45397/diff/
Testing
---
`../configure --enable-libevent --enable-ssl && make check` was used to text on
OSX.
Thanks,
Greg Mann
s/3rdparty/Makefile.am
385302a491aba5a38ff74c0debfc2a423b0c5a8a
3rdparty/libprocess/3rdparty/http-parser-2.6.1.patch PRE-CREATION
Diff: https://reviews.apache.org/r/45397/diff/
Testing
---
`../configure --enable-libevent --enable-ssl && make check` was used to text on
OSX.
Thanks,
Greg Mann
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45438/#review125932
---
Ship it!
Ship It!
- Greg Mann
On March 29, 2016, 6:45 p.m
abled, then we test that requests that
don't authenticate properly are refused when authentication is on. This should
test all of the code paths through the handlers, since we don't actually do
anything with the principal currently. What do you think?
- Greg Mann
On March 29, 2016,
, though it
does seem that RFC-7230 specifically prohibits whitespace in that location. I
wonder if a deprecation cycle is advisable for this change?
Also, it's not immediately clear to me: are we using http-parser in "strict"
mode?
- Greg Mann
On March 30, 2016, 5:35 a.m., Zh
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45434/#review126227
---
Ship it!
Ship It!
- Greg Mann
On March 30, 2016, 8:20 a.m
://reviews.apache.org/r/45563/diff/
Testing
---
Viewed with the Mesos website container:
https://github.com/mesosphere/mesos-website-container
Thanks,
Greg Mann
/r/45562/diff/
Testing
---
Viewed with the Mesos website container:
https://github.com/mesosphere/mesos-website-container
Thanks,
Greg Mann
/flags.cpp 0551ec334c6747507bf7bb068d27d67f3fdd6c83
Diff: https://reviews.apache.org/r/45562/diff/
Testing
---
Viewed with the Mesos website container:
https://github.com/mesosphere/mesos-website-container
Thanks,
Greg Mann
/flags.cpp 0551ec334c6747507bf7bb068d27d67f3fdd6c83
Diff: https://reviews.apache.org/r/45562/diff/
Testing
---
Viewed with the Mesos website container:
https://github.com/mesosphere/mesos-website-container
Thanks,
Greg Mann
99c8e7656dc2a2f54a309d4a369e73ca2ab2f4dd
Diff: https://reviews.apache.org/r/45804/diff/
Testing
---
Used `support/test-upgrade.py --prev="/path/to/0.27.2"
--next="/path/to/0.28.1-rc2"` to test.
Thanks,
Greg Mann
b60c3
src/tests/containerizer/mesos_containerizer_tests.cpp
09742ff21513dc2570684d384b257868dd57a9ce
Diff: https://reviews.apache.org/r/46003/diff/
Testing
---
`sudo make check`
Thanks,
Greg Mann
hanks,
Greg Mann
d8
src/tests/status_update_manager_tests.cpp
f5313a124c59eba3da86a173817d0c2a6a943e17
Diff: https://reviews.apache.org/r/46005/diff/
Testing
---
`sudo make check`
Thanks,
Greg Mann
38b8344c
Diff: https://reviews.apache.org/r/46004/diff/
Testing
---
`sudo make check`
Thanks,
Greg Mann
/45562/diff/
Testing
---
Viewed with the Mesos website container:
https://github.com/mesosphere/mesos-website-container
Thanks,
Greg Mann
tically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45562/#review126474
-------
On April 11, 2016, 4:38 p.m., Greg Mann wrote:
>
> ---
> This is an automat
the Mesos website container:
https://github.com/mesosphere/mesos-website-container
Thanks,
Greg Mann
5ae7ede3f500380a78364d5c3da2c4cea75e04c5
Diff: https://reviews.apache.org/r/45563/diff/
Testing
---
Viewed with the Mesos website container:
https://github.com/mesosphere/mesos-website-container
Thanks,
Greg Mann
/diff/
Testing (updated)
---
Viewed with the Mesos website container:
https://github.com/mesosphere/mesos-website-container
Thanks,
Greg Mann
aster/flags.cpp e522499586b731d522180f171731a9dd38b8344c
Diff: https://reviews.apache.org/r/46004/diff/
Testing
---
`sudo make check`
Thanks,
Greg Mann
://github.com/mesosphere/mesos-website-container
Thanks,
Greg Mann
5ae7ede3f500380a78364d5c3da2c4cea75e04c5
Diff: https://reviews.apache.org/r/46038/diff/
Testing
---
Viewed with the Mesos website container:
https://github.com/mesosphere/mesos-website-container
Thanks,
Greg Mann
hanks,
Greg Mann
overy_tests.cpp 79132344be3bcd2bda54357cd5e7e0c59a766fd8
src/tests/status_update_manager_tests.cpp
f5313a124c59eba3da86a173817d0c2a6a943e17
Diff: https://reviews.apache.org/r/46005/diff/
Testing
---
`sudo make check`
Thanks,
Greg Mann
/diff/
Testing
---
Viewed with the Mesos website container:
https://github.com/mesosphere/mesos-website-container
Thanks,
Greg Mann
---
Made use of random container IDs in tests.
Diffs
-
src/tests/containerizer/mesos_containerizer_tests.cpp
09742ff21513dc2570684d384b257868dd57a9ce
Diff: https://reviews.apache.org/r/46104/diff/
Testing
---
`sudo make check`
Thanks,
Greg Mann
sudo make check`
Thanks,
Greg Mann
/diff/
Testing
---
`sudo make check`
Thanks,
Greg Mann
nvironment` (the class defined in environment.hpp).
Adding this explicit namespace resolves the ambiguity.
- Greg
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46003/#review128278
-
://reviews.apache.org/r/46104/diff/
Testing
---
`sudo make check`
Thanks,
Greg Mann
aster/flags.cpp e522499586b731d522180f171731a9dd38b8344c
Diff: https://reviews.apache.org/r/46004/diff/
Testing
---
`sudo make check`
Thanks,
Greg Mann
://github.com/mesosphere/mesos-website-container
Thanks,
Greg Mann
dation.cpp (lines 79 - 81)
<https://reviews.apache.org/r/46115/#comment192358>
What about: `if (principal.isSome() && frameworkInfo.has_principal() &&
principal != frameworkInfo.principal())`?
- Greg Mann
On
x27; about authenticating HTTP
frameworks as well?
- Greg Mann
On April 14, 2016, 3:34 p.m., Anand Mazumdar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revi
.apache.org/r/46211/#comment192372>
This can be moved into the `if (flags.authenticate_http_frameworks)` scope,
as well as the above declaration of `httpFrameworkAuthenticator`.
- Greg Mann
On April 14, 2016, 3:34 p.m., Anand Mazumdar wrote:
>
> -
(line 30)
<https://reviews.apache.org/r/45270/#comment192422>
s/and not configurable/and is not configurable/
- Greg Mann
On April 14, 2016, 4:41 a.m., Guangya Liu wrote:
>
> ---
> This is an automatically generated e
> On April 14, 2016, 8:17 p.m., Greg Mann wrote:
> >
Could you fix the typo in the commit message: "protobut" should be "protobuf".
Also, could you remove the duplicate Summary that's in the Description field,
and add a more verbose description of the patch
src/tests/master_validation_tests.cpp
8a5bf9477596f13b2fb3a1348337ad2fe53a034d
src/tests/reservation_endpoints_tests.cpp
f014290ed9f279df4c774aeb7ce7bd38fd1cc854
Diff: https://reviews.apache.org/r/46242/diff/
Testing
---
`sudo make check`
Thanks,
Greg Mann
://reviews.apache.org/r/46242/diff/
Testing
---
`sudo make check`
Thanks,
Greg Mann
/process/gtest.hpp
3e0887257e1484813b3547170a5a1b9bb89de0d2
3rdparty/libprocess/src/tests/main.cpp
78858a2b84a439d8f8a60ec8bcb6ac3a308087a6
Diff: https://reviews.apache.org/r/46254/diff/
Testing
---
`sudo make check` on OSX.
Thanks,
Greg Mann
: https://reviews.apache.org/r/46242/diff/
Testing
---
`sudo make check`
Thanks,
Greg Mann
---
`sudo make check` on OSX.
Thanks,
Greg Mann
n.cpp 70df4f384b09a1fb078cd893efe52a5e3b116f48
src/tests/main.cpp 142585096493a334ac9ac0df511ae0fc10798040
src/tests/mesos.hpp 20370a277d55efeea8daae7ea5e2f6575b5a2d62
Diff: https://reviews.apache.org/r/46255/diff/
Testing
---
`sudo make check` on OSX.
Thanks,
Greg Mann
3rdparty/libprocess/src/logging.cpp bdbf716ee46a459f1004f0f4b72c23aae135f347
3rdparty/libprocess/src/process.cpp 5e9dcfdc52f3a8223bc43af149b8e1f5dbdf5b0a
Diff: https://reviews.apache.org/r/46258/diff/
Testing
---
`sudo make check` on OSX.
Thanks,
Greg Mann
3rdparty/libprocess/src/metrics/metrics.cpp
7677dffed98153bc6276aad492a6815e67740ea3
3rdparty/libprocess/src/process.cpp 5e9dcfdc52f3a8223bc43af149b8e1f5dbdf5b0a
Diff: https://reviews.apache.org/r/46259/diff/
Testing
---
`sudo make check` on OSX
Thanks,
Greg Mann
Diff: https://reviews.apache.org/r/46260/diff/
Testing
---
`sudo make check` on OSX.
Thanks,
Greg Mann
Diff: https://reviews.apache.org/r/46261/diff/
Testing
---
`sudo make check` on OSX.
Thanks,
Greg Mann
/metrics_tests.cpp eacff678d06da7ba8afee6ab68261968561dffc3
Diff: https://reviews.apache.org/r/46261/diff/
Testing
---
`sudo make check` on OSX.
Thanks,
Greg Mann
/
Testing
---
`sudo make check` on OSX.
Thanks,
Greg Mann
ly, visit:
https://reviews.apache.org/r/46260/#review129098
---
On April 15, 2016, 6:58 a.m., Greg Mann wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46260/
>
sting
---
`sudo make check` on OSX.
Thanks,
Greg Mann
5e9dcfdc52f3a8223bc43af149b8e1f5dbdf5b0a
3rdparty/libprocess/src/tests/main.cpp
78858a2b84a439d8f8a60ec8bcb6ac3a308087a6
Diff: https://reviews.apache.org/r/46254/diff/
Testing
---
`sudo make check` on OSX.
Thanks,
Greg Mann
tion/lifetime issue, but you said "multiple problems" so
let me know what you think :-)
- Greg
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46254/#review129091
-----
-
>
> The tests `MetricsTest.AgentAuthenticationEnabled` and
> `MetricsTest.MasterAuthenticationEnabled` are added in
> this patch.
>
>
> Diffs
> -
>
> src/tests/metrics_tests.cpp eacff678d06da7ba8afee6ab68261968561dffc3
>
> Diff: https://reviews.apache.org/r/46261/diff/
>
>
> Testing
> ---
>
> `sudo make check` on OSX.
>
>
> Thanks,
>
> Greg Mann
>
>
eviews.apache.org/r/46262/#review129105
---
On April 15, 2016, 7:01 a.m., Greg Mann wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46262/
> ---
5e9dcfdc52f3a8223bc43af149b8e1f5dbdf5b0a
3rdparty/libprocess/src/tests/main.cpp
78858a2b84a439d8f8a60ec8bcb6ac3a308087a6
Diff: https://reviews.apache.org/r/46254/diff/
Testing
---
`sudo make check` on OSX.
Thanks,
Greg Mann
src/slave/main.cpp 70df4f384b09a1fb078cd893efe52a5e3b116f48
src/tests/main.cpp 142585096493a334ac9ac0df511ae0fc10798040
src/tests/mesos.hpp 20370a277d55efeea8daae7ea5e2f6575b5a2d62
Diff: https://reviews.apache.org/r/46255/diff/
Testing
---
`sudo make check` on OSX.
Thanks,
Greg Mann
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46401/#review129590
---
Ship it!
Ship It!
- Greg Mann
On April 19, 2016, 6:38 p.m
ple, I could use {offset =
-1024; length = 1024} to read the last 1024 bytes of the file.
- Greg Mann
On April 19, 2016, 8:07 a.m., zhou xing wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http
/
Testing
---
`sudo make check`
Thanks,
Greg Mann
check`
Thanks,
Greg Mann
/libprocess/3rdparty/gperftools-2.5.tar.gz PRE-CREATION
3rdparty/libprocess/3rdparty/versions.am 5506eb3
3rdparty/libprocess/configure.ac d27e46e
3rdparty/libprocess/src/profiler.cpp 58cf2fe
Diff: https://reviews.apache.org/r/46461/diff/
Testing
---
`sudo make check`
Thanks,
Greg Mann
://reviews.apache.org/r/46462/diff/
Testing
---
`sudo make check`
Thanks,
Greg Mann
5e9dcfdc52f3a8223bc43af149b8e1f5dbdf5b0a
3rdparty/libprocess/src/tests/main.cpp
78858a2b84a439d8f8a60ec8bcb6ac3a308087a6
Diff: https://reviews.apache.org/r/46254/diff/
Testing
---
`sudo make check` on OSX.
Thanks,
Greg Mann
rocess.cpp 8727eb202e9699f0ac3c95788257cf1a22b0da7b
3rdparty/libprocess/src/profiler.cpp 58cf2fec119e65a74a3c75561ba0866ec88897d0
Diff: https://reviews.apache.org/r/46497/diff/
Testing
---
`sudo make check` on OSX.
Thanks,
Greg Mann
/metrics_tests.cpp eacff678d06da7ba8afee6ab68261968561dffc3
Diff: https://reviews.apache.org/r/46261/diff/
Testing
---
`sudo make check` on OSX.
Thanks,
Greg Mann
5e9dcfdc52f3a8223bc43af149b8e1f5dbdf5b0a
3rdparty/libprocess/src/tests/main.cpp
78858a2b84a439d8f8a60ec8bcb6ac3a308087a6
Diff: https://reviews.apache.org/r/46254/diff/
Testing
---
`sudo make check` on OSX.
Thanks,
Greg Mann
libprocess is
initialized.
Diffs
-
Diff: https://reviews.apache.org/r/46256/diff/
Testing
---
`sudo make check` on OSX.
Thanks,
Greg Mann
/3rdparty/gperftools-2.5.tar.gz PRE-CREATION
3rdparty/libprocess/3rdparty/versions.am 5506eb3
3rdparty/libprocess/configure.ac d27e46e
3rdparty/libprocess/src/profiler.cpp 58cf2fe
Diff: https://reviews.apache.org/r/46461/diff/
Testing
---
`sudo make check`
Thanks,
Greg Mann
80c6d
src/slave/main.cpp 38bd00584dd9c6a872398678b2288edeed1cd2a4
src/tests/main.cpp 142585096493a334ac9ac0df511ae0fc10798040
src/tests/mesos.hpp e4b63d41d883807ac39846799468b80e88c84e0b
Diff: https://reviews.apache.org/r/46255/diff/
Testing
---
`sudo make check` on OSX.
Thanks,
://reviews.apache.org/r/34318/diff/
Testing
---
make check
Thanks,
Greg Mann
Thanks,
Greg Mann
501 - 600 of 3738 matches
Mail list logo
