Description
---
Fixed typo in subprocess.hpp.
Diffs
-
3rdparty/libprocess/include/process/subprocess.hpp
8a3fe5526f480187441a8aee2c72636bec3e2b2d
Diff: https://reviews.apache.org/r/45874/diff/
Testing
---
Thanks,
Joerg Schad
On March 31, 2016, 10:21 a.m., Joerg Schad wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45492/
> --
yours, still: This feels a little off as it must only exist in the
whitelist if there is a whitelist specified.
- Joerg Schad
On April 7, 2016, 10:50 a.m., Alexander Rukletsov wrote:
>
> ---
> This is an automatically genera
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45767/#review127302
---
Ship it!
Thanks!
- Joerg Schad
On April 5, 2016, 7:48 p.m
port/docker_build.sh (line 91)
<https://reviews.apache.org/r/45668/#comment189908>
Why is this needed here?
- Joerg Schad
On April 4, 2016, 6:54 a.m., Juan Larriba wrote:
>
> ---
> This is an automaticall
Thanks,
Joerg Schad
(updated)
---
None: Not a functional change.
Thanks,
Joerg Schad
tps://reviews.apache.org/r/45562/#comment189467>
Not yours but why isn't that flag in the common master/agent section above?
docs/configuration.md (line 361)
<https://reviews.apache.org/r/45562/#comment189470>
are *only* suitable for short-term?
- Joerg Schad
On Mar
Rukletsov.
Repository: mesos
Description (updated)
---
See summary.
Diffs
-
site/source/community/user-groups.html.md
bf072cd47473dffb38c2f7a159d169db9287133a
Diff: https://reviews.apache.org/r/45539/diff/
Testing (updated)
---
None: not a functional change.
Thanks,
Joerg
Rukletsov.
Repository: mesos
Description
---
Added Hamburg Mesos User Group to community page.
Diffs
-
site/source/community/user-groups.html.md
bf072cd47473dffb38c2f7a159d169db9287133a
Diff: https://reviews.apache.org/r/45539/diff/
Testing
---
Thanks,
Joerg Schad
3e36f2f7ab89b98de2c1a971e4ecca58c13ad642
src/tests/containerizer/ns_tests.cpp cd668ebb3b9461bee00dc338c288e5df6eb8fe31
Diff: https://reviews.apache.org/r/45495/diff/
Testing
---
sudo make check
../configure --with-network-isolator
make check
Thanks,
Joerg Schad
8a3fe5526f480187441a8aee2c72636bec3e2b2d
3rdparty/libprocess/src/subprocess.cpp
bb0fcbcd0dfa455c8700247c5b4ca0473fd163c3
Diff: https://reviews.apache.org/r/45494/diff/
Testing
---
Tested entire chain see https://reviews.apache.org/r/45495/.
Thanks,
Joerg Schad
/libprocess/src/subprocess.cpp
bb0fcbcd0dfa455c8700247c5b4ca0473fd163c3
Diff: https://reviews.apache.org/r/45493/diff/
Testing
---
Tested entire chain see https://reviews.apache.org/r/45495/.
Thanks,
Joerg Schad
e062daa9fcfc776144b48325daa1f1284c5e59a4
src/tests/slave_tests.cpp 57fc50360eae85819ae6ce714b0c3c4c1867b2b8
Diff: https://reviews.apache.org/r/45492/diff/
Testing
---
Tested entire chain see https://reviews.apache.org/r/45495/.
Thanks,
Joerg Schad
---
Tested entire chain see https://reviews.apache.org/r/45495/.
Thanks,
Joerg Schad
Description
---
Fixed typo in stout.
Diffs
-
3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/fork.hpp
a6e676766be527af48846a7ae6842c5b1465e501
Diff: https://reviews.apache.org/r/45477/diff/
Testing
---
Thanks,
Joerg Schad
dd77793b0a289ebffecfdddf2cd881b4659d637c
Diff: https://reviews.apache.org/r/45476/diff/
Testing
---
Thanks,
Joerg Schad
ttps://reviews.apache.org/r/45475/.
- Joerg
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45231/#review126031
---
On March 28, 2
---
Fixed typos in isolator test comments.
Diffs
-
src/tests/containerizer/isolator_tests.cpp
4dde7292831dd6eab5da1c511a55a34e3bb5a96f
Diff: https://reviews.apache.org/r/45475/diff/
Testing
---
Thanks,
Joerg Schad
---
Moved realm initialization from constructor to initializer list.
Diffs
-
src/files/files.cpp a8b27518bd50b951cc1a6dc077ac21eba07376cd
Diff: https://reviews.apache.org/r/45438/diff/
Testing
---
sudo make check
Thanks,
Joerg Schad
/ee8a6b5a92e71d6bf704
Thanks,
Joerg Schad
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44333/#review125863
---
Ship it!
Ship It!
- Joerg Schad
On March 3, 2016, 1 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45424/#review125857
---
Ship it!
Ship It!
- Joerg Schad
On March 29, 2016, 11:49
://reviews.apache.org/r/45423/diff/
Testing
---
Viewed as gist: https://gist.github.com/joerg84/ee8a6b5a92e71d6bf704
Thanks,
Joerg Schad
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45399/#review125818
---
On March 28, 2016, 9:41 p.m., Joerg Schad wrote:
>
> ---
/browse/MESOS-5049
Repository: mesos
Description
---
Fixed typo in subprocess doxygen comments.
Diffs
-
3rdparty/libprocess/include/process/subprocess.hpp
da806640a238e168bd24ea837cbb711041fe1d12
Diff: https://reviews.apache.org/r/45401/diff/
Testing
---
Thanks,
Joerg
: https://reviews.apache.org/r/45399/diff/
Testing
---
sudo make check
Thanks,
Joerg Schad
de4b6f99f3a994bcedafa801eed9c4a7b79bac23
Diff: https://reviews.apache.org/r/45400/diff/
Testing
---
sudo make check on with port_isolator enabled.
Thanks,
Joerg Schad
tches are committed,
> > because port_mapping.cpp passes flags but no setsid to subprocess(), this
> > is not allowed by C++.
>
> Joerg Schad wrote:
> Thx for catching: Fixed with https://reviews.apache.org/r/45400/
A
https://reviews.apache.org/r/45232/#review125676
-------
On March 28, 2016, 4:52 p.m., Joerg Schad wrote:
>
> ---
> This is an automatically generated e-m
ally generated e-mail. To reply, visit:
https://reviews.apache.org/r/45230/#review125677
-------
On March 28, 2016, 4:51 p.m., Joerg Schad wrote:
>
> ---
> This is an au
b38d83fbb29f46552ffbda7b17cbc85af15550e1
Diff: https://reviews.apache.org/r/45245/diff/
Testing
---
sudo make check linux/OSX
Thanks,
Joerg Schad
/isolator_tests.cpp
df506fc793e480e825b476e43c683ef8bcf676b2
Diff: https://reviews.apache.org/r/45236/diff/
Testing
---
sudo make check on Linux and OSX.
Thanks,
Joerg Schad
/containerizer/launcher.hpp 36405a97893f352147af4794fb39b6e621d95b58
src/tests/containerizer/launcher.cpp a92d9890f0931425d69ef8ce0896d081b8722079
Diff: https://reviews.apache.org/r/45235/diff/
Testing
---
Tested complete chain (see https://reviews.apache.org/r/45236/).
Thanks,
Joerg
1c113a2b3f57877e132bbd65e01fb2f045132128
Diff: https://reviews.apache.org/r/45233/diff/
Testing
---
Tested entire chain (see https://reviews.apache.org/r/45236/).
Thanks,
Joerg Schad
://reviews.apache.org/r/45231/diff/
Testing
---
tested complete chain (see https://reviews.apache.org/r/45236/).
Thanks,
Joerg Schad
rg/r/45236/).
Thanks,
Joerg Schad
/
Testing
---
tested entire chain (see https://reviews.apache.org/r/45236/).
Thanks,
Joerg Schad
apache.org/r/45236/).
Thanks,
Joerg Schad
(see https://reviews.apache.org/r/45236/).
Thanks,
Joerg Schad
/containerizer/isolator_tests.cpp
df506fc793e480e825b476e43c683ef8bcf676b2
Diff: https://reviews.apache.org/r/45236/diff/
Testing
---
sudo make check on Linux and OSX.
Thanks,
Joerg Schad
/tests/containerizer/isolator_tests.cpp
df506fc793e480e825b476e43c683ef8bcf676b2
Diff: https://reviews.apache.org/r/45236/diff/
Testing
---
sudo make check on Linux and OSX.
Thanks,
Joerg Schad
---
src/slave/containerizer/mesos/isolators/posix/disk.cpp
b38d83fbb29f46552ffbda7b17cbc85af15550e1
Diff: https://reviews.apache.org/r/45245/diff/
Testing
---
sudo make check linux/OSX
Thanks,
Joerg Schad
patter of a parentHook.
Diffs (updated)
-
src/tests/containerizer/isolator_tests.cpp
df506fc793e480e825b476e43c683ef8bcf676b2
Diff: https://reviews.apache.org/r/45236/diff/
Testing
---
sudo make check on Linux and OSX.
Thanks,
Joerg Schad
chain (see https://reviews.apache.org/r/45236/).
Thanks,
Joerg Schad
anymore.
Diffs (updated)
-
src/linux/perf.cpp 1c113a2b3f57877e132bbd65e01fb2f045132128
Diff: https://reviews.apache.org/r/45233/diff/
Testing
---
Tested entire chain (see https://reviews.apache.org/r/45236/).
Thanks,
Joerg Schad
ache.org/r/45236/).
Thanks,
Joerg Schad
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45232/#review125521
-------
On March 28, 2016, 11:57 a.m., Joerg Schad wrote:
>
> -
.
Thanks,
Joerg Schad
rocess.cpp
b99bad04f7251169df3bfcec5dee459977440997
3rdparty/libprocess/src/tests/subprocess_tests.cpp
09e46eb1ce10a6c38cc364077f0b5952579d46e7
Diff: https://reviews.apache.org/r/45232/diff/
Testing
---
Tested complete chain (see https://reviews.apache.org/r/45236/).
Thanks,
Joerg Schad
src/tests/slave_tests.cpp 1f1a31020096efa5db698e86ac74e61dfdb4b94a
Diff: https://reviews.apache.org/r/45231/diff/
Testing
---
tested complete chain (see https://reviews.apache.org/r/45236/).
Thanks,
Joerg Schad
/45230/diff/
Testing
---
tested entire chain (see https://reviews.apache.org/r/45236/).
Thanks,
Joerg Schad
---
tested entire chain (see https://reviews.apache.org/r/45236/).
Thanks,
Joerg Schad
: https://reviews.apache.org/r/45037/diff/
Testing
---
Viewed rendered page via docker website container.
Thanks,
Joerg Schad
701805e2ffac5604eef155befR59
- Joerg
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45037/#review124526
---
On March
enerated e-mail. To reply, visit:
https://reviews.apache.org/r/45036/#review124525
-------
On March 21, 2016, 10:22 a.m., Joerg Schad wrote:
>
> ---
> This
538979977e07b484956be85b08b0dbc6cffcef01
docs/endpoints/master/flags.md e9038fece0d17432f839c1719beac65d1a351550
src/master/http.cpp bfea8fa811c24d37b2d7a8109728e1f40217e02f
Diff: https://reviews.apache.org/r/45204/diff/
Testing
---
Viewed endpoint help and viewed generated docs.
Thanks,
Joerg Schad
iew124452
---
On March 19, 2016, 11:51 a.m., Joerg Schad wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/450
> On March 19, 2016, 10:49 a.m., Joerg Schad wrote:
> > docs/configuration.md, line 1274
> > <https://reviews.apache.org/r/44554/diff/7/?file=1306425#file1306425line1274>
> >
> > dito.
>
> Greg Mann wrote:
> Since the master's flag is &#x
-website generator.
Thanks,
Joerg Schad
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44766/#review123377
-------
On March 17, 2016, 11:55 a.m., Joerg Schad wrote:
>
>
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44767/#review123522
-------
On March 17, 2016, 11:57 a.m., Joerg Schad wrote:
>
> --
g/r/44553/#comment186659>
Where is this coming from? I would expect this in slave/constants.hpp
similar as for the master
I am probably missing something here... :-)
- Joerg Schad
On March 17, 2016, 10:56 p.m., Greg Mann
ent186487>
Stupid question: Why makes this basic?
src/tests/http_authentication_tests.cpp (line 103)
<https://reviews.apache.org/r/44678/#comment186486>
Does it maybe make sense to create a helper function for this?
- Joerg Schad
On March 17, 2016, 7:39 p.m
)
-
src/master/http.cpp b47ab7cc86c0a56a81815a98bd63f37a1175ba7f
Diff: https://reviews.apache.org/r/44767/diff/
Testing
---
Viewed master endpoint help in browser.
Thanks,
Joerg Schad
s.apache.org/r/44846/#comment186399>
We now mention deprecated twice here.
The 'Note that' also seems to be out of sync with the configuration.md.
- Joerg Schad
On March 15, 2016, 2:01 p.m., Jan Schlicht wrote:
>
> -
> On March 19, 2016, 10:49 a.m., Joerg Schad wrote:
> > docs/authentication.md, line 45
> > <https://reviews.apache.org/r/44554/diff/7/?file=1306424#file1306424line45>
> >
> > Does it make to create a 'Master and Slave Options' section similar to
website container
Thanks,
Joerg Schad
interested in your opinion first.
- Joerg Schad
On March 18, 2016, 6:32 p.m., Greg Mann wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://rev
> On March 19, 2016, 10:49 a.m., Joerg Schad wrote:
> > docs/authentication.md, line 45
> > <https://reviews.apache.org/r/44554/diff/7/?file=1306424#file1306424line45>
> >
> > Does it make to create a 'Master and Slave Options' section similar to
> > just before you start calling StartSlave() in the loop
>
> Joerg Schad wrote:
> I agree with you, but actually we follow this pattern in many other tests
> as well.
> E.g.
> // This test ensures that allocation is done per slave. This is done
> // by hav
This flag should also move to the shared "Master and Slave Options" section
instead of duplicating it.
docs/configuration.md (line 1274)
<https://reviews.apache.org/r/44554/#comment186934>
dito.
- Joerg Schad
On March 18, 2016, 7:30 p.m., Greg Mann wrote:
>
> ---
tps://reviews.apache.org/r/44553/#comment186927>
could just be my taste, but I would group the two invalid (and respectively
the two non-authenticated ones below) into one scope.
This also matches the comment much better.
- Joerg Schad
On March 18, 2016, 7:16 p.m., Greg Mann
ck::settle() here?
- Joerg Schad
On March 18, 2016, 6:55 p.m., Greg Mann wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44523/#review124394
---
Ship it!
Ship It!
- Joerg Schad
On March 17, 2016, 7:42 p.m
ter/agent authentication
- Joerg Schad
On March 18, 2016, 6:32 p.m., Greg Mann wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44515/
> --
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44703/#review124391
---
Ship it!
- Joerg Schad
On March 18, 2016, 6:13 p.m., Greg
.
Thanks,
Joerg Schad
Diff: https://reviews.apache.org/r/45037/diff/
Testing
---
Viewed rendered page via docker website container.
Thanks,
Joerg Schad
783304e2fc78db70f1a5fccbf5e96fcc76a88fd8
3rdparty/libprocess/src/help.cpp 5f368801affecacb0d1daaeb6ccf5895ccb231d2
3rdparty/libprocess/src/logging.cpp 015a43db77fd7015aeee0c45fa10c292f3e9cf58
Diff: https://reviews.apache.org/r/44766/diff/
Testing
---
Viewed master endpoint help in browser.
Thanks,
Joerg Schad
mail. To reply, visit:
> https://reviews.apache.org/r/44989/
> ---
>
> (Updated March 18, 2016, 9:48 a.m.)
>
>
> Review request for mesos, Adam B and Joerg Schad.
>
>
> Bugs: MESOS-4849
> https://
master endpoint help in browser.
Thanks,
Joerg Schad
tps://reviews.apache.org/r/45039/#comment186745>
Can you also update
https://github.com/apache/mesos/blob/master/docs/app-framework-development-guide.md
- Joerg Schad
On March 18, 2016, 5:13 p.m., Alexander Rukletsov wrote:
>
> ---
> On March 18, 2016, 3:47 p.m., Joerg Schad wrote:
> > src/slave/slave.cpp, line 677
> > <https://reviews.apache.org/r/44553/diff/7/?file=1302924#file1302924line677>
> >
> > Where is this coming from? I would expect this in slave/constants.h
b47ab7cc86c0a56a81815a98bd63f37a1175ba7f
Diff: https://reviews.apache.org/r/44767/diff/
Testing
---
Viewed master endpoint help in browser.
Thanks,
Joerg Schad
e059d8d888343c5036346f7a615f04375f44f517
docs/endpoints/master/weights.md 632be242d85fbd61ded62d846e385009a321533c
Diff: https://reviews.apache.org/r/44954/diff/
Testing
---
viewed docs with docker-website generator.
Thanks,
Joerg Schad
Description
---
Removed superfluous blank line in slave/http.cpp.
Diffs
-
src/slave/http.cpp 4eb1fafdfa72094511b0b2684a3c2705bd8c7c5e
Diff: https://reviews.apache.org/r/45034/diff/
Testing
---
Thanks,
Joerg Schad
,
Joerg Schad
/master/unreserve.md e059d8d888343c5036346f7a615f04375f44f517
docs/endpoints/master/weights.md 632be242d85fbd61ded62d846e385009a321533c
Diff: https://reviews.apache.org/r/44954/diff/
Testing
---
viewed docs with docker-website generator.
Thanks,
Joerg Schad
553/#comment186636>
FYI: Noticed this incorrect blank line while reviewing, removed it with
https://reviews.apache.org/r/45034/.
- Joerg Schad
On March 17, 2016, 10:56 p.m., Greg Mann wrote:
>
> ---
> This is an automati
rakescript (and
potentially also github as both sometimes differ)? THX
- Joerg Schad
On March 15, 2016, 1:22 p.m., Alexander Rukletsov wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://review
> On March 15, 2016, 12:40 p.m., Guangya Liu wrote:
> > The configuration.md
> > https://github.com/apache/mesos/blob/master/docs/configuration.md should
> > also be updated.
>
> Joerg Schad wrote:
> see my 2nd comment above :-).
>
> Guangya Liu wrote
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44846/
> ---
>
> (Updated March 15, 2016, 11:36 a.m.)
>
>
> Review request for mesos, Adam B and Joerg Schad.
>
>
?
src/slave/flags.cpp (line 432)
<https://reviews.apache.org/r/44846/#comment185871>
or (deprecated)
src/slave/flags.cpp (line 434)
<https://reviews.apache.org/r/44846/#comment185872>
see above.
- Joerg Schad
On Marc
configuration.md.
:-)
- Joerg Schad
On March 15, 2016, 11:36 a.m., Jan Schlicht wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44846/#review123639
---
Can you also add this upgrades.md?
- Joerg Schad
On March 15
> On March 10, 2016, 5:56 p.m., Joerg Schad wrote:
> > src/launcher/executor.cpp, line 124
> > <https://reviews.apache.org/r/44652/diff/1/?file=1294474#file1294474line124>
> >
> > Not sure whether we have a real style for that, but the example I seen
> &g
--
>
> (Updated March 14, 2016, 5:45 p.m.)
>
>
> Review request for mesos, Ben Mahler and Joerg Schad.
>
>
> Repository: mesos
>
>
> Description
> ---
>
> See summary.
>
>
> Diffs
&
> On March 15, 2016, 10:33 a.m., Joerg Schad wrote:
> > src/slave/flags.cpp, line 682
> > <https://reviews.apache.org/r/44515/diff/8/?file=1296989#file1296989line682>
> >
> > As we are actively deprecated the old text based format with Mesos-228,
> >
g/r/44515/#comment185858>
As we are actively deprecated the old text based format with Mesos-228,
does it make sense to only document the new json format here?
- Joerg Schad
On March 14, 2016, 4:17 a.m., Greg Mann wrote:
>
> -
401 - 500 of 1143 matches
Mail list logo
